March 2010 - cal10n-dev - mailman3.qos.ch

[JIRA] Created: (CAL-8) MessageConveyer.lookup() uses wrong classloader
by Pete Muir (JIRA) 25 Aug '10

25 Aug '10

MessageConveyer.lookup() uses wrong classloader ----------------------------------------------- Key: CAL-8 URL: http://jira.qos.ch/browse/CAL-8 Project: CAL10N Issue Type: Bug Environment: cal10n 0.7 Reporter: Pete Muir Assignee: Ceki Gulcu MessageConveyer uses this.getClass().getClassLoader() as the classloader to use to search for resource bundles. If you wish to install cal10n as a installed library in an application server (or in any case where the cal10n jar is placed on a parent classlaoder), the classloader of the classes using cal10n may not be searched for resource bundles. I would suggest using declaredClass.getClassLoader(). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

3 3

[JIRA] Created: (CAL-14) Performance etc improvements
by Rick Beton (JIRA) 05 Jul '10

05 Jul '10

Performance etc improvements ---------------------------- Key: CAL-14 URL: http://jira.qos.ch/browse/CAL-14 Project: CAL10N Issue Type: Improvement Environment: Cal10N 0.7.2 pulled from Git Reporter: Rick Beton Assignee: Ceki Gulcu Priority: Minor I have been reading through the Cal10n code, which I cloned from Git so as to get the most up to date. I'd like to offer a patch file containing some suggested changes - see attached. * some javadoc alterations * more fields are private * some fields are final to distinguish them from 'accumulator' variables (this shows my functional programming tendencies!) * CAL10NResourceBundle hasChanged method now computes the periodicity correctly * CAL10NResourceBundle has new getMap() method to remove the assumption that there is only one parent level. * performance penalty for loading MessageConveyor instances can be reduced -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 2

[JIRA] Created: (CAL-13) Single quote causes bad parsing
by Gilles (JIRA) 05 Jul '10

05 Jul '10

Single quote causes bad parsing ------------------------------- Key: CAL-13 URL: http://jira.qos.ch/browse/CAL-13 Project: CAL10N Issue Type: Bug Reporter: Gilles Assignee: Ceki Gulcu When in a "properties" file containing the localized message patterns, there is a single quote in a pattern, it doesn't appear in the output and prevents the conversion of the curly-braced variables that follow it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 4

[JIRA] Created: (CAL-10) Check all enum's in a package
by Pete Muir (JIRA) 05 Jul '10

05 Jul '10

Check all enum's in a package ----------------------------- Key: CAL-10 URL: http://jira.qos.ch/browse/CAL-10 Project: CAL10N Issue Type: New Feature Reporter: Pete Muir Assignee: Ceki Gulcu It would be nice to be able to do: <enumTypes>  <enumType>org.jboss.weld.messages.*</enumType> and have all enum's in the package annotated @BaseName validated -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 1

[JIRA] Created: (CAL-12) Interface IMessageConveyor should be called MessageConveyor and the class MessageConveyor should be called DefaultMessageConveyor
by Geoffrey De Smet (JIRA) 02 Jul '10

02 Jul '10

Interface IMessageConveyor should be called MessageConveyor and the class MessageConveyor should be called DefaultMessageConveyor ---------------------------------------------------------------------------------------------------------------------------------- Key: CAL-12 URL: http://jira.qos.ch/browse/CAL-12 Project: CAL10N Issue Type: Improvement Reporter: Geoffrey De Smet Assignee: Ceki Gulcu So it follows the JDK, JRE coding conventions, as well as most open source projects out there (especially Java projects). It also allows you to design an AbstractMessageConveyor in between, so you can tell people to extend that instead of directly implementing the public interface. That allows you to add extra methods to the interface in future versions and provide a dummy implementation in AbstractMessageConveyor. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 1

[JIRA] Created: (CAL-11) please add util package as exported package to MANIFEST.MF
by ekkehard gentz (JIRA) 02 Jul '10

02 Jul '10

please add util package as exported package to MANIFEST.MF ---------------------------------------------------------- Key: CAL-11 URL: http://jira.qos.ch/browse/CAL-11 Project: CAL10N Issue Type: Improvement Environment: OSGI Reporter: ekkehard gentz Assignee: Ceki Gulcu please add also the package ch.qos.cal10n.util as exported package. I need access to some classes of this package for my OSGI implementation of CAL10N thx ekke -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 1

MessageConveyor caching
by Rick Beton 16 Mar '10

16 Mar '10

Hi all, It occurred to me that there is a performance penalty for loading MessageConveyor instances which can be mitigated with an extra cache like this public class MessageConveyor implements IMessageConveyor { private static final Map<Locale, MessageConveyor> INSTANCES = new ConcurrentHashMap<Locale, MessageConveyor>(); private final Locale locale; final Map<String, CAL10NResourceBundle> cache = new ConcurrentHashMap<String, CAL10NResourceBundle>(); /** * Constructs an instance with a {@link Locale} associated with this * instance. * * @param locale * required locale */ MessageConveyor(Locale locale) { this.locale = locale; } /** * Gets a cached instance associated with a particular {@link Locale}. If * the time taken to read the resource files is significant, the cached * instances will perform significantly better than simply creating a new * instance whenever it is needed. * * @param locale * required locale */ public static MessageConveyor get(Locale locale) { MessageConveyor instance = INSTANCES.get(locale); if (instance == null) { instance = new MessageConveyor(locale); INSTANCES.put(locale, instance); } return instance; } ... } Note that the constructor is now package-private - this breaks the API so will need to be agreed. It is not strictly necessary but desirable to encourage the most efficient use of Cal10n. The internal cache (called 'cache') holds the actual resource bundles and avoids them being repeatedly read from disk. Previously, this cache would be dropped every time an instance was no longer referenced. The next time the same locale was required, a new instance would be needed, also needing the same files to be read from disk again. Now, the new static INSTANCES cache holds the instances, each of which holds its cache containing the resource bundles that were read from disk. There is a small penalty in consulting the INSTANCES cache but this should be no worse than re-reading the files (and probably much better). I've attached a patch, which replaces the one I sent on the 14th. Regards, Rick -- Big Bee Consultants Limited : Registered in England & Wales No. 6397941 Registered Office: 71 The Hundred, Romsey, Hampshire, SO51 8BZ

1 0

Some suggestions based on a code review
by Rick Beton 14 Mar '10

14 Mar '10

Hi Ceki, I have been reading through the Cal10n code, which I cloned from Git so as to get the most up to date. I'd like to offer a patch file containing some suggested changes - see attached. * some javadoc alterations * more fields are private * some fields are final to distinguish them from 'accumulator' variables (this shows my functional programming tendencies!) * CAL10NResourceBundle hasChanged method now computes the periodicity correctly * CAL10NResourceBundle has new getMap() method to remove the assumption that there is only one parent level. I may be able to put together a first effort at integrating Cal10n with Ant; it depends on how busy I am this week and whether my colleagues want to try out Cal10n further. (I've done bits of Ant before - the javah task is my work). Regards, Rick -- Big Bee Consultants Limited : Registered in England & Wales No. 6397941 Registered Office: 71 The Hundred, Romsey, Hampshire, SO51 8BZ

1 0