October 2006 - logback-dev - mailman3.qos.ch

[Bug 8] New: The insertion of a percent symbol causes the Parser to crash
by bugzilla-daemon＠pixie.qos.ch 19 Mar '08

19 Mar '08

http://bugzilla.qos.ch/show_bug.cgi?id=8 Summary: The insertion of a percent symbol causes the Parser to crash Product: logback-core Version: unspecified Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2 Component: Pattern AssignedTo: logback-dev(a)qos.ch ReportedBy: noreply.sebastien(a)qos.ch When inserting the percent char twice, so that it appears in the PatternLayout output, a number format exception is thrown. It does not prevent from using normally the PatternLayout. trace: ERROR in ch.qos.logback.core.joran.spi.Interpreter@131f71a - Exception in Action for tag <layout>8:14 java.lang.NumberFormatException: For input string: "% %" java.lang.NumberFormatException: For input string: "% %" at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48) at java.lang.Integer.parseInt(Integer.java:447) at java.lang.Integer.parseInt(Integer.java:497) at ch.qos.logback.core.pattern.FormatInfo.valueOf(FormatInfo.java:70) at ch.qos.logback.core.pattern.parser.Parser.T(Parser.java:84) at ch.qos.logback.core.pattern.parser.Parser.E(Parser.java:51) at ch.qos.logback.core.pattern.parser.Parser.Eopt(Parser.java:107) at ch.qos.logback.core.pattern.parser.Parser.E(Parser.java:55) at ch.qos.logback.core.pattern.parser.Parser.Eopt(Parser.java:107) at ch.qos.logback.core.pattern.parser.Parser.E(Parser.java:55) at ch.qos.logback.core.pattern.parser.Parser.Eopt(Parser.java:107) at ch.qos.logback.core.pattern.parser.Parser.E(Parser.java:55) at ch.qos.logback.core.pattern.parser.Parser.Eopt(Parser.java:107) at ch.qos.logback.core.pattern.parser.Parser.E(Parser.java:55) at ch.qos.logback.core.pattern.parser.Parser.Eopt(Parser.java:107) at ch.qos.logback.core.pattern.parser.Parser.E(Parser.java:55) at ch.qos.logback.core.pattern.parser.Parser.Eopt(Parser.java:107) at ch.qos.logback.core.pattern.parser.Parser.E(Parser.java:55) at ch.qos.logback.core.pattern.parser.Parser.Eopt(Parser.java:107) at ch.qos.logback.core.pattern.parser.Parser.E(Parser.java:55) at ch.qos.logback.core.pattern.parser.Parser.Eopt(Parser.java:107) at ch.qos.logback.core.pattern.parser.Parser.E(Parser.java:55) at ch.qos.logback.core.pattern.parser.Parser.parse(Parser.java:31) at ch.qos.logback.core.pattern.PatternLayoutBase.start(PatternLayoutBase.java:76) at ch.qos.logback.core.joran.action.AbstractLayoutAction.end(AbstractLayoutAction.java:75) at ch.qos.logback.core.joran.spi.Interpreter.callEndAction(Interpreter.java:289) at ch.qos.logback.core.joran.spi.Interpreter.endElement(Interpreter.java:152) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.endElement(AbstractSAXParser.java:633) at com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.scanEndElement(XMLNSDocumentScannerImpl.java:719) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(XMLDocumentFragmentScannerImpl.java:1685) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:368) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:834) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:764) at com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:148) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1242) at javax.xml.parsers.SAXParser.parse(SAXParser.java:375) at ch.qos.logback.core.joran.JoranConfiguratorBase.doConfigure(JoranConfiguratorBase.java:125) at ch.qos.logback.core.joran.JoranConfiguratorBase.doConfigure(JoranConfiguratorBase.java:101) at ch.qos.logback.core.joran.JoranConfiguratorBase.doConfigure(JoranConfiguratorBase.java:84) at ch.qos.logback.core.joran.JoranConfiguratorBase.doConfigure(JoranConfiguratorBase.java:77) at mainPackage.ConfigTester.main(ConfigTester.java:21) -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 5

[Bug 19] New: In there is an error in the expession, JaninoEventEvaluatorBase throws an excpetion
by bugzilla-daemon＠pixie.qos.ch 23 Jan '07

23 Jan '07

http://bugzilla.qos.ch/show_bug.cgi?id=19 Summary: In there is an error in the expession, JaninoEventEvaluatorBase throws an excpetion Product: logback-classic Version: unspecified Platform: PC OS/Version: Windows Status: NEW Severity: blocker Priority: P1 Component: Other AssignedTo: logback-dev(a)qos.ch ReportedBy: ceki(a)qos.ch If there is an error in the expression passed to JaninoEventEvaluator, then the JaninoEE will throw an excpetion, sometimes an NPE to higher levels. Loggers do not seem to catch the NPE, nor does EvaluatorFilter. Here is a stack trace: Exception in thread "main" java.lang.NullPointerException at ch.qos.logback.core.boolex.JaninoEventEvaluatorBase.evaluate(JaninoEventEvaluatorBase.java:58) at ch.qos.logback.core.filter.EvaluatorFilter.decide(EvaluatorFilter.java:48) at ch.qos.logback.core.spi.FilterAttachableImpl.getFilterChainDecision(FilterAttachableImpl.java:68) at ch.qos.logback.core.AppenderBase.getFilterChainDecision(AppenderBase.java:115) at ch.qos.logback.core.AppenderBase.doAppend(AppenderBase.java:65) at ch.qos.logback.core.spi.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:51) at ch.qos.logback.classic.Logger.appendLoopOnAppenders(Logger.java:286) at ch.qos.logback.classic.Logger.callAppenders(Logger.java:270) at ch.qos.logback.classic.Logger.filterAndLog(Logger.java:375) at ch.qos.logback.classic.Logger.debug(Logger.java:398) at chapter5.GoMDC.main(GoMDC.java:28) The expresison is: <Expression>message.conts("I know me 1")</Expression> -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 3

[Bug 9] New: PostContentConverter
by bugzilla-daemon＠pixie.qos.ch 23 Jan '07

23 Jan '07

http://bugzilla.qos.ch/show_bug.cgi?id=9 Summary: PostContentConverter Product: logback-access Version: unspecified Platform: All OS/Version: All Status: NEW Severity: normal Priority: P1 Component: Other AssignedTo: logback-dev(a)qos.ch ReportedBy: noreply.sebastien(a)qos.ch At the moment, the PostContentConverter consumes the bytes present in the request's InputStream and returns them as a String. It seems that it is quite a dangerous behaviour, since several sources consider the inputStream as a read-once component. This converter has been removed from access' PatternLayout. We should create a real-life webservice and soap requests, then test the PostContentConverter against the webservice. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 2

[Bug 22] New: Default config conflicting with examples
by bugzilla-daemon＠pixie.qos.ch 12 Jan '07

12 Jan '07

http://bugzilla.qos.ch/show_bug.cgi?id=22 Summary: Default config conflicting with examples Product: logback-classic Version: unspecified Platform: PC OS/Version: Windows Status: NEW Severity: major Priority: P1 Component: Other AssignedTo: logback-dev(a)qos.ch ReportedBy: noreply.sebastien(a)qos.ch The new default config behaviour prevents the use of a class with a main method that takes the path to a config file as a first parameter. Either the logback-test.xml, or the BasicConfigurator, seem to take the lead. When using the example classes, there are two output: the one specified in the config file passed as a parameter _and_ the one coming from logback-test or BasicConfigurator. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 5

[Bug 25] New: Filters attached to the context do not allow use of Core module Filters
by bugzilla-daemon＠pixie.qos.ch 18 Dec '06

18 Dec '06

http://bugzilla.qos.ch/show_bug.cgi?id=25 Summary: Filters attached to the context do not allow use of Core module Filters Product: logback-core Version: unspecified Platform: All OS/Version: All Status: NEW Severity: normal Priority: P1 Component: Joran AssignedTo: logback-dev(a)qos.ch ReportedBy: noreply.sebastien(a)qos.ch Adding a filter to an appender via the configuration file works well, but adding one nested right in the <configuration> element does not. If the class of the filter is a subclass of ClassicFilter, then it should work fine even when declared in the config element. However, we do not want users not to be able to add core filter classes in the context. Headaches right ahead :) -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 2

[Bug 24] New: Constants need to be grouped
by bugzilla-daemon＠pixie.qos.ch 30 Nov '06

30 Nov '06

http://bugzilla.qos.ch/show_bug.cgi?id=24 Summary: Constants need to be grouped Product: logback-core Version: unspecified Platform: All OS/Version: All Status: NEW Severity: minor Priority: P1 Component: Joran AssignedTo: logback-dev(a)qos.ch ReportedBy: noreply.sebastien(a)qos.ch The constants used by modules to put objects in the context's object map come from different classes. For example, ActionConst.APPENDER_BAG is the constant used by c.q.l.core.joran.AppenderAction, and c.q.l.core.CoreGlobal.EVALUATOR_MAP is used by classes trying to add or access evaluators mapped in the context. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 2

[Bug 16] New: ch.qos.logback.core.util.PropertySetter
by bugzilla-daemon＠pixie.qos.ch 30 Nov '06

30 Nov '06

http://bugzilla.qos.ch/show_bug.cgi?id=16 Summary: ch.qos.logback.core.util.PropertySetter Product: logback-core Version: unspecified Platform: PC OS/Version: Windows Status: NEW Severity: blocker Priority: P1 Component: Joran AssignedTo: logback-dev(a)qos.ch ReportedBy: noreply.ceki(a)qos.ch PropertySetter should be better unit tested. In particular for primitive types. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 3

[Bug 7] New: file and activeFileName params in config
by bugzilla-daemon＠pixie.qos.ch 30 Nov '06

30 Nov '06

http://bugzilla.qos.ch/show_bug.cgi?id=7 Summary: file and activeFileName params in config Product: logback-core Version: unspecified Platform: All OS/Version: All Status: NEW Severity: major Priority: P2 Component: Rolling AssignedTo: logback-dev(a)qos.ch ReportedBy: noreply.sebastien(a)qos.ch In FileAppender, there is a settable "file" attribute. In RollingPolicyBase, there is an activeFileName attribute. Both serve the same point: set a name for the file where the logging will take place. We should propose only one way of specifying this. Maybe suppressing the activeFileName from the RollingPolicyBase class and using the "file" attribute instead. This bug doesn't affect the normal use of logback in a major way. One can still use the rolling functions by specifying the activeFileName attribute. The "file" attribute is ignored in that case. The contrary is not true: if the "file" attribute is specified and no activeFileName is set, the rolling policy will not be able to work correctly. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 3

svn commit: r842 - in logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic: . spi
by noreply.ceki＠qos.ch 31 Oct '06

31 Oct '06

Author: ceki Date: Tue Oct 31 22:53:07 2006 New Revision: 842 Added: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/TurboFilterAttachable.java - copied, changed from r841, /logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/ClassicFilterAttachable.java logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/TurboFilterAttachableImpl.java - copied, changed from r841, /logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/ClassicFilterAttachableImpl.java Removed: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/ClassicFilterAttachable.java logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/ClassicFilterAttachableImpl.java Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/Logger.java logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/LoggerContext.java Log: aligning method with the new name, i.e. TurboFilter Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/Logger.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/Logger.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/Logger.java Tue Oct 31 22:53:07 2006 @@ -407,7 +407,7 @@ final void filterAndLog(final Marker marker, final Level level, final String msg, final Object[] params, final Throwable t) { - final int decision = loggerContext.getFilterChainDecision(marker, this, Level.DEBUG, msg, params, t); + final int decision = loggerContext.getTurboFilterChainDecision(marker, this, Level.DEBUG, msg, params, t); if(decision == Filter.NEUTRAL) { if(effectiveLevelInt > level.levelInt) { Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/LoggerContext.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/LoggerContext.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/LoggerContext.java Tue Oct 31 22:53:07 2006 @@ -17,8 +17,8 @@ import org.slf4j.Marker; import ch.qos.logback.classic.turbo.TurboFilter; -import ch.qos.logback.classic.spi.ClassicFilterAttachable; -import ch.qos.logback.classic.spi.ClassicFilterAttachableImpl; +import ch.qos.logback.classic.spi.TurboFilterAttachable; +import ch.qos.logback.classic.spi.TurboFilterAttachableImpl; import ch.qos.logback.classic.spi.LoggerContextRemoteView; import ch.qos.logback.core.ContextBase; import ch.qos.logback.core.CoreGlobal; @@ -29,7 +29,7 @@ * @author ceki */ public class LoggerContext extends ContextBase implements ILoggerFactory, - ClassicFilterAttachable { + TurboFilterAttachable { public static final String ROOT_NAME = "root"; @@ -46,7 +46,7 @@ LoggerContextRemoteView loggerContextRemoteView; - ClassicFilterAttachableImpl cfai = null; + TurboFilterAttachableImpl cfai = null; public LoggerContext() { super(); @@ -169,35 +169,35 @@ } - public void addFilter(TurboFilter newFilter) { + public void addTurboFilter(TurboFilter newFilter) { if (cfai == null) { - cfai = new ClassicFilterAttachableImpl(); + cfai = new TurboFilterAttachableImpl(); } - cfai.addFilter(newFilter); + cfai.addTurboFilter(newFilter); } - public void clearAllFilters() { + public void clearAllTurboFilters() { if (cfai == null) { return; } - cfai.clearAllFilters(); + cfai.clearAllTurboFilters(); cfai = null; } - final public int getFilterChainDecision(final Marker marker, + final public int getTurboFilterChainDecision(final Marker marker, final Logger logger, final Level level, final String format, final Object[] params, final Throwable t) { if (cfai == null) { return Filter.NEUTRAL; } return cfai - .getFilterChainDecision(marker, logger, level, format, params, t); + .getTurboFilterChainDecision(marker, logger, level, format, params, t); } - public TurboFilter getFirstFilter() { + public TurboFilter getFirstTurboFilter() { if (cfai == null) { return null; } - return cfai.getFirstFilter(); + return cfai.getFirstTurboFilter(); } } Copied: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/TurboFilterAttachable.java (from r841, /logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/ClassicFilterAttachable.java) ============================================================================== --- /logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/ClassicFilterAttachable.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/TurboFilterAttachable.java Tue Oct 31 22:53:07 2006 @@ -11,26 +11,26 @@ * * @author Ceki Gülcü */ -public interface ClassicFilterAttachable { +public interface TurboFilterAttachable { /** * Add a filter. */ - public void addFilter(TurboFilter newFilter); + public void addTurboFilter(TurboFilter newFilter); /** * Get first filter in the chain. */ - public TurboFilter getFirstFilter(); + public TurboFilter getFirstTurboFilter(); - public void clearAllFilters(); + public void clearAllTurboFilters(); /** * Loop through the filters in the chain. As soon as a filter decides on * ACCEPT or DENY, then that value is returned. If all of the filters return * NEUTRAL, then NEUTRAL is returned. */ - public int getFilterChainDecision(Marker marker, Logger logger, + public int getTurboFilterChainDecision(Marker marker, Logger logger, Level level, String format, Object[] params, Throwable t); } Copied: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/TurboFilterAttachableImpl.java (from r841, /logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/ClassicFilterAttachableImpl.java) ============================================================================== --- /logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/ClassicFilterAttachableImpl.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/TurboFilterAttachableImpl.java Tue Oct 31 22:53:07 2006 @@ -21,7 +21,7 @@ * * @author Ceki Gülcü */ -final public class ClassicFilterAttachableImpl implements ClassicFilterAttachable { +final public class TurboFilterAttachableImpl implements TurboFilterAttachable { TurboFilter headFilter; TurboFilter tailFilter; @@ -29,7 +29,7 @@ /** * Add a filter to end of the filter list. */ - public void addFilter(TurboFilter newFilter) { + public void addTurboFilter(TurboFilter newFilter) { if (headFilter == null) { headFilter = newFilter; tailFilter = newFilter; @@ -42,14 +42,14 @@ /** * Get first filter in the chain. */ - public TurboFilter getFirstFilter() { + public TurboFilter getFirstTurboFilter() { return headFilter; } /** * Clear the filter chain */ - public void clearAllFilters() { + public void clearAllTurboFilters() { TurboFilter f = headFilter; while (f != null) { final TurboFilter next = f.getNext(); @@ -66,7 +66,7 @@ * ACCEPT or DENY, then that value is returned. If all of the filters return * NEUTRAL, then NEUTRAL is returned. */ - public final int getFilterChainDecision(final Marker marker, final Logger logger, + public final int getTurboFilterChainDecision(final Marker marker, final Logger logger, final Level level, final String format, final Object[] params, final Throwable t) { TurboFilter f = headFilter;

1 0

svn commit: r841 - in logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic: . spi turbo
by noreply.ceki＠qos.ch 31 Oct '06

31 Oct '06

Author: ceki Date: Tue Oct 31 22:49:48 2006 New Revision: 841 Added: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/turbo/TurboFilter.java - copied, changed from r831, /logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/turbo/ClassicFilter.java Removed: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/turbo/ClassicFilter.java Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/LoggerContext.java logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/ClassicFilterAttachable.java logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/ClassicFilterAttachableImpl.java Log: renamed ClassicFilter as TurboFilter Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/LoggerContext.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/LoggerContext.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/LoggerContext.java Tue Oct 31 22:49:48 2006 @@ -16,7 +16,7 @@ import org.slf4j.ILoggerFactory; import org.slf4j.Marker; -import ch.qos.logback.classic.turbo.ClassicFilter; +import ch.qos.logback.classic.turbo.TurboFilter; import ch.qos.logback.classic.spi.ClassicFilterAttachable; import ch.qos.logback.classic.spi.ClassicFilterAttachableImpl; import ch.qos.logback.classic.spi.LoggerContextRemoteView; @@ -169,7 +169,7 @@ } - public void addFilter(ClassicFilter newFilter) { + public void addFilter(TurboFilter newFilter) { if (cfai == null) { cfai = new ClassicFilterAttachableImpl(); } @@ -194,7 +194,7 @@ .getFilterChainDecision(marker, logger, level, format, params, t); } - public ClassicFilter getFirstFilter() { + public TurboFilter getFirstFilter() { if (cfai == null) { return null; } Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/ClassicFilterAttachable.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/ClassicFilterAttachable.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/ClassicFilterAttachable.java Tue Oct 31 22:49:48 2006 @@ -4,7 +4,7 @@ import ch.qos.logback.classic.Level; import ch.qos.logback.classic.Logger; -import ch.qos.logback.classic.turbo.ClassicFilter; +import ch.qos.logback.classic.turbo.TurboFilter; /** * Interface for attaching ClassicFilter instances to objects. @@ -16,12 +16,12 @@ /** * Add a filter. */ - public void addFilter(ClassicFilter newFilter); + public void addFilter(TurboFilter newFilter); /** * Get first filter in the chain. */ - public ClassicFilter getFirstFilter(); + public TurboFilter getFirstFilter(); public void clearAllFilters(); Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/ClassicFilterAttachableImpl.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/ClassicFilterAttachableImpl.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/spi/ClassicFilterAttachableImpl.java Tue Oct 31 22:49:48 2006 @@ -13,7 +13,7 @@ import ch.qos.logback.classic.Level; import ch.qos.logback.classic.Logger; -import ch.qos.logback.classic.turbo.ClassicFilter; +import ch.qos.logback.classic.turbo.TurboFilter; import ch.qos.logback.core.filter.Filter; /** @@ -23,13 +23,13 @@ */ final public class ClassicFilterAttachableImpl implements ClassicFilterAttachable { - ClassicFilter headFilter; - ClassicFilter tailFilter; + TurboFilter headFilter; + TurboFilter tailFilter; /** * Add a filter to end of the filter list. */ - public void addFilter(ClassicFilter newFilter) { + public void addFilter(TurboFilter newFilter) { if (headFilter == null) { headFilter = newFilter; tailFilter = newFilter; @@ -42,7 +42,7 @@ /** * Get first filter in the chain. */ - public ClassicFilter getFirstFilter() { + public TurboFilter getFirstFilter() { return headFilter; } @@ -50,9 +50,9 @@ * Clear the filter chain */ public void clearAllFilters() { - ClassicFilter f = headFilter; + TurboFilter f = headFilter; while (f != null) { - final ClassicFilter next = f.getNext(); + final TurboFilter next = f.getNext(); f.setNext(null); f = next; } @@ -68,7 +68,7 @@ */ public final int getFilterChainDecision(final Marker marker, final Logger logger, final Level level, final String format, final Object[] params, final Throwable t) { - ClassicFilter f = headFilter; + TurboFilter f = headFilter; while (f != null) { switch (f.decide(marker, logger, level, format, params, t)) { Copied: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/turbo/TurboFilter.java (from r831, /logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/turbo/ClassicFilter.java) ============================================================================== --- /logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/turbo/ClassicFilter.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/turbo/TurboFilter.java Tue Oct 31 22:49:48 2006 @@ -5,6 +5,8 @@ import ch.qos.logback.classic.Level; import ch.qos.logback.classic.Logger; import ch.qos.logback.core.filter.Filter; +import ch.qos.logback.core.spi.ContextAwareBase; +import ch.qos.logback.core.spi.LifeCycle; /** * ClassicFilter is a specialized filter with a decide method that takes a bunch of parameters @@ -13,17 +15,20 @@ * * @author Ceki Gulcu */ -public abstract class ClassicFilter extends Filter { +public abstract class TurboFilter extends ContextAwareBase implements LifeCycle { + private String name; + boolean start = false; + /** * Points to the next filter in the filter chain. */ - private ClassicFilter classicNext; + private TurboFilter classicNext; /** * Make a decision based on the multiple parameters passed as arguments. - * The returned value should be one of <code>{@link #DENY}</code>, - * <code>{@link #NEUTRAL}</code>, or <code>{@link #ACCEPT}</code>. + * The returned value should be one of <code>{@link Filter#DENY}</code>, + * <code>{@link Filter#NEUTRAL}</code>, or <code>{@link Filter#ACCEPT}</code>. * @param marker * @param logger @@ -36,22 +41,39 @@ public abstract int decide(Marker marker, Logger logger, Level level, String format, Object[] params, Throwable t); - public int decide(Object o) { - throw new UnsupportedOperationException("decide(Object) not supported"); + public void start() { + this.start = true; + } + + public boolean isStarted() { + return this.start; } + public void stop() { + this.start = false; + } + + /** * Set the next filter pointer. */ - public void setNext(ClassicFilter next) { + public void setNext(TurboFilter next) { this.classicNext = next; } /** * Return the pointer to the next filter; */ - public ClassicFilter getNext() { + public TurboFilter getNext() { return classicNext; } + + public String getName() { + return name; + } + + public void setName(String name) { + this.name = name; + } }

1 0