November 2006 - logback-dev

svn commit: r1031 - in logback/trunk: logback-core/src/main/java/ch/qos/logback/core/joran/action logback-core/src/main/java/ch/qos/logback/core/joran/spi logback-examples/src/main/java/joran/implicit
by noreply.seb＠qos.ch 29 Nov '06

29 Nov '06

Author: seb Date: Wed Nov 29 11:54:35 2006 New Revision: 1031 Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/AppenderRefAction.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/NestedComponentIA.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/NestedSimplePropertyIA.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/spi/Interpreter.java logback/trunk/logback-examples/src/main/java/joran/implicit/PrintMeImplicitAction.java Log: <tag> changed to [tag] Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/AppenderRefAction.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/AppenderRefAction.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/AppenderRefAction.java Wed Nov 29 11:54:35 2006 @@ -33,8 +33,8 @@ Object o = ec.peekObject(); if (!(o instanceof AppenderAttachable)) { - String errMsg = "Could not find an AppenderAttachable at the top of execution stack. Near <" - + tagName + "> line " + getLineNumber(ec); + String errMsg = "Could not find an AppenderAttachable at the top of execution stack. Near [" + + tagName + "] line " + getLineNumber(ec); inError = true; addError(errMsg); return; Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/NestedComponentIA.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/NestedComponentIA.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/NestedComponentIA.java Wed Nov 29 11:54:35 2006 @@ -42,7 +42,7 @@ public boolean isApplicable(Pattern pattern, Attributes attributes, InterpretationContext ec) { - // System.out.println("in NestComponentIA.isApplicable <" + pattern + ">"); + // System.out.println("in NestComponentIA.isApplicable [" + pattern + "]"); String nestedElementTagName = pattern.peekLast(); // calling ec.peekObject with an empty stack will throw an exception @@ -99,7 +99,7 @@ try { // getLogger().debug( - // "About to instantiate component <{}> of type [{}]", localName, + // "About to instantiate component [{}] of type [{}]", localName, // className); // FIXME: Loading classes should be governed by config file rules. Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/NestedSimplePropertyIA.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/NestedSimplePropertyIA.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/NestedSimplePropertyIA.java Wed Nov 29 11:54:35 2006 @@ -43,7 +43,7 @@ public boolean isApplicable( Pattern pattern, Attributes attributes, InterpretationContext ec) { - //System.out.println("in NestedSimplePropertyIA.isApplicable <" + pattern + ">"); + //System.out.println("in NestedSimplePropertyIA.isApplicable [" + pattern + "]"); String nestedElementTagName = pattern.peekLast(); // no point in attempting if there is no parent object Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/spi/Interpreter.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/spi/Interpreter.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/spi/Interpreter.java Wed Nov 29 11:54:35 2006 @@ -160,10 +160,10 @@ // "+skip); if (skip.equals(pattern)) { // ec.addInfo("Normal processing will continue with the next element. - // Current pattern is <"+ pattern+">", this); + // Current pattern is ["+ pattern+"]", this); skip = null; } else { - // getLogger().debug("Skipping invoking end() method for <{}>.", + // getLogger().debug("Skipping invoking end() method for [{}].", // pattern); } } else if (applicableActionList != EMPTY_LIST) { @@ -240,7 +240,7 @@ } if (skip != null) { - // getLogger().debug("Skipping invoking begin() method for <{}>.", + // getLogger().debug("Skipping invoking begin() method for [{}].", // pattern); return; } @@ -266,11 +266,11 @@ skip.pop(); break; } - // getLogger().info("Skip pattern set to <{}>", skip); + // getLogger().info("Skip pattern set to [{}]", skip); } catch (Exception e) { skip = (Pattern) pattern.clone(); - // getLogger().info("Skip pattern set to <{}>", skip); - cai.addError("Exception in Action for tag <" + tagName + ">", e); + // getLogger().info("Skip pattern set to [{}]", skip); + cai.addError("Exception in Action for tag [" + tagName + "]", e); } } } @@ -296,7 +296,7 @@ return; } - // logger.debug("About to call end actions on node: <" + localName + ">"); + // logger.debug("About to call end actions on node: [" + localName + "]"); Iterator i = applicableActionList.iterator(); while (i.hasNext()) { @@ -317,10 +317,10 @@ } // getLogger().info("Skip pattern set to <{}>", skip); } catch (Exception e) { - cai.addError("Exception in Action for tag <" + tagName + ">", e); + cai.addError("Exception in Action for tag [" + tagName + "]", e); skip = (Pattern) pattern.clone(); skip.pop(); // induce the siblings to be skipped - // getLogger().info("Skip pattern set to <{}>.", skip); + // getLogger().info("Skip pattern set to [{}].", skip); } } } Modified: logback/trunk/logback-examples/src/main/java/joran/implicit/PrintMeImplicitAction.java ============================================================================== --- logback/trunk/logback-examples/src/main/java/joran/implicit/PrintMeImplicitAction.java (original) +++ logback/trunk/logback-examples/src/main/java/joran/implicit/PrintMeImplicitAction.java Wed Nov 29 11:54:35 2006 @@ -35,7 +35,7 @@ } public void begin(InterpretationContext ec, String name, Attributes attributes) { - System.out.println("Element <"+name+"> asked to be printed."); + System.out.println("Element ["+name+"] asked to be printed."); }

1 0

[continuum] BUILD SUCCESSFUL: Logback Access Module
by John Noreplai 29 Nov '06

29 Nov '06

Online report : http://localhost:8090/continuum/servlet/continuum/target/ProjectBuild.vm/vi… Build statistics: State: Ok Previous State: Failed Started at: Wed, 29 Nov 2006 11:20:18 +0100 Finished at: Wed, 29 Nov 2006 11:20:32 +0100 Total time: 14s Build Trigger: Schedule Exit code: 0 Building machine hostname: pixie Operating system : Linux(unknown) Java version : 1.5.0_08(Sun Microsystems Inc.) Changes seb better test /logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTest.java /logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTestBase.java /logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/DBAppenderTest.java /logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/DBAppenderTestBase.java **************************************************************************** Output: **************************************************************************** [INFO] Scanning for projects... [INFO] ---------------------------------------------------------------------------- [INFO] Building Logback Access Module [INFO] task-segment: [clean, install] [INFO] ---------------------------------------------------------------------------- [INFO] [clean:clean] [INFO] Deleting directory /opt/continuum-1.0.3/apps/continuum/working-directory/47/target [INFO] Deleting directory /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/classes [INFO] Deleting directory /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/test-classes [INFO] [resources:resources] [INFO] Using default encoding to copy filtered resources. [INFO] [compiler:compile] Compiling 56 source files to /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/classes [INFO] [resources:testResources] [INFO] Using default encoding to copy filtered resources. [INFO] [compiler:testCompile] Compiling 22 source files to /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/test-classes [INFO] [surefire:test] [INFO] Surefire report directory: /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/surefire-reports ------------------------------------------------------- T E S T S ------------------------------------------------------- Running ch.qos.logback.access.db.DBAppenderTest [Server@3c6f579]: [Thread[main,5,main]]: checkRunning(false) entered [Server@3c6f579]: [Thread[main,5,main]]: checkRunning(false) exited [Server@3c6f579]: [Thread[main,5,main]]: setDatabaseName(0,test) [Server@3c6f579]: [Thread[main,5,main]]: checkRunning(false) entered [Server@3c6f579]: [Thread[main,5,main]]: checkRunning(false) exited [Server@3c6f579]: [Thread[main,5,main]]: setDatabasePath(0,mem:test;sql.enforce_strict_size=true) [Server@7cf1bb78]: [Thread[main,5,main]]: checkRunning(false) entered [Server@7cf1bb78]: [Thread[main,5,main]]: checkRunning(false) exited [Server@7cf1bb78]: [Thread[main,5,main]]: setDatabaseName(0,test) [Server@7cf1bb78]: [Thread[main,5,main]]: checkRunning(false) entered [Server@7cf1bb78]: [Thread[main,5,main]]: checkRunning(false) exited [Server@7cf1bb78]: [Thread[main,5,main]]: setDatabasePath(0,mem:test;sql.enforce_strict_size=true) [Server@12b7eea]: [Thread[main,5,main]]: checkRunning(false) entered [Server@12b7eea]: [Thread[main,5,main]]: checkRunning(false) exited [Server@12b7eea]: [Thread[main,5,main]]: setDatabaseName(0,test) [Server@12b7eea]: [Thread[main,5,main]]: checkRunning(false) entered [Server@12b7eea]: [Thread[main,5,main]]: checkRunning(false) exited [Server@12b7eea]: [Thread[main,5,main]]: setDatabasePath(0,mem:test;sql.enforce_strict_size=true) [Server@63238bd2]: [Thread[main,5,main]]: checkRunning(false) entered [Server@63238bd2]: [Thread[main,5,main]]: checkRunning(false) exited [Server@63238bd2]: [Thread[main,5,main]]: setDatabaseName(0,test) [Server@63238bd2]: [Thread[main,5,main]]: checkRunning(false) entered [Server@63238bd2]: [Thread[main,5,main]]: checkRunning(false) exited [Server@63238bd2]: [Thread[main,5,main]]: setDatabasePath(0,mem:test;sql.enforce_strict_size=true) Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.758 sec Running ch.qos.logback.access.jetty.JettyBasicTest 2006-11-29 11:20:30.083::INFO: Logging to STDERR via org.mortbay.log.StdErrLog 2006-11-29 11:20:30.125::INFO: jetty-6.0.x |-WARN in ch.qos.logback.access.jetty.RequestLogImpl@52f6438d - filename property not set. Assuming [null/etc/logback-access.xml] |-ERROR in ch.qos.logback.access.jetty.RequestLogImpl@52f6438d - [null/etc/logback-access.xml] does not exist |-INFO in ch.qos.logback.access.jetty.RequestLogImpl@52f6438d - RequestLog added to RequestLogRegistry with name: LogbackRequestLog 2006-11-29 11:20:30.196::INFO: Started SelectChannelConnector @ 0.0.0.0:1234 29/11/2006:11:20:30 +0100 localhost 127.0.0.1 29/11/2006:11:20:30 +0100 localhost 127.0.0.1 Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.326 sec Running ch.qos.logback.access.filter.AccessStatsTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.008 sec Running ch.qos.logback.access.pattern.ConverterTest Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.019 sec Running ch.qos.logback.access.filter.StatsByDayTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.01 sec Running ch.qos.logback.access.net.URLEvaluatorTest Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.009 sec Running ch.qos.logback.access.net.SocketAppenderTest Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.127 sec Results : Tests run: 29, Failures: 0, Errors: 0, Skipped: 0 [INFO] [jar:jar] [INFO] Building jar: /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/logback-access-0.6-SNAPSHOT.jar [INFO] Preparing source:jar [WARNING] Removing: jar from forked lifecycle, to prevent recursive invocation. [INFO] No goals needed for project - skipping [INFO] [source:jar {execution: default}] [INFO] Building jar: /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/logback-access-0.6-SNAPSHOT-sources.jar [INFO] [install:install] [INFO] Installing /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/logback-access-0.6-SNAPSHOT.jar to /root/.m2/repository/ch/qos/logback/logback-access/0.6-SNAPSHOT/logback-access-0.6-SNAPSHOT.jar [INFO] Installing /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/logback-access-0.6-SNAPSHOT-sources.jar to /root/.m2/repository/ch/qos/logback/logback-access/0.6-SNAPSHOT/logback-access-0.6-SNAPSHOT-sources.jar [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESSFUL [INFO] ------------------------------------------------------------------------ [INFO] Total time: 12 seconds [INFO] Finished at: Wed Nov 29 11:20:32 CET 2006 [INFO] Final Memory: 14M/117M [INFO] ------------------------------------------------------------------------ ****************************************************************************

1 0

svn commit: r1030 - in logback/trunk: logback-access/src/test/java/ch/qos/logback/access/db logback-classic/src/test/java/ch/qos/logback/classic/db
by noreply.seb＠qos.ch 29 Nov '06

29 Nov '06

Author: seb Date: Wed Nov 29 11:14:11 2006 New Revision: 1030 Modified: logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTest.java logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTestBase.java logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/DBAppenderTest.java logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/DBAppenderTestBase.java Log: better test Modified: logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTest.java ============================================================================== --- logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTest.java (original) +++ logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTest.java Wed Nov 29 11:14:11 2006 @@ -10,6 +10,7 @@ import ch.qos.logback.access.spi.AccessEvent; import ch.qos.logback.access.spi.BasicContext; import ch.qos.logback.core.db.DriverManagerConnectionSource; +import ch.qos.logback.core.util.StatusPrinter; public class DBAppenderTest extends DBAppenderTestBase { @@ -36,6 +37,10 @@ connectionSource.setPassword(password); connectionSource.start(); appender.setConnectionSource(connectionSource); + } + + private void setInsertHeadersAndStart(boolean insert) { + appender.setInsertHeaders(insert); appender.start(); } @@ -47,9 +52,11 @@ } public void testAppendAccessEvent() throws SQLException { + setInsertHeadersAndStart(false); + AccessEvent event = createAccessEvent(); appender.append(event); - + Statement stmt = connectionSource.getConnection().createStatement(); ResultSet rs = null; rs = stmt.executeQuery("SELECT * FROM access_event"); @@ -71,16 +78,53 @@ rs.close(); stmt.close(); } + + + public void testCheckNoHeadersAreInserted() throws Exception { + setInsertHeadersAndStart(false); + + AccessEvent event = createAccessEvent(); + appender.append(event); + StatusPrinter.print(context.getStatusManager()); + + //Check that no headers were inserted + Statement stmt = connectionSource.getConnection().createStatement(); + ResultSet rs = null; + rs = stmt.executeQuery("SELECT * FROM access_event_header"); + + assertFalse(rs.next()); + rs.close(); + stmt.close(); + } - public void testAppendHeaders() throws SQLException { + public void testAppendHeaders() throws SQLException { + setInsertHeadersAndStart(true); + AccessEvent event = createAccessEvent(); appender.append(event); Statement stmt = connectionSource.getConnection().createStatement(); ResultSet rs = null; - rs = stmt.executeQuery("SELECT * FROM access_event_header where event_id = 0"); - while (rs.next()) { - assertEquals(event.getRequestHeader(rs.getString(2)), rs.getString(3)); + rs = stmt.executeQuery("SELECT * FROM access_event_header"); + String key; + String value; + if (!rs.next()) { + fail("There should be results to this query"); + } else { + key = rs.getString(2); + value = rs.getString(3); + assertNotNull(key); + assertNotNull(value); + assertEquals(event.getRequestHeader(key), value); + rs.next(); + key = rs.getString(2); + value = rs.getString(3); + assertNotNull(key); + assertNotNull(value); + assertEquals(event.getRequestHeader(key), value); + } + if (rs.next()) { + fail("There should be no more rows available"); } rs.close(); Modified: logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTestBase.java ============================================================================== --- logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTestBase.java (original) +++ logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTestBase.java Wed Nov 29 11:14:11 2006 @@ -23,12 +23,6 @@ super(name); } - public DBAppenderTestBase(String name, String url, boolean isNetwork) { - super(name); - this.isNetwork = isNetwork; - this.url = url; - } - protected void setUp() throws SQLException { if (isNetwork) { if (url == null) { Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/DBAppenderTest.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/DBAppenderTest.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/DBAppenderTest.java Wed Nov 29 11:14:11 2006 @@ -82,7 +82,6 @@ LoggingEvent event = createLoggingEvent(); appender.append(event); - //StatusPrinter.print(lc.getStatusManager()); Statement stmt = connectionSource.getConnection().createStatement(); ResultSet rs = null; @@ -102,7 +101,6 @@ lc.setProperty("testKey1", "testValue1"); appender.append(event); - //StatusPrinter.print(lc.getStatusManager()); Statement stmt = connectionSource.getConnection().createStatement(); ResultSet rs = null; @@ -123,7 +121,6 @@ LoggingEvent event = createLoggingEvent(); appender.append(event); } - //StatusPrinter.print(lc.getStatusManager()); Statement stmt = connectionSource.getConnection().createStatement(); ResultSet rs = null; Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/DBAppenderTestBase.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/DBAppenderTestBase.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/DBAppenderTestBase.java Wed Nov 29 11:14:11 2006 @@ -23,14 +23,6 @@ super(name); } - public DBAppenderTestBase(String name, String url, boolean isNetwork) { - - super(name); - - this.isNetwork = isNetwork; - this.url = url; - } - protected void setUp() throws SQLException { if (isNetwork) {

1 0

[continuum] BUILD FAILURE: Logback Access Module
by John Noreplai 29 Nov '06

29 Nov '06

Online report : http://localhost:8090/continuum/servlet/continuum/target/ProjectBuild.vm/vi… Build statistics: State: Failed Previous State: Failed Started at: Wed, 29 Nov 2006 11:00:19 +0100 Finished at: Wed, 29 Nov 2006 11:00:33 +0100 Total time: 14s Build Trigger: Schedule Exit code: 1 Building machine hostname: pixie Operating system : Linux(unknown) Java version : 1.5.0_08(Sun Microsystems Inc.) Changes seb Added an option to let the user choose if she wants to add the headers to the DB or not /logback/trunk/logback-access/src/main/java/ch/qos/logback/access/db/DBAppender.java /logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTestBase.java /logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/DBAppenderTestBase.java /logback/trunk/pom.xml **************************************************************************** Output: **************************************************************************** [INFO] Scanning for projects... [INFO] ---------------------------------------------------------------------------- [INFO] Building Logback Access Module [INFO] task-segment: [clean, install] [INFO] ---------------------------------------------------------------------------- [INFO] [clean:clean] [INFO] Deleting directory /opt/continuum-1.0.3/apps/continuum/working-directory/47/target [INFO] Deleting directory /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/classes [INFO] Deleting directory /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/test-classes [INFO] [resources:resources] [INFO] Using default encoding to copy filtered resources. Downloading: http://repo1.maven.org/maven2/hsqldb/hsqldb/1.8.0.7/hsqldb-1.8.0.7.pom 621b downloaded [INFO] [compiler:compile] Compiling 56 source files to /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/classes [INFO] [resources:testResources] [INFO] Using default encoding to copy filtered resources. Downloading: http://repo1.maven.org/maven2/hsqldb/hsqldb/1.8.0.7/hsqldb-1.8.0.7.jar 628K downloaded [INFO] [compiler:testCompile] Compiling 22 source files to /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/test-classes [INFO] [surefire:test] [INFO] Surefire report directory: /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/surefire-reports ------------------------------------------------------- T E S T S ------------------------------------------------------- Running ch.qos.logback.access.db.DBAppenderTest [Server@3c6f579]: [Thread[main,5,main]]: checkRunning(false) entered [Server@3c6f579]: [Thread[main,5,main]]: checkRunning(false) exited [Server@3c6f579]: [Thread[main,5,main]]: setDatabaseName(0,test) [Server@3c6f579]: [Thread[main,5,main]]: checkRunning(false) entered [Server@3c6f579]: [Thread[main,5,main]]: checkRunning(false) exited [Server@3c6f579]: [Thread[main,5,main]]: setDatabasePath(0,mem:test;sql.enforce_strict_size=true) [Server@7cf1bb78]: [Thread[main,5,main]]: checkRunning(false) entered [Server@7cf1bb78]: [Thread[main,5,main]]: checkRunning(false) exited [Server@7cf1bb78]: [Thread[main,5,main]]: setDatabaseName(0,test) [Server@7cf1bb78]: [Thread[main,5,main]]: checkRunning(false) entered [Server@7cf1bb78]: [Thread[main,5,main]]: checkRunning(false) exited [Server@7cf1bb78]: [Thread[main,5,main]]: setDatabasePath(0,mem:test;sql.enforce_strict_size=true) [Server@16aa37a6]: [Thread[main,5,main]]: checkRunning(false) entered [Server@16aa37a6]: [Thread[main,5,main]]: checkRunning(false) exited [Server@16aa37a6]: [Thread[main,5,main]]: setDatabaseName(0,test) [Server@16aa37a6]: [Thread[main,5,main]]: checkRunning(false) entered [Server@16aa37a6]: [Thread[main,5,main]]: checkRunning(false) exited [Server@16aa37a6]: [Thread[main,5,main]]: setDatabasePath(0,mem:test;sql.enforce_strict_size=true) Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.649 sec Running ch.qos.logback.access.jetty.JettyBasicTest 2006-11-29 11:00:32.034::INFO: Logging to STDERR via org.mortbay.log.StdErrLog 2006-11-29 11:00:32.082::INFO: jetty-6.0.x |-WARN in ch.qos.logback.access.jetty.RequestLogImpl@1de4f7c2 - filename property not set. Assuming [null/etc/logback-access.xml] |-ERROR in ch.qos.logback.access.jetty.RequestLogImpl@1de4f7c2 - [null/etc/logback-access.xml] does not exist |-INFO in ch.qos.logback.access.jetty.RequestLogImpl@1de4f7c2 - RequestLog added to RequestLogRegistry with name: LogbackRequestLog 2006-11-29 11:00:32.142::INFO: Started SelectChannelConnector @ 0.0.0.0:1234 29/11/2006:11:00:32 +0100 localhost 127.0.0.1 Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.279 sec <<< FAILURE! Running ch.qos.logback.access.filter.AccessStatsTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.009 sec Running ch.qos.logback.access.pattern.ConverterTest Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.023 sec Running ch.qos.logback.access.filter.StatsByDayTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.011 sec Running ch.qos.logback.access.net.URLEvaluatorTest Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.01 sec Running ch.qos.logback.access.net.SocketAppenderTest Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.128 sec Results : Tests run: 28, Failures: 0, Errors: 1, Skipped: 0 [INFO] ------------------------------------------------------------------------ [ERROR] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] There are test failures. [INFO] ------------------------------------------------------------------------ [INFO] For more information, run Maven with the -e switch [INFO] ------------------------------------------------------------------------ [INFO] Total time: 13 seconds [INFO] Finished at: Wed Nov 29 11:00:33 CET 2006 [INFO] Final Memory: 12M/142M [INFO] ------------------------------------------------------------------------ ****************************************************************************

1 0

svn commit: r1029 - in logback/trunk: . logback-access/src/main/java/ch/qos/logback/access/db logback-access/src/test/java/ch/qos/logback/access/db logback-classic/src/test/java/ch/qos/logback/classic/db
by noreply.seb＠qos.ch 29 Nov '06

29 Nov '06

Author: seb Date: Wed Nov 29 10:41:28 2006 New Revision: 1029 Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/db/DBAppender.java logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTestBase.java logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/DBAppenderTestBase.java logback/trunk/pom.xml Log: Added an option to let the user choose if she wants to add the headers to the DB or not Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/db/DBAppender.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/db/DBAppender.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/db/DBAppender.java Wed Nov 29 10:41:28 2006 @@ -35,6 +35,8 @@ protected final String insertHeaderSQL = "INSERT INTO access_event_header (event_id, header_key, header_value) VALUES (?, ?, ?)"; protected static final Method GET_GENERATED_KEYS_METHOD; + private boolean insertHeaders = false; + static { StringBuffer sql = new StringBuffer(); sql.append("INSERT INTO access_event ("); @@ -76,8 +78,10 @@ addWarn("Failed to insert access event"); } - int eventId = getEventId(insertStatement, connection); - addRequestHeaders(event, connection, eventId); + if (insertHeaders) { + int eventId = getEventId(insertStatement, connection); + addRequestHeaders(event, connection, eventId); + } } void addAccessEvent(PreparedStatement stmt, AccessEvent event) @@ -135,4 +139,8 @@ protected String getInsertSQL() { return insertSQL; } + + public void setInsertHeaders(boolean insertHeaders) { + this.insertHeaders = insertHeaders; + } } Modified: logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTestBase.java ============================================================================== --- logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTestBase.java (original) +++ logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTestBase.java Wed Nov 29 10:41:28 2006 @@ -41,6 +41,8 @@ server.setDatabasePath(0, "mem:test;sql.enforce_strict_size=true"); server.setLogWriter(null); server.setErrWriter(null); + server.setTrace(false); + server.setSilent(true); server.start(); } else { if (url == null) { Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/DBAppenderTestBase.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/DBAppenderTestBase.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/DBAppenderTestBase.java Wed Nov 29 10:41:28 2006 @@ -44,6 +44,8 @@ server.setDatabasePath(0, "mem:test;sql.enforce_strict_size=true"); server.setLogWriter(null); server.setErrWriter(null); + server.setTrace(false); + server.setSilent(true); server.start(); } else { if (url == null) { Modified: logback/trunk/pom.xml ============================================================================== --- logback/trunk/pom.xml (original) +++ logback/trunk/pom.xml Wed Nov 29 10:41:28 2006 @@ -89,7 +89,7 @@ <dependency> <groupId>hsqldb</groupId> <artifactId>hsqldb</artifactId> - <version>1.8.0.5</version> + <version>1.8.0.7</version> </dependency> <dependency> <groupId>tomcat</groupId>

1 0

[continuum] BUILD FAILURE: Logback Access Module
by John Noreplai 29 Nov '06

29 Nov '06

Online report : http://localhost:8090/continuum/servlet/continuum/target/ProjectBuild.vm/vi… Build statistics: State: Failed Previous State: Failed Started at: Wed, 29 Nov 2006 10:32:37 +0100 Finished at: Wed, 29 Nov 2006 10:32:50 +0100 Total time: 12s Build Trigger: Forced Exit code: 1 Building machine hostname: pixie Operating system : Linux(unknown) Java version : 1.5.0_08(Sun Microsystems Inc.) Changes No files changed **************************************************************************** Output: **************************************************************************** [INFO] Scanning for projects... [INFO] ---------------------------------------------------------------------------- [INFO] Building Logback Access Module [INFO] task-segment: [clean, install] [INFO] ---------------------------------------------------------------------------- [INFO] [clean:clean] [INFO] Deleting directory /opt/continuum-1.0.3/apps/continuum/working-directory/47/target [INFO] Deleting directory /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/classes [INFO] Deleting directory /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/test-classes [INFO] [resources:resources] [INFO] Using default encoding to copy filtered resources. [INFO] [compiler:compile] Compiling 56 source files to /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/classes [INFO] [resources:testResources] [INFO] Using default encoding to copy filtered resources. [INFO] [compiler:testCompile] Compiling 22 source files to /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/test-classes [INFO] [surefire:test] [INFO] Surefire report directory: /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/surefire-reports ------------------------------------------------------- T E S T S ------------------------------------------------------- Running ch.qos.logback.access.db.DBAppenderTest [Server@7b1ddcde]: [Thread[main,5,main]]: checkRunning(false) entered [Server@7b1ddcde]: [Thread[main,5,main]]: checkRunning(false) exited [Server@7b1ddcde]: [Thread[main,5,main]]: setDatabaseName(0,test) [Server@7b1ddcde]: [Thread[main,5,main]]: checkRunning(false) entered [Server@7b1ddcde]: [Thread[main,5,main]]: checkRunning(false) exited [Server@7b1ddcde]: [Thread[main,5,main]]: setDatabasePath(0,mem:test;sql.enforce_strict_size=true) [Server@624b035d]: [Thread[main,5,main]]: checkRunning(false) entered [Server@624b035d]: [Thread[main,5,main]]: checkRunning(false) exited [Server@624b035d]: [Thread[main,5,main]]: setDatabaseName(0,test) [Server@624b035d]: [Thread[main,5,main]]: checkRunning(false) entered [Server@624b035d]: [Thread[main,5,main]]: checkRunning(false) exited [Server@624b035d]: [Thread[main,5,main]]: setDatabasePath(0,mem:test;sql.enforce_strict_size=true) [Server@2c76e369]: [Thread[main,5,main]]: checkRunning(false) entered [Server@2c76e369]: [Thread[main,5,main]]: checkRunning(false) exited [Server@2c76e369]: [Thread[main,5,main]]: setDatabaseName(0,test) [Server@2c76e369]: [Thread[main,5,main]]: checkRunning(false) entered [Server@2c76e369]: [Thread[main,5,main]]: checkRunning(false) exited [Server@2c76e369]: [Thread[main,5,main]]: setDatabasePath(0,mem:test;sql.enforce_strict_size=true) Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.719 sec <<< FAILURE! Running ch.qos.logback.access.jetty.JettyBasicTest 2006-11-29 10:32:48.547::INFO: Logging to STDERR via org.mortbay.log.StdErrLog 2006-11-29 10:32:48.595::INFO: jetty-6.0.x |-WARN in ch.qos.logback.access.jetty.RequestLogImpl@309cbd4b - filename property not set. Assuming [null/etc/logback-access.xml] |-ERROR in ch.qos.logback.access.jetty.RequestLogImpl@309cbd4b - [null/etc/logback-access.xml] does not exist |-INFO in ch.qos.logback.access.jetty.RequestLogImpl@309cbd4b - RequestLog added to RequestLogRegistry with name: LogbackRequestLog 2006-11-29 10:32:48.658::INFO: Started SelectChannelConnector @ 0.0.0.0:1234 29/11/2006:10:32:48 +0100 localhost 127.0.0.1 Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.291 sec <<< FAILURE! Running ch.qos.logback.access.filter.AccessStatsTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.011 sec Running ch.qos.logback.access.pattern.ConverterTest Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.029 sec Running ch.qos.logback.access.filter.StatsByDayTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.012 sec Running ch.qos.logback.access.net.URLEvaluatorTest Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.009 sec Running ch.qos.logback.access.net.SocketAppenderTest Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.128 sec Results : Tests run: 28, Failures: 0, Errors: 2, Skipped: 0 [INFO] ------------------------------------------------------------------------ [ERROR] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] There are test failures. [INFO] ------------------------------------------------------------------------ [INFO] For more information, run Maven with the -e switch [INFO] ------------------------------------------------------------------------ [INFO] Total time: 11 seconds [INFO] Finished at: Wed Nov 29 10:32:50 CET 2006 [INFO] Final Memory: 12M/116M [INFO] ------------------------------------------------------------------------ ****************************************************************************

1 0

svn commit: r1028 - logback/trunk/logback-site/src/site/resources
by noreply.ceki＠qos.ch 29 Nov '06

29 Nov '06

Author: ceki Date: Wed Nov 29 08:52:24 2006 New Revision: 1028 Modified: logback/trunk/logback-site/src/site/resources/10reasons.ppt Log: ongoing work Modified: logback/trunk/logback-site/src/site/resources/10reasons.ppt ============================================================================== Binary files. No diff available.

1 0

svn commit: r1027 - logback/trunk/logback-site/src/site/resources
by noreply.ceki＠qos.ch 29 Nov '06

29 Nov '06

Author: ceki Date: Wed Nov 29 08:51:06 2006 New Revision: 1027 Added: logback/trunk/logback-site/src/site/resources/modules.EAP (contents, props changed) Modified: logback/trunk/logback-site/src/site/resources/slf4j-slides.vsd Log: ongoing work Added: logback/trunk/logback-site/src/site/resources/modules.EAP ============================================================================== Binary file. No diff available. Modified: logback/trunk/logback-site/src/site/resources/slf4j-slides.vsd ============================================================================== Binary files. No diff available.

1 0

svn commit: r1026 - in logback/trunk: . logback-site/src/site/resources
by noreply.ceki＠qos.ch 28 Nov '06

28 Nov '06

Author: ceki Date: Tue Nov 28 23:17:44 2006 New Revision: 1026 Removed: logback/trunk/sync_logback_ibiblio.sh Modified: logback/trunk/logback-site/src/site/resources/10reasons.ppt Log: ongoing work Modified: logback/trunk/logback-site/src/site/resources/10reasons.ppt ============================================================================== Binary files. No diff available.

1 0

svn commit: r1025 - logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling
by noreply.ceki＠qos.ch 28 Nov '06

28 Nov '06

Author: ceki Date: Tue Nov 28 22:51:48 2006 New Revision: 1025 Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/SizeBasedTriggeringPolicy.java Log: minor refactoring Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/SizeBasedTriggeringPolicy.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/SizeBasedTriggeringPolicy.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/SizeBasedTriggeringPolicy.java Tue Nov 28 22:51:48 2006 @@ -28,6 +28,7 @@ */ public class SizeBasedTriggeringPolicy extends TriggeringPolicyBase { + public static final String SEE_SIZE_FORMAT = "http://logback.qos.ch/codes.html#sbtp_size_format"; /** * The default maximum file size. */ @@ -82,7 +83,7 @@ return Long.valueOf(s).longValue() * multiplier; } catch (NumberFormatException e) { - addError("[" + s + "] is not in proper int form. For more info, please visit http://logback.qos.ch/codes.html#sbtp_size_format"); + addError("[" + s + "] is not in proper int format. Please refer to "+SEE_SIZE_FORMAT); addError("[" + value + "] not in expected format.", e); } }

1 0