September 2006 - logback-dev

[Bug 8] New: The insertion of a percent symbol causes the Parser to crash
by bugzilla-daemon＠pixie.qos.ch 19 Mar '08

19 Mar '08

http://bugzilla.qos.ch/show_bug.cgi?id=8 Summary: The insertion of a percent symbol causes the Parser to crash Product: logback-core Version: unspecified Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2 Component: Pattern AssignedTo: logback-dev(a)qos.ch ReportedBy: noreply.sebastien(a)qos.ch When inserting the percent char twice, so that it appears in the PatternLayout output, a number format exception is thrown. It does not prevent from using normally the PatternLayout. trace: ERROR in ch.qos.logback.core.joran.spi.Interpreter@131f71a - Exception in Action for tag <layout>8:14 java.lang.NumberFormatException: For input string: "% %" java.lang.NumberFormatException: For input string: "% %" at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48) at java.lang.Integer.parseInt(Integer.java:447) at java.lang.Integer.parseInt(Integer.java:497) at ch.qos.logback.core.pattern.FormatInfo.valueOf(FormatInfo.java:70) at ch.qos.logback.core.pattern.parser.Parser.T(Parser.java:84) at ch.qos.logback.core.pattern.parser.Parser.E(Parser.java:51) at ch.qos.logback.core.pattern.parser.Parser.Eopt(Parser.java:107) at ch.qos.logback.core.pattern.parser.Parser.E(Parser.java:55) at ch.qos.logback.core.pattern.parser.Parser.Eopt(Parser.java:107) at ch.qos.logback.core.pattern.parser.Parser.E(Parser.java:55) at ch.qos.logback.core.pattern.parser.Parser.Eopt(Parser.java:107) at ch.qos.logback.core.pattern.parser.Parser.E(Parser.java:55) at ch.qos.logback.core.pattern.parser.Parser.Eopt(Parser.java:107) at ch.qos.logback.core.pattern.parser.Parser.E(Parser.java:55) at ch.qos.logback.core.pattern.parser.Parser.Eopt(Parser.java:107) at ch.qos.logback.core.pattern.parser.Parser.E(Parser.java:55) at ch.qos.logback.core.pattern.parser.Parser.Eopt(Parser.java:107) at ch.qos.logback.core.pattern.parser.Parser.E(Parser.java:55) at ch.qos.logback.core.pattern.parser.Parser.Eopt(Parser.java:107) at ch.qos.logback.core.pattern.parser.Parser.E(Parser.java:55) at ch.qos.logback.core.pattern.parser.Parser.Eopt(Parser.java:107) at ch.qos.logback.core.pattern.parser.Parser.E(Parser.java:55) at ch.qos.logback.core.pattern.parser.Parser.parse(Parser.java:31) at ch.qos.logback.core.pattern.PatternLayoutBase.start(PatternLayoutBase.java:76) at ch.qos.logback.core.joran.action.AbstractLayoutAction.end(AbstractLayoutAction.java:75) at ch.qos.logback.core.joran.spi.Interpreter.callEndAction(Interpreter.java:289) at ch.qos.logback.core.joran.spi.Interpreter.endElement(Interpreter.java:152) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.endElement(AbstractSAXParser.java:633) at com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.scanEndElement(XMLNSDocumentScannerImpl.java:719) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(XMLDocumentFragmentScannerImpl.java:1685) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:368) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:834) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:764) at com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:148) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1242) at javax.xml.parsers.SAXParser.parse(SAXParser.java:375) at ch.qos.logback.core.joran.JoranConfiguratorBase.doConfigure(JoranConfiguratorBase.java:125) at ch.qos.logback.core.joran.JoranConfiguratorBase.doConfigure(JoranConfiguratorBase.java:101) at ch.qos.logback.core.joran.JoranConfiguratorBase.doConfigure(JoranConfiguratorBase.java:84) at ch.qos.logback.core.joran.JoranConfiguratorBase.doConfigure(JoranConfiguratorBase.java:77) at mainPackage.ConfigTester.main(ConfigTester.java:21) -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 5

[Bug 7] New: file and activeFileName params in config
by bugzilla-daemon＠pixie.qos.ch 30 Nov '06

30 Nov '06

http://bugzilla.qos.ch/show_bug.cgi?id=7 Summary: file and activeFileName params in config Product: logback-core Version: unspecified Platform: All OS/Version: All Status: NEW Severity: major Priority: P2 Component: Rolling AssignedTo: logback-dev(a)qos.ch ReportedBy: noreply.sebastien(a)qos.ch In FileAppender, there is a settable "file" attribute. In RollingPolicyBase, there is an activeFileName attribute. Both serve the same point: set a name for the file where the logging will take place. We should propose only one way of specifying this. Maybe suppressing the activeFileName from the RollingPolicyBase class and using the "file" attribute instead. This bug doesn't affect the normal use of logback in a major way. One can still use the rolling functions by specifying the activeFileName attribute. The "file" attribute is ignored in that case. The contrary is not true: if the "file" attribute is specified and no activeFileName is set, the rolling policy will not be able to work correctly. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 3

[Bug 2] New: Missing test case to verify status messages when LoggingContext is not configured
by bugzilla-daemon＠pixie.qos.ch 27 Oct '06

27 Oct '06

http://bugzilla.qos.ch/show_bug.cgi?id=2 Summary: Missing test case to verify status messages when LoggingContext is not configured Product: logback-classic Version: unspecified Platform: PC OS/Version: Windows Status: NEW Severity: blocker Priority: P1 Component: Other AssignedTo: logback-dev(a)qos.ch ReportedBy: noreply.ceki(a)qos.ch We need a test case to check that we do *not* flood the StatusManager when there are no appenders configured in the LoggingContext? -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 2

[Bug 3] New: Source jars
by bugzilla-daemon＠pixie.qos.ch 27 Oct '06

27 Oct '06

http://bugzilla.qos.ch/show_bug.cgi?id=3 Summary: Source jars Product: logback-core Version: unspecified Platform: PC OS/Version: Windows Status: NEW Severity: enhancement Priority: P1 Component: Other AssignedTo: logback-dev(a)qos.ch ReportedBy: noreply.ceki(a)qos.ch We should build source jars and include them in our distribution. This bug applies to all modules. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 2

[Bug 5] New: 'skin' projec as a subproject of logback?
by bugzilla-daemon＠pixie.qos.ch 27 Oct '06

27 Oct '06

http://bugzilla.qos.ch/show_bug.cgi?id=5 Summary: 'skin' projec as a subproject of logback? Product: logback-site Version: unspecified Platform: Other OS/Version: Other Status: NEW Severity: minor Priority: P1 Component: other AssignedTo: logback-dev(a)qos.ch ReportedBy: noreply.ceki(a)qos.ch Could 'skin' be a a subprokect of logback/trunk instead of a sibling of logback? I've done this in SLF4J and it seems to work pretty well. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 2

[Bug 4] New: Print view of short manual with Internet Explorer
by bugzilla-daemon＠pixie.qos.ch 27 Oct '06

27 Oct '06

http://bugzilla.qos.ch/show_bug.cgi?id=4 Summary: Print view of short manual with Internet Explorer Product: logback-site Version: unspecified Platform: PC URL: http://logback.qos.ch/shortIntro.html OS/Version: Windows Status: NEW Severity: blocker Priority: P1 Component: other AssignedTo: logback-dev(a)qos.ch ReportedBy: ceki(a)qos.ch Altough the print preview of http://logback.qos.ch/shortIntro.html looks fine with Firefox, with IE it contains a large space between the author notice and the copyright notice. This is probably due to some invisible elment taking up space. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 3

svn commit: r613 - logback/trunk/logback-access/src/main/java/ch/qos/logback/access/tomcat
by noreply.seb＠qos.ch 29 Sep '06

29 Sep '06

Author: seb Date: Fri Sep 29 18:01:08 2006 New Revision: 613 Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java Log: Work in progress: - LogbackValve now implements the Contained interface from tomcat Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java Fri Sep 29 18:01:08 2006 @@ -6,6 +6,8 @@ import javax.servlet.ServletException; +import org.apache.catalina.Contained; +import org.apache.catalina.Container; import org.apache.catalina.Valve; import org.apache.catalina.connector.Request; import org.apache.catalina.connector.Response; @@ -25,8 +27,8 @@ * directly to LogbackValve and LogbackValve uses the same StatusManager as * LoggerContext does. It also provides containers for properties. * <p> - * To configure tomcat in order to use LogbackValve, the following lines must - * be added to the tomcat's server.xml: + * To configure tomcat in order to use LogbackValve, the following lines must be + * added to the tomcat's server.xml: * * <Valve className="ch.qos.logback.access.tomcat.LogbackValve"/> * @@ -40,15 +42,15 @@ * Here is a sample logback.xml file that can be used right away: * * <pre> - * <configuration> - * <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender"> - * <layout class="ch.qos.logback.access.PatternLayout"> - * <param name="Pattern" value="%date %server %remoteIP %clientHost %user %requestURL " /> - * </layout> - * </appender> - * - * <appender-ref ref="STDOUT" /> - * </configuration> + * <configuration> + * <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender"> + * <layout class="ch.qos.logback.access.PatternLayout"> + * <param name="Pattern" value="%date %server %remoteIP %clientHost %user %requestURL " /> + * </layout> + * </appender> + * + * <appender-ref ref="STDOUT" /> + * </configuration> * </pre> * * A special, module-specific implementation of PatternLayout was implemented to @@ -64,7 +66,7 @@ * @author Ceki Gülcü * @author Sébastien Pennec */ -public class LogbackValve extends ContextBase implements Valve, +public class LogbackValve extends ContextBase implements Valve, Contained, AppenderAttachable { public final static String DEFAULT_CONFIG_FILE = "conf" + File.separatorChar @@ -74,6 +76,7 @@ String filename; boolean started; + Container container; Valve nextValve; public LogbackValve() { @@ -106,6 +109,9 @@ public void invoke(Request request, Response response) throws IOException, ServletException { + + nextValve.invoke(request, response); + // System.out.println("**** LogbackValve invoke called"); TomcatServerAdapter adapter = new TomcatServerAdapter(request, response); AccessEvent accessEvent = new AccessEvent(request, response, adapter); @@ -164,4 +170,12 @@ public void setFileName(String fileName) { this.filename = fileName; } + + public Container getContainer() { + return container; + } + + public void setContainer(Container container) { + this.container = container; + } }

1 0

svn commit: r612 - in logback/trunk/logback-access/src/main/java/ch/qos/logback/access: . pattern spi tomcat
by noreply.seb＠qos.ch 29 Sep '06

29 Sep '06

Author: seb Date: Fri Sep 29 12:11:12 2006 New Revision: 612 Added: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/pattern/RequestParameterConverter.java Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/PatternLayout.java logback/trunk/logback-access/src/main/java/ch/qos/logback/access/spi/AccessEvent.java logback/trunk/logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java logback/trunk/logback-access/src/main/java/ch/qos/logback/access/tomcat/TomcatServerAdapter.java Log: - added a RequestParameterConverter, that works just like the RequestAttributeConverter except for one small obvious detail - added several patterns to PatternLayout Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/PatternLayout.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/PatternLayout.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/PatternLayout.java Fri Sep 29 12:11:12 2006 @@ -16,16 +16,21 @@ import ch.qos.logback.access.pattern.DateConverter; import ch.qos.logback.access.pattern.LineSeparatorConverter; import ch.qos.logback.access.pattern.LocalIPAddressConverter; +import ch.qos.logback.access.pattern.LocalPortConverter; import ch.qos.logback.access.pattern.NAConverter; import ch.qos.logback.access.pattern.PostContentConverter; import ch.qos.logback.access.pattern.RemoteHostConverter; import ch.qos.logback.access.pattern.RemoteIPAddressConverter; import ch.qos.logback.access.pattern.RemoteUserConverter; +import ch.qos.logback.access.pattern.RequestAttributeConverter; +import ch.qos.logback.access.pattern.RequestCookieConverter; import ch.qos.logback.access.pattern.RequestHeaderConverter; import ch.qos.logback.access.pattern.RequestMethodConverter; +import ch.qos.logback.access.pattern.RequestParameterConverter; import ch.qos.logback.access.pattern.RequestProtocolConverter; import ch.qos.logback.access.pattern.RequestURIConverter; import ch.qos.logback.access.pattern.RequestURLConverter; +import ch.qos.logback.access.pattern.ResponseHeaderConverter; import ch.qos.logback.access.pattern.ServerNameConverter; import ch.qos.logback.access.pattern.StatusCodeConverter; import ch.qos.logback.access.spi.AccessEvent; @@ -71,7 +76,6 @@ defaultConverterMap.put("s", StatusCodeConverter.class.getName()); defaultConverterMap.put("statusCode", StatusCodeConverter.class.getName()); - defaultConverterMap.put("t", DateConverter.class.getName()); defaultConverterMap.put("date", DateConverter.class.getName()); @@ -87,6 +91,11 @@ defaultConverterMap.put("p", PostContentConverter.class.getName()); defaultConverterMap.put("post", PostContentConverter.class.getName()); + defaultConverterMap.put("localPort", LocalPortConverter.class.getName()); + defaultConverterMap.put("reqAttribute", RequestAttributeConverter.class.getName()); + defaultConverterMap.put("reqCookie", RequestCookieConverter.class.getName()); + defaultConverterMap.put("responseHeader", ResponseHeaderConverter.class.getName()); + defaultConverterMap.put("reqParameter", RequestParameterConverter.class.getName()); } public PatternLayout() { Added: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/pattern/RequestParameterConverter.java ============================================================================== --- (empty file) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/pattern/RequestParameterConverter.java Fri Sep 29 12:11:12 2006 @@ -0,0 +1,28 @@ +package ch.qos.logback.access.pattern; + +import ch.qos.logback.access.spi.AccessEvent; +import ch.qos.logback.core.util.OptionHelper; + + +public class RequestParameterConverter extends AccessConverter { + + String key; + + public void start() { + key = getFirstOption(); + if (OptionHelper.isEmpty(key)) { + addWarn("Missing key for the request parameter"); + } else { + super.start(); + } + } + + protected String convert(AccessEvent accessEvent) { + if (!isStarted()) { + return "INACTIVE_REQUEST_PARAM_CONV"; + } + + return accessEvent.getRequestParameter(key); + } + +} Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/spi/AccessEvent.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/spi/AccessEvent.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/spi/AccessEvent.java Fri Sep 29 12:11:12 2006 @@ -1,5 +1,6 @@ package ch.qos.logback.access.spi; +import java.io.InputStream; import java.io.Serializable; import java.util.Enumeration; import java.util.HashMap; @@ -229,6 +230,19 @@ } } + public String getRequestParameter(String key) { + if (httpRequest != null) { + Object value = httpRequest.getParameter(key); + if (value == null) { + return AccessEvent.NA; + } else { + return value.toString(); + } + } else { + return AccessEvent.NA; + } + } + public String getCookie(String key) { if (httpRequest != null) { @@ -249,7 +263,8 @@ public long getContentLength() { if (contentLength == SENTINEL) { if (httpResponse != null) { - return serverAdapter.getContentLength(); + contentLength = serverAdapter.getContentLength(); + return contentLength; // if (httpResponse instanceof org.mortbay.jetty.Response) { // // TODO // } else if (httpResponse instanceof @@ -271,7 +286,7 @@ public int getStatusCode() { if (statusCode == SENTINEL) { if (httpResponse != null) { - return serverAdapter.getStatusCode(); + statusCode = serverAdapter.getStatusCode(); // if (httpResponse instanceof org.mortbay.jetty.Response) { // statusCode = ((org.mortbay.jetty.Response) httpResponse).getStatus(); // } else if (httpResponse instanceof @@ -295,7 +310,9 @@ } try { - postContent = Util.readToString(httpRequest.getInputStream()); + InputStream in = httpRequest.getInputStream(); + System.out.println("********InputStream: " + in.toString()); + postContent = Util.readToString(in); } catch (Exception ex) { // do nothing } Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java Fri Sep 29 12:11:12 2006 @@ -147,7 +147,6 @@ } public void backgroundProcess() { - // TODO Auto-generated method stub } public String getInfo() { Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/tomcat/TomcatServerAdapter.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/tomcat/TomcatServerAdapter.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/tomcat/TomcatServerAdapter.java Fri Sep 29 12:11:12 2006 @@ -21,7 +21,7 @@ } public long getContentLength() { - return response.getContentCount(); + return response.getContentLength(); } public int getStatusCode() {

1 0

svn commit: r611 - in logback/trunk/logback-access/src: main/java/ch/qos/logback/access/jetty main/java/ch/qos/logback/access/tomcat test/java/ch/qos/logback/access/jetty
by noreply.seb＠qos.ch 29 Sep '06

29 Sep '06

Author: seb Date: Fri Sep 29 10:55:31 2006 New Revision: 611 Added: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java logback/trunk/logback-access/src/main/java/ch/qos/logback/access/tomcat/TomcatServerAdapter.java Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/jetty/RequestLogImpl.java logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty/JettyBasicTest.java Log: - added LogbackValve, an implementation of tomcat's Valve interface. - added a TomcatServerAdapter - organized imports in RequestLogImpl.java and JettyBasicTest.java. Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/jetty/RequestLogImpl.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/jetty/RequestLogImpl.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/jetty/RequestLogImpl.java Fri Sep 29 10:55:31 2006 @@ -14,7 +14,6 @@ import ch.qos.logback.core.spi.AppenderAttachable; import ch.qos.logback.core.spi.AppenderAttachableImpl; import ch.qos.logback.core.status.ErrorStatus; -import ch.qos.logback.core.util.StatusPrinter; /** * This class is logback's implementation of jetty's RequestLog interface. @@ -55,7 +54,7 @@ * <configuration> * <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender"> * <layout class="ch.qos.logback.access.PatternLayout"> - * <param name="Pattern" value="%date %server %remoteIP %clientHost %user %requestURL %post" /> + * <param name="Pattern" value="%date %server %remoteIP %clientHost %user %requestURL" /> * </layout> * </appender> * @@ -108,7 +107,7 @@ JoranConfigurator jc = new JoranConfigurator(); jc.setContext(this); jc.doConfigure(filename); - StatusPrinter.print(getStatusManager()); + //StatusPrinter.print(getStatusManager()); } else { getStatusManager().add( new ErrorStatus("[" + filename + "] does not exist", this)); Added: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java ============================================================================== --- (empty file) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java Fri Sep 29 10:55:31 2006 @@ -0,0 +1,168 @@ +package ch.qos.logback.access.tomcat; + +import java.io.File; +import java.io.IOException; +import java.util.Iterator; + +import javax.servlet.ServletException; + +import org.apache.catalina.Valve; +import org.apache.catalina.connector.Request; +import org.apache.catalina.connector.Response; + +import ch.qos.logback.access.joran.JoranConfigurator; +import ch.qos.logback.access.spi.AccessEvent; +import ch.qos.logback.core.Appender; +import ch.qos.logback.core.ContextBase; +import ch.qos.logback.core.spi.AppenderAttachable; +import ch.qos.logback.core.spi.AppenderAttachableImpl; +import ch.qos.logback.core.status.ErrorStatus; + +/** + * This class is an implementation of tomcat's Valve interface. + * + * It can be seen as logback classic's LoggerContext. Appenders can be attached + * directly to LogbackValve and LogbackValve uses the same StatusManager as + * LoggerContext does. It also provides containers for properties. + * <p> + * To configure tomcat in order to use LogbackValve, the following lines must + * be added to the tomcat's server.xml: + * + * <Valve className="ch.qos.logback.access.tomcat.LogbackValve"/> + * + * By default, LogbackValve looks for a logback configuration file called + * logback.xml, in the same folder where the tomcat configuration is located, + * that is /conf/logback.xml. The logback.xml file is slightly different than + * the usual logback classic configuration file. Most of it is the same: + * Appenders and Layouts are declared the exact same way. However, loggers + * elements are not allowed. + * <p> + * Here is a sample logback.xml file that can be used right away: + * + * <pre> + * <configuration> + * <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender"> + * <layout class="ch.qos.logback.access.PatternLayout"> + * <param name="Pattern" value="%date %server %remoteIP %clientHost %user %requestURL " /> + * </layout> + * </appender> + * + * <appender-ref ref="STDOUT" /> + * </configuration> + * </pre> + * + * A special, module-specific implementation of PatternLayout was implemented to + * allow http-specific patterns to be used. The + * {@link ch.qos.logback.access.PatternLayout} provides a way to format the + * logging output that is just as easy and flexible as the usual PatternLayout. + * For more information about the general use of a PatternLayout, please refer + * to logback classic's {@link ch.qos.logback.classic.PatternLayout}. For + * information about logback access' specific PatternLayout, please refer to + * it's javadoc. + * <p> + * + * @author Ceki Gülcü + * @author Sébastien Pennec + */ +public class LogbackValve extends ContextBase implements Valve, + AppenderAttachable { + + public final static String DEFAULT_CONFIG_FILE = "conf" + File.separatorChar + + "logback.xml"; + + AppenderAttachableImpl aai = new AppenderAttachableImpl(); + String filename; + boolean started; + + Valve nextValve; + + public LogbackValve() { + // System.out.println("LogbackValve constructor called"); + start(); + } + + public void start() { + if (filename == null) { + String tomcatHomeProperty = System.getProperty("catalina.home"); + + filename = tomcatHomeProperty + File.separatorChar + DEFAULT_CONFIG_FILE; + getStatusManager().add( + new ErrorStatus("filename property not set. Assuming [" + filename + + "]", this)); + + } + File configFile = new File(filename); + if (configFile.exists()) { + JoranConfigurator jc = new JoranConfigurator(); + jc.setContext(this); + jc.doConfigure(filename); + // StatusPrinter.print(getStatusManager()); + } else { + getStatusManager().add( + new ErrorStatus("[" + filename + "] does not exist", this)); + } + started = true; + } + + public void invoke(Request request, Response response) throws IOException, + ServletException { + // System.out.println("**** LogbackValve invoke called"); + TomcatServerAdapter adapter = new TomcatServerAdapter(request, response); + AccessEvent accessEvent = new AccessEvent(request, response, adapter); + // TODO better exception handling + aai.appendLoopOnAppenders(accessEvent); + } + + public void stop() { + started = false; + } + + public void addAppender(Appender newAppender) { + aai.addAppender(newAppender); + } + + public Iterator iteratorForAppenders() { + return aai.iteratorForAppenders(); + } + + public Appender getAppender(String name) { + return aai.getAppender(name); + } + + public boolean isAttached(Appender appender) { + return aai.isAttached(appender); + } + + public void detachAndStopAllAppenders() { + aai.detachAndStopAllAppenders(); + + } + + public boolean detachAppender(Appender appender) { + return aai.detachAppender(appender); + } + + public Appender detachAppender(String name) { + return aai.detachAppender(name); + } + + public void backgroundProcess() { + // TODO Auto-generated method stub + } + + public String getInfo() { + return "logback's valve"; + } + + public Valve getNext() { + return nextValve; + } + + public void setNext(Valve next) { + this.nextValve = next; + } + + public void setFileName(String fileName) { + this.filename = fileName; + } +} Added: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/tomcat/TomcatServerAdapter.java ============================================================================== --- (empty file) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/tomcat/TomcatServerAdapter.java Fri Sep 29 10:55:31 2006 @@ -0,0 +1,34 @@ +package ch.qos.logback.access.tomcat; + +import org.apache.catalina.connector.Request; +import org.apache.catalina.connector.Response; + +import ch.qos.logback.access.spi.ServerAdapter; + +/** + * A tomcat specific implementation of the {@link ServerAdapter} interface. + * + * @author Sébastien Pennec + */ +public class TomcatServerAdapter implements ServerAdapter { + + Request request; + Response response; + + public TomcatServerAdapter(Request tomcatRequest, Response tomcatResponse) { + this.request = tomcatRequest; + this.response = tomcatResponse; + } + + public long getContentLength() { + return response.getContentCount(); + } + + public int getStatusCode() { + return response.getStatus(); + } + + public String getResponseHeader(String key) { + return response.getHeader(key); + } +} Modified: logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty/JettyBasicTest.java ============================================================================== --- logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty/JettyBasicTest.java (original) +++ logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty/JettyBasicTest.java Fri Sep 29 10:55:31 2006 @@ -4,7 +4,6 @@ import java.io.PrintWriter; import java.net.HttpURLConnection; import java.net.URL; -import java.util.Iterator; import junit.framework.Test; import junit.framework.TestCase;

1 0

svn commit: r610 - logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty
by noreply.seb＠qos.ch 28 Sep '06

28 Sep '06

Author: seb Date: Thu Sep 28 15:16:53 2006 New Revision: 610 Modified: logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty/JettyBasicTest.java logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty/JettyTestSetup.java Log: - corrected basic test, it now creates the POST request correctly and retrieves the post content, too. Modified: logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty/JettyBasicTest.java ============================================================================== --- logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty/JettyBasicTest.java (original) +++ logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty/JettyBasicTest.java Thu Sep 28 15:16:53 2006 @@ -54,41 +54,32 @@ } public void testPostContentConverter() throws Exception { - System.out.println("into test"); + //System.out.println("into test"); URL url = new URL("http://localhost:8080/"); + String msg = "test message"; + HttpURLConnection connection = (HttpURLConnection) url.openConnection(); + //this line is necessary to make the stream aware of when the message is over. + connection.setFixedLengthStreamingMode(msg.getBytes().length); ((HttpURLConnection) connection).setRequestMethod("POST"); - connection.setDoOutput(true); connection.setDoInput(true); connection.setUseCaches(false); connection.setRequestProperty("Content-Type", "text/plain"); - // connection.setRequestProperty("Content-Type", - // "application/x-www-form-urlencoded"); - String msg = "test message"; + PrintWriter output = new PrintWriter(new OutputStreamWriter(connection .getOutputStream())); output.print(msg); output.flush(); output.close(); - // System.out.println("length: " + connection.getContentLength()); - - // Reading the response - String result = Util.readToString(connection.getInputStream()); - assertEquals("hello world", result); // StatusPrinter.print(requestLogImpl.getStatusManager()); ListAppender listAppender = (ListAppender) requestLogImpl .getAppender("list"); + Thread.sleep(100); AccessEvent event = (AccessEvent) listAppender.list.get(0); assertEquals(msg, event.getPostContent()); - - Iterator it = listAppender.list.iterator(); - while (it.hasNext()) { - AccessEvent event2 = (AccessEvent) it.next(); - System.out.println("Event PostContent: " + event2.getPostContent()); - } } } Modified: logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty/JettyTestSetup.java ============================================================================== --- logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty/JettyTestSetup.java (original) +++ logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty/JettyTestSetup.java Thu Sep 28 15:16:53 2006 @@ -38,7 +38,7 @@ String url = "http://localhost:8080/"; public void setUp() throws Exception { - System.out.println("into setUp"); + //System.out.println("into setUp"); super.setUp(); server = new Server(); @@ -64,7 +64,7 @@ } public void tearDown() throws Exception { - System.out.println("into tearDown"); + //System.out.println("into tearDown"); super.tearDown(); server.stop(); Thread.sleep(1000);

1 0