April 2007 - logback-dev - mailman3.qos.ch

[Bug 70] New: %throwable does not work
by bugzilla-daemon＠pixie.qos.ch 05 May '07

05 May '07

http://bugzilla.qos.ch/show_bug.cgi?id=70 Summary: %throwable does not work Product: logback-classic Version: unspecified Platform: PC OS/Version: Linux Status: NEW Severity: trivial Priority: P1 Component: Other AssignedTo: logback-dev(a)qos.ch ReportedBy: dirk(a)onesparrow.com According to http://logback.qos.ch/manual/layouts.html#PatternLayout '%throwable' can be used in a pattern, but it is rejected with the message '[throwable] is not a valid conversion word'. %ex does work and this is also clear from the source of PatternLayout.java. So either the documentation needs to be changed or the source adapted to include %throwable. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 2

[Bug 63] New: Bridge error
by bugzilla-daemon＠pixie.qos.ch 03 May '07

03 May '07

http://bugzilla.qos.ch/show_bug.cgi?id=63 Summary: Bridge error Product: logback-general Version: unspecified Platform: PC OS/Version: Windows Status: NEW Severity: blocker Priority: P1 Component: build-structure AssignedTo: logback-dev(a)qos.ch ReportedBy: r.lacanea(a)gmail.com The bridge library for log4j has an error. If the level of log is TRACE generate an Exception: IllegalStateException: Unknown Priority TRACE in class Category, method priorityToLevel() -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 2

[Bug 71] New: LogbackValve misses setFilename(String)
by bugzilla-daemon＠pixie.qos.ch 24 Apr '07

24 Apr '07

http://bugzilla.qos.ch/show_bug.cgi?id=71 Summary: LogbackValve misses setFilename(String) Product: logback-access Version: unspecified Platform: PC OS/Version: Linux Status: NEW Severity: major Priority: P1 Component: Other AssignedTo: logback-dev(a)qos.ch ReportedBy: ml001(a)armbruster-it.de There's no way to specify a different filename for logback-access.xml in LogbackValve because its setter method is missing. The following snippet of server.xml should work: <Valve className="ch.qos.logback.access.tomcat.LogbackValve" filename="my_logback_access.xml"/> But the default logfile ${catalina.home}/conf/logback-access.xml is used instead. Its counterpart for Jetty, namely RequestLogImpl provides such a method - so please add it for Tomcat too. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 0

[continuum] BUILD FAILURE: Logback Classic Module
by John Noreplai 21 Apr '07

21 Apr '07

Online report : http://localhost:8090/continuum/servlet/continuum/target/ProjectBuild.vm/vi… Build statistics: State: Failed Previous State: Ok Started at: Sat, 21 Apr 2007 22:40:30 +0200 Finished at: Sat, 21 Apr 2007 22:40:51 +0200 Total time: 21s Build Trigger: Schedule Exit code: 1 Building machine hostname: pixie Operating system : Linux(unknown) Java version : 1.5.0_08(Sun Microsystems Inc.) Changes ceki aliging with the implementation of toString in BasicMarker (in SLF4J) /logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/MarkerConverter.java **************************************************************************** Output: **************************************************************************** [INFO] Scanning for projects... [INFO] ---------------------------------------------------------------------------- [INFO] Building Logback Classic Module [INFO] task-segment: [clean, install] [INFO] ---------------------------------------------------------------------------- [INFO] [clean:clean] [INFO] Deleting directory /opt/continuum-1.0.3/apps/continuum/working-directory/46/target [INFO] Deleting directory /opt/continuum-1.0.3/apps/continuum/working-directory/46/target/classes [INFO] Deleting directory /opt/continuum-1.0.3/apps/continuum/working-directory/46/target/test-classes [INFO] [resources:resources] [INFO] Using default encoding to copy filtered resources. [INFO] [compiler:compile] Compiling 89 source files to /opt/continuum-1.0.3/apps/continuum/working-directory/46/target/classes [INFO] [retrotranslator:translate {execution: default}] [INFO] Transforming 90 file(s) from /opt/continuum-1.0.3/apps/continuum/working-directory/46/target/classes to /opt/continuum-1.0.3/apps/continuum/working-directory/46/target/logback-classic-0.9.6-SNAPSHOT-jdk14.jar. [INFO] Transformation of 90 file(s) completed successfully. [INFO] [resources:testResources] [INFO] Using default encoding to copy filtered resources. [INFO] [compiler:testCompile] Compiling 89 source files to /opt/continuum-1.0.3/apps/continuum/working-directory/46/target/test-classes [INFO] [surefire:test] [INFO] Surefire report directory: /opt/continuum-1.0.3/apps/continuum/working-directory/46/target/surefire-reports ------------------------------------------------------- T E S T S ------------------------------------------------------- Running ch.qos.logback.classic.LoggerContextTest Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.037 sec Running ch.qos.logback.classic.pattern.ClassNameAbbreviatorTest Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.012 sec Running ch.qos.logback.classic.TurboFilteringInLoggerTest Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.058 sec Running ch.qos.logback.classic.pattern.MDCConverterTest Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.017 sec Running ch.qos.logback.classic.PatternLayoutTest Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.033 sec Running ch.qos.logback.classic.MessageFormattingTest Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.016 sec Running ch.qos.logback.classic.pattern.ConverterTest Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.161 sec Running ch.qos.logback.classic.selector.ContextJNDISelectorTest MockInitialContextFactory static called Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.061 sec Running ch.qos.logback.classic.control.TestAction Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 sec Running ch.qos.logback.classic.DynamicLoggerContextTest Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.174 sec Running ch.qos.logback.classic.util.InitializationTest TEST 22:40:47.550 [main] DEBUG c.q.l.c.util.InitializationTest - Hello-didily-odily TEST 22:40:47.550 [main] DEBUG c.q.l.c.util.InitializationTest - Hello-didily-odily Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.005 sec Running ch.qos.logback.classic.db.DBAppenderTest [Server@2d5253d5]: [Thread[main,5,main]]: checkRunning(false) entered [Server@2d5253d5]: [Thread[main,5,main]]: checkRunning(false) exited [Server@2d5253d5]: [Thread[main,5,main]]: setDatabaseName(0,test) [Server@2d5253d5]: [Thread[main,5,main]]: checkRunning(false) entered [Server@2d5253d5]: [Thread[main,5,main]]: checkRunning(false) exited [Server@2d5253d5]: [Thread[main,5,main]]: setDatabasePath(0,mem:test;sql.enforce_strict_size=true) [Server@23309e87]: [Thread[main,5,main]]: checkRunning(false) entered [Server@23309e87]: [Thread[main,5,main]]: checkRunning(false) exited [Server@23309e87]: [Thread[main,5,main]]: setDatabaseName(0,test) [Server@23309e87]: [Thread[main,5,main]]: checkRunning(false) entered [Server@23309e87]: [Thread[main,5,main]]: checkRunning(false) exited [Server@23309e87]: [Thread[main,5,main]]: setDatabasePath(0,mem:test;sql.enforce_strict_size=true) [Server@6d3f7281]: [Thread[main,5,main]]: checkRunning(false) entered [Server@6d3f7281]: [Thread[main,5,main]]: checkRunning(false) exited [Server@6d3f7281]: [Thread[main,5,main]]: setDatabaseName(0,test) [Server@6d3f7281]: [Thread[main,5,main]]: checkRunning(false) entered [Server@6d3f7281]: [Thread[main,5,main]]: checkRunning(false) exited [Server@6d3f7281]: [Thread[main,5,main]]: setDatabasePath(0,mem:test;sql.enforce_strict_size=true) [Server@2d8941f7]: [Thread[main,5,main]]: checkRunning(false) entered [Server@2d8941f7]: [Thread[main,5,main]]: checkRunning(false) exited [Server@2d8941f7]: [Thread[main,5,main]]: setDatabaseName(0,test) [Server@2d8941f7]: [Thread[main,5,main]]: checkRunning(false) entered [Server@2d8941f7]: [Thread[main,5,main]]: checkRunning(false) exited [Server@2d8941f7]: [Thread[main,5,main]]: setDatabasePath(0,mem:test;sql.enforce_strict_size=true) Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.283 sec Running ch.qos.logback.classic.joran.IncludeFileActionTest Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.049 sec Running ch.qos.logback.classic.html.HTMLLayoutTest Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.673 sec Running ch.qos.logback.classic.control.RandomUtilTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.035 sec Running ch.qos.logback.classic.turbo.MarkerFilterTest LOGBACK: No context given for ch.qos.logback.classic.turbo.MarkerFilter@789934d4 Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.005 sec Running ch.qos.logback.classic.net.SocketAppenderTest Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.556 sec Running ch.qos.logback.classic.control.ScenarioMakerTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.043 sec Running ch.qos.logback.classic.net.LoggingEventSerializationTest Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.013 sec Running ch.qos.logback.classic.control.CLCTest Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.005 sec Running ch.qos.logback.classic.selector.ContextDetachingSCLTest About to detach context named toto No context named toto was found. About to detach context named titi TEST 22:40:50.228 [main] WARN root - Shutting down context titi Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.014 sec Running ch.qos.logback.classic.MDCTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.006 sec Running ch.qos.logback.classic.BasicLoggerTest |-WARN in ch.qos.logback.core.read.ListAppender[null] - Attempted to append to non started appender [null]. Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.014 sec Running ch.qos.logback.classic.net.SMTPAppenderTest Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.242 sec Running ch.qos.logback.classic.boolex.JaninoEventEvaluatorTest Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.356 sec Running ch.qos.logback.classic.joran.EvaluatorJoranTest Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.106 sec Running ch.qos.logback.classic.spi.ContextListenerTest Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.006 sec Running ch.qos.logback.classic.pattern.MarkerConverterTest Tests run: 4, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 0.015 sec <<< FAILURE! Running ch.qos.logback.classic.net.JMSQueueAppenderTest Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.024 sec Running ch.qos.logback.classic.net.JMSTopicAppenderTest Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.015 sec Running ch.qos.logback.classic.net.SyslogAppenderTest Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.223 sec Running ch.qos.logback.classic.joran.BasicJoranTest |-INFO in ch.qos.logback.core.joran.action.AppenderAction - About to instantiate appender of type [ch.qos.logback.core.read.ListAppender] |-INFO in ch.qos.logback.core.joran.action.AppenderAction - Naming appender as [LIST] |-INFO in ch.qos.logback.core.joran.action.AppenderAction - Popping appender named [LIST] from the object stack |-INFO in ch.qos.logback.classic.joran.action.LevelAction - root level set to DEBUG |-INFO in ch.qos.logback.core.joran.action.AppenderRefAction - Attaching appender named [LIST] to Logger[root] |-INFO in ch.qos.logback.classic.joran.action.ConfigurationAction - End of configuration. |-INFO in ch.qos.logback.core.joran.action.AppenderAction - About to instantiate appender of type [ch.qos.logback.core.read.ListAppender] |-INFO in ch.qos.logback.core.joran.action.AppenderAction - Naming appender as [LIST] |-INFO in ch.qos.logback.core.joran.action.AppenderAction - Popping appender named [LIST] from the object stack |-INFO in ch.qos.logback.classic.joran.action.LevelAction - ch.qos.logback.classic.joran level set to INFO |-INFO in ch.qos.logback.classic.joran.action.LevelAction - root level set to DEBUG |-INFO in ch.qos.logback.core.joran.action.AppenderRefAction - Attaching appender named [LIST] to Logger[root] |-INFO in ch.qos.logback.classic.joran.action.ConfigurationAction - End of configuration. |-INFO in ch.qos.logback.classic.joran.action.ConfigurationAction - Ignoring debug attribute. |-WARN in ch.qos.logback.classic.joran.action.EvaluatorAction - Assuming default evaluator class [ch.qos.logback.classic.boolex.JaninoEventEvaluator] |-INFO in ch.qos.logback.classic.joran.action.EvaluatorAction - Adding evaluator named [helloEval] to the object stack |-INFO in ch.qos.logback.core.joran.action.MatcherAction - matcher named as [m] |-INFO in ch.qos.logback.core.joran.action.MatcherAction - Popping appender named [m] from the object stack |-INFO in ch.qos.logback.classic.joran.action.EvaluatorAction - Starting evaluator named [helloEval] |-INFO in ch.qos.logback.core.joran.action.AppenderAction - About to instantiate appender of type [ch.qos.logback.classic.StringListAppender] |-INFO in ch.qos.logback.core.joran.action.AppenderAction - Naming appender as [STR_LIST] |-INFO in ch.qos.logback.core.joran.action.AppenderAction - Popping appender named [STR_LIST] from the object stack |-INFO in ch.qos.logback.classic.joran.action.LevelAction - root level set to DEBUG |-INFO in ch.qos.logback.core.joran.action.AppenderRefAction - Attaching appender named [STR_LIST] to Logger[root] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.038 sec Results : Tests run: 153, Failures: 3, Errors: 0, Skipped: 0 [INFO] ------------------------------------------------------------------------ [ERROR] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] There are test failures. [INFO] ------------------------------------------------------------------------ [INFO] For more information, run Maven with the -e switch [INFO] ------------------------------------------------------------------------ [INFO] Total time: 20 seconds [INFO] Finished at: Sat Apr 21 22:40:51 CEST 2007 [INFO] Final Memory: 20M/199M [INFO] ------------------------------------------------------------------------ ****************************************************************************

1 0

svn commit: r1510 - logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern
by noreply.ceki＠qos.ch 21 Apr '07

21 Apr '07

Author: ceki Date: Sat Apr 21 22:36:17 2007 New Revision: 1510 Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/MarkerConverter.java Log: aliging with the implementation of toString in BasicMarker (in SLF4J) Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/MarkerConverter.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/MarkerConverter.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/pattern/MarkerConverter.java Sat Apr 21 22:36:17 2007 @@ -1,7 +1,5 @@ package ch.qos.logback.classic.pattern; -import java.util.Iterator; - import org.slf4j.Marker; import ch.qos.logback.classic.spi.LoggingEvent; @@ -12,36 +10,16 @@ * @author Sébastien Pennec */ public class MarkerConverter extends ClassicConverter { - + private static String EMPTY = ""; - private static String OPEN = "[ "; - private static String CLOSE = " ]"; - private static String SEP = ", "; - + public String convert(LoggingEvent le) { Marker marker = le.getMarker(); if (marker == null) { return EMPTY; + } else { + return marker.toString(); } - - if (!marker.hasChildren()) { - return marker.getName(); - } - - Iterator it = marker.iterator(); - Marker child; - StringBuffer sb = new StringBuffer(marker.getName()); - sb.append(' ').append(OPEN); - while(it.hasNext()) { - child = (Marker)it.next(); - sb.append(child.getName()); - if (it.hasNext()) { - sb.append(SEP); - } - } - sb.append(CLOSE); - - return sb.toString(); } }

1 0

[Bug 68] New: classloader for loading autoConfig configuration resource
by bugzilla-daemon＠pixie.qos.ch 20 Apr '07

20 Apr '07

http://bugzilla.qos.ch/show_bug.cgi?id=68 Summary: classloader for loading autoConfig configuration resource Product: logback-core Version: unspecified Platform: PC OS/Version: Windows Status: NEW Severity: blocker Priority: P1 Component: Other AssignedTo: logback-dev(a)qos.ch ReportedBy: Filip.Jirsak(a)gmail.com ContextInitializer.autoConfig(LoggerContext) uses current thread context ClassLoader (TCL) nowadays - it calls Thread.currentThread().getContextClassLoader(). Sometimes this classloader has no access to logback classes - for example TCL is parent of classloader, which loaded current class, in oc4j (Oracle J2EE container) at the time of starting servlet container. So logback-*.jar are in WEB-INF/lib directory, but TCL has no access to these jars and to files in WEB-INF/classes. I think ContextInitializer.autoConfig(LoggerContext) should try this.getClass().getClassLoader() first and only if it fails it should use Thread.currentThread().getContextClassLoader(). -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 1

[Bug 66] New: Cannot install eclipse plugin.
by bugzilla-daemon＠pixie.qos.ch 16 Apr '07

16 Apr '07

http://bugzilla.qos.ch/show_bug.cgi?id=66 Summary: Cannot install eclipse plugin. Product: Console Plugin Version: unspecified Platform: PC OS/Version: Windows Status: NEW Severity: blocker Priority: P1 Component: interface AssignedTo: logback-dev(a)qos.ch ReportedBy: sanjeev(a)otto.co.kr Hi, I tried to install the eclipse (eclipse version 3.2 with jdk 1.4.2) plugin as per the documentation on the project site. But when I go to windows --> show view --> Logback --> logback view, I get the error as below: Unable to create view: Plug-in ch.qos.logback.eclipse was unable to load class ch.qos.logback.eclipse.views.LogbackView. java.lang.ClassNotFoundException: ch.qos.logback.eclipse.views.LogbackView at org.eclipse.osgi.framework.internal.core.BundleLoader.findClass(BundleLoader.java:402) at org.eclipse.osgi.framework.internal.core.BundleLoader.findClass(BundleLoader.java:347) at org.eclipse.osgi.internal.baseadaptor.DefaultClassLoader.loadClass(DefaultClassLoader.java:83) at java.lang.ClassLoader.loadClass(ClassLoader.java:235) at org.eclipse.osgi.framework.internal.core.BundleLoader.loadClass(BundleLoader.java:278) at org.eclipse.osgi.framework.internal.core.BundleHost.loadClass(BundleHost.java:227) at org.eclipse.osgi.framework.internal.core.AbstractBundle.loadClass(AbstractBundle.java:1245) at org.eclipse.core.internal.registry.osgi.RegistryStrategyOSGI.createExecutableExtension(RegistryStrategyOSGI.java:147) at org.eclipse.core.internal.registry.ExtensionRegistry.createExecutableExtension(ExtensionRegistry.java:759) at org.eclipse.core.internal.registry.ConfigurationElement.createExecutableExtension(ConfigurationElement.java:243) at org.eclipse.core.internal.registry.ConfigurationElementHandle.createExecutableExtension(ConfigurationElementHandle.java:51) at org.eclipse.ui.internal.WorkbenchPlugin$1.run(WorkbenchPlugin.java:242) at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:67) at org.eclipse.ui.internal.WorkbenchPlugin.createExtension(WorkbenchPlugin.java:238) at org.eclipse.ui.internal.registry.ViewDescriptor.createView(ViewDescriptor.java:69) -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 2

[Bug 65] New: SMTPAppenderBase: authentication options request
by bugzilla-daemon＠pixie.qos.ch 15 Apr '07

15 Apr '07

http://bugzilla.qos.ch/show_bug.cgi?id=65 Summary: SMTPAppenderBase: authentication options request Product: logback-core Version: unspecified Platform: PC URL: http://www.nabble.com/Re%3A-SMTPAppender%3A- authentication-option-missing--p10006781.html OS/Version: All Status: NEW Severity: blocker Priority: P1 Component: Appender AssignedTo: logback-dev(a)qos.ch ReportedBy: hung(a)mxnmedia.com I'm trying to use the SMTPAppender but my SMTP server requires that I authenticate, and it appears that SMTPAppenderBase do not provide the necessary authentication options. I also notice that SMTPAppenderBase uses Transport.send(), and no where does it use transport.connect(...) that accepts username and password. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 0

svn commit: r1509 - in logback/trunk/logback-core/src: main/java/ch/qos/logback/core/rolling test/java/ch/qos/logback/core/rolling
by noreply.jncharpin＠qos.ch 13 Apr '07

13 Apr '07

Author: jncharpin Date: Fri Apr 13 13:05:05 2007 New Revision: 1509 Removed: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/rolling/SubTimeBasedRollingPolicy.java Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/TimeBasedRollingPolicy.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/rolling/TimeBasedRollingTest.java Log: SubTimeBasedRollingPolicy which was used to run the test faster has been deleted. Current time can now be set into TimeBasedRollingPolicy. Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/TimeBasedRollingPolicy.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/TimeBasedRollingPolicy.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/TimeBasedRollingPolicy.java Fri Apr 13 13:05:05 2007 @@ -35,7 +35,10 @@ static final String SEE_FNP_NOT_SET = "See also http://logback.qos.ch/codes.html#tbr_fnp_not_set"; RollingCalendar rc; + long currentTime; long nextCheck; + //indicate whether the time has been forced or not + boolean isTimeForced=false; Date lastCheck = new Date(); String elapsedPeriodsFileName; FileNamePattern activeFileNamePattern; @@ -43,6 +46,21 @@ Compress compress = new Compress(); String lastGeneratedFileName; + public void setCurrentTime(long timeInMillis) { + currentTime = timeInMillis; + isTimeForced = true; + } + + public long getCurrentTime(){ + //if time is forced return the time set by user + if(isTimeForced){ + return currentTime; + } + else{ + return System.currentTimeMillis(); + } + } + public void start() { // set the LR for our utility object util.setContext(this.context); @@ -88,8 +106,8 @@ fileNamePattern.getPattern()+"'."); rc.printPeriodicity(this); - long n = System.currentTimeMillis(); - lastCheck.setTime(n); + //currentTime = System.currentTimeMillis(); + lastCheck.setTime(getCurrentTime()); nextCheck = rc.getNextCheckMillis(lastCheck); //Date nc = new Date(); @@ -168,9 +186,9 @@ } public boolean isTriggeringEvent(File activeFile, final Object event) { - long n = System.currentTimeMillis(); + //currentTime= System.currentTimeMillis(); - if (n >= nextCheck) { + if (getCurrentTime() >= nextCheck) { //addInfo("Time to trigger roll-over"); // We set the elapsedPeriodsFileName before we set the 'lastCheck' variable // The elapsedPeriodsFileName corresponds to the file name of the period @@ -178,7 +196,7 @@ elapsedPeriodsFileName = activeFileNamePattern.convertDate(lastCheck); //addInfo("elapsedPeriodsFileName set to "+elapsedPeriodsFileName); - lastCheck.setTime(n); + lastCheck.setTime(currentTime); nextCheck = rc.getNextCheckMillis(lastCheck); Date x = new Date(); Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/rolling/TimeBasedRollingTest.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/rolling/TimeBasedRollingTest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/rolling/TimeBasedRollingTest.java Fri Apr 13 13:05:05 2007 @@ -90,14 +90,14 @@ rfa.setContext(context); rfa.setLayout(layout); - SubTimeBasedRollingPolicy tbrpt = new SubTimeBasedRollingPolicy(); - tbrpt.setContext(context); - tbrpt.setFileNamePattern(Constants.TEST_DIR_PREFIX + "output/test1-%d{" + TimeBasedRollingPolicy tbrp = new TimeBasedRollingPolicy(); + tbrp.setContext(context); + tbrp.setFileNamePattern(Constants.TEST_DIR_PREFIX + "output/test1-%d{" + DATE_PATTERN + "}"); - tbrpt.setParent(rfa); - tbrpt.setSimulatedTime(currentTime); - tbrpt.start(); - rfa.setRollingPolicy(tbrpt); + tbrp.setParent(rfa); + tbrp.setCurrentTime(currentTime); + tbrp.start(); + rfa.setRollingPolicy(tbrp); rfa.start(); SimpleDateFormat sdf = new SimpleDateFormat(DATE_PATTERN); @@ -110,12 +110,12 @@ } // System.out.println("Waiting until next second and 100 millis."); - tbrpt.setSimulatedTime(addTime(currentTime, 1100)); + tbrp.setCurrentTime(addTime(currentTime, 1100)); // System.out.println("Done waiting."); for (int i = 0; i < 3; i++) { rfa.doAppend("Hello---" + i); - tbrpt.setSimulatedTime(addTime(tbrpt.getSimulatedTime(), 500)); + tbrp.setCurrentTime(addTime(tbrp.getCurrentTime(), 500)); // Thread.sleep(500); } @@ -141,14 +141,14 @@ rfa1.setContext(context); rfa1.setLayout(layout); - SubTimeBasedRollingPolicy tbrpt1 = new SubTimeBasedRollingPolicy(); - tbrpt1.setFileNamePattern(Constants.TEST_DIR_PREFIX + "output/test2-%d{" + TimeBasedRollingPolicy tbrp1 = new TimeBasedRollingPolicy(); + tbrp1.setFileNamePattern(Constants.TEST_DIR_PREFIX + "output/test2-%d{" + DATE_PATTERN + "}"); - tbrpt1.setContext(context); - tbrpt1.setParent(rfa1); - tbrpt1.setSimulatedTime(currentTime); - tbrpt1.start(); - rfa1.setRollingPolicy(tbrpt1); + tbrp1.setContext(context); + tbrp1.setParent(rfa1); + tbrp1.setCurrentTime(currentTime); + tbrp1.start(); + rfa1.setRollingPolicy(tbrp1); rfa1.start(); SimpleDateFormat sdf = new SimpleDateFormat(DATE_PATTERN); @@ -161,12 +161,12 @@ } // System.out.println("Waiting until next second and 100 millis."); - tbrpt1.setSimulatedTime(addTime(currentTime, 1100)); + tbrp1.setCurrentTime(addTime(currentTime, 1100)); // System.out.println("Done waiting."); for (int i = 0; i <= 2; i++) { rfa1.doAppend("Hello---" + i); - tbrpt1.setSimulatedTime(addTime(tbrpt1.getSimulatedTime(), 500)); + tbrp1.setCurrentTime(addTime(tbrp1.getCurrentTime(), 500)); // Thread.sleep(500); } @@ -176,19 +176,19 @@ rfa2.setContext(context); rfa2.setLayout(layout); - SubTimeBasedRollingPolicy tbrpt2 = new SubTimeBasedRollingPolicy(); - tbrpt2.setContext(context); - tbrpt2.setFileNamePattern(Constants.TEST_DIR_PREFIX + "output/test2-%d{" + TimeBasedRollingPolicy tbrp2 = new TimeBasedRollingPolicy(); + tbrp2.setContext(context); + tbrp2.setFileNamePattern(Constants.TEST_DIR_PREFIX + "output/test2-%d{" + DATE_PATTERN + "}"); - tbrpt2.setParent(rfa2); - tbrpt2.setSimulatedTime(tbrpt1.getSimulatedTime()); - tbrpt2.start(); - rfa2.setRollingPolicy(tbrpt2); + tbrp2.setParent(rfa2); + tbrp2.setCurrentTime(tbrp1.getCurrentTime()); + tbrp2.start(); + rfa2.setRollingPolicy(tbrp2); rfa2.start(); for (int i = 0; i <= 2; i++) { rfa2.doAppend("Hello---" + i); - tbrpt2.setSimulatedTime(addTime(tbrpt2.getSimulatedTime(), 100)); + tbrp2.setCurrentTime(addTime(tbrp2.getCurrentTime(), 100)); // Thread.sleep(100); } @@ -210,14 +210,14 @@ rfa.setContext(context); rfa.setLayout(layout); - SubTimeBasedRollingPolicy tbrpt = new SubTimeBasedRollingPolicy(); - tbrpt.setContext(context); - tbrpt.setFileNamePattern(Constants.TEST_DIR_PREFIX + "output/test3-%d{" + TimeBasedRollingPolicy tbrp = new TimeBasedRollingPolicy(); + tbrp.setContext(context); + tbrp.setFileNamePattern(Constants.TEST_DIR_PREFIX + "output/test3-%d{" + DATE_PATTERN + "}.gz"); - tbrpt.setParent(rfa); - tbrpt.setSimulatedTime(currentTime); - tbrpt.start(); - rfa.setRollingPolicy(tbrpt); + tbrp.setParent(rfa); + tbrp.setCurrentTime(currentTime); + tbrp.start(); + rfa.setRollingPolicy(tbrp); rfa.start(); SimpleDateFormat sdf = new SimpleDateFormat(DATE_PATTERN); @@ -233,12 +233,12 @@ + sdf.format(cal.getTime()); // System.out.println("Waiting until next second and 100 millis."); - tbrpt.setSimulatedTime(addTime(currentTime, 1100)); + tbrp.setCurrentTime(addTime(currentTime, 1100)); // System.out.println("Done waiting."); for (int i = 0; i < 3; i++) { rfa.doAppend("Hello---" + i); - tbrpt.setSimulatedTime(addTime(tbrpt.getSimulatedTime(), 500)); + tbrp.setCurrentTime(addTime(tbrp.getCurrentTime(), 500)); } // for (int i = 0; i < 3; i++) { @@ -267,15 +267,15 @@ rfa1.setLayout(layout); rfa1.setFile(Constants.TEST_DIR_PREFIX + "output/test4.log"); - SubTimeBasedRollingPolicy tbrpt1 = new SubTimeBasedRollingPolicy(); - tbrpt1.setContext(context); + TimeBasedRollingPolicy tbrp1 = new TimeBasedRollingPolicy(); + tbrp1.setContext(context); // tbrp1.setActiveFileName(Constants.TEST_DIR_PREFIX + "output/test4.log"); - tbrpt1.setFileNamePattern(Constants.TEST_DIR_PREFIX + "output/test4-%d{" + tbrp1.setFileNamePattern(Constants.TEST_DIR_PREFIX + "output/test4-%d{" + DATE_PATTERN + "}"); - tbrpt1.setParent(rfa1); - tbrpt1.setSimulatedTime(currentTime); - tbrpt1.start(); - rfa1.setRollingPolicy(tbrpt1); + tbrp1.setParent(rfa1); + tbrp1.setCurrentTime(currentTime); + tbrp1.start(); + rfa1.setRollingPolicy(tbrp1); rfa1.start(); SimpleDateFormat sdf = new SimpleDateFormat(DATE_PATTERN); @@ -289,12 +289,12 @@ filenames[2] = Constants.TEST_DIR_PREFIX + "output/test4.log"; // System.out.println("Waiting until next second and 100 millis."); - tbrpt1.setSimulatedTime(addTime(currentTime, 1100)); + tbrp1.setCurrentTime(addTime(currentTime, 1100)); // System.out.println("Done waiting."); for (int i = 0; i <= 2; i++) { rfa1.doAppend("Hello---" + i); - tbrpt1.setSimulatedTime(addTime(tbrpt1.getSimulatedTime(), 500)); + tbrp1.setCurrentTime(addTime(tbrp1.getCurrentTime(), 500)); } rfa1.stop(); @@ -304,20 +304,20 @@ rfa2.setLayout(layout); rfa2.setFile(Constants.TEST_DIR_PREFIX + "output/test4.log"); - SubTimeBasedRollingPolicy tbrpt2 = new SubTimeBasedRollingPolicy(); - tbrpt2.setContext(context); - tbrpt2.setFileNamePattern(Constants.TEST_DIR_PREFIX + "output/test4-%d{" + TimeBasedRollingPolicy tbrp2 = new TimeBasedRollingPolicy(); + tbrp2.setContext(context); + tbrp2.setFileNamePattern(Constants.TEST_DIR_PREFIX + "output/test4-%d{" + DATE_PATTERN + "}"); // tbrp2.setActiveFileName(Constants.TEST_DIR_PREFIX + "output/test4.log"); - tbrpt2.setParent(rfa2); - tbrpt2.setSimulatedTime(tbrpt1.getSimulatedTime()); - tbrpt2.start(); - rfa2.setRollingPolicy(tbrpt2); + tbrp2.setParent(rfa2); + tbrp2.setCurrentTime(tbrp1.getCurrentTime()); + tbrp2.start(); + rfa2.setRollingPolicy(tbrp2); rfa2.start(); for (int i = 0; i <= 2; i++) { rfa2.doAppend("Hello---" + i); - tbrpt2.setSimulatedTime(addTime(tbrpt2.getSimulatedTime(), 100)); + tbrp2.setCurrentTime(addTime(tbrp2.getCurrentTime(), 100)); } for (int i = 0; i < 3; i++) { @@ -339,15 +339,15 @@ rfa.setLayout(layout); rfa.setFile(Constants.TEST_DIR_PREFIX + "output/test5.log"); - SubTimeBasedRollingPolicy tbrpt = new SubTimeBasedRollingPolicy(); - tbrpt.setContext(context); - tbrpt.setFileNamePattern(Constants.TEST_DIR_PREFIX + "output/test5-%d{" + TimeBasedRollingPolicy tbrp = new TimeBasedRollingPolicy(); + tbrp.setContext(context); + tbrp.setFileNamePattern(Constants.TEST_DIR_PREFIX + "output/test5-%d{" + DATE_PATTERN + "}"); // tbrp.setActiveFileName(Constants.TEST_DIR_PREFIX + "output/test5.log"); - tbrpt.setParent(rfa); - tbrpt.setSimulatedTime(currentTime); - tbrpt.start(); - rfa.setRollingPolicy(tbrpt); + tbrp.setParent(rfa); + tbrp.setCurrentTime(currentTime); + tbrp.start(); + rfa.setRollingPolicy(tbrp); rfa.start(); SimpleDateFormat sdf = new SimpleDateFormat(DATE_PATTERN); @@ -362,12 +362,12 @@ filenames[2] = Constants.TEST_DIR_PREFIX + "output/test5.log"; // System.out.println("Waiting until next second and 100 millis."); - tbrpt.setSimulatedTime(addTime(currentTime, 1100)); + tbrp.setCurrentTime(addTime(currentTime, 1100)); // System.out.println("Done waiting."); for (int i = 0; i < 3; i++) { rfa.doAppend("Hello---" + i); - tbrpt.setSimulatedTime(addTime(tbrpt.getSimulatedTime(), 500)); + tbrp.setCurrentTime(addTime(tbrp.getCurrentTime(), 500)); } for (int i = 0; i < 3; i++) { @@ -389,15 +389,15 @@ rfa.setLayout(layout); rfa.setFile(Constants.TEST_DIR_PREFIX + "output/test6.log"); - SubTimeBasedRollingPolicy tbrpt = new SubTimeBasedRollingPolicy(); - tbrpt.setContext(context); - tbrpt.setFileNamePattern(Constants.TEST_DIR_PREFIX + "output/test6-%d{" + TimeBasedRollingPolicy tbrp = new TimeBasedRollingPolicy(); + tbrp.setContext(context); + tbrp.setFileNamePattern(Constants.TEST_DIR_PREFIX + "output/test6-%d{" + DATE_PATTERN + "}.gz"); // tbrp.setActiveFileName(Constants.TEST_DIR_PREFIX + "output/test6.log"); - tbrpt.setParent(rfa); - tbrpt.setSimulatedTime(currentTime); - tbrpt.start(); - rfa.setRollingPolicy(tbrpt); + tbrp.setParent(rfa); + tbrp.setCurrentTime(currentTime); + tbrp.start(); + rfa.setRollingPolicy(tbrp); rfa.start(); SimpleDateFormat sdf = new SimpleDateFormat(DATE_PATTERN); @@ -412,12 +412,12 @@ filenames[2] = Constants.TEST_DIR_PREFIX + "output/test6.log"; // System.out.println("Waiting until next second and 100 millis."); - tbrpt.setSimulatedTime(addTime(currentTime, 1100)); + tbrp.setCurrentTime(addTime(currentTime, 1100)); // System.out.println("Done waiting."); for (int i = 0; i < 3; i++) { rfa.doAppend("Hello---" + i); - tbrpt.setSimulatedTime(addTime(tbrpt.getSimulatedTime(), 500)); + tbrp.setCurrentTime(addTime(tbrp.getCurrentTime(), 500)); } // for (int i = 0; i < 4; i++) { @@ -432,7 +432,7 @@ assertTrue(Compare.compare(filenames[2], Constants.TEST_DIR_PREFIX + "witness/rolling/tbr-test6.2")); } - + public static Test suite() { TestSuite suite = new TestSuite(); suite.addTestSuite(TimeBasedRollingTest.class);

1 0

Possible problem with markers...
by Joern Huxhorn 12 Apr '07

12 Apr '07

Hi guys. I did a quick'n'dirty conversion of Chainsaw to support LOGBack- instead of Log4J-Events. It works but I think I might have found a problem. It's also very well possible that I simply don't understand a LOGBack/SLF4J concept... While testing my changes I tried to send some Markers, too. The first problem I encountered was that the helper class org.slf4j.helpers.BasicMarker has a package-private constructor. I missed that MarkerFactory at that point and wrote my own SimpleMarker that did essentially the same as BasicMarker. This worked but Chainsaw would explode during event deserialization if my SimpleMarker class was not contained in the classpath. Is this expected behaviour or should LOGBacks SocketAppender always use BasicMarker instead of a user-implemented Marker class while serializing log events? I'm really not sure at all. After all, it *could* be worthwhile to use the applications original markers if there is some additional functionality beside tagging a log message... but isn't that in itself a misuse of the marker concept? Beside that, would it be possible to implement SLF4J's BasicMarker.toString somewhat like that: public String toString() { StringBuffer result = new StringBuffer(); result.append("BasicMarker[name=").append(name); if(markers.size()>0) { result.append(", {"); boolean first = true; for (Map.Entry<String, Marker> marker : markers.entrySet()) { if (first) { first = false; } else { result.append(", "); } result.append(marker.getValue()); } result.append("}"); } result.append("]"); return result.toString(); } So it would print contained markers instead of the current generic Object.toString()? This isn't really important but would be nice. Beside the mentioned problem I'm really very happy with LOGBack. I switched a major project a month ago and haven't had any problems beside the missing support in Chainsaw ;). I especially love the ability to change the logging configuration during runtime in a reasonable way. Thanks for all your work, Joern.

1 0