December 2008 - logback-dev

svn commit: r2073 - logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic
by noreply.ceki＠qos.ch 05 Dec '08

05 Dec '08

Author: ceki Date: Fri Dec 5 19:08:41 2008 New Revision: 2073 Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/LoggerContext.java Log: Removed 'synchronized' keyword from the incSize() and size() methods. Synchronization was causing a deadlock described in LBCLASSIC-81 These two methods are used internally by logback for testing purposes. Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/LoggerContext.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/LoggerContext.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/LoggerContext.java Fri Dec 5 19:08:41 2008 @@ -54,8 +54,7 @@ // We want loggerCache to be synchronized so Hashtable is a good choice. In // practice, it performs a little faster than the map returned by - // Collections.synchronizedMap at the - // cost of a very slightly higher memory footprint. + // Collections.synchronizedMap at the cost of a very slightly higher memory footprint. private Hashtable<String, Logger> loggerCache; private LoggerContextRemoteView loggerContextRemoteView; @@ -151,11 +150,11 @@ } } - private synchronized void incSize() { + private void incSize() { size++; } - synchronized int size() { + int size() { return size; }

1 0

[JIRA] Created: (LBCORE-70) Compressing log files does not work correctly
by Alain Oberdörfer (JIRA) 05 Dec '08

05 Dec '08

Compressing log files does not work correctly --------------------------------------------- Key: LBCORE-70 URL: http://jira.qos.ch/browse/LBCORE-70 Project: logback-core Issue Type: Bug Components: Rolling Affects Versions: 0.9.11 Environment: JVM 1.6.10 Windows 2003 Server GigaSpaces 6.0 Reporter: Alain Oberdörfer Assignee: Logback dev list In our environment compressing log files does not work correctly. As example here is the logger configuration: <appender name="rdf-api-debug-file-appender" class="ch.qos.logback.core.rolling.RollingFileAppender"> <append>true</append> <filter class="ch.qos.logback.classic.filter.ThresholdFilter"> <level>debug</level> </filter> <rollingPolicy class="ch.qos.logback.core.rolling.TimeBasedRollingPolicy"> <fileNamePattern>D:/Temp/rdf-files/logs/%d{yyyy-MM-dd}/debug/rdf-api-debug.log.gz</fileNamePattern> </rollingPolicy> <layout class="ch.qos.logback.classic.PatternLayout"> <pattern>%date,%-5level,%logger,%thread,%message%n</pattern> </layout> </appender> At Nov, 5th I see a directory "D:/Temp/rdf-files/logs/2008-11-04/debug" with the following files (and time of last modifucation): rdf-api-debug.log, November 05, 2008, 12:12:26 AM rdf-api-debug.log855980476945031.tmp, November 05, 2008, 12:11:52 AM rdf-api-debug.log856014875320881.tmp, November 05, 2008, 12:12:26 AM rdf-api-debug.log.gz, November 05, 2008, 12:11:53 AM The first three files and the log file in the .gz-archive have all the same size. So compression works, but the original log file and the temporary files are not deleted. Our application uses several threads, perhaps this causes the problem. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 5

svn commit: r2072 - logback/trunk/logback-core/src/main/java/ch/qos/logback/core/status
by noreply.ceki＠qos.ch 05 Dec '08

05 Dec '08

Author: ceki Date: Fri Dec 5 18:13:07 2008 New Revision: 2072 Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/status/StatusBase.java Log: The getEffectiveLevel() method needs to be synchronized to protect against concurrent modification when iterating over childrenList.iterator(). Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/status/StatusBase.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/status/StatusBase.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/status/StatusBase.java Fri Dec 5 18:13:07 2008 @@ -62,17 +62,19 @@ if (childrenList == null) { return false; } - - // TODO also search in childrens' childrens + // TODO also search in childrens' children return childrenList.remove(statusToRemove); - } public int getLevel() { return level; } - public int getEffectiveLevel() { + // status messages are not supposed to contains cycles. + // cyclic status arrangements are like to cause deadlocks + // when this method is called from different thread on + // different status objects lying on the same cycle + public synchronized int getEffectiveLevel() { int result = level; int effLevel; @@ -85,7 +87,6 @@ result = effLevel; } } - return result; }

1 0

svn commit: r2071 - logback/trunk/logback-core/src/main/java/ch/qos/logback/core
by noreply.ceki＠qos.ch 05 Dec '08

05 Dec '08

Author: ceki Date: Fri Dec 5 17:53:29 2008 New Revision: 2071 Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/BasicStatusManager.java Log: - using explicit locks instead of relying on the internal details of the collection returned by Collections.synchronizedList() Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/BasicStatusManager.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/BasicStatusManager.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/BasicStatusManager.java Fri Dec 5 17:53:29 2008 @@ -1,16 +1,15 @@ /** - * LOGBack: the reliable, fast and flexible logging library for Java. - * - * Copyright (C) 1999-2006, QOS.ch - * - * This library is free software, you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public License as - * published by the Free Software Foundation. + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2008, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. */ package ch.qos.logback.core; import java.util.ArrayList; -import java.util.Collections; import java.util.List; import ch.qos.logback.core.status.Status; @@ -21,23 +20,24 @@ public static final int MAX_COUNT = 200; - // This method is synchronized on the instance. - // Code int count = 0; - // reading SynchronizedCollection source code, we learn that the mutex is the - // returned synchronized list, we make use of this fact in getCopyOfStatusList // protected access was requested in http://jira.qos.ch/browse/LBCORE-36 - final protected List<Status> statusList = Collections - .synchronizedList(new ArrayList<Status>()); + final protected List<Status> statusList = new ArrayList<Status>(); + final protected Object statusListLock = new Object(); + int level = Status.INFO; - // reading SynchronizedCollection source code, we learn that the mutex is the - // returned synchronized list, we make use of this fact in - // getCopyOfStatusListnerList // protected access was requested in http://jira.qos.ch/browse/LBCORE-36 - final protected List<StatusListener> statusListenerList = Collections - .synchronizedList(new ArrayList<StatusListener>()); + final protected List<StatusListener> statusListenerList = new ArrayList<StatusListener>(); + final protected Object statusListenerListLock = new Object(); + + // Note on synchronization + // This class contains two separate locks statusListLock and + // statusListenerListLock guarding respectively the statusList and + // statusListenerList fields. The locks are used internally + // without cycles. They are exposed to derived classes which should be careful + // not to create deadlock cycles. /** * Add a new status object. @@ -46,9 +46,9 @@ * the status message to add */ public void add(Status newStatus) { - // LBCORE-72: fire event before the count check + // LBCORE-72: fire event before the count check fireStatusAddEvent(newStatus); - + if (count > MAX_COUNT) { return; } @@ -57,12 +57,15 @@ if (newStatus.getLevel() > level) { level = newStatus.getLevel(); } - statusList.add(newStatus); + + synchronized (statusListLock) { + statusList.add(newStatus); + } } private void fireStatusAddEvent(Status status) { - synchronized (statusListenerList) { + synchronized (statusListenerListLock) { for (StatusListener sl : statusListenerList) { sl.addStatusEvent(status); } @@ -70,7 +73,7 @@ } public List<Status> getCopyOfStatusList() { - synchronized (statusList) { + synchronized (statusListLock) { return new ArrayList<Status>(statusList); } } @@ -84,15 +87,19 @@ } public void add(StatusListener listener) { - statusListenerList.add(listener); + synchronized (statusListenerListLock) { + statusListenerList.add(listener); + } } public void remove(StatusListener listener) { - statusListenerList.remove(listener); + synchronized (statusListenerListLock) { + statusListenerList.remove(listener); + } } public List<StatusListener> getCopyOfStatusListenerList() { - synchronized (statusListenerList) { + synchronized (statusListenerListLock) { return new ArrayList<StatusListener>(statusListenerList); } }

1 0

svn commit: r2070 - in logback/trunk: . logback-access logback-classic logback-core logback-examples logback-site
by noreply.ceki＠qos.ch 05 Dec '08

05 Dec '08

Author: ceki Date: Fri Dec 5 11:40:20 2008 New Revision: 2070 Modified: logback/trunk/logback-access/pom.xml logback/trunk/logback-classic/pom.xml logback/trunk/logback-core/pom.xml logback/trunk/logback-examples/pom.xml logback/trunk/logback-site/pom.xml logback/trunk/pom.xml Log: starting work on 0.9.14-SNAPSHOT Modified: logback/trunk/logback-access/pom.xml ============================================================================== --- logback/trunk/logback-access/pom.xml (original) +++ logback/trunk/logback-access/pom.xml Fri Dec 5 11:40:20 2008 @@ -5,7 +5,7 @@ <parent> <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>0.9.13</version> + <version>0.9.14-SNAPSHOT</version> </parent> <modelVersion>4.0.0</modelVersion> Modified: logback/trunk/logback-classic/pom.xml ============================================================================== --- logback/trunk/logback-classic/pom.xml (original) +++ logback/trunk/logback-classic/pom.xml Fri Dec 5 11:40:20 2008 @@ -5,7 +5,7 @@ <parent> <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>0.9.13</version> + <version>0.9.14-SNAPSHOT</version> </parent> <modelVersion>4.0.0</modelVersion> Modified: logback/trunk/logback-core/pom.xml ============================================================================== --- logback/trunk/logback-core/pom.xml (original) +++ logback/trunk/logback-core/pom.xml Fri Dec 5 11:40:20 2008 @@ -5,7 +5,7 @@ <parent> <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>0.9.13</version> + <version>0.9.14-SNAPSHOT</version> </parent> <modelVersion>4.0.0</modelVersion> Modified: logback/trunk/logback-examples/pom.xml ============================================================================== --- logback/trunk/logback-examples/pom.xml (original) +++ logback/trunk/logback-examples/pom.xml Fri Dec 5 11:40:20 2008 @@ -5,7 +5,7 @@ <parent> <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>0.9.13</version> + <version>0.9.14-SNAPSHOT</version> </parent> <modelVersion>4.0.0</modelVersion> Modified: logback/trunk/logback-site/pom.xml ============================================================================== --- logback/trunk/logback-site/pom.xml (original) +++ logback/trunk/logback-site/pom.xml Fri Dec 5 11:40:20 2008 @@ -3,7 +3,7 @@ <parent> <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>0.9.13</version> + <version>0.9.14-SNAPSHOT</version> </parent> <modelVersion>4.0.0</modelVersion> Modified: logback/trunk/pom.xml ============================================================================== --- logback/trunk/pom.xml (original) +++ logback/trunk/pom.xml Fri Dec 5 11:40:20 2008 @@ -5,7 +5,7 @@ <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>0.9.13</version> + <version>0.9.14-SNAPSHOT</version> <packaging>pom</packaging> <name>Logback-Parent</name>

1 0

svn commit: r2069 - logback/tags/release_0.9.13/trunk
by noreply.ceki＠qos.ch 05 Dec '08

05 Dec '08

Author: ceki Date: Fri Dec 5 11:38:30 2008 New Revision: 2069 Added: logback/tags/release_0.9.13/trunk/ - copied from r2068, /logback/trunk/ Log: tagging 0.9.13

1 0

svn commit: r2068 - logback/tags/release_0.9.13
by noreply.ceki＠qos.ch 05 Dec '08

05 Dec '08

Author: ceki Date: Fri Dec 5 11:38:00 2008 New Revision: 2068 Added: logback/tags/release_0.9.13/ Log: tagging 0.9.13

1 0

Release of logback version 0.9.13
by Ceki Gulcu 05 Dec '08

05 Dec '08

5th of December 2008 - Release of version 0.9.13 Version 0.9.13 is a maintenance release fixing LBCLASSIC-91, a severe bug introduced in logback version 0.9.12. Please refer to the the news page for precise details. http://logback.qos.ch/news.html You can download logback, including full source code, class files and documentation on our download page, shown below. http://logback.qos.ch/download.html You can receive logback related announcements by subscribing to the logback announce mailing list. To subscribe to logback-announce list, please visit the following URL. http://qos.ch/mailman/listinfo/logback-announce -- Ceki Gülcü Logback: The reliable, generic, fast and flexible logging framework for Java. http://logback.qos.ch

1 0

svn commit: r2067 - in logback/trunk: . logback-access logback-classic logback-core logback-examples logback-site
by noreply.ceki＠qos.ch 05 Dec '08

05 Dec '08

Author: ceki Date: Fri Dec 5 11:16:19 2008 New Revision: 2067 Modified: logback/trunk/logback-access/pom.xml logback/trunk/logback-classic/pom.xml logback/trunk/logback-core/pom.xml logback/trunk/logback-examples/pom.xml logback/trunk/logback-site/pom.xml logback/trunk/pom.xml Log: - preparing release 0.9.13 Modified: logback/trunk/logback-access/pom.xml ============================================================================== --- logback/trunk/logback-access/pom.xml (original) +++ logback/trunk/logback-access/pom.xml Fri Dec 5 11:16:19 2008 @@ -5,7 +5,7 @@ <parent> <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>0.9.12</version> + <version>0.9.13</version> </parent> <modelVersion>4.0.0</modelVersion> Modified: logback/trunk/logback-classic/pom.xml ============================================================================== --- logback/trunk/logback-classic/pom.xml (original) +++ logback/trunk/logback-classic/pom.xml Fri Dec 5 11:16:19 2008 @@ -5,7 +5,7 @@ <parent> <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>0.9.12</version> + <version>0.9.13</version> </parent> <modelVersion>4.0.0</modelVersion> Modified: logback/trunk/logback-core/pom.xml ============================================================================== --- logback/trunk/logback-core/pom.xml (original) +++ logback/trunk/logback-core/pom.xml Fri Dec 5 11:16:19 2008 @@ -5,7 +5,7 @@ <parent> <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>0.9.12</version> + <version>0.9.13</version> </parent> <modelVersion>4.0.0</modelVersion> Modified: logback/trunk/logback-examples/pom.xml ============================================================================== --- logback/trunk/logback-examples/pom.xml (original) +++ logback/trunk/logback-examples/pom.xml Fri Dec 5 11:16:19 2008 @@ -5,7 +5,7 @@ <parent> <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>0.9.12</version> + <version>0.9.13</version> </parent> <modelVersion>4.0.0</modelVersion> Modified: logback/trunk/logback-site/pom.xml ============================================================================== --- logback/trunk/logback-site/pom.xml (original) +++ logback/trunk/logback-site/pom.xml Fri Dec 5 11:16:19 2008 @@ -3,7 +3,7 @@ <parent> <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>0.9.12</version> + <version>0.9.13</version> </parent> <modelVersion>4.0.0</modelVersion> Modified: logback/trunk/pom.xml ============================================================================== --- logback/trunk/pom.xml (original) +++ logback/trunk/pom.xml Fri Dec 5 11:16:19 2008 @@ -5,7 +5,7 @@ <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>0.9.12</version> + <version>0.9.13</version> <packaging>pom</packaging> <name>Logback-Parent</name>

1 0

[JIRA] Created: (LBCLASSIC-91) Logger.setLevel(null) may throw NPE
by mateusz jedruch (JIRA) 05 Dec '08

05 Dec '08

Logger.setLevel(null) may throw NPE ----------------------------------- Key: LBCLASSIC-91 URL: http://jira.qos.ch/browse/LBCLASSIC-91 Project: logback-classic Issue Type: Bug Affects Versions: 0.9.12 Reporter: mateusz jedruch Assignee: Logback dev list When setting null for logger which has childes with null levels then NPE is thrown: Caused by: java.lang.NullPointerException at ch.qos.logback.classic.Logger.handleParentLevelChange(Logger.java:216) [classes/:na] at ch.qos.logback.classic.Logger.setLevel(Logger.java:200) [classes/:na] .... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 5