December 2008 - logback-dev

[JIRA] Created: (LBCLASSIC-89) stop() method is not called on TurboFilter when shutdownAndReset is performed.
by alexis morillo (JIRA) 30 Dec '08

30 Dec '08

stop() method is not called on TurboFilter when shutdownAndReset is performed. ------------------------------------------------------------------------------ Key: LBCLASSIC-89 URL: http://jira.qos.ch/browse/LBCLASSIC-89 Project: logback-classic Issue Type: Bug Components: Other Affects Versions: 0.9.11 Environment: Windows xp. Reporter: alexis morillo Assignee: Logback dev list Priority: Minor I use the following code to initialize and reload logback configuration : LoggerContext lc = (LoggerContext) LoggerFactory.getILoggerFactory(); JoranConfigurator configurator = new JoranConfigurator(); configurator.setContext(lc); lc.shutdownAndReset(); configurator.doConfigure(logFile); I have a turbofilter that needs to do some stuff when stopped. Though, the stop() method is not called in that case. So I added the following code before the shutdownandreset : TurboFilter tbf = lc.getFirstTurboFilter(); while(tbf != null) { tbf.stop(); tbf = tbf.getNext(); } This is the only workaround I found. Is there any way to do better ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 3

svn commit: r2116 - in logback/trunk/logback-classic/src: main/java/ch/qos/logback/classic test/java/ch/qos/logback/classic
by noreply.ceki＠qos.ch 30 Dec '08

30 Dec '08

Author: ceki Date: Tue Dec 30 12:48:16 2008 New Revision: 2116 Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/LoggerContext.java logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/LoggerContextTest.java Log: - LoggerContext reset, registered turbo filters are first stopped before being unregistered. This fixes LBCLASSIC-89. Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/LoggerContext.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/LoggerContext.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/LoggerContext.java Tue Dec 30 12:48:16 2008 @@ -54,7 +54,8 @@ // We want loggerCache to be synchronized so Hashtable is a good choice. In // practice, it performs a little faster than the map returned by - // Collections.synchronizedMap at the cost of a very slightly higher memory footprint. + // Collections.synchronizedMap at the cost of a very slightly higher memory + // footprint. private Hashtable<String, Logger> loggerCache; private LoggerContextRemoteView loggerContextRemoteView; @@ -193,13 +194,12 @@ */ public void reset() { root.recursiveReset(); - clearAllTurboFilters(); + resetTurboFilterList(); fireOnReset(); resetListenersExceptResetResistant(); resetStatusListeners(); } - private void resetStatusListeners() { StatusManager sm = getStatusManager(); for (StatusListener sl : sm.getCopyOfStatusListenerList()) { @@ -215,7 +215,14 @@ turboFilterList.add(newFilter); } - public void clearAllTurboFilters() { + /** + * First stop all registered turbo filters and then clear the registration + * list. + */ + public void resetTurboFilterList() { + for (TurboFilter tf : turboFilterList) { + tf.stop(); + } turboFilterList.clear(); } Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/LoggerContextTest.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/LoggerContextTest.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/LoggerContextTest.java Tue Dec 30 12:48:16 2008 @@ -9,11 +9,17 @@ */ package ch.qos.logback.classic; -import static org.junit.Assert.*; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertFalse; +import static org.junit.Assert.assertNotNull; +import static org.junit.Assert.assertNull; +import static org.junit.Assert.assertTrue; +import static org.junit.Assert.fail; import org.junit.Before; import org.junit.Test; +import ch.qos.logback.classic.turbo.NOPTurboFilter; import ch.qos.logback.core.status.StatusManager; public class LoggerContextTest { @@ -170,6 +176,16 @@ assertEquals(Level.DEBUG, root.getLevel()); assertNull(a.getLevel()); assertNull(ab.getLevel()); - + } + + // http://jira.qos.ch/browse/LBCLASSIC-89 + @Test + public void turboFilterStopOnReset() { + NOPTurboFilter nopTF = new NOPTurboFilter(); + nopTF.start(); + lc.addTurboFilter(nopTF); + assertTrue(nopTF.isStarted()); + lc.reset(); + assertFalse(nopTF.isStarted()); } } \ No newline at end of file

1 0

[JIRA] Closed: (LBCLASSIC-54) TurboFilterAttachableImpl.addTurboFilter() will behave funny if newFilter.turboNext != null
by Ceki Gulcu (JIRA) 30 Dec '08

30 Dec '08

[ http://jira.qos.ch/browse/LBCLASSIC-54?page=com.atlassian.jira.plugin.syste… ] Ceki Gulcu closed LBCLASSIC-54. ------------------------------- > TurboFilterAttachableImpl.addTurboFilter() will behave funny if newFilter.turboNext != null > ------------------------------------------------------------------------------------------- > > Key: LBCLASSIC-54 > URL: http://jira.qos.ch/browse/LBCLASSIC-54 > Project: logback-classic > Issue Type: Bug > Reporter: Anton Tagunov > Assignee: Logback dev list > Priority: Minor > Fix For: 0.9.14 > > Attachments: ChainIterationPerfTest.java > > > Hi! > addTurboFilter() sets tailFilter incorrectly if newFilter.nextFilter != null > Here's what I was trying to do. > I implement a new TurboFilter. > This TurboFilter is an interceptor that captures log messages and stores them for analysis. > This is part of Unit Test. This Unit Test has to ensure that a specific message has been logged. > This TurboFilter is not configured via logback.xml > It can be but I don't want that to be mandatory. > Instead this TurboFilter needs to bind itself to LoggerContext programmatically, via Logback API. > It also need to bind itself as _the first filter in the chain_. > Here's how I've tried to do it: > final LogbackMessageProducer nuvo = new LogbackMessageProducer(true); > > /* make sure we're the first in the chain */ > final TurboFilter oldFirst = tfa.getFirstTurboFilter(); > nuvo.setNext(oldFirst); > > tfa.clearAllTurboFilters(); > tfa.addTurboFilter(nuvo); > However should somebody else call addTurboFilter(some-other-filter) after this behavior shall be funny. > Basically all old turbo filters that were bound before my code executed shall be lost. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Resolved: (LBCLASSIC-54) TurboFilterAttachableImpl.addTurboFilter() will behave funny if newFilter.turboNext != null
by Ceki Gulcu (JIRA) 30 Dec '08

30 Dec '08

[ http://jira.qos.ch/browse/LBCLASSIC-54?page=com.atlassian.jira.plugin.syste… ] Ceki Gulcu resolved LBCLASSIC-54. --------------------------------- Fix Version/s: 0.9.14 Resolution: Fixed The TurboFitler code has been heavily refactored in revision 1931. > TurboFilterAttachableImpl.addTurboFilter() will behave funny if newFilter.turboNext != null > ------------------------------------------------------------------------------------------- > > Key: LBCLASSIC-54 > URL: http://jira.qos.ch/browse/LBCLASSIC-54 > Project: logback-classic > Issue Type: Bug > Reporter: Anton Tagunov > Assignee: Logback dev list > Priority: Minor > Fix For: 0.9.14 > > Attachments: ChainIterationPerfTest.java > > > Hi! > addTurboFilter() sets tailFilter incorrectly if newFilter.nextFilter != null > Here's what I was trying to do. > I implement a new TurboFilter. > This TurboFilter is an interceptor that captures log messages and stores them for analysis. > This is part of Unit Test. This Unit Test has to ensure that a specific message has been logged. > This TurboFilter is not configured via logback.xml > It can be but I don't want that to be mandatory. > Instead this TurboFilter needs to bind itself to LoggerContext programmatically, via Logback API. > It also need to bind itself as _the first filter in the chain_. > Here's how I've tried to do it: > final LogbackMessageProducer nuvo = new LogbackMessageProducer(true); > > /* make sure we're the first in the chain */ > final TurboFilter oldFirst = tfa.getFirstTurboFilter(); > nuvo.setNext(oldFirst); > > tfa.clearAllTurboFilters(); > tfa.addTurboFilter(nuvo); > However should somebody else call addTurboFilter(some-other-filter) after this behavior shall be funny. > Basically all old turbo filters that were bound before my code executed shall be lost. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Created: (LBCORE-77) When calling the shutdownandreset method of the loggercontext, Status list of the statusmanager is not reset.
by alexis morillo (JIRA) 30 Dec '08

30 Dec '08

When calling the shutdownandreset method of the loggercontext, Status list of the statusmanager is not reset. ------------------------------------------------------------------------------------------------------------- Key: LBCORE-77 URL: http://jira.qos.ch/browse/LBCORE-77 Project: logback-core Issue Type: Bug Affects Versions: 0.9.11 Reporter: alexis morillo Assignee: Logback dev list Priority: Minor To implement the reloading of confifguration, I had to call each time the shutdownandreset followed by the doconfigure. Thought, as the statuslist in BasicStatusManager is not reset at this time, when it reaches 200 entries, it stops logging, even if the debug mode is true. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 2

svn commit: r2115 - in logback/trunk/logback-core/src/main/java/ch/qos/logback/core: . status
by noreply.ceki＠qos.ch 30 Dec '08

30 Dec '08

Author: ceki Date: Tue Dec 30 11:20:19 2008 New Revision: 2115 Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/BasicStatusManager.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/Context.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/status/StatusManager.java Log: - allow clearing of the status list. This addresses LBCORE-77 Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/BasicStatusManager.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/BasicStatusManager.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/BasicStatusManager.java Tue Dec 30 11:20:19 2008 @@ -20,7 +20,7 @@ public class BasicStatusManager implements StatusManager { public static final int MAX_HEADER_COUNT = 150; - public static final int TAIL_SIZE = 150; + public static final int TAIL_SIZE = 150; int count = 0; @@ -67,6 +67,7 @@ } } + public List<Status> getCopyOfStatusList() { synchronized (statusListLock) { List<Status> tList = new ArrayList<Status>(statusList); @@ -74,7 +75,7 @@ return tList; } } - + private void fireStatusAddEvent(Status status) { synchronized (statusListenerListLock) { for (StatusListener sl : statusListenerList) { @@ -83,6 +84,14 @@ } } + public void clear() { + synchronized (statusListLock) { + count = 0; + statusList.clear(); + tailBuffer.clear(); + } + } + public int getLevel() { return level; } Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/Context.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/Context.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/Context.java Tue Dec 30 11:20:19 2008 @@ -12,20 +12,29 @@ import ch.qos.logback.core.spi.PropertyContainer; import ch.qos.logback.core.status.StatusManager; - +/** + * A context is the main anchorage point of all logback components. + * + * @author Ceki Gulcu + * + */ public interface Context extends PropertyContainer { - - StatusManager getStatusManager(); - /** - * A Context can act as a store for various objects used - * by LOGBack components. + * Return the StatusManager instance in use. + * + * @return the {@link StatusManager} instance in use. + */ + public StatusManager getStatusManager(); + + /** + * A Context can act as a store for various objects used by LOGBack + * components. * * @return The object stored under 'key'. */ public Object getObject(String key); - + /** * Store an object under 'key'. If no object can be found, null is returned. * @@ -33,34 +42,35 @@ * @param value */ public void putObject(String key, Object value); - + /** - * Get all the properties for this context as a Map. Note that - * the returned cop might be a copy not the original. Thus, modifying - * the returned Map will have no effect (on the original.) + * Get all the properties for this context as a Map. Note that the returned + * cop might be a copy not the original. Thus, modifying the returned Map will + * have no effect (on the original.) + * * @return */ - //public Map<String, String> getPropertyMap(); - - /** + // public Map<String, String> getPropertyMap(); + /** * Get the property of this context. */ public String getProperty(String key); - /** + /** * Set a property of this context. */ public void putProperty(String key, String value); - + /** * Contexts are named objects. * * @return the name for this context */ public String getName(); - + /** * The name of the context can be set only once. + * * @param name */ public void setName(String name); Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/status/StatusManager.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/status/StatusManager.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/status/StatusManager.java Tue Dec 30 11:20:19 2008 @@ -46,10 +46,26 @@ */ public int getCount(); + /** + * Add a status listener. + * @param listener + */ public void add(StatusListener listener); - + + /** + * Remove a status listener. + * + * @param listener + */ public void remove(StatusListener listener); + + /** + * Clear the list of status messages. + */ + public void clear(); + + /** * Obtain a copy of the status listener list maintained by this StatusManager *

1 0

svn commit: r2114 - in logback/trunk: . logback-access logback-classic logback-core logback-examples logback-site
by noreply.ceki＠qos.ch 29 Dec '08

29 Dec '08

Author: ceki Date: Mon Dec 29 18:08:16 2008 New Revision: 2114 Modified: logback/trunk/logback-access/pom.xml logback/trunk/logback-classic/pom.xml logback/trunk/logback-core/pom.xml logback/trunk/logback-examples/pom.xml logback/trunk/logback-site/pom.xml logback/trunk/pom.xml Log: - start work on 0.9.15 Modified: logback/trunk/logback-access/pom.xml ============================================================================== --- logback/trunk/logback-access/pom.xml (original) +++ logback/trunk/logback-access/pom.xml Mon Dec 29 18:08:16 2008 @@ -5,7 +5,7 @@ <parent> <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>0.9.14</version> + <version>0.9.15-SNAPSHOT</version> </parent> <modelVersion>4.0.0</modelVersion> Modified: logback/trunk/logback-classic/pom.xml ============================================================================== --- logback/trunk/logback-classic/pom.xml (original) +++ logback/trunk/logback-classic/pom.xml Mon Dec 29 18:08:16 2008 @@ -5,7 +5,7 @@ <parent> <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>0.9.14</version> + <version>0.9.15-SNAPSHOT</version> </parent> <modelVersion>4.0.0</modelVersion> Modified: logback/trunk/logback-core/pom.xml ============================================================================== --- logback/trunk/logback-core/pom.xml (original) +++ logback/trunk/logback-core/pom.xml Mon Dec 29 18:08:16 2008 @@ -5,7 +5,7 @@ <parent> <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>0.9.14</version> + <version>0.9.15-SNAPSHOT</version> </parent> <modelVersion>4.0.0</modelVersion> Modified: logback/trunk/logback-examples/pom.xml ============================================================================== --- logback/trunk/logback-examples/pom.xml (original) +++ logback/trunk/logback-examples/pom.xml Mon Dec 29 18:08:16 2008 @@ -5,7 +5,7 @@ <parent> <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>0.9.14</version> + <version>0.9.15-SNAPSHOT</version> </parent> <modelVersion>4.0.0</modelVersion> Modified: logback/trunk/logback-site/pom.xml ============================================================================== --- logback/trunk/logback-site/pom.xml (original) +++ logback/trunk/logback-site/pom.xml Mon Dec 29 18:08:16 2008 @@ -3,7 +3,7 @@ <parent> <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>0.9.14</version> + <version>0.9.15-SNAPSHOT</version> </parent> <modelVersion>4.0.0</modelVersion> Modified: logback/trunk/pom.xml ============================================================================== --- logback/trunk/pom.xml (original) +++ logback/trunk/pom.xml Mon Dec 29 18:08:16 2008 @@ -5,7 +5,7 @@ <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>0.9.14</version> + <version>0.9.15-SNAPSHOT</version> <packaging>pom</packaging> <name>Logback-Parent</name>

1 0

svn commit: r2113 - logback/tags/release_0.9.14
by noreply.ceki＠qos.ch 29 Dec '08

29 Dec '08

Author: ceki Date: Mon Dec 29 18:00:34 2008 New Revision: 2113 Added: logback/tags/release_0.9.14/ - copied from r2112, /logback/trunk/ Log: tagging release 0.9.14

1 0

Release of logback version 0.9.14
by Ceki Gulcu 29 Dec '08

29 Dec '08

29th of December 2008 - Release of logback version 0.9.14 I am happy to announce the immediate availability of logback version 0.9.14. This release fixes several critical bugs. However, it also brings new features such as DuplicateMessageFilter and SiftingAppender. Please refer to the the news page for precise details. http://logback.qos.ch/news.html You can download logback, including full source code, class files and documentation on our download page, shown below. http://logback.qos.ch/download.html You can receive logback related announcements by subscribing to the logback announce mailing list. To subscribe to logback-announce list, please visit the following URL. http://qos.ch/mailman/listinfo/logback-announce -- Ceki Gülcü Logback: The reliable, generic, fast and flexible logging framework for Java. http://logback.qos.ch

1 0

svn commit: r2112 - in logback/trunk: . logback-access logback-classic logback-core logback-examples logback-site logback-site/src/site/pages
by noreply.ceki＠qos.ch 29 Dec '08

29 Dec '08

Author: ceki Date: Mon Dec 29 17:45:53 2008 New Revision: 2112 Modified: logback/trunk/logback-access/pom.xml logback/trunk/logback-classic/pom.xml logback/trunk/logback-core/pom.xml logback/trunk/logback-examples/pom.xml logback/trunk/logback-site/pom.xml logback/trunk/logback-site/src/site/pages/news.html logback/trunk/pom.xml Log: - preparing 0.9.14 release Modified: logback/trunk/logback-access/pom.xml ============================================================================== --- logback/trunk/logback-access/pom.xml (original) +++ logback/trunk/logback-access/pom.xml Mon Dec 29 17:45:53 2008 @@ -5,7 +5,7 @@ <parent> <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>0.9.14-SNAPSHOT</version> + <version>0.9.14</version> </parent> <modelVersion>4.0.0</modelVersion> Modified: logback/trunk/logback-classic/pom.xml ============================================================================== --- logback/trunk/logback-classic/pom.xml (original) +++ logback/trunk/logback-classic/pom.xml Mon Dec 29 17:45:53 2008 @@ -5,7 +5,7 @@ <parent> <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>0.9.14-SNAPSHOT</version> + <version>0.9.14</version> </parent> <modelVersion>4.0.0</modelVersion> Modified: logback/trunk/logback-core/pom.xml ============================================================================== --- logback/trunk/logback-core/pom.xml (original) +++ logback/trunk/logback-core/pom.xml Mon Dec 29 17:45:53 2008 @@ -5,7 +5,7 @@ <parent> <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>0.9.14-SNAPSHOT</version> + <version>0.9.14</version> </parent> <modelVersion>4.0.0</modelVersion> Modified: logback/trunk/logback-examples/pom.xml ============================================================================== --- logback/trunk/logback-examples/pom.xml (original) +++ logback/trunk/logback-examples/pom.xml Mon Dec 29 17:45:53 2008 @@ -5,7 +5,7 @@ <parent> <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>0.9.14-SNAPSHOT</version> + <version>0.9.14</version> </parent> <modelVersion>4.0.0</modelVersion> Modified: logback/trunk/logback-site/pom.xml ============================================================================== --- logback/trunk/logback-site/pom.xml (original) +++ logback/trunk/logback-site/pom.xml Mon Dec 29 17:45:53 2008 @@ -3,7 +3,7 @@ <parent> <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>0.9.14-SNAPSHOT</version> + <version>0.9.14</version> </parent> <modelVersion>4.0.0</modelVersion> Modified: logback/trunk/logback-site/src/site/pages/news.html ============================================================================== --- logback/trunk/logback-site/src/site/pages/news.html (original) +++ logback/trunk/logback-site/src/site/pages/news.html Mon Dec 29 17:45:53 2008 @@ -29,7 +29,7 @@ <hr width="80%" align="center" /> - <h3>xx of December 2008 - Release of version 0.9.14</h3> + <h3>29th of December 2008 - Release of version 0.9.14</h3> <p>Corrected a serious dead-lock problem occuring during configuration. It was reported in <a Modified: logback/trunk/pom.xml ============================================================================== --- logback/trunk/pom.xml (original) +++ logback/trunk/pom.xml Mon Dec 29 17:45:53 2008 @@ -5,7 +5,7 @@ <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>0.9.14-SNAPSHOT</version> + <version>0.9.14</version> <packaging>pom</packaging> <name>Logback-Parent</name>

1 0