February 2008 - logback-dev

Build Error
by Matt Fowles 08 Feb '08

08 Feb '08

All~ When I try to build from svn right now I get the error: Missing: ---------- 1) org.slf4j:slf4j-api:jar:1.5.0-SNAPSHOT Try downloading the file manually from the project website. Unfortunately, I don't see that file available for download from slf4j. Pointers? Matt

2 2

[Bug 126] New: Dynamically setting the log levels from a unit test
by bugzilla-daemon＠pixie.qos.ch 05 Feb '08

05 Feb '08

http://bugzilla.qos.ch/show_bug.cgi?id=126 Summary: Dynamically setting the log levels from a unit test Product: logback-classic Version: unspecified Platform: PC URL: http://www.jroller.com/robwilliams/entry/classes_for_usi ng_logs_in OS/Version: Other Status: NEW Severity: enhancement Priority: P1 Component: Other AssignedTo: logback-dev(a)qos.ch ReportedBy: noreply.ceki(a)qos.ch Rob's idea has merit. We should look into it. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 0

[Bug 120] New: Clean up a typo in SizeBasedRollingTest.java
by bugzilla-daemon＠pixie.qos.ch 04 Feb '08

04 Feb '08

http://bugzilla.qos.ch/show_bug.cgi?id=120 Summary: Clean up a typo in SizeBasedRollingTest.java Product: logback-core Version: unspecified Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: P1 Component: Rolling AssignedTo: logback-dev(a)qos.ch ReportedBy: matt.fowles(a)gmail.com This patch just fixes a typo in a unit test. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 5

Bug 120 Question
by Matt Fowles 04 Feb '08

04 Feb '08

All~ I posted a fix to bug 120 a few weeks ago and am now wondering about its fate. Is there some problem that is blocking it from inclusion? http://bugzilla.qos.ch/show_bug.cgi?id=120 Thanks, Matt

1 0

svn commit: r1619 - in logback/trunk/logback-access/src/test/java/ch/qos/logback/access: db net
by noreply.ceki＠qos.ch 04 Feb '08

04 Feb '08

Author: ceki Date: Mon Feb 4 17:57:35 2008 New Revision: 1619 Modified: logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTest.java logback/trunk/logback-access/src/test/java/ch/qos/logback/access/net/SocketAppenderTest.java Log: - renamed BasicContext as AccessContext for extra clarity Modified: logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTest.java ============================================================================== --- logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTest.java (original) +++ logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTest.java Mon Feb 4 17:57:35 2008 @@ -8,13 +8,13 @@ import ch.qos.logback.access.dummy.DummyResponse; import ch.qos.logback.access.dummy.DummyServerAdapter; import ch.qos.logback.access.spi.AccessEvent; -import ch.qos.logback.access.spi.BasicContext; +import ch.qos.logback.access.spi.AccessContext; import ch.qos.logback.core.db.DriverManagerConnectionSource; import ch.qos.logback.core.util.StatusPrinter; public class DBAppenderTest extends DBAppenderTestBase { - BasicContext context; + AccessContext context; DBAppender appender; DriverManagerConnectionSource connectionSource; @@ -24,7 +24,7 @@ public void setUp() throws SQLException { super.setUp(); - context = new BasicContext(); + context = new AccessContext(); context.setName("default"); appender = new DBAppender(); appender.setName("DB"); Modified: logback/trunk/logback-access/src/test/java/ch/qos/logback/access/net/SocketAppenderTest.java ============================================================================== --- logback/trunk/logback-access/src/test/java/ch/qos/logback/access/net/SocketAppenderTest.java (original) +++ logback/trunk/logback-access/src/test/java/ch/qos/logback/access/net/SocketAppenderTest.java Mon Feb 4 17:57:35 2008 @@ -14,16 +14,16 @@ import ch.qos.logback.access.dummy.DummyResponse; import ch.qos.logback.access.dummy.DummyServerAdapter; import ch.qos.logback.access.spi.AccessEvent; -import ch.qos.logback.access.spi.BasicContext; +import ch.qos.logback.access.spi.AccessContext; public class SocketAppenderTest extends TestCase { - private BasicContext context; + private AccessContext context; private MockSocketServer mockSocketServer; public void testStartFailNoRemoteHost() { - context = new BasicContext(); + context = new AccessContext(); SocketAppender appender = new SocketAppender(); appender.setContext(context); appender.setPort(123); @@ -57,7 +57,7 @@ } private void configureClient() { - context = new BasicContext(); + context = new AccessContext(); context.setName("test"); SocketAppender socketAppender = new SocketAppender(); socketAppender.setContext(context);

1 0

svn commit: r1618 - in logback/trunk/logback-access/src/main/java/ch/qos/logback/access: net spi
by noreply.ceki＠qos.ch 04 Feb '08

04 Feb '08

Author: ceki Date: Mon Feb 4 17:56:30 2008 New Revision: 1618 Added: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/spi/AccessContext.java - copied, changed from r1616, /logback/trunk/logback-access/src/main/java/ch/qos/logback/access/spi/BasicContext.java Removed: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/spi/BasicContext.java Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/net/SimpleSocketServer.java logback/trunk/logback-access/src/main/java/ch/qos/logback/access/net/SocketNode.java Log: - renamed BasicContext as AccessContext for extra clarity Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/net/SimpleSocketServer.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/net/SimpleSocketServer.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/net/SimpleSocketServer.java Mon Feb 4 17:56:30 2008 @@ -13,7 +13,7 @@ import java.net.Socket; import ch.qos.logback.access.joran.JoranConfigurator; -import ch.qos.logback.access.spi.BasicContext; +import ch.qos.logback.access.spi.AccessContext; import ch.qos.logback.core.joran.spi.JoranException; import ch.qos.logback.core.util.StatusPrinter; @@ -43,7 +43,7 @@ static int port; - private static BasicContext basicContext; + private static AccessContext basicContext; public static void main(String argv[]) throws Exception { if (argv.length == 2) { @@ -86,7 +86,7 @@ usage("Could not interpret port number [" + portStr + "]."); } - basicContext = new BasicContext(); + basicContext = new AccessContext(); if (configFile.endsWith(".xml")) { JoranConfigurator configurator = new JoranConfigurator(); configurator.setContext(basicContext); Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/net/SocketNode.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/net/SocketNode.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/net/SocketNode.java Mon Feb 4 17:56:30 2008 @@ -15,8 +15,8 @@ import java.io.ObjectInputStream; import java.net.Socket; +import ch.qos.logback.access.spi.AccessContext; import ch.qos.logback.access.spi.AccessEvent; -import ch.qos.logback.access.spi.BasicContext; import ch.qos.logback.core.spi.FilterReply; // Contributors: Moses Hohman <mmhohman(a)rainbow.uchicago.edu> @@ -38,10 +38,10 @@ public class SocketNode implements Runnable { Socket socket; - BasicContext context; + AccessContext context; ObjectInputStream ois; - public SocketNode(Socket socket, BasicContext context) { + public SocketNode(Socket socket, AccessContext context) { this.socket = socket; this.context = context; try { Copied: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/spi/AccessContext.java (from r1616, /logback/trunk/logback-access/src/main/java/ch/qos/logback/access/spi/BasicContext.java) ============================================================================== --- /logback/trunk/logback-access/src/main/java/ch/qos/logback/access/spi/BasicContext.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/spi/AccessContext.java Mon Feb 4 17:56:30 2008 @@ -18,7 +18,7 @@ * * @author Sébastien Pennec */ -public class BasicContext extends ContextBase implements AppenderAttachable<AccessEvent>, FilterAttachable { +public class AccessContext extends ContextBase implements AppenderAttachable<AccessEvent>, FilterAttachable { AppenderAttachableImpl<AccessEvent> aai = new AppenderAttachableImpl<AccessEvent>(); FilterAttachableImpl fai = new FilterAttachableImpl();

1 0

svn commit: r1617 - in logback/trunk/logback-core/src: main/java/ch/qos/logback/core/joran/spi main/java/ch/qos/logback/core/util test/java/ch/qos/logback/core/util
by noreply.ceki＠qos.ch 04 Feb '08

04 Feb '08

Author: ceki Date: Mon Feb 4 17:43:50 2008 New Revision: 1617 Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/spi/InterpretationContext.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/util/OptionHelper.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/util/OptionHelperTest.java Log: - Modified OptionHelper.substVars to accept the property map passed in the context. The secondary map is no longer supported. Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/spi/InterpretationContext.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/spi/InterpretationContext.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/spi/InterpretationContext.java Mon Feb 4 17:43:50 2008 @@ -145,7 +145,7 @@ if (value == null) { return null; } - return OptionHelper.substVars(value, context, null); + return OptionHelper.substVars(value, context); } public void addInPlayListener(InPlayListener ipl) { Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/util/OptionHelper.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/util/OptionHelper.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/util/OptionHelper.java Mon Feb 4 17:43:50 2008 @@ -74,27 +74,24 @@ /** * Perform variable substitution in string <code>val</code> from the values - * of keys found the primary map passed as first parameter, then in the - * secondary map, and last in the system properties. + * of keys found in context property map, and if that fails, then in the + * system properties. * * * The variable substitution delimeters are ${ and }. * * - * For example, if the primary map parameter contains a property "key1" set as + * For example, if the context property map contains a property "key1" set as * "value1", then the call * * <pre> - * String s = OptionConverter.substituteVars("Value of key is ${key1}.", priMap, - * null); - * </pre> - * + * String s = OptionConverter.substituteVars("Value of key is ${key1}.", context);</pre> * will set the variable <code>s</code> to "Value of key is value1.". * * - * If no value could be found for the specified key, then the secondary map is - * searches, and if that fails, the system properties are searched, if that - * fails, then substitution defaults to the empty string. + * If no value could be found for the specified key in the context map, then + * the system properties are searched, if that fails, then substitution defaults + * to the empty string. * * * For example, if system properties contains no value for the key @@ -102,9 +99,7 @@ * * <pre> * String s = OptionConverter.subsVars( - * "Value of inexistentKey is [${inexistentKey}]", priMap, null); - * </pre> - * + * "Value of inexistentKey is [${inexistentKey}]", context);</pre> * will set <code>s</code> to "Value of inexistentKey is []". * * @@ -112,9 +107,7 @@ * the ":-" operator. For example, the call * * <pre> - * String s = OptionConverter.subsVars("Value of key is [${key2:-val2}]"); - * </pre> - * + * String s = OptionConverter.subsVars("Value of key is [${key2:-val2}]", context);</pre> * will set <code>s</code> to "Value of key is [val2]" even if the "key2" * property is unset. * @@ -129,8 +122,7 @@ * @throws IllegalArgumentException * if <code>val</code> is malformed. */ - public static String substVars(String val, Context context, - Map<String, String> secondaryMap) { + public static String substVars(String val, Context context) { StringBuffer sbuf = new StringBuffer(); @@ -174,10 +166,6 @@ // first try the props passed as parameter replacement = context.getProperty(key); - if (replacement == null && secondaryMap != null) { - replacement = secondaryMap.get(key); - } - // then try in System properties if (replacement == null) { replacement = getSystemProperty(key, null); @@ -195,8 +183,7 @@ // where the properties are // x1=p1 // x2=${x1} - String recursiveReplacement = substVars(replacement, context, - secondaryMap); + String recursiveReplacement = substVars(replacement, context); sbuf.append(recursiveReplacement); } Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/util/OptionHelperTest.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/util/OptionHelperTest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/util/OptionHelperTest.java Mon Feb 4 17:43:50 2008 @@ -31,7 +31,7 @@ public void testSubstVarsNoSubstitution() { String noSubst = "testing if it works"; - String result = OptionHelper.substVars(noSubst, null, null); + String result = OptionHelper.substVars(noSubst, null); assertEquals(noSubst, result); } @@ -40,7 +40,7 @@ try { @SuppressWarnings("unused") - String result = OptionHelper.substVars(noSubst, null, null); + String result = OptionHelper.substVars(noSubst, null); fail(); } catch (IllegalArgumentException e) { //ok @@ -51,15 +51,7 @@ context.putProperty("v1", "if"); context.putProperty("v2", "works"); - String result = OptionHelper.substVars(text, context, null); - assertEquals(expected, result); - } - - public void testSubstVarsPrimaryAndSecondary() { - context.putProperty("v1", "if"); - secondaryMap.put("v2", "works"); - - String result = OptionHelper.substVars(text, context, secondaryMap); + String result = OptionHelper.substVars(text, context); assertEquals(expected, result); } @@ -68,7 +60,7 @@ System.setProperty("v1", "if"); System.setProperty("v2", "works"); - String result = OptionHelper.substVars(text, context, null); + String result = OptionHelper.substVars(text, context); assertEquals(expected, result); System.clearProperty("v1"); @@ -80,7 +72,7 @@ String textWithDefault = "Testing ${v1} variable substitution ${v2:-toto}"; String resultWithDefault = "Testing if variable substitution toto"; - String result = OptionHelper.substVars(textWithDefault, context, null); + String result = OptionHelper.substVars(textWithDefault, context); assertEquals(resultWithDefault, result); } @@ -89,7 +81,7 @@ context.putProperty("v2", "${v3}"); context.putProperty("v3", "works"); - String result = OptionHelper.substVars(text, context, null); + String result = OptionHelper.substVars(text, context); assertEquals(expected, result); }

1 0