March 2008 - logback-dev - mailman3.qos.ch

[Bug 92] New: TimeBasedRollingPolicy will not rollover a log file, append logs to a old log file.
by bugzilla-daemon＠pixie.qos.ch 13 May '08

13 May '08

http://bugzilla.qos.ch/show_bug.cgi?id=92 Summary: TimeBasedRollingPolicy will not rollover a log file, append logs to a old log file. Product: logback-core Version: unspecified Platform: All OS/Version: All Status: NEW Severity: critical Priority: P1 Component: Rolling AssignedTo: logback-dev(a)qos.ch ReportedBy: benbrand(a)mac.com If you use TimeBasedRollingPolicy to rollover a log file and no log wasn't wrote into the log beyond the timing of rollover, and if you restart your application, the log file doesn't roll, then new log will be appended into old log file. EVIDENCE: 1. in logback.xml, set your FileNamePattern like 'log.%d{yyyy-MM-dd_HH-mm}.log'. 2. Simply do a kind of thing, which will make some logs into your log file. 3. Wait for some minutes. 4. restart your application. 5. do a kind of thing, which will make some logs into your log file. the FileNamePattern is 'log.%d{yyyy-MM-dd_HH-mm}.log', so the log file will be roll every minutes. On case 5 of above example, the log file should be roll over, because some minutes already have passed after last logs wrote into the log file. But the file didn't be roll overed. THE CAUSE: In start() method of TimeBasedRollingPolicy, you initialize a variable 'lastCheck' to System.currentTimeStamp(). So if you restart your application, the last check time will be set to just NOW. you should initialize the variable to a last modified time of a current log file. See below source code. from '//modified by Tsutomu YANO' to '//until here'. SOURCE: public void start() { // set the LR for our utility object util.setContext(this.context); compress.setContext(this.context); // find out period from the filename pattern if (fileNamePatternStr != null) { fileNamePattern = new FileNamePattern(fileNamePatternStr, this.context); determineCompressionMode(); } else { addWarn(FNP_NOT_SET); addWarn(SEE_FNP_NOT_SET); throw new IllegalStateException(FNP_NOT_SET + SEE_FNP_NOT_SET); } DateTokenConverter dtc = fileNamePattern.getDateTokenConverter(); if (dtc == null) { throw new IllegalStateException("FileNamePattern [" + fileNamePattern.getPattern() + "] does not contain a valid DateToken"); } int len = fileNamePatternStr.length(); switch (compressionMode) { case Compress.GZ: activeFileNamePattern = new FileNamePattern(fileNamePatternStr.substring(0, len - 3), this.context); break; case Compress.ZIP: activeFileNamePattern = new FileNamePattern(fileNamePatternStr.substring(0, len - 4), this.context); break; case Compress.NONE: activeFileNamePattern = fileNamePattern; } addInfo("Will use the pattern " + activeFileNamePattern + " for the active file"); rc = new RollingCalendar(); rc.init(dtc.getDatePattern()); addInfo("The date pattern is '" + dtc.getDatePattern() + "' from file name pattern '" + fileNamePattern.getPattern() + "'."); rc.printPeriodicity(this); //modified by Tsutomu YANO //if a current log file exists, initialize a 'lastCheck' variable to the //last modified date of the file. File currentFile = new File(getParentFileName()); if(currentFile.exists() && currentFile.canRead()) { lastCheck.setTime(currentFile.lastModified()); } else { // currentTime = System.currentTimeMillis(); lastCheck.setTime(getCurrentTime()); } //until here nextCheck = rc.getNextCheckMillis(lastCheck); // Date nc = new Date(); // nc.setTime(nextCheck); } -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 2

[Bug 55] New: Implement AsyncAppender
by bugzilla-daemon＠pixie.qos.ch 22 Apr '08

22 Apr '08

http://bugzilla.qos.ch/show_bug.cgi?id=55 Summary: Implement AsyncAppender Product: logback-classic Version: unspecified Platform: PC OS/Version: Windows Status: NEW Severity: enhancement Priority: P1 Component: Other AssignedTo: logback-dev(a)qos.ch ReportedBy: anders_wallgren(a)alum.mit.edu Being able to write log files in the background is a requirement for production deployments of anything we would write on top of logback. Bonus points for including a feature to periodically flush the output. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 2

[Bug 121] New: logback configuration fails without warning even if debug="true"
by bugzilla-daemon＠pixie.qos.ch 17 Apr '08

17 Apr '08

http://bugzilla.qos.ch/show_bug.cgi?id=121 Summary: logback configuration fails without warning even if debug="true" Product: logback-core Version: unspecified Platform: PC OS/Version: Windows Status: NEW Severity: normal Priority: P3 Component: Joran AssignedTo: logback-dev(a)qos.ch ReportedBy: stivo(a)gmx.ch I tried out logback, and ive written a configuration xml. It worked fine on my machine, but not on any others, and on the other machines joran did not even give a single output line. I traced it to my mysql appender: I used a mysql appender which I didnt add to the root logger. On machines where the mysql server was not around joran did not give any output at all but was just left unconfigured. At least some exception should be thrown. When I comment it out, everything works the way I want it to. Confirmed this with one Vista, 3 XP`s and one ubuntu. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 1

[Bug 107] New: Specificy the config file to use as a System property
by bugzilla-daemon＠pixie.qos.ch 04 Apr '08

04 Apr '08

http://bugzilla.qos.ch/show_bug.cgi?id=107 Summary: Specificy the config file to use as a System property Product: logback-core Version: unspecified Platform: PC OS/Version: Windows Status: NEW Severity: normal Priority: P1 Component: Other AssignedTo: logback-dev(a)qos.ch ReportedBy: tgraham(a)concordenergy.com I'd like to be able to specify the logger config file to use as a System property, something like: java -Dlogback.configuration=customConfig.xml This is a much cleaner way of controlling the config than by messing with the classpath. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 6

[Bug 137] New: add option to FileAppender to auto-create parent directories
by bugzilla-daemon＠pixie.qos.ch 03 Apr '08

03 Apr '08

http://bugzilla.qos.ch/show_bug.cgi?id=137 Summary: add option to FileAppender to auto-create parent directories Product: logback-core Version: unspecified Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: P1 Component: Appender AssignedTo: logback-dev(a)qos.ch ReportedBy: bruno.navert(a)morganstanley.com FileAppender should be able to automatically create parent directories as needed when writing the log file. For instance, if configured with <File>/var/tmp/project_name/some_file.log</File>, and the new option set to true (suggest <CreateParentDirectories>true</CreateParentDirectories> maybe), then in FileAppender.setFile(), it should do new File( fileName ).getParentFile().mkdirs() workaround is to create the directory before initializing logback. Possible but far less than ideal, and rather complicated too -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 2

[Bug 142] SyslogStartConverter specifies hour as 1-12 not 0-23
by bugzilla-daemon＠pixie.qos.ch 31 Mar '08

31 Mar '08

http://bugzilla.qos.ch/show_bug.cgi?id=142 ------- Comment #1 from peter.royal(a)pobox.com 2008-04-01 00:24 ------- Created an attachment (id=27) --> (http://bugzilla.qos.ch/attachment.cgi?id=27&action=view) patch to fix time format -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 0

[Bug 141] New: introduce FlushableAppender
by bugzilla-daemon＠pixie.qos.ch 25 Mar '08

25 Mar '08

http://bugzilla.qos.ch/show_bug.cgi?id=141 Summary: introduce FlushableAppender Product: logback-core Version: unspecified Platform: PC OS/Version: Linux Status: NEW Severity: enhancement Priority: P3 Component: Appender AssignedTo: logback-dev(a)qos.ch ReportedBy: bruno.navert(a)morganstanley.com Suggest a new sub-interface of Appender: public interface FlushableAppender<E> extends Appender<E>, java.io.Flushable { } Then, WriterAppender could be defined to implement FlushableAppender, with this simple implementation: public void flush() throws IOException { writer.flush(); } This would allow manual flushing of the appenders. This is particularly useful when buffered IO is used, obviously. It allows, for instance, to manually flush all appenders when a request has been fully processed, ensuring that we retain the benefits of buffered IO while also having the full logs after request processing. Here's sample code I used to get all appenders (run once after Logback configuration): public static Set<Appender> getAllAppenders() { ContextSelector selector = StaticLoggerBinder.SINGLETON.getContextSelector(); LoggerContext loggerContext = selector.getLoggerContext(); Map<String, Appender> appenders = newHashMap(); // loop through all Loggers for ( Logger logger : loggerContext.getLoggerList() ) { // for each logger, loop through all its appenders Iterator iter = logger.iteratorForAppenders(); while ( iter.hasNext() ) { // appenders are uniquely identified by name, so store them in the Map thus // this will overwrite the same entry in the Map many times (with the same reference) Appender appender = ( Appender ) iter.next(); appenders.put( appender.getName(), appender ); } } return newHashSet( appenders.values() ); } The below bean is used in Spring, calling flush() forces all appenders to be flushed: public class LogbackFlushBean implements Flushable { protected final Logger log = LoggerFactory.getLogger( getClass() ); private final Collection<FlushableAppender> flushableAppenders = newLinkedList(); @PostConstruct public void loadFlushableAppenders() { for ( Appender appender : LogbackConfigurer.getAllAppenders() ) { if ( appender instanceof FlushableAppender ) { flushableAppenders.add( ( FlushableAppender ) appender ); } else { log.debug( "appender {} is not Flushable, skipping", appender.getName() ); } } } public void flush() throws IOException { for ( FlushableAppender appender : flushableAppenders ) { log.debug( "flushing appender {}", appender.getName() ); appender.flush(); } } } -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 0

[Bug 140] New: logback.xml vs. logback-test.xml - conflicting information on website
by bugzilla-daemon＠pixie.qos.ch 24 Mar '08

24 Mar '08

http://bugzilla.qos.ch/show_bug.cgi?id=140 Summary: logback.xml vs. logback-test.xml - conflicting information on website Product: logback-core Version: unspecified Platform: PC OS/Version: Windows Status: NEW Severity: blocker Priority: P1 Component: Other AssignedTo: logback-dev(a)qos.ch ReportedBy: sapatel(a)nemours.org I am using latest version of logback. -------------------------------------------------------------------- <dependency> <groupId>org.slf4j</groupId> <artifactId>slf4j-api</artifactId> </dependency> <dependency> <groupId>ch.qos.logback</groupId> <artifactId>logback-classic</artifactId> </dependency> -------------------------------------------------------------------- I found conflicting information on the logback website. http://logback.qos.ch/faq.html states "If a file called logback.xml is found in the classpath, then it is used. In case it is not found, a logback-test.xml file is searched, and used if available. If none of these files are available, logback uses its BasicConfigurator class to create a simple default configuration that will only log to the console." http://logback.qos.ch/manual/joran.html states " 1. Logback tries to find a file called logback-test.xml in the classpath. 2. If no such file is found, it checks for the file logback.xml. 3. In case neither file is found, logback configures itself automatically using the BasicConfigurator which will cause logging output to be directed on the console" > > I think that FAQ (http://logback.qos.ch/faq.html) is correct. If it is true, while running tests using Maven (mvn test) it uses "src/main/resources" (home of logback.xml) and "src/test/resources" (home of logback-test.xml). logback-test.xml will never override logback.xml. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 0

svn commit: r1659 - logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty
by noreply.ceki＠qos.ch 23 Mar '08

23 Mar '08

Author: ceki Date: Sun Mar 23 10:22:21 2008 New Revision: 1659 Modified: logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty/JettyBasicTest.java Log: - import changes Modified: logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty/JettyBasicTest.java ============================================================================== --- logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty/JettyBasicTest.java (original) +++ logback/trunk/logback-access/src/test/java/ch/qos/logback/access/jetty/JettyBasicTest.java Sun Mar 23 10:22:21 2008 @@ -1,6 +1,6 @@ package ch.qos.logback.access.jetty; -import static org.junit.Assert.assertEquals; +import static org.junit.Assert.*; import java.io.OutputStreamWriter; import java.io.PrintWriter;

1 0

svn commit: r1658 - in logback/trunk/logback-site/src/site/pages: . manual
by noreply.ceki＠qos.ch 22 Mar '08

22 Mar '08

Author: ceki Date: Sat Mar 22 19:51:03 2008 New Revision: 1658 Modified: logback/trunk/logback-site/src/site/pages/faq.html logback/trunk/logback-site/src/site/pages/manual/joran.html Log: - Correcting incorrect text in the FAQ. The problem was mentioned in the user mailing list [1]. [1] http://www.qos.ch/pipermail/logback-user/2008-March/000410.html Modified: logback/trunk/logback-site/src/site/pages/faq.html ============================================================================== --- logback/trunk/logback-site/src/site/pages/faq.html (original) +++ logback/trunk/logback-site/src/site/pages/faq.html Sat Mar 22 19:51:03 2008 @@ -101,15 +101,9 @@ </a> </dt> <dd> - <p>If a file called <em>logback.xml</em> is found in the - classpath, then it is used. - </p> - <p>In case it is not found, a <em>logback-test.xml</em> file - is searched, and used if available. - </p> - <p>If none of these files are available, logback uses its - <code>BasicConfigurator</code> class to create a simple - default configuration that will only log to the console. + <p>This question is answered in the <a + href="manual/joran.html#auto_configuration">relevant + section</a> of the logback manual. </p> <table border="0"> <tr> Modified: logback/trunk/logback-site/src/site/pages/manual/joran.html ============================================================================== --- logback/trunk/logback-site/src/site/pages/manual/joran.html (original) +++ logback/trunk/logback-site/src/site/pages/manual/joran.html Sat Mar 22 19:51:03 2008 @@ -47,8 +47,10 @@ configure your own applications. </p> + <a name="auto_configuration"> + </a> <h2>Configuration in logback</h2> - + <p>Inserting log requests into the application code requires a fair amount of planning and effort. Observation shows that approximately four percent of code is dedicated to

1 0