April 2008 - logback-dev - mailman3.qos.ch

[Bug 92] New: TimeBasedRollingPolicy will not rollover a log file, append logs to a old log file.
by bugzilla-daemon＠pixie.qos.ch 13 May '08

13 May '08

http://bugzilla.qos.ch/show_bug.cgi?id=92 Summary: TimeBasedRollingPolicy will not rollover a log file, append logs to a old log file. Product: logback-core Version: unspecified Platform: All OS/Version: All Status: NEW Severity: critical Priority: P1 Component: Rolling AssignedTo: logback-dev(a)qos.ch ReportedBy: benbrand(a)mac.com If you use TimeBasedRollingPolicy to rollover a log file and no log wasn't wrote into the log beyond the timing of rollover, and if you restart your application, the log file doesn't roll, then new log will be appended into old log file. EVIDENCE: 1. in logback.xml, set your FileNamePattern like 'log.%d{yyyy-MM-dd_HH-mm}.log'. 2. Simply do a kind of thing, which will make some logs into your log file. 3. Wait for some minutes. 4. restart your application. 5. do a kind of thing, which will make some logs into your log file. the FileNamePattern is 'log.%d{yyyy-MM-dd_HH-mm}.log', so the log file will be roll every minutes. On case 5 of above example, the log file should be roll over, because some minutes already have passed after last logs wrote into the log file. But the file didn't be roll overed. THE CAUSE: In start() method of TimeBasedRollingPolicy, you initialize a variable 'lastCheck' to System.currentTimeStamp(). So if you restart your application, the last check time will be set to just NOW. you should initialize the variable to a last modified time of a current log file. See below source code. from '//modified by Tsutomu YANO' to '//until here'. SOURCE: public void start() { // set the LR for our utility object util.setContext(this.context); compress.setContext(this.context); // find out period from the filename pattern if (fileNamePatternStr != null) { fileNamePattern = new FileNamePattern(fileNamePatternStr, this.context); determineCompressionMode(); } else { addWarn(FNP_NOT_SET); addWarn(SEE_FNP_NOT_SET); throw new IllegalStateException(FNP_NOT_SET + SEE_FNP_NOT_SET); } DateTokenConverter dtc = fileNamePattern.getDateTokenConverter(); if (dtc == null) { throw new IllegalStateException("FileNamePattern [" + fileNamePattern.getPattern() + "] does not contain a valid DateToken"); } int len = fileNamePatternStr.length(); switch (compressionMode) { case Compress.GZ: activeFileNamePattern = new FileNamePattern(fileNamePatternStr.substring(0, len - 3), this.context); break; case Compress.ZIP: activeFileNamePattern = new FileNamePattern(fileNamePatternStr.substring(0, len - 4), this.context); break; case Compress.NONE: activeFileNamePattern = fileNamePattern; } addInfo("Will use the pattern " + activeFileNamePattern + " for the active file"); rc = new RollingCalendar(); rc.init(dtc.getDatePattern()); addInfo("The date pattern is '" + dtc.getDatePattern() + "' from file name pattern '" + fileNamePattern.getPattern() + "'."); rc.printPeriodicity(this); //modified by Tsutomu YANO //if a current log file exists, initialize a 'lastCheck' variable to the //last modified date of the file. File currentFile = new File(getParentFileName()); if(currentFile.exists() && currentFile.canRead()) { lastCheck.setTime(currentFile.lastModified()); } else { // currentTime = System.currentTimeMillis(); lastCheck.setTime(getCurrentTime()); } //until here nextCheck = rc.getNextCheckMillis(lastCheck); // Date nc = new Date(); // nc.setTime(nextCheck); } -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 2

svn commit: r1677 - in logback/trunk/logback-core/src: main/java/ch/qos/logback/core/rolling main/java/ch/qos/logback/core/rolling/helper test/java/ch/qos/logback/core/rolling test/java/ch/qos/logback/core/rolling/helper
by noreply.ceki＠qos.ch 25 Apr '08

25 Apr '08

Author: ceki Date: Sat Apr 26 01:05:56 2008 New Revision: 1677 Added: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/AsynchronousCompressor.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/CompressionMode.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/CompressionRunnable.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/Compressor.java - copied, changed from r1666, /logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/Compress.java Removed: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/Compress.java Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/FixedWindowRollingPolicy.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/RollingPolicyBase.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/TimeBasedRollingPolicy.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/rolling/TimeBasedRollingTest.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/rolling/helper/CompressTest.java Log: - added support for asynchronous compression see also http://bugzilla.qos.ch/show_bug.cgi?id=55 http://bugzilla.qos.ch/show_bug.cgi?id=149 Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/FixedWindowRollingPolicy.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/FixedWindowRollingPolicy.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/FixedWindowRollingPolicy.java Sat Apr 26 01:05:56 2008 @@ -11,7 +11,8 @@ import java.io.File; -import ch.qos.logback.core.rolling.helper.Compress; +import ch.qos.logback.core.rolling.helper.CompressionMode; +import ch.qos.logback.core.rolling.helper.Compressor; import ch.qos.logback.core.rolling.helper.FileNamePattern; import ch.qos.logback.core.rolling.helper.IntegerTokenConverter; import ch.qos.logback.core.rolling.helper.RenameUtil; @@ -32,7 +33,6 @@ int maxIndex; int minIndex; RenameUtil util = new RenameUtil(); - Compress compress = new Compress(); /** * It's almost always a bad idea to have a large window size, say over 12. @@ -47,8 +47,7 @@ public void start() { // set the LR for our utility object util.setContext(this.context); - compress.setContext(this.context); - + if (fileNamePatternStr != null) { fileNamePattern = new FileNamePattern(fileNamePatternStr, this.context); determineCompressionMode(); @@ -111,15 +110,23 @@ } // move active file name to min + Compressor compressor; switch (compressionMode) { - case Compress.NONE: - util.rename(getNewActiveFileName(), fileNamePattern.convertInt(minIndex)); + case NONE: + util.rename(getNewActiveFileName(), fileNamePattern + .convertInt(minIndex)); break; - case Compress.GZ: - compress.GZCompress(getNewActiveFileName(), fileNamePattern.convertInt(minIndex)); + case GZ: + compressor = new Compressor(CompressionMode.GZ, + getNewActiveFileName(), fileNamePattern.convertInt(minIndex)); + compressor.setContext(this.context); + compressor.compress(); break; - case Compress.ZIP: - compress.ZIPCompress(getNewActiveFileName(), fileNamePattern.convertInt(minIndex)); + case ZIP: + compressor = new Compressor(CompressionMode.ZIP, + getNewActiveFileName(), fileNamePattern.convertInt(minIndex)); + compressor.setContext(this.context); + compressor.compress(); break; } } Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/RollingPolicyBase.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/RollingPolicyBase.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/RollingPolicyBase.java Sat Apr 26 01:05:56 2008 @@ -10,7 +10,7 @@ package ch.qos.logback.core.rolling; import ch.qos.logback.core.FileAppender; -import ch.qos.logback.core.rolling.helper.Compress; +import ch.qos.logback.core.rolling.helper.CompressionMode; import ch.qos.logback.core.rolling.helper.FileNamePattern; import ch.qos.logback.core.spi.ContextAwareBase; @@ -24,7 +24,7 @@ * @author Ceki Gülcü */ public abstract class RollingPolicyBase extends ContextAwareBase implements RollingPolicy { - protected int compressionMode = Compress.NONE; + protected CompressionMode compressionMode = CompressionMode.NONE; protected FileNamePattern fileNamePattern; protected String fileNamePatternStr; @@ -42,13 +42,13 @@ protected void determineCompressionMode() { if (fileNamePatternStr.endsWith(".gz")) { addInfo("Will use gz compression"); - compressionMode = Compress.GZ; + compressionMode = CompressionMode.GZ; } else if (fileNamePatternStr.endsWith(".zip")) { addInfo("Will use zip compression"); - compressionMode = Compress.ZIP; + compressionMode = CompressionMode.ZIP; } else { addInfo("No compression will be used"); - compressionMode = Compress.NONE; + compressionMode = CompressionMode.NONE; } } Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/TimeBasedRollingPolicy.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/TimeBasedRollingPolicy.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/TimeBasedRollingPolicy.java Sat Apr 26 01:05:56 2008 @@ -9,63 +9,63 @@ */ package ch.qos.logback.core.rolling; - import java.io.File; import java.util.Date; +import java.util.concurrent.Future; -import ch.qos.logback.core.rolling.helper.Compress; +import ch.qos.logback.core.rolling.helper.AsynchronousCompressor; +import ch.qos.logback.core.rolling.helper.Compressor; +import ch.qos.logback.core.rolling.helper.CompressionMode; import ch.qos.logback.core.rolling.helper.DateTokenConverter; import ch.qos.logback.core.rolling.helper.FileNamePattern; import ch.qos.logback.core.rolling.helper.RenameUtil; import ch.qos.logback.core.rolling.helper.RollingCalendar; /** - * <code>TimeBasedRollingPolicy</code> is both easy to configure and quite - * powerful. It allows the rollover to be made based on time conditions. - * It is possible to specify that the rollover must occur each day, or month, for example. + * <code>TimeBasedRollingPolicy</code> is both easy to configure and quite + * powerful. It allows the rollover to be made based on time conditions. It is + * possible to specify that the rollover must occur each day, or month, for + * example. * - * For more information about this policy, please refer to the online manual at - * http://logback.qos.ch/manual/appenders.html#TimeBasedRollingPolicy + * For more information about this policy, please refer to the online manual at + * http://logback.qos.ch/manual/appenders.html#TimeBasedRollingPolicy * * @author Ceki Gülcü */ -public class TimeBasedRollingPolicy<E> extends RollingPolicyBase implements TriggeringPolicy<E> { - static final String FNP_NOT_SET = - "The FileNamePattern option must be set before using TimeBasedRollingPolicy. "; - static final String SEE_FNP_NOT_SET = - "See also http://logback.qos.ch/codes.html#tbr_fnp_not_set"; +public class TimeBasedRollingPolicy<E> extends RollingPolicyBase implements + TriggeringPolicy<E> { + static final String FNP_NOT_SET = "The FileNamePattern option must be set before using TimeBasedRollingPolicy. "; + static final String SEE_FNP_NOT_SET = "See also http://logback.qos.ch/codes.html#tbr_fnp_not_set"; RollingCalendar rc; long currentTime; long nextCheck; - //indicate whether the time has been forced or not - boolean isTimeForced=false; + // indicate whether the time has been forced or not + boolean isTimeForced = false; Date lastCheck = new Date(); String elapsedPeriodsFileName; FileNamePattern activeFileNamePattern; RenameUtil util = new RenameUtil(); - Compress compress = new Compress(); String lastGeneratedFileName; - + Future<?> future; + public void setCurrentTime(long timeInMillis) { - currentTime = timeInMillis; - isTimeForced = true; + currentTime = timeInMillis; + isTimeForced = true; } - - public long getCurrentTime(){ - //if time is forced return the time set by user - if(isTimeForced){ - return currentTime; - } - else{ - return System.currentTimeMillis(); - } + + public long getCurrentTime() { + // if time is forced return the time set by user + if (isTimeForced) { + return currentTime; + } else { + return System.currentTimeMillis(); + } } - + public void start() { // set the LR for our utility object util.setContext(this.context); - compress.setContext(this.context); - + // find out period from the filename pattern if (fileNamePatternStr != null) { fileNamePattern = new FileNamePattern(fileNamePatternStr, this.context); @@ -79,103 +79,115 @@ DateTokenConverter dtc = fileNamePattern.getDateTokenConverter(); if (dtc == null) { - throw new IllegalStateException( - "FileNamePattern [" + fileNamePattern.getPattern() - + "] does not contain a valid DateToken"); + throw new IllegalStateException("FileNamePattern [" + + fileNamePattern.getPattern() + + "] does not contain a valid DateToken"); } int len = fileNamePatternStr.length(); - switch(compressionMode) { - case Compress.GZ: - activeFileNamePattern = - new FileNamePattern(fileNamePatternStr.substring(0, len - 3), this.context); - + switch (compressionMode) { + case GZ: + activeFileNamePattern = new FileNamePattern(fileNamePatternStr.substring( + 0, len - 3), this.context); + + break; + case ZIP: + activeFileNamePattern = new FileNamePattern(fileNamePatternStr.substring( + 0, len - 4), this.context); break; - case Compress.ZIP: - activeFileNamePattern = - new FileNamePattern(fileNamePatternStr.substring(0, len - 4), this.context); - break; - case Compress.NONE: - activeFileNamePattern = fileNamePattern; - } - addInfo("Will use the pattern "+activeFileNamePattern+" for the active file"); - + case NONE: + activeFileNamePattern = fileNamePattern; + } + addInfo("Will use the pattern " + activeFileNamePattern + + " for the active file"); + rc = new RollingCalendar(); rc.init(dtc.getDatePattern()); - addInfo("The date pattern is '"+dtc.getDatePattern()+"' from file name pattern '"+ - fileNamePattern.getPattern()+"'."); + addInfo("The date pattern is '" + dtc.getDatePattern() + + "' from file name pattern '" + fileNamePattern.getPattern() + "'."); rc.printPeriodicity(this); - //currentTime = System.currentTimeMillis(); + // currentTime = System.currentTimeMillis(); lastCheck.setTime(getCurrentTime()); nextCheck = rc.getNextCheckMillis(lastCheck); - //Date nc = new Date(); - //nc.setTime(nextCheck); + // Date nc = new Date(); + // nc.setTime(nextCheck); } public void rollover() throws RolloverFailure { - //addInfo("roll-over called"); - //addInfo("compressionMode: " + compressionMode); - if (getParentFileName() == null) { - switch (compressionMode) { - case Compress.NONE: - // nothing to do; - break; - case Compress.GZ: - addInfo("GZIP compressing ["+elapsedPeriodsFileName+"]."); - compress.GZCompress(elapsedPeriodsFileName); - break; - case Compress.ZIP: - addInfo("ZIP compressing ["+elapsedPeriodsFileName+"]"); - compress.ZIPCompress(elapsedPeriodsFileName); - break; - } + // when rollover is called the elapsed period's file has + // been already closed. This is a working assumption of this method. + + if (getParentFileName() == null && compressionMode != CompressionMode.NONE) { + doCompression(false, elapsedPeriodsFileName, elapsedPeriodsFileName); } else { - switch (compressionMode) { - case Compress.NONE: + if (compressionMode == CompressionMode.NONE) { util.rename(getParentFileName(), elapsedPeriodsFileName); - break; - case Compress.GZ: - addInfo("GZIP compressing ["+elapsedPeriodsFileName+"]"); - compress.GZCompress(getParentFileName(), elapsedPeriodsFileName); - break; - case Compress.ZIP: - addInfo("ZIP compressing ["+elapsedPeriodsFileName+"]"); - compress.ZIPCompress(getParentFileName(), elapsedPeriodsFileName); - break; + } else { + doCompression(true, getParentFileName(), elapsedPeriodsFileName); } } - - //let's update the parent active file name + + // let's update the parent active file name setParentFileName(getNewActiveFileName()); - + + } + + void doCompression(boolean rename, String nameOfFile2Compress, + String nameOfCompressedFile) throws RolloverFailure { + Compressor compressor = null; + + if (rename) { + String renameTarget = nameOfFile2Compress + System.nanoTime() + ".tmp"; + util.rename(getParentFileName(), renameTarget); + nameOfFile2Compress = renameTarget; + } + + switch (compressionMode) { + case GZ: + addInfo("GZIP compressing [" + nameOfFile2Compress + "]."); + compressor = new Compressor(CompressionMode.GZ, nameOfFile2Compress, + nameOfCompressedFile); + compressor.setContext(this.context); + break; + case ZIP: + addInfo("ZIP compressing [" + nameOfFile2Compress + "]"); + compressor = new Compressor(CompressionMode.ZIP, nameOfFile2Compress, + nameOfCompressedFile); + compressor.setContext(this.context); + break; + } + + AsynchronousCompressor ac = new AsynchronousCompressor(compressor); + future = ac.compressAsynchronously(); + } /** - * + * * The active log file is determined by the value of the parent's filename - * option. However, in case the file name is left blank, - * then, the active log file equals the file name for the current period - * as computed by the FileNamePattern option. + * option. However, in case the file name is left blank, then, the active log + * file equals the file name for the current period as computed by the + * FileNamePattern option. * - * The RollingPolicy must know wether it is responsible for - * changing the name of the active file or not. If the active file - * name is set by the user via the configuration file, then the - * RollingPolicy must let it like it is. If the user does not - * specify an active file name, then the RollingPolicy generates one. + * The RollingPolicy must know wether it is responsible for changing the name + * of the active file or not. If the active file name is set by the user via + * the configuration file, then the RollingPolicy must let it like it is. If + * the user does not specify an active file name, then the RollingPolicy + * generates one. * - * To be sure that the file name used by the parent class has been - * generated by the RollingPolicy and not specified by the user, we - * keep track of the last generated name object and compare its - * reference to the parent file name. If they match, then - * the RollingPolicy knows it's responsible for the change of the - * file name. + * To be sure that the file name used by the parent class has been generated + * by the RollingPolicy and not specified by the user, we keep track of the + * last generated name object and compare its reference to the parent file + * name. If they match, then the RollingPolicy knows it's responsible for the + * change of the file name. * */ public String getNewActiveFileName() { - if (getParentFileName() == null || getParentFileName() == lastGeneratedFileName) { + if (getParentFileName() == null + || getParentFileName() == lastGeneratedFileName) { String newName = activeFileNamePattern.convertDate(lastCheck); addInfo("Generated a new name for RollingFileAppender: " + newName); lastGeneratedFileName = newName; @@ -186,32 +198,33 @@ } public boolean isTriggeringEvent(File activeFile, final E event) { - long time= getCurrentTime(); + long time = getCurrentTime(); if (time >= nextCheck) { - //addInfo("Time to trigger roll-over"); - // We set the elapsedPeriodsFileName before we set the 'lastCheck' variable + // addInfo("Time to trigger roll-over"); + // We set the elapsedPeriodsFileName before we set the 'lastCheck' + // variable // The elapsedPeriodsFileName corresponds to the file name of the period // that just elapsed. elapsedPeriodsFileName = activeFileNamePattern.convertDate(lastCheck); - //addInfo("elapsedPeriodsFileName set to "+elapsedPeriodsFileName); + // addInfo("elapsedPeriodsFileName set to "+elapsedPeriodsFileName); lastCheck.setTime(time); nextCheck = rc.getNextCheckMillis(lastCheck); Date x = new Date(); x.setTime(nextCheck); - //addInfo("Next check on "+ x); + // addInfo("Next check on "+ x); return true; } else { return false; } - } + } @Override public String toString() { return "c.q.l.core.rolling.TimeBasedRollingPolicy"; } - + } Added: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/AsynchronousCompressor.java ============================================================================== --- (empty file) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/AsynchronousCompressor.java Sat Apr 26 01:05:56 2008 @@ -0,0 +1,19 @@ +package ch.qos.logback.core.rolling.helper; + +import java.util.concurrent.ExecutorService; +import java.util.concurrent.Executors; +import java.util.concurrent.Future; + +public class AsynchronousCompressor { + Compressor compressor; + + public AsynchronousCompressor(Compressor compressor) { + this.compressor = compressor; + } + + public Future<?> compressAsynchronously() { + ExecutorService executor = Executors.newScheduledThreadPool(1); + return executor.submit(new CompressionRunnable(compressor)); + } + +} Added: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/CompressionMode.java ============================================================================== --- (empty file) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/CompressionMode.java Sat Apr 26 01:05:56 2008 @@ -0,0 +1,5 @@ +package ch.qos.logback.core.rolling.helper; + +public enum CompressionMode { + NONE, GZ, ZIP; +} Added: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/CompressionRunnable.java ============================================================================== --- (empty file) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/CompressionRunnable.java Sat Apr 26 01:05:56 2008 @@ -0,0 +1,14 @@ +package ch.qos.logback.core.rolling.helper; + + +public class CompressionRunnable implements Runnable { + + final Compressor compressor; + public CompressionRunnable(Compressor compressor) { + this.compressor = compressor; + } + + public void run() { + compressor.compress(); + } +} Copied: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/Compressor.java (from r1666, /logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/Compress.java) ============================================================================== --- /logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/Compress.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/Compressor.java Sat Apr 26 01:05:56 2008 @@ -16,7 +16,6 @@ import java.util.zip.ZipEntry; import java.util.zip.ZipOutputStream; -import ch.qos.logback.core.Context; import ch.qos.logback.core.spi.ContextAwareBase; import ch.qos.logback.core.status.ErrorStatus; import ch.qos.logback.core.status.WarnStatus; @@ -28,37 +27,37 @@ * * @author Ceki Gülcü */ -public class Compress extends ContextAwareBase { - public static final int NONE = 0; - public static final int GZ = 1; - public static final int ZIP = 2; - /** - * String constant representing no compression. The value of this constant is - * "NONE". - */ - public static final String NONE_STR = "NONE"; - - /** - * String constant representing compression in the GZIP format. The value of - * this constant is "GZ". - */ - public static final String GZ_STR = "GZ"; - - /** - * String constant representing compression in the ZIP format. The value of - * this constant is "ZIP". - */ - public static final String ZIP_STR = "ZIP"; - - Context context; - - public void ZIPCompress(String nameOfFile2zip) { - // Here we rely on the fact that the two argument version of ZIPCompress - // automatically adds a .zip extension to the second argument - GZCompress(nameOfFile2zip, nameOfFile2zip); +public class Compressor extends ContextAwareBase { + + final CompressionMode compressionMode; + final String nameOfFile2Compress; + final String nameOfCompressedFile; + + + public Compressor(CompressionMode compressionMode, String nameOfFile2Compress, String nameOfCompressedFile) { + this.compressionMode = compressionMode; + this.nameOfFile2Compress = nameOfFile2Compress; + this.nameOfCompressedFile = nameOfCompressedFile; + } + + public Compressor(CompressionMode compressionMode, String nameOfFile2Compress) { + // Here we rely on the fact that the two argument version of ZIPCompress/GZCompress + // automatically adds a .zip/.gz extension to the second argument + this(compressionMode, nameOfFile2Compress, nameOfFile2Compress); } - public void ZIPCompress(String nameOfFile2zip, String nameOfZippedFile) { + public void compress() { + switch(compressionMode) { + case GZ: + gzCompress(nameOfFile2Compress, nameOfCompressedFile); + break; + case ZIP: + zipCompress(nameOfFile2Compress, nameOfCompressedFile); + break; + } + } + + private void zipCompress(String nameOfFile2zip, String nameOfZippedFile) { File file2zip = new File(nameOfFile2zip); if (!file2zip.exists()) { @@ -111,13 +110,7 @@ } } - public void GZCompress(String nameOfFile2gz) { - // Here we rely on the fact that the two argument version of GZCompress - // automatically adds a .gz extension to the second argument - GZCompress(nameOfFile2gz, nameOfFile2gz); - } - - public void GZCompress(String nameOfFile2gz, String nameOfgzedFile) { + private void gzCompress(String nameOfFile2gz, String nameOfgzedFile) { File file2gz = new File(nameOfFile2gz); if (!file2gz.exists()) { Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/rolling/TimeBasedRollingTest.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/rolling/TimeBasedRollingTest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/rolling/TimeBasedRollingTest.java Sat Apr 26 01:05:56 2008 @@ -10,18 +10,19 @@ package ch.qos.logback.core.rolling; +import java.io.File; +import java.text.SimpleDateFormat; +import java.util.Calendar; +import java.util.concurrent.TimeUnit; + +import junit.framework.Test; +import junit.framework.TestCase; +import junit.framework.TestSuite; import ch.qos.logback.core.Context; import ch.qos.logback.core.ContextBase; import ch.qos.logback.core.layout.EchoLayout; import ch.qos.logback.core.util.Compare; import ch.qos.logback.core.util.Constants; -import junit.framework.Test; -import junit.framework.TestCase; -import junit.framework.TestSuite; - -import java.io.File; -import java.text.SimpleDateFormat; -import java.util.Calendar; /** * A rather exhaustive set of tests. Tests include leaving the file option @@ -241,9 +242,7 @@ tbrp.setCurrentTime(addTime(tbrp.getCurrentTime(), 500)); } - // for (int i = 0; i < 3; i++) { - // System.out.println(i + " expected filename [" + filenames[i] + "]."); - // } + tbrp.future.get(1000, TimeUnit.MILLISECONDS); for (int i = 0; i < 2; i++) { assertTrue(Compare.gzCompare(filenames[i], Constants.TEST_DIR_PREFIX @@ -424,6 +423,9 @@ // System.out.println(i + " expected filename [" + filenames[i] + "]."); // } + // wait for the compression task to finish + tbrp.future.get(1000, TimeUnit.MILLISECONDS); + for (int i = 0; i < 2; i++) { assertTrue(Compare.gzCompare(filenames[i], Constants.TEST_DIR_PREFIX + "witness/rolling/tbr-test6." + i + ".gz")); @@ -432,7 +434,7 @@ assertTrue(Compare.compare(filenames[2], Constants.TEST_DIR_PREFIX + "witness/rolling/tbr-test6.2")); } - + public static Test suite() { TestSuite suite = new TestSuite(); suite.addTestSuite(TimeBasedRollingTest.class); Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/rolling/helper/CompressTest.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/rolling/helper/CompressTest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/rolling/helper/CompressTest.java Sat Apr 26 01:05:56 2008 @@ -16,108 +16,106 @@ import java.io.InputStream; import java.io.OutputStream; -import junit.framework.Test; import junit.framework.TestCase; -import junit.framework.TestSuite; import ch.qos.logback.core.Context; import ch.qos.logback.core.ContextBase; import ch.qos.logback.core.util.Compare; import ch.qos.logback.core.util.Constants; import ch.qos.logback.core.util.StatusPrinter; - /** * @author Ceki Gulcu */ public class CompressTest extends TestCase { - Compress compress; Context context = new ContextBase(); - - public CompressTest(String arg0) { - super(arg0); - compress = new Compress(); - compress.setContext(context); - } public void setUp() throws IOException { - //Copy source files - //Delete output files - { - File source = new File(Constants.TEST_DIR_PREFIX + "input/compress1.copy"); - File dest = new File(Constants.TEST_DIR_PREFIX + "input/compress1.txt"); - copy(source, dest); - File target = new File(Constants.TEST_DIR_PREFIX + "output/compress1.txt.gz"); - target.mkdirs(); - target.delete(); - } - { - File source = new File(Constants.TEST_DIR_PREFIX + "input/compress2.copy"); - File dest = new File(Constants.TEST_DIR_PREFIX + "input/compress2.txt"); - copy(source, dest); - File target = new File(Constants.TEST_DIR_PREFIX + "output/compress2.txt.gz"); - target.mkdirs(); - target.delete(); - } - { - File source = new File(Constants.TEST_DIR_PREFIX + "input/compress3.copy"); - File dest = new File(Constants.TEST_DIR_PREFIX + "input/compress3.txt"); - copy(source, dest); - File target = new File(Constants.TEST_DIR_PREFIX + "output/compress3.txt.zip"); - target.mkdirs(); - target.delete(); - } + // Copy source files + // Delete output files + { + File source = new File(Constants.TEST_DIR_PREFIX + "input/compress1.copy"); + File dest = new File(Constants.TEST_DIR_PREFIX + "input/compress1.txt"); + + copy(source, dest); + File target = new File(Constants.TEST_DIR_PREFIX + + "output/compress1.txt.gz"); + target.mkdirs(); + target.delete(); + } + { + File source = new File(Constants.TEST_DIR_PREFIX + "input/compress2.copy"); + File dest = new File(Constants.TEST_DIR_PREFIX + "input/compress2.txt"); + copy(source, dest); + File target = new File(Constants.TEST_DIR_PREFIX + + "output/compress2.txt.gz"); + target.mkdirs(); + target.delete(); + } + { + File source = new File(Constants.TEST_DIR_PREFIX + "input/compress3.copy"); + File dest = new File(Constants.TEST_DIR_PREFIX + "input/compress3.txt"); + copy(source, dest); + File target = new File(Constants.TEST_DIR_PREFIX + + "output/compress3.txt.zip"); + target.mkdirs(); + target.delete(); + } } public void tearDown() { } public void test1() throws Exception { - compress.GZCompress(Constants.TEST_DIR_PREFIX + "input/compress1.txt", Constants.TEST_DIR_PREFIX + "output/compress1.txt.gz"); - - StatusPrinter.print(context.getStatusManager()); - assertEquals(0, context.getStatusManager().getCount()); - assertTrue(Compare.gzCompare(Constants.TEST_DIR_PREFIX + "output/compress1.txt.gz", - Constants.TEST_DIR_PREFIX + "witness/compress1.txt.gz")); + Compressor compressor = new Compressor(CompressionMode.GZ, + Constants.TEST_DIR_PREFIX + "input/compress1.txt", + Constants.TEST_DIR_PREFIX + "output/compress1.txt.gz"); + compressor.setContext(context); + compressor.compress(); + + StatusPrinter.print(context.getStatusManager()); + assertEquals(0, context.getStatusManager().getCount()); + assertTrue(Compare.gzCompare(Constants.TEST_DIR_PREFIX + + "output/compress1.txt.gz", Constants.TEST_DIR_PREFIX + + "witness/compress1.txt.gz")); } public void test2() throws Exception { - compress.GZCompress(Constants.TEST_DIR_PREFIX + "input/compress2.txt", Constants.TEST_DIR_PREFIX + "output/compress2.txt"); - - StatusPrinter.print(context.getStatusManager()); - assertEquals(0, context.getStatusManager().getCount()); - assertTrue(Compare.gzCompare(Constants.TEST_DIR_PREFIX + "output/compress2.txt.gz", - Constants.TEST_DIR_PREFIX + "witness/compress2.txt.gz")); + Compressor compressor = new Compressor(CompressionMode.GZ, + Constants.TEST_DIR_PREFIX + "input/compress2.txt", + Constants.TEST_DIR_PREFIX + "output/compress2.txt"); + compressor.setContext(context); + compressor.compress(); + + StatusPrinter.print(context.getStatusManager()); + assertEquals(0, context.getStatusManager().getCount()); + assertTrue(Compare.gzCompare(Constants.TEST_DIR_PREFIX + + "output/compress2.txt.gz", Constants.TEST_DIR_PREFIX + + "witness/compress2.txt.gz")); } public void test3() throws Exception { - compress.ZIPCompress(Constants.TEST_DIR_PREFIX + "input/compress3.txt", Constants.TEST_DIR_PREFIX + "output/compress3.txt"); - - StatusPrinter.print(context.getStatusManager()); - assertEquals(0, context.getStatusManager().getCount()); + Compressor compressor = new Compressor(CompressionMode.ZIP, + Constants.TEST_DIR_PREFIX + "input/compress3.txt", + Constants.TEST_DIR_PREFIX + "output/compress3.txt"); + compressor.setContext(context); + compressor.compress(); + StatusPrinter.print(context.getStatusManager()); + assertEquals(0, context.getStatusManager().getCount()); // assertTrue(Compare.compare("output/compress3.txt.zip", // "witness/compress3.txt.zip")); } - public static Test suite() { - TestSuite suite = new TestSuite(); - suite.addTest(new CompressTest("test1")); - suite.addTest(new CompressTest("test2")); - suite.addTest(new CompressTest("test3")); - return suite; - } - private void copy(File src, File dst) throws IOException { - InputStream in = new FileInputStream(src); - OutputStream out = new FileOutputStream(dst); - byte[] buf = new byte[1024]; - int len; - while ((len = in.read(buf)) > 0) { - out.write(buf, 0, len); - } - in.close(); - out.close(); + InputStream in = new FileInputStream(src); + OutputStream out = new FileOutputStream(dst); + byte[] buf = new byte[1024]; + int len; + while ((len = in.read(buf)) > 0) { + out.write(buf, 0, len); + } + in.close(); + out.close(); } - - + }

1 0

[Bug 149] New: compression should happen in a separate thread
by bugzilla-daemon＠pixie.qos.ch 22 Apr '08

22 Apr '08

http://bugzilla.qos.ch/show_bug.cgi?id=149 Summary: compression should happen in a separate thread Product: logback-core Version: unspecified Platform: Other OS/Version: All Status: NEW Severity: enhancement Priority: P1 Component: Rolling AssignedTo: logback-dev(a)qos.ch ReportedBy: noreply.ceki(a)qos.ch During rollover, compression can bring all logging to a halt. This bug is related to bug #55. http://bugzilla.qos.ch/show_bug.cgi?id=55 -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 1

[Bug 55] New: Implement AsyncAppender
by bugzilla-daemon＠pixie.qos.ch 22 Apr '08

22 Apr '08

http://bugzilla.qos.ch/show_bug.cgi?id=55 Summary: Implement AsyncAppender Product: logback-classic Version: unspecified Platform: PC OS/Version: Windows Status: NEW Severity: enhancement Priority: P1 Component: Other AssignedTo: logback-dev(a)qos.ch ReportedBy: anders_wallgren(a)alum.mit.edu Being able to write log files in the background is a requirement for production deployments of anything we would write on top of logback. Bonus points for including a feature to periodically flush the output. -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 2

[JIRA] Test Message From JIRA
by bugzilla-daemon＠pixie.qos.ch 22 Apr '08

22 Apr '08

This is a test message from JIRA. Server: Defauls SMTP Host SMTP Port: 25 Description: Localhost From: bugzilla-daemon(a)pixie.qos.ch Host User Name: null

1 0

[Bug 148] New: Use of BasicStatusManager.iterator() without synchronization in ch.qos.logback.classic.jmx.Configurator
by bugzilla-daemon＠pixie.qos.ch 22 Apr '08

22 Apr '08

http://bugzilla.qos.ch/show_bug.cgi?id=148 Summary: Use of BasicStatusManager.iterator() without synchronization in ch.qos.logback.classic.jmx.Configurator Product: logback-classic Version: unspecified Platform: PC OS/Version: Windows Status: NEW Severity: major Priority: P1 Component: Other AssignedTo: logback-dev(a)qos.ch ReportedBy: joern(a)huxhorn.de We sometimes receive strange exceptions in our webapp: [21/Apr/2008:21:00:58] warning ( 1596): CORE3283: stderr: Exception in thread "Thread-6" java.lang.ArrayIndexOutOfBoundsException [21/Apr/2008:21:00:58] warning ( 1596): CORE3283: stderr: at java.lang.System.arraycopy(Native Method) [21/Apr/2008:21:00:58] warning ( 1596): CORE3283: stderr: at java.util.ArrayList.ensureCapacity(ArrayList.java:170) [21/Apr/2008:21:00:58] warning ( 1596): CORE3283: stderr: at java.util.ArrayList.add(ArrayList.java:351) [21/Apr/2008:21:00:58] warning ( 1596): CORE3283: stderr: at ch.qos.logback.core.BasicStatusManager.add(BasicStatusManager.java:38) [21/Apr/2008:21:00:58] warning ( 1596): CORE3283: stderr: at ch.qos.logback.core.spi.ContextAwareBase.addStatus(ContextAwareBase.java:59) [21/Apr/2008:21:00:58] warning ( 1596): CORE3283: stderr: at ch.qos.logback.core.spi.ContextAwareBase.addInfo(ContextAwareBase.java:64) I just tried to analyze the problem and found out that ch.qos.logback.classic.jmx.Configurator is simply using the iterator of the status manager without synchronizing, as it's documented in BasicStatusManager. So instead of public List<String> getStatuses() { List<String> list = new ArrayList<String>(); Iterator<Status> it = context.getStatusManager().iterator(); while(it.hasNext()) { list.add(it.next().toString()); } return list; } it should probably be public List<String> getStatuses() { List<String> list = new ArrayList<String>(); StatusManager sm = context.getStatusManager(); Iterator<Status> it = sm.iterator(); synchronized(sm) { while(it.hasNext()) { list.add(it.next().toString()); } } return list; } -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 0

svn commit: r1676 - in logback/trunk/logback-site/src/site/pages: . templates
by noreply.ceki＠qos.ch 17 Apr '08

17 Apr '08

Author: ceki Date: Thu Apr 17 17:18:41 2008 New Revision: 1676 Modified: logback/trunk/logback-site/src/site/pages/codes.html logback/trunk/logback-site/src/site/pages/news.html logback/trunk/logback-site/src/site/pages/templates/footer.js Log: - updating the error code for null_CS - copyright is 2000 to 2008 - other docs changes Modified: logback/trunk/logback-site/src/site/pages/codes.html ============================================================================== --- logback/trunk/logback-site/src/site/pages/codes.html (original) +++ logback/trunk/logback-site/src/site/pages/codes.html Thu Apr 17 17:18:41 2008 @@ -23,13 +23,21 @@ <h2><a name="top">Logback error messages and their meanings</a></h2> - <a name="null_CS" href="#null_CS"> - contextSelector cannot be null + <a name="null_CS" href="#null_CS"> The contextSelector cannot be + null in <code>StaticLoggerBinder</code>. </a> - XXXXXXXXXXX + An <code>IllegalStateException</code> is thrown when no + ContextSelector could be set for logback's + <code>StaticLoggerBinder</code>. In principle, this error can only + occur when the context selector is expressly specified by the user, + and when that context selector cannot not be instantiated correctly. + + It should not happen when you are using the default or JNDI + context selectors. + <hr/> Modified: logback/trunk/logback-site/src/site/pages/news.html ============================================================================== --- logback/trunk/logback-site/src/site/pages/news.html (original) +++ logback/trunk/logback-site/src/site/pages/news.html Thu Apr 17 17:18:41 2008 @@ -36,6 +36,12 @@ initialization, unless told to be quiet. This greatly helps troubleshooting the configration of logback-access under Tomcat. + + Fixed <a href="http://bugzilla.qos.ch/show_bug.cgi?id=147">bug + 147</a> which occured when the user inadvertently attempted to set + the layout of a <code>SyslogAppender</code>. The code now actively + prevents this. Documenation has been updated to reflect the change. + <hr width="80%" align="center" /> Modified: logback/trunk/logback-site/src/site/pages/templates/footer.js ============================================================================== --- logback/trunk/logback-site/src/site/pages/templates/footer.js (original) +++ logback/trunk/logback-site/src/site/pages/templates/footer.js Thu Apr 17 17:18:41 2008 @@ -1,4 +1,4 @@ document.write('') -document.write('Copyright © 2000-2007 <a href="http://www.qos.ch/">QOS.ch</a>') +document.write('Copyright © 2000-2008 <a href="http://www.qos.ch/">QOS.ch</a>') document.write('') \ No newline at end of file

1 0

[Bug 147] New: ch.qos.logback.classic.net.SyslogAppender fail with NullPointerException
by bugzilla-daemon＠pixie.qos.ch 17 Apr '08

17 Apr '08

http://bugzilla.qos.ch/show_bug.cgi?id=147 Summary: ch.qos.logback.classic.net.SyslogAppender fail with NullPointerException Product: logback-classic Version: unspecified Platform: PC OS/Version: Windows Status: NEW Severity: normal Priority: P1 Component: Other AssignedTo: logback-dev(a)qos.ch ReportedBy: rybin.andrey+logback(a)gmail.com Joran shows no error in conf file, but SyslogAppender failed with NullPointerException (because prefixLayout == null). I think Joran should show a error or SyslogAppender should work. conf, java and log below: conf: <?xml version="1.0" encoding="UTF-8"?> <configuration debug="true"> <appender name="aSYSLOG" class="ch.qos.logback.classic.net.SyslogAppender"> <SyslogHost>127.0.0.1</SyslogHost> <Facility>LOCAL7</Facility> <layout class="ch.qos.logback.classic.PatternLayout"> <pattern>%d %p [%t] %c::%m%n</pattern> </layout> </appender> <root> <level value="TRACE"/> <appender-ref ref="aSYSLOG"/> </root> </configuration> java: public static void main(String[] a) { org.slf4j.Logger log = org.slf4j.LoggerFactory.getLogger(TestLogback.class); log.warn("test"); ch.qos.logback.classic.util.LoggerStatusPrinter.printStatusInDefaultContext(); }//main log: 11:09:10,687 |-INFO in ch.qos.logback.core.joran.action.AppenderAction - About to instantiate appender of type [ch.qos.logback.classic.net.SyslogAppender] 11:09:10,687 |-INFO in ch.qos.logback.core.joran.action.AppenderAction - Naming appender as [aSYSLOG] 11:09:10,796 |-INFO in ch.qos.logback.core.joran.action.AppenderAction - Popping appender named [aSYSLOG] from the object stack 11:09:10,796 |-INFO in ch.qos.logback.classic.joran.action.LevelAction - root level set to TRACE 11:09:10,796 |-INFO in ch.qos.logback.core.joran.action.AppenderRefAction - Attaching appender named [aSYSLOG] to Logger[root] 11:09:10,796 |-INFO in ch.qos.logback.classic.joran.action.ConfigurationAction - End of configuration. 11:09:10,796 |-ERROR in ch.qos.logback.classic.net.SyslogAppender[aSYSLOG] - Appender [aSYSLOG] failed to append. java.lang.NullPointerException java.lang.NullPointerException at ch.qos.logback.classic.net.SyslogAppender.postProcess(SyslogAppender.java:81) at ch.qos.logback.core.net.SyslogAppenderBase.append(SyslogAppenderBase.java:62) at ch.qos.logback.core.AppenderBase.doAppend(AppenderBase.java:81) at ch.qos.logback.core.spi.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:51) at ch.qos.logback.classic.Logger.appendLoopOnAppenders(Logger.java:282) at ch.qos.logback.classic.Logger.callAppenders(Logger.java:266) at ch.qos.logback.classic.Logger.buildLoggingEventAndAppend(Logger.java:487) at ch.qos.logback.classic.Logger.filterAndLog(Logger.java:479) at ch.qos.logback.classic.Logger.warn(Logger.java:712) at net.sf.apr.test.logback.TestLogback.main(TestLogback.java:7) -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 1

svn commit: r1675 - in logback/trunk: logback-classic/src/test/input/joran logback-classic/src/test/java/ch/qos/logback/classic logback-classic/src/test/java/ch/qos/logback/classic/net logback-core/src/main/java/ch/qos/logback/core/net logback-site/src/site/pages logback-site/src/site/pages/manual
by noreply.ceki＠qos.ch 17 Apr '08

17 Apr '08

Author: ceki Date: Thu Apr 17 16:52:22 2008 New Revision: 1675 Added: logback/trunk/logback-classic/src/test/input/joran/syslog_147.xml logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/TestContants.java - copied, changed from r1666, /logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/Contants4T.java Removed: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/Contants4T.java Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/PatternLayoutTest.java logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net/PackageTest.java logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net/SyslogAppenderTest.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/net/SyslogAppenderBase.java logback/trunk/logback-site/src/site/pages/codes.html logback/trunk/logback-site/src/site/pages/manual/appenders.html Log: - renamed Constant4T ad TestConstants - fixed bug 147 which was caused by the user specifying a layout for SyslogAppender. SyslogAppender now disallows the user to set a layout. It also informs the user that the action is disallows directing her to an error page. - updated codes.html in relation to bug 147 - simplified and shortened codes.html Added: logback/trunk/logback-classic/src/test/input/joran/syslog_147.xml ============================================================================== --- (empty file) +++ logback/trunk/logback-classic/src/test/input/joran/syslog_147.xml Thu Apr 17 16:52:22 2008 @@ -0,0 +1,14 @@ +<?xml version="1.0" encoding="UTF-8"?> +<configuration debug="true"> + <appender name="aSYSLOG" class="ch.qos.logback.classic.net.SyslogAppender"> + <SyslogHost>127.0.0.1</SyslogHost> + <Facility>LOCAL7</Facility> + <layout class="ch.qos.logback.classic.PatternLayout"> + <pattern>%d %p [%t] %c::%m%n</pattern> + </layout> + </appender> + <root> + <level value="TRACE"/> + <appender-ref ref="aSYSLOG"/> + </root> +</configuration> \ No newline at end of file Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/PatternLayoutTest.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/PatternLayoutTest.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/PatternLayoutTest.java Thu Apr 17 16:52:22 2008 @@ -64,7 +64,7 @@ pl.start(); String val = pl.doLayout(getEventObject()); // 2006-02-01 22:38:06,212 INFO [main] c.q.l.pattern.ConverterTest - Some message - String regex = Contants4T.ISO_REGEX+" INFO \\[main] c.q.l.c.pattern.ConverterTest - Some message\\s*"; + String regex = TestContants.ISO_REGEX+" INFO \\[main] c.q.l.c.pattern.ConverterTest - Some message\\s*"; assertTrue(val.matches(regex)); } @@ -86,7 +86,7 @@ pl.start(); String val = pl.doLayout(getEventObject()); // 2008-03-18 21:55:54,250 [main] c.q.l.c.pattern.ConverterTest - Some message - String regex = Contants4T.ISO_REGEX+" \\[main] c.q.l.c.p.ConverterTest - Some message\\s*"; + String regex = TestContants.ISO_REGEX+" \\[main] c.q.l.c.p.ConverterTest - Some message\\s*"; System.out.println(val); assertTrue(val.matches(regex)); @@ -123,7 +123,7 @@ pl.start(); String val = pl.doLayout(getEventObject()); // 2006-02-01 22:38:06,212 INFO [main] c.q.l.pattern.ConverterTest - Some message - String regex = Contants4T.ISO_REGEX+" INFO \\[main] c.q.l.c.pattern.ConverterTest - Some message\\s*"; + String regex = TestContants.ISO_REGEX+" INFO \\[main] c.q.l.c.pattern.ConverterTest - Some message\\s*"; assertTrue(val.matches(regex)); } Copied: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/TestContants.java (from r1666, /logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/Contants4T.java) ============================================================================== --- /logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/Contants4T.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/TestContants.java Thu Apr 17 16:52:22 2008 @@ -9,7 +9,9 @@ */ package ch.qos.logback.classic; -public class Contants4T { +public class TestContants { final static public String ISO_REGEX = "\\d{4}-\\d{2}-\\d{2} \\d{2}:\\d{2}:\\d{2},\\d{3}"; + + final static public String JORAN_ONPUT_PREFIX = "src/test/input/joran"; } Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net/PackageTest.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net/PackageTest.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net/PackageTest.java Thu Apr 17 16:52:22 2008 @@ -19,7 +19,7 @@ public static Test suite() { TestSuite suite = new TestSuite(); - suite.addTestSuite(SyslogAppenderTest.class); + suite.addTest(new JUnit4TestAdapter(SyslogAppenderTest.class)); suite.addTestSuite(SMTPAppenderTest.class); suite.addTest(new JUnit4TestAdapter(SocketAppenderTest.class)); suite.addTestSuite(JMSTopicAppenderTest.class); Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net/SyslogAppenderTest.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net/SyslogAppenderTest.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net/SyslogAppenderTest.java Thu Apr 17 16:52:22 2008 @@ -9,26 +9,34 @@ */ package ch.qos.logback.classic.net; -import junit.framework.TestCase; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertTrue; + +import org.junit.After; +import org.junit.Before; +import org.junit.Test; +import org.slf4j.LoggerFactory; + import ch.qos.logback.classic.Logger; import ch.qos.logback.classic.LoggerContext; +import ch.qos.logback.classic.TestContants; +import ch.qos.logback.classic.joran.JoranConfigurator; import ch.qos.logback.classic.net.mock.MockSyslogServer; +import ch.qos.logback.core.joran.spi.JoranException; import ch.qos.logback.core.net.SyslogConstants; +import ch.qos.logback.core.util.StatusPrinter; -public class SyslogAppenderTest extends TestCase { - - public SyslogAppenderTest(String arg0) { - super(arg0); - } +public class SyslogAppenderTest { - protected void setUp() throws Exception { - super.setUp(); + @Before + public void setUp() throws Exception { } - protected void tearDown() throws Exception { - super.tearDown(); + @After + public void tearDown() throws Exception { } + @Test public void testBasic() throws InterruptedException { int port = MockSyslogServer.PORT + 1; @@ -53,7 +61,7 @@ logger.addAppender(sa); String logMsg = "hello"; logger.debug(logMsg); - //StatusPrinter.print(lc.getStatusManager()); + // StatusPrinter.print(lc.getStatusManager()); // wait max 2 seconds for mock server to finish. However, it should // much sooner than that. @@ -73,6 +81,7 @@ } + @Test public void testException() throws InterruptedException { int port = MockSyslogServer.PORT + 2; MockSyslogServer mockServer = new MockSyslogServer(21, port); @@ -98,29 +107,45 @@ String exMsg = "just testing"; Exception ex = new Exception(exMsg); logger.debug(logMsg, ex); - //StatusPrinter.print(lc.getStatusManager()); + // StatusPrinter.print(lc.getStatusManager()); // wait max 2 seconds for mock server to finish. However, it should // much sooner than that. mockServer.join(8000); assertTrue(mockServer.isFinished()); - - //message + 20 lines of stacktrace + + // message + 20 lines of stacktrace assertEquals(21, mockServer.getMessageList().size()); -// int i = 0; -// for (String line: mockServer.msgList) { -// System.out.println(i++ + ": " + line); -// } - + // int i = 0; + // for (String line: mockServer.msgList) { + // System.out.println(i++ + ": " + line); + // } + String msg = mockServer.getMessageList().get(0); String expected = "<" + (SyslogConstants.LOG_MAIL + SyslogConstants.DEBUG_SEVERITY) + ">"; assertTrue(msg.startsWith(expected)); - + String expectedPrefix = "<\\d{2}>\\w{3} \\d{2} \\d{2}(:\\d{2}){2} \\w* "; String threadName = Thread.currentThread().getName(); - String expectedResult = expectedPrefix + "\\[" + threadName + "\\] " + loggerName - + " " + logMsg; + String expectedResult = expectedPrefix + "\\[" + threadName + "\\] " + + loggerName + " " + logMsg; assertTrue(msg.matches(expectedResult)); } + + @Test + public void bug147() throws JoranException { + + LoggerContext lc = (LoggerContext) LoggerFactory.getILoggerFactory(); + + JoranConfigurator configurator = new JoranConfigurator(); + configurator.setContext(lc); + lc.shutdownAndReset(); + configurator.doConfigure(TestContants.JORAN_ONPUT_PREFIX + + "/syslog_147.xml"); + + org.slf4j.Logger logger = LoggerFactory.getLogger(this.getClass()); + logger.info("hello"); + StatusPrinter.print(lc); + } } Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/net/SyslogAppenderBase.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/net/SyslogAppenderBase.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/net/SyslogAppenderBase.java Thu Apr 17 16:52:22 2008 @@ -5,10 +5,13 @@ import java.net.UnknownHostException; import ch.qos.logback.core.AppenderBase; +import ch.qos.logback.core.CoreGlobal; import ch.qos.logback.core.Layout; public abstract class SyslogAppenderBase<E> extends AppenderBase<E> { + final static String SYSLOG_LAYOUT_URL = CoreGlobal.CODES_URL + "#syslog_layout"; + Layout<E> layout; int facility; String facilityStr; @@ -44,7 +47,7 @@ super.start(); } } - + abstract public Layout<E> buildLayout(String facilityStr); abstract public int getSeverityForEvent(Object eventObject); @@ -182,15 +185,13 @@ this.port = port; } - /** - * You can override - */ + public Layout<E> getLayout() { return layout; } public void setLayout(Layout<E> layout) { - this.layout = layout; + addWarn("The layout of a SyslogAppender cannot be set directly. See also "+SYSLOG_LAYOUT_URL); } @Override Modified: logback/trunk/logback-site/src/site/pages/codes.html ============================================================================== --- logback/trunk/logback-site/src/site/pages/codes.html (original) +++ logback/trunk/logback-site/src/site/pages/codes.html Thu Apr 17 16:52:22 2008 @@ -2,7 +2,7 @@ <html xmlns="http://www.w3.org/1999/xhtml"> <head> <meta http-equiv="content-type" content="text/html; charset=iso-8859-1" /> -<title>Logback FAQ</title> +<title>Logback Error Codes</title> <link rel="stylesheet" type="text/css" media="screen" href="css/site.css" /> </head> @@ -23,380 +23,243 @@ <h2><a name="top">Logback error messages and their meanings</a></h2> - <ol type="1"> + <a name="null_CS" href="#null_CS"> + contextSelector cannot be null + </a> + - <li> - <a href="#null_CS">contextSelector cannot be null</a> - </li> + XXXXXXXXXXX - <li> - <a href="#tbr_fnp_not_set">The FileNamePattern option - must be set before using <code>TimeBasedRollingPolicy</code> or - <code>FixedWindowRollingPolicy</code> - </a> - </li> + <hr/> - <li> - <a href="#fwrp_parentFileName_not_set">The File option must be set before - <code>FixedWindowRollingPolicy</code> - </a> - </li> - - <li> - <a href="#socket_no_host">No remote host or address is set - for <code>SocketAppender</code> - </a> - </li> - - <li> - <a href="#socket_no_port">No remote port is set for - <code>SocketAppender</code> - </a> - </li> - - - <li> - <a href="#smtp_no_layout"> - No <code>Layout</code> is set for appender - </a> - </li> - - <li> - <a href="#sbtp_size_format"> - Specified number is not in proper int form, or - not expected format. - </a> - </li> - - <li> - <a href="#rfa_no_tp"> - No <code>TriggeringPolicy</code> was set for the - <code>RollingFileAppender</code> - </a> - </li> - - <li> - <a href="#rfa_no_rp"> - No <code>RollingPolicy</code> was set for the - <code>RollingFileAppender</code> - </a> - </li> - </ol> - - - <h2>Error codes and their meanings</h2> - - <dl> - <dt> - <a name="null_CS"> - contextSelector cannot be null - </a> - </dt> - - <dd> - - - </dd> + + <a name="tbr_fnp_not_set" href="#tbr_fnp_not_set"> + The FileNamePattern option must be set before using + <code>TimeBasedRollingPolicy</code> or + <code>FixedWindowRollingPolicy</code> + </a> + - <dt> - <a name="tbr_fnp_not_set"> - The FileNamePattern option must be set before using - <code>TimeBasedRollingPolicy</code> or - <code>FixedWindowRollingPolicy</code> - - </a> - </dt> - - <dd> - The FileNamePattern option for both - <code>TimeBasedRollingPolicy</code> and - <code>FixedWindowRollingPolicy</code> is mandatory. - - - See the <a - href="http://logback.qos.ch/apidocs/ch/qos/logback/core/rolling/FixedWindowRollin…"> - FixedWindowRollingPolicy javadoc - </a> for more information. - - + + The FileNamePattern option for both + <code>TimeBasedRollingPolicy</code> and + <code>FixedWindowRollingPolicy</code> is mandatory. + + + See the <a + href="http://logback.qos.ch/apidocs/ch/qos/logback/core/rolling/FixedWindowRollin…"> + FixedWindowRollingPolicy javadoc </a> for more information. + - <table border="0"> - <tr> - <td align="right"><a href="#top">[top]</a></td> - </tr> - </table> - <hr /> - </dd> - - <dt> - <a name="fwrp_parentFileName_not_set"> - The File option must be set before - <code>FixedWindowRollingPolicy</code> - </a> - </dt> + <hr /> - <dd> - The File option is mandatory with - <code>FixedWindowRollingPolicy</code>. Moreover, the File option must be set before the - <code>FixedWindowRollingPolicy</code> element. - - - Refer to the logback manual on - <a href="manual/appenders.html#FixedWindowRollingPolicy"> - FixedWindowRollingPolicy - </a> - for more information. - + + <a name="fwrp_parentFileName_not_set" href="#fwrp_parentFileName_not_set"> + The File option must be set before + <code>FixedWindowRollingPolicy</code> + </a> + + + The File option is mandatory with + <code>FixedWindowRollingPolicy</code>. Moreover, the File option must be set before the + <code>FixedWindowRollingPolicy</code> element. + + + Refer to the logback manual on + <a href="manual/appenders.html#FixedWindowRollingPolicy"> + FixedWindowRollingPolicy </a> for more information. + - <table border="0"> - <tr> - <td align="right"> - <a href="#top">[top]</a> - </td> - </tr> - </table> - <hr /> - - </dd> - - <dt> - <a name="socket_no_host">No remote host or address is set for - <code>SocketAppender</code> - </a> - </dt> - <dd> - A remote host or address is mandatory for SocketAppender. - - You can specify the remote host in the configuration file - like this: - - - <div class="source"><pre> -<appender name="SOCKET" class="ch.qos.logback.classic.net.SocketAppender"> + <hr /> + + + <a name="socket_no_host" href="#socket_no_host">No remote host or + address is set for <code>SocketAppender</code> + </a> + + + A remote host or address is mandatory for SocketAppender. + You can specify the remote host in the configuration file + as follows. + + + <appender name="SOCKET" + class="ch.qos.logback.classic.net.SocketAppender"> ... - <param name="remoteHost" value="127.0.0.1"></param> + <remoteHost>127.0.0.1</remoteHost> ... -</appender></pre> - </div> - - <table border="0"> - <tr> - <td align="right"> - <a href="#top">[top]</a> - </td> - </tr> - </table> - <hr /> - </dd> - - <dt> - <a name="socket_no_port">No remote port is set for - <code>SocketAppender</code> - </a> - </dt> +</appender> + + + <hr /> + + + <a name="socket_no_port" href="#socket_no_port">No remote port is set for + <code>SocketAppender</code> + </a> + - <dd> - A remote port is mandatory for SocketAppender. - - - You can specify the remote port in the configuration file - like this: - + A remote port is mandatory for SocketAppender. - <div class="source"><pre> -<appender name="SOCKET" class="ch.qos.logback.classic.net.SocketAppender"> + You can specify the remote port in the configuration file + like this: + + + <appender name="SOCKET" class="ch.qos.logback.classic.net.SocketAppender"> ... - <param name="port" value="4560"></param> + <port>4560</port> ... -</appender></pre> - </div> +</appender> - <table border="0"> - <tr> - <td align="right"> - <a href="#top">[top]</a> - </td> - </tr> - </table> - <hr /> - </dd> - - <dt> - <a name="smtp_no_layout">No <code>Layout</code> is set for - appender</a> - </dt> - <dd> - A <code>Layout</code> is mandatory for - <code>SMTPAppender</code> . It allows the appender format the - logging events before sending the email. Two layouts are often - used with <code>SMTPAppender</code> : - <code>PatternLayout</code> and <code>HTMLLayout</code> . - - - You can specify the <code>Layout</code> in the - configuration file like this: - + + <hr /> + + + + <a name="smtp_no_layout" href="#smtp_no_layout"> + No <code>Layout</code> is set for SMTPAppender</a> + + + A <code>Layout</code> is mandatory for + <code>SMTPAppender</code>. It allows SMPTPAppender to format logging + events before sending an email. + + + You can specify the <code>Layout</code> in a configuration file + as follows: + - <div class="source"><pre> -<appender name="SMTP" class="ch.qos.logback.classic.net.SMTPAppender"> + <appender name="SMTP" class="ch.qos.logback.classic.net.SMTPAppender"> ... <layout class="ch.qos.logback.classic.PatternLayout"> - <param name="pattern" value="%-4relative [%thread] %-5level %class - %msg%n"></param> - </layout> + <pattern>%date [%thread] %-5level %logger - %msg%n"></pattern> + </layout> ... -</appender></pre> - - </div> +</appender> + + SMTPAppender is known to work well with <a + href="manual/layouts.html#ClassicPatternLayout">PatternLayout</a> + and <a + href="manual/layouts.html#ClassicHTMLLayout">HTMLLayout</a>. + + + + <hr /> + + + <a name="sbtp_size_format" href="#sbtp_size_format">Specified number is not in proper + int form, or not expected format. + </a> + + + When you specify the MaxFileSize to be used by the + SizeBasedRollingPolicy, logback expects a rather precise + format: + + + <ul> + <li>The number has to be an integer</li> + <li>You can add 'KB', 'MB' or 'GB' after the number. + </li> + </ul> - You can see more examples in the - <a href="http://logback.qos.ch/apidocs/ch/qos/logback/classic/html/HTMLLayout.html"> - HTMLLayout javadoc - </a> and the - <a href="http://logback.qos.ch/apidocs/ch/qos/logback/classic/PatternLayout.html"> - PatternLayout javadoc - </a> - - - <table border="0"> - <tr> - <td align="right"> - <a href="#top">[top]</a> - </td> - </tr> - </table> - <hr /> - - - </dd> - <dt> - <a name="sbtp_size_format">Specified number is not in proper - int form, or not expected format. + Here are some correct values: 500KB, 15MB, 2GB. + + <hr /> + + <a name="rfa_no_tp" href="#rfa_no_tp">No <code>TriggeringPolicy</code> was set for + the <code>RollingFileAppender</code>. + </a> + + + The <code>RollingFileAppender</code> must be set up with a + <code>TriggeringPolicy</code>. It permits the Appender to know when + the rollover must be activated. + + + To find more information about <code>TriggeringPolicy</code> + objects, please read the following javadocs: + + + <ul> + <li> + <a + href="http://logback.qos.ch/apidocs/ch/qos/logback/core/rolling/SizeBasedTriggeri…"><code>SizeBasedTriggeringPolicy</code> </a> - </dt> - - <dd> - When you specify the MaxFileSize to be used by the - SizeBasedRollingPolicy, logback expects a rather precise - format: - - - <ul> - <li>The number has to be an integer</li> - <li>You can add 'KB', 'MB' or 'GB' after the number. - </li> - </ul> - - Here are some correct values: 500KB, 15MB, 2GB. - - <table border="0"> - <tr> - <td align="right"> - <a href="#top">[top]</a> - </td> - </tr> - </table> - <hr /> - - </dd> - <dt> - <a name="rfa_no_tp">No <code>TriggeringPolicy</code> was set - for the <code>RollingFileAppender</code>. + </li> + <li> + <a + href="http://logback.qos.ch/apidocs/ch/qos/logback/core/rolling/TimeBasedRollingP…"><code>TimeBasedRollingPolicy</code> </a> - </dt> + </li> + </ul> + + Please note that the <code>TimeBasedRollingPolicy</code> + is a TriggeringPolicy and and + <code>RollingPolicy</code> at the same time. + + + <hr /> + + + + <a name="rfa_no_rp" href="#rfa_no_rp">No <code>RollingPolicy</code> was set + for the <code>RollingFileAppender</code>. + </a> + + + The <code>RollingFileAppender</code> must be set up with + a <code>RollingPolicy</code>. It permits the Appender to + know what to do when a rollover is requested. + + + To find more information about <code>RollingPolicy</code> + objects, please read the following javadocs: + - <dd> - The <code>RollingFileAppender</code> must be set up with a - <code>TriggeringPolicy</code>. It permits the Appender to know - when the rollover must be activated. - - - To find more information about <code>TriggeringPolicy</code> - objects, please read the following javadocs: - - - <ul> - <li> - <a - href="http://logback.qos.ch/apidocs/ch/qos/logback/core/rolling/SizeBasedTriggeri…"><code>SizeBasedTriggeringPolicy</code> - </a> - </li> - <li> - <a - href="http://logback.qos.ch/apidocs/ch/qos/logback/core/rolling/TimeBasedRollingP…"><code>TimeBasedRollingPolicy</code> - </a> - </li> - </ul> - - Please note that the <code>TimeBasedRollingPolicy</code> - is a TriggeringPolicy and and - <code>RollingPolicy</code> at the same time. - - - - <table border="0"> - <tr> - <td align="right"> - <a href="#top">[top]</a> - </td> - </tr> - </table> - <hr /> - - </dd> - <dt> - <a name="rfa_no_rp">No <code>RollingPolicy</code> was set - for the <code>RollingFileAppender</code>. + <ul> + <li> + <a href="http://logback.qos.ch/apidocs/ch/qos/logback/core/rolling/FixedWindowRollin…"> + <code>FixedWindowRollingPolicy</code> </a> - </dt> - - <dd> - The <code>RollingFileAppender</code> must be set up with - a <code>RollingPolicy</code>. It permits the Appender to - know what to do when a rollover is requested. - - - To find more information about <code>RollingPolicy</code> - objects, please read the following javadocs: - - - <ul> - <li> - <a href="http://logback.qos.ch/apidocs/ch/qos/logback/core/rolling/FixedWindowRollin…"> - <code>FixedWindowRollingPolicy</code> - </a> - </li> - <li> - <a href="http://logback.qos.ch/apidocs/ch/qos/logback/core/rolling/TimeBasedRollingP…"> - <code>TimeBasedRollingPolicy</code> - </a> - </li> - </ul> - - Please note that the <code>TimeBasedRollingPolicy</code> is a - <code>TriggeringPolicy</code> and and RollingPolicy at - the same time. - - - - <table border="0"> - <tr> - <td align="right"> - <a href="#top">[top]</a> - </td> - </tr> - </table> - - </dd> + </li> + <li> + <a href="http://logback.qos.ch/apidocs/ch/qos/logback/core/rolling/TimeBasedRollingP…"> + <code>TimeBasedRollingPolicy</code> + </a> + </li> + </ul> + + Please note that the <code>TimeBasedRollingPolicy</code> is a + <code>TriggeringPolicy</code> and and RollingPolicy at + the same time. + + + + <hr/> + + + <a name="syslog_layout" href="#syslog_layout"> SyslogAppender + does not admit a layout parameter.</a> + - - - - </dl> + Given that the format of a syslog request follows strict rules, + you cannot freely specify the layout to be used with + SyslogAppender. However, you can use SuffixPattern option instead to influence the + contents of the message sent to the syslog daemon. + + + For more information on SyslogAppeder please refer to the <a + href="manual/appenders.html#SyslogAppender">its documentation.</a> + + <hr/> + + <script src="templates/footer.js"></script> </div> </body> Modified: logback/trunk/logback-site/src/site/pages/manual/appenders.html ============================================================================== --- logback/trunk/logback-site/src/site/pages/manual/appenders.html (original) +++ logback/trunk/logback-site/src/site/pages/manual/appenders.html Thu Apr 17 16:52:22 2008 @@ -2707,9 +2707,12 @@ The gain is a 10 factor. - <a name="SyslogAppender"></a> - <h3>SyslogAppender</h3> - + <h3> + <a name="SyslogAppender" href="#SyslogAppender"> + SyslogAppender + </a> + </h3> + The syslog protocol is a very simple protocol: a syslog sender sends a small message to a syslog receiver. @@ -2718,9 +2721,7 @@ <a href="../xref/ch/qos/logback/classic/net/SyslogAppender.html"><code>SyslogAppender</code></a>. - - Here are its options: - + Here are the options upi can pass to a SyslogAppender. <table class="bodyTable"> <tr class="a"> @@ -2777,21 +2778,22 @@ </td> </tr> - <tr class="a"> - <td> - - SuffixPattern - + <tr class="a"> + <td> + + SuffixPattern + </td> <td> <code>String</code> </td> <td> - - The SuffixPattern option specifies the format of the - non-standardized part the message sent to the syslog server. By default, its value - is [%thread] %logger %msg %exception. Any value that a <code>PatternLayout</code> - could use is a correct SuffixPattern. + The SuffixPattern option + specifies the format of the non-standardized part the + message sent to the syslog server. By default, its value is + [%thread] %logger %msg. Any value that a + <code>PatternLayout</code> could use is a correct SuffixPattern value. </td> </tr> @@ -2822,7 +2824,7 @@ class="ch.qos.logback.classic.net.SyslogAppender"> <SyslogHost>remote_home</SyslogHost> <Facility>AUTH</Facility> - <SuffixPattern>%-4relative [%thread] %-5level - %msg</SuffixPattern> + <SuffixPattern>[%thread] %logger %msg</SuffixPattern> </appender> <root> @@ -2831,21 +2833,21 @@ </root> </configuration></pre></div> - - When testing this configuration, one should verify that the remote syslog daemon - accepts requests from an external source. Experience shows that syslog daemons - usually deny such requests by default. + When testing this configuration, you should verify that the + remote syslog daemon accepts requests from an external + source. Experience shows that, by default, syslog daemons usually + deny requests coming via a network connection. <a name="Access"></a> <h2>Logback Access</h2> - - Most of the appenders found in logback classic can be used within - logback access. They function mostly in the same way as their logback - classic counterpart. In the next section, we will cover their use, but will - focuse on the differences with the classic appenders. + Most of the appenders found in logback classic can be used + within logback access. They function mostly in the same way as + their logback classic counterpart. In the next section, we will + cover their use, but will focuse on the differences with the + classic appenders. <a name="AccessSocketAppender"/>

1 0

svn commit: r1674 - logback/trunk
by noreply.ceki＠qos.ch 17 Apr '08

17 Apr '08

Author: ceki Date: Thu Apr 17 16:49:19 2008 New Revision: 1674 Modified: logback/trunk/pom.xml Log: - latest consolePlugin is at 1.1.0 Modified: logback/trunk/pom.xml ============================================================================== --- logback/trunk/pom.xml (original) +++ logback/trunk/pom.xml Thu Apr 17 16:49:19 2008 @@ -37,7 +37,7 @@ <properties>  <slf4j.version>1.5.0</slf4j.version> - <consolePlugin.version>1.0.1</consolePlugin.version> + <consolePlugin.version>1.1.0</consolePlugin.version> <retrotranslator.verify>false</retrotranslator.verify> </properties>

1 0