November 2009 - logback-dev

branch, master, updated. 0908ef4dc8bebd0c8f38dbdd4c2d0282a01d77fb
by git-noreply＠pixie.qos.ch 28 Nov '09

28 Nov '09

The branch, master has been updated via 0908ef4dc8bebd0c8f38dbdd4c2d0282a01d77fb (commit) from 843489d8a2aefa978f32c6ad9b9ed1596ec113c8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=0908ef4dc8bebd0c8f38dbdd… http://github.com/ceki/logback/commit/0908ef4dc8bebd0c8f38dbdd4c2d0282a01d7… commit 0908ef4dc8bebd0c8f38dbdd4c2d0282a01d77fb Author: Ceki Gulcu <ceki(a)qos.ch> Date: Sat Nov 28 23:36:03 2009 +0100 - Partial fix to LBGENERAL-35 diff --git a/logback-core/src/main/java/ch/qos/logback/core/rolling/DefaultTimeBasedFileNamingAndTriggeringPolicy.java b/logback-core/src/main/java/ch/qos/logback/core/rolling/DefaultTimeBasedFileNamingAndTriggeringPolicy.java index 6ad9bd7..ef19d9d 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/rolling/DefaultTimeBasedFileNamingAndTriggeringPolicy.java +++ b/logback-core/src/main/java/ch/qos/logback/core/rolling/DefaultTimeBasedFileNamingAndTriggeringPolicy.java @@ -32,6 +32,7 @@ public class DefaultTimeBasedFileNamingAndTriggeringPolicy<E> extends TimeBasedF public void start() { super.start(); archiveRemover = new DefaultArchiveRemover(tbrp.fileNamePattern, rc); + archiveRemover.setContext(context); started = true; } diff --git a/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/ArchiveRemover.java b/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/ArchiveRemover.java index 53cf5f7..a8b5c10 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/ArchiveRemover.java +++ b/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/ArchiveRemover.java @@ -15,12 +15,14 @@ package ch.qos.logback.core.rolling.helper; import java.util.Date; +import ch.qos.logback.core.spi.ContextAware; + /** * Given a date remove older archived log files. * * @author Ceki Gülcü */ -public interface ArchiveRemover { +public interface ArchiveRemover extends ContextAware { public void clean(Date now); public void setMaxHistory(int maxHistory); } \ No newline at end of file diff --git a/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/DefaultArchiveRemover.java b/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/DefaultArchiveRemover.java index c18b53c..32e7e56 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/DefaultArchiveRemover.java +++ b/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/DefaultArchiveRemover.java @@ -18,8 +18,10 @@ import java.util.Date; import ch.qos.logback.core.pattern.Converter; import ch.qos.logback.core.pattern.LiteralConverter; +import ch.qos.logback.core.spi.ContextAwareBase; -public class DefaultArchiveRemover implements ArchiveRemover { +public class DefaultArchiveRemover extends ContextAwareBase implements + ArchiveRemover { final FileNamePattern fileNamePattern; final RollingCalendar rc; @@ -36,32 +38,33 @@ public class DefaultArchiveRemover implements ArchiveRemover { boolean computeParentCleaningFlag(FileNamePattern fileNamePattern) { DateTokenConverter dtc = fileNamePattern.getDateTokenConverter(); // if the date pattern has a /, then we need parent cleaning - if(dtc.getDatePattern().indexOf('/') != -1) { + if (dtc.getDatePattern().indexOf('/') != -1) { return true; } - // if the literal string subsequent to the dtc contains a /, we also need + // if the literal string subsequent to the dtc contains a /, we also + // need // parent cleaning - + Converter<Object> p = fileNamePattern.headTokenConverter; - + // find the date converter - while(p != null) { - if(p instanceof DateTokenConverter) { + while (p != null) { + if (p instanceof DateTokenConverter) { break; } p = p.getNext(); } - - while(p != null) { - if(p instanceof LiteralConverter) { + + while (p != null) { + if (p instanceof LiteralConverter) { String s = p.convert(null); - if(s.indexOf('/') != -1) { + if (s.indexOf('/') != -1) { return true; } } p = p.getNext(); } - + // no /, so we don't need parent cleaning return false; } @@ -72,6 +75,7 @@ public class DefaultArchiveRemover implements ArchiveRemover { File file2Delete = new File(filename); if (file2Delete.exists() && file2Delete.isFile()) { file2Delete.delete(); + addInfo("deleting " + file2Delete); if (parentClean) { removeFolderIfEmpty(file2Delete.getParentFile(), 0); } @@ -92,6 +96,7 @@ public class DefaultArchiveRemover implements ArchiveRemover { return; } if (dir.isDirectory() && FileFilterUtil.isEmptyDirectory(dir)) { + addInfo("deleting folder [" + dir +"]"); dir.delete(); removeFolderIfEmpty(dir.getParentFile(), recursivityCount + 1); } diff --git a/logback-core/src/test/java/ch/qos/logback/core/rolling/TimeBasedRollingWithArchiveRemovalTest.java b/logback-core/src/test/java/ch/qos/logback/core/rolling/TimeBasedRollingWithArchiveRemovalTest.java index 4d1d697..2d3dcd4 100644 --- a/logback-core/src/test/java/ch/qos/logback/core/rolling/TimeBasedRollingWithArchiveRemovalTest.java +++ b/logback-core/src/test/java/ch/qos/logback/core/rolling/TimeBasedRollingWithArchiveRemovalTest.java @@ -35,6 +35,7 @@ import ch.qos.logback.core.ContextBase; import ch.qos.logback.core.layout.EchoLayout; import ch.qos.logback.core.testUtil.RandomUtil; import ch.qos.logback.core.util.CoreTestConstants; +import ch.qos.logback.core.util.StatusPrinter; public class TimeBasedRollingWithArchiveRemovalTest { @@ -109,6 +110,7 @@ public class TimeBasedRollingWithArchiveRemovalTest { + "}/clean.txt.zip", MILLIS_IN_MONTH, maxHistory, numPeriods); int beginPeriod = Calendar.getInstance().get(Calendar.MONTH); boolean extraFolder = extraFolder(numPeriods, 12, beginPeriod, maxHistory); + StatusPrinter.print(context); check(expectedCountWithFolders(2, extraFolder)); } @@ -279,7 +281,8 @@ public class TimeBasedRollingWithArchiveRemovalTest { // year is 2012, and not 2013 (the current year). boolean extraFolder(int numPeriods, int periodsPerEra, int beginPeriod, int maxHistory) { - int remainder = (beginPeriod + numPeriods) % periodsPerEra; + int adjustedBegin = beginPeriod+1; + int remainder = ((adjustedBegin) + numPeriods) % periodsPerEra; return (remainder < maxHistory + 1); } ----------------------------------------------------------------------- Summary of changes: ...aultTimeBasedFileNamingAndTriggeringPolicy.java | 1 + .../core/rolling/helper/ArchiveRemover.java | 4 ++- .../core/rolling/helper/DefaultArchiveRemover.java | 29 +++++++++++-------- .../TimeBasedRollingWithArchiveRemovalTest.java | 5 +++- 4 files changed, 25 insertions(+), 14 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

WriterAppender.subAppend behaviour in case of IOExceptions
by Syvalta 27 Nov '09

27 Nov '09

Hi, I noticed WriterAppender.subAppend stops appending if an IOException occurs during write. This is bit problematic if interruption is used as a cancellation mechanism (as suggested in JCiP). The problem is that if a thread happens to be logging at the time it is interrupted, logging (for that appender) will be ceased for the lifetime of the application (or until Logback is re-initialized). Additionally, if there are some transient errors, logging won't continue after recovery. At least it seems so, but I might be wrong. I could provide a patch which changes the behavior, but it seems changes are non-trivial. I would be glad to receive some advice. - how backward compatible the changes should be? Can I remove methods, add abstract methods etc. or should backward compatibility be preserved (and if it is, does that increase the likelihood of the patch being applied)? - in what level at hierarchy this should be done? I have thought at WriterAppender, but that would require adding a method to create OutputStream, which subclasses would implement. Currently subclasses set writer to WriterAppender, so this would change it to the opposite. Another option would be to do it at FileAppender level, but I haven't investigated that option much yet. - should there be some "throttling", so that under persistent error state new outputstream would not be tried to be created in every logging call. I think so, perhaps some condition like "try in first 10 calls, but after that only every 30 sec). - should the log events be buffered under presence of error (of course limited amount with fifo or something)? - is there any chance that this kind of patch would be accepted? Do you see this kind of feature useful? Hope you understand at least something from my post, I admit it is "bit" unclear :) -- View this message in context: http://www.nabble.com/WriterAppender.subAppend-behaviour-in-case-of-IOExcep… Sent from the Logback Dev mailing list archive at Nabble.com.

2 2

branch, master, updated. 843489d8a2aefa978f32c6ad9b9ed1596ec113c8
by git-noreply＠pixie.qos.ch 25 Nov '09

25 Nov '09

The branch, master has been updated via 843489d8a2aefa978f32c6ad9b9ed1596ec113c8 (commit) from a0e45a889c6180b29f853348ccbdf2eacca1bb55 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=843489d8a2aefa978f32c6ad… http://github.com/ceki/logback/commit/843489d8a2aefa978f32c6ad9b9ed1596ec11… commit 843489d8a2aefa978f32c6ad9b9ed1596ec113c8 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Wed Nov 25 22:00:11 2009 +0100 - fixed LBCLASSIC-121 by applying Hugues' patch provided in LBCLASSIC-168. diff --git a/logback-classic/pom.xml b/logback-classic/pom.xml index b460fb3..286d0e6 100644 --- a/logback-classic/pom.xml +++ b/logback-classic/pom.xml @@ -215,7 +215,7 @@ of java code. --> <Import-Package> - sun.reflect;resolution:=optional, javax.jms;resolution:=optional, + sun.reflect;resolution:=optional, javax.*;resolution:=optional, ch.qos.logback.core.rolling, ch.qos.logback.core.rolling.helper, * </Import-Package> diff --git a/logback-site/src/site/pages/news.html b/logback-site/src/site/pages/news.html index 95af9a3..9d0d4a2 100644 --- a/logback-site/src/site/pages/news.html +++ b/logback-site/src/site/pages/news.html @@ -39,7 +39,9 @@ <p>Fixed Private-Package and Export-Package sections in logback-classic.jar MANIFEST as reported in <a href="http://jira.qos.ch/browse/LBCLASSIC-165">LBCLASSIC-165</a> - by applying the relavant patch supplied by Hugues Malphettes. + and <a + href="http://jira.qos.ch/browse/LBCLASSIC-121">LBCLASSIC-121</a> + by applying the relavant patches supplied by Hugues Malphettes. </p> <p>Made the OSGi import declerations for Janino and javax optional ----------------------------------------------------------------------- Summary of changes: logback-classic/pom.xml | 2 +- logback-site/src/site/pages/news.html | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[JIRA] Created: (LBCLASSIC-121) Make some of the Import-Package declarations in logback-classic OSGi bundle optional
by Pavol Juhos (JIRA) 25 Nov '09

25 Nov '09

Make some of the Import-Package declarations in logback-classic OSGi bundle optional ------------------------------------------------------------------------------------ Key: LBCLASSIC-121 URL: http://jira.qos.ch/browse/LBCLASSIC-121 Project: logback-classic Issue Type: Improvement Components: Other Affects Versions: 0.9.15 Environment: OSGi Service Platform Release 4 Reporter: Pavol Juhos Assignee: Logback dev list Priority: Minor It might be a good idea to mark some additional packages imported by logback-classis bundle as optional. Namely this applies to packages javax.servlet, javax.servlet.http, javax.management By importing package javax.servlet you are forcing the users to deploy Sevlet API bundle even in non-web application environment. The current <Import-Package> declaration in maven-bundle-plugin configuration: <Import-Package>sun.reflect;resolution:=optional, javax.jms;resolution:=optional, * </Import-Package> Suggested update: <Import-Package>sun.reflect;resolution:=optional, javax.jms;resolution:=optional, javax.servlet.*;resolution:=optional, javax.management;resolution:=optional, * </Import-Package> Feel free to close this as invalid if the above mentioned packages are _always_ required for correct operation of logback-classic. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

3 3

[JIRA] Created: (LBCLASSIC-168) for OSGi make javax.* imports optional to support using logback-classic without requiring javax.servlet and other jars to be present
by Hugues Malphettes (JIRA) 25 Nov '09

25 Nov '09

for OSGi make javax.* imports optional to support using logback-classic without requiring javax.servlet and other jars to be present ------------------------------------------------------------------------------------------------------------------------------------ Key: LBCLASSIC-168 URL: http://jira.qos.ch/browse/LBCLASSIC-168 Project: logback-classic Issue Type: Improvement Components: Other Affects Versions: 0.917 Reporter: Hugues Malphettes Assignee: Logback dev list This improvement is related to http://jira.qos.ch/browse/LBCLASSIC-165 When prototyping some OSGi tweaks to slf4j I discovered that logback-classic once patched with LBCLASSIC-165 requires a couple of bundles that should be optional These bundles are present when executing jetty-osgi but not in a minimal environment. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 5

[JIRA] Created: (LBCLASSIC-151) Export-Package: org.slf4j.impl; version="1.5.6" but 1.5.8 required
by Bulat Nigmatullin (JIRA) 18 Nov '09

18 Nov '09

Export-Package: org.slf4j.impl;version="1.5.6" but 1.5.8 required ----------------------------------------------------------------- Key: LBCLASSIC-151 URL: http://jira.qos.ch/browse/LBCLASSIC-151 Project: logback-classic Issue Type: Bug Affects Versions: 0.917 Reporter: Bulat Nigmatullin Assignee: Logback dev list Priority: Minor In pom.xml you says <properties> −  <slf4j.version>1.5.8</slf4j.version> <consolePlugin.version>1.1.0</consolePlugin.version> </properties> but in MANIFEST.MF exported org.slf4j.impl version 1.5.6. Please, fix version in MANIFEST.MF and upload it to Maven repository. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 2

[JIRA] Created: (LBCLASSIC-108) LOGBack Classic Bundle does not declare ch.qos.logback.core.rolling as Import-Package
by Christian Brensing (JIRA) 18 Nov '09

18 Nov '09

LOGBack Classic Bundle does not declare ch.qos.logback.core.rolling as Import-Package ------------------------------------------------------------------------------------- Key: LBCLASSIC-108 URL: http://jira.qos.ch/browse/LBCLASSIC-108 Project: logback-classic Issue Type: Bug Components: Other Affects Versions: 0.9.15 Reporter: Christian Brensing Assignee: Logback dev list Priority: Minor The LOGBack Classic Bundle has no Import-Package for ch.qos.logback.core.rolling (and rolling.helper), resulting in a ClassNotFoundException when using e.g. the RollingFileAppender from the Core-Bundle. The ClassNotFoundException will be raised because the Bundle which initializes the LoggerContext (Classic) can not load the Appender from the Core-Bundle. The Bnd-Tool by Peter Kriens and the Maven-Felix-Plugin only detects package dependencies that are imported in java classes. Runtime dependencies like Appenders must be explicitly configured in the bnd-file or pom. This issue is identically to the one I reported for the SpringSource-Bundle-Repository, see https://issuetracker.springsource.com/browse/BRITS-165. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 2

branch, master, updated. a0e45a889c6180b29f853348ccbdf2eacca1bb55
by git-noreply＠pixie.qos.ch 13 Nov '09

13 Nov '09

The branch, master has been updated via a0e45a889c6180b29f853348ccbdf2eacca1bb55 (commit) from bfb1e735c93af7672bb96511c68ac1a379f6eadc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=a0e45a889c6180b29f853348… http://github.com/ceki/logback/commit/a0e45a889c6180b29f853348ccbdf2eacca1b… commit a0e45a889c6180b29f853348ccbdf2eacca1bb55 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Fri Nov 13 14:06:02 2009 +0100 - corrections in grouping code diff --git a/logback-core/src/test/java/ch/qos/logback/core/rolling/TimeBasedRollingWithArchiveRemovalTest.java b/logback-core/src/test/java/ch/qos/logback/core/rolling/TimeBasedRollingWithArchiveRemovalTest.java index 2e2e27a..4d1d697 100644 --- a/logback-core/src/test/java/ch/qos/logback/core/rolling/TimeBasedRollingWithArchiveRemovalTest.java +++ b/logback-core/src/test/java/ch/qos/logback/core/rolling/TimeBasedRollingWithArchiveRemovalTest.java @@ -148,7 +148,7 @@ public class TimeBasedRollingWithArchiveRemovalTest { // rollover occurs on the last period, that the last period is still accounted // for checkPatternCompliance(5 + 1 + slashCount, - "\\d{4}-\\d{2}-\\d{2}-clean.(\\d)(.zip)?"); + "\\d{4}-\\d{2}-\\d{2}-clean(\\.\\d)(.zip)?"); } @Test @@ -332,8 +332,9 @@ public class TimeBasedRollingWithArchiveRemovalTest { } // reduce file names differing by index number into the same group - // for example, 2009-11-01-clean-0.zip, 2009-11-01-clean-1.zip and + // for example, 2009-11-01-clean.0.zip, 2009-11-01-clean.1.zip and // 2009-11-01-clean-2 are reduced into the same string (group) + // 2009-11-01-clean Set<String> groupByClass(List<File> fileList, String regex) { Pattern p = Pattern.compile(regex); Set<String> set = new HashSet<String>(); @@ -342,10 +343,10 @@ public class TimeBasedRollingWithArchiveRemovalTest { Matcher m = p.matcher(n); m.matches(); int begin = m.start(1); - int end = m.end(1); - String reduced = n.substring(0, begin) + n.substring(end); + String reduced = n.substring(0, begin); set.add(reduced); } + System.out.println(set); return set; } ----------------------------------------------------------------------- Summary of changes: .../TimeBasedRollingWithArchiveRemovalTest.java | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[JIRA] Created: (LBCLASSIC-149) ContextNameConverter does not use the context of the event
by Ceki Gulcu (JIRA) 13 Nov '09

13 Nov '09

ContextNameConverter does not use the context of the event ---------------------------------------------------------- Key: LBCLASSIC-149 URL: http://jira.qos.ch/browse/LBCLASSIC-149 Project: logback-classic Issue Type: Bug Reporter: Ceki Gulcu Assignee: Logback dev list ContextNameConverter instead of reading the context name found in the event passed as parameter, uses the context to which it (the ContextNameConverter instance) is attached to. Usually the two contexts are the same. However, when an event is sent to a remote server, the wrong information is displayed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 1

branch, master, updated. bfb1e735c93af7672bb96511c68ac1a379f6eadc
by git-noreply＠pixie.qos.ch 13 Nov '09

13 Nov '09

The branch, master has been updated via bfb1e735c93af7672bb96511c68ac1a379f6eadc (commit) from feba37d06ec4fc8398641b3056f32e1afdcb0bb4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=bfb1e735c93af7672bb96511… http://github.com/ceki/logback/commit/bfb1e735c93af7672bb96511c68ac1a379f6e… commit bfb1e735c93af7672bb96511c68ac1a379f6eadc Author: Ceki Gulcu <ceki(a)qos.ch> Date: Fri Nov 13 10:59:50 2009 +0100 Fixed http://jira.qos.ch/browse/LBCLASSIC-149 diff --git a/logback-classic/src/main/java/ch/qos/logback/classic/pattern/ContextNameConverter.java b/logback-classic/src/main/java/ch/qos/logback/classic/pattern/ContextNameConverter.java index 56bfe15..29a3d29 100644 --- a/logback-classic/src/main/java/ch/qos/logback/classic/pattern/ContextNameConverter.java +++ b/logback-classic/src/main/java/ch/qos/logback/classic/pattern/ContextNameConverter.java @@ -26,7 +26,7 @@ public class ContextNameConverter extends ClassicConverter { * Return the name of the logger context's name. */ public String convert(ILoggingEvent event) { - return getContext().getName(); + return event.getLoggerContextVO().getName(); } } diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/pattern/ConverterTest.java b/logback-classic/src/test/java/ch/qos/logback/classic/pattern/ConverterTest.java index c1ff3b5..c4c5b3b 100644 --- a/logback-classic/src/test/java/ch/qos/logback/classic/pattern/ConverterTest.java +++ b/logback-classic/src/test/java/ch/qos/logback/classic/pattern/ConverterTest.java @@ -356,7 +356,11 @@ public class ConverterTest { @Test public void contextNameConverter() { ClassicConverter converter = new ContextNameConverter(); - converter.setContext(lc); + // see http://jira.qos.ch/browse/LBCLASSIC-149 + LoggerContext lcOther = new LoggerContext(); + lcOther.setName("another"); + converter.setContext(lcOther); + lc.setName("aValue"); ILoggingEvent event = makeLoggingEvent(null); diff --git a/logback-site/src/site/pages/news.html b/logback-site/src/site/pages/news.html index 953aabe..95af9a3 100644 --- a/logback-site/src/site/pages/news.html +++ b/logback-site/src/site/pages/news.html @@ -63,6 +63,12 @@ showed that this was an appropriate strategy in all the cases we considered.</p> + <p>Fixed <a + href="http://jira.qos.ch/browse/LBCLASSIC-149">LBCLASSIC-149</a>. The + ContextNameConverter now correctly uses the context name of the + event instead of its own context name. + </p> + <hr width="80%" align="center" /> <h3>9th of August 2009 - Release of version 0.9.17</h3> ----------------------------------------------------------------------- Summary of changes: .../classic/pattern/ContextNameConverter.java | 2 +- .../qos/logback/classic/pattern/ConverterTest.java | 6 +++++- logback-site/src/site/pages/news.html | 6 ++++++ 3 files changed, 12 insertions(+), 2 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0