February 2009 - logback-dev

svn commit: r2169 - in logback/trunk/logback-classic/src: main/java/ch/qos/logback/classic test/java/ch/qos/logback/classic
by noreply.ceki＠qos.ch 24 Feb '09

24 Feb '09

Author: ceki Date: Tue Feb 24 10:40:17 2009 New Revision: 2169 Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/Logger.java logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/LoggerContextTest.java Log: Fixing problem by the fact that the localLevelReset() method in the Logger class inadvertently uses the DEBUG_INT value in the org.slf4j.spi.LocationAwareLogger interface instead of the DEBUG_INT value in ch.qos.logback.classic.Level class. The issue was first identified by Andy Ruch in a message to the logback-user list http://qos.ch/pipermail/logback-user/2009-February/000955.html Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/Logger.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/Logger.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/Logger.java Tue Feb 24 10:40:17 2009 @@ -153,13 +153,13 @@ // nothing to do; return; } + if(newLevel == null && isRootLogger()) { + throw new IllegalArgumentException("The level of the root logger cannot be set to null"); + } + level = newLevel; if (newLevel == null) { - if (isRootLogger()) { - throw new IllegalArgumentException("The level of the root logger cannot be set to null"); - } else { - effectiveLevelInt = parent.effectiveLevelInt; - } + effectiveLevelInt = parent.effectiveLevelInt; } else { effectiveLevelInt = newLevel.levelInt; } @@ -322,7 +322,7 @@ } private void localLevelReset() { - effectiveLevelInt = DEBUG_INT; + effectiveLevelInt = Level.DEBUG_INT; if(isRootLogger()) { level = Level.DEBUG; } else { Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/LoggerContextTest.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/LoggerContextTest.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/LoggerContextTest.java Tue Feb 24 10:40:17 2009 @@ -170,6 +170,7 @@ root.setLevel(Level.INFO); lc.reset(); assertEquals(Level.DEBUG, root.getEffectiveLevel()); + assertTrue(root.isDebugEnabled()); assertEquals(Level.DEBUG, a.getEffectiveLevel()); assertEquals(Level.DEBUG, ab.getEffectiveLevel()); @@ -188,4 +189,15 @@ lc.reset(); assertFalse(nopTF.isStarted()); } + + @Test + public void levelResetTest() { + Logger root = lc.getLogger(LoggerContext.ROOT_NAME); + root.setLevel(Level.TRACE); + assertTrue(root.isTraceEnabled()); + lc.reset(); + assertFalse(root.isTraceEnabled()); + assertTrue(root.isDebugEnabled()); + } + } \ No newline at end of file

1 0

[JIRA] Commented: (LBCLASSIC-22) feature request: XMLLayout (cfr. log4j)
by Thorbjoern Ravn Andersen (JIRA) 16 Feb '09

16 Feb '09

[ http://jira.qos.ch/browse/LBCLASSIC-22?page=com.atlassian.jira.plugin.syste… ] Thorbjoern Ravn Andersen commented on LBCLASSIC-22: --------------------------------------------------- I stand corrected. I did not look further back than the version included with 1.2.15. The XML fragments generated with my XMLLayout will not validate against older versions of log4j.dtd and is therefore not compliant. > feature request: XMLLayout (cfr. log4j) > --------------------------------------- > > Key: LBCLASSIC-22 > URL: http://jira.qos.ch/browse/LBCLASSIC-22 > Project: logback-classic > Issue Type: Improvement > Components: Other > Affects Versions: unspecified > Environment: Operating System: Linux > Platform: PC > Reporter: dirk > Assignee: Ceki Gulcu > Priority: Minor > Fix For: 0.9.15 > > Attachments: XMLLayout.jar, XMLLayout.java > > > see Summary -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Commented: (LBCLASSIC-22) feature request: XMLLayout (cfr. log4j)
by Ceki Gulcu (JIRA) 16 Feb '09

16 Feb '09

[ http://jira.qos.ch/browse/LBCLASSIC-22?page=com.atlassian.jira.plugin.syste… ] Ceki Gulcu commented on LBCLASSIC-22: ------------------------------------- The log4j.dtd in log4j version 1.2.14 reads: <!ATTLIST log4j:event logger CDATA #REQUIRED level CDATA #REQUIRED thread CDATA #REQUIRED timestamp CDATA #REQUIRED > Thus, my previous remark is still valid. The timestamp attribute is *not* part of log4j.dtd in log4j 1.2.14 and earlier, I don't think we can just add unexpected attributes to a given element and still be DTD compliant. How about adding a comment which includes the date? A comment will satisfy the human reader without affecting DTD compliance. > feature request: XMLLayout (cfr. log4j) > --------------------------------------- > > Key: LBCLASSIC-22 > URL: http://jira.qos.ch/browse/LBCLASSIC-22 > Project: logback-classic > Issue Type: Improvement > Components: Other > Affects Versions: unspecified > Environment: Operating System: Linux > Platform: PC > Reporter: dirk > Assignee: Ceki Gulcu > Priority: Minor > Fix For: 0.9.15 > > Attachments: XMLLayout.jar, XMLLayout.java > > > see Summary -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

svn commit: r2159 - logbackPDE/trunk
by noreply.ceki＠qos.ch 16 Feb '09

16 Feb '09

Author: ceki Date: Mon Feb 16 18:49:25 2009 New Revision: 2159 Added: logbackPDE/trunk/.project Log: Tentatively adding .project file Added: logbackPDE/trunk/.project ============================================================================== --- (empty file) +++ logbackPDE/trunk/.project Mon Feb 16 18:49:25 2009 @@ -0,0 +1,11 @@ +<?xml version="1.0" encoding="UTF-8"?> +<projectDescription> + <name>LogbackPDE</name> + <comment></comment> + <projects> + </projects> + <buildSpec> + </buildSpec> + <natures> + </natures> +</projectDescription>

1 0

[JIRA] Commented: (LBCLASSIC-22) feature request: XMLLayout (cfr. log4j)
by Thorbjoern Ravn Andersen (JIRA) 16 Feb '09

16 Feb '09

[ http://jira.qos.ch/browse/LBCLASSIC-22?page=com.atlassian.jira.plugin.syste… ] Thorbjoern Ravn Andersen commented on LBCLASSIC-22: --------------------------------------------------- The log4j.dtd present in the log4j-1.2.15 distribution has this definition of log4j:event  <!ATTLIST log4j:event logger CDATA #REQUIRED level CDATA #REQUIRED thread CDATA #REQUIRED timestamp CDATA #REQUIRED time CDATA #IMPLIED > The XML specification states in 3.3.2 that "In an attribute declaration, #REQUIRED means that the attribute MUST always be provided, #IMPLIED that no default value is provided." (http://www.w3.org/TR/REC-xml/#sec-attr-defaults) > feature request: XMLLayout (cfr. log4j) > --------------------------------------- > > Key: LBCLASSIC-22 > URL: http://jira.qos.ch/browse/LBCLASSIC-22 > Project: logback-classic > Issue Type: Improvement > Components: Other > Affects Versions: unspecified > Environment: Operating System: Linux > Platform: PC > Reporter: dirk > Assignee: Ceki Gulcu > Priority: Minor > Fix For: 0.9.15 > > Attachments: XMLLayout.jar, XMLLayout.java > > > see Summary -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Commented: (LBCLASSIC-22) feature request: XMLLayout (cfr. log4j)
by Ceki Gulcu (JIRA) 16 Feb '09

16 Feb '09

[ http://jira.qos.ch/browse/LBCLASSIC-22?page=com.atlassian.jira.plugin.syste… ] Ceki Gulcu commented on LBCLASSIC-22: ------------------------------------- > 1) "generates humanly readable output" - the output is in a form that is readable to the human eye when browsing > the text file containing the output from the XMLLayout. This _INCLUDES_ the time attribute which contains a > humanly readable version of the timestamp, put in a location where it is useful in the situation where the human > needs to read the logfile. I took great care in putting the linefeeds in the right places while maintaining DTD > conformancy. The output generated by XMLLayout_Blue (blue for the version currently shipping in logback 0.9.16) also generates "humanly readable" output. The timestamp attribute is *not* part of log4j.dtd, at least not on any currently shipping version of log4j. I am not sure one can just add unexpected attributes to a given element and still be DTD compliant. How about adding a comment which includes the date? A comment will satisfy the human reader without affecting DTD compliance. > 2) Uses numeric XML entities instead of CDATA. In my experience this is more robust to data transports where the > encoding is broken - which we have more often than I like to think about here - as it keeps to 7-bit ascii, AND it is > better to the human reader as "<", ">" and "&" are only found in their proper form in tagnames and entities and not as > a CDATA stream. Also linefeeds etc are encoded as their numeric XML entity, resultning in each log event > generating exactly two lines of output (but can be very wide). We could add a 7-bit transport property (a boolean) to XMLLayout_Blue and if 7-bit transport property were set, your style of encoding would be used. > feature request: XMLLayout (cfr. log4j) > --------------------------------------- > > Key: LBCLASSIC-22 > URL: http://jira.qos.ch/browse/LBCLASSIC-22 > Project: logback-classic > Issue Type: Improvement > Components: Other > Affects Versions: unspecified > Environment: Operating System: Linux > Platform: PC > Reporter: dirk > Assignee: Ceki Gulcu > Priority: Minor > Fix For: 0.9.15 > > Attachments: XMLLayout.jar, XMLLayout.java > > > see Summary -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Commented: (LBCLASSIC-22) feature request: XMLLayout (cfr. log4j)
by Thorbjoern Ravn Andersen (JIRA) 16 Feb '09

16 Feb '09

[ http://jira.qos.ch/browse/LBCLASSIC-22?page=com.atlassian.jira.plugin.syste… ] Thorbjoern Ravn Andersen commented on LBCLASSIC-22: --------------------------------------------------- I am neither "pissed" nor "peeved", but I was quite astonished. I have found it to be due to the difference in our coding cultures and my subconcious expectations. So be it. There are two key functionalities: 1) "generates humanly readable output" - the output is in a form that is readable to the human eye when browsing the text file containing the output from the XMLLayout. This _INCLUDES_ the time attribute which contains a humanly readable version of the timestamp, put in a location where it is useful in the situation where the human needs to read the logfile. I took great care in putting the linefeeds in the right places while maintaining DTD conformancy. 2) Uses numeric XML entities instead of CDATA. In my experience this is more robust to data transports where the encoding is broken - which we have more often than I like to think about here - as it keeps to 7-bit ascii, AND it is better to the human reader as "<", ">" and "&" are only found in their proper form in tagnames and entities and not as a CDATA stream. Also linefeeds etc are encoded as their numeric XML entity, resultning in each log event generating exactly two lines of output (but can be very wide). The goal I am pursuing is to move from processed logs in flat text files (oh the joy of multi line log messages) into easily reprocessable log files in our production scenario. Hence a XMLLayout class which generates humanly readable output while being log4j DTD conformant so it can be processed with e.g. Chainsaw and hopefully soon Lilith. I understand your desire to be 100% compatible with log4j. I hope you understand my need for a different version which is compatible with the log4j DTD but does not generates 100% identical output. In XML there are many ways to say the same thing. > feature request: XMLLayout (cfr. log4j) > --------------------------------------- > > Key: LBCLASSIC-22 > URL: http://jira.qos.ch/browse/LBCLASSIC-22 > Project: logback-classic > Issue Type: Improvement > Components: Other > Affects Versions: unspecified > Environment: Operating System: Linux > Platform: PC > Reporter: dirk > Assignee: Ceki Gulcu > Priority: Minor > Fix For: 0.9.15 > > Attachments: XMLLayout.jar, XMLLayout.java > > > see Summary -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

svn commit: r2158 - in logback/trunk: . logback-access logback-classic logback-core logback-examples logback-site
by noreply.ceki＠qos.ch 16 Feb '09

16 Feb '09

Author: ceki Date: Mon Feb 16 11:59:41 2009 New Revision: 2158 Modified: logback/trunk/logback-access/pom.xml logback/trunk/logback-classic/pom.xml logback/trunk/logback-core/pom.xml logback/trunk/logback-examples/pom.xml logback/trunk/logback-site/pom.xml logback/trunk/pom.xml logback/trunk/version.pl Log: - starting work on 0.9.16 - to method to remove files is called "unlink" in perl Modified: logback/trunk/logback-access/pom.xml ============================================================================== --- logback/trunk/logback-access/pom.xml (original) +++ logback/trunk/logback-access/pom.xml Mon Feb 16 11:59:41 2009 @@ -5,7 +5,7 @@ <parent> <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>0.9.15</version> + <version>0.9.16-SNAPSHOT</version> </parent> <modelVersion>4.0.0</modelVersion> Modified: logback/trunk/logback-classic/pom.xml ============================================================================== --- logback/trunk/logback-classic/pom.xml (original) +++ logback/trunk/logback-classic/pom.xml Mon Feb 16 11:59:41 2009 @@ -5,7 +5,7 @@ <parent> <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>0.9.15</version> + <version>0.9.16-SNAPSHOT</version> </parent> <modelVersion>4.0.0</modelVersion> Modified: logback/trunk/logback-core/pom.xml ============================================================================== --- logback/trunk/logback-core/pom.xml (original) +++ logback/trunk/logback-core/pom.xml Mon Feb 16 11:59:41 2009 @@ -5,7 +5,7 @@ <parent> <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>0.9.15</version> + <version>0.9.16-SNAPSHOT</version> </parent> <modelVersion>4.0.0</modelVersion> Modified: logback/trunk/logback-examples/pom.xml ============================================================================== --- logback/trunk/logback-examples/pom.xml (original) +++ logback/trunk/logback-examples/pom.xml Mon Feb 16 11:59:41 2009 @@ -5,7 +5,7 @@ <parent> <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>0.9.15</version> + <version>0.9.16-SNAPSHOT</version> </parent> <modelVersion>4.0.0</modelVersion> Modified: logback/trunk/logback-site/pom.xml ============================================================================== --- logback/trunk/logback-site/pom.xml (original) +++ logback/trunk/logback-site/pom.xml Mon Feb 16 11:59:41 2009 @@ -3,7 +3,7 @@ <parent> <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>0.9.15</version> + <version>0.9.16-SNAPSHOT</version> </parent> <modelVersion>4.0.0</modelVersion> Modified: logback/trunk/pom.xml ============================================================================== --- logback/trunk/pom.xml (original) +++ logback/trunk/pom.xml Mon Feb 16 11:59:41 2009 @@ -5,7 +5,7 @@ <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>0.9.15</version> + <version>0.9.16-SNAPSHOT</version> <packaging>pom</packaging> <name>Logback-Parent</name> Modified: logback/trunk/version.pl ============================================================================== --- logback/trunk/version.pl (original) +++ logback/trunk/version.pl Mon Feb 16 11:59:41 2009 @@ -30,7 +30,7 @@ } close(IN); close(OUT); - remove($origFile); + unlink($origFile); } else { print "File [" . $filename . "] does not exist\r\n" }

1 0

svn commit: r2157 - logback/release_0.9.15
by noreply.ceki＠qos.ch 16 Feb '09

16 Feb '09

Author: ceki Date: Mon Feb 16 11:56:32 2009 New Revision: 2157 Added: logback/release_0.9.15/ - copied from r2156, /logback/trunk/ Log: tagging 0.9.15

1 0

svn commit: r2156 - logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/log4j
by noreply.ceki＠qos.ch 16 Feb '09

16 Feb '09

Author: ceki Date: Mon Feb 16 11:03:47 2009 New Revision: 2156 Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/log4j/XMLLayout.java Log: Removed Thorbjoern's name from the authors list at his request. Andersen Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/log4j/XMLLayout.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/log4j/XMLLayout.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/log4j/XMLLayout.java Mon Feb 16 11:03:47 2009 @@ -30,7 +30,6 @@ * * * @author Ceki Gülcü - * @author Thorbj�rn Ravn Andersen */ public class XMLLayout extends LayoutBase<LoggingEvent> {

1 0