October 2010 - logback-dev - mailman3.qos.ch

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. v_0.9.25-12-g358ca5f
by git-noreply＠pixie.qos.ch 20 Oct '10

20 Oct '10

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via 358ca5f91a5deae9bde0a8ef34bc39d682d6b346 (commit) from 31c713847189d2dc19cc51ce43f727e8ed58b917 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=358ca5f91a5deae9bde0a8ef… http://github.com/ceki/logback/commit/358ca5f91a5deae9bde0a8ef34bc39d682d6b… commit 358ca5f91a5deae9bde0a8ef34bc39d682d6b346 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Tue Oct 19 23:42:10 2010 +0200 minor refactoring diff --git a/logback-core/src/main/java/ch/qos/logback/core/status/OnConsoleStatusListener.java b/logback-core/src/main/java/ch/qos/logback/core/status/OnConsoleStatusListener.java index 332dcad..1547313 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/status/OnConsoleStatusListener.java +++ b/logback-core/src/main/java/ch/qos/logback/core/status/OnConsoleStatusListener.java @@ -27,8 +27,9 @@ import java.util.List; public class OnConsoleStatusListener extends ContextAwareBase implements StatusListener, LifeCycle { + static final long DEFAULT_RESTROSPECTIVE = 300; boolean isStarted = false; - long retrospective = 300; + long retrospective = DEFAULT_RESTROSPECTIVE; private void print(Status status) { StringBuilder sb = new StringBuilder(); ----------------------------------------------------------------------- Summary of changes: .../core/status/OnConsoleStatusListener.java | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[JIRA] Created: (LBGENERAL-42) Lifecycle stop() method is never called
by Lieven Doclo (JIRA) 20 Oct '10

20 Oct '10

Lifecycle stop() method is never called --------------------------------------- Key: LBGENERAL-42 URL: http://jira.qos.ch/browse/LBGENERAL-42 Project: logback-general Issue Type: Bug Reporter: Lieven Doclo Assignee: Logback dev list Don't know whether this is intended behavior, but when for example an configuration is loaded, the Lifecycle start() method is called. However, when the VM exits, stop() is never called. So anything in there is never executed. I came across this when writing a Google Charts appender for Perf4J. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

3 3

[JIRA] Created: (LBCLASSIC-223) Two tests fail in latest commit 74915053db48b5e803816f8d39237cd85293273f
by Joern Huxhorn (JIRA) 19 Oct '10

19 Oct '10

Two tests fail in latest commit 74915053db48b5e803816f8d39237cd85293273f ------------------------------------------------------------------------ Key: LBCLASSIC-223 URL: http://jira.qos.ch/browse/LBCLASSIC-223 Project: logback-classic Issue Type: Bug Environment: Apache Maven 2.2.1 (r801777; 2009-08-06 21:16:01+0200) Java version: 1.6.0_20 Java home: /System/Library/Frameworks/JavaVM.framework/Versions/1.6.0/Home Default locale: en_US, platform encoding: MacRoman OS name: "mac os x" version: "10.6.4" arch: "x86_64" Family: "mac" Reporter: Joern Huxhorn Assignee: Logback dev list ch.qos.logback.classic.joran.conditional.ConditionalTest.conditionalConsoleApp_IF_THEN_True (from ConditionalTest) java.lang.AssertionError: at org.junit.Assert.fail(Assert.java:91) at org.junit.Assert.assertTrue(Assert.java:43) at org.junit.Assert.assertNotNull(Assert.java:524) at org.junit.Assert.assertNotNull(Assert.java:535) at ch.qos.logback.classic.joran.conditional.ConditionalTest.conditionalConsoleApp_IF_THEN_True(ConditionalTest.java:79) ch.qos.logback.classic.turbo.ReconfigureOnChangeTest.scan_lbclassic154 (from ReconfigureOnChangeTest) java.lang.AssertionError: effective=3, expected=4 at org.junit.Assert.fail(Assert.java:91) at org.junit.Assert.assertTrue(Assert.java:43) at ch.qos.logback.classic.turbo.ReconfigureOnChangeTest.verify(ReconfigureOnChangeTest.java:181) at ch.qos.logback.classic.turbo.ReconfigureOnChangeTest.scan_lbclassic154(ReconfigureOnChangeTest.java:163) The first one seems to fail always while the second one fails sometimes. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 11

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. v_0.9.25-11-g31c7138
by git-noreply＠pixie.qos.ch 19 Oct '10

19 Oct '10

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via 31c713847189d2dc19cc51ce43f727e8ed58b917 (commit) from 0eeea7653973434f7288b53f741d9c16bd4a300c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=31c713847189d2dc19cc51ce… http://github.com/ceki/logback/commit/31c713847189d2dc19cc51ce43f727e8ed58b… commit 31c713847189d2dc19cc51ce43f727e8ed58b917 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Tue Oct 19 21:06:32 2010 +0200 OnConsoleStatusListener now retrospectively prints status messages having occured in the last 300 milliseconds. diff --git a/logback-classic/src/test/input/joran/onConsoleRetro.xml b/logback-classic/src/test/input/joran/onConsoleRetro.xml new file mode 100644 index 0000000..dae7437 --- /dev/null +++ b/logback-classic/src/test/input/joran/onConsoleRetro.xml @@ -0,0 +1,14 @@ +<?xml version="1.0" encoding="UTF-8" ?> + +<configuration> + + + <appender name="LIST" class="ch.qos.logback.core.read.ListAppender"/> + + <root> + <level value="DEBUG"/> + <appender-ref ref="LIST"/> + </root> + <statusListener class="ch.qos.logback.core.status.OnConsoleStatusListener"/> +</configuration> + \ No newline at end of file diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbcore_155/Main.java b/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbcore_155/Main.java new file mode 100644 index 0000000..af7e196 --- /dev/null +++ b/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbcore_155/Main.java @@ -0,0 +1,26 @@ +package ch.qos.logback.classic.issue.lbcore_155; + +import ch.qos.logback.classic.Logger; +import ch.qos.logback.classic.LoggerContext; +import ch.qos.logback.core.util.StatusPrinter; +import org.slf4j.LoggerFactory; + +/** + * @author Ceki Gücü + */ +public class Main { + + public static void main(String[] args) throws InterruptedException { + + Logger logger = (Logger) LoggerFactory.getLogger(Main.class); + StatusPrinter.print((LoggerContext) LoggerFactory.getILoggerFactory()); + OThread ot = new OThread(); + ot.start(); + Thread.sleep(OThread.WAIT_MILLIS-500); + logger.info("About to interrupt"); + ot.interrupt(); + logger.info("After interrupt"); + logger.info("Leaving main"); + + } +} diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbcore_155/OThread.java b/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbcore_155/OThread.java new file mode 100644 index 0000000..a210401 --- /dev/null +++ b/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbcore_155/OThread.java @@ -0,0 +1,43 @@ +package ch.qos.logback.classic.issue.lbcore_155; + + +import ch.qos.logback.classic.LoggerContext; +import ch.qos.logback.core.util.StatusPrinter; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * @author Ceki Gücü + */ +public class OThread extends Thread { + + + static int NANOS_IN_MILLI = 1000 * 1000; + + static int WAIT_MILLIS = 10; + + Logger logger = LoggerFactory.getLogger(this.getClass()); + + public void run() { + + while (!isInterrupted()) { + long start = System.nanoTime(); + for (long now = System.nanoTime(); now < start + 2*WAIT_MILLIS*NANOS_IN_MILLI; now = System.nanoTime()) { + logger.info("in time loop"); + } + + logger.info("before 2nd sleep"); + + try { + sleep(1000); + } catch (InterruptedException e) { + logger.info("While sleeping", e); + e.printStackTrace(); + break; + } + logger.info("after sleep"); + } + logger.info("exiting WHILE"); + + } +} diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/joran/JoranConfiguratorTest.java b/logback-classic/src/test/java/ch/qos/logback/classic/joran/JoranConfiguratorTest.java index 5cebca1..26e7555 100644 --- a/logback-classic/src/test/java/ch/qos/logback/classic/joran/JoranConfiguratorTest.java +++ b/logback-classic/src/test/java/ch/qos/logback/classic/joran/JoranConfiguratorTest.java @@ -21,6 +21,7 @@ import java.util.logging.LogManager; import ch.qos.logback.classic.jul.JULHelper; import ch.qos.logback.core.util.StatusPrinter; +import org.junit.Ignore; import org.junit.Test; import org.slf4j.MDC; @@ -371,5 +372,17 @@ public class JoranConfiguratorTest { verifyJULLevel(Logger.ROOT_LOGGER_NAME, Level.TRACE); } + @Test + @Ignore + public void onConsoleRetro() throws JoranException, IOException, InterruptedException { + String configFileAsStr = ClassicTestConstants.JORAN_INPUT_PREFIX + + "/onConsoleRetro.xml"; + configure(configFileAsStr); + System.out.println("xxxxxxxxxxxxx"); + Thread.sleep(400); + + loggerContext.reset(); + configure(configFileAsStr); + } } diff --git a/logback-core/src/main/java/ch/qos/logback/core/joran/action/StatusListenerAction.java b/logback-core/src/main/java/ch/qos/logback/core/joran/action/StatusListenerAction.java index 7e06e34..604ed97 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/joran/action/StatusListenerAction.java +++ b/logback-core/src/main/java/ch/qos/logback/core/joran/action/StatusListenerAction.java @@ -13,6 +13,7 @@ */ package ch.qos.logback.core.joran.action; +import ch.qos.logback.core.spi.ContextAware; import org.xml.sax.Attributes; import ch.qos.logback.core.joran.spi.ActionException; @@ -24,35 +25,39 @@ import ch.qos.logback.core.util.OptionHelper; public class StatusListenerAction extends Action { - + boolean inError = false; StatusListener statusListener = null; - + public void begin(InterpretationContext ec, String name, Attributes attributes) throws ActionException { inError = false; String className = attributes.getValue(CLASS_ATTRIBUTE); - if(OptionHelper.isEmpty(className)) { + if (OptionHelper.isEmpty(className)) { addError( - "Missing class name for statusListener. Near [" - + name + "] line " + getLineNumber(ec)); + "Missing class name for statusListener. Near [" + + name + "] line " + getLineNumber(ec)); inError = true; return; } - + try { statusListener = (StatusListener) OptionHelper.instantiateByClassName( - className, StatusListener.class, context); + className, StatusListener.class, context); + addInfo("Adding status listener of type ["+className+"]"); ec.getContext().getStatusManager().add(statusListener); + if (statusListener instanceof ContextAware) { + ((ContextAware) statusListener).setContext(context); + } ec.pushObject(statusListener); } catch (Exception e) { inError = true; addError( - "Could not create an StatusListener of type ["+className+"].", e); + "Could not create an StatusListener of type [" + className + "].", e); throw new ActionException(e); } - + } - + public void finish(InterpretationContext ec) { } @@ -66,7 +71,7 @@ public class StatusListenerAction extends Action { Object o = ec.peekObject(); if (o != statusListener) { addWarn( - "The object at the of the stack is not the statusListener pushed earlier."); + "The object at the of the stack is not the statusListener pushed earlier."); } else { ec.popObject(); } diff --git a/logback-core/src/main/java/ch/qos/logback/core/status/OnConsoleStatusListener.java b/logback-core/src/main/java/ch/qos/logback/core/status/OnConsoleStatusListener.java index 9c1bbbd..332dcad 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/status/OnConsoleStatusListener.java +++ b/logback-core/src/main/java/ch/qos/logback/core/status/OnConsoleStatusListener.java @@ -13,8 +13,6 @@ */ package ch.qos.logback.core.status; -import ch.qos.logback.core.Context; -import ch.qos.logback.core.spi.ContextAware; import ch.qos.logback.core.spi.ContextAwareBase; import ch.qos.logback.core.spi.LifeCycle; import ch.qos.logback.core.util.StatusPrinter; @@ -29,31 +27,56 @@ import java.util.List; public class OnConsoleStatusListener extends ContextAwareBase implements StatusListener, LifeCycle { - boolean isStarted = false; + boolean isStarted = false; + long retrospective = 300; - private void print(Status status) { - StringBuilder sb = new StringBuilder(); - StatusPrinter.buildStr(sb, "", status); - System.out.print(sb); - } - public void addStatusEvent(Status status) { - if (!isStarted) - return; + private void print(Status status) { + StringBuilder sb = new StringBuilder(); + StatusPrinter.buildStr(sb, "", status); + System.out.print(sb); + } + + public void addStatusEvent(Status status) { + if (!isStarted) + return; + print(status); + } + + /** + * Print status messages retrospectively + */ + private void retrospectivePrint() { + long now = System.currentTimeMillis(); + StatusManager sm = context.getStatusManager(); + List<Status> statusList = sm.getCopyOfStatusList(); + for (Status status : statusList) { + long timestamp = status.getDate(); + if (now - timestamp < retrospective) { print(status); } - - public void start() { - isStarted = true; - StatusManager sm = context.getStatusManager(); - List<Status>statusList = sm.getCopyOfStatusList(); - for(sta) } + } - public void stop() { - isStarted = false; + public void start() { + isStarted = true; + if (retrospective > 0) { + retrospectivePrint(); } + } - public boolean isStarted() { - return isStarted; - } + public void setRetrospective(long retrospective) { + this.retrospective = retrospective; + } + + public long getRetrospective() { + return retrospective; + } + + public void stop() { + isStarted = false; + } + + public boolean isStarted() { + return isStarted; + } } ----------------------------------------------------------------------- Summary of changes: .../src/test/input/joran/onConsoleRetro.xml | 14 ++++ .../qos/logback/classic/issue/lbcore_155/Main.java | 26 ++++++++ .../logback/classic/issue/lbcore_155/OThread.java | 43 +++++++++++++ .../classic/joran/JoranConfiguratorTest.java | 13 ++++ .../core/joran/action/StatusListenerAction.java | 27 +++++--- .../core/status/OnConsoleStatusListener.java | 67 +++++++++++++------- 6 files changed, 157 insertions(+), 33 deletions(-) create mode 100644 logback-classic/src/test/input/joran/onConsoleRetro.xml create mode 100644 logback-classic/src/test/java/ch/qos/logback/classic/issue/lbcore_155/Main.java create mode 100644 logback-classic/src/test/java/ch/qos/logback/classic/issue/lbcore_155/OThread.java hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. v_0.9.25-10-g0eeea76
by git-noreply＠pixie.qos.ch 19 Oct '10

19 Oct '10

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via 0eeea7653973434f7288b53f741d9c16bd4a300c (commit) from ca7ec46c41a2d026fc3e2ad137962cf1e679a16b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=0eeea7653973434f7288b53f… http://github.com/ceki/logback/commit/0eeea7653973434f7288b53f741d9c16bd4a3… commit 0eeea7653973434f7288b53f741d9c16bd4a300c Author: Ceki Gulcu <ceki(a)qos.ch> Date: Tue Oct 19 17:55:24 2010 +0200 ongoing work diff --git a/logback-core/src/main/java/ch/qos/logback/core/status/OnConsoleStatusListener.java b/logback-core/src/main/java/ch/qos/logback/core/status/OnConsoleStatusListener.java index 9b6ea49..9c1bbbd 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/status/OnConsoleStatusListener.java +++ b/logback-core/src/main/java/ch/qos/logback/core/status/OnConsoleStatusListener.java @@ -13,20 +13,47 @@ */ package ch.qos.logback.core.status; +import ch.qos.logback.core.Context; +import ch.qos.logback.core.spi.ContextAware; +import ch.qos.logback.core.spi.ContextAwareBase; +import ch.qos.logback.core.spi.LifeCycle; import ch.qos.logback.core.util.StatusPrinter; +import java.util.List; + /** * Print all new incoming status messages on the console. - * - * @author Ceki Gülcü * + * @author Ceki Gülcü */ -public class OnConsoleStatusListener implements StatusListener { +public class OnConsoleStatusListener extends ContextAwareBase implements StatusListener, LifeCycle { + + + boolean isStarted = false; + + private void print(Status status) { + StringBuilder sb = new StringBuilder(); + StatusPrinter.buildStr(sb, "", status); + System.out.print(sb); + } + public void addStatusEvent(Status status) { + if (!isStarted) + return; + print(status); + } + + public void start() { + isStarted = true; + StatusManager sm = context.getStatusManager(); + List<Status>statusList = sm.getCopyOfStatusList(); + for(sta) + } + public void stop() { + isStarted = false; + } - public void addStatusEvent(Status status) { - StringBuilder sb = new StringBuilder(); - StatusPrinter.buildStr(sb, "", status); - System.out.print(sb); - } + public boolean isStarted() { + return isStarted; + } } ----------------------------------------------------------------------- Summary of changes: .../core/status/OnConsoleStatusListener.java | 43 ++++++++++++++++---- 1 files changed, 35 insertions(+), 8 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[JIRA] Created: (LBCORE-173) An ability to use external thread pool executor service for async rolling tasks.
by Alexander Morozov (JIRA) 19 Oct '10

19 Oct '10

An ability to use external thread pool executor service for async rolling tasks. -------------------------------------------------------------------------------- Key: LBCORE-173 URL: http://jira.qos.ch/browse/LBCORE-173 Project: logback-core Issue Type: Improvement Components: Rolling Reporter: Alexander Morozov Assignee: Logback dev list At this moment, compression tasks are managed by the means of logback-core, for example, TimeBasedRollingPolicy creates AsynCompressor task for each policy instance and creates as many compression threads, as many TimeBasedRollingPolicy instances present in the logger context. In the systems with great number of "fat" log files it may cause performance issues with filesystem. It would be much better if logback-core allowed to define external thread pool executor service and reuse it for such async tasks. Thanks :) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Created: (LBCORE-172) Compile logback.groovy rather than interpret at runtime
by Anthony Whitford (JIRA) 19 Oct '10

19 Oct '10

Compile logback.groovy rather than interpret at runtime ------------------------------------------------------- Key: LBCORE-172 URL: http://jira.qos.ch/browse/LBCORE-172 Project: logback-core Issue Type: Improvement Components: Other Affects Versions: 0.9.25 Environment: Windows, Java 6 Reporter: Anthony Whitford Assignee: Logback dev list Priority: Minor Configuring LogBack using an internal DSL with Groovy is a clever idea. Rather than including logback.groovy in the classpath and requiring a 5.5 MB groovy-all dependency to load and interpret it, why not offer a way that logback.groovy could be compiled at compile time. Then, instead of interpreting logback.groovy using a GroovyShell, why not simply run a method from an already compiled class. This strategy has the advantage of discovering many configuration problems (like typos) at compile-time rather than run-time. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 1

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. v_0.9.25-9-gca7ec46
by git-noreply＠pixie.qos.ch 18 Oct '10

18 Oct '10

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via ca7ec46c41a2d026fc3e2ad137962cf1e679a16b (commit) from 13500debebed9bb352c9216ab295ec21a8cbe59a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=ca7ec46c41a2d026fc3e2ad1… http://github.com/ceki/logback/commit/ca7ec46c41a2d026fc3e2ad137962cf1e679a… commit ca7ec46c41a2d026fc3e2ad137962cf1e679a16b Author: Ceki Gulcu <ceki(a)qos.ch> Date: Mon Oct 18 23:19:01 2010 +0200 editing diff --git a/logback-site/src/site/pages/manual/mdc.html b/logback-site/src/site/pages/manual/mdc.html index 9e24ced..afdb15b 100644 --- a/logback-site/src/site/pages/manual/mdc.html +++ b/logback-site/src/site/pages/manual/mdc.html @@ -36,11 +36,11 @@ complex distributed applications. Most real-world distributed systems need to deal with multiple clients simultaneously. In a typical multithreaded implementation of such a system, different - threads will handle different clients. A possible but discouraged - approach to differentiate the logging output of one client from - another consists of instantiating a new and separate logger for - each client. This technique promotes the proliferation of loggers - and considerably increases their management overhead. + threads will handle different clients. A possible but slightly + discouraged approach to differentiate the logging output of one + client from another consists of instantiating a new and separate + logger for each client. This technique promotes the proliferation + of loggers and may increase their management overhead. <script src="../templates/setup.js" type="text/javascript"></script> @@ -94,6 +94,9 @@ public class MDC { information in each log entry. + Please note that MDC as implemented by logback-classic assumes + that values are placed into the MDC with moderate frequency. + The next application named <code><a href="../xref/chapters/mdc/SimpleMDC.html">SimpleMDC</a></code> diff --git a/logback-site/src/site/pages/news.html b/logback-site/src/site/pages/news.html index 32f4256..537d28b 100644 --- a/logback-site/src/site/pages/news.html +++ b/logback-site/src/site/pages/news.html @@ -32,11 +32,20 @@ <h3>xxxx, 2010 - Release of version 0.9.26</h3> + Fixed <a + href="http://jira.qos.ch/browse/LBCLASSIC-183">LBCLASSIC-183</a> + as reported by Anthony Whitford. Upon application restart, Tomcat + should no longer complain about ThreadLocal variables created + internally by logback. + + When stopped, <code>RollingFileAppender</code> now calls <code>stop()</code> on its policy objects, fixing <a href="http://jira.qos.ch/browse/LBCORE-114">LBCORE-114</a> reported by Anders Wallgren. + + <h3>October 13th, 2010 - Release of version 0.9.25</h3> Logback-classic now supports <a ----------------------------------------------------------------------- Summary of changes: logback-site/src/site/pages/manual/mdc.html | 13 ++++++++----- logback-site/src/site/pages/news.html | 9 +++++++++ 2 files changed, 17 insertions(+), 5 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. v_0.9.25-8-g13500de
by git-noreply＠pixie.qos.ch 18 Oct '10

18 Oct '10

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via 13500debebed9bb352c9216ab295ec21a8cbe59a (commit) from 93995946b59b3ed1622d92c06b39c21942d98c58 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=13500debebed9bb352c9216a… http://github.com/ceki/logback/commit/13500debebed9bb352c9216ab295ec21a8cbe… commit 13500debebed9bb352c9216ab295ec21a8cbe59a Author: Ceki Gulcu <ceki(a)qos.ch> Date: Mon Oct 18 22:56:41 2010 +0200 Solve LBCLASSIC-183. Use InheritableThreadLocal instead of CopyOnInheritThreadLocal. This is sage given the implementaiton of the LogbackMDCAdapter.put method. diff --git a/logback-classic/src/main/java/ch/qos/logback/classic/util/LogbackMDCAdapter.java b/logback-classic/src/main/java/ch/qos/logback/classic/util/LogbackMDCAdapter.java index 2c4f807..83129b9 100644 --- a/logback-classic/src/main/java/ch/qos/logback/classic/util/LogbackMDCAdapter.java +++ b/logback-classic/src/main/java/ch/qos/logback/classic/util/LogbackMDCAdapter.java @@ -24,23 +24,25 @@ import org.slf4j.spi.MDCAdapter; * distinguishing interleaved log output from different sources. Log output is * typically interleaved when a server handles multiple clients * near-simultaneously. - * + * * The MDC is managed on a per thread basis. A child thread * automatically inherits a copy of the mapped diagnostic context of * its parent. - * - * + * + * * For more information about MDC, please refer to the online manual at * http://logback.qos.ch/manual/mdc.html - * + * * @author Ceki Gülcü */ public class LogbackMDCAdapter implements MDCAdapter { - // final CopyOnInheritThreadLocal copyOnInheritThreadLocal = new - // CopyOnInheritThreadLocal(); - final CopyOnInheritThreadLocal copyOnInheritThreadLocal = new CopyOnInheritThreadLocal(); + // We no longer use CopyOnInheritThreadLocal in order to solve LBCLASSIC-183 + // Initially the contents of the thread local in parent and child threads + // reference the same map. However, as soon as a thread invokes the put() + // method, the maps diverge as they should. + final InheritableThreadLocal<HashMap<String, String>> copyOnInheritThreadLocal = new InheritableThreadLocal<HashMap<String, String>>(); public LogbackMDCAdapter() { } @@ -49,19 +51,18 @@ public class LogbackMDCAdapter implements MDCAdapter { * Put a context value (the <code>val</code> parameter) as identified with the * <code>key</code> parameter into the current thread's context map. Note that * contrary to log4j, the <code>val</code> parameter can be null. - * - * + * + * * If the current thread does not have a context map it is created as a side * effect of this call. - * - * + * + * * Each time a value is added, a new instance of the map is created. This is * to be certain that the serialization process will operate on the updated * map and not send a reference to the old map, thus not allowing the remote * logback component to see the latest changes. - * - * @throws IllegalArgumentException - * in case the "key" parameter is null + * + * @throws IllegalArgumentException in case the "key" parameter is null */ public void put(String key, String val) throws IllegalArgumentException { if (key == null) { @@ -81,8 +82,8 @@ public class LogbackMDCAdapter implements MDCAdapter { /** * Get the context identified by the <code>key</code> parameter. - * - * + * + * * This method has no side effects. */ public String get(String key) { @@ -97,15 +98,15 @@ public class LogbackMDCAdapter implements MDCAdapter { /** * Remove the the context identified by the <code>key</code> parameter. - * - * + * + * * Each time a value is removed, a new instance of the map is created. This is * to be certain that the serialization process will operate on the updated * map and not send a reference to the old map, thus not allowing the remote * logback component to see the latest changes. */ public void remove(String key) { - if(key == null) { + if (key == null) { return; } HashMap<String, String> oldMap = copyOnInheritThreadLocal.get(); diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/util/LogbackMDCAdapterTest.java b/logback-classic/src/test/java/ch/qos/logback/classic/util/LogbackMDCAdapterTest.java index a88d9d0..8edb657 100644 --- a/logback-classic/src/test/java/ch/qos/logback/classic/util/LogbackMDCAdapterTest.java +++ b/logback-classic/src/test/java/ch/qos/logback/classic/util/LogbackMDCAdapterTest.java @@ -28,31 +28,32 @@ import ch.qos.logback.core.testUtil.RandomUtil; public class LogbackMDCAdapterTest { final static String A_SUFFIX = "A_SUFFIX"; + final static String B_SUFFIX = "B_SUFFIX"; int diff = RandomUtil.getPositiveInt(); /** - * Test that CopyOnInheritThreadLocal does not barf when the + * Test that CopyOnInheritThreadLocal does not barf when the * MDC hashmap is null - * + * * @throws InterruptedException */ @Test - public void lbclassic77() throws InterruptedException { + public void lbclassic77Test() throws InterruptedException { LogbackMDCAdapter lma = new LogbackMDCAdapter(); HashMap<String, String> parentHM = getHashMapFromMDCAdapter(lma); assertNull(parentHM); - + ChildThreadForMDCAdapter childThread = new ChildThreadForMDCAdapter(lma); childThread.start(); childThread.join(); assertTrue(childThread.successul); assertNull(childThread.childHM); } - + @Test - public void removeForNullKey() { + public void removeForNullKeyTest() { LogbackMDCAdapter lma = new LogbackMDCAdapter(); lma.remove(null); } @@ -62,7 +63,7 @@ public class LogbackMDCAdapterTest { LogbackMDCAdapter lma = new LogbackMDCAdapter(); lma.remove("abcdlw0"); } - + class ChildThreadForMDCAdapter extends Thread { LogbackMDCAdapter logbackMDCAdapter; @@ -72,7 +73,7 @@ public class LogbackMDCAdapterTest { ChildThreadForMDCAdapter(LogbackMDCAdapter logbackMDCAdapter) { this.logbackMDCAdapter = logbackMDCAdapter; } - + @Override public void run() { childHM = getHashMapFromMDCAdapter(logbackMDCAdapter); @@ -82,30 +83,43 @@ public class LogbackMDCAdapterTest { } // ================================================= + /** * Test that LogbackMDCAdapter copies its hashmap when a child * thread inherits it. - * + * * @throws InterruptedException */ @Test - public void copyOnInheritence() throws InterruptedException { + public void copyOnInheritenceTest() throws InterruptedException { String mdcKey = "x" + diff; String otherMDCKey = "o" + diff; MDC.put(mdcKey, mdcKey + A_SUFFIX); - HashMap<String, String> parentHM = getHashMapFromMDC(); ChildThreadForMDC childThread = new ChildThreadForMDC(mdcKey, otherMDCKey); childThread.start(); + MDC.put(mdcKey, mdcKey + B_SUFFIX); childThread.join(); assertNull(MDC.get(otherMDCKey)); assertTrue(childThread.successul); + + HashMap<String, String> parentHM = getHashMapFromMDC(); assertTrue(parentHM != childThread.childHM); + + HashMap<String, String> parentHMWitness = new HashMap<String, String>(); + parentHMWitness.put(mdcKey, mdcKey + B_SUFFIX); + assertEquals(parentHMWitness, parentHM); + + HashMap<String, String> childHMWitness = new HashMap<String, String>(); + childHMWitness.put(mdcKey, mdcKey + A_SUFFIX); + childHMWitness.put(otherMDCKey, otherMDCKey + A_SUFFIX); + assertEquals(childHMWitness, childThread.childHM); + } - + class ChildThreadForMDC extends Thread { String mdcKey; @@ -120,24 +134,23 @@ public class LogbackMDCAdapterTest { @Override public void run() { - childHM = getHashMapFromMDC(); - MDC.put(otherMDCKey, otherMDCKey + A_SUFFIX); assertNotNull(MDC.get(mdcKey)); assertEquals(mdcKey + A_SUFFIX, MDC.get(mdcKey)); assertEquals(otherMDCKey + A_SUFFIX, MDC.get(otherMDCKey)); successul = true; + childHM = getHashMapFromMDC(); } } HashMap<String, String> getHashMapFromMDCAdapter(LogbackMDCAdapter lma) { - CopyOnInheritThreadLocal copyOnInheritThreadLocal = lma.copyOnInheritThreadLocal; + InheritableThreadLocal<HashMap<String, String>> copyOnInheritThreadLocal = lma.copyOnInheritThreadLocal; return copyOnInheritThreadLocal.get(); } HashMap<String, String> getHashMapFromMDC() { LogbackMDCAdapter lma = (LogbackMDCAdapter) MDC.getMDCAdapter(); - CopyOnInheritThreadLocal copyOnInheritThreadLocal = lma.copyOnInheritThreadLocal; + InheritableThreadLocal<HashMap<String, String>> copyOnInheritThreadLocal = lma.copyOnInheritThreadLocal; return copyOnInheritThreadLocal.get(); } } ----------------------------------------------------------------------- Summary of changes: .../logback/classic/util/LogbackMDCAdapter.java | 39 +++++++++-------- .../classic/util/LogbackMDCAdapterTest.java | 45 +++++++++++++------- 2 files changed, 49 insertions(+), 35 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

MDC/ThreadLocal not being cleared properely?
by Marcel Stör 18 Oct '10

18 Oct '10

I'm wondering whether slf4j/logback (potentially) suffers from the same problems as log4j: http://www.mail-archive.com/log4j-user@logging.apache.org/msg11921.html http://www.mail-archive.com/log4j-dev@logging.apache.org/msg11378.html I'd switch from slf4j/log4j to slf4j/logback if this solved the issue. [Abstract] If you don't want to go through the above referenced posts... According to Tomcat's (>=6.0.24) "memory leak detection" listener the log4j MDC has a memory leak: "A web application created a ThreadLocal with key of type (...) and a value of type (...) but failed to remove it when the web application was stopped." That's because log4j doesn't provide something like ThreadLocal#remove. Regards, Marcel -- Marcel Stör, http://www.frightanic.com Couchsurfing: http://www.couchsurfing.com/people/marcelstoer O< ascii ribbon campaign - stop html mail - www.asciiribbon.org

1 1