October 2011 - logback-dev - mailman3.qos.ch

About LBCORE-224...
by Joern Huxhorn 11 Oct '11

11 Oct '11

This issue is still creeping me out. First of all, I'm perfectly fine with your workaround. Nevertheless, we should probably create an app that produces the IllegalMonitorStateException and deliver it to the Java developers. If this is a Java bug - and I have no other explanation - then it's a really critical one... Cheers, Joern.

5 20

testing - please ignore
by ceki 08 Oct '11

08 Oct '11

1 0

On going system maintenance
by Ceki Gülcü 07 Oct '11

07 Oct '11

Hi all, I am in the progress of migrating certain services to a newer machine. This may disrupt slf4j and logback mailing lists. -- http://twitter.com/ceki

1 0

[JIRA] Created: (LBCORE-147) RollingPolicy MaxHistory not deleting old files
by Rafael Diaz Maurin (JIRA) 04 Oct '11

04 Oct '11

RollingPolicy MaxHistory not deleting old files ----------------------------------------------- Key: LBCORE-147 URL: http://jira.qos.ch/browse/LBCORE-147 Project: logback-core Issue Type: Bug Components: Rolling Affects Versions: 0.9.18 Environment: linux 2.6.18 64bits apache-tomcat-6.0.20 java/jre1.6.0_18 Reporter: Rafael Diaz Maurin Assignee: Logback dev list The MaxHistory does not do the trick : the old files are not deleted at all : cat logging.xml <appender name="IDP_ACCESS" class="ch.qos.logback.core.rolling.RollingFileAppender"> <File>/shibboleth-idp/logs/idp-access.log</File> <Append>false</Append> <ImmediateFlush>true</ImmediateFlush> <RollingPolicy class="ch.qos.logback.core.rolling.TimeBasedRollingPolicy"> <FileNamePattern>/shibboleth-idp/logs/old/idp-access-%d{yyyy-MM-dd_HH-mm}.log.gz</FileNamePattern> <MaxHistory>3</MaxHistory> </RollingPolicy> <layout class="ch.qos.logback.classic.PatternLayout"> <Pattern>%msg%n</Pattern> </layout> </appender> -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

11 35

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. v_0.9.30-23-gb572ad6
by git-noreply＠pixie.qos.ch 04 Oct '11

04 Oct '11

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via b572ad6f784af47731dffcbe3e56476b190ede44 (commit) via 21ab32421307f702eecfa2d71376155cc0bcdfb5 (commit) via 46ae12bdf2d732aeb1f2579afe5c0bd1bd1cfc91 (commit) from c16086d475427676097597cea89460e504ca0cd6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=b572ad6f784af47731dffcbe… http://github.com/ceki/logback/commit/b572ad6f784af47731dffcbe3e56476b190ed… commit b572ad6f784af47731dffcbe3e56476b190ede44 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Tue Oct 4 15:30:17 2011 +0200 fix LBCLASSIC-283 diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/net/SerializationPerfTest.java b/logback-classic/src/test/java/ch/qos/logback/classic/net/SerializationPerfTest.java index 96c7650..8064a34 100644 --- a/logback-classic/src/test/java/ch/qos/logback/classic/net/SerializationPerfTest.java +++ b/logback-classic/src/test/java/ch/qos/logback/classic/net/SerializationPerfTest.java @@ -104,7 +104,7 @@ public class SerializationPerfTest extends TestCase { public void setUp() throws Exception { super.setUp(); if (runWithExternalMockServer) { - oos = new ObjectOutputStream(new Socket("pixie", + oos = new ObjectOutputStream(new Socket("localhost", ExternalMockSocketServer.PORT).getOutputStream()); } else { oos = new ObjectOutputStream(new NOPOutputStream()); http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=21ab32421307f702eecfa2d7… http://github.com/ceki/logback/commit/21ab32421307f702eecfa2d71376155cc0bcd… commit 21ab32421307f702eecfa2d71376155cc0bcdfb5 Author: Pierre Queinnec <pierre.queinnec(a)zenika.com> Date: Thu Jul 14 23:58:13 2011 +0800 Fix the exception occuring because LoggingEvent is not serializable by using LoggingEventVO instances for the benchmark. diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/net/SerializationPerfTest.java b/logback-classic/src/test/java/ch/qos/logback/classic/net/SerializationPerfTest.java index a5fe745..96c7650 100644 --- a/logback-classic/src/test/java/ch/qos/logback/classic/net/SerializationPerfTest.java +++ b/logback-classic/src/test/java/ch/qos/logback/classic/net/SerializationPerfTest.java @@ -19,8 +19,8 @@ import java.net.Socket; import junit.framework.TestCase; import ch.qos.logback.classic.net.testObjectBuilders.Builder; -import ch.qos.logback.classic.net.testObjectBuilders.TrivialLoggingEventBuilder; import ch.qos.logback.classic.net.testObjectBuilders.MinimalSerBuilder; +import ch.qos.logback.classic.net.testObjectBuilders.TrivialLoggingEventVOBuilder; public class SerializationPerfTest extends TestCase { @@ -194,8 +194,8 @@ public class SerializationPerfTest extends TestCase { // } public void testWithSerialization() throws Exception { - Builder builder = new TrivialLoggingEventBuilder(); - runPerfTest(builder, "LoggingEvent object serialization"); + Builder builder = new TrivialLoggingEventVOBuilder(); + runPerfTest(builder, "LoggingEventVO object serialization"); } http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=46ae12bdf2d732aeb1f2579a… http://github.com/ceki/logback/commit/46ae12bdf2d732aeb1f2579afe5c0bd1bd1cf… commit 46ae12bdf2d732aeb1f2579afe5c0bd1bd1cfc91 Author: Pierre Queinnec <pierre.queinnec(a)zenika.com> Date: Thu Jul 14 23:48:25 2011 +0800 Add a builder for LoggingEventVO objects. diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/net/testObjectBuilders/TrivialLoggingEventVOBuilder.java b/logback-classic/src/test/java/ch/qos/logback/classic/net/testObjectBuilders/TrivialLoggingEventVOBuilder.java new file mode 100644 index 0000000..d04c2d1 --- /dev/null +++ b/logback-classic/src/test/java/ch/qos/logback/classic/net/testObjectBuilders/TrivialLoggingEventVOBuilder.java @@ -0,0 +1,31 @@ +/** + * Logback: the reliable, generic, fast and flexible logging framework. + * Copyright (C) 1999-2011, QOS.ch. All rights reserved. + * + * This program and the accompanying materials are dual-licensed under + * either the terms of the Eclipse Public License v1.0 as published by + * the Eclipse Foundation + * + * or (per the licensee's choosing) + * + * under the terms of the GNU Lesser General Public License version 2.1 + * as published by the Free Software Foundation. + */ +package ch.qos.logback.classic.net.testObjectBuilders; + +import ch.qos.logback.classic.spi.LoggingEvent; +import ch.qos.logback.classic.spi.LoggingEventVO; + +/** + * @author Pierre Queinnec + */ +public class TrivialLoggingEventVOBuilder implements Builder { + + public Object build(int i) { + TrivialLoggingEventBuilder loggingEventBuilder = new TrivialLoggingEventBuilder(); + LoggingEvent event = (LoggingEvent) loggingEventBuilder.build(i); + + return LoggingEventVO.build(event); + } + +} ----------------------------------------------------------------------- Summary of changes: .../logback/classic/net/SerializationPerfTest.java | 8 +++--- ...lder.java => TrivialLoggingEventVOBuilder.java} | 27 ++++++++----------- 2 files changed, 15 insertions(+), 20 deletions(-) copy logback-classic/src/test/java/ch/qos/logback/classic/net/testObjectBuilders/{MinimalSerBuilder.java => TrivialLoggingEventVOBuilder.java} (55%) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[JIRA] Created: (LBCORE-218) Incorrect switch fallthrough in the SQL dialect selection
by Pierre Queinnec (JIRA) 04 Oct '11

04 Oct '11

Incorrect switch fallthrough in the SQL dialect selection --------------------------------------------------------- Key: LBCORE-218 URL: http://jira.qos.ch/browse/LBCORE-218 Project: logback-core Issue Type: Bug Components: Other Affects Versions: 0.9.30 Reporter: Pierre Queinnec Assignee: Logback dev list There's a break missing in the switch statement for SQL dialects in DBUtil#getDialectFromCode. As HSQLDB and H2 have the same syntax it has gone un-noticed. I'll open a pull request. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 2

[JIRA] Created: (LBCLASSIC-283) SerializationPerfTest crashes due to LoggingEvent being not serializable
by Pierre Queinnec (JIRA) 04 Oct '11

04 Oct '11

SerializationPerfTest crashes due to LoggingEvent being not serializable ------------------------------------------------------------------------ Key: LBCLASSIC-283 URL: http://jira.qos.ch/browse/LBCLASSIC-283 Project: logback-classic Issue Type: Bug Components: Other Affects Versions: 0.9.30 Reporter: Pierre Queinnec Assignee: Logback dev list SerializationPerfTest crashes due to LoggingEvent being not serializable. This can be trivially fixed using LoggingEventVO. I'll open a pull request with the changes, as I was interested in the benchmark. Thanks! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 2

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. v_0.9.30-20-gc16086d
by git-noreply＠pixie.qos.ch 04 Oct '11

04 Oct '11

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via c16086d475427676097597cea89460e504ca0cd6 (commit) via 54014e65f9f46af3844c24b8e4d5def15e2e6722 (commit) via 94c75b9fbf01b9850adcbba2c325747d468f889c (commit) from 46490d3c26121f3def3c6d4911ee22abe596e1df (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=c16086d475427676097597ce… http://github.com/ceki/logback/commit/c16086d475427676097597cea89460e504ca0… commit c16086d475427676097597cea89460e504ca0cd6 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Tue Oct 4 15:02:51 2011 +0200 fix LBCORE-218 diff --git a/logback-site/src/site/pages/news.html b/logback-site/src/site/pages/news.html index 5018b38..2fe9431 100644 --- a/logback-site/src/site/pages/news.html +++ b/logback-site/src/site/pages/news.html @@ -48,6 +48,12 @@ Pierre Queinnec. </p> + <p>Fixed incorrect switch fallthrough while selecting between the + H2 and HSQL dialects as reported in <a + href="http://jira.qos.ch/browse/LBCORE-218">LBCORE-218</a> by + Pierre Queinnec. + </p> + <h3>September 21st, 2011 - Release of version 0.9.30</h3> <p>Archive removal can now deal with prolonged periods of http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=54014e65f9f46af3844c24b8… http://github.com/ceki/logback/commit/54014e65f9f46af3844c24b8e4d5def15e2e6… commit 54014e65f9f46af3844c24b8e4d5def15e2e6722 Author: Pierre Queinnec <pierre.queinnec(a)zenika.com> Date: Fri Aug 5 18:57:42 2011 +0800 Fix the javadoc for the H2 dialect to distinguish from the HSQLDB one. diff --git a/logback-core/src/main/java/ch/qos/logback/core/db/dialect/H2Dialect.java b/logback-core/src/main/java/ch/qos/logback/core/db/dialect/H2Dialect.java index a28d2dd..9955f1d 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/db/dialect/H2Dialect.java +++ b/logback-core/src/main/java/ch/qos/logback/core/db/dialect/H2Dialect.java @@ -14,7 +14,7 @@ package ch.qos.logback.core.db.dialect; /** - * The HSQLDB dialect. + * The H2 dialect. * * @author Ceki Gülcü */ http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=94c75b9fbf01b9850adcbba2… http://github.com/ceki/logback/commit/94c75b9fbf01b9850adcbba2c325747d468f8… commit 94c75b9fbf01b9850adcbba2c325747d468f889c Author: Pierre Queinnec <pierre.queinnec(a)zenika.com> Date: Fri Aug 5 18:56:43 2011 +0800 Add a missing break in the switch statement responsible for choosing the SQL dialect. This went unnoticed because HSQLDB and H2 dialects are identical as of now. diff --git a/logback-core/src/main/java/ch/qos/logback/core/db/dialect/DBUtil.java b/logback-core/src/main/java/ch/qos/logback/core/db/dialect/DBUtil.java index f0cafbf..ba1cf09 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/db/dialect/DBUtil.java +++ b/logback-core/src/main/java/ch/qos/logback/core/db/dialect/DBUtil.java @@ -86,6 +86,7 @@ public class DBUtil extends ContextAwareBase { case HSQL_DIALECT: sqlDialect = new HSQLDBDialect(); + break; case H2_DIALECT: sqlDialect = new H2Dialect(); ----------------------------------------------------------------------- Summary of changes: .../ch/qos/logback/core/db/dialect/DBUtil.java | 1 + .../ch/qos/logback/core/db/dialect/H2Dialect.java | 2 +- logback-site/src/site/pages/news.html | 6 ++++++ 3 files changed, 8 insertions(+), 1 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. v_0.9.30-17-g46490d3
by git-noreply＠pixie.qos.ch 03 Oct '11

03 Oct '11

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via 46490d3c26121f3def3c6d4911ee22abe596e1df (commit) from 490d56f33f71aef3dbcc30a388b99c95e6372a03 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=46490d3c26121f3def3c6d49… http://github.com/ceki/logback/commit/46490d3c26121f3def3c6d4911ee22abe596e… commit 46490d3c26121f3def3c6d4911ee22abe596e1df Author: Ceki Gulcu <ceki(a)qos.ch> Date: Mon Oct 3 23:35:33 2011 +0200 LBACCESS-25 diff --git a/logback-site/src/site/pages/news.html b/logback-site/src/site/pages/news.html index 7426181..5018b38 100644 --- a/logback-site/src/site/pages/news.html +++ b/logback-site/src/site/pages/news.html @@ -38,10 +38,16 @@ <p>Investigation of <a href="http://jira.qos.ch/browse/LBCORE-224">LBCORE-224</a> reported by Cesar Alvarez Nunez points to bug in the JVM rather - than in logbacl. A workaround has been found by using + than in logback. A workaround has been found by using <code>CopyOnWriteArrayList</code> instead of the apparently buggy <code>ReadWriteLock</code>.</p> + <p>Fixed infinitely recursive calls in + <code>AccessConverter#addError</code> methods as reported in <a + href="http://jira.qos.ch/browse/LBACCESS-25">LBACCESS-25</a> by + Pierre Queinnec. + </p> + <h3>September 21st, 2011 - Release of version 0.9.30</h3> <p>Archive removal can now deal with prolonged periods of ----------------------------------------------------------------------- Summary of changes: logback-site/src/site/pages/news.html | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[JIRA] Created: (LBCLASSIC-297) logback.xml not found when initialized by java agent
by subes (JIRA) 02 Oct '11

02 Oct '11

logback.xml not found when initialized by java agent ---------------------------------------------------- Key: LBCLASSIC-297 URL: http://jira.qos.ch/browse/LBCLASSIC-297 Project: logback-classic Issue Type: Bug Affects Versions: 0.9.31 Reporter: subes Assignee: Logback dev list datanucleus-enhancer is a java agent that manipulates java classes during jvm startup. It uses a Log4J binding, which is implemented by slf4j and delegated to logback. datanucleus-enhacer spams the console with unnecessary debug statements while it does its work: 21:29:25.369 [main] DEBUG DataNucleus.ClassLoading - Class "org.eclipse.core.runtime.RegistryFactory" was not found in the CLASSPATH [Class resolver called from org.datanucleus.plugin.PluginRegistryFactory.newInstance (line=91)] 21:29:25.374 [main] DEBUG DataNucleus.Plugin - Plugin Registry "org.datanucleus.plugin.EclipsePluginRegistry" not found. Falling back to DataNucleus registry. Reason : Class "org.eclipse.core.runtime.RegistryFactory" was not found in the CLASSPATH. Please check your specification and your CLASSPATH.. 21:29:25.375 [main] DEBUG DataNucleus.Plugin - Using PluginRegistry org.datanucleus.plugin.NonManagedPluginRegistry 21:29:25.399 [main] DEBUG DataNucleus.ClassLoading - Class "org.eclipse.core.runtime.RegistryFactory" was not found in the CLASSPATH [Class resolver called from org.datanucleus.plugin.PluginRegistryFactory.newInstance (line=91)] 21:29:25.400 [main] DEBUG DataNucleus.Plugin - Plugin Registry "org.datanucleus.plugin.EclipsePluginRegistry" not found. Falling back to DataNucleus registry. Reason : Class "org.eclipse.core.runtime.RegistryFactory" was not found in the CLASSPATH. Please check your specification and your CLASSPATH.. 21:29:25.400 [main] DEBUG DataNucleus.Plugin - Using PluginRegistry org.datanucleus.plugin.NonManagedPluginRegistry ... -------------------------------------------------------------------------------------------------------- That is because logback does not find my logback.xml on the classpath: <configuration> <appender name="console" class="de.invesdwin.gemeinsam.log.logback.ConfiguredConsoleAppender"> <Target>System.err</Target> </appender> <root level="WARN"> <appender-ref ref="console" /> </root> </configuration> -------------------------------------------------------------------------------------------------------- This is caused by ContextInitializer.getResource() using the wrong classloader during java agent process: sun.misc.Launcher$AppClassLoader@28df6ccd which cannot resolve the classpath name: logback.xml to fix this, logback should fallback to the system classloader if the resource was not found with the specific classloader. To do this, we have to change: ------------------- private URL getResource(String filename, ClassLoader myClassLoader, boolean updateStatus) { URL url = Loader.getResource(filename, myClassLoader); if (updateStatus) { statusOnResourceSearch(filename, myClassLoader, url); } return url; } ------------------- to: ------------------- private URL getResource(String filename, ClassLoader myClassLoader, boolean updateStatus) { URL url = Loader.getResource(filename, myClassLoader); if(url == null){ url = Loader.getResource(filename, ClassLoader.getSystemClassLoader()); } if (updateStatus) { statusOnResourceSearch(filename, myClassLoader, url); } return url; } to properly initialize logback during javaagent execution. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 2