March 2011 - logback-dev - mailman3.qos.ch

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. v_0.9.28-23-ga7582c9
by git-noreply＠pixie.qos.ch 09 Mar '11

09 Mar '11

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via a7582c96029b7666fb2a0380dd8a60af2cce613c (commit) from 40fb027ac8d80af4b0fe0d6dff595eafa335fbfa (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=a7582c96029b7666fb2a0380… http://github.com/ceki/logback/commit/a7582c96029b7666fb2a0380dd8a60af2cce6… commit a7582c96029b7666fb2a0380dd8a60af2cce613c Author: Ceki Gulcu <ceki(a)qos.ch> Date: Wed Mar 9 19:20:47 2011 +0100 ongoing work diff --git a/logback-classic/src/test/input/gaffer/x.groovy b/logback-classic/src/test/input/gaffer/x.groovy new file mode 100644 index 0000000..22d6db4 --- /dev/null +++ b/logback-classic/src/test/input/gaffer/x.groovy @@ -0,0 +1,62 @@ +import ch.qos.logback.classic.PatternLayout +import ch.qos.logback.classic.filter.ThresholdFilter +import ch.qos.logback.classic.net.SMTPAppender +import ch.qos.logback.core.ConsoleAppender +import ch.qos.logback.core.rolling.FixedWindowRollingPolicy +import ch.qos.logback.core.rolling.RollingFileAppender +import ch.qos.logback.core.rolling.SizeBasedTriggeringPolicy + + +import static ch.qos.logback.classic.Level.ERROR +import static ch.qos.logback.classic.Level.INFO + + + +appender("RootFileAppender", RollingFileAppender) { + file = "project" + append = true + filter(ThresholdFilter) { + level = INFO + } + rollingPolicy(FixedWindowRollingPolicy) { + fileNamePattern = "project_log.%i" + maxIndex = 1 + } + triggeringPolicy(SizeBasedTriggeringPolicy) { + maxFileSize = 1000000 + } + + layout(PatternLayout) { + pattern = "%d{yyyy-MM-dd HH:mm:ss}, %p, %c, %t, %ex, %F, %L, %C{1}, %M %m%n" + } +} + +appender("RootConsoleAppender", ConsoleAppender) { + filter(ThresholdFilter) { + level = INFO + } + + layout(PatternLayout) { + pattern = "%d{yyyy-MM-dd HH:mm:ss}, %p, %c, %t %m%n" + } +} + +appender("RootEmailAppender", SMTPAppender) { + filter(ThresholdFilter) { + level = ERROR + } + bufferSize = 10 + SMTPHost = "smtp.hostaddress" + to = "logback.user(a)xyz.com" + from = " logback.user(a)xyz.com " + username = "user" + password = "password" + subject = "Logback Error" + + layout(PatternLayout) { + pattern = "%d{yyyy-MM-dd HH:mm:ss}, %p, %c, %t, %ex, %F, %L, %C{1}, %M %m%n" + } + +} + +root(INFO, ["RootFileAppender", "RootConsoleAppender", "RootEmailAppender"]) \ No newline at end of file diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/util/LogbackMDCAdapterTest.java b/logback-classic/src/test/java/ch/qos/logback/classic/util/LogbackMDCAdapterTest.java index 7799af7..b4bb459 100644 --- a/logback-classic/src/test/java/ch/qos/logback/classic/util/LogbackMDCAdapterTest.java +++ b/logback-classic/src/test/java/ch/qos/logback/classic/util/LogbackMDCAdapterTest.java @@ -108,7 +108,7 @@ public class LogbackMDCAdapterTest { } } - // ================================================= + // ================================================= /** * Test that LogbackMDCAdapter copies its hashmap when a child @@ -146,6 +146,28 @@ public class LogbackMDCAdapterTest { } + // see also http://jira.qos.ch/browse/LBCLASSIC-253 + @Test + public void clearOnChildThreadShouldNotAffectParent() throws InterruptedException { + String firstKey = "x" + diff; + String secondKey = "o" + diff; + + MDC.put(firstKey, firstKey+A_SUFFIX); + assertEquals(firstKey+A_SUFFIX, MDC.get(firstKey)); + + Thread clearer = new ChildThreadForMDC(firstKey, secondKey) { + @Override + public void run() { + MDC.clear(); + assertNull(MDC.get(firstKey)); + } + }; + + clearer.start(); + clearer.join(); + + assertEquals(firstKey+A_SUFFIX, MDC.get(firstKey)); + } class ChildThreadForMDC extends Thread { @@ -155,6 +177,10 @@ public class LogbackMDCAdapterTest { HashMap<String, String> childHM; CountDownLatch countDownLatch; + ChildThreadForMDC(String firstKey, String secondKey) { + this(firstKey, secondKey, null); + } + ChildThreadForMDC(String firstKey, String secondKey, CountDownLatch countDownLatch) { this.firstKey = firstKey; this.secondKey = secondKey; @@ -166,7 +192,7 @@ public class LogbackMDCAdapterTest { MDC.put(secondKey, secondKey + A_SUFFIX); assertNotNull(MDC.get(firstKey)); assertEquals(firstKey + A_SUFFIX, MDC.get(firstKey)); - countDownLatch.countDown(); + if(countDownLatch != null) countDownLatch.countDown(); assertEquals(secondKey + A_SUFFIX, MDC.get(secondKey)); successul = true; childHM = getHashMapFromMDC(); diff --git a/logback-core/src/main/java/ch/qos/logback/core/rolling/TimeBasedRollingPolicy.java b/logback-core/src/main/java/ch/qos/logback/core/rolling/TimeBasedRollingPolicy.java index 40d3713..1159aa5 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/rolling/TimeBasedRollingPolicy.java +++ b/logback-core/src/main/java/ch/qos/logback/core/rolling/TimeBasedRollingPolicy.java @@ -71,8 +71,8 @@ public class TimeBasedRollingPolicy<E> extends RollingPolicyBase implements compressor.setContext(context); // wcs : without compression suffix - fileNamePatternWCS = new FileNamePattern(computeFileNameStr_WCS( - fileNamePatternStr, compressionMode), this.context); + fileNamePatternWCS = new FileNamePattern(Compressor.computeFileNameStr_WCS( + fileNamePatternStr, compressionMode), this.context); addInfo("Will use the pattern " + fileNamePatternWCS + " for the active file"); @@ -104,20 +104,6 @@ public class TimeBasedRollingPolicy<E> extends RollingPolicyBase implements return timeBasedFileNamingAndTriggeringPolicy; } - static public String computeFileNameStr_WCS(String fileNamePatternStr, - CompressionMode compressionMode) { - int len = fileNamePatternStr.length(); - switch (compressionMode) { - case GZ: - return fileNamePatternStr.substring(0, len - 3); - case ZIP: - return fileNamePatternStr.substring(0, len - 4); - case NONE: - return fileNamePatternStr; - } - throw new IllegalStateException("Execution should not reach this point"); - } - public void rollover() throws RolloverFailure { // when rollover is called the elapsed period's file has diff --git a/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/Compressor.java b/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/Compressor.java index d664d66..cb2f899 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/Compressor.java +++ b/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/Compressor.java @@ -35,20 +35,10 @@ public class Compressor extends ContextAwareBase { final CompressionMode compressionMode; - // final String nameOfFile2Compress; - // final String nameOfCompressedFile; - public Compressor(CompressionMode compressionMode) { this.compressionMode = compressionMode; } - // public Compressor(CompressionMode compressionMode, String - // nameOfFile2Compress, String nameOfCompressedFile) { - // this.compressionMode = compressionMode; - // //this.nameOfFile2Compress = nameOfFile2Compress; - // //this.nameOfCompressedFile = nameOfCompressedFile; - // } - public void compress(String nameOfFile2Compress, String nameOfCompressedFile) { switch (compressionMode) { case GZ: @@ -132,8 +122,7 @@ public class Compressor extends ContextAwareBase { // all having the same name, which could make it harder for the user // to unzip the file without collisions ZipEntry computeZipEntry(File zippedFile) { - String nameOfFileNestedWithinArchive = TimeBasedRollingPolicy - .computeFileNameStr_WCS(zippedFile.getName(), compressionMode); + String nameOfFileNestedWithinArchive = computeFileNameStr_WCS(zippedFile.getName(), compressionMode); return new ZipEntry(nameOfFileNestedWithinArchive); } @@ -184,6 +173,20 @@ public class Compressor extends ContextAwareBase { } } + static public String computeFileNameStr_WCS(String fileNamePatternStr, + CompressionMode compressionMode) { + int len = fileNamePatternStr.length(); + switch (compressionMode) { + case GZ: + return fileNamePatternStr.substring(0, len - 3); + case ZIP: + return fileNamePatternStr.substring(0, len - 4); + case NONE: + return fileNamePatternStr; + } + throw new IllegalStateException("Execution should not reach this point"); + } + @Override public String toString() { return "c.q.l.core.rolling.helper.Compress"; diff --git a/logback-core/src/test/scala/ch/qos/logback/core/rolling/A.scala b/logback-core/src/test/scala/ch/qos/logback/core/rolling/A.scala deleted file mode 100644 index b446737..0000000 --- a/logback-core/src/test/scala/ch/qos/logback/core/rolling/A.scala +++ /dev/null @@ -1,41 +0,0 @@ -package ch.qos.logback.core.rolling - -import collection.mutable.ListBuffer -import org.junit.Test - -/** - * Created by IntelliJ IDEA. - * User: ceki - * Date: 27.12.10 - * Time: 14:19 - * To change this template use File | Settings | File Templates. - */ - -class A { - - - val initial = List(1,2, 3, 5) - def mon[B](f: Int => B): List[B] = { - val b = new ListBuffer[B] - var these = initial - while (!these.isEmpty) { - var that = f(these.head) - b += that - these = these.tail - } - b.toList - } - - def asString(in: Any):String = { - "-"+ in.toString; - } - - @Test - def doTest() { - val res: List[String] = mon(asString); - println(res) - - - } - -} \ No newline at end of file diff --git a/logback-core/src/test/scala/ch/qos/logback/core/rolling/LBCORE_199.scala b/logback-core/src/test/scala/ch/qos/logback/core/rolling/LBCORE_199.scala new file mode 100644 index 0000000..fc7ea2a --- /dev/null +++ b/logback-core/src/test/scala/ch/qos/logback/core/rolling/LBCORE_199.scala @@ -0,0 +1,62 @@ +package ch.qos.logback.core.rolling + +import org.junit.{Before, Test} +import ch.qos.logback.core.encoder.EchoEncoder +import ch.qos.logback.core.util.StatusPrinter + +/** + * Created by IntelliJ IDEA. + * User: ceki + * Date: 09.03.11 + * Time: 18:11 + * To change this template use File | Settings | File Templates. + */ + +class LBCORE_199 extends RollingScaffolding { + + private[rolling] var rfa: RollingFileAppender[AnyRef] = new RollingFileAppender[AnyRef] + private[rolling] var fwrp: FixedWindowRollingPolicy[AnyRef] = new FixedWindowRollingPolicy[AnyRef] + private[rolling] var triggeringPolicy = new SizeBasedTriggeringPolicy[AnyRef] + private[rolling] var encoder: EchoEncoder[AnyRef] = new EchoEncoder[AnyRef] + + @Before + def setUp: Unit = { + setUpScaffolding + fwrp.setContext(context) + rfa.setContext(context) + triggeringPolicy.setContext(context) + } + + private[rolling] def initRFA(filename: String): Unit = { + rfa.setEncoder(encoder) + if (filename != null) { + rfa.setFile(filename) + } + } + + @Test + def smoke() { + println("ba") + initRFA("toto.log") + fwrp.setFileNamePattern("tests.%i.log.gz") + fwrp.minIndex = 1 + fwrp.maxIndex = 3 + fwrp.setParent(rfa) + fwrp.start + triggeringPolicy.setMaxFileSize("20") + triggeringPolicy.start + rfa.triggeringPolicy = triggeringPolicy + rfa.rollingPolicy = fwrp + rfa.start + + for (i <- 1 to 100) { + Thread.sleep(10) + rfa.doAppend("hello "+i) + } + + StatusPrinter.print(context) + + } + + +} \ No newline at end of file diff --git a/logback-site/src/site/pages/news.html b/logback-site/src/site/pages/news.html index 2304328..2cb6553 100644 --- a/logback-site/src/site/pages/news.html +++ b/logback-site/src/site/pages/news.html @@ -35,6 +35,12 @@ a performace issue in <code>LogbackMDCAdapter</code> as reported by Michael Franz. + Given that events reference a snapshot of the current MDC map, + the snapshot should not be cleared upon invocation of the + MDC.clear operation. This issue was reported in <a + href="http://jira.qos.ch/browse/LBCLASSIC-253">LBCLASSIC-253</a> + by Tommy Becker and independently fixed by the changes designated + to fix LBCLASSIC-254. <code>ConfigurationWatchList</code> no longer emits an error message when it encouters a configuraton file placed in a jar ----------------------------------------------------------------------- Summary of changes: logback-classic/src/test/input/gaffer/x.groovy | 62 ++++++++++++++++++++ .../classic/util/LogbackMDCAdapterTest.java | 30 +++++++++- .../core/rolling/TimeBasedRollingPolicy.java | 18 +----- .../logback/core/rolling/helper/Compressor.java | 27 +++++---- .../test/scala/ch/qos/logback/core/rolling/A.scala | 41 ------------- .../ch/qos/logback/core/rolling/LBCORE_199.scala | 62 ++++++++++++++++++++ logback-site/src/site/pages/news.html | 6 ++ 7 files changed, 175 insertions(+), 71 deletions(-) create mode 100644 logback-classic/src/test/input/gaffer/x.groovy delete mode 100644 logback-core/src/test/scala/ch/qos/logback/core/rolling/A.scala create mode 100644 logback-core/src/test/scala/ch/qos/logback/core/rolling/LBCORE_199.scala hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[JIRA] Created: (LBCLASSIC-253) MDC.clear() in child thread improperly affects parent.
by Thomas Becker (JIRA) 09 Mar '11

09 Mar '11

MDC.clear() in child thread improperly affects parent. ------------------------------------------------------ Key: LBCLASSIC-253 URL: http://jira.qos.ch/browse/LBCLASSIC-253 Project: logback-classic Issue Type: Bug Components: Other Affects Versions: 0.9.28 Environment: JDK 1.6.0_21 Reporter: Thomas Becker Assignee: Logback dev list I want to upgrade logback to 0.9.28 but one of my unit tests caught this bug in the LogbackMDCAdapter. Basically, if a child thread clears the MDC, the parent thread's copy is cleared as well. This simple unit test illustrates the problem. import org.junit.Test; import org.slf4j.MDC; /** * Demonstrates a bug in LogbackMDCAdapter. The clear() executed by the child thread should not affect the parent. */ public class MDCTest { @Test public void testBug() throws InterruptedException { MDC.put("foo", "bar"); assertEquals("bar", MDC.get("foo")); Thread clearer = new Thread() { @Override public void run() { MDC.clear(); assertNull(MDC.get("foo")); } }; clearer.start(); clearer.join(); //Fails assertEquals("bar", MDC.get("foo")); } } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 4

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. v_0.9.28-22-g40fb027
by git-noreply＠pixie.qos.ch 08 Mar '11

08 Mar '11

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via 40fb027ac8d80af4b0fe0d6dff595eafa335fbfa (commit) from e068bd3b9754e8d62e4ca799480bc3a6c7e14683 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=40fb027ac8d80af4b0fe0d6d… http://github.com/ceki/logback/commit/40fb027ac8d80af4b0fe0d6dff595eafa335f… commit 40fb027ac8d80af4b0fe0d6dff595eafa335fbfa Author: Ceki Gulcu <ceki(a)qos.ch> Date: Tue Mar 8 22:49:36 2011 +0100 updates to news.html diff --git a/logback-site/src/site/pages/news.html b/logback-site/src/site/pages/news.html index 739c3d4..2304328 100644 --- a/logback-site/src/site/pages/news.html +++ b/logback-site/src/site/pages/news.html @@ -30,6 +30,12 @@ <h3>xxx, 2011 - Release of version 0.9.29</h3> + Fixed <a + href="http://jira.qos.ch/browse/LBCLASSIC-254">LBCLASSIC-254</a>, + a performace issue in <code>LogbackMDCAdapter</code> as reported + by Michael Franz. + + <code>ConfigurationWatchList</code> no longer emits an error message when it encouters a configuraton file placed in a jar file, fixing <a @@ -43,6 +49,7 @@ href="http://jira.qos.ch/browse/LBCORE-193">LBCORE-193</a> reported by B. K. Oxley. + <hr width="80%" align="center" /> <h3>January 25th, 2011 - Release of version 0.9.28</h3> ----------------------------------------------------------------------- Summary of changes: logback-site/src/site/pages/news.html | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[JIRA] Created: (LBCLASSIC-254) Performance improvement for LogbackMDCAdapter
by Michael Franz (JIRA) 08 Mar '11

08 Mar '11

Performance improvement for LogbackMDCAdapter --------------------------------------------- Key: LBCLASSIC-254 URL: http://jira.qos.ch/browse/LBCLASSIC-254 Project: logback-classic Issue Type: Improvement Components: Other Affects Versions: 0.9.28 Reporter: Michael Franz Assignee: Logback dev list Attachments: LogbackMDCAdapter.java During performance analysis of our application the LogbackMDCAdapter showed up as a performance hotspot. This is because the application does relatively often replaces multiple entries in the MDC at ones, e.g. 6 removes/writes without any intermediate log statement. Also actual log messages that come through filtering before creating the LoggingEvent are relatively rare in production environments. I have reworked the implementation to improve the performance. The main idea is to defer cloning the internal Map as long possible. This patch increased overall application performance by about 10% in that test. Other application types were MDC changes are small and many LoggingEvent objects are created (calls to getPropertyMap()) should not be affected significantly. Note: I haven't check if my patch would reintroduce the #LBCLASSIC-183, but my subclasses of InheritableThreadLocal does not override the initialValue() method, so it could work. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 5

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. v_0.9.28-21-ge068bd3
by git-noreply＠pixie.qos.ch 08 Mar '11

08 Mar '11

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via e068bd3b9754e8d62e4ca799480bc3a6c7e14683 (commit) from 0cc65fce0f69854255d2798d93c7ff11a08be0ce (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=e068bd3b9754e8d62e4ca799… http://github.com/ceki/logback/commit/e068bd3b9754e8d62e4ca799480bc3a6c7e14… commit e068bd3b9754e8d62e4ca799480bc3a6c7e14683 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Tue Mar 8 22:17:10 2011 +0100 - refactoring - avoid clearing the old map reference which may be still referenced elsewhere diff --git a/logback-classic/src/main/java/ch/qos/logback/classic/util/LogbackMDCAdapter.java b/logback-classic/src/main/java/ch/qos/logback/classic/util/LogbackMDCAdapter.java index d8e5a80..b8ffb82 100644 --- a/logback-classic/src/main/java/ch/qos/logback/classic/util/LogbackMDCAdapter.java +++ b/logback-classic/src/main/java/ch/qos/logback/classic/util/LogbackMDCAdapter.java @@ -35,7 +35,7 @@ import org.slf4j.spi.MDCAdapter; * * @author Ceki Gülcü */ -public class LogbackMDCAdapter implements MDCAdapter { +public final class LogbackMDCAdapter implements MDCAdapter { // We no longer use CopyOnInheritThreadLocal in order to solve LBCLASSIC-183 @@ -47,19 +47,31 @@ public class LogbackMDCAdapter implements MDCAdapter { private static final int WRITE_OPERATION = 1; private static final int READ_OPERATION = 2; + // keeps track of the last operation performed final ThreadLocal<Integer> lastOperation = new ThreadLocal<Integer>(); - - public LogbackMDCAdapter() { } private Integer getAndSetLastOperation(int op) { Integer lastOp = lastOperation.get(); - lastOperation.set(WRITE_OPERATION); + lastOperation.set(op); return lastOp; } + private boolean wasLastOpReadOrNull(Integer lastOp) { + return lastOp == null || lastOp.intValue() == READ_OPERATION; + } + + private HashMap<String, String> duplicateAndInsertNewMap(HashMap<String, String> oldMap) { + HashMap<String, String> newMap = new HashMap<String, String>(); + if (oldMap != null) + newMap.putAll(oldMap); + // the newMap replaces the old one for serialisation's sake + copyOnInheritThreadLocal.set(newMap); + return newMap; + } + /** * Put a context value (the <code>val</code> parameter) as identified with the * <code>key</code> parameter into the current thread's context map. Note that @@ -68,12 +80,6 @@ public class LogbackMDCAdapter implements MDCAdapter { * * If the current thread does not have a context map it is created as a side * effect of this call. - * - * - * Each time a value is added, a new instance of the map is created. This is - * to be certain that the serialization process will operate on the updated - * map and not send a reference to the old map, thus not allowing the remote - * logback component to see the latest changes. * * @throws IllegalArgumentException in case the "key" parameter is null */ @@ -85,13 +91,8 @@ public class LogbackMDCAdapter implements MDCAdapter { HashMap<String, String> oldMap = copyOnInheritThreadLocal.get(); Integer lastOp = getAndSetLastOperation(WRITE_OPERATION); - if(lastOp == null || lastOp.intValue() == READ_OPERATION || oldMap == null) { - HashMap<String, String> newMap = new HashMap<String, String>(); - if (oldMap != null) { - newMap.putAll(oldMap); - } - // the newMap replaces the old one for serialisation's sake - copyOnInheritThreadLocal.set(newMap); + if (wasLastOpReadOrNull(lastOp) || oldMap == null) { + HashMap<String, String> newMap = duplicateAndInsertNewMap(oldMap); newMap.put(key, val); } else { oldMap.put(key, val); @@ -99,61 +100,49 @@ public class LogbackMDCAdapter implements MDCAdapter { } /** - * Get the context identified by the <code>key</code> parameter. - * - * - * This method has no side effects. - */ - public String get(String key) { - HashMap<String, String> hashMap = copyOnInheritThreadLocal.get(); - - if ((hashMap != null) && (key != null)) { - return hashMap.get(key); - } else { - return null; - } - } - - - /** * Remove the the context identified by the <code>key</code> parameter. * - * - * Each time a value is removed, a new instance of the map is created. This is - * to be certain that the serialization process will operate on the updated - * map and not send a reference to the old map, thus not allowing the remote - * logback component to see the latest changes. */ public void remove(String key) { if (key == null) { return; } HashMap<String, String> oldMap = copyOnInheritThreadLocal.get(); - if(oldMap == null) return; + if (oldMap == null) return; Integer lastOp = getAndSetLastOperation(WRITE_OPERATION); - if(lastOp == null || lastOp.intValue() == READ_OPERATION) { - HashMap<String, String> newMap = new HashMap<String, String>(); - newMap.putAll(oldMap); - // the newMap replaces the old one for serialisation's sake - copyOnInheritThreadLocal.set(newMap); + if (wasLastOpReadOrNull(lastOp)) { + HashMap<String, String> newMap = duplicateAndInsertNewMap(oldMap); newMap.remove(key); } else { oldMap.remove(key); } } + /** * Clear all entries in the MDC. */ public void clear() { - HashMap<String, String> hashMap = copyOnInheritThreadLocal.get(); - Integer lastOp = getAndSetLastOperation(WRITE_OPERATION); + lastOperation.set(WRITE_OPERATION); copyOnInheritThreadLocal.remove(); } /** + * Get the context identified by the <code>key</code> parameter. + * + */ + public String get(String key) { + Map<String, String> map = getPropertyMap(); + if ((map != null) && (key != null)) { + return map.get(key); + } else { + return null; + } + } + + /** * Get the current thread's MDC as a map. This method is intended to be used * internally. */ @@ -163,47 +152,40 @@ public class LogbackMDCAdapter implements MDCAdapter { } /** - * Return a copy of the current thread's context map. Returned value may be + * Returns the keys in the MDC as a {@link Set}. The returned value can be * null. */ - public Map getCopyOfContextMap() { - HashMap<String, String> hashMap = copyOnInheritThreadLocal.get(); - if (hashMap == null) { - return null; + public Set<String> getKeys() { + Map<String, String> map = getPropertyMap(); + + if (map != null) { + return map.keySet(); } else { - return new HashMap<String, String>(hashMap); + return null; } } /** - * Returns the keys in the MDC as a {@link Set}. The returned value can be + * Return a copy of the current thread's context map. Returned value may be * null. */ - public Set<String> getKeys() { - lastOperation.set(READ_OPERATION); + public Map getCopyOfContextMap() { HashMap<String, String> hashMap = copyOnInheritThreadLocal.get(); - - if (hashMap != null) { - return hashMap.keySet(); - } else { + if (hashMap == null) { return null; + } else { + return new HashMap<String, String>(hashMap); } } @SuppressWarnings("unchecked") public void setContextMap(Map contextMap) { - HashMap<String, String> oldMap = copyOnInheritThreadLocal.get(); + lastOperation.set(WRITE_OPERATION); HashMap<String, String> newMap = new HashMap<String, String>(); newMap.putAll(contextMap); // the newMap replaces the old one for serialisation's sake copyOnInheritThreadLocal.set(newMap); - - // hints for the garbage collector - if (oldMap != null) { - oldMap.clear(); - oldMap = null; - } } } diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/util/LogbackMDCAdapterTest.java b/logback-classic/src/test/java/ch/qos/logback/classic/util/LogbackMDCAdapterTest.java index 767b490..7799af7 100644 --- a/logback-classic/src/test/java/ch/qos/logback/classic/util/LogbackMDCAdapterTest.java +++ b/logback-classic/src/test/java/ch/qos/logback/classic/util/LogbackMDCAdapterTest.java @@ -19,6 +19,7 @@ import static org.junit.Assert.assertNull; import static org.junit.Assert.assertTrue; import java.util.HashMap; +import java.util.Map; import java.util.concurrent.CountDownLatch; import org.junit.Test; @@ -61,11 +62,34 @@ public class LogbackMDCAdapterTest { } @Test - public void removeInexistnetKey() { + public void removeInexistentKey() { LogbackMDCAdapter lma = new LogbackMDCAdapter(); lma.remove("abcdlw0"); } + + @Test + public void sequenceWithGet() { + LogbackMDCAdapter lma = new LogbackMDCAdapter(); + lma.put("k0", "v0"); + Map<String, String> map0 = lma.copyOnInheritThreadLocal.get(); + lma.get("k0"); // point 0 + lma.put("k0", "v1"); + // verify that map0 is that in point 0 + assertEquals("v0", map0.get("k0")); + } + + @Test + public void sequenceWithGetPropertyMap() { + LogbackMDCAdapter lma = new LogbackMDCAdapter(); + lma.put("k0", "v0"); + Map<String, String> map0 = lma.getPropertyMap(); // point 0 + lma.put("k0", "v1"); + // verify that map0 is that in point 0 + assertEquals("v0", map0.get("k0")); + } + + class ChildThreadForMDCAdapter extends Thread { LogbackMDCAdapter logbackMDCAdapter; @@ -111,11 +135,11 @@ public class LogbackMDCAdapterTest { HashMap<String, String> parentHM = getHashMapFromMDC(); assertTrue(parentHM != childThread.childHM); - HashMap<String, String> parentHMWitness = new HashMap<String, String>(); + HashMap<String, String> parentHMWitness = new HashMap<String, String>(); parentHMWitness.put(firstKey, firstKey + B_SUFFIX); assertEquals(parentHMWitness, parentHM); - HashMap<String, String> childHMWitness = new HashMap<String, String>(); + HashMap<String, String> childHMWitness = new HashMap<String, String>(); childHMWitness.put(firstKey, firstKey + A_SUFFIX); childHMWitness.put(secondKey, secondKey + A_SUFFIX); assertEquals(childHMWitness, childThread.childHM); @@ -150,13 +174,13 @@ public class LogbackMDCAdapterTest { } HashMap<String, String> getHashMapFromMDCAdapter(LogbackMDCAdapter lma) { - InheritableThreadLocal<HashMap<String, String>> copyOnInheritThreadLocal = lma.copyOnInheritThreadLocal; + InheritableThreadLocal<HashMap<String, String>> copyOnInheritThreadLocal = lma.copyOnInheritThreadLocal; return copyOnInheritThreadLocal.get(); } HashMap<String, String> getHashMapFromMDC() { LogbackMDCAdapter lma = (LogbackMDCAdapter) MDC.getMDCAdapter(); - InheritableThreadLocal<HashMap<String, String>> copyOnInheritThreadLocal = lma.copyOnInheritThreadLocal; + InheritableThreadLocal<HashMap<String, String>> copyOnInheritThreadLocal = lma.copyOnInheritThreadLocal; return copyOnInheritThreadLocal.get(); } } ----------------------------------------------------------------------- Summary of changes: .../logback/classic/util/LogbackMDCAdapter.java | 116 ++++++++----------- .../classic/util/LogbackMDCAdapterTest.java | 34 +++++- 2 files changed, 78 insertions(+), 72 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

Custom Logback for WebApplication
by cissine 08 Mar '11

08 Mar '11

Hello Everybody, I'm a new user of the FrameWork LogBack for Logging from France, and i have some question. I want to create a new Interface/Class for my webapplication, and i want to use the method of this class ( class name, file path, id ... ) and instantiate all this in the begining..., with that, i can just tel logback the name of my application and/or the name of the classes and logback will do his job. the goal is to avoid to write in all my webapp's class : Logger logger = LoggerFactory.getLogger(MyClass.class); and : Logger.(debug/info/trace/error/warn) Is it possible to do that ? Think you ! -- View this message in context: http://old.nabble.com/Custom-Logback-for-WebApplication-tp31097213p31097213… Sent from the Logback Dev mailing list archive at Nabble.com.

1 0

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. v_0.9.28-20-g0cc65fc
by git-noreply＠pixie.qos.ch 07 Mar '11

07 Mar '11

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via 0cc65fce0f69854255d2798d93c7ff11a08be0ce (commit) from ce40eedafcb09985ad861044dfecd803cfc0e9cc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=0cc65fce0f69854255d2798d… http://github.com/ceki/logback/commit/0cc65fce0f69854255d2798d93c7ff11a08be… commit 0cc65fce0f69854255d2798d93c7ff11a08be0ce Author: Ceki Gulcu <ceki(a)qos.ch> Date: Mon Mar 7 23:50:30 2011 +0100 make tests pass diff --git a/logback-classic/src/main/java/ch/qos/logback/classic/util/LogbackMDCAdapter.java b/logback-classic/src/main/java/ch/qos/logback/classic/util/LogbackMDCAdapter.java index acf427b..d8e5a80 100644 --- a/logback-classic/src/main/java/ch/qos/logback/classic/util/LogbackMDCAdapter.java +++ b/logback-classic/src/main/java/ch/qos/logback/classic/util/LogbackMDCAdapter.java @@ -85,7 +85,7 @@ public class LogbackMDCAdapter implements MDCAdapter { HashMap<String, String> oldMap = copyOnInheritThreadLocal.get(); Integer lastOp = getAndSetLastOperation(WRITE_OPERATION); - if(lastOp == null || lastOp.intValue() == READ_OPERATION) { + if(lastOp == null || lastOp.intValue() == READ_OPERATION || oldMap == null) { HashMap<String, String> newMap = new HashMap<String, String>(); if (oldMap != null) { newMap.putAll(oldMap); diff --git a/logback-classic/src/test/groovy/ch/qos/logback/classic/gaffer/GafferConfiguratorTest.groovy b/logback-classic/src/test/groovy/ch/qos/logback/classic/gaffer/GafferConfiguratorTest.groovy index 7d52d73..c36d936 100644 --- a/logback-classic/src/test/groovy/ch/qos/logback/classic/gaffer/GafferConfiguratorTest.groovy +++ b/logback-classic/src/test/groovy/ch/qos/logback/classic/gaffer/GafferConfiguratorTest.groovy @@ -157,14 +157,4 @@ class GafferConfiguratorTest { assertTrue ca.isStarted() assertEquals("HELLO %m%n", ca.encoder.getLayout().pattern) } - - @Test - void p() { - context.putProperty("p", "HELLO"); - File file = new File(ClassicTestConstants.GAFFER_INPUT_PREFIX + "x.groovy") - String dslText = file.text - configurator.run dslText - StatusPrinter.print(context) - - } } diff --git a/pom.xml b/pom.xml index ea8959e..514ea01 100755 --- a/pom.xml +++ b/pom.xml @@ -35,7 +35,7 @@ <junit.version>4.8.2</junit.version> <janino.version>2.5.10</janino.version> <scala.version>2.7.7</scala.version> - <groovy.version>1.7.8</groovy.version> + <groovy.version>1.7.6</groovy.version> <surefire.version>2.6</surefire.version> <consolePlugin.version>1.1.0</consolePlugin.version> </properties> ----------------------------------------------------------------------- Summary of changes: .../logback/classic/util/LogbackMDCAdapter.java | 2 +- .../classic/gaffer/GafferConfiguratorTest.groovy | 10 ---------- pom.xml | 2 +- 3 files changed, 2 insertions(+), 12 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. v_0.9.28-19-gce40eed
by git-noreply＠pixie.qos.ch 07 Mar '11

07 Mar '11

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via ce40eedafcb09985ad861044dfecd803cfc0e9cc (commit) from 6cacf873a1691b3ce233e5eebaf846f652cdb12b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=ce40eedafcb09985ad861044… http://github.com/ceki/logback/commit/ce40eedafcb09985ad861044dfecd803cfc0e… commit ce40eedafcb09985ad861044dfecd803cfc0e9cc Author: Ceki Gulcu <ceki(a)qos.ch> Date: Mon Mar 7 23:23:35 2011 +0100 optimized LogbackMDCAppender as requested in http://jira.qos.ch/browse/LBCLASSIC-254 diff --git a/logback-classic/src/main/java/ch/qos/logback/classic/util/LogbackMDCAdapter.java b/logback-classic/src/main/java/ch/qos/logback/classic/util/LogbackMDCAdapter.java index 83129b9..acf427b 100644 --- a/logback-classic/src/main/java/ch/qos/logback/classic/util/LogbackMDCAdapter.java +++ b/logback-classic/src/main/java/ch/qos/logback/classic/util/LogbackMDCAdapter.java @@ -44,9 +44,22 @@ public class LogbackMDCAdapter implements MDCAdapter { // method, the maps diverge as they should. final InheritableThreadLocal<HashMap<String, String>> copyOnInheritThreadLocal = new InheritableThreadLocal<HashMap<String, String>>(); + private static final int WRITE_OPERATION = 1; + private static final int READ_OPERATION = 2; + + final ThreadLocal<Integer> lastOperation = new ThreadLocal<Integer>(); + + + public LogbackMDCAdapter() { } + private Integer getAndSetLastOperation(int op) { + Integer lastOp = lastOperation.get(); + lastOperation.set(WRITE_OPERATION); + return lastOp; + } + /** * Put a context value (the <code>val</code> parameter) as identified with the * <code>key</code> parameter into the current thread's context map. Note that @@ -70,14 +83,19 @@ public class LogbackMDCAdapter implements MDCAdapter { } HashMap<String, String> oldMap = copyOnInheritThreadLocal.get(); - - HashMap<String, String> newMap = new HashMap<String, String>(); - if (oldMap != null) { - newMap.putAll(oldMap); + Integer lastOp = getAndSetLastOperation(WRITE_OPERATION); + + if(lastOp == null || lastOp.intValue() == READ_OPERATION) { + HashMap<String, String> newMap = new HashMap<String, String>(); + if (oldMap != null) { + newMap.putAll(oldMap); + } + // the newMap replaces the old one for serialisation's sake + copyOnInheritThreadLocal.set(newMap); + newMap.put(key, val); + } else { + oldMap.put(key, val); } - // the newMap replaces the old one for serialisation's sake - copyOnInheritThreadLocal.set(newMap); - newMap.put(key, val); } /** @@ -96,6 +114,7 @@ public class LogbackMDCAdapter implements MDCAdapter { } } + /** * Remove the the context identified by the <code>key</code> parameter. * @@ -110,14 +129,19 @@ public class LogbackMDCAdapter implements MDCAdapter { return; } HashMap<String, String> oldMap = copyOnInheritThreadLocal.get(); + if(oldMap == null) return; - HashMap<String, String> newMap = new HashMap<String, String>(); - if (oldMap != null) { + Integer lastOp = getAndSetLastOperation(WRITE_OPERATION); + + if(lastOp == null || lastOp.intValue() == READ_OPERATION) { + HashMap<String, String> newMap = new HashMap<String, String>(); newMap.putAll(oldMap); + // the newMap replaces the old one for serialisation's sake + copyOnInheritThreadLocal.set(newMap); + newMap.remove(key); + } else { + oldMap.remove(key); } - // the newMap replaces the old one for serialisation's sake - copyOnInheritThreadLocal.set(newMap); - newMap.remove(key); } /** @@ -125,11 +149,8 @@ public class LogbackMDCAdapter implements MDCAdapter { */ public void clear() { HashMap<String, String> hashMap = copyOnInheritThreadLocal.get(); - - if (hashMap != null) { - hashMap.clear(); - copyOnInheritThreadLocal.remove(); - } + Integer lastOp = getAndSetLastOperation(WRITE_OPERATION); + copyOnInheritThreadLocal.remove(); } /** @@ -137,6 +158,7 @@ public class LogbackMDCAdapter implements MDCAdapter { * internally. */ public Map<String, String> getPropertyMap() { + lastOperation.set(READ_OPERATION); return copyOnInheritThreadLocal.get(); } @@ -158,6 +180,7 @@ public class LogbackMDCAdapter implements MDCAdapter { * null. */ public Set<String> getKeys() { + lastOperation.set(READ_OPERATION); HashMap<String, String> hashMap = copyOnInheritThreadLocal.get(); if (hashMap != null) { diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/util/LogbackMDCAdapterTest.java b/logback-classic/src/test/java/ch/qos/logback/classic/util/LogbackMDCAdapterTest.java index 8edb657..767b490 100644 --- a/logback-classic/src/test/java/ch/qos/logback/classic/util/LogbackMDCAdapterTest.java +++ b/logback-classic/src/test/java/ch/qos/logback/classic/util/LogbackMDCAdapterTest.java @@ -19,6 +19,7 @@ import static org.junit.Assert.assertNull; import static org.junit.Assert.assertTrue; import java.util.HashMap; +import java.util.concurrent.CountDownLatch; import org.junit.Test; import org.slf4j.MDC; @@ -32,6 +33,7 @@ public class LogbackMDCAdapterTest { int diff = RandomUtil.getPositiveInt(); + /** * Test that CopyOnInheritThreadLocal does not barf when the * MDC hashmap is null @@ -92,29 +94,30 @@ public class LogbackMDCAdapterTest { */ @Test public void copyOnInheritenceTest() throws InterruptedException { - String mdcKey = "x" + diff; - String otherMDCKey = "o" + diff; - MDC.put(mdcKey, mdcKey + A_SUFFIX); - + CountDownLatch countDownLatch = new CountDownLatch(1); + String firstKey = "x" + diff; + String secondKey = "o" + diff; + MDC.put(firstKey, firstKey + A_SUFFIX); - ChildThreadForMDC childThread = new ChildThreadForMDC(mdcKey, otherMDCKey); + ChildThreadForMDC childThread = new ChildThreadForMDC(firstKey, secondKey, countDownLatch); childThread.start(); - MDC.put(mdcKey, mdcKey + B_SUFFIX); + countDownLatch.await(); + MDC.put(firstKey, firstKey + B_SUFFIX); childThread.join(); - assertNull(MDC.get(otherMDCKey)); + assertNull(MDC.get(secondKey)); assertTrue(childThread.successul); HashMap<String, String> parentHM = getHashMapFromMDC(); assertTrue(parentHM != childThread.childHM); HashMap<String, String> parentHMWitness = new HashMap<String, String>(); - parentHMWitness.put(mdcKey, mdcKey + B_SUFFIX); + parentHMWitness.put(firstKey, firstKey + B_SUFFIX); assertEquals(parentHMWitness, parentHM); HashMap<String, String> childHMWitness = new HashMap<String, String>(); - childHMWitness.put(mdcKey, mdcKey + A_SUFFIX); - childHMWitness.put(otherMDCKey, otherMDCKey + A_SUFFIX); + childHMWitness.put(firstKey, firstKey + A_SUFFIX); + childHMWitness.put(secondKey, secondKey + A_SUFFIX); assertEquals(childHMWitness, childThread.childHM); } @@ -122,22 +125,25 @@ public class LogbackMDCAdapterTest { class ChildThreadForMDC extends Thread { - String mdcKey; - String otherMDCKey; + String firstKey; + String secondKey; boolean successul; HashMap<String, String> childHM; + CountDownLatch countDownLatch; - ChildThreadForMDC(String mdcKey, String otherMDCKey) { - this.mdcKey = mdcKey; - this.otherMDCKey = otherMDCKey; + ChildThreadForMDC(String firstKey, String secondKey, CountDownLatch countDownLatch) { + this.firstKey = firstKey; + this.secondKey = secondKey; + this.countDownLatch = countDownLatch; } @Override public void run() { - MDC.put(otherMDCKey, otherMDCKey + A_SUFFIX); - assertNotNull(MDC.get(mdcKey)); - assertEquals(mdcKey + A_SUFFIX, MDC.get(mdcKey)); - assertEquals(otherMDCKey + A_SUFFIX, MDC.get(otherMDCKey)); + MDC.put(secondKey, secondKey + A_SUFFIX); + assertNotNull(MDC.get(firstKey)); + assertEquals(firstKey + A_SUFFIX, MDC.get(firstKey)); + countDownLatch.countDown(); + assertEquals(secondKey + A_SUFFIX, MDC.get(secondKey)); successul = true; childHM = getHashMapFromMDC(); } ----------------------------------------------------------------------- Summary of changes: .../logback/classic/util/LogbackMDCAdapter.java | 57 ++++++++++++++------ .../classic/util/LogbackMDCAdapterTest.java | 44 +++++++++------- 2 files changed, 65 insertions(+), 36 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. v_0.9.28-18-g6cacf87
by git-noreply＠pixie.qos.ch 07 Mar '11

07 Mar '11

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via 6cacf873a1691b3ce233e5eebaf846f652cdb12b (commit) from ad8b72b119ed9beff2ef4f11b814586e8de5479e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=6cacf873a1691b3ce233e5ee… http://github.com/ceki/logback/commit/6cacf873a1691b3ce233e5eebaf846f652cdb… commit 6cacf873a1691b3ce233e5eebaf846f652cdb12b Author: Ceki Gulcu <ceki(a)qos.ch> Date: Mon Mar 7 19:54:16 2011 +0100 added doc improvements suggested by David Beamer diff --git a/logback-examples/src/main/java/chapters/architecture/SelectionRule.java b/logback-examples/src/main/java/chapters/architecture/SelectionRule.java new file mode 100644 index 0000000..d4debd4 --- /dev/null +++ b/logback-examples/src/main/java/chapters/architecture/SelectionRule.java @@ -0,0 +1,38 @@ +package chapters.architecture; + +import ch.qos.logback.classic.Level; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * @author Ceki Gücü + */ +public class SelectionRule { + + public static void main(String[] args) { + // get a logger instance named "com.foo". Let us further assume that the + // logger is of type ch.qos.logback.classic.Logger so that we can + // set its level + ch.qos.logback.classic.Logger logger = (ch.qos.logback.classic.Logger) LoggerFactory.getLogger("com.foo"); + //set its Level to INFO. The setLevel() method requires a logback logger + logger.setLevel(Level.INFO); + + Logger barlogger = LoggerFactory.getLogger("com.foo.Bar"); + + // This request is enabled, because WARN >= INFO + logger.warn("Low fuel level."); + + // This request is disabled, because DEBUG < INFO. + logger.debug("Starting search for nearest gas station."); + + // The logger instance barlogger, named "com.foo.Bar", + // will inherit its level from the logger named + // "com.foo" Thus, the following request is enabled + // because INFO >= INFO. + barlogger.info("Located nearest gas station."); + + // This request is disabled, because DEBUG < INFO. + barlogger.debug("Exiting gas station search"); + + } +} diff --git a/logback-site/src/site/pages/manual/architecture.html b/logback-site/src/site/pages/manual/architecture.html index 939636b..9a3f956 100644 --- a/logback-site/src/site/pages/manual/architecture.html +++ b/logback-site/src/site/pages/manual/architecture.html @@ -436,10 +436,19 @@ public interface Logger { Here is an example of the basic selection rule. - <pre class="prettyprint source">// get a logger instance named "com.foo" -Logger logger = LoggerFactory.getLogger("com.foo"); -//set its Level to INFO + <pre class="prettyprint source">import ch.qos.logback.classic.Level; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +.... + +// get a logger instance named "com.foo". Let us further assume that the +// logger is of type ch.qos.logback.classic.Logger so that we can +// set its level +ch.qos.logback.classic.Logger logger = + (ch.qos.logback.classic.Logger) LoggerFactory.getLogger("com.foo"); +//set its Level to INFO. The setLevel() method requires a logback logger logger.setLevel(Level. INFO); + Logger barlogger = LoggerFactory.getLogger("com.foo.Bar"); // This request is enabled, because WARN >= INFO diff --git a/logback-site/src/site/pages/manual/configuration.html b/logback-site/src/site/pages/manual/configuration.html index 17fc59e..38a8de0 100644 --- a/logback-site/src/site/pages/manual/configuration.html +++ b/logback-site/src/site/pages/manual/configuration.html @@ -159,8 +159,9 @@ public class MyApp1 { } }</pre> - This class defines a static logger variable. It then - instantiates a Foo object. The Foo class is listed below: + This class defines a static logger variable. It then instantiates + a <code>Foo</code> object. The <code>Foo</code> class is listed + below: Example: Small class doing logging @@ -195,8 +196,9 @@ public class Foo { configuration consists of a <code>ConsoleAppender</code> attached to the root logger. The output is formatted using a <code>PatternLayoutEncoder</code> set to the pattern - %d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n. Moreover, by default the root logger is assigned the - <code>DEBUG</code> level. + %d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n. Moreover, + by default the root logger is assigned the <code>DEBUG</code> + level. Thus, the output of the command java chapters.configuration.MyApp1 @@ -684,7 +686,7 @@ public class MyApp3 { If you are unsure which case to use for a given tag name, just follow the <a href="http://en.wikipedia.org/wiki/CamelCase">camelCase - convention</a> which is almost always the corrrect convention. + convention</a> which is almost always the correct convention. </div> <h4><a name="caseSensitivity" href="#caseSensitivity">Case ----------------------------------------------------------------------- Summary of changes: .../java/chapters/architecture/SelectionRule.java | 38 ++++++++++++++++++++ .../src/site/pages/manual/architecture.html | 15 ++++++-- .../src/site/pages/manual/configuration.html | 12 ++++--- 3 files changed, 57 insertions(+), 8 deletions(-) create mode 100644 logback-examples/src/main/java/chapters/architecture/SelectionRule.java hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[JIRA] Created: (LBSITE-43) "Write Your Own Appender" example outdated
by Eric Jain (JIRA) 05 Mar '11

05 Mar '11

"Write Your Own Appender" example outdated ------------------------------------------ Key: LBSITE-43 URL: http://jira.qos.ch/browse/LBSITE-43 Project: logback-site Issue Type: Bug Components: Documentation Affects Versions: 0.9.28 Reporter: Eric Jain Assignee: Logback dev list http://logback.qos.ch/manual/appenders.html#WriteYourOwnAppender The example code references "this.layout", which no longer exists. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0