September 2011 - logback-dev

[JIRA] Created: (LBCORE-218) Incorrect switch fallthrough in the SQL dialect selection
by Pierre Queinnec (JIRA) 04 Oct '11

04 Oct '11

Incorrect switch fallthrough in the SQL dialect selection --------------------------------------------------------- Key: LBCORE-218 URL: http://jira.qos.ch/browse/LBCORE-218 Project: logback-core Issue Type: Bug Components: Other Affects Versions: 0.9.30 Reporter: Pierre Queinnec Assignee: Logback dev list There's a break missing in the switch statement for SQL dialects in DBUtil#getDialectFromCode. As HSQLDB and H2 have the same syntax it has gone un-noticed. I'll open a pull request. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 2

[JIRA] Created: (LBCLASSIC-283) SerializationPerfTest crashes due to LoggingEvent being not serializable
by Pierre Queinnec (JIRA) 04 Oct '11

04 Oct '11

SerializationPerfTest crashes due to LoggingEvent being not serializable ------------------------------------------------------------------------ Key: LBCLASSIC-283 URL: http://jira.qos.ch/browse/LBCLASSIC-283 Project: logback-classic Issue Type: Bug Components: Other Affects Versions: 0.9.30 Reporter: Pierre Queinnec Assignee: Logback dev list SerializationPerfTest crashes due to LoggingEvent being not serializable. This can be trivially fixed using LoggingEventVO. I'll open a pull request with the changes, as I was interested in the benchmark. Thanks! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 2

[JIRA] Created: (LBACCESS-25) Infinite loops in AccessConverter#addError
by Pierre Queinnec (JIRA) 30 Sep '11

30 Sep '11

Infinite loops in AccessConverter#addError ------------------------------------------ Key: LBACCESS-25 URL: http://jira.qos.ch/browse/LBACCESS-25 Project: logback-access Issue Type: Bug Affects Versions: 0.9.30 Reporter: Pierre Queinnec Assignee: Logback dev list The addError(String msg) and addError(String msg, Throwable ex) methods seem to be calling themselves in an infinite loop. I'll open a pull-request. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 2

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. v_0.9.30-16-g490d56f
by git-noreply＠pixie.qos.ch 30 Sep '11

30 Sep '11

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via 490d56f33f71aef3dbcc30a388b99c95e6372a03 (commit) from 385ba8afa57029a17e436b06b77e3dc1c4e79881 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=490d56f33f71aef3dbcc30a3… http://github.com/ceki/logback/commit/490d56f33f71aef3dbcc30a388b99c95e6372… commit 490d56f33f71aef3dbcc30a388b99c95e6372a03 Author: Pierre Queinnec <pierre.queinnec(a)zenika.com> Date: Thu Jul 21 03:35:40 2011 +0800 Remove two infinite loops in AccessConverter#addError methods. diff --git a/logback-access/src/main/java/ch/qos/logback/access/pattern/AccessConverter.java b/logback-access/src/main/java/ch/qos/logback/access/pattern/AccessConverter.java index bbb102d..c3c74db 100644 --- a/logback-access/src/main/java/ch/qos/logback/access/pattern/AccessConverter.java +++ b/logback-access/src/main/java/ch/qos/logback/access/pattern/AccessConverter.java @@ -57,11 +57,11 @@ abstract public class AccessConverter extends DynamicConverter<IAccessEvent> imp } public void addError(String msg) { - addError(msg); + cab.addError(msg); } public void addError(String msg, Throwable ex) { - addError(msg, ex); + cab.addError(msg, ex); } } ----------------------------------------------------------------------- Summary of changes: .../logback/access/pattern/AccessConverter.java | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[JIRA] Created: (LBACCESS-17) LogbackValve overrides final start() method from LifecycleBase in Tomcat 7
by Grzegorz Grzybek (JIRA) 30 Sep '11

30 Sep '11

LogbackValve overrides final start() method from LifecycleBase in Tomcat 7 -------------------------------------------------------------------------- Key: LBACCESS-17 URL: http://jira.qos.ch/browse/LBACCESS-17 Project: logback-access Issue Type: Bug Affects Versions: 0.9.26 Reporter: Grzegorz Grzybek Assignee: Logback dev list Priority: Critical {code} java.lang.VerifyError: class ch.qos.logback.access.tomcat.LogbackValve overrides final method start.()V {code} Tomcat 7 has changed the LifecycleBase implementation - it should not override start() but rather startInternal() -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

3 3

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. v_0.9.30-15-g385ba8a
by git-noreply＠pixie.qos.ch 30 Sep '11

30 Sep '11

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via 385ba8afa57029a17e436b06b77e3dc1c4e79881 (commit) via 958d0a4611b7e10988aa286bf317a0d13468ee6b (commit) from 6b7985ee8171195dbaf0a4da4dda2099aa428eb8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=385ba8afa57029a17e436b06… http://github.com/ceki/logback/commit/385ba8afa57029a17e436b06b77e3dc1c4e79… commit 385ba8afa57029a17e436b06b77e3dc1c4e79881 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Fri Sep 30 23:28:19 2011 +0200 The logback-access module now targets Tomcat 7.x and Jetty 7.x & 8.x as its servlet container platforms. diff --git a/logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java b/logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java index ede5b77..e1a6edc 100644 --- a/logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java +++ b/logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java @@ -27,7 +27,9 @@ import ch.qos.logback.access.spi.IAccessEvent; //import org.apache.catalina.Lifecycle; import ch.qos.logback.core.spi.*; import org.apache.catalina.Lifecycle; +import org.apache.catalina.LifecycleException; import org.apache.catalina.LifecycleListener; +import org.apache.catalina.LifecycleState; import org.apache.catalina.connector.Request; import org.apache.catalina.connector.Response; import org.apache.catalina.valves.ValveBase; @@ -92,7 +94,8 @@ public class LogbackValve extends ValveBase implements Lifecycle, Context, return started; } - public void startInternal() { + public void startInternal() throws LifecycleException { + System.out.println("***startInternal() called"); if (filename == null) { String tomcatHomeProperty = OptionHelper .getSystemProperty("catalina.home"); @@ -103,8 +106,10 @@ public class LogbackValve extends ValveBase implements Lifecycle, Context, + "]", this)); } File configFile = new File(filename); + if (configFile.exists()) { try { + System.out.println("***startInternal() JoranConfigurator"); JoranConfigurator jc = new JoranConfigurator(); jc.setContext(this); jc.doConfigure(filename); @@ -122,6 +127,7 @@ public class LogbackValve extends ValveBase implements Lifecycle, Context, } started = true; + setState(LifecycleState.STARTING); } public String getFilename() { @@ -173,8 +179,9 @@ public class LogbackValve extends ValveBase implements Lifecycle, Context, } } - public void stopInternal() { + protected void stopInternal() throws LifecycleException { started = false; + setState(LifecycleState.STOPPING); } public void addAppender(Appender<IAccessEvent> newAppender) { diff --git a/logback-site/src/site/pages/access.html b/logback-site/src/site/pages/access.html index 02a9b4d..3e722d7 100644 --- a/logback-site/src/site/pages/access.html +++ b/logback-site/src/site/pages/access.html @@ -50,16 +50,17 @@ level of a web-application. </p> - <a name="tomcat"></a> - <h1>Logback-access under Tomcat</h1> + <h1><a name="tomcat" href="#tomcat">Logback-access under Tomcat</a></h1> <p>To use logback-access with Tomcat, after downloading the logback distribution, place the files <em>logback-core-${project.version}.jar</em> and <em>logback-access-${project.version}.jar</em> under $TOMCAT_HOME/lib/ directory, where $TOMCAT_HOME is the folder - where you have installed Tomcat. We have tested logback-access - with Tomcat version 6.0.20. + where you have installed Tomcat. This version of logback-access + has been tested with Tomcat version 7.0.21. It will not work with + Tomcat 6.x. However, the target platform for logback-access + version 0.9.30 is Tomcat 6.x. </p> <!-- @@ -157,8 +158,9 @@ under the URL <code>http://host/yourWebapp/lbAccessStatus</code> </p> - <a name="jetty"></a> - <h1>Logback-access under Jetty</h1> + + <h1><a name="jetty" href="#jetty">Logback-access under + Jetty</a></h1> <p>After downloading the logback distribution, place the files <em>logback-core-VERSION.jar</em> and diff --git a/logback-site/src/site/pages/news.html b/logback-site/src/site/pages/news.html index bdda443..7426181 100644 --- a/logback-site/src/site/pages/news.html +++ b/logback-site/src/site/pages/news.html @@ -30,6 +30,11 @@ <h3>... .. , 2011 - Release of version 0.9.31</h3> + <p>The logback-access module now targets Tomcat 7.x and Jetty 7.x + & 8.x as its servlet container platforms. This fixes <a + href="http://jira.qos.ch/browse/LBACCESS-17">LBACCESS-17</a> + reported by Grzegorz Grzybek.</p> + <p>Investigation of <a href="http://jira.qos.ch/browse/LBCORE-224">LBCORE-224</a> reported by Cesar Alvarez Nunez points to bug in the JVM rather http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=958d0a4611b7e10988aa286b… http://github.com/ceki/logback/commit/958d0a4611b7e10988aa286bf317a0d13468e… commit 958d0a4611b7e10988aa286bf317a0d13468ee6b Author: Ceki Gulcu <ceki(a)qos.ch> Date: Fri Sep 30 17:06:54 2011 +0200 minor edits diff --git a/logback-site/src/site/pages/manual/layouts.html b/logback-site/src/site/pages/manual/layouts.html index 7dc55d4..34e9b6b 100644 --- a/logback-site/src/site/pages/manual/layouts.html +++ b/logback-site/src/site/pages/manual/layouts.html @@ -1058,8 +1058,8 @@ Wrapped by: org.springframework.BeanCreationException: Error creating bean with %xException, only the order of exception output is reversed. </p> - <p>Tomek Nurkiewicz, the author of %rootException converter, - documents his creation in a blog entry entitled <a + <p>Tomasz Nurkiewicz, the author of %rootException converter, + documents his contribution in a blog entry entitled <a href="http://nurkiewicz.blogspot.com/2011/09/logging-exceptions-root-cause-first.…">"Logging exceptions root cause first"</a>.</p> </td> ----------------------------------------------------------------------- Summary of changes: .../ch/qos/logback/access/tomcat/LogbackValve.java | 11 +++++++++-- logback-site/src/site/pages/access.html | 14 ++++++++------ logback-site/src/site/pages/manual/layouts.html | 4 ++-- logback-site/src/site/pages/news.html | 5 +++++ 4 files changed, 24 insertions(+), 10 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. v_0.9.30-13-g6b7985e
by git-noreply＠pixie.qos.ch 30 Sep '11

30 Sep '11

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via 6b7985ee8171195dbaf0a4da4dda2099aa428eb8 (commit) from 3e8ea18b3fdd9e4adc9d853216a41022307aa29d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=6b7985ee8171195dbaf0a4da… http://github.com/ceki/logback/commit/6b7985ee8171195dbaf0a4da4dda2099aa428… commit 6b7985ee8171195dbaf0a4da4dda2099aa428eb8 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Fri Sep 30 17:03:17 2011 +0200 - added link to Tomasz blog entry on root first exception printing - updates logback-access and jetty 7 support diff --git a/logback-site/src/site/pages/access.html b/logback-site/src/site/pages/access.html index 2fe4f94..02a9b4d 100644 --- a/logback-site/src/site/pages/access.html +++ b/logback-site/src/site/pages/access.html @@ -164,8 +164,8 @@ <em>logback-core-VERSION.jar</em> and <em>logback-access-VERSION.jar</em> under $JETTY_HOME/lib directory, where $JETTY_HOME is the folder where you have - installed Jetty. Versions of logback-access 0.9.31 and later taget - Jetty version 7.x as well as 8.x. Logback-access versions 0.9.30 + installed Jetty. Versions of logback-access 0.9.31 and later + target Jetty versions 7.x and 8.x. Logback-access versions 0.9.30 and earlier target Jetty version 6.x. </p> @@ -192,19 +192,48 @@ Jetty's main configuration file, namely <em>$JETTY_HOME/etc/jetty.xml</em>: </p> - <pre class="prettyprint source"><Ref id="requestLog"> + <pre class="prettyprint source"><Ref id="RequestLogHandler"> <Set name="requestLog"> - <New id="requestLogImpl" - class="ch.qos.logback.access.jetty.RequestLogImpl"> + <New id="requestLogImpl" class="ch.qos.logback.access.jetty.RequestLogImpl"> </New> </Set> </Ref></pre> - <p>By default, <code>RequestLogImpl</code> looks for a logback - configuration file called <em>logback-access.xml</em>, in the same - folder where <em>jetty.xml</em> is located. This configuration - file contains directives for configuring logback components such - as appenders and layouts. + <p>Please note that the above jetty configuration snippet makes + reference to "RequestLogHandler". Check your jetty.xml + configuration file and add a <code>RequestLogHandler</code> if it + has not been already added. Here is a configuration snipped to set + you on the right tract.</p> + + <pre class="prettyprint source"><Set name="handler"> + <New id="Handlers" class="org.eclipse.jetty.server.handler.HandlerCollection"> + <Set name="handlers"> + <Array type="org.eclipse.jetty.server.Handler"> + <Item> + <New id="Contexts" + class="org.eclipse.jetty.server.handler.ContextHandlerCollection"/> + </Item> + <Item> + <New id="DefaultHandler" + class="org.eclipse.jetty.server.handler.DefaultHandler"/> + </Item> + <b></b> + <b><Item></b> + <b><New id="RequestLogHandler"</b> + <b>class="org.eclipse.jetty.server.handler.RequestLogHandler"/></b> + <b></Item></b> + </Array> + </Set> + </New> +</Set></pre> + + + <p>By default, <code>RequestLogImpl</code> looks + for a logback configuration file called + <em>logback-access.xml</em>, in the same folder where + <em>jetty.xml</em> is located. This configuration file contains + directives for configuring logback components such as appenders + and layouts. </p> <p>As long the path is specified, you can place the logback @@ -213,17 +242,17 @@ configuration file here named <em>myaccess.xml</em>. </p> - <pre class="prettyprint source"><Ref id="requestLog"> + <pre class="prettyprint source"><Ref id="RequestLogHandler"> <Set name="requestLog"> - <New id="requestLogImpl" - class="ch.qos.logback.access.jetty.RequestLogImpl"> - </New> - <Set name="fileName">path/to/myaccess.xml</Set> + <New id="requestLogImpl" class="ch.qos.logback.access.jetty.RequestLogImpl"> + <Set name="fileName">path/to/myaccess.xml</Set> + </New> </Set> </Ref></pre> - <a name="configuration"></a> - <h1>Logback-access configuration</h1> + <h1><a name="configuration" href="#configuration">Logback-access + configuration</a></h1> + <p>Although similar, the format of <em>logback-access.xml</em> configuration file is slightly different than the configuration file diff --git a/logback-site/src/site/pages/manual/layouts.html b/logback-site/src/site/pages/manual/layouts.html index 3e9a025..7dc55d4 100644 --- a/logback-site/src/site/pages/manual/layouts.html +++ b/logback-site/src/site/pages/manual/layouts.html @@ -1057,6 +1057,11 @@ Wrapped by: org.springframework.BeanCreationException: Error creating bean with information. In short, %rootException is very similar to %xException, only the order of exception output is reversed. </p> + + <p>Tomek Nurkiewicz, the author of %rootException converter, + documents his creation in a blog entry entitled <a + href="http://nurkiewicz.blogspot.com/2011/09/logging-exceptions-root-cause-first.…">"Logging + exceptions root cause first"</a>.</p> </td> </tr> ----------------------------------------------------------------------- Summary of changes: logback-site/src/site/pages/access.html | 63 ++++++++++++++++------ logback-site/src/site/pages/manual/layouts.html | 5 ++ 2 files changed, 51 insertions(+), 17 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

Slightly simplified status printing policy
by Ceki Gülcü 30 Sep '11

30 Sep '11

Hello all, I'd like to slightly modify logback's status printing policy. Currently, setting the debug attribute causes status messages to be printed as the last action of the configuration process. However, status messages added after configuration are not printed. One needs to add a OnConsoleStatusListener to have status messages occurring after configuration to be printed on the console. I think it makes sense to modify current debug mode behavior so that it is identical to adding an OnConsoleStatusListener. In case the user sets the debug mode and also adds an OnConsoleStatusListener, debug mode will check to see if an OnConsoleStatusListener was already added and refrain from adding a second (thus avoiding printing status messages twice). It seems that this one of those transparent changes with upsides and no downsides. Anyway, please let me know if you are OK with it. Cheers, -- http://twitter.com/ceki

1 0

LBCLASSIC-289
by Ralph Goers 30 Sep '11

30 Sep '11

I have to admit, I've just never been able to get my head around LogbackMDCAdpater and why it is so complicated. Why did you not choose to just override the childValue method of the InheritableThreadLocal?

1 0

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. v_0.9.30-12-g3e8ea18
by git-noreply＠pixie.qos.ch 28 Sep '11

28 Sep '11

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via 3e8ea18b3fdd9e4adc9d853216a41022307aa29d (commit) from f6b2d46bf4de81cfb3ce14329c41626e037b7b5d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=3e8ea18b3fdd9e4adc9d8532… http://github.com/ceki/logback/commit/3e8ea18b3fdd9e4adc9d853216a41022307aa… commit 3e8ea18b3fdd9e4adc9d853216a41022307aa29d Author: Ceki Gulcu <ceki(a)qos.ch> Date: Wed Sep 28 22:46:04 2011 +0200 blurb on lbcore-224 diff --git a/logback-site/src/site/pages/news.html b/logback-site/src/site/pages/news.html index f41678a..bdda443 100644 --- a/logback-site/src/site/pages/news.html +++ b/logback-site/src/site/pages/news.html @@ -28,8 +28,16 @@ <hr width="80%" align="center" /> - <h3>September 21st, 2011 - Release of version 0.9.30</h3> + <h3>... .. , 2011 - Release of version 0.9.31</h3> + + <p>Investigation of <a + href="http://jira.qos.ch/browse/LBCORE-224">LBCORE-224</a> + reported by Cesar Alvarez Nunez points to bug in the JVM rather + than in logbacl. A workaround has been found by using + <code>CopyOnWriteArrayList</code> instead of the apparently buggy + <code>ReadWriteLock</code>.</p> + <h3>September 21st, 2011 - Release of version 0.9.30</h3> <p>Archive removal can now deal with prolonged periods of application inactivity and application stop and restarts. The ----------------------------------------------------------------------- Summary of changes: logback-site/src/site/pages/news.html | 10 +++++++++- 1 files changed, 9 insertions(+), 1 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0