May 2012 - logback-dev - mailman3.qos.ch

[JIRA] Created: (LBCORE-137) PatternLayout does not really respect ISO8601 for date time
by Brice Dutheil (JIRA) 30 May '12

30 May '12

PatternLayout does not really respect ISO8601 for date time ----------------------------------------------------------- Key: LBCORE-137 URL: http://jira.qos.ch/browse/LBCORE-137 Project: logback-core Issue Type: Improvement Components: Layout Affects Versions: 0.9.19 Environment: irrelevant here Reporter: Brice Dutheil Assignee: Logback dev list Using the default "%d" "%date" or %d{ISO8601} does not output a correct ISO 8601 formatted date and time representation. Indeed there is a space between the date and the time, as the specification says having a space separator means there two fields : a 'date field' and a 'time field'. The specification consider this as acceptable for human reading though. However when processing logs it might cause some trouble to effectively parse the fields, especially when correlating logs from different applications. For now we have workarounds, but it seems reasonable to have a correct ISO8601 formatting. The correct ISO8601 representation for a 'date and time field' is to have the T indicator, for example '2007-03-01T13:00:00Z'. The workaround for now is to write ourself the correct ISO8601 pattern. Oh and by the way the timezone formatting options in the SimpleDateFormat are incomplete. The JodaTime format class org.joda.time.format.ISODateTimeFormat worth a look on this matter. Anyway date and time related classes in the JDK are not known for being the best at what they do. This problem is also found in log4j. An excerpt of the specification is documented on wikipedia. http://en.wikipedia.org/wiki/ISO_8601#Combined_date_and_time_representations -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

3 2

[qos-ch/logback] 5cba8e: LBCLASSIC-225 - Take debug setting from environmen...
by Ceki Gulcu 30 May '12

30 May '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: 5cba8ef5b01a4648fa6e5b404ad62d9f6f5a0cb9 https://github.com/qos-ch/logback/commit/5cba8ef5b01a4648fa6e5b404ad62d9f6f… Author: Antony Stubbs <antony.stubbs(a)gmail.com> Date: 2012-05-22 (Tue, 22 May 2012) Changed paths: M logback-classic/src/main/java/ch/qos/logback/classic/joran/action/ConfigurationAction.java Log Message: ----------- LBCLASSIC-225 - Take debug setting from environment property Commit: ddfe8c3123e96623ed87b4ea50eb5da9e4b87580 https://github.com/qos-ch/logback/commit/ddfe8c3123e96623ed87b4ea50eb5da9e4… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2012-05-30 (Wed, 30 May 2012) Changed paths: M logback-classic/src/main/java/ch/qos/logback/classic/joran/action/ConfigurationAction.java Log Message: ----------- Merge pull request #47 from astubbs/debug LBCLASSIC-225 - Take debug setting from environment property Compare: https://github.com/qos-ch/logback/compare/91317ef...ddfe8c3

1 0

[JIRA] Created: (LBCLASSIC-295) MarkerFilter doesn't recognize nested markers.
by Paolo Mazzoncini (JIRA) 29 May '12

29 May '12

MarkerFilter doesn't recognize nested markers. ---------------------------------------------- Key: LBCLASSIC-295 URL: http://jira.qos.ch/browse/LBCLASSIC-295 Project: logback-classic Issue Type: Bug Components: Other Affects Versions: 0.9.29 Environment: MacOsx, Jdk 1.6 update 26 Reporter: Paolo Mazzoncini Assignee: Logback dev list I was trying to use nested markers to organize my logs in a better (maybe) way. But the MarkerFilter (ch.qos.logback.classic.turbo.MarkerFilter) did not treat nested (or composite) markers as I expect. Here a test that shows this issue, this test can be appended to ch.qos.logback.classic.turbo.MarkerFilterTest: @Test public void testComposite(){ String compositeMarkerName = "compositeMarker"; Marker compositeMarker=MarkerFactory.getMarker(compositeMarkerName); compositeMarker.add(totoMarker); MarkerFilter mkt = new MarkerFilter(); mkt.setMarker(MARKER_NAME); mkt.setOnMatch("ACCEPT"); mkt.setOnMismatch("DENY"); mkt.start(); assertTrue(mkt.isStarted()); assertEquals(FilterReply.DENY, mkt.decide(null, null, null, null, null, null)); assertEquals(FilterReply.ACCEPT, mkt.decide(totoMarker, null, null, null, null, null)); assertEquals(FilterReply.ACCEPT, mkt.decide(compositeMarker, null, null, null, null, null)); } The solution that I found is pretty simple, here is the patch: diff --git a/logback-classic/src/main/java/ch/qos/logback/classic/turbo/MarkerFilter.java b/logback-classic/src/main/java/ch/qos/logback/classic/turbo/MarkerFilter.java index 8e133cb..434b035 100644 --- a/logback-classic/src/main/java/ch/qos/logback/classic/turbo/MarkerFilter.java +++ b/logback-classic/src/main/java/ch/qos/logback/classic/turbo/MarkerFilter.java @@ -47,7 +47,7 @@ public class MarkerFilter extends MatchingFilter { return onMismatch; } - if(markerToMatch.contains(marker)) { + if(marker.contains(markerToMatch)) { return onMatch; } else { return onMismatch; -- 1.7.5.4 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

3 4

[qos-ch/logback] 91317e: added news about LBCLASSIC-295
by Ceki Gulcu 29 May '12

29 May '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: 91317ef14559344543d40df6b2d8f48e9623f0b7 https://github.com/qos-ch/logback/commit/91317ef14559344543d40df6b2d8f48e96… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2012-05-29 (Tue, 29 May 2012) Changed paths: M logback-site/src/site/pages/news.html Log Message: ----------- added news about LBCLASSIC-295

1 0

[qos-ch/logback] 9e0284: fix LBCLASSIC-295
by Ceki Gulcu 29 May '12

29 May '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: 9e0284976cb915f45d5353242b2449d579e4d077 https://github.com/qos-ch/logback/commit/9e0284976cb915f45d5353242b2449d579… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2012-05-29 (Tue, 29 May 2012) Changed paths: M logback-classic/src/main/java/ch/qos/logback/classic/turbo/MarkerFilter.java M logback-classic/src/test/java/ch/qos/logback/classic/turbo/MarkerFilterTest.java Log Message: ----------- fix LBCLASSIC-295

1 0

[qos-ch/logback] bd226d: minor edits
by Ceki Gulcu 29 May '12

29 May '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: bd226d4f0f98c8affccfcb6fd7321fea5f38a55e https://github.com/qos-ch/logback/commit/bd226d4f0f98c8affccfcb6fd7321fea5f… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2012-05-29 (Tue, 29 May 2012) Changed paths: M logback-site/src/site/pages/volunteer.html Log Message: ----------- minor edits

1 0

[qos-ch/logback] 10ed40: added a page calling for volunteers
by Ceki Gulcu 29 May '12

29 May '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: 10ed40fb01ef2d1259c0d77d2351a70cfca19799 https://github.com/qos-ch/logback/commit/10ed40fb01ef2d1259c0d77d2351a70cfc… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2012-05-29 (Tue, 29 May 2012) Changed paths: M logback-site/src/site/pages/templates/left.js A logback-site/src/site/pages/volunteer.html Log Message: ----------- added a page calling for volunteers

1 0

[qos-ch/logback] 46ed32: added link to David Virdefors article
by Ceki Gulcu 29 May '12

29 May '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: 46ed32e259447a06270240316051b70d6d1a6ba7 https://github.com/qos-ch/logback/commit/46ed32e259447a06270240316051b70d6d… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2012-05-29 (Tue, 29 May 2012) Changed paths: M logback-site/src/site/pages/documentation.html Log Message: ----------- added link to David Virdefors article

1 0

[JIRA] (LBCORE-259) Change file input buffer size of 8102 bytes to 8192 bytes in Compressor class
by Shuo Chen (JIRA) 29 May '12

29 May '12

2 1

[qos-ch/logback] c348fb: Fix http://jira.qos.ch/browse/LBCORE-259
by Ceki Gulcu 29 May '12

29 May '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: c348fb63500ed577bb02bd64de134dbdc03c2455 https://github.com/qos-ch/logback/commit/c348fb63500ed577bb02bd64de134dbdc0… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2012-05-29 (Tue, 29 May 2012) Changed paths: M logback-core/src/main/java/ch/qos/logback/core/rolling/helper/Compressor.java Log Message: ----------- Fix http://jira.qos.ch/browse/LBCORE-259

1 0