June 2012 - logback-dev - mailman3.qos.ch

[qos-ch/logback-beagle] 88c247: Resulting ch.qos.logback.beagle-1.0.0.qualifier.ja...
by Ceki Gulcu 05 Jul '12

05 Jul '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback-beagle Commit: 88c247e4cf33991b64ad399786232fc6f3ae7d85 https://github.com/qos-ch/logback-beagle/commit/88c247e4cf33991b64ad3997862… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2012-06-29 (Fri, 29 Jun 2012) Changed paths: M ch.qos.logback.beagle/build.properties Log Message: ----------- Resulting ch.qos.logback.beagle-1.0.0.qualifier.jar now includes requried libs and class files

3 6

[JIRA] Created: (LBCLASSIC-272) Automatic MDC inheritance with thread pools cases false data printed in the log
by Lóránt Pintér (JIRA) 30 Jun '12

30 Jun '12

Automatic MDC inheritance with thread pools cases false data printed in the log ------------------------------------------------------------------------------- Key: LBCLASSIC-272 URL: http://jira.qos.ch/browse/LBCLASSIC-272 Project: logback-classic Issue Type: Bug Components: Other Affects Versions: 0.9.27 Environment: Applies to all Logback versions, specifically tested with Logback 0.9.27. Reporter: Lóránt Pintér Assignee: Logback dev list MDC inheritance when used in conjunction with a thread pool can turn out to be malicious. Consider the following in a web server where each line in the log contains the current user's name. 1. A web request comes in and processing is started on a thread 2. Authenticate the user (on original thread) 3. Put the user name into the MDC (on original thread) 4. Create some Runnable and pass it to a thread pool to be run in the background (on thread pool thread) Let's take a look at the logs that are printed from the Runnable created in step 4. Without automatic MDC inheritance (e.g. when using Log4J) these log lines will contain no user name. This can be good or bad, depending on what you want. If you do want the user name in these log lines, you can explicitly transfer the MDC from the originating thread to the thread pool thread. If you don't want to print the user name for background tasks, you are already done. If you have no access to the thread pool or the Runnables, you simply get no MDC information. However, if you do have automatic MDC inheritance (as with Logback), the log lines *will* contain a user name, but not from the originating thread. The thread pool thread will instead inherit its MDC from the first thread that executed a Runnable on it. This can never be what you want. You can correct this by transferring the original MDC manually, or clearing it explicitly inside your Runnable. But if you forget to do this, or you don't have access to the thread pool and the Runnables, you will end up with corrupt data in your logs. The latter can happen if you are using some third-party API that maintains its own thread pool. I can see two ways to fix this issue: 1) Make automatic MDC inhertance configurable from logback.xml. This is not a perfect solution: if you mix code that relies on MDC inheritance with code that relies on no MDC inheritance you will have no good value for this setting. 2) Remove the automatic MDC inheritance feature altogether. Instead, Logback (or even better: SLF4J) could provide some utility classes to wrap Runnable's and Callable's in something like this: {code} class MdcRetainingRunnable implements Runnable { private final Map context; public MdcRetainingRunnable { this.context = MDC.getCopyOfContextMap(); } @Override public void run() { Map originalContext = MDC.getCopyOfContextMap(); MDC.setContextMap(context); try { runWithMdc(); } finally { MDC.setContextMap(originalContext); } } abstract protected runWithMdc(); } {code} I would prefer solution #2 as it provides for the rule of least astonishment. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

3 4

[qos-ch/logback-beagle] 780eda: enable jump to source functionality
by Ceki Gulcu 28 Jun '12

28 Jun '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback-beagle Commit: 780eda010e983bdd458917a5a4e30a42e28203f1 https://github.com/qos-ch/logback-beagle/commit/780eda010e983bdd458917a5a4e… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2012-06-28 (Thu, 28 Jun 2012) Changed paths: M ch.qos.logback.beagle/META-INF/MANIFEST.MF M ch.qos.logback.beagle/src/ch/qos/logback/beagle/menu/OnMenuSelectionAction.java A ch.qos.logback.beagle/src/ch/qos/logback/beagle/util/EditorUtil.java Log Message: ----------- enable jump to source functionality

1 0

[qos-ch/logback-beagle] 5bb78b: ongoing work
by Ceki Gulcu 28 Jun '12

28 Jun '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback-beagle Commit: 5bb78bd386db9e130e05690e0d71dc976294a2a1 https://github.com/qos-ch/logback-beagle/commit/5bb78bd386db9e130e05690e0d7… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2012-06-28 (Thu, 28 Jun 2012) Changed paths: M ch.qos.logback.beagle/META-INF/MANIFEST.MF A ch.qos.logback.beagle/lib/logback-core-1.0.4.jar A ch.qos.logback.beagle/lib/slf4j-api-1.6.6.jar M ch.qos.logback.beagle/src/ch/qos/logback/beagle/Activator.java M ch.qos.logback.beagle/src/ch/qos/logback/beagle/menu/MenuBuilder.java M ch.qos.logback.beagle/src/ch/qos/logback/beagle/net/LoggingEventSocketReader.java M ch.qos.logback.beagle/src/ch/qos/logback/beagle/net/LoggingEventSocketServer.java M ch.qos.logback.beagle/src/ch/qos/logback/beagle/vista/TableItemSelectionListener.java M ch.qos.logback.beagle/src/ch/qos/logback/beagle/vista/TableSelectionViaMouseMovements.java M ch.qos.logback.beagle/src/ch/qos/logback/beagle/vista/UnfreezeToolItemListener.java Log Message: ----------- ongoing work Commit: 36caff6cb324da3a3227461802e3e822836a4977 https://github.com/qos-ch/logback-beagle/commit/36caff6cb324da3a3227461802e… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2012-06-28 (Thu, 28 Jun 2012) Changed paths: M ch.qos.logback.beagle.feature/feature.xml A ch.qos.logback.beagle.tests/META-INF/MANIFEST.MF A ch.qos.logback.beagle.tests/build.properties A ch.qos.logback.beagle.tests/pom.xml A ch.qos.logback.beagle.tests/src/ch/qos/logback/beagle/tests/FirstTest.java M ch.qos.logback.beagle/build.properties M logback-beagle.target M pom.xml Log Message: ----------- Merge branch 'master' of github.com:qos-ch/logback-beagle Compare: https://github.com/qos-ch/logback-beagle/compare/8c3afb50d226...36caff6cb324

1 0

[JIRA] (LOGBACK-713) DBAppenderBase closes connection-object after each insert
by Heikki Malkamäki (JIRA) 28 Jun '12

28 Jun '12

2 3

[qos-ch/logback-beagle] 8c3afb: beagle.tests plugin introduced.
by Christian Trutz 27 Jun '12

27 Jun '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback-beagle Commit: 8c3afb50d22695651db6cab9c228edad59dd8040 https://github.com/qos-ch/logback-beagle/commit/8c3afb50d22695651db6cab9c22… Author: Christian Trutz <christian.trutz(a)belaso.de> Date: 2012-06-27 (Wed, 27 Jun 2012) Changed paths: M ch.qos.logback.beagle.feature/feature.xml A ch.qos.logback.beagle.tests/META-INF/MANIFEST.MF A ch.qos.logback.beagle.tests/build.properties A ch.qos.logback.beagle.tests/pom.xml A ch.qos.logback.beagle.tests/src/ch/qos/logback/beagle/tests/FirstTest.java M ch.qos.logback.beagle/build.properties M logback-beagle.target M pom.xml Log Message: ----------- beagle.tests plugin introduced. Signed-off-by: Christian Trutz <christian.trutz(a)belaso.de>

1 0

[JIRA] (LOGBACK-715) enhancing DuplicateMessageFilter
by Kevin Ding (JIRA) 27 Jun '12

27 Jun '12

1 0

[qos-ch/logback-beagle] d71bf3: Removing beagle.core.
by Christian Trutz 27 Jun '12

27 Jun '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback-beagle Commit: d71bf301038a0631b816f8fff97df4c82b1666c9 https://github.com/qos-ch/logback-beagle/commit/d71bf301038a0631b816f8fff97… Author: Christian Trutz <christian.trutz(a)belaso.de> Date: 2012-06-27 (Wed, 27 Jun 2012) Changed paths: R ch.qos.logback.beagle.core/META-INF/MANIFEST.MF R ch.qos.logback.beagle.core/build.properties R ch.qos.logback.beagle.core/icons/obj16/sailing-ship-16x16.png R ch.qos.logback.beagle.core/plugin.xml R ch.qos.logback.beagle.core/pom.xml R ch.qos.logback.beagle.core/src/ch/qos/logback/beagle/core/Activator.java R ch.qos.logback.beagle.core/src/ch/qos/logback/beagle/core/net/LoggingEventSocketReader.java R ch.qos.logback.beagle.core/src/ch/qos/logback/beagle/core/net/LoggingEventSocketServer.java R ch.qos.logback.beagle.core/src/ch/qos/logback/beagle/core/net/Messages.java R ch.qos.logback.beagle.core/src/ch/qos/logback/beagle/core/net/messages.properties R ch.qos.logback.beagle.core/src/ch/qos/logback/beagle/core/view/BeagleView.java M ch.qos.logback.beagle/src/ch/qos/logback/beagle/views/BeagleView.java Log Message: ----------- Removing beagle.core. Signed-off-by: Christian Trutz <christian.trutz(a)belaso.de>

1 0

[qos-ch/logback-beagle] 1cc628: BeagleView clean up and prepare beagle.core remove...
by Christian Trutz 27 Jun '12

27 Jun '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback-beagle Commit: 1cc628efb18fdc5f85da1ca2b0f4ae962b0a4678 https://github.com/qos-ch/logback-beagle/commit/1cc628efb18fdc5f85da1ca2b0f… Author: Christian Trutz <christian.trutz(a)belaso.de> Date: 2012-06-27 (Wed, 27 Jun 2012) Changed paths: M ch.qos.logback.beagle/src/ch/qos/logback/beagle/views/BeagleView.java M pom.xml Log Message: ----------- BeagleView clean up and prepare beagle.core remove. Signed-off-by: Christian Trutz <christian.trutz(a)belaso.de>

1 0

[qos-ch/logback-beagle] 26d3df: ch.qos.logback.beagle can receive messages from So...
by Ceki Gulcu 27 Jun '12

27 Jun '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback-beagle Commit: 26d3df7ab8934a85fb7a8ff81adb1908a63f9cdb https://github.com/qos-ch/logback-beagle/commit/26d3df7ab8934a85fb7a8ff81ad… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2012-06-27 (Wed, 27 Jun 2012) Changed paths: M ch.qos.logback.beagle/build.properties R ch.qos.logback.beagle/icons/2windows.png R ch.qos.logback.beagle/icons/book_open.png A ch.qos.logback.beagle/icons/ch/qos/logback/beagle/icons/2windows.png A ch.qos.logback.beagle/icons/ch/qos/logback/beagle/icons/book_open.png A ch.qos.logback.beagle/icons/ch/qos/logback/beagle/icons/cog_add.png A ch.qos.logback.beagle/icons/ch/qos/logback/beagle/icons/cog_delete.png A ch.qos.logback.beagle/icons/ch/qos/logback/beagle/icons/copy-16x16.png A ch.qos.logback.beagle/icons/ch/qos/logback/beagle/icons/copy.png A ch.qos.logback.beagle/icons/ch/qos/logback/beagle/icons/error-circle.png A ch.qos.logback.beagle/icons/ch/qos/logback/beagle/icons/flag_orange.png A ch.qos.logback.beagle/icons/ch/qos/logback/beagle/icons/flag_red.png A ch.qos.logback.beagle/icons/ch/qos/logback/beagle/icons/home-16x16.png A ch.qos.logback.beagle/icons/ch/qos/logback/beagle/icons/icons.ai A ch.qos.logback.beagle/icons/ch/qos/logback/beagle/icons/icons.png A ch.qos.logback.beagle/icons/ch/qos/logback/beagle/icons/layout_add.png A ch.qos.logback.beagle/icons/ch/qos/logback/beagle/icons/layout_delete.png A ch.qos.logback.beagle/icons/ch/qos/logback/beagle/icons/lightbulb_add.png A ch.qos.logback.beagle/icons/ch/qos/logback/beagle/icons/lightbulb_delete.png A ch.qos.logback.beagle/icons/ch/qos/logback/beagle/icons/lightning_add.png A ch.qos.logback.beagle/icons/ch/qos/logback/beagle/icons/lightning_delete.png A ch.qos.logback.beagle/icons/ch/qos/logback/beagle/icons/play.gif A ch.qos.logback.beagle/icons/ch/qos/logback/beagle/icons/play_doc.gif A ch.qos.logback.beagle/icons/ch/qos/logback/beagle/icons/preview-16x16.png A ch.qos.logback.beagle/icons/ch/qos/logback/beagle/icons/sailing-ship-16x16.png A ch.qos.logback.beagle/icons/ch/qos/logback/beagle/icons/sample.gif A ch.qos.logback.beagle/icons/ch/qos/logback/beagle/icons/skull.png A ch.qos.logback.beagle/icons/ch/qos/logback/beagle/icons/zip_file_search.png R ch.qos.logback.beagle/icons/cog_add.png R ch.qos.logback.beagle/icons/cog_delete.png R ch.qos.logback.beagle/icons/copy-16x16.png R ch.qos.logback.beagle/icons/copy.png R ch.qos.logback.beagle/icons/error-circle.png R ch.qos.logback.beagle/icons/flag_orange.png R ch.qos.logback.beagle/icons/flag_red.png R ch.qos.logback.beagle/icons/home-16x16.png R ch.qos.logback.beagle/icons/icons.ai R ch.qos.logback.beagle/icons/icons.png R ch.qos.logback.beagle/icons/layout_add.png R ch.qos.logback.beagle/icons/layout_delete.png R ch.qos.logback.beagle/icons/lightbulb_add.png R ch.qos.logback.beagle/icons/lightbulb_delete.png R ch.qos.logback.beagle/icons/lightning_add.png R ch.qos.logback.beagle/icons/lightning_delete.png R ch.qos.logback.beagle/icons/play.gif R ch.qos.logback.beagle/icons/play_doc.gif R ch.qos.logback.beagle/icons/preview-16x16.png R ch.qos.logback.beagle/icons/sailing-ship-16x16.png R ch.qos.logback.beagle/icons/sample.gif R ch.qos.logback.beagle/icons/skull.png R ch.qos.logback.beagle/icons/zip_file_search.png M ch.qos.logback.beagle/plugin.xml M ch.qos.logback.beagle/src/ch/qos/logback/beagle/Activator.java A ch.qos.logback.beagle/src/ch/qos/logback/beagle/net/LoggingEventSocketReader.java A ch.qos.logback.beagle/src/ch/qos/logback/beagle/net/LoggingEventSocketServer.java M ch.qos.logback.beagle/src/ch/qos/logback/beagle/util/ResourceUtil.java M ch.qos.logback.beagle/src/ch/qos/logback/beagle/views/BeagleView.java M ch.qos.logback.beagle/src/ch/qos/logback/beagle/vista/MySupplierThread.java M ch.qos.logback.beagle/src/ch/qos/logback/beagle/vista/TableControlListener.java M ch.qos.logback.beagle/src/ch/qos/logback/beagle/vista/TableMediator.java Log Message: ----------- ch.qos.logback.beagle can receive messages from SocketAppender

1 0