April 2013 - logback-dev - mailman3.qos.ch

[qos-ch/logback] 649710: ServerSocketAppenderBase now uses ExecutorService ...
by Carl Harris 04 Apr '13

04 Apr '13

Branch: refs/heads/useContextExecutorService Home: https://github.com/qos-ch/logback Commit: 64971049c80e8700506373b2fbb65541a704436e https://github.com/qos-ch/logback/commit/64971049c80e8700506373b2fbb65541a7… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M logback-core/src/main/java/ch/qos/logback/core/net/server/ServerSocketAppenderBase.java Log Message: ----------- ServerSocketAppenderBase now uses ExecutorService from context If the appender does not have a thread pool configuration, we now use the context's ExecutorService instead of creating a new one based on the default ThreadPoolConfiguration. Commit: 9e06b6be7e6bace591dac20373a51eed59264ad2 https://github.com/qos-ch/logback/commit/9e06b6be7e6bace591dac20373a51eed59… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M logback-core/src/test/java/ch/qos/logback/core/net/server/InstrumentedServerSocketAppenderBase.java A logback-core/src/test/java/ch/qos/logback/core/net/server/MockExecutorService.java R logback-core/src/test/java/ch/qos/logback/core/net/server/MockThreadPoolFactoryBean.java M logback-core/src/test/java/ch/qos/logback/core/net/server/ServerSocketAppenderBaseTest.java Log Message: ----------- updated tests to validate that context's executor is not shut down In ServerSocketAppenderBase.stop, we must not shut down the executor service if it is the context's executorService. We only shut down an executor that we created specifically for this appender. Commit: e84874634c30889af380671811345fba4ab15dd2 https://github.com/qos-ch/logback/commit/e84874634c30889af380671811345fba4a… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M logback-classic/src/main/java/ch/qos/logback/classic/net/SocketRemote.java Log Message: ----------- SocketRemote now uses ExecutorService from context The SocketRemote component doesn't want/need to allow the user to provide a thread pool configuration, anyway, so we might as well use the executor service provided by the context instead of creating our own. Commit: bbd4100e30cd6b2fbd5fce80bf6031fd6ae0e4ad https://github.com/qos-ch/logback/commit/bbd4100e30cd6b2fbd5fce80bf6031fd6a… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M logback-classic/src/test/java/ch/qos/logback/classic/net/SocketRemoteTest.java Log Message: ----------- modified SocketRemoteTest to validate executor service shutdown behavior If a subclass provides a custom executor, we want to shut it down, but if the context's executor is used, we must not shut it down. The revised test covers both cases. Commit: d35ea443e333486a69506a8ff660071790d819bf https://github.com/qos-ch/logback/commit/d35ea443e333486a69506a8ff660071790… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M logback-classic/src/main/java/ch/qos/logback/classic/net/server/SocketServer.java Log Message: ----------- SocketServer now uses ExecutorService from context If the server has no thread pool configuration, the context's executor service is now used by default. Compare: https://github.com/qos-ch/logback/compare/64971049c80e^...d35ea443e333

1 0

[qos-ch/logback] c686f8: now SocketServer uses the injected context
by Carl Harris 04 Apr '13

04 Apr '13

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: c686f86d40f5616d9e87dbe81f16f3d0750113df https://github.com/qos-ch/logback/commit/c686f86d40f5616d9e87dbe81f16f3d075… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M logback-classic/src/main/java/ch/qos/logback/classic/net/server/RemoteAppenderServerRunner.java Log Message: ----------- now SocketServer uses the injected context The context injected by logback into SocketServer is subsequently injected into RemoteAppenderServerRunner. The runner simply casts it to LoggerContext before injecting it into the client object. Commit: 9286f5f9778b833bc6db1a89e171cef23b5a4f22 https://github.com/qos-ch/logback/commit/9286f5f9778b833bc6db1a89e171cef23b… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M logback-core/src/test/java/ch/qos/logback/core/net/SocketConnectorBaseTest.java Log Message: ----------- further reduced system timing sensitivity in SocketConnectorBase When testing the exception reported by SocketConnectorBase after a connection failure, the test now uses lock and associated condition to avoid synchronization issues. Commit: f45134c57f632b32983ea35b5426f31adb78754b https://github.com/qos-ch/logback/commit/f45134c57f632b32983ea35b5426f31adb… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M logback-core/src/test/java/ch/qos/logback/core/spi/AppenderAttachableImplLockTest.java M logback-site/src/site/pages/news.html M logback-site/src/site/pages/setup.html Log Message: ----------- Merge branch 'master' of github.com:qos-ch/logback Compare: https://github.com/qos-ch/logback/compare/5953f9d9f83b...f45134c57f63

1 0

[qos-ch/logback] 9286f5: further reduced system timing sensitivity in Socke...
by Carl Harris 04 Apr '13

04 Apr '13

Branch: refs/heads/socketConnectorTestBrokenInJenkins Home: https://github.com/qos-ch/logback Commit: 9286f5f9778b833bc6db1a89e171cef23b5a4f22 https://github.com/qos-ch/logback/commit/9286f5f9778b833bc6db1a89e171cef23b… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M logback-core/src/test/java/ch/qos/logback/core/net/SocketConnectorBaseTest.java Log Message: ----------- further reduced system timing sensitivity in SocketConnectorBase When testing the exception reported by SocketConnectorBase after a connection failure, the test now uses lock and associated condition to avoid synchronization issues.

1 0

[qos-ch/logback] c686f8: now SocketServer uses the injected context
by Carl Harris 04 Apr '13

04 Apr '13

Branch: refs/heads/socketConnectorTestBrokenInJenkins Home: https://github.com/qos-ch/logback Commit: c686f86d40f5616d9e87dbe81f16f3d0750113df https://github.com/qos-ch/logback/commit/c686f86d40f5616d9e87dbe81f16f3d075… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M logback-classic/src/main/java/ch/qos/logback/classic/net/server/RemoteAppenderServerRunner.java Log Message: ----------- now SocketServer uses the injected context The context injected by logback into SocketServer is subsequently injected into RemoteAppenderServerRunner. The runner simply casts it to LoggerContext before injecting it into the client object.

1 0

[qos-ch/logback]
by ceharris 04 Apr '13

04 Apr '13

Branch: refs/heads/serverSocketUseInjectedContext Home: https://github.com/qos-ch/logback

1 0

[qos-ch/logback] 5953f9: updated documentation for simplified scala-less bu...
by Ceki Gulcu 04 Apr '13

04 Apr '13

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: 5953f9d9f83b84c9a89d6c26ed9188c496038b49 https://github.com/qos-ch/logback/commit/5953f9d9f83b84c9a89d6c26ed9188c496… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M logback-core/src/test/java/ch/qos/logback/core/spi/AppenderAttachableImplLockTest.java M logback-site/src/site/pages/news.html M logback-site/src/site/pages/setup.html Log Message: ----------- updated documentation for simplified scala-less build, increased timeout in AppenderAttachableImplLockTest

1 0

[qos-ch/logback] 844a31: work in progress on documentation of SocketRemote/...
by Carl Harris 04 Apr '13

04 Apr '13

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: 844a31029d70891c3e21128a787c15db25b8f5b3 https://github.com/qos-ch/logback/commit/844a31029d70891c3e21128a787c15db25… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M logback-site/src/site/pages/manual/appenders.html Log Message: ----------- work in progress on documentation of SocketRemote/ServerSocketAppender Committing before moving to a clone of qos-ch/logback instead of my fork. Commit: 5c1a989de3bedea2df1c7203aeda70349109a3aa https://github.com/qos-ch/logback/commit/5c1a989de3bedea2df1c7203aeda703491… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M logback-site/src/site/pages/manual/appenders.html Log Message: ----------- Merge pull request #106 from ceharris/LOGBACK-826-documentation work in progress on documentation of SocketRemote/ServerSocketAppender Compare: https://github.com/qos-ch/logback/compare/216b1c50c97b...5c1a989de3be

1 0

[qos-ch/logback] 67b0bf: removed some assertions that were not critical
by Carl Harris 04 Apr '13

04 Apr '13

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: 67b0bfe95d7fdde56d925b779eae9151650d7a55 https://github.com/qos-ch/logback/commit/67b0bfe95d7fdde56d925b779eae915165… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M logback-classic/src/test/java/ch/qos/logback/classic/net/SocketRemoteTest.java Log Message: ----------- removed some assertions that were not critical The test was system timing sensitive due to testing some assertions on fields without proper synchronization. The assertions themselves were not especially critical, and adding the synchronization would have added significant complexity, so the assertions were removed. Commit: 216b1c50c97b67e83faff4dac2d3e2d5f95a5758 https://github.com/qos-ch/logback/commit/216b1c50c97b67e83faff4dac2d3e2d5f9… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M logback-classic/src/test/java/ch/qos/logback/classic/net/SocketRemoteTest.java Log Message: ----------- Merge pull request #105 from ceharris/socketRemoteTestBrokenOnJenkins removed some assertions that were not critical Compare: https://github.com/qos-ch/logback/compare/94ff6ef07ad4...216b1c50c97b

1 0

[qos-ch/logback] e9c22d: reduce system timing sensitivity in SocketConnecto...
by Carl Harris 04 Apr '13

04 Apr '13

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: e9c22dea08430b6d07381c84cbe8b0f125998d15 https://github.com/qos-ch/logback/commit/e9c22dea08430b6d07381c84cbe8b0f125… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M logback-core/src/test/java/ch/qos/logback/core/net/SocketConnectorBaseTest.java Log Message: ----------- reduce system timing sensitivity in SocketConnectorBaseTest Now using a larger delay tolerance and additional Thread.join calls to give the connector thread time to exit before testing assertions that it did exit properly. Commit: 94ff6ef07ad426707f8e1d575a11b5b72548bc1d https://github.com/qos-ch/logback/commit/94ff6ef07ad426707f8e1d575a11b5b725… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M logback-core/src/test/java/ch/qos/logback/core/net/SocketConnectorBaseTest.java Log Message: ----------- Merge pull request #104 from ceharris/socketConnectorTestBrokenOnJenkins reduce system timing sensitivity in SocketConnectorBaseTest Compare: https://github.com/qos-ch/logback/compare/ca243ac077eb...94ff6ef07ad4

1 0

[qos-ch/logback] a61b9b: added SocketRemote error codes
by Carl Harris 04 Apr '13

04 Apr '13

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: a61b9b6edba6e3f243b689de8fd77e1b4b13de0c https://github.com/qos-ch/logback/commit/a61b9b6edba6e3f243b689de8fd77e1b4b… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M logback-site/src/site/pages/codes.html Log Message: ----------- added SocketRemote error codes Commit: 81de31593cf74dd774fd95921c84b384dcc25f59 https://github.com/qos-ch/logback/commit/81de31593cf74dd774fd95921c84b384dc… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M logback-site/src/site/pages/manual/appenders.html Log Message: ----------- minor edit of SSLSocketServer documentation Commit: 6752b13be8b510f5e383c3c47ffd48508f86aec0 https://github.com/qos-ch/logback/commit/6752b13be8b510f5e383c3c47ffd48508f… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M logback-examples/src/main/java/chapters/appenders/socket/remoteClient.xml M logback-examples/src/main/java/chapters/appenders/socket/ssl/remoteClient.xml Log Message: ----------- use encoder instead of layout in SocketRemote examples Other example configurations using layout remain and need the same treatment. Commit: f9d9a6c330052e91fd2b3775a707c852a40f0e11 https://github.com/qos-ch/logback/commit/f9d9a6c330052e91fd2b3775a707c852a4… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M logback-examples/src/main/java/chapters/appenders/socket/remoteClient.xml M logback-examples/src/main/java/chapters/appenders/socket/ssl/remoteClient.xml Log Message: ----------- changed reconnectionDelay to 10000 in SocketRemote examples Commit: ca243ac077eb32ef0bfb26a3789310b8aa4c0f40 https://github.com/qos-ch/logback/commit/ca243ac077eb32ef0bfb26a3789310b8aa… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M logback-examples/src/main/java/chapters/appenders/socket/remoteClient.xml M logback-examples/src/main/java/chapters/appenders/socket/ssl/remoteClient.xml M logback-site/src/site/pages/codes.html M logback-site/src/site/pages/manual/appenders.html Log Message: ----------- Merge pull request #103 from ceharris/LOGBACK-826-documentation LOGBACK-826: work in progress on documentation Compare: https://github.com/qos-ch/logback/compare/798cacfbc6f1...ca243ac077eb

1 0