May 2013 - logback-dev - mailman3.qos.ch

[qos-ch/logback] 91b953: no need to wait 10s for the runner to enter runSta...
by Ceki Gulcu 01 May '13

01 May '13

Branch: refs/heads/LOGBACK-848 Home: https://github.com/qos-ch/logback Commit: 91b953adfd962187d141b167b19786bc2c547369 https://github.com/qos-ch/logback/commit/91b953adfd962187d141b167b19786bc2c… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2013-05-01 (Wed, 01 May 2013) Changed paths: M logback-core/src/test/java/ch/qos/logback/core/net/server/ConcurrentServerRunnerTest.java Log Message: ----------- no need to wait 10s for the runner to enter runState

1 0

[qos-ch/logback] 92a764: use an asynchronous ExecutorService in SSLServerSo...
by Carl Harris 01 May '13

01 May '13

Branch: refs/heads/LOGBACK-848 Home: https://github.com/qos-ch/logback Commit: 92a764529d7f068e7bb4db8c581866434a3216d2 https://github.com/qos-ch/logback/commit/92a764529d7f068e7bb4db8c581866434a… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-05-01 (Wed, 01 May 2013) Changed paths: M logback-core/src/test/java/ch/qos/logback/core/net/server/SSLServerSocketAppenderBaseTest.java Log Message: ----------- use an asynchronous ExecutorService in SSLServerSocketAppenderBaseTest

1 0

[qos-ch/logback] 6e81e1: add an appender.stop() statement
by Ceki Gulcu 01 May '13

01 May '13

Branch: refs/heads/LOGBACK-848 Home: https://github.com/qos-ch/logback Commit: 6e81e1ef7b2217038ff861c484608553ead72928 https://github.com/qos-ch/logback/commit/6e81e1ef7b2217038ff861c484608553ea… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2013-05-01 (Wed, 01 May 2013) Changed paths: M logback-core/src/test/java/ch/qos/logback/core/net/server/SSLServerSocketAppenderBaseTest.java Log Message: ----------- add an appender.stop() statement

1 0

[qos-ch/logback] 37ba9c: stop the appender in SSLSocketAppenderBaseTest
by Carl Harris 01 May '13

01 May '13

Branch: refs/heads/LOGBACK-848 Home: https://github.com/qos-ch/logback Commit: 37ba9c14b19f6e837f3aae1536f9a5a5c2a2b222 https://github.com/qos-ch/logback/commit/37ba9c14b19f6e837f3aae1536f9a5a5c2… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-05-01 (Wed, 01 May 2013) Changed paths: M logback-core/src/test/java/ch/qos/logback/core/net/SSLSocketAppenderBaseTest.java Log Message: ----------- stop the appender in SSLSocketAppenderBaseTest Since the appender now has some an asynchronous task, this is a best practice. Moreover, some test runners may not be able to terminate properly if there are non-daemon threads remaining in the JVM.

1 0

[qos-ch/logback] 905d4d: added PackagetTest classes to facilitate launch fr...
by Ceki Gulcu 01 May '13

01 May '13

Branch: refs/heads/LOGBACK-848 Home: https://github.com/qos-ch/logback Commit: 905d4d285ce7fe355b22a61408219ed34487704c https://github.com/qos-ch/logback/commit/905d4d285ce7fe355b22a61408219ed344… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2013-05-01 (Wed, 01 May 2013) Changed paths: M logback-core/src/main/java/ch/qos/logback/core/net/server/RemoteReceiverStreamClient.java M logback-core/src/test/java/ch/qos/logback/core/AllCoreTest.java A logback-core/src/test/java/ch/qos/logback/core/net/PackageTest.java A logback-core/src/test/java/ch/qos/logback/core/net/server/PackageTest.java A logback-core/src/test/java/ch/qos/logback/core/net/ssl/PackageTest.java Log Message: ----------- added PackagetTest classes to facilitate launch from IDE

1 0

naming conventions
by ceki 01 May '13

01 May '13

Hi all, In the future, I'd like to follow the convention described at [1] by Jarrod Roberson. Regarding the I-prefix for interfaces, IAccessEvent and ILoggingEvent are 'I'-prefixed interfaces that are in wide use and cannot be modified. IEvaluator should be possible to change since it's an internal interface used by GEventEvaluator. Whenever possible, abstract classes ending the 'Base' suffix should be prefixed with 'Abstract' instead. AppenderBase is in wide usage and cannot be changed to AbstractAppender. A non-abstract implementation of interface X should be named in a descriptive way as appropriate for that specific implementation. Release 1.1.0 might be a good time to implement said naming conventions. Cheers, [1] http://stackoverflow.com/a/2814831/100970 -- Ceki 65% of statistics are made up on the spot

1 0

[qos-ch/logback] b9e60b: exit from SocketReceiver.run when executor rejects...
by Carl Harris 01 May '13

01 May '13

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: b9e60b216908987a521170ff2aebb094ba29de6e https://github.com/qos-ch/logback/commit/b9e60b216908987a521170ff2aebb094ba… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-05-01 (Wed, 01 May 2013) Changed paths: M logback-classic/src/main/java/ch/qos/logback/classic/net/SocketReceiver.java Log Message: ----------- exit from SocketReceiver.run when executor rejects a task Previously, we exited only when interrupted. But if the executor is shutting down, there's no reason for the receiver to try to continue running. This was a left over from when the receiver had its own executor service, and ExecutorService.shutdownNow was used to shut it down on stop().

1 0

[qos-ch/logback] 42a929: exit SocketConnectorBase.run when executor rejects...
by Carl Harris 01 May '13

01 May '13

Branch: refs/heads/LOGBACK-848 Home: https://github.com/qos-ch/logback Commit: 42a929e76eefd3af1a1a27b41fb5b6f7e34a1fcc https://github.com/qos-ch/logback/commit/42a929e76eefd3af1a1a27b41fb5b6f7e3… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-05-01 (Wed, 01 May 2013) Changed paths: M logback-core/src/main/java/ch/qos/logback/core/net/SocketAppenderBase.java Log Message: ----------- exit SocketConnectorBase.run when executor rejects a task Previously, exited only on interrupt, but if the executor is shutting down, there's no reason for us to wait to be interrupted.

1 0

[qos-ch/logback] 55602a: illustrates that line 62 in ExecutorServiceUtil wi...
by Carl Harris 01 May '13

01 May '13

Branch: refs/heads/LOGBACK-848 Home: https://github.com/qos-ch/logback Commit: 55602a4e2a43d098f7d38257fb605e764f296d90 https://github.com/qos-ch/logback/commit/55602a4e2a43d098f7d38257fb605e764f… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2013-04-30 (Tue, 30 Apr 2013) Changed paths: A logback-core/src/test/java/ch/qos/logback/core/issue/LOGBACK_849/Basic.java Log Message: ----------- illustrates that line 62 in ExecutorServiceUtil will never be reached Commit: 371e1338414db4075f0a4ef06f4388cca4b77f1f https://github.com/qos-ch/logback/commit/371e1338414db4075f0a4ef06f4388cca4… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-05-01 (Wed, 01 May 2013) Changed paths: M logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java M logback-core/src/main/java/ch/qos/logback/core/ContextBase.java M logback-core/src/main/java/ch/qos/logback/core/util/ExecutorServiceUtil.java Log Message: ----------- removed awaitTermination and related noise from ExecutorServiceUtil ExecutorService.shutdownNow returns the list of jobs that never executed, not the list of jobs that didn't terminate. Commit: 94808311d3033e51f20152dd9a823d7db5d11214 https://github.com/qos-ch/logback/commit/94808311d3033e51f20152dd9a823d7db5… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-05-01 (Wed, 01 May 2013) Changed paths: M logback-core/src/main/java/ch/qos/logback/core/CoreConstants.java Log Message: ----------- added missing final in from what should have been a constant Commit: c8c2109f7d635e46617c7a5dec096cf1133ecfe3 https://github.com/qos-ch/logback/commit/c8c2109f7d635e46617c7a5dec096cf113… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-05-01 (Wed, 01 May 2013) Changed paths: M logback-core/src/test/java/ch/qos/logback/core/issue/LOGBACK_849/Basic.java Log Message: ----------- removed unneeded parameter after ExecutorServiceUtil refactoring Commit: 631cd7edfb6a59c44c684a9f1fe5ba4f880fb91f https://github.com/qos-ch/logback/commit/631cd7edfb6a59c44c684a9f1fe5ba4f88… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-05-01 (Wed, 01 May 2013) Changed paths: M logback-core/src/main/java/ch/qos/logback/core/CoreConstants.java Log Message: ----------- removed unused constant Commit: 3bb4d53a3a8b1ab33fa7d78113e007a96a2d3c6c https://github.com/qos-ch/logback/commit/3bb4d53a3a8b1ab33fa7d78113e007a96a… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-05-01 (Wed, 01 May 2013) Changed paths: M logback-core/src/test/java/ch/qos/logback/core/issue/LOGBACK_849/Basic.java Log Message: ----------- removed references to removed constant Commit: a3b532b6c1af771e0c38346267d6b4f73c61b06d https://github.com/qos-ch/logback/commit/a3b532b6c1af771e0c38346267d6b4f73c… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-05-01 (Wed, 01 May 2013) Changed paths: M logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java M logback-core/src/main/java/ch/qos/logback/core/ContextBase.java M logback-core/src/main/java/ch/qos/logback/core/CoreConstants.java M logback-core/src/main/java/ch/qos/logback/core/util/ExecutorServiceUtil.java A logback-core/src/test/java/ch/qos/logback/core/issue/LOGBACK_849/Basic.java Log Message: ----------- Merge remote-tracking branch 'origin/master' into LOGBACK-848 Compare: https://github.com/qos-ch/logback/compare/43e7693e8d34...a3b532b6c1af

1 0

[qos-ch/logback] 3bb4d5: removed references to removed constant
by Carl Harris 01 May '13

01 May '13

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: 3bb4d53a3a8b1ab33fa7d78113e007a96a2d3c6c https://github.com/qos-ch/logback/commit/3bb4d53a3a8b1ab33fa7d78113e007a96a… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-05-01 (Wed, 01 May 2013) Changed paths: M logback-core/src/test/java/ch/qos/logback/core/issue/LOGBACK_849/Basic.java Log Message: ----------- removed references to removed constant

1 0