February 2018 - logback-dev

[JIRA] (LOGBACK-1382) AsyncAppender#putUninterruptibly may loop forever
by QOS.CH (JIRA) 15 Feb '18

15 Feb '18

1 0

[JIRA] (LOGBACK-1382) AsyncAppender#putUninterruptibly looks suspicious
by QOS.CH (JIRA) 15 Feb '18

15 Feb '18

Gérald Quintana created LOGBACK-1382: ---------------------------------------- Summary: AsyncAppender#putUninterruptibly looks suspicious Key: LOGBACK-1382 URL: https://jira.qos.ch/browse/LOGBACK-1382 Project: logback Issue Type: Task Components: logback-core Affects Versions: 1.2.3 Environment: The code in AsyncAppenderBase#putUninterruptibly is suspicious, if InterruptedException is raised in blockingQueue.put(...), the interrupted flag is set to true but as there is a while(true) around the current Thread will not be interrupted and the code in the finally block may never occur. {code:java} private void putUninterruptibly(E eventObject) { boolean interrupted = false; try { while (true) { try { blockingQueue.put(eventObject); break; } catch (InterruptedException e) { interrupted = true; } } } finally { if (interrupted) { Thread.currentThread().interrupt(); } } } {code} What's the purpose of this infinite loop? I suspect the intent was to write while(!interrupted&&!pushed) instead of while(true). To me, the blockingQueue.put is a blocking operation, the current thread will wait until it can push the event in the queue. Attempting multiple retries seems useless and dangerous to me. Reporter: Gérald Quintana Assignee: Logback dev list -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[qos-ch/logback] 0f3261: ongoing work on model based configuration
by Ceki Gulcu 14 Feb '18

14 Feb '18

Branch: refs/heads/configModel Home: https://github.com/qos-ch/logback Commit: 0f32610d7e2481bdfd359833d846d473171fc847 https://github.com/qos-ch/logback/commit/0f32610d7e2481bdfd359833d846d47317… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2018-02-14 (Wed, 14 Feb 2018) Changed paths: M logback-classic/src/main/java/ch/qos/logback/classic/joran/JoranConfigurator.java M logback-classic/src/main/java/ch/qos/logback/classic/joran/action/ConfigurationAction.java A logback-classic/src/main/java/ch/qos/logback/classic/model/ConfigurationModel.java A logback-classic/src/main/java/ch/qos/logback/classic/model/processor/ConfigurationModelHandler.java M logback-core/src/main/java/ch/qos/logback/core/model/processor/DefaultProcessor.java M logback-core/src/main/java/ch/qos/logback/core/model/processor/ModelHandlerBase.java M logback-core/src/main/java/ch/qos/logback/core/model/processor/ShutdownHookModelHandler.java M logback-core/src/main/java/ch/qos/logback/core/model/processor/TimestampModelHandler.java M logback-core/src/main/java/module-info.java Log Message: ----------- ongoing work on model based configuration

1 0

[qos-ch/logback] f96e5f: continued work on model migration
by Ceki Gulcu 14 Feb '18

14 Feb '18

Branch: refs/heads/configModel Home: https://github.com/qos-ch/logback Commit: f96e5f24167aaef1e640a4416b9141f334a77ebe https://github.com/qos-ch/logback/commit/f96e5f24167aaef1e640a4416b9141f334… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2018-02-14 (Wed, 14 Feb 2018) Changed paths: M logback-core/src/main/java/ch/qos/logback/core/joran/GenericConfigurator.java M logback-core/src/main/java/ch/qos/logback/core/joran/JoranConfiguratorBase.java M logback-core/src/main/java/ch/qos/logback/core/joran/action/NestedBasicPropertyIA.java M logback-core/src/main/java/ch/qos/logback/core/joran/action/NestedComplexPropertyIA.java M logback-core/src/main/java/ch/qos/logback/core/joran/action/PropertyAction.java M logback-core/src/main/java/ch/qos/logback/core/joran/action/TimestampAction.java M logback-core/src/main/java/ch/qos/logback/core/joran/spi/InterpretationContext.java A logback-core/src/main/java/ch/qos/logback/core/model/TimestampModel.java M logback-core/src/main/java/ch/qos/logback/core/model/processor/DefaultProcessor.java M logback-core/src/main/java/ch/qos/logback/core/model/processor/ModelHandlerBase.java M logback-core/src/main/java/ch/qos/logback/core/model/processor/PropertyModelHandler.java M logback-core/src/main/java/ch/qos/logback/core/model/processor/ShutdownHookModelHandler.java A logback-core/src/main/java/ch/qos/logback/core/model/processor/TimestampModelHandler.java M logback-core/src/test/java/ch/qos/logback/core/joran/action/PropertyActionTest.java A logback-core/src/test/java/ch/qos/logback/core/joran/action/TopElementAction.java M logback-core/src/test/java/ch/qos/logback/core/joran/conditional/IfThenElseTest.java Log Message: ----------- continued work on model migration

1 0

[qos-ch/logback] 6121e7: ongoing work on model
by Ceki Gulcu 13 Feb '18

13 Feb '18

Branch: refs/heads/configModel Home: https://github.com/qos-ch/logback Commit: 6121e76edb6f4ac5825d8a239c4938dab82a0b69 https://github.com/qos-ch/logback/commit/6121e76edb6f4ac5825d8a239c4938dab8… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2018-02-13 (Tue, 13 Feb 2018) Changed paths: M logback-core/src/main/java/ch/qos/logback/core/joran/action/ModelImplicitAction.java M logback-core/src/main/java/ch/qos/logback/core/joran/action/PropertyAction.java M logback-core/src/main/java/ch/qos/logback/core/joran/action/ShutdownHookAction.java R logback-core/src/main/java/ch/qos/logback/core/joran/model/Model.java R logback-core/src/main/java/ch/qos/logback/core/joran/model/Parameter.java R logback-core/src/main/java/ch/qos/logback/core/joran/model/ShutdownHookModel.java R logback-core/src/main/java/ch/qos/logback/core/joran/processor/DefaultProcessor.java R logback-core/src/main/java/ch/qos/logback/core/joran/processor/ProcessorException.java A logback-core/src/main/java/ch/qos/logback/core/model/Model.java A logback-core/src/main/java/ch/qos/logback/core/model/Parameter.java A logback-core/src/main/java/ch/qos/logback/core/model/PropertyModel.java A logback-core/src/main/java/ch/qos/logback/core/model/ShutdownHookModel.java A logback-core/src/main/java/ch/qos/logback/core/model/processor/DefaultProcessor.java A logback-core/src/main/java/ch/qos/logback/core/model/processor/ModelHandlerBase.java A logback-core/src/main/java/ch/qos/logback/core/model/processor/ProcessorException.java A logback-core/src/main/java/ch/qos/logback/core/model/processor/PropertyModelHandler.java A logback-core/src/main/java/ch/qos/logback/core/model/processor/ShutdownHookModelHandler.java M logback-core/src/main/java/ch/qos/logback/core/util/OptionHelper.java Log Message: ----------- ongoing work on model

1 0

JDK 10: First Release Candidate - JDK 10 b43
by Rory O'Donnell 13 Feb '18

13 Feb '18

Hi Ceki, *JDK 10 build 43 is our first JDK 10 Release Candidate [1]* * JDK 10 Early Access build 43 is available at : - jdk.java.net/10/ Notable changes since previous email.** *build 43 * * JDK-8194764 <https://bugs.openjdk.java.net/browse/JDK-8194764> - javac incorrectly flags deprecated for removal imports * JDK-8196678 <https://bugs.openjdk.java.net/browse/JDK-8196678> - avoid printing uninitialized buffer in os::print_memory_info on AIX * JDK-8195837 <https://bugs.openjdk.java.net/browse/JDK-8195837> - (tz) Upgrade time-zone data to tzdata2018c ** *Bug fixes reported by Open Source Projects :* * JDK-8196296 <https://bugs.openjdk.java.net/browse/JDK-8196296> Lucene test crashes C2 compilation *Security Manager Survey * If you have written or maintain code that uses the SecurityManager or related APIs such as the AccessController, then we would appreciate if you would complete this survey: https://www.surveymonkey.com/r/RSGMF3K More info on the survey [2] Regards, Rory [1] http://mail.openjdk.java.net/pipermail/jdk-dev/2018-February/000742.html [2] http://mail.openjdk.java.net/pipermail/jdk-dev/2018-February/000649.html -- Rgds,Rory O'Donnell Quality Engineering Manager Oracle EMEA , Dublin, Ireland

1 0

[qos-ch/logback] 894654: ongoing work on models
by Ceki Gulcu 12 Feb '18

12 Feb '18

Branch: refs/heads/configModel Home: https://github.com/qos-ch/logback Commit: 894654703ee5ff6b776465450ee10077b4eb277c https://github.com/qos-ch/logback/commit/894654703ee5ff6b776465450ee10077b4… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M logback-core/src/main/java/ch/qos/logback/core/joran/JoranConfiguratorBase.java A logback-core/src/main/java/ch/qos/logback/core/joran/action/ModelImplicitAction.java M logback-core/src/main/java/ch/qos/logback/core/joran/action/NestedBasicPropertyIA.java M logback-core/src/main/java/ch/qos/logback/core/joran/action/ShutdownHookAction.java A logback-core/src/main/java/ch/qos/logback/core/joran/model/Model.java A logback-core/src/main/java/ch/qos/logback/core/joran/model/Parameter.java A logback-core/src/main/java/ch/qos/logback/core/joran/model/ShutdownHookModel.java A logback-core/src/main/java/ch/qos/logback/core/joran/processor/DefaultProcessor.java A logback-core/src/main/java/ch/qos/logback/core/joran/processor/ProcessorException.java Log Message: ----------- ongoing work on models

1 0

[qos-ch/logback] 8d7cae: requrie Java 8
by Ceki Gulcu 12 Feb '18

12 Feb '18

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: 8d7cae020888fc3b0c38f9fa31e0e2341baa2b15 https://github.com/qos-ch/logback/commit/8d7cae020888fc3b0c38f9fa31e0e2341b… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M pom.xml Log Message: ----------- requrie Java 8 Commit: 4dd08e68321548cd85251ec389f5a832505e1268 https://github.com/qos-ch/logback/commit/4dd08e68321548cd85251ec389f5a83250… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2018-02-12 (Mon, 12 Feb 2018) Changed paths: M logback-site/src/site/pages/dependencies.html M logback-site/src/site/pages/news.html M pom.xml Log Message: ----------- require java 8 Compare: https://github.com/qos-ch/logback/compare/b63303832dc1...4dd08e683215

1 0

[qos-ch/logback] b63303: add SequenceNumberGenerator support in logback-*
by Ceki Gulcu 11 Feb '18

11 Feb '18

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: b63303832dc1a2a8bf1eb9980cdb2d2d838fdb55 https://github.com/qos-ch/logback/commit/b63303832dc1a2a8bf1eb9980cdb2d2d83… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2018-02-11 (Sun, 11 Feb 2018) Changed paths: M logback-access/src/main/java/ch/qos/logback/access/jetty/RequestLogImpl.java M logback-access/src/main/java/ch/qos/logback/access/spi/AccessEvent.java M logback-access/src/main/java/ch/qos/logback/access/spi/IAccessEvent.java M logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java M logback-access/src/test/java/ch/qos/logback/access/boolex/JaninoEventEvaluatorTest.java M logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderHSQLTest.java M logback-access/src/test/java/ch/qos/logback/access/dummy/DummyAccessEventBuilder.java M logback-access/src/test/java/ch/qos/logback/access/net/URLEvaluatorTest.java M logback-access/src/test/java/ch/qos/logback/access/pattern/ConverterTest.java M logback-access/src/test/java/ch/qos/logback/access/spi/AccessEventSerializationTest.java M logback-classic/src/main/java/ch/qos/logback/classic/LoggerContext.java R logback-classic/src/main/java/ch/qos/logback/classic/spi/BasicSequenceNumberGenerator.java M logback-classic/src/main/java/ch/qos/logback/classic/spi/LoggingEvent.java R logback-classic/src/main/java/ch/qos/logback/classic/spi/SequenceNumberGenerator.java M logback-core/src/main/java/ch/qos/logback/core/Context.java M logback-core/src/main/java/ch/qos/logback/core/ContextBase.java A logback-core/src/main/java/ch/qos/logback/core/joran/action/SequenceNumberGeneratorAction.java A logback-core/src/main/java/ch/qos/logback/core/spi/BasicSequenceNumberGenerator.java A logback-core/src/main/java/ch/qos/logback/core/spi/SequenceNumberGenerator.java Log Message: ----------- add SequenceNumberGenerator support in logback-*

1 0

[JIRA] (LOGBACK-1381) module ch.qos.logback.core does not read module java.xml
by QOS.CH (JIRA) 11 Feb '18

11 Feb '18

1 0