- logback-dev - mailman3.qos.ch

[JIRA] (LOGBACK-1337) LogbackMDCAdapter should store mdc in LinkedHashMap to predict order of MDC in %X
by QOS.CH (JIRA) 05 Dec '19

05 Dec '19

1 0

[JIRA] (LOGBACK-1337) LogbackMDCAdapter should store mdc in LinkedHashMap to predict order of MDC in %X
by QOS.CH (JIRA) 05 Dec '19

05 Dec '19

1 0

JDK 14 - Early Access build 25 is available
by Rory O'Donnell 29 Nov '19

29 Nov '19

Hi Ceki, *OpenJDK builds - JDK 14 *- Early Access build 25 is available at http://jdk.java.net/14/ These early-access, open-source builds are provided under the GNU General Public License, version 2, with the Classpath Exception <http://openjdk.java.net/legal/gplv2+ce.html>. * *Next Milestone* ** o ** *12-Dec-2019 Rampdown Phase One.* * Release notes o https://jdk.java.net/14/release-notes * JEP proposed to target JDK 14 o JEP 365 ZGC on Windows <https://openjdk.java.net/jeps/365> * JEPs targeted to JDK 14, so far: o JEP 305: Pattern Matching for instanceof (Preview) <http://openjdk.java.net/jeps/305> was proposed to target. o JEP 343: Packaging Tool (Incubator) <http://openjdk.java.net/jeps/343> was proposed to target. o JEP 345: NUMA-Aware Memory Allocation for G1 <http://openjdk.java.net/jeps/345> was integrated. o JEP 349: JFR Event Streaming <http://openjdk.java.net/jeps/349> was integrated. o JEP 352: Non-Volatile Mapped Byte Buffers <http://openjdk.java.net/jeps/352> was targeted. o JEP 358: Helpful NullPointerExceptions <https://openjdk.java.net/jeps/358> was integrated. o JEP 359: Records (Preview) <http://openjdk.java.net/jeps/359> JEP 359: Records (Preview) <http://openjdk.java.net/jeps/359> was proposed to target. o JEP 361: Switch Expressions (Standard) <http://openjdk.java.net/jeps/361> was intergrated. o JEP 363: Remove the Concurrent Mark Sweep (CMS) Garbage Collector <http://openjdk.java.net/jeps/363> was targeted. o JEP 364: ZGC on macOS <http://openjdk.java.net/jeps/364> was targeted. o JEP 366: Deprecate the ParallelScavenge + SerialOld GC Combination <http://openjdk.java.net/jeps/366> was proposed to target. o JEP 367: Remove the Pack200 Tools and API <http://openjdk.java.net/jeps/367> was targeted to JDK 14. o JEP 368: Text Blocks (Second Preview) <http://openjdk.java.net/jeps/368> was proposed to target. * Recent Bug fixes of Interest * Build 25: o JDK-8233301: Implementation of JEP 366: Deprecate the ParallelScavenge + SerialOld GC Combination o JDK-8233296: The behavior of MulticastSocket getOption/setOption for IP_MULTICAST_LOOP is changed to conform the specification of StandardSocketOptions.IP_MULTICAST_LOOP * Build 24: o JDK-8233141 :DatagramSocket.send and MulticastSocket.send throw IllegalArgumentException when the socket is not connected and the packet doesn't contain any address ) o JDK-8214024: Remove the default keytool -keyalg value o JDK-8232019: Add LuxTrust certificate updates to the existing root program * Build 23 o JDK 8232365: Implementation for JEP 363: Remove the Concurrent Mark Sweep (CMS) Garbage Collector o JDK 8224817: Implementation of JEP 364: ZGC on macOS * Changes in this build <http://hg.openjdk.java.net/jdk/jdk/log?rev=reverse%28%22jdk-14%2B24%22%3A%3…> *jpackage EA -* Build 14-jpackage+1-70 (2019/11/12) * This is an early access build of JEP 343: Packaging Tool <https://openjdk.java.net/jeps/343>, aimed at testing a prototype implementation of jpackage, which is a new tool for packaging self-contained Java applications along with a Java Runtime Environment. * These early-access builds are provided under the GNU General Public License, version 2, with the Classpath Exception <http://openjdk.java.net/legal/gplv2+ce.html> * Build is now available http://jdk.java.net/jpackage/ * Please send feedback via e-mail to core-libs-dev(a)openjdk.java.net <mailto:core-libs-dev@openjdk.java.net> Rgds,Rory** ** -- Rgds, Rory O'Donnell Quality Engineering Manager Oracle EMEA, Dublin, Ireland

1 0

[JIRA] (LOGBACK-1090) ShutdownHook requires the class attribute
by QOS.CH (JIRA) 29 Nov '19

29 Nov '19

1 0

[JIRA] (LOGBACK-1493) MDC performance can be improved with persistent ADT
by QOS.CH (JIRA) 25 Nov '19

25 Nov '19

Ceki Gülcü created LOGBACK-1493: ----------------------------------- Summary: MDC performance can be improved with persistent ADT Key: LOGBACK-1493 URL: https://jira.qos.ch/browse/LOGBACK-1493 Project: logback Issue Type: Improvement Components: logback-classic Environment: Given that MDC is increasingly used in conjuction with log analysis tools, MDC performance should be further optimized. Reporter: Ceki Gülcü Assignee: Logback dev list Fix For: 1.3.0-alpha6 -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[qos-ch/logback] b5baeb: added Nicolai Parlog to CLAs
by Ceki Gulcu 25 Nov '19

25 Nov '19

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: b5baeb47bacdd64190d1c10f119f810b39773d95 https://github.com/qos-ch/logback/commit/b5baeb47bacdd64190d1c10f119f810b39… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2019-11-25 (Mon, 25 Nov 2019) Changed paths: M src/main/clas/signed-clas.txt Log Message: ----------- added Nicolai Parlog to CLAs

1 0

[qos-ch/logback] ee57be: ow
by Ceki Gulcu 25 Nov '19

25 Nov '19

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: ee57be191351820baf83e7ae9cebfb1ab263e987 https://github.com/qos-ch/logback/commit/ee57be191351820baf83e7ae9cebfb1ab2… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2019-11-25 (Mon, 25 Nov 2019) Changed paths: M logback-classic/src/main/java/ch/qos/logback/classic/joran/action/LevelAction.java M logback-classic/src/main/java/ch/qos/logback/classic/joran/action/LoggerAction.java M logback-classic/src/main/java/ch/qos/logback/classic/joran/action/RootLoggerAction.java M logback-classic/src/main/java/ch/qos/logback/classic/model/ContextNameModel.java M logback-classic/src/main/java/ch/qos/logback/classic/model/processor/ContextNameModelHandler.java M logback-core/src/main/java/ch/qos/logback/core/joran/action/AppenderRefAction.java M logback-core/src/main/java/ch/qos/logback/core/joran/action/BaseModelAction.java M logback-core/src/main/java/ch/qos/logback/core/model/AppenderModel.java M logback-core/src/main/java/ch/qos/logback/core/model/DefineModel.java A logback-core/src/main/java/ch/qos/logback/core/model/INamedModel.java M logback-core/src/main/java/ch/qos/logback/core/model/Model.java A logback-core/src/main/java/ch/qos/logback/core/model/NamedComponentModel.java A logback-core/src/main/java/ch/qos/logback/core/model/NamedModel.java M logback-core/src/main/java/ch/qos/logback/core/model/ParamModel.java M logback-core/src/main/java/ch/qos/logback/core/model/PropertyModel.java M logback-core/src/main/java/ch/qos/logback/core/model/TimestampModel.java M logback-site/src/site/pages/templates/right.js Log Message: ----------- ow

1 0

[JIRA] (LOGBACK-1421) Logback 1.2.3 threads getting deadlocked at CachingDateFormatter
by QOS.CH (JIRA) 20 Nov '19

20 Nov '19

1 0

[JIRA] (LOGBACK-1492) AppenderBase is deadlock prone
by QOS.CH (JIRA) 19 Nov '19

19 Nov '19

Christoffer Eide created LOGBACK-1492: ----------------------------------------- Summary: AppenderBase is deadlock prone Key: LOGBACK-1492 URL: https://jira.qos.ch/browse/LOGBACK-1492 Project: logback Issue Type: Bug Environment: {noformat} java version "1.8.0_192" Java(TM) SE Runtime Environment (build 1.8.0_192-b12) Java HotSpot(TM) 64-Bit Server VM (build 25.192-b12, mixed mode) {noformat} Tested in HEAD ({{cc0d7394faf2525a43f967f8960d54ebefe30b2c}}) Reporter: Christoffer Eide Assignee: Logback dev list We encountered a deadlock with a subclass of {{ch.qos.logback.core.AppenderBase}}. The implementation of {{append()}} is: {code:java} @Override protected void append(ILoggingEvent event) { event.prepareForDeferredProcessing(); try { queue.put(event); } catch (InterruptedException e) { Thread.currentThread().interrupt(); } } {code} {{AppenderBase#doAppend}} has the signature: {code:java} public synchronized void doAppend(E eventObject) {code} And it calls the subclass {{append()}}. The deadlock occurred because the subclass of {{AppenderBase}} called {{toString()}} on an object (via {{ILoggingEvent#prepareForDeferredProcessing()}}) while holding a lock in {{AppenderBase#doAppend}}. The objects {{toString()}} method grabbed a second lock, leading to a deadlock. One might argue that an implementation of {{toString()}} should _not_ grab a lock, but it's also bad practice to call an alien method while holding a lock. >From JCIP 10.1.3: ??Invoking an alien method with a lock held is asking for liveness trouble. The alien method might acquire other locks (risking deadlock) or block for an unexpectedly long time, stalling other threads that need the lock you hold?? The test below demonstrates the problem we encountered: {code:java} package ch.qos.logback.core; import ch.qos.logback.classic.Level; import ch.qos.logback.classic.Logger; import ch.qos.logback.classic.LoggerContext; import ch.qos.logback.classic.spi.ILoggingEvent; import org.junit.Before; import org.junit.Test; import java.lang.management.ManagementFactory; import java.util.concurrent.CountDownLatch; import java.util.concurrent.ExecutorService; import java.util.concurrent.Executors; import java.util.concurrent.TimeUnit; import static java.util.concurrent.Executors.newFixedThreadPool; import static org.junit.Assert.assertNull; public class AppenderBaseDeadlockTest { static CountDownLatch inReload = new CountDownLatch(1); Logger logger; ExecutorService executor; @Before public void setUp() throws Exception { LoggerContext context = new LoggerContext(); logger = context.getLogger(Logger.ROOT_LOGGER_NAME); logger.detachAndStopAllAppenders(); logger.setLevel(Level.TRACE); logger.addAppender(new AppenderBase<ILoggingEvent>() { { start(); } @Override protected void append(ILoggingEvent eventObject) { inReload.countDown(); eventObject.prepareForDeferredProcessing(); } }); executor = newFixedThreadPool(2, runnable -> { Thread thread = Executors.defaultThreadFactory().newThread(runnable); thread.setDaemon(true); return thread; }); } @Test public void testDeadlock() throws Exception { ClassWithLockOnToString classWithLockOnToString = new ClassWithLockOnToString(logger); CountDownLatch start = new CountDownLatch(1); executor.submit(() -> { start.await(); logger.debug("{}", classWithLockOnToString); return null; }); executor.submit(() -> { start.await(); classWithLockOnToString.reload(); return null; }); start.countDown(); executor.shutdown(); if(!executor.awaitTermination(1, TimeUnit.SECONDS)){ assertNull(ManagementFactory.getThreadMXBean().findDeadlockedThreads()); } } static class ClassWithLockOnToString { private final Logger logger; ClassWithLockOnToString(Logger logger) { this.logger = logger; } void reload(){ synchronized (this){ try { inReload.await(); } catch (InterruptedException e) { Thread.currentThread().interrupt(); } logger.debug("ClassWithLockOnToString#toStringwreload()"); } } @Override public String toString() { reload(); return "ClassWithLockOnToString#toString()"; } } } {code} A simplified stack track trace of the stack: {noformat} ThreadA -> logger#debug -> AppenderBase#doAppend <-- Grabs Lock A -> LoggingEvent#prepareForDeferredProcessing -> ClassWithLockOnToString#toString -> ClassWithLockOnToString#reload <-- Grabs Lock B ThreadB -> ClassWithLockOnToString#reload <-- Grabs Lock B -> logger#debug -> AppenderBase#doAppend <-- Grabs Lock A {noformat} Full stacktraces of the deadlocked threads {noformat} "pool-1-thread-1@1038" daemon prio=5 tid=0xd nid=NA waiting for monitor entry java.lang.Thread.State: BLOCKED blocks pool-2-thread-1@1043 waiting for pool-2-thread-1@1043 to release lock on <0x42d> (a ch.qos.logback.core.AppenderBaseDeadlockTest$ClassWithLockOnToString) at ch.qos.logback.core.AppenderBaseDeadlockTest$ClassWithLockOnToString.reload(AppenderBaseDeadlockTest.java:95) at ch.qos.logback.core.AppenderBaseDeadlockTest$ClassWithLockOnToString.toString(AppenderBaseDeadlockTest.java:105) at org.slf4j.helpers.MessageFormatter.safeObjectAppend(MessageFormatter.java:292) at org.slf4j.helpers.MessageFormatter.deeplyAppendParameter(MessageFormatter.java:264) at org.slf4j.helpers.MessageFormatter.arrayFormat(MessageFormatter.java:226) at org.slf4j.helpers.MessageFormatter.arrayFormat(MessageFormatter.java:161) at ch.qos.logback.classic.spi.LoggingEvent.getFormattedMessage(LoggingEvent.java:314) at ch.qos.logback.classic.spi.LoggingEvent.prepareForDeferredProcessing(LoggingEvent.java:218) at ch.qos.logback.core.AppenderBaseDeadlockTest$1.append(AppenderBaseDeadlockTest.java:42) at ch.qos.logback.core.AppenderBaseDeadlockTest$1.append(AppenderBaseDeadlockTest.java:34) at ch.qos.logback.core.AppenderBase.doAppend(AppenderBase.java:82) - locked <0x438> (a ch.qos.logback.core.AppenderBaseDeadlockTest$1) at ch.qos.logback.core.spi.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:51) at ch.qos.logback.classic.Logger.appendLoopOnAppenders(Logger.java:272) at ch.qos.logback.classic.Logger.callAppenders(Logger.java:259) at ch.qos.logback.classic.Logger.buildLoggingEventAndAppend(Logger.java:423) at ch.qos.logback.classic.Logger.filterAndLog_1(Logger.java:400) at ch.qos.logback.classic.Logger.debug(Logger.java:488) at ch.qos.logback.core.AppenderBaseDeadlockTest.lambda$testDeadlock$1(AppenderBaseDeadlockTest.java:60) at ch.qos.logback.core.AppenderBaseDeadlockTest$$Lambda$2.171497379.call(Unknown Source:-1) at java.util.concurrent.FutureTask.run$$$capture(FutureTask.java:266) at java.util.concurrent.FutureTask.run(FutureTask.java:-1) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) {noformat} {noformat} "pool-2-thread-1@1043" daemon prio=5 tid=0xe nid=NA waiting for monitor entry java.lang.Thread.State: BLOCKED blocks pool-1-thread-1@1038 blocks main@1 waiting for pool-1-thread-1@1038 to release lock on <0x438> (a ch.qos.logback.core.AppenderBaseDeadlockTest$1) at ch.qos.logback.core.AppenderBase.doAppend(AppenderBase.java:63) at ch.qos.logback.core.spi.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:51) at ch.qos.logback.classic.Logger.appendLoopOnAppenders(Logger.java:272) at ch.qos.logback.classic.Logger.callAppenders(Logger.java:259) at ch.qos.logback.classic.Logger.buildLoggingEventAndAppend(Logger.java:423) at ch.qos.logback.classic.Logger.filterAndLog_0_Or3Plus(Logger.java:385) at ch.qos.logback.classic.Logger.debug(Logger.java:484) at ch.qos.logback.core.AppenderBaseDeadlockTest$ClassWithLockOnToString.reload(AppenderBaseDeadlockTest.java:99) - locked <0x42d> (a ch.qos.logback.core.AppenderBaseDeadlockTest$ClassWithLockOnToString) at ch.qos.logback.core.AppenderBaseDeadlockTest.lambda$testDeadlock$2(AppenderBaseDeadlockTest.java:66) at ch.qos.logback.core.AppenderBaseDeadlockTest$$Lambda$3.415186196.call(Unknown Source:-1) at java.util.concurrent.FutureTask.run$$$capture(FutureTask.java:266) at java.util.concurrent.FutureTask.run(FutureTask.java:-1) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) {noformat} -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (LOGBACK-1491) NPE with Logback 1.3.0-alpha5 in application using module path
by QOS.CH (JIRA) 12 Nov '19

12 Nov '19

1 0