- logback-dev - mailman3.qos.ch

[JIRA] (LOGBACK-1288) Misspelled Level in XML configuration leads to logs being printed in DEBUG
by QOS.CH (JIRA) 23 Mar '17

23 Mar '17

1 0

[JIRA] (LOGBACK-1288) Misspelled Level in XML configuration leads to logs being printed in DEBUG
by QOS.CH (JIRA) 23 Mar '17

23 Mar '17

1 0

[JIRA] (LOGBACK-1288) Misspelled Level in XML configuration leads to logs being printed in DEBUG
by QOS.CH (JIRA) 23 Mar '17

23 Mar '17

Gaurav Khanna created LOGBACK-1288: -------------------------------------- Summary: Misspelled Level in XML configuration leads to logs being printed in DEBUG Key: LOGBACK-1288 URL: https://jira.qos.ch/browse/LOGBACK-1288 Project: logback Issue Type: Improvement Components: logback-classic Affects Versions: 1.1.3 Environment: Linux, CentOS. Reporter: Gaurav Khanna Assignee: Logback dev list Priority: Minor On misspelling the level (as in "INFO " instead of "INFO"), the library did not throw an error (on INFO and above) and defaulted to "DEBUG". <logger name="chapters.configuration" *level="INFO"*/> Was wondering if a WARNING or an ERROR is thrown in cases of such obvious cases? -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (LOGBACK-1287) Breaking change? Custom appender can not be assigned to OutputStreamAppender
by QOS.CH (JIRA) 22 Mar '17

22 Mar '17

1 0

[qos-ch/logback] 0c7581: Fix two typos in the README.md
by Ceki Gulcu 22 Mar '17

22 Mar '17

Branch: refs/heads/branch_1.2.3 Home: https://github.com/qos-ch/logback Commit: 0c7581fba010c08fde6f2db3926460b36b75cb3c https://github.com/qos-ch/logback/commit/0c7581fba010c08fde6f2db3926460b36b… Author: Jérémie Roquet <jroquet(a)arkanosis.net> Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M README.md Log Message: ----------- Fix two typos in the README.md logbback -> logback http -> https Commit: ed099d32756b1b4ee1d8efbea077e789e7cf5414 https://github.com/qos-ch/logback/commit/ed099d32756b1b4ee1d8efbea077e789e7… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M logback-site/src/site/pages/setup.html A logback-site/src/site/resources/images/setup/deselectMavenDependenciesExport.png A logback-site/src/site/resources/images/setup/discoverM2EConnectors.png A logback-site/src/site/resources/images/setup/removeGroovyExclusions.png Log Message: ----------- document build with M2Eclipse Commit: 4bbab462950851cd64e97cef73fdd988038bc8c9 https://github.com/qos-ch/logback/commit/4bbab462950851cd64e97cef73fdd98803… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M logback-core/src/main/java/ch/qos/logback/core/OutputStreamAppender.java Log Message: ----------- no point in writing zero length arrays Commit: a31c93b5c1794c9f264e7c27f63817f1c774cd21 https://github.com/qos-ch/logback/commit/a31c93b5c1794c9f264e7c27f63817f1c7… Author: Thibault Meyer <meyer.thibault(a)gmail.com> Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M logback-core/src/main/java/ch/qos/logback/core/AsyncAppenderBase.java Log Message: ----------- Remove disturbing println Signed-off-by: Thibault Meyer <meyer.thibault(a)gmail.com> Commit: 2fb19ce31d95a5a097fe3b2368cef5f79f2688c3 https://github.com/qos-ch/logback/commit/2fb19ce31d95a5a097fe3b2368cef5f79f… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M logback-core/src/main/java/ch/qos/logback/core/encoder/LayoutWrappingEncoder.java Log Message: ----------- fix LOGBACK-1287 Compare: https://github.com/qos-ch/logback/compare/0c7581fba010^...2fb19ce31d95

1 0

[JIRA] (LOGBACK-1287) Breaking change? Custom appender can not be assigned to OutputStreamAppender
by QOS.CH (JIRA) 22 Mar '17

22 Mar '17

1 0

[qos-ch/logback] b0ede8: fix LOGBACK-1287
by Ceki Gulcu 22 Mar '17

22 Mar '17

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: b0ede870f6acec8b1ec27ee90a8e664a62307d0d https://github.com/qos-ch/logback/commit/b0ede870f6acec8b1ec27ee90a8e664a62… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M logback-core/src/main/java/ch/qos/logback/core/encoder/LayoutWrappingEncoder.java Log Message: ----------- fix LOGBACK-1287

1 0

[JIRA] (LOGBACK-1287) Breaking change? Custom appender can not be assigned to OutputStreamAppender
by QOS.CH (JIRA) 22 Mar '17

22 Mar '17

Jack created LOGBACK-1287: ----------------------------- Summary: Breaking change? Custom appender can not be assigned to OutputStreamAppender Key: LOGBACK-1287 URL: https://jira.qos.ch/browse/LOGBACK-1287 Project: logback Issue Type: Bug Components: logback-core Affects Versions: 1.2.2, 1.2.1 Reporter: Jack Assignee: Logback dev list Priority: Blocker With the release of logback 1.2.1 our custom appender does not work anymore and Joran fails with the error below: {noformat} INFO in ch.qos.logback.core.joran.action.NestedComplexPropertyIA - Assuming default type [ch.qos.logback.classic.encoder.PatternLayoutEncoder] for [encoder] property ERROR in ch.qos.logback.core.joran.util.PropertySetter@434f3900 - A "com.example.logging.logback.extensions.DebugFileDumper" object is not assignable to a "ch.qos.logback.core.OutputStreamAppender" variable. The class "ch.qos.logback.core.OutputStreamAppender" was loaded by [startJarLoader@2d95ebec] whereas object of type "com.example.logging.logback.extensions.DebugFileDumper" was loaded by [startJarLoader@2d95ebec]. {noformat} I think the issue has been introduced by commit: [https://github.com/qos-ch/logback/commit/d3d704c12e7b8e6503187744ac2200c244…] which makes {{LayoutWrappingEncoder}} assume that it is always owned by an OutputstreamAppender: [https://github.com/qos-ch/logback/commit/d3d704c12e7b8e6503187744ac2200c244…] However our custom Appender extends AppenderBase and uses composition to use two FileAppenders internally. The encoder of one of those FileAppenders can be configured in logback.xml while the other has a fixed encoding. Basically the Java code delegates setEncoder() to a FileAppender. Code roughly looks like: {code:java} public class DebugFileDumper extends AppenderBase<ILoggingEvent> { // writes a debug-timestamp.log from a cyclic buffer private FileAppender<ILoggingEvent> debugBufferFileDumper; // writes a debug-timestamp.meta containing corresponding meta infos stored in MDC in an easy to parse key=value format for further processing by external tools. private FileAppender<ILoggingEvent> mdcFileDumper; // ... additional properties public DebugFileDumper() { mdcFileDumper.setEncoder(new MdcOnlyEncoder()); } public void setEncoder(Encoder<ILoggingEvent> encoder) { debugBufferFileDumper.setEncoder(encoder); } public Encoder<ILoggingEvent> getEncoder() { return debugBufferFileDumper.getEncoder(); } // .. additional methods } {code} With configuration like: {code:xml} <appender name="debugDumper" class="com.example.logging.logback.extensions.DebugFileDumper"> <discriminator class="ch.qos.logback.classic.sift.MDCBasedDiscriminator"> <key>SESSION_ID</key> <defaultValue>server</defaultValue> </discriminator> <evaluator class="ch.qos.logback.classic.boolex.OnErrorEvaluator" /> <cyclicBufferTracker class="ch.qos.logback.core.spi.CyclicBufferTracker"> <bufferSize>128</bufferSize> <maxComponents>128</maxComponents> <timeout>1800000</timeout> </cyclicBufferTracker> <folder>${logback.logs}/dumps</folder> <encoder> <pattern>[SOME PATTERN FOR DEBUG LOG FILE]</pattern> </encoder> </appender> {code} I think our implementation strategy is valid and the assumption made in the mentioned commit, that an encoder configuration block always belongs to an OutputStreamAppender, is a bit too strict. Basically composition/delegation pattern hasn't been taken into account. Currently we would need to rewrite our appender in order to make it work with Logback 1.2.1+, so I thought I should let you know about that implicit breaking change. Maybe it was not intended on your side and you can relax the assumption to fix our issue. -- This message was sent by Atlassian JIRA (v7.3.1#73012)

1 0

[JIRA] (LOGBACK-1277) Capping log files does not work with large log file base
by QOS.CH (JIRA) 22 Mar '17

22 Mar '17

1 0

[qos-ch/logback] 4d2a6a: Remove disturbing println
by Ceki Gulcu 21 Mar '17

21 Mar '17

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: 4d2a6a6579ce5b9a1e79be8557989574bd196e5f https://github.com/qos-ch/logback/commit/4d2a6a6579ce5b9a1e79be8557989574bd… Author: Thibault Meyer <meyer.thibault(a)gmail.com> Date: 2017-03-21 (Tue, 21 Mar 2017) Changed paths: M logback-core/src/main/java/ch/qos/logback/core/AsyncAppenderBase.java Log Message: ----------- Remove disturbing println Signed-off-by: Thibault Meyer <meyer.thibault(a)gmail.com> Commit: 6165653f62fe6ccd82b4a849e6ad636f357eb835 https://github.com/qos-ch/logback/commit/6165653f62fe6ccd82b4a849e6ad636f35… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2017-03-21 (Tue, 21 Mar 2017) Changed paths: M logback-core/src/main/java/ch/qos/logback/core/AsyncAppenderBase.java Log Message: ----------- Merge pull request #369 from 0xbaadf00d/feature/remove-println Remove disturbing println Compare: https://github.com/qos-ch/logback/compare/ed3ec5be6830...6165653f62fe

1 0