- logback-dev - mailman3.qos.ch

A couple minor PRs to allow switching Dropwizard request logging to logback-access
by Jamie Furness 02 Jun '14

02 Jun '14

Hey guys, I've been doing some work recently on switching Dropwizards ( http://dropwizard.io) request logging from using the basic Jetty NCSARequestLog to logback-access. During this I came across a couple issues in logback-access that I have submit PRs for on Github, but so far they have been no eyes on them. The first one (#202) changes the AccessEvent.prepareForDeferredProcessing to be idempotent. Without this async appenders will cause correctly prepared context to be overwritten with invalid context. The second (#201) extracts the configuration of the request logging in to a protected configure method to allow us to override the configuration without overriding (and re-implementing the other parts of) the start method. Cheers, Jamie

1 0

[JIRA] (LOGBACK-985) RollingFileAppender fails to rotate log if underlying jar files also uses logger
by kaustubh sathe (JIRA) 01 Jun '14

01 Jun '14

1 0

[JIRA] (LOGBACK-262) PatternLayout does not really respect ISO8601 for date time
by Michael Osipov (JIRA) 29 May '14

29 May '14

1 0

[JIRA] (LOGBACK-262) PatternLayout does not really respect ISO8601 for date time
by James Fisher (JIRA) 29 May '14

29 May '14

1 0

[JIRA] (LOGBACK-986) build fails on our build server due to missing directory
by Joern Huxhorn (JIRA) 27 May '14

27 May '14

1 0

[JIRA] (LOGBACK-985) RollingFileAppender fails to rotate log if underlying jar files also uses logger
by Tony Trinh (JIRA) 27 May '14

27 May '14

1 0

[JIRA] (LOGBACK-986) build fails on our build server due to missing directory
by Tony Trinh (JIRA) 27 May '14

27 May '14

1 0

[JIRA] (LOGBACK-128) race condition when creating log directory in multithreaded environment
by Tony Trinh (JIRA) 27 May '14

27 May '14

1 0

[JIRA] (LOGBACK-128) race condition when creating log directory in multithreaded environment
by Tony Trinh (JIRA) 27 May '14

27 May '14

1 0

[qos-ch/logback] 0637d2: Fix exception when threads write files to same dir
by Tony Trinh 27 May '14

27 May '14

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: 0637d22cf8a6c0f41487021c9ff087e8bd256274 https://github.com/qos-ch/logback/commit/0637d22cf8a6c0f41487021c9ff087e8bd… Author: Tony Trinh <tony19(a)gmail.com> Date: 2014-05-26 (Mon, 26 May 2014) Changed paths: M logback-core/src/main/java/ch/qos/logback/core/FileAppender.java M logback-core/src/main/java/ch/qos/logback/core/rolling/helper/Compressor.java M logback-core/src/main/java/ch/qos/logback/core/rolling/helper/RenameUtil.java M logback-core/src/main/java/ch/qos/logback/core/util/FileUtil.java M logback-core/src/test/java/ch/qos/logback/core/appender/FileAppenderTest.java M logback-core/src/test/java/ch/qos/logback/core/util/FileUtilTest.java Log Message: ----------- Fix exception when threads write files to same dir When Multiple FileAppenders attempt to write files to the same nonexistent directory, concurrent threads could attempt to create the directory at the same time, where only one succeeds, while the others hit an IllegalStateException. This patch modifies FileUtil.createMissingParentDirectories() to gracefully handle existing directories (no exceptions thrown). This patch also removes FileUtil.isParentDirectoryCreationRequired() as this allows for race conditions between the existence-check and the directory creation. Note that File.mkdirs() already performs an existence-check. Fixes LOGBACK-128

1 0