- logback-dev - mailman3.qos.ch

[qos-ch/logback] 6e7605: modified ContextBase to shut down executor service...
by Carl Harris 28 Apr '13

28 Apr '13

Branch: refs/heads/LOGBACK-849 Home: https://github.com/qos-ch/logback Commit: 6e7605be8fd67512e660f3c6afb263d540e2a22c https://github.com/qos-ch/logback/commit/6e7605be8fd67512e660f3c6afb263d540… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-04-28 (Sun, 28 Apr 2013) Changed paths: M logback-core/src/main/java/ch/qos/logback/core/ContextBase.java M logback-core/src/test/java/ch/qos/logback/core/ContextBaseTest.java Log Message: ----------- modified ContextBase to shut down executor service on reset

1 0

[qos-ch/logback] ac0daf: marked SocketAppender convenience constructors in ...
by Carl Harris 27 Apr '13

27 Apr '13

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: ac0dafdbac096eb51895d7243eeac9708cdcfad1 https://github.com/qos-ch/logback/commit/ac0dafdbac096eb51895d7243eeac9708c… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-04-27 (Sat, 27 Apr 2013) Changed paths: M logback-access/src/main/java/ch/qos/logback/access/net/SSLSocketAppender.java M logback-access/src/main/java/ch/qos/logback/access/net/SocketAppender.java Log Message: ----------- marked SocketAppender convenience constructors in access as deprecated For consistency with logback-core.

1 0

[qos-ch/logback] e2164f: use "receiver" instead of "remote" in receiver dia...
by Carl Harris 27 Apr '13

27 Apr '13

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: e2164f9eb60b12d08500684b0a644c65b24df3f9 https://github.com/qos-ch/logback/commit/e2164f9eb60b12d08500684b0a644c65b2… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-04-27 (Sat, 27 Apr 2013) Changed paths: M logback-classic/src/main/java/ch/qos/logback/classic/net/SocketReceiver.java Log Message: ----------- use "receiver" instead of "remote" in receiver diagnostic messages

1 0

[qos-ch/logback] 5c9917: removed unused SocketReceiver.createExecutorServic...
by Carl Harris 27 Apr '13

27 Apr '13

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: 5c9917ce3fb08664bdf5d204892e2977df91e03b https://github.com/qos-ch/logback/commit/5c9917ce3fb08664bdf5d204892e2977df… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-04-27 (Sat, 27 Apr 2013) Changed paths: M logback-classic/src/main/java/ch/qos/logback/classic/net/SocketReceiver.java Log Message: ----------- removed unused SocketReceiver.createExecutorService

1 0

[qos-ch/logback]
by ceharris 27 Apr '13

27 Apr '13

Branch: refs/heads/LOGBACK-848 Home: https://github.com/qos-ch/logback

1 0

[qos-ch/logback] 55b574: marked SSLSocketAppender convenience constructors ...
by Carl Harris 27 Apr '13

27 Apr '13

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: 55b5749d031dac1345ec23fcb7b5e509875afe00 https://github.com/qos-ch/logback/commit/55b5749d031dac1345ec23fcb7b5e50987… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-04-27 (Sat, 27 Apr 2013) Changed paths: M logback-classic/src/main/java/ch/qos/logback/classic/net/SSLSocketAppender.java Log Message: ----------- marked SSLSocketAppender convenience constructors as deprecated For consistency with SocketAppender.

1 0

[qos-ch/logback] bb6375: fixed deprecation warning for SocketAppender conve...
by Carl Harris 27 Apr '13

27 Apr '13

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: bb6375b7a356e4e8ec52b68f1196ef875471af7b https://github.com/qos-ch/logback/commit/bb6375b7a356e4e8ec52b68f1196ef8754… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-04-27 (Sat, 27 Apr 2013) Changed paths: M logback-classic/src/test/java/ch/qos/logback/classic/net/SocketMin.java Log Message: ----------- fixed deprecation warning for SocketAppender convenience constructor

1 0

[qos-ch/logback] ed2d5d: marked SocketAppender convenience constructors as ...
by Carl Harris 27 Apr '13

27 Apr '13

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: ed2d5d00d3f583829fbabe7794780ee82b24e4f1 https://github.com/qos-ch/logback/commit/ed2d5d00d3f583829fbabe7794780ee82b… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-04-27 (Sat, 27 Apr 2013) Changed paths: M logback-classic/src/main/java/ch/qos/logback/classic/net/SocketAppender.java Log Message: ----------- marked SocketAppender convenience constructors as deprecated Convenience constructors that are used to set mutable fields that have proper accessors add little value, and they make it more complicated to subclass. Best practice is to use constructor arguments only to initialize fields that are immutable or for which an accessor method cannot be safely provided within the design constraints of the class. The only use of these constructors by logback modules is in the SocketMin class. However, because these constructors were exposed as API (public modifier) there is a chance that other code is using them, therefore marking them as deprecated rather than removing them.

1 0

[qos-ch/logback] 438d0d: added static and final modifier to PreSerializatio...
by Carl Harris 27 Apr '13

27 Apr '13

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: 438d0d284cf407e1373e9c9c4217061edd15615c https://github.com/qos-ch/logback/commit/438d0d284cf407e1373e9c9c4217061edd… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-04-27 (Sat, 27 Apr 2013) Changed paths: M logback-classic/src/main/java/ch/qos/logback/classic/net/SocketAppender.java Log Message: ----------- added static and final modifier to PreSerializationTransformer field The LoggingEventPreSerializationTransformer is completely stateless and therefore inherently thread-safe. Therefore, there is no reason to create a distinct instance for each appender. Moreover, once created it never needs to be modified, therefore it should be properly marked as immutable via the final keyword.

1 0

[qos-ch/logback] c8ac1e: added private modifier to mutable fields
by Carl Harris 27 Apr '13

27 Apr '13

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: c8ac1e9cbb058105755872e35923d126c32df89f https://github.com/qos-ch/logback/commit/c8ac1e9cbb058105755872e35923d126c3… Author: Carl Harris <ceharris(a)vt.edu> Date: 2013-04-27 (Sat, 27 Apr 2013) Changed paths: M logback-classic/src/main/java/ch/qos/logback/classic/net/SocketAppender.java Log Message: ----------- added private modifier to mutable fields

1 0