- logback-dev - mailman3.qos.ch

[qos-ch/logback] 879081: more unit tests
by Ceki Gulcu 25 Apr '13

25 Apr '13

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: 879081248675a22013663a51a629ba2bcedfd094 https://github.com/qos-ch/logback/commit/879081248675a22013663a51a629ba2bce… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2013-04-25 (Thu, 25 Apr 2013) Changed paths: M logback-core/src/test/java/ch/qos/logback/core/sift/AppenderTrackerTest.java Log Message: ----------- more unit tests

1 0

field encapsulation in logback classes
by Harris, Carl 25 Apr '13

25 Apr '13

There are apparently many examples of fields in logback classes that are not private to the class implementation. For example, SyslogAppenderBase contains seven examples of mutable fields that are not private. Best practice would suggest that unless there's a really good reason to break encapsulation by exposing such fields, they should be private. In the case of SyslogAppenderBase there appears to be no reason for exposing most of these fields; apparently the "private" modifier was omitted as an oversight. Properly marking fields as private is a significant aid to project contributors, in that the scope of the field is explicit and limited. Moreover, it is much easier to contemplate making changes to a properly encapsulated class. I propose that as a general practice, logback contributors should mark all mutable fields as private and expose properly documented accessor methods with appropriate access modifiers as a better alternative to allowing field state to directly accessed and possibly modified. Comments or opposing opinions? carl

2 1

[qos-ch/logback] 078aa4: make the AppenderFactory related code in c.q.logba...
by Ceki Gulcu 25 Apr '13

25 Apr '13

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: 078aa4201760ca1763250a24e92379e3a64e0fb3 https://github.com/qos-ch/logback/commit/078aa4201760ca1763250a24e92379e3a6… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2013-04-25 (Thu, 25 Apr 2013) Changed paths: R logback-access/src/main/java/ch/qos/logback/access/sift/AppenderFactory.java A logback-access/src/main/java/ch/qos/logback/access/sift/AppenderFactoryUsingJoran.java M logback-access/src/main/java/ch/qos/logback/access/sift/SiftAction.java R logback-classic/src/main/java/ch/qos/logback/classic/sift/AppenderFactory.java A logback-classic/src/main/java/ch/qos/logback/classic/sift/AppenderFactoryUsingJoran.java M logback-classic/src/main/java/ch/qos/logback/classic/sift/SiftAction.java A logback-core/src/main/java/ch/qos/logback/core/sift/AbstractAppenderFactoryUsingJoran.java A logback-core/src/main/java/ch/qos/logback/core/sift/AppenderFactory.java R logback-core/src/main/java/ch/qos/logback/core/sift/AppenderFactoryBase.java M logback-core/src/main/java/ch/qos/logback/core/sift/AppenderTracker.java M logback-core/src/main/java/ch/qos/logback/core/sift/SiftingAppenderBase.java M logback-core/src/test/java/ch/qos/logback/core/sift/AppenderTrackerTest.java Log Message: ----------- make the AppenderFactory related code in c.q.logback.core.sift suck less

1 0

[qos-ch/logback] 9041e0: make all tests pass
by Ceki Gulcu 25 Apr '13

25 Apr '13

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: 9041e0c2fe4fd569abe072521cc02c643eb771c3 https://github.com/qos-ch/logback/commit/9041e0c2fe4fd569abe072521cc02c643e… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2013-04-25 (Thu, 25 Apr 2013) Changed paths: M logback-access/src/main/java/ch/qos/logback/access/sift/AppenderFactory.java M logback-access/src/main/java/ch/qos/logback/access/sift/SiftAction.java M logback-classic/src/main/java/ch/qos/logback/classic/sift/AppenderFactory.java A logback-classic/src/test/input/joran/sift/lingering.xml M logback-core/src/main/java/ch/qos/logback/core/sift/AppenderFactoryBase.java Log Message: ----------- make all tests pass

1 0

[qos-ch/logback] 547cac: more refactoring, added unit tests
by Ceki Gulcu 25 Apr '13

25 Apr '13

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: 547cac23d6b0f24c2901c26d16dbb24346fbe77d https://github.com/qos-ch/logback/commit/547cac23d6b0f24c2901c26d16dbb24346… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2013-04-25 (Thu, 25 Apr 2013) Changed paths: M logback-access/src/main/java/ch/qos/logback/access/sift/SiftingJoranConfigurator.java M logback-access/src/test/java/ch/qos/logback/access/sift/SiftingAppenderTest.java M logback-classic/src/main/java/ch/qos/logback/classic/sift/SiftingJoranConfigurator.java M logback-classic/src/test/input/joran/sift/compositeProperty.xml M logback-classic/src/test/input/joran/sift/defaultLayoutRule.xml M logback-classic/src/test/input/joran/sift/hoard0.xml M logback-classic/src/test/input/joran/sift/lbclassic203.xml M logback-classic/src/test/input/joran/sift/multipleNesting.xml M logback-classic/src/test/input/joran/sift/propertyDefinedInSiftElement.xml M logback-classic/src/test/input/joran/sift/propertyPropagation.xml M logback-classic/src/test/input/joran/sift/smoke.xml M logback-classic/src/test/input/joran/sift/unsetDefaultValueProperty.xml M logback-classic/src/test/input/joran/sift/zeroNesting.xml M logback-classic/src/test/java/ch/qos/logback/classic/sift/SiftingAppenderTest.java M logback-core/src/main/java/ch/qos/logback/core/joran/GenericConfigurator.java M logback-core/src/main/java/ch/qos/logback/core/joran/action/IncludeAction.java M logback-core/src/main/java/ch/qos/logback/core/joran/event/SaxEventRecorder.java M logback-core/src/main/java/ch/qos/logback/core/joran/spi/Interpreter.java M logback-core/src/main/java/ch/qos/logback/core/sift/AppenderTracker.java M logback-core/src/main/java/ch/qos/logback/core/sift/SiftingAppenderBase.java M logback-core/src/main/java/ch/qos/logback/core/sift/SiftingJoranConfiguratorBase.java M logback-core/src/main/java/ch/qos/logback/core/spi/AbstractComponentTracker.java M logback-core/src/main/java/ch/qos/logback/core/spi/ComponentTracker.java M logback-core/src/main/java/ch/qos/logback/core/spi/ContextAwareImpl.java M logback-core/src/main/java/ch/qos/logback/core/spi/CyclicBufferTracker.java M logback-core/src/test/java/ch/qos/logback/core/joran/event/SaxEventRecorderTest.java M logback-core/src/test/java/ch/qos/logback/core/spi/CyclicBufferTrackerSimulator.java M logback-core/src/test/java/ch/qos/logback/core/spi/CyclicBufferTrackerT.java M logback-core/src/test/java/ch/qos/logback/core/spi/CyclicBufferTrackerTest.java R logback-core/src/test/java/ch/qos/logback/core/spi/CyclicBufferTracker_TImpl.java M logback-core/src/test/java/ch/qos/logback/core/spi/ScenarioBasedCyclicBufferTrackerTest.java Log Message: ----------- more refactoring, added unit tests

1 0

[JIRA] (LOGBACK-844) LogbackValve should use ${catalina.base} instead of ${catalina.home}
by Xavier Dury (JIRA) 25 Apr '13

25 Apr '13

1 0

[qos-ch/logback] cdb865: fix LOGBACK-846
by Ceki Gulcu 25 Apr '13

25 Apr '13

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: cdb8657fcefe28e3293f36f38b6434e61ca84f49 https://github.com/qos-ch/logback/commit/cdb8657fcefe28e3293f36f38b6434e61c… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2013-04-25 (Thu, 25 Apr 2013) Changed paths: M logback-classic/src/main/java/ch/qos/logback/classic/selector/servlet/ContextDetachingSCL.java Log Message: ----------- fix LOGBACK-846

1 0

[JIRA] (LOGBACK-846) ContextDetachingSCL throws NPE when LoggerContext has not been initialized
by Ceki Gulcu (JIRA) 25 Apr '13

25 Apr '13

1 0

[JIRA] (LOGBACK-846) ContextDetachingSCL throws NPE when LoggerContext has not been initialized
by Ceki Gulcu (JIRA) 25 Apr '13

25 Apr '13

1 0

[JIRA] (LOGBACK-846) ContextDetachingSCL throws NPE when LoggerContext has not been initialized
by Xavier Dury (JIRA) 25 Apr '13

25 Apr '13

1 0