- logback-dev - mailman3.qos.ch

[qos-ch/logback] 56c624: Always close InputStream
by Ceki Gulcu 06 Jul '12

06 Jul '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: 56c6243f20b0b64b00a0de959286ab7dd7f11db1 https://github.com/qos-ch/logback/commit/56c6243f20b0b64b00a0de959286ab7dd7… Author: Mikhail Mazursky <ash2kk(a)gmail.com> Date: 2012-07-05 (Thu, 05 Jul 2012) Changed paths: M logback-core/src/main/java/ch/qos/logback/core/joran/GenericConfigurator.java Log Message: ----------- Always close InputStream e.g. in case of JoranException from doConfigure(). Commit: 586e3385963f395d6fcd71049f39876dc89c5459 https://github.com/qos-ch/logback/commit/586e3385963f395d6fcd71049f39876dc8… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2012-07-06 (Fri, 06 Jul 2012) Changed paths: M logback-core/src/main/java/ch/qos/logback/core/joran/GenericConfigurator.java Log Message: ----------- Merge pull request #52 from ash2k/close-stream Always close InputStream Compare: https://github.com/qos-ch/logback/compare/1fb52d9f0039...586e3385963f

1 0

[qos-ch/logback-beagle] c047b7: Renaming org.slf4j to org.slf4j.feature
by Christian Trutz 05 Jul '12

05 Jul '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback-beagle Commit: c047b708a3b1f6b1fd77e20439bd49a99b7e0089 https://github.com/qos-ch/logback-beagle/commit/c047b708a3b1f6b1fd77e20439b… Author: Christian Trutz <christian.trutz(a)belaso.de> Date: 2012-07-05 (Thu, 05 Jul 2012) Changed paths: M p2-repository/ch.qos.logback.feature/feature.xml M p2-repository/ch.qos.logback.repository/category.xml A p2-repository/org.slf4j.feature/build.properties A p2-repository/org.slf4j.feature/feature.xml R p2-repository/org.slf4j/build.properties R p2-repository/org.slf4j/feature.xml Log Message: ----------- Renaming org.slf4j to org.slf4j.feature Signed-off-by: Christian Trutz <christian.trutz(a)belaso.de>

1 0

[qos-ch/logback-beagle] 780eda: enable jump to source functionality
by Christian Trutz 05 Jul '12

05 Jul '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback-beagle Commit: 780eda010e983bdd458917a5a4e30a42e28203f1 https://github.com/qos-ch/logback-beagle/commit/780eda010e983bdd458917a5a4e… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2012-06-28 (Thu, 28 Jun 2012) Changed paths: M ch.qos.logback.beagle/META-INF/MANIFEST.MF M ch.qos.logback.beagle/src/ch/qos/logback/beagle/menu/OnMenuSelectionAction.java A ch.qos.logback.beagle/src/ch/qos/logback/beagle/util/EditorUtil.java Log Message: ----------- enable jump to source functionality Commit: 88c247e4cf33991b64ad399786232fc6f3ae7d85 https://github.com/qos-ch/logback-beagle/commit/88c247e4cf33991b64ad3997862… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2012-06-29 (Fri, 29 Jun 2012) Changed paths: M ch.qos.logback.beagle/build.properties Log Message: ----------- Resulting ch.qos.logback.beagle-1.0.0.qualifier.jar now includes requried libs and class files Commit: d9a92425590cd5f53998d7a1f8630c9c9af832ad https://github.com/qos-ch/logback-beagle/commit/d9a92425590cd5f53998d7a1f86… Author: Christian Trutz <christian.trutz(a)belaso.de> Date: 2012-07-05 (Thu, 05 Jul 2012) Changed paths: M logback-beagle.target M pom.xml Log Message: ----------- Eclipse Orbit repository removed. Signed-off-by: Christian Trutz <christian.trutz(a)belaso.de> Compare: https://github.com/qos-ch/logback-beagle/compare/36caff6cb324...d9a92425590c

1 0

[qos-ch/logback-beagle] d9a924: Eclipse Orbit repository removed.
by Christian Trutz 05 Jul '12

05 Jul '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback-beagle Commit: d9a92425590cd5f53998d7a1f8630c9c9af832ad https://github.com/qos-ch/logback-beagle/commit/d9a92425590cd5f53998d7a1f86… Author: Christian Trutz <christian.trutz(a)belaso.de> Date: 2012-07-05 (Thu, 05 Jul 2012) Changed paths: M logback-beagle.target M pom.xml Log Message: ----------- Eclipse Orbit repository removed. Signed-off-by: Christian Trutz <christian.trutz(a)belaso.de>

1 0

[qos-ch/logback-beagle] 88c247: Resulting ch.qos.logback.beagle-1.0.0.qualifier.ja...
by Ceki Gulcu 05 Jul '12

05 Jul '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback-beagle Commit: 88c247e4cf33991b64ad399786232fc6f3ae7d85 https://github.com/qos-ch/logback-beagle/commit/88c247e4cf33991b64ad3997862… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2012-06-29 (Fri, 29 Jun 2012) Changed paths: M ch.qos.logback.beagle/build.properties Log Message: ----------- Resulting ch.qos.logback.beagle-1.0.0.qualifier.jar now includes requried libs and class files

3 6

[JIRA] (LOGBACK-716) SMTPAppenderBase, mimeMsg field, racing condition
by Yuri Cherio (JIRA) 05 Jul '12

05 Jul '12

1 0

[qos-ch/logback] 1fb52d: ongoing work on github style link anchoring
by Ceki Gulcu 05 Jul '12

05 Jul '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: 1fb52d9f0039d2718982d307969b47bd07b9aae2 https://github.com/qos-ch/logback/commit/1fb52d9f0039d2718982d307969b47bd07… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2012-07-05 (Thu, 05 Jul 2012) Changed paths: M logback-site/src/site/pages/css/screen.css M logback-site/src/site/pages/manual/layouts.html A logback-site/src/site/resources/css/anchor12.png A logback-site/src/site/resources/css/anchor16.png A logback-site/src/site/resources/css/anchor20.png A logback-site/src/site/resources/css/anchor24.png Log Message: ----------- ongoing work on github style link anchoring

1 0

[qos-ch/logback] b52e43: minor edits
by Ceki Gulcu 04 Jul '12

04 Jul '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: b52e432307bc2293535f6ff4e00b0c06045f7fdd https://github.com/qos-ch/logback/commit/b52e432307bc2293535f6ff4e00b0c0604… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2012-07-04 (Wed, 04 Jul 2012) Changed paths: M logback-site/src/site/pages/manual/layouts.html Log Message: ----------- minor edits

1 0

[JIRA] Created: (LBCLASSIC-272) Automatic MDC inheritance with thread pools cases false data printed in the log
by Lóránt Pintér (JIRA) 30 Jun '12

30 Jun '12

Automatic MDC inheritance with thread pools cases false data printed in the log ------------------------------------------------------------------------------- Key: LBCLASSIC-272 URL: http://jira.qos.ch/browse/LBCLASSIC-272 Project: logback-classic Issue Type: Bug Components: Other Affects Versions: 0.9.27 Environment: Applies to all Logback versions, specifically tested with Logback 0.9.27. Reporter: Lóránt Pintér Assignee: Logback dev list MDC inheritance when used in conjunction with a thread pool can turn out to be malicious. Consider the following in a web server where each line in the log contains the current user's name. 1. A web request comes in and processing is started on a thread 2. Authenticate the user (on original thread) 3. Put the user name into the MDC (on original thread) 4. Create some Runnable and pass it to a thread pool to be run in the background (on thread pool thread) Let's take a look at the logs that are printed from the Runnable created in step 4. Without automatic MDC inheritance (e.g. when using Log4J) these log lines will contain no user name. This can be good or bad, depending on what you want. If you do want the user name in these log lines, you can explicitly transfer the MDC from the originating thread to the thread pool thread. If you don't want to print the user name for background tasks, you are already done. If you have no access to the thread pool or the Runnables, you simply get no MDC information. However, if you do have automatic MDC inheritance (as with Logback), the log lines *will* contain a user name, but not from the originating thread. The thread pool thread will instead inherit its MDC from the first thread that executed a Runnable on it. This can never be what you want. You can correct this by transferring the original MDC manually, or clearing it explicitly inside your Runnable. But if you forget to do this, or you don't have access to the thread pool and the Runnables, you will end up with corrupt data in your logs. The latter can happen if you are using some third-party API that maintains its own thread pool. I can see two ways to fix this issue: 1) Make automatic MDC inhertance configurable from logback.xml. This is not a perfect solution: if you mix code that relies on MDC inheritance with code that relies on no MDC inheritance you will have no good value for this setting. 2) Remove the automatic MDC inheritance feature altogether. Instead, Logback (or even better: SLF4J) could provide some utility classes to wrap Runnable's and Callable's in something like this: {code} class MdcRetainingRunnable implements Runnable { private final Map context; public MdcRetainingRunnable { this.context = MDC.getCopyOfContextMap(); } @Override public void run() { Map originalContext = MDC.getCopyOfContextMap(); MDC.setContextMap(context); try { runWithMdc(); } finally { MDC.setContextMap(originalContext); } } abstract protected runWithMdc(); } {code} I would prefer solution #2 as it provides for the rule of least astonishment. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

3 4

[qos-ch/logback-beagle] 780eda: enable jump to source functionality
by Ceki Gulcu 28 Jun '12

28 Jun '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback-beagle Commit: 780eda010e983bdd458917a5a4e30a42e28203f1 https://github.com/qos-ch/logback-beagle/commit/780eda010e983bdd458917a5a4e… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2012-06-28 (Thu, 28 Jun 2012) Changed paths: M ch.qos.logback.beagle/META-INF/MANIFEST.MF M ch.qos.logback.beagle/src/ch/qos/logback/beagle/menu/OnMenuSelectionAction.java A ch.qos.logback.beagle/src/ch/qos/logback/beagle/util/EditorUtil.java Log Message: ----------- enable jump to source functionality

1 0