- logback-dev - mailman3.qos.ch

Looking at MongoDBAppender
by ceki 18 Jun '12

18 Jun '12

Hi Christian, I've mostly looked at the tests (not MongoDBAppender itself). Here are some preliminary remarks: 1) Mocks in tests are very useful for certain tests. However, I don't think mock tests let us verify that MongoDBAppender actually works with MongoDB. We faced a similar problem with DBAppender which supports several databases such as oracle, mysqldb, postgresql, h2, etc. During the build, there are tests which actually run against these databases but only on "conforming" hosts, i.e. hosts that are known to run a database of certain type. Here is an except from DBAppenderIntegrationTest [1] which you might find useful. public class DBAppenderIntegrationTest { static String LOCAL_HOST_NAME; // set in setUpBeforeClass() static String[] MYSQL_CONFORMING_HOST_LIST = new String[] { "xharo" }; @Test public void mysql() throws Exception { if (!isConformingHostAndJDK16OrHigher(MYSQL_CONFORMING_HOST_LIST)) { return; } doTest("src/test/input/integration/db/mysql-with-driver.xml"); } static boolean isConformingHostAndJDK16OrHigher( String[] conformingHostList) { if (!Env.isJDK6OrHigher()) { return false; } for (String conformingHost : conformingHostList) { if (conformingHost.equalsIgnoreCase(LOCAL_HOST_NAME)) { return true; } } return false; } } The idea could perhaps be applied to MongoDB as well. We'd run integration tests on machines known to deploy MongoDB and skip the tests on most other machines. Remark 2) MongoDBAppender tests use TestNG. While TestNG offers some functionality beyond Junit, in my past experience, I often had to revert to Junit because it is better supported than TestNG by various tools, in particular IDEs. From what I could see, you care not using any TestNG specific features, so moving to Junit should be easy. If you really prefer TestNG, you are welcome to put the issue to a vote and we'll all use the tool with the most votes. However, it seems awkward to use TestNG in some parts of the project and JUnit in others. Relying on a must-have TestNG-only feature is a different matter which may justify TestNG in a particular test case. Remark 3) If I understand correctly, Jmockit relies on a java-agent to execute? Is there a way to run Jmockit without a javaagent? Remark 4) No logback-ext module should depend on logback-access and logback-classic at the same time. Otherwise, when such a module is used, it will pull in both logback-access and logback-classic into the client's project. This may have unintended consequences. In the most common deployment scenario, logback-access is deployed on the server's lib/ folder whereas logback-classic is deployed in a web-app. We don't want to break that common deployment scenario. Given the above, I would suggest to break mongodb into two modules, one for logback-access and one for logback-classic. Notwithstanding the above remarks, I am looking forward to testing logback-mongodb-* once I install MongoDB on my local machine. [1] http://tinyurl.com/d2anyzb -- Ceki http://twitter.com/#!/ceki

2 4

[qos-ch/logback-extensions] 0e46b0: Failed test corrected.
by Christian Trutz 18 Jun '12

18 Jun '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback-extensions Commit: 0e46b065c39581954d70efc6e2fc55e2199cd9fe https://github.com/qos-ch/logback-extensions/commit/0e46b065c39581954d70efc… Author: Christian Trutz <christian.trutz(a)belaso.de> Date: 2012-06-18 (Mon, 18 Jun 2012) Changed paths: M mongodb/src/test/java/ch/qos/logback/ext/mongodb/MongoDBAccessEventAppenderTest.java Log Message: ----------- Failed test corrected. Signed-off-by: Christian Trutz <christian.trutz(a)belaso.de>

1 0

[qos-ch/logback-extensions] f050d9: ONLY TEST: Provoke Jenkins build fail.
by Christian Trutz 18 Jun '12

18 Jun '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback-extensions Commit: f050d9f8083378074da9e4d9815f4e030dd17ab8 https://github.com/qos-ch/logback-extensions/commit/f050d9f8083378074da9e4d… Author: Christian Trutz <christian.trutz(a)belaso.de> Date: 2012-06-18 (Mon, 18 Jun 2012) Changed paths: M mongodb/src/test/java/ch/qos/logback/ext/mongodb/MongoDBAccessEventAppenderTest.java Log Message: ----------- ONLY TEST: Provoke Jenkins build fail. Signed-off-by: Christian Trutz <christian.trutz(a)belaso.de> Commit: 4020edeea949c829b80f5f1d2ced2471c9058746 https://github.com/qos-ch/logback-extensions/commit/4020edeea949c829b80f5f1… Author: Christian Trutz <christian.trutz(a)belaso.de> Date: 2012-06-18 (Mon, 18 Jun 2012) Changed paths: M mongodb/src/main/java/ch/qos/logback/ext/mongodb/MongoDBLoggingEventAppender.java Log Message: ----------- Merge branch 'master' of https://github.com/qos-ch/logback-extensions.git Compare: https://github.com/qos-ch/logback-extensions/compare/1d76015c63d5...4020ede…

1 0

Copyright headers
by ceki 18 Jun '12

18 Jun '12

Hello Christian, Joern, Les, Tomasz, Tony, as well all future contributors, I am super thrilled to see the logback-extensions project taking off with contribution flowing in. It makes it all the more important to tackle legal issues as early as possible in order to as to avoid ill-will in the future. No one likes to see the rules change in mid-flight. My apologies for not clarifying this before. As you are probably aware, the CLA [1] assigns copyright of your contributors to QOS.ch (see section 2). Thus, it makes sense to state QOS.ch as the copyright holder and not each individual contributor. To be blunt, QOS.ch cannot release software for which it does not hold copyright. Of course, the various @author tags and commit history reveal the actual authors, pursuant the authors' moral rights [2]. More concretely, the headers in [3, 4, 5] need to change from * Copyright 2012 Tomasz Nurkiewicz, Christian Trutz, et. al. * Copyright 2012 Ceki Gulcu, Les Hazlewood, et. al. * Copyright 2012 Ceki Gulcu, Anthony Trinh, et. al. to * Copyright (C) 2012, QOS.ch. All rights reserved. The Apache License is OK for the moment although we should one day settle for either Apache or LGPL+EPL for *both* logback and logback-extensions. Having two separate licenses for two closely related projects is a little incoherent. Please let me know if you agree or oppose this change. All comments are most welcome. [1] http://logback.qos.ch/cla.txt [2] http://en.wikipedia.org/wiki/Moral_rights_(copyright_law) [3] http://bit.ly/KyxC3E [4] http://bit.ly/MMIINk [5] http://bit.ly/Lf2DJh -- Ceki http://twitter.com/#!/ceki

5 12

relative paths to parent pom
by ceki 18 Jun '12

18 Jun '12

Hi all, I can't think of any valid reason to use relative paths to the parent pom in logback-ext. Relative paths seem confuses my IDE (IntelliJ) and it's pita. Any objections to me removing relative paths to the parent pom? Cheers, -- Ceki http://twitter.com/#!/ceki

2 2

[qos-ch/logback-extensions] 19ca22: Including MDC map if exists in log entry
by Tomasz Nurkiewicz 18 Jun '12

18 Jun '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback-extensions Commit: 19ca22b630d73de88905323fe3341350f6cc3971 https://github.com/qos-ch/logback-extensions/commit/19ca22b630d73de88905323… Author: Tomasz Nurkiewicz <nurkiewicz(a)gmail.com> Date: 2012-06-18 (Mon, 18 Jun 2012) Changed paths: M mongodb/src/main/java/ch/qos/logback/ext/mongodb/MongoDBLoggingEventAppender.java Log Message: ----------- Including MDC map if exists in log entry Commit: ea992b3028012b732f5ec9fbb4339c134bbbee2c https://github.com/qos-ch/logback-extensions/commit/ea992b3028012b732f5ec9f… Author: Tomasz Nurkiewicz <nurkiewicz(a)gmail.com> Date: 2012-06-18 (Mon, 18 Jun 2012) Changed paths: M mongodb/src/main/java/ch/qos/logback/ext/mongodb/MongoDBLoggingEventAppender.java Log Message: ----------- Including caller data if requested in log entry (disabled by default since introduces severe overhead) Commit: 48ed30507d62049b8046f3fb57c4b480b1376a32 https://github.com/qos-ch/logback-extensions/commit/48ed30507d62049b8046f3f… Author: Tomasz Nurkiewicz <nurkiewicz(a)gmail.com> Date: 2012-06-18 (Mon, 18 Jun 2012) Changed paths: M mongodb/src/main/java/ch/qos/logback/ext/mongodb/MongoDBLoggingEventAppender.java Log Message: ----------- Including explicit log event arguments (like ids) passed when logging in log entry Commit: 1d76015c63d5d4a54378b62a05ed977e8c6a36b5 https://github.com/qos-ch/logback-extensions/commit/1d76015c63d5d4a54378b62… Author: Tomasz Nurkiewicz <nurkiewicz(a)gmail.com> Date: 2012-06-18 (Mon, 18 Jun 2012) Changed paths: M mongodb/src/main/java/ch/qos/logback/ext/mongodb/MongoDBLoggingEventAppender.java Log Message: ----------- Including exception stack trace in log entry as a sub document/array to take advantage of document-oriented storage Compare: https://github.com/qos-ch/logback-extensions/compare/a4919204972f...1d76015…

1 0

[qos-ch/logback-extensions] a49192: removed logback-access/logback-classic dependency ...
by Ceki Gulcu 18 Jun '12

18 Jun '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback-extensions Commit: a4919204972faf856789c1678e51661c327596a9 https://github.com/qos-ch/logback-extensions/commit/a4919204972faf856789c16… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2012-06-18 (Mon, 18 Jun 2012) Changed paths: M eclipse/pom.xml M json/classic/pom.xml M json/core/pom.xml M loggly/pom.xml M mongodb/pom.xml M pom.xml M spring/pom.xml Log Message: ----------- removed logback-access/logback-classic dependency from parent pom

1 0

[qos-ch/logback-extensions] 6993df: remove relative paths to parent pom
by Ceki Gulcu 18 Jun '12

18 Jun '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback-extensions Commit: 6993dfa2ee7961e20982a1bd4412dcd47021e74d https://github.com/qos-ch/logback-extensions/commit/6993dfa2ee7961e20982a1b… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2012-06-18 (Mon, 18 Jun 2012) Changed paths: M eclipse/pom.xml M jackson/pom.xml M json/classic/pom.xml M json/core/pom.xml M json/pom.xml M loggly/pom.xml M mongodb/pom.xml M pom.xml M spring/pom.xml Log Message: ----------- remove relative paths to parent pom

1 0

[qos-ch/logback-extensions] c36091: Rename MongoDBAppenderBase#setURI to MongoDBAppend...
by Christian Trutz 18 Jun '12

18 Jun '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback-extensions Commit: c3609179aee8c3d9814194f4efbb71d7287d41ae https://github.com/qos-ch/logback-extensions/commit/c3609179aee8c3d9814194f… Author: Christian Trutz <christian.trutz(a)belaso.de> Date: 2012-06-18 (Mon, 18 Jun 2012) Changed paths: M mongodb/src/main/java/ch/qos/logback/ext/mongodb/MongoDBAppenderBase.java M mongodb/src/test/java/ch/qos/logback/ext/mongodb/MongoDBAppenderBaseTest.java Log Message: ----------- Rename MongoDBAppenderBase#setURI to MongoDBAppenderBase#setUri. Signed-off-by: Christian Trutz <christian.trutz(a)belaso.de>

1 0

[qos-ch/logback-extensions] c0737f: Renaming MongoDBAccessAppender to MongoDBAccessEve...
by Christian Trutz 18 Jun '12

18 Jun '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback-extensions Commit: c0737f08f9b10e31cdd658824fd75fd8e5683faf https://github.com/qos-ch/logback-extensions/commit/c0737f08f9b10e31cdd6588… Author: Christian Trutz <christian.trutz(a)belaso.de> Date: 2012-06-18 (Mon, 18 Jun 2012) Changed paths: R mongodb/src/main/java/ch/qos/logback/ext/mongodb/MongoDBAccessAppender.java A mongodb/src/main/java/ch/qos/logback/ext/mongodb/MongoDBAccessEventAppender.java A mongodb/src/main/java/ch/qos/logback/ext/mongodb/MongoDBLoggingEventAppender.java R mongodb/src/test/java/ch/qos/logback/ext/mongodb/MongoDBAccessAppenderTest.java A mongodb/src/test/java/ch/qos/logback/ext/mongodb/MongoDBAccessEventAppenderTest.java Log Message: ----------- Renaming MongoDBAccessAppender to MongoDBAccessEventAppender and introduction of MongoDBLoggingEventAppender. Signed-off-by: Christian Trutz <christian.trutz(a)belaso.de>

1 0