- logback-dev - mailman3.qos.ch

[JIRA] Created: (LBCLASSIC-177) Provide an appender similar to log4js AsyncAppender
by Torsten Juergeleit (JIRA) 31 May '12

31 May '12

Provide an appender similar to log4js AsyncAppender --------------------------------------------------- Key: LBCLASSIC-177 URL: http://jira.qos.ch/browse/LBCLASSIC-177 Project: logback-classic Issue Type: New Feature Components: appender Affects Versions: unspecified Reporter: Torsten Juergeleit Assignee: Logback dev list We're using log4j successfully in financial B2B / B2C web applications for years. Now we would like to adopt Logback but therefore we need support for an asynchronous appender decorator like log4js AsyncAppender. Attached you can find my take on this kind of appender cobbled together from ideas and code from various places: * http://logging.apache.org/log4j/1.2/xref/org/apache/log4j/AsyncAppender.html * http://jira.qos.ch/browse/LBCLASSIC-20 * http://jira.qos.ch/browse/LBCLASSIC-176 * http://www.simonsite.org.uk/ -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

5 12

[qos-ch/logback] f495e5: completed work on AsyncAppender
by Ceki Gulcu 31 May '12

31 May '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: f495e50ba6ee5707680b2945f706e42af635beb0 https://github.com/qos-ch/logback/commit/f495e50ba6ee5707680b2945f706e42af6… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2012-05-31 (Thu, 31 May 2012) Changed paths: M logback-classic/src/main/java/ch/qos/logback/classic/AsyncAppender.java A logback-classic/src/test/java/ch/qos/logback/classic/AsyncAppenderTest.java M logback-classic/src/test/java/ch/qos/logback/classic/net/testObjectBuilders/Builder.java A logback-classic/src/test/java/ch/qos/logback/classic/net/testObjectBuilders/LoggingEventBuilderInContext.java M logback-classic/src/test/java/ch/qos/logback/classic/net/testObjectBuilders/LoggingEventWithParametersBuilder.java M logback-core/src/main/java/ch/qos/logback/core/AsyncAppenderBase.java M logback-core/src/main/java/ch/qos/logback/core/spi/AppenderAttachableImpl.java M logback-core/src/test/java/ch/qos/logback/core/AsyncAppenderBaseTest.java A logback-core/src/test/java/ch/qos/logback/core/testUtil/NPEAppender.java M logback-core/src/test/java/ch/qos/logback/core/util/OptionHelperTest.java M logback-site/src/site/pages/manual/appenders.html M logback-site/src/site/pages/volunteer.html Log Message: ----------- completed work on AsyncAppender

1 0

[qos-ch/logback] 2e74a0: ongoing work on AsyncAppender
by Ceki Gulcu 30 May '12

30 May '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: 2e74a013d74eb14bae046627b3ba3e6e11a556bc https://github.com/qos-ch/logback/commit/2e74a013d74eb14bae046627b3ba3e6e11… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2012-05-30 (Wed, 30 May 2012) Changed paths: A logback-classic/src/main/java/ch/qos/logback/classic/AsyncAppender.java M logback-core/src/main/java/ch/qos/logback/core/AsyncAppenderBase.java A logback-examples/src/main/java/chapters/appenders/conf/logback-async.xml M logback-site/src/site/pages/manual/appenders.html M logback-site/src/site/pages/manual/configuration.html M logback-site/src/site/pages/manual/encoders.html M logback-site/src/site/pages/news.html R logback-site/src/site/resources/images/devoxx09.jpeg R logback-site/src/site/resources/images/jazoon09.gif Log Message: ----------- ongoing work on AsyncAppender

1 0

[JIRA] (LBGENERAL-54) Unable to run tests
by Dale Wijnand (JIRA) 30 May '12

30 May '12

2 6

[qos-ch/logback] ef9f12: Make sure AsyncAppenderBaseTest tests have a timeo...
by Ceki Gulcu 30 May '12

30 May '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: ef9f12ba16e25c08a021850eb21032099e50372c https://github.com/qos-ch/logback/commit/ef9f12ba16e25c08a021850eb21032099e… Author: Dale Wijnand <dale.wijnand(a)gmail.com> Date: 2012-05-30 (Wed, 30 May 2012) Changed paths: M logback-core/src/test/java/ch/qos/logback/core/AsyncAppenderBaseTest.java Log Message: ----------- Make sure AsyncAppenderBaseTest tests have a timeout (LBGENERAL-54). I had an issue where I wasn't able to run the tests because the build hung after ch.qos.logback.core.util.StatusPrinterTest. By git bisecting I found that the issue was in the f2d15babe3275e7b0d618a020f09a863a0fa6a54 commit. Eventually after much trial and error & head-scratching I stumbed upon a fix involving making sure that each AsyncAppenderBaseTest test method had a timeout. Commit: 5ebb0e03a9eb819cf2b3e83af0b7c0e13b3ff1b3 https://github.com/qos-ch/logback/commit/5ebb0e03a9eb819cf2b3e83af0b7c0e13b… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2012-05-30 (Wed, 30 May 2012) Changed paths: M logback-core/src/test/java/ch/qos/logback/core/AsyncAppenderBaseTest.java Log Message: ----------- Merge pull request #48 from dwijnand/LBGENERAL-54 Make sure AsyncAppenderBaseTest tests have a timeout (LBGENERAL-54). Compare: https://github.com/qos-ch/logback/compare/685b0aa...5ebb0e0

1 0

[qos-ch/logback] 685b0a: typo fix
by Ceki Gulcu 30 May '12

30 May '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: 685b0aa263dc4214bea44d6734584590d4d6b99d https://github.com/qos-ch/logback/commit/685b0aa263dc4214bea44d6734584590d4… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2012-05-30 (Wed, 30 May 2012) Changed paths: M logback-access/src/main/java/ch/qos/logback/access/joran/action/ConfigurationAction.java M logback-classic/src/main/java/ch/qos/logback/classic/joran/action/ConfigurationAction.java Log Message: ----------- typo fix

1 0

[qos-ch/logback] 0987ec: fix LBCLASSIC-225
by Ceki Gulcu 30 May '12

30 May '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: 0987ec3c5af72d7146b958414bc935dc14507e44 https://github.com/qos-ch/logback/commit/0987ec3c5af72d7146b958414bc935dc14… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2012-05-30 (Wed, 30 May 2012) Changed paths: M logback-access/src/main/java/ch/qos/logback/access/joran/action/ConfigurationAction.java M logback-classic/src/main/java/ch/qos/logback/classic/joran/action/ConfigurationAction.java M logback-site/src/site/pages/manual/configuration.html M logback-site/src/site/pages/news.html Log Message: ----------- fix LBCLASSIC-225

1 0

[JIRA] Created: (LBCORE-137) PatternLayout does not really respect ISO8601 for date time
by Brice Dutheil (JIRA) 30 May '12

30 May '12

PatternLayout does not really respect ISO8601 for date time ----------------------------------------------------------- Key: LBCORE-137 URL: http://jira.qos.ch/browse/LBCORE-137 Project: logback-core Issue Type: Improvement Components: Layout Affects Versions: 0.9.19 Environment: irrelevant here Reporter: Brice Dutheil Assignee: Logback dev list Using the default "%d" "%date" or %d{ISO8601} does not output a correct ISO 8601 formatted date and time representation. Indeed there is a space between the date and the time, as the specification says having a space separator means there two fields : a 'date field' and a 'time field'. The specification consider this as acceptable for human reading though. However when processing logs it might cause some trouble to effectively parse the fields, especially when correlating logs from different applications. For now we have workarounds, but it seems reasonable to have a correct ISO8601 formatting. The correct ISO8601 representation for a 'date and time field' is to have the T indicator, for example '2007-03-01T13:00:00Z'. The workaround for now is to write ourself the correct ISO8601 pattern. Oh and by the way the timezone formatting options in the SimpleDateFormat are incomplete. The JodaTime format class org.joda.time.format.ISODateTimeFormat worth a look on this matter. Anyway date and time related classes in the JDK are not known for being the best at what they do. This problem is also found in log4j. An excerpt of the specification is documented on wikipedia. http://en.wikipedia.org/wiki/ISO_8601#Combined_date_and_time_representations -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

3 2

[qos-ch/logback] 5cba8e: LBCLASSIC-225 - Take debug setting from environmen...
by Ceki Gulcu 30 May '12

30 May '12

Branch: refs/heads/master Home: https://github.com/qos-ch/logback Commit: 5cba8ef5b01a4648fa6e5b404ad62d9f6f5a0cb9 https://github.com/qos-ch/logback/commit/5cba8ef5b01a4648fa6e5b404ad62d9f6f… Author: Antony Stubbs <antony.stubbs(a)gmail.com> Date: 2012-05-22 (Tue, 22 May 2012) Changed paths: M logback-classic/src/main/java/ch/qos/logback/classic/joran/action/ConfigurationAction.java Log Message: ----------- LBCLASSIC-225 - Take debug setting from environment property Commit: ddfe8c3123e96623ed87b4ea50eb5da9e4b87580 https://github.com/qos-ch/logback/commit/ddfe8c3123e96623ed87b4ea50eb5da9e4… Author: Ceki Gulcu <ceki(a)qos.ch> Date: 2012-05-30 (Wed, 30 May 2012) Changed paths: M logback-classic/src/main/java/ch/qos/logback/classic/joran/action/ConfigurationAction.java Log Message: ----------- Merge pull request #47 from astubbs/debug LBCLASSIC-225 - Take debug setting from environment property Compare: https://github.com/qos-ch/logback/compare/91317ef...ddfe8c3

1 0

[JIRA] Created: (LBCLASSIC-295) MarkerFilter doesn't recognize nested markers.
by Paolo Mazzoncini (JIRA) 29 May '12

29 May '12

MarkerFilter doesn't recognize nested markers. ---------------------------------------------- Key: LBCLASSIC-295 URL: http://jira.qos.ch/browse/LBCLASSIC-295 Project: logback-classic Issue Type: Bug Components: Other Affects Versions: 0.9.29 Environment: MacOsx, Jdk 1.6 update 26 Reporter: Paolo Mazzoncini Assignee: Logback dev list I was trying to use nested markers to organize my logs in a better (maybe) way. But the MarkerFilter (ch.qos.logback.classic.turbo.MarkerFilter) did not treat nested (or composite) markers as I expect. Here a test that shows this issue, this test can be appended to ch.qos.logback.classic.turbo.MarkerFilterTest: @Test public void testComposite(){ String compositeMarkerName = "compositeMarker"; Marker compositeMarker=MarkerFactory.getMarker(compositeMarkerName); compositeMarker.add(totoMarker); MarkerFilter mkt = new MarkerFilter(); mkt.setMarker(MARKER_NAME); mkt.setOnMatch("ACCEPT"); mkt.setOnMismatch("DENY"); mkt.start(); assertTrue(mkt.isStarted()); assertEquals(FilterReply.DENY, mkt.decide(null, null, null, null, null, null)); assertEquals(FilterReply.ACCEPT, mkt.decide(totoMarker, null, null, null, null, null)); assertEquals(FilterReply.ACCEPT, mkt.decide(compositeMarker, null, null, null, null, null)); } The solution that I found is pretty simple, here is the patch: diff --git a/logback-classic/src/main/java/ch/qos/logback/classic/turbo/MarkerFilter.java b/logback-classic/src/main/java/ch/qos/logback/classic/turbo/MarkerFilter.java index 8e133cb..434b035 100644 --- a/logback-classic/src/main/java/ch/qos/logback/classic/turbo/MarkerFilter.java +++ b/logback-classic/src/main/java/ch/qos/logback/classic/turbo/MarkerFilter.java @@ -47,7 +47,7 @@ public class MarkerFilter extends MatchingFilter { return onMismatch; } - if(markerToMatch.contains(marker)) { + if(marker.contains(markerToMatch)) { return onMatch; } else { return onMismatch; -- 1.7.5.4 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

3 4