- logback-dev - mailman3.qos.ch

[GIT] Logback: the generic, reliable, fast and flexible logging framework. annotated tag v_1.0.3 created. v_1.0.3
by git-noreply＠pixie.qos.ch 03 May '12

03 May '12

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The annotated tag, v_1.0.3 has been created at 8b73e192d656ed2b6a4a3a8352421cc6e93cdbe1 (tag) tagging 791680229b8644535b7b6e9b1aa8dc5ad1e17e0c (commit) replaces v_1.0.2 tagged by Ceki Gulcu on Fri May 4 00:53:39 2012 +0200 - Log ----------------------------------------------------------------- 1.0.3 Ceki Gulcu (13): start work on 1.0.3 add blurb about outputPatternAsPresentationHeader option The ConsoleAppender created by BasicConfigurator should not output its pattern string Fixing LBCORE-243 by reintroducing buffered streaming and immediate flush as an option fix LBCORE-243 Fix http://jira.qos.ch/browse/LBCLASSIC-256 Fix http://jira.qos.ch/browse/LBCLASSIC-256 outputPatternAsPresentationHeader renamed as outputPatternAsHeader and is now false by default working on lbclassic232 fixing lbclassic232 minor edit added blurb about LBCLASSIC-323 release 1.0.3 ----------------------------------------------------------------------- hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch master updated. v_1.0.2-13-g7916802
by git-noreply＠pixie.qos.ch 03 May '12

03 May '12

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via 791680229b8644535b7b6e9b1aa8dc5ad1e17e0c (commit) from 0a414247cfd3c6a04f241f89fc8fc7382be40e35 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=791680229b8644535b7b6e9b… http://github.com/ceki/logback/commit/791680229b8644535b7b6e9b1aa8dc5ad1e17… commit 791680229b8644535b7b6e9b1aa8dc5ad1e17e0c Author: Ceki Gulcu <ceki(a)qos.ch> Date: Fri May 4 00:53:16 2012 +0200 release 1.0.3 diff --git a/logback-access/pom.xml b/logback-access/pom.xml index e62dbea..5774402 100644 --- a/logback-access/pom.xml +++ b/logback-access/pom.xml @@ -7,7 +7,7 @@ <parent> <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>1.0.3-SNAPSHOT</version> + <version>1.0.3</version> </parent> <artifactId>logback-access</artifactId> diff --git a/logback-classic/pom.xml b/logback-classic/pom.xml index 8404054..3dacd5c 100644 --- a/logback-classic/pom.xml +++ b/logback-classic/pom.xml @@ -7,7 +7,7 @@ <parent> <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>1.0.3-SNAPSHOT</version> + <version>1.0.3</version> </parent> <artifactId>logback-classic</artifactId> diff --git a/logback-core/pom.xml b/logback-core/pom.xml index c20077d..3018943 100644 --- a/logback-core/pom.xml +++ b/logback-core/pom.xml @@ -7,7 +7,7 @@ <parent> <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>1.0.3-SNAPSHOT</version> + <version>1.0.3</version> </parent> <artifactId>logback-core</artifactId> diff --git a/logback-examples/pom.xml b/logback-examples/pom.xml index ee401a4..c472a4f 100644 --- a/logback-examples/pom.xml +++ b/logback-examples/pom.xml @@ -5,7 +5,7 @@ <parent> <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>1.0.3-SNAPSHOT</version> + <version>1.0.3</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/logback-site/pom.xml b/logback-site/pom.xml index 42a43f0..59ba11e 100644 --- a/logback-site/pom.xml +++ b/logback-site/pom.xml @@ -5,7 +5,7 @@ <parent> <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>1.0.3-SNAPSHOT</version> + <version>1.0.3</version> </parent> <modelVersion>4.0.0</modelVersion> diff --git a/logback-site/src/site/pages/news.html b/logback-site/src/site/pages/news.html index a2ad6ee..9fc982e 100644 --- a/logback-site/src/site/pages/news.html +++ b/logback-site/src/site/pages/news.html @@ -30,7 +30,7 @@ <hr width="80%" align="center" /> - <h3>3rd of May, 2012 - Release of version 1.0.3</h3> + <h3>4rd of May, 2012 - Release of version 1.0.3</h3> <code>PatternLayoutEncoder</code> class now admits the <a diff --git a/pom.xml b/pom.xml index f2b9998..53975fc 100755 --- a/pom.xml +++ b/pom.xml @@ -6,7 +6,7 @@ <groupId>ch.qos.logback</groupId> <artifactId>logback-parent</artifactId> - <version>1.0.3-SNAPSHOT</version> + <version>1.0.3</version> <packaging>pom</packaging> <name>Logback-Parent</name> <description>logback project pom.xml file</description> ----------------------------------------------------------------------- Summary of changes: logback-access/pom.xml | 2 +- logback-classic/pom.xml | 2 +- logback-core/pom.xml | 2 +- logback-examples/pom.xml | 2 +- logback-site/pom.xml | 2 +- logback-site/src/site/pages/news.html | 2 +- pom.xml | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

Release of logback version 1.0.3
by ceki 03 May '12

03 May '12

Hello all, I am happy to announce the release of logback version 1.0.3. It should hit the Maven central repository within the next 24 hours. Please refer to the news page for precise details of this release. http://logback.qos.ch/news.html You can download logback, including full source code, class files and documentation on our download page, shown below. http://logback.qos.ch/download.html You can receive logback related announcements by subscribing to the QOS.ch announce mailing list. To subscribe to QOS.ch announce list, please visit the following URL. http://www.qos.ch/mailman/listinfo/announce Enjoy, -- Ceki http://twitter.com/#!/ceki

1 0

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch master updated. v_1.0.2-12-g0a41424
by git-noreply＠pixie.qos.ch 03 May '12

03 May '12

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via 0a414247cfd3c6a04f241f89fc8fc7382be40e35 (commit) via 44525ee9b121f5856f1e28c94d533d2f36bfe709 (commit) from 56add24c8e14fe96b7597d18820b7b20c4537acb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=0a414247cfd3c6a04f241f89… http://github.com/ceki/logback/commit/0a414247cfd3c6a04f241f89fc8fc7382be40… commit 0a414247cfd3c6a04f241f89fc8fc7382be40e35 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Fri May 4 00:29:09 2012 +0200 added blurb about LBCLASSIC-323 diff --git a/logback-site/src/site/pages/news.html b/logback-site/src/site/pages/news.html index 70c8002..a2ad6ee 100644 --- a/logback-site/src/site/pages/news.html +++ b/logback-site/src/site/pages/news.html @@ -41,7 +41,6 @@ href="http://jira.qos.ch/browse/LBCORE-243">LBCORE-243</a>. - In order to facilitate parsing of log files, logback can now <a href="manual/encoders.html#outputPatternAsHeader">output the pattern</a> used for the log output at the top of log files as a @@ -49,6 +48,16 @@ href="http://jira.qos.ch/browse/LBCORE-234">LBCORE-234</a>. + <code>SMTPAppender</code> failed to transmit messages under JDK + 1.5. After some investigation, Dave dicovered that this was due to + setting the <code>corePoolSize</code> parameter of the relavant + <code>ThreadPoolExecutor</code> to 0. Setting + <code>corePoolSize</code> to a higher value, e.g. 1, under JDK 1.5 + solves the problem and fixes <a + href="http://jira.qos.ch/browse/LBCLASSIC-323">LBCLASSIC-323</a> + reported by Lutz Huehnken. + + <code>LevelChangePropagator</code> now retains references to j.u.l. loggers whose level it sets. This fixes garbage collection issues reported in <a http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=44525ee9b121f5856f1e28c9… http://github.com/ceki/logback/commit/44525ee9b121f5856f1e28c94d533d2f36bfe… commit 44525ee9b121f5856f1e28c94d533d2f36bfe709 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Fri May 4 00:19:24 2012 +0200 minor edit diff --git a/logback-core/src/main/java/ch/qos/logback/core/ContextBase.java b/logback-core/src/main/java/ch/qos/logback/core/ContextBase.java index e274179..c22795e 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/ContextBase.java +++ b/logback-core/src/main/java/ch/qos/logback/core/ContextBase.java @@ -36,6 +36,8 @@ public class ContextBase implements Context { Object configurationLock = new Object(); + // CORE_POOL_SIZE must be 1 for JDK 1.5. For JD 1.6 or higher it's set to 0 + // so that there are no idle threads private static final int CORE_POOL_SIZE = EnvUtil.isJDK5() ? 1 : 0; // 0 (JDK 1,6+) or 1 (JDK 1.5) idle threads, 2 maximum threads, no idle waiting ----------------------------------------------------------------------- Summary of changes: .../main/java/ch/qos/logback/core/ContextBase.java | 2 ++ logback-site/src/site/pages/news.html | 11 ++++++++++- 2 files changed, 12 insertions(+), 1 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch master updated. v_1.0.2-10-g56add24
by git-noreply＠pixie.qos.ch 03 May '12

03 May '12

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via 56add24c8e14fe96b7597d18820b7b20c4537acb (commit) from fdd1363fa8fb6798a1aef048f580c82d3a5cdc51 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=56add24c8e14fe96b7597d18… http://github.com/ceki/logback/commit/56add24c8e14fe96b7597d18820b7b20c4537… commit 56add24c8e14fe96b7597d18820b7b20c4537acb Author: Ceki Gulcu <ceki(a)qos.ch> Date: Fri May 4 00:11:01 2012 +0200 fixing lbclassic232 diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic232/Barebones.java b/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic232/Barebones.java new file mode 100644 index 0000000..f8cdf56 --- /dev/null +++ b/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic232/Barebones.java @@ -0,0 +1,32 @@ +package ch.qos.logback.classic.issue.lbclassic232; + +import ch.qos.logback.core.Context; +import ch.qos.logback.core.ContextBase; + +public class Barebones { + + public static void main(String[] args) { + Context context = new ContextBase(); + for(int i = 0; i < 3; i++) { + SenderRunnable senderRunnable = new SenderRunnable(""+i); + context.getExecutorService().execute(senderRunnable); + } + System.out.println("done"); + //System.exit(0); + } + + static class SenderRunnable implements Runnable { + String id; + SenderRunnable(String id) { + this.id = id; + } + + public void run() { + try { + Thread.sleep(2000); + } catch (InterruptedException e) { + } + System.out.println("SenderRunnable " +id); + } + } +} diff --git a/logback-core/src/main/java/ch/qos/logback/core/ContextBase.java b/logback-core/src/main/java/ch/qos/logback/core/ContextBase.java index cd58377..e274179 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/ContextBase.java +++ b/logback-core/src/main/java/ch/qos/logback/core/ContextBase.java @@ -18,6 +18,7 @@ import java.util.Map; import java.util.concurrent.*; import ch.qos.logback.core.status.StatusManager; +import ch.qos.logback.core.util.EnvUtil; import static ch.qos.logback.core.CoreConstants.CONTEXT_NAME_KEY; @@ -35,8 +36,10 @@ public class ContextBase implements Context { Object configurationLock = new Object(); - // 0 idle threads, 2 maximum threads, no idle waiting - ExecutorService executorService = new ThreadPoolExecutor(0, 2, + private static final int CORE_POOL_SIZE = EnvUtil.isJDK5() ? 1 : 0; + + // 0 (JDK 1,6+) or 1 (JDK 1.5) idle threads, 2 maximum threads, no idle waiting + ExecutorService executorService = new ThreadPoolExecutor(CORE_POOL_SIZE, 2, 0L, TimeUnit.MILLISECONDS, new LinkedBlockingQueue<Runnable>()); diff --git a/logback-core/src/main/java/ch/qos/logback/core/util/EnvUtil.java b/logback-core/src/main/java/ch/qos/logback/core/util/EnvUtil.java index 08e0e5e..1f9b7c0 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/util/EnvUtil.java +++ b/logback-core/src/main/java/ch/qos/logback/core/util/EnvUtil.java @@ -19,17 +19,18 @@ package ch.qos.logback.core.util; public class EnvUtil { - static public boolean isGroovyAvailable() { - ClassLoader classLoader = EnvUtil.class.getClassLoader(); - try { - Class bindingClass = classLoader.loadClass("groovy.lang.Binding"); - return (bindingClass != null); - } catch (ClassNotFoundException e) { + static public boolean isJDK5() { + String javaVersion = System.getProperty("java.version"); + if (javaVersion == null) { + return false; + } + if (javaVersion.startsWith("1.5")) { + return true; + } else { return false; } } - static public boolean isJaninoAvailable() { ClassLoader classLoader = EnvUtil.class.getClassLoader(); try { ----------------------------------------------------------------------- Summary of changes: .../classic/issue/lbclassic232/Barebones.java | 32 ++++++++++++++++++++ .../main/java/ch/qos/logback/core/ContextBase.java | 7 +++- .../java/ch/qos/logback/core/util/EnvUtil.java | 15 +++++---- 3 files changed, 45 insertions(+), 9 deletions(-) create mode 100644 logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic232/Barebones.java hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch master updated. v_1.0.2-9-gfdd1363
by git-noreply＠pixie.qos.ch 03 May '12

03 May '12

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via fdd1363fa8fb6798a1aef048f580c82d3a5cdc51 (commit) from 22126c5c13088502dc0b5c9c7dda4218ac3c8978 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=fdd1363fa8fb6798a1aef048… http://github.com/ceki/logback/commit/fdd1363fa8fb6798a1aef048f580c82d3a5cd… commit fdd1363fa8fb6798a1aef048f580c82d3a5cdc51 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Thu May 3 21:36:35 2012 +0200 working on lbclassic232 diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic232/Simple.java b/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic232/Simple.java new file mode 100644 index 0000000..a700160 --- /dev/null +++ b/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic232/Simple.java @@ -0,0 +1,34 @@ +package ch.qos.logback.classic.issue.lbclassic232; + +import ch.qos.logback.classic.LoggerContext; +import ch.qos.logback.classic.joran.JoranConfigurator; +import ch.qos.logback.core.joran.spi.JoranException; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class Simple { + + static Logger logger = LoggerFactory.getLogger(Simple.class); + static String DIR_PREFIX = "src/test/java/ch/qos/logback/classic/issue/lbclassic232/"; + + public static void main(String[] args) throws JoranException, InterruptedException { + init(DIR_PREFIX + "logback_smtp.xml"); + + for (int i = 0; i < 10; i++) { + logger.debug("SEE IF THIS IS LOGGED {}.", i); + } + + logger.error("trigger"); + + } + + + static void init(String file) throws JoranException { + LoggerContext loggerContext = (LoggerContext) LoggerFactory.getILoggerFactory(); + JoranConfigurator jc = new JoranConfigurator(); + jc.setContext(loggerContext); + loggerContext.reset(); + jc.doConfigure(file); + } + +} diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic232/logback_smtp.xml b/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic232/logback_smtp.xml new file mode 100644 index 0000000..6b39693 --- /dev/null +++ b/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic232/logback_smtp.xml @@ -0,0 +1,18 @@ +<configuration scan="true" scanPeriod="3 seconds" debug="true"> + <appender name="EMAIL" class="ch.qos.logback.classic.net.SMTPAppender"> + <smtpHost>smtp.gmail.com</smtpHost> + <smtpPort>465</smtpPort> + <to>${destination}</to> + <password>${password}</password> + <from>noreply(a)qos.ch</from> + <subject>%logger{20} - %m</subject> + <username>${destination}</username> + <SSL>true</SSL> + <layout class="ch.qos.logback.classic.PatternLayout"> + <pattern>%date %-5level %logger{35} - %message%n</pattern> + </layout> + </appender> + <root level="DEBUG"> + <appender-ref ref="EMAIL"/> + </root> +</configuration> \ No newline at end of file diff --git a/logback-core/src/main/java/ch/qos/logback/core/net/SMTPAppenderBase.java b/logback-core/src/main/java/ch/qos/logback/core/net/SMTPAppenderBase.java index d9318d9..68365ec 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/net/SMTPAppenderBase.java +++ b/logback-core/src/main/java/ch/qos/logback/core/net/SMTPAppenderBase.java @@ -82,6 +82,8 @@ public abstract class SMTPAppenderBase<E> extends AppenderBase<E> { String password; String localhost; + boolean asynchronousSending = true; + private String charsetEncoding = "UTF-8"; protected MimeMessage mimeMsg; ----------------------------------------------------------------------- Summary of changes: .../logback/classic/issue/lbclassic232/Simple.java | 34 ++++++++++++++++++++ .../classic/issue/lbclassic232/logback_smtp.xml | 18 ++++++++++ .../ch/qos/logback/core/net/SMTPAppenderBase.java | 2 + 3 files changed, 54 insertions(+), 0 deletions(-) create mode 100644 logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic232/Simple.java create mode 100644 logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic232/logback_smtp.xml hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[JIRA] Created: (LBCORE-234) write a special line as the first line in any log file so that the file can be automatically parsed by a tool
by James Strachan (JIRA) 03 May '12

03 May '12

write a special line as the first line in any log file so that the file can be automatically parsed by a tool ------------------------------------------------------------------------------------------------------------- Key: LBCORE-234 URL: http://jira.qos.ch/browse/LBCORE-234 Project: logback-core Issue Type: New Feature Components: Layout Affects Versions: 0.9.9 Reporter: James Strachan Assignee: Logback dev list So there's a few tools out there for parsing log files; most of them require the user to create a regex or find the right line of some config file to figure out what the Pattern layout expression was used to create the log file. The problem with these is the regex/patterns are quite brittle; its easy for code/dependencies to change and new log configuration to become effective or for users to not know the correct config/pattern for a file. (Its easy to have quite a few log configuration files in a tarball/war/bundle and not be quite sure which one is really active in a container for example). A simpler idea would be to (optionally but hopefully by default) output the first line of every log file some kind of well known first line (which can easily be excluded by tools that grep for stuff or whatever) which describes the pattern layout thats being used to write the file - so files generated by logback would be automatically parseable by a generic tool. Indeed it'd be nice to have such a tool; so you can easily load a file and turn it into ILoggingEvent objects by parsing the first line... e.g. imaging if all the files (including rolling logs and whatnot) looked like this... {code} #logback.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32c{1} | %-32.32C %4L | %X{bundle.id} - %X{bundle.name} - %X{bundle.version} | %m%n 11:52:08,267 | INFO | FelixStartLevel | BlueprintExtender | rint.container.BlueprintExtender 124 | 9 - org.apache.aries.blueprint - 0.3.1 | No quiesce support is available, so blueprint components will not participate in quiesce operations 11:52:08,400 | INFO | rint Extender: 2 | BlueprintContainerImpl | container.BlueprintContainerImpl 266 | 9 - org.apache.aries.blueprint - 0.3.1 | Bundle org.apache.karaf.management is waiting for namespace handlers 11:52:08,704 | INFO | FelixStartLevel | jmx | ? ? | 27 - org.apache.aries.jmx - 0.3.0 | Starting JMX OSGi agent {code} so via a simple bit of code the first line (or all lines starting with #logback.) could be parsed to figure out the format of the file; then the rest of the file could be turned into ILogEvents and passed into tools - or rendered easily in the logback eclipse plugin for example. Folks could even reverse engineer log formats and make sure other framework/tools/apps output the correct log format up front. Then dev/ops can just 'open a log' and its not just text with error prone regex/parsing expressions that have to be guessed but a kinda 'self describing log markup' -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

6 12

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch master updated. v_1.0.2-8-g22126c5
by git-noreply＠pixie.qos.ch 03 May '12

03 May '12

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via 22126c5c13088502dc0b5c9c7dda4218ac3c8978 (commit) from 0a2446b85f3ba811d9cbd153f3e591ca44ea4e0f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=22126c5c13088502dc0b5c9c… http://github.com/ceki/logback/commit/22126c5c13088502dc0b5c9c7dda4218ac3c8… commit 22126c5c13088502dc0b5c9c7dda4218ac3c8978 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Thu May 3 18:38:10 2012 +0200 outputPatternAsPresentationHeader renamed as outputPatternAsHeader and is now false by default diff --git a/logback-classic/src/main/java/ch/qos/logback/classic/BasicConfigurator.java b/logback-classic/src/main/java/ch/qos/logback/classic/BasicConfigurator.java index 6890b9e..8c8de83 100644 --- a/logback-classic/src/main/java/ch/qos/logback/classic/BasicConfigurator.java +++ b/logback-classic/src/main/java/ch/qos/logback/classic/BasicConfigurator.java @@ -46,7 +46,6 @@ public class BasicConfigurator { ca.setName("console"); PatternLayoutEncoder pl = new PatternLayoutEncoder(); pl.setContext(lc); - pl.setOutputPatternAsPresentationHeader(false); pl.setPattern("%d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n"); pl.start(); diff --git a/logback-classic/src/main/java/ch/qos/logback/classic/encoder/PatternLayoutEncoder.java b/logback-classic/src/main/java/ch/qos/logback/classic/encoder/PatternLayoutEncoder.java index 5bf4705..9e9782e 100644 --- a/logback-classic/src/main/java/ch/qos/logback/classic/encoder/PatternLayoutEncoder.java +++ b/logback-classic/src/main/java/ch/qos/logback/classic/encoder/PatternLayoutEncoder.java @@ -24,7 +24,7 @@ public class PatternLayoutEncoder extends PatternLayoutEncoderBase<ILoggingEvent PatternLayout patternLayout = new PatternLayout(); patternLayout.setContext(context); patternLayout.setPattern(getPattern()); - patternLayout.setOutputPatternAsPresentationHeader(outputPatternAsPresentationHeader); + patternLayout.setOutputPatternAsHeader(outputPatternAsHeader); patternLayout.start(); this.layout = patternLayout; super.start(); diff --git a/logback-classic/src/main/java/ch/qos/logback/classic/jul/LevelChangePropagator.java b/logback-classic/src/main/java/ch/qos/logback/classic/jul/LevelChangePropagator.java index 3f8cb7d..2c90cec 100644 --- a/logback-classic/src/main/java/ch/qos/logback/classic/jul/LevelChangePropagator.java +++ b/logback-classic/src/main/java/ch/qos/logback/classic/jul/LevelChangePropagator.java @@ -60,7 +60,7 @@ public class LevelChangePropagator extends ContextAwareBase implements LoggerCon private void propagate(Logger logger, Level level) { addInfo("Propagating " + level + " level on " + logger + " onto the JUL framework"); java.util.logging.Logger julLogger = JULHelper.asJULLogger(logger); - // prevent garbage collection of jul loggers levels were propagated to + // prevent garbage collection of jul loggers whose level we set // see also http://jira.qos.ch/browse/LBCLASSIC-256 julLoggerSet.add(julLogger); java.util.logging.Level julLevel = JULHelper.asJULLevel(level); diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/encoder/PatternLayoutEncoderTest.java b/logback-classic/src/test/java/ch/qos/logback/classic/encoder/PatternLayoutEncoderTest.java index bab8c26..6def85c 100644 --- a/logback-classic/src/test/java/ch/qos/logback/classic/encoder/PatternLayoutEncoderTest.java +++ b/logback-classic/src/test/java/ch/qos/logback/classic/encoder/PatternLayoutEncoderTest.java @@ -59,7 +59,7 @@ public class PatternLayoutEncoderTest { void init(ByteArrayOutputStream baos) throws IOException { ple.start(); - ((PatternLayout) ple.getLayout()).setOutputPatternAsPresentationHeader(false); + ((PatternLayout) ple.getLayout()).setOutputPatternAsHeader(false); ple.init(baos); } diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbcore243/PerformanceComparatorLogback.java b/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbcore243/PerformanceComparatorLogback.java index aacc7c6..223584c 100644 --- a/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbcore243/PerformanceComparatorLogback.java +++ b/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbcore243/PerformanceComparatorLogback.java @@ -1,12 +1,5 @@ package ch.qos.logback.classic.issue.lbcore243; -/** - * Created with IntelliJ IDEA. - * User: ceki - * Date: 26.04.12 - * Time: 21:52 - * To change this template use File | Settings | File Templates. - */ import ch.qos.logback.classic.LoggerContext; import ch.qos.logback.classic.joran.JoranConfigurator; diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbcore243/logback_without_immediateFlush.xml b/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbcore243/logback_without_immediateFlush.xml index 3d4f49e..b69f357 100644 --- a/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbcore243/logback_without_immediateFlush.xml +++ b/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbcore243/logback_without_immediateFlush.xml @@ -12,7 +12,8 @@ <encoder> <Pattern>%d{ISO8601} %5p [%t] %c - %m%n</Pattern> <immediateFlush>false</immediateFlush> -  + <outputPatternAsHeader>true</outputPatternAsHeader> + <charset>UTF-8</charset> </encoder> </appender> <root> diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/net/SMTPAppender_GreenTest.java b/logback-classic/src/test/java/ch/qos/logback/classic/net/SMTPAppender_GreenTest.java index 71a15b8..8ebd4de 100644 --- a/logback-classic/src/test/java/ch/qos/logback/classic/net/SMTPAppender_GreenTest.java +++ b/logback-classic/src/test/java/ch/qos/logback/classic/net/SMTPAppender_GreenTest.java @@ -90,7 +90,7 @@ public class SMTPAppender_GreenTest { PatternLayout layout = new PatternLayout(); layout.setContext(lc); layout.setFileHeader(HEADER); - layout.setOutputPatternAsPresentationHeader(false); + layout.setOutputPatternAsHeader(false); layout.setPattern("%-4relative %mdc [%thread] %-5level %class - %msg%n"); layout.setFileFooter(FOOTER); layout.start(); diff --git a/logback-core/src/main/java/ch/qos/logback/core/pattern/PatternLayoutBase.java b/logback-core/src/main/java/ch/qos/logback/core/pattern/PatternLayoutBase.java index fa5cfab..3fe2ad8 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/pattern/PatternLayoutBase.java +++ b/logback-core/src/main/java/ch/qos/logback/core/pattern/PatternLayoutBase.java @@ -34,7 +34,7 @@ abstract public class PatternLayoutBase<E> extends LayoutBase<E> { Map<String, String> instanceConverterMap = new HashMap<String, String>(); - protected boolean outputPatternAsHeader = true; + protected boolean outputPatternAsHeader = false; /** * Concrete implementations of this class are responsible for elaborating the diff --git a/logback-core/src/main/java/ch/qos/logback/core/pattern/PatternLayoutEncoderBase.java b/logback-core/src/main/java/ch/qos/logback/core/pattern/PatternLayoutEncoderBase.java index a094dcc..628afa1 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/pattern/PatternLayoutEncoderBase.java +++ b/logback-core/src/main/java/ch/qos/logback/core/pattern/PatternLayoutEncoderBase.java @@ -55,7 +55,7 @@ public class PatternLayoutEncoderBase<E> extends LayoutWrappingEncoder<E> { * @deprecated replaced by {@link #setOutputPatternAsHeader(boolean)} */ public void setOutputPatternAsPresentationHeader(boolean outputPatternAsHeader) { - addWarn("outputPatternAsPresentationHeader option is deprecated. Use outputPatternAsHeader option instead."); + addWarn("[outputPatternAsPresentationHeader] property is deprecated. Please use [outputPatternAsHeader] option instead."); this.outputPatternAsHeader = outputPatternAsHeader; } diff --git a/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/SamplePatternLayout.java b/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/SamplePatternLayout.java index ce730de..d33e8c0 100644 --- a/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/SamplePatternLayout.java +++ b/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/SamplePatternLayout.java @@ -29,7 +29,6 @@ public class SamplePatternLayout<E> extends PatternLayoutBase<E> { public SamplePatternLayout() { converterMap.put("OTT", Converter123.class.getName()); converterMap.put("hello", ConverterHello.class.getName()); - outputPatternAsPresentationHeader = false; } public Map<String, String> getDefaultConverterMap() { diff --git a/logback-site/src/site/pages/manual/appenders.html b/logback-site/src/site/pages/manual/appenders.html index de31c49..3574056 100644 --- a/logback-site/src/site/pages/manual/appenders.html +++ b/logback-site/src/site/pages/manual/appenders.html @@ -377,7 +377,7 @@ public interface Appender<E> extends LifeCycle, ContextAware, FilterAttachabl a file. The target file is specified by the File option. If the file already exists, it is either appended to, or truncated depending on the value of the - Append option. + append property. <table class="bodyTable properties striped"> @@ -390,10 +390,9 @@ public interface Appender<E> extends LifeCycle, ContextAware, FilterAttachabl <td>append</td> <td><code>boolean</code></td> <td>If true, events are appended at the end of an existing - file. Otherwise, if Append is - false, any existing file is truncated. The Append option is set to true by - default. + file. Otherwise, if append is false, + any existing file is truncated. The append option is set to true by default. </td> </tr> <tr > @@ -472,6 +471,15 @@ public interface Appender<E> extends LifeCycle, ContextAware, FilterAttachabl </tr> </table> + Immediate Flush By default, + each log event is immediately flushed to the underlying output + stream. For significantly increased logging throughput, you may + want to set the immediateFlush property + to <code>false</code> of the underlying encoder. Encoders and in + particular <a + href="encoders.html#LayoutWrappingEncoder"><code>LayoutWrappingEncoder</code></a> + are described in a separate chapter. + Below is an example of a configuration file for <code>FileAppender</code>: diff --git a/logback-site/src/site/pages/manual/encoders.html b/logback-site/src/site/pages/manual/encoders.html index 5e95765..6de5b7b 100644 --- a/logback-site/src/site/pages/manual/encoders.html +++ b/logback-site/src/site/pages/manual/encoders.html @@ -142,11 +142,13 @@ public class LayoutWrappingEncoder<E> extends EncoderBase<E> { protected Layout<E> layout; private Charset charset; + private boolean immediateFlush = true; public void doEncode(E event) throws IOException { String txt = layout.doLayout(event); outputStream.write(convertToBytes(txt)); - outputStream.flush(); + if (immediateFlush) + outputStream.flush(); } private byte[] convertToBytes(String s) { @@ -162,10 +164,15 @@ public class LayoutWrappingEncoder<E> extends EncoderBase<E> { layout convert the incoming event into string. The resulting text string is converted to bytes according to the charset encoding chosen by the user. Those bytes are then written to the - <code>OutputStream</code> given by the owning appender and the - <code>OutputStream</code> is immediately flushed. + <code>OutputStream</code> given by the owning appender. By + default, the <code>OutputStream</code> is immediately flushed, + unless the immediateFlush property is + explicitly set to false. Setting the immediateFlush property to false can + significantly improve logging throughput. See + <code>PatternLayoutEncoder</code> below for example. - + <h2><a name="PatternLayoutEncoder" href="#PatternLayoutEncoder">PatternLayoutEncoder</a></h2> @@ -186,9 +193,61 @@ public class LayoutWrappingEncoder<E> extends EncoderBase<E> { logback error codes</a>. + <h4><a name="outputPatternAsHeader" href="#outputPatternAsHeader">Output pattern string as header</a></h4> + + In order to facilitate parsing of log files, logback can insert + the pattern used for the log output at the top of log files. This + feature is disabled by default. It can be enabled by + setting the outputPatternAsHeader + property to 'true' for relevant + <code>PatternLayoutEncoder</code>. Here is an example: + +<pre class="prettyprint"><appender name="FILE" class="ch.qos.logback.core.FileAppender"> + <file>foo.log</file> + <encoder> + <pattern>%d %-5level [%thread] %logger{0}: %msg%n</pattern> + <outputPatternAsHeader>true</outputPatternAsHeader> + </encoder> +</appender></pre> + + This will result output akin to the following in the log file: + + <pre>#logback.classic pattern: %d [%thread] %-5level %logger{36} - %msg%n +2012-04-26 14:54:38,461 [main] DEBUG com.foo.App - Hello world +2012-04-26 14:54:38,461 [main] DEBUG com.foo.App - Hi again +...</pre> + + The line starting with "#logback.classic pattern" is newly + inserted pattern line. + + <h4>immediateFlush property</h4> + + As a sub-class of <a + href="../xref/ch/qos/logback/core/encoder/LayoutWrappingEncoder.html"><code>LayoutWrappingEncoder</code></a>, + <code>PatternLayoutEncoder</code> admits the immediateFlush property. The default value + for immediateFlush is 'false'. However, + by setting this property to 'false', logging throughput can be + quadrupled although your mileage may vary. + + + Below is a sample configuration for a + <code>FileAppender</code> containing a + <code>PatternLayoutEncoder</code> with its immediateFlush property set to 'false'. +<pre class="prettyprint"><appender name="FILE" class="ch.qos.logback.core.FileAppender"> + <file>foo.log</file> + <encoder> + <pattern>%d %-5level [%thread] %logger{0}: %msg%n</pattern> +  + <immediateFlush>false</immediateFlush> + </encoder> +</appender></pre> + + - <script src="../templates/footer.js" type="text/javascript"></script> + <script src="../templates/footer.js" type="text/javascript"></script> </div> </body> diff --git a/logback-site/src/site/pages/news.html b/logback-site/src/site/pages/news.html index 26126fe..70c8002 100644 --- a/logback-site/src/site/pages/news.html +++ b/logback-site/src/site/pages/news.html @@ -32,41 +32,30 @@ <h3>3rd of May, 2012 - Release of version 1.0.3</h3> - <code>PatternLayoutEncoder</code> now admits the immediateFlush option (set to true by - default). By setting this option to false, logging throughput can - be quadrupled, although your mileage may vary. This option was - requested in <a + <code>PatternLayoutEncoder</code> class now admits the <a + href="manual/encoders.html#LayoutWrappingEncoder">immediateFlush</a> + property (set to true by default). By setting this property to + 'false', logging throughput can be quadrupled, although your + mileage may vary. This enhancement was requested in <a href="http://jira.qos.ch/browse/LBCORE-243">LBCORE-243</a>. - In order to facilitate parsing of log files, logback can now - insert the pattern used for the log output at the top of log - files. This feature was requested by James Strachan in <a + In order to facilitate parsing of log files, logback can now <a + href="manual/encoders.html#outputPatternAsHeader">output the + pattern</a> used for the log output at the top of log files as a + header. This feature was requested by James Strachan in <a href="http://jira.qos.ch/browse/LBCORE-234">LBCORE-234</a>. - However, this feature is not enabled by default. It can be - enabled by setting the outputPatternAsHeader option to 'true' for - the relevant encoder. Here is an example: + -<pre class="prettyprint"><appender name="FILE" class="ch.qos.logback.core.FileAppender"> - <file>foo.log</file> - <encoder> - <pattern>%d %-5level [%thread] %logger{0}: %msg%n</pattern> - <outputPatternAsHeader>true</outputPatternAsHeader> - </encoder> -</appender></pre> + <code>LevelChangePropagator</code> now retains references to + j.u.l. loggers whose level it sets. This fixes garbage collection + issues reported in <a + href="http://jira.qos.ch/browse/LBCLASSIC-256">LBCLASSIC-256</a> + by Samuel Stanojevic who also provided the appropriate patch. + - This will result output akin to the following in the log file: - - <pre>#logback.classic pattern: %d [%thread] %-5level %logger{36} - %msg%n -2012-04-26 14:54:38,461 [main] DEBUG com.foo.App - Hello world -2012-04-26 14:54:38,461 [main] DEBUG com.foo.App - Hi again -...</pre> - - The line starting with "#logback.classic pattern" is newly - inserted pattern line. <h3>26th of April, 2012 - Release of version 1.0.2</h3> @@ -77,7 +66,7 @@ its pattern at the top of log files</h4> This feature, although still available, is no longer enabled by - default. See release 1.0.3 for details. + default. See release notes for version 1.0.3 for details. @@ -119,7 +108,7 @@ Added new property the cleanHistoryOnStart to <a + class="prop">cleanHistoryOnStart to <a href="manual/appenders.html#TimeBasedRollingPolicy">TimeBasedRollingPolicy</a>. By setting this property to <code>true</code>, history removal will work as expected even in the case of short lived @@ -237,8 +226,6 @@ Pierre Queinnec. - - <h3>September 21st, 2011 - Release of version 0.9.30</h3> Archive removal can now deal with prolonged periods of @@ -281,15 +268,15 @@ reported by Josh Oddman. It is now possible to specify multiple destination addresses - separated by commas in the the to + separated by commas in the the to property of <code>SMTPAppender</code>. This fixes <a href="http://jira.qos.ch/browse/LBCORE-213">LBCORE-213</a> reported by Alexandre Garnier who also provided the relevant patch. In previous versions of logback multiple destination addresses could only be specified by using multiple to properties. As of version 0.9.30 both + class="prop">to properties. As of version 0.9.30 both comma separated addresses and multiple to properties are supported. + class="prop">to properties are supported. When debug attribute is set to true within the @@ -420,7 +407,7 @@ The <a href="manual/appenders.html#smtpTo">to</a> option of SMTPAppender now admits a + class="prop">to</a> option of SMTPAppender now admits a pattern and is evaluated dynamically. <code>TeeServletInputStream</code> no longer chokes on input @@ -740,7 +727,7 @@ ALTER TABLE logging_event ADD arg3 VARCHAR(254);</pre> special. - The CharsetEncoder property in + The CharsetEncoder property in <code>SMTPAppender</code> can now be accessed and set from configuration files. This fixes <a href="http://jira.qos.ch/browse/LBCLASSIC-194">LBCLASSIC-194</a>. diff --git a/logback-site/src/site/pages/templates/header.js b/logback-site/src/site/pages/templates/header.js index 96a6a46..6bfd5f4 100644 --- a/logback-site/src/site/pages/templates/header.js +++ b/logback-site/src/site/pages/templates/header.js @@ -5,7 +5,7 @@ document.write('</a></td>') document.write('<td> </td>'); -document.write('<td width=70%">Due to an error, <a href="http://repo1.maven.org/maven2/ch/qos/logback/logback-classic/maven-metadata…">metadata</a> for logback on Maven central only mentions version 1.0.2. As such such, "mvn" can no longer fetch earlier versions of logback from Maven central. Until this issue is resolved, one simple workaround is to upgrade to logback 1.0.2 in your project' pom.xml file. Please also vote for <a href="https://issues.sonatype.org/browse/OSSRH-3437">OSSRH-3437</a>.</td>'); +document.write('<td width="70%" style="padding-right: 10em;">Due to an error, <a href="http://repo1.maven.org/maven2/ch/qos/logback/logback-classic/maven-metadata…">metadata</a> for logback on Maven central only mentions versions 1.0.2 and 1.0.3. It follows that "mvn" can no longer fetch earlier versions of logback artifacts from Maven central. Until this issue is resolved, one simple workaround is to upgrade your project's pom.xml file to use logback version 1.0.3 (or 1.0.2). Please also vote for <a href="https://issues.sonatype.org/browse/OSSRH-3437">OSSRH-3437</a>.</td>'); document.write('</tr></table>') ----------------------------------------------------------------------- Summary of changes: .../ch/qos/logback/classic/BasicConfigurator.java | 1 - .../classic/encoder/PatternLayoutEncoder.java | 2 +- .../logback/classic/jul/LevelChangePropagator.java | 2 +- .../classic/encoder/PatternLayoutEncoderTest.java | 2 +- .../lbcore243/PerformanceComparatorLogback.java | 7 -- .../lbcore243/logback_without_immediateFlush.xml | 3 +- .../classic/net/SMTPAppender_GreenTest.java | 2 +- .../logback/core/pattern/PatternLayoutBase.java | 2 +- .../core/pattern/PatternLayoutEncoderBase.java | 2 +- .../core/pattern/parser/SamplePatternLayout.java | 1 - logback-site/src/site/pages/manual/appenders.html | 18 ++++-- logback-site/src/site/pages/manual/encoders.html | 69 ++++++++++++++++++-- logback-site/src/site/pages/news.html | 61 +++++++----------- logback-site/src/site/pages/templates/header.js | 2 +- 14 files changed, 110 insertions(+), 64 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[JIRA] Created: (LBCLASSIC-256) java.util.logging propagated level changes are lost because of race condition with garbage collection
by Samuel Stanojevic (JIRA) 03 May '12

03 May '12

java.util.logging propagated level changes are lost because of race condition with garbage collection ----------------------------------------------------------------------------------------------------- Key: LBCLASSIC-256 URL: http://jira.qos.ch/browse/LBCLASSIC-256 Project: logback-classic Issue Type: Bug Affects Versions: 0.9.28 Environment: win7 64-bit, bootstrapped in a Tomcat server Reporter: Samuel Stanojevic Assignee: Logback dev list Attachments: LevelChangePropagator.java I have bootstrapped logback in my Tomcat server, and have setup JUL to redirect logging requests to SLF4J by adding the following in my logging.properties: .handlers = org.slf4j.bridge.SLF4JBridgeHandler Anyways, my setup works pretty nicely. The problem is when I try to activate the JUL LevelChangePropagator, the info doesn't quite propagate as expected. Here is my config: <configuration debug="true"> <contextListener class="ch.qos.logback.classic.jul.LevelChangePropagator"> <resetJUL>true</resetJUL> </contextListener> <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">  <encoder> <pattern>%d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n</pattern> </encoder> <target>System.out</target> </appender> <root level="ERROR"> <appender-ref ref="STDOUT" /> </root> <logger name="test.propagation" level="TRACE"/>  </configuration> The problem is that if my app tries to do: java.util.logging.Logger.getLogger("test.propagation").fine("hello world"); ..., it doesn't print. I have confirmed that the bug is because, even though the LevelChangePropagator class does propagate the level change info to JUL, it fails to keep a strong reference to the logger that it just changed. By not keeping a strong reference, and because the JUL LogManager only keeps WeakReferences to loggers, then the GC has time to clear out the change before the app's first attempt to use the logger. (see java.util.logging.LogManager#addLogger where the javadoc says "The application should retain its own reference to the Logger object to avoid it being garbage collected. The LogManager may only retain a weak reference") To test my hunch, I patched the LevelChangePropagator class by adding a global hashset of java.util.logging.Logger, and I systematically add the loggers to the hashset in the method "propagate(logger,level)". After this patch, my logging started working as expected. My fix may not be the best, and may have implications that I did not think about, but I think something along those lines needs to be done to fix the bug. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

5 7

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch master updated. v_1.0.2-7-g0a2446b
by git-noreply＠pixie.qos.ch 03 May '12

03 May '12

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via 0a2446b85f3ba811d9cbd153f3e591ca44ea4e0f (commit) from d903644be47ceaf38b437a921c3163a2335d9d5e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=0a2446b85f3ba811d9cbd153… http://github.com/ceki/logback/commit/0a2446b85f3ba811d9cbd153f3e591ca44ea4… commit 0a2446b85f3ba811d9cbd153f3e591ca44ea4e0f Author: Ceki Gulcu <ceki(a)qos.ch> Date: Thu May 3 18:29:18 2012 +0200 Fix http://jira.qos.ch/browse/LBCLASSIC-256 diff --git a/logback-classic/src/main/java/ch/qos/logback/classic/jul/LevelChangePropagator.java b/logback-classic/src/main/java/ch/qos/logback/classic/jul/LevelChangePropagator.java index 05ffa57..3f8cb7d 100644 --- a/logback-classic/src/main/java/ch/qos/logback/classic/jul/LevelChangePropagator.java +++ b/logback-classic/src/main/java/ch/qos/logback/classic/jul/LevelChangePropagator.java @@ -21,7 +21,9 @@ import ch.qos.logback.core.spi.ContextAwareBase; import ch.qos.logback.core.spi.LifeCycle; import java.util.Enumeration; +import java.util.HashSet; import java.util.List; +import java.util.Set; import java.util.logging.LogManager; @@ -30,8 +32,8 @@ import java.util.logging.LogManager; */ public class LevelChangePropagator extends ContextAwareBase implements LoggerContextListener, LifeCycle { + private Set julLoggerSet = new HashSet(); boolean isStarted = false; - boolean resetJUL = false; public void setResetJUL(boolean resetJUL) { @@ -58,6 +60,9 @@ public class LevelChangePropagator extends ContextAwareBase implements LoggerCon private void propagate(Logger logger, Level level) { addInfo("Propagating " + level + " level on " + logger + " onto the JUL framework"); java.util.logging.Logger julLogger = JULHelper.asJULLogger(logger); + // prevent garbage collection of jul loggers levels were propagated to + // see also http://jira.qos.ch/browse/LBCLASSIC-256 + julLoggerSet.add(julLogger); java.util.logging.Level julLevel = JULHelper.asJULLevel(level); julLogger.setLevel(julLevel); } ----------------------------------------------------------------------- Summary of changes: .../logback/classic/jul/LevelChangePropagator.java | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0