- logback-dev - mailman3.qos.ch

TimeBasedFileNamingAndTriggeringPolicyBaseTest fails
by Ralph Goers 06 Mar '12

06 Mar '12

I just got a new Mac at work and at home. The Logback build is failing on both. I have no idea if the error is due to the upgrade or not. ------------------------------------------------------------------------------- Test set: ch.qos.logback.core.rolling.TimeBasedFileNamingAndTriggeringPolicyBaseTest ------------------------------------------------------------------------------- Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1,133,311.978 sec <<< FAILURE! singleDate(ch.qos.logback.core.rolling.TimeBasedFileNamingAndTriggeringPolicyBaseTest) Time elapsed: 0 secmultiDate(ch.qos.logback.core.rolling.TimeBasedFileNamingAndTriggeringPolicyBaseTest) Time elapsed: 0.002 sec <<< FAILURE! java.lang.AssertionError: expected:<foo-2011-12/59.log> but was:<null> at org.junit.Assert.fail(Assert.java:93) at org.junit.Assert.failNotEquals(Assert.java:647) at org.junit.Assert.assertEquals(Assert.java:128) at org.junit.Assert.assertEquals(Assert.java:147) at ch.qos.logback.core.rolling.TimeBasedFileNamingAndTriggeringPolicyBaseTest.multiDate(TimeBasedFileNamingAndTriggeringPolicyBaseTest.java:65) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222) at org.junit.runners.ParentRunner.run(ParentRunner.java:300) at org.junit.runners.Suite.runChild(Suite.java:128) at org.junit.runners.Suite.runChild(Suite.java:24) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303) at java.util.concurrent.FutureTask.run(FutureTask.java:138) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:680) ~

3 8

debug attribute == OnConsoleStatusListener
by ceki 06 Mar '12

06 Mar '12

Hi Joern, As of [1], setting the debug attribute in the <configuration> element is equivalent to registering a OnConsoleStatusListener with the StatusManager. Thus, problems occurring during the lifetime of your application, well after logback is initialized, can be reported when the debug attribute is set. This results in a behavior closer to what users expect. As you were sensitive to changes in status manager, I thought to solicit your comments. Thoughts? [1] https://github.com/ceki/logback/commit/e85c6226ec -- Ceki http://twitter.com/#!/ceki

2 1

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch master updated. v_1.0.0-77-gb0876ea
by git-noreply＠pixie.qos.ch 06 Mar '12

06 Mar '12

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via b0876ea252337f55c9f0b7b6d613d7b38ed1503f (commit) from a4af39ec18f0868a2a1593f25f151dbf14bdd7f4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=b0876ea252337f55c9f0b7b6… http://github.com/ceki/logback/commit/b0876ea252337f55c9f0b7b6d613d7b38ed15… commit b0876ea252337f55c9f0b7b6d613d7b38ed1503f Author: Ceki Gulcu <ceki(a)qos.ch> Date: Tue Mar 6 23:54:16 2012 +0100 minor edits diff --git a/logback-site/src/site/pages/manual/loggingSeparation.html b/logback-site/src/site/pages/manual/loggingSeparation.html index fe1aafb..a415321 100644 --- a/logback-site/src/site/pages/manual/loggingSeparation.html +++ b/logback-site/src/site/pages/manual/loggingSeparation.html @@ -253,14 +253,15 @@ </listener></pre> Note Most containers invoke - the <code>contextInitialized</code> method of listeners in the + the <code>contextInitialized()</code> method of listeners in the order in which they are declared but invoke their - <code>contextDestroyed</code> method reverse order. It follows - that if you have multiple <code>ServletContextListener</code> - declarations in your web.xml, then - <code>ContextDetachingSCL</code> should be declared first - so that its <code>contextDestroyed</code> method is invoked - last during application shutdown. + <code>contextDestroyed()</code> method in reverse order. It + follows that if you have multiple + <code>ServletContextListener</code> declarations in your + web.xml, then <code>ContextDetachingSCL</code> should be + declared first so that its + <code>contextDestroyed()</code> method is invoked last + during application shutdown. <h3><a name="betterPerf" href="betterPerf">Better performance</a></h3> ----------------------------------------------------------------------- Summary of changes: .../src/site/pages/manual/loggingSeparation.html | 15 ++++++++------- 1 files changed, 8 insertions(+), 7 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch master updated. v_1.0.0-76-ga4af39e
by git-noreply＠pixie.qos.ch 06 Mar '12

06 Mar '12

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via a4af39ec18f0868a2a1593f25f151dbf14bdd7f4 (commit) from bf9d8c3f25035654d4b164f612a001a6d9422f05 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=a4af39ec18f0868a2a1593f2… http://github.com/ceki/logback/commit/a4af39ec18f0868a2a1593f25f151dbf14bdd… commit a4af39ec18f0868a2a1593f25f151dbf14bdd7f4 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Tue Mar 6 23:51:55 2012 +0100 ContextDetachingSCL should be declared first NOT last diff --git a/logback-site/src/site/pages/manual/loggingSeparation.html b/logback-site/src/site/pages/manual/loggingSeparation.html index 6372de6..fe1aafb 100644 --- a/logback-site/src/site/pages/manual/loggingSeparation.html +++ b/logback-site/src/site/pages/manual/loggingSeparation.html @@ -252,10 +252,15 @@ <listener-class>ch.qos.logback.classic.selector.servlet.ContextDetachingSCL</listener-class> </listener></pre> - Note If you have multiple - <code>ServletContextListener</code> instances declared in - web.xml, then declaring <code>ContextDetachingSCL</code> - last usually works best. + Note Most containers invoke + the <code>contextInitialized</code> method of listeners in the + order in which they are declared but invoke their + <code>contextDestroyed</code> method reverse order. It follows + that if you have multiple <code>ServletContextListener</code> + declarations in your web.xml, then + <code>ContextDetachingSCL</code> should be declared first + so that its <code>contextDestroyed</code> method is invoked + last during application shutdown. <h3><a name="betterPerf" href="betterPerf">Better performance</a></h3> ----------------------------------------------------------------------- Summary of changes: .../src/site/pages/manual/loggingSeparation.html | 13 +++++++++---- 1 files changed, 9 insertions(+), 4 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch master updated. v_1.0.0-75-gbf9d8c3
by git-noreply＠pixie.qos.ch 06 Mar '12

06 Mar '12

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via bf9d8c3f25035654d4b164f612a001a6d9422f05 (commit) from 6d036a31c7bf2563a49767253aced730a057b285 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=bf9d8c3f25035654d4b164f6… http://github.com/ceki/logback/commit/bf9d8c3f25035654d4b164f612a001a6d9422… commit bf9d8c3f25035654d4b164f612a001a6d9422f05 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Tue Mar 6 23:31:08 2012 +0100 text about declaring ContextDetachingSCL last. diff --git a/logback-site/src/site/pages/manual/loggingSeparation.html b/logback-site/src/site/pages/manual/loggingSeparation.html index 0be426c..6372de6 100644 --- a/logback-site/src/site/pages/manual/loggingSeparation.html +++ b/logback-site/src/site/pages/manual/loggingSeparation.html @@ -252,6 +252,11 @@ <listener-class>ch.qos.logback.classic.selector.servlet.ContextDetachingSCL</listener-class> </listener></pre> + Note If you have multiple + <code>ServletContextListener</code> instances declared in + web.xml, then declaring <code>ContextDetachingSCL</code> + last usually works best. + <h3><a name="betterPerf" href="betterPerf">Better performance</a></h3> ----------------------------------------------------------------------- Summary of changes: .../src/site/pages/manual/loggingSeparation.html | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch master updated. v_1.0.0-74-g6d036a3
by git-noreply＠pixie.qos.ch 06 Mar '12

06 Mar '12

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via 6d036a31c7bf2563a49767253aced730a057b285 (commit) from e85c6226ec0d00007c64508157d6054e07871406 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=6d036a31c7bf2563a4976725… http://github.com/ceki/logback/commit/6d036a31c7bf2563a49767253aced730a057b… commit 6d036a31c7bf2563a49767253aced730a057b285 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Tue Mar 6 23:08:30 2012 +0100 minor edit diff --git a/logback-site/src/site/pages/news.html b/logback-site/src/site/pages/news.html index 851bf66..657c073 100644 --- a/logback-site/src/site/pages/news.html +++ b/logback-site/src/site/pages/news.html @@ -36,8 +36,8 @@ <code>OnConsoleStatusListener</code> with the <code>StatusManager</code>. Thus, problems occurring during the lifetime of your application, well after logback is initialized, - can be reported. This results in a behavior closer to what users - expect. + can be reported when the debug attribute + is set. This results in a behavior closer to what users expect. Added new property the <span ----------------------------------------------------------------------- Summary of changes: logback-site/src/site/pages/news.html | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch master updated. v_1.0.0-73-ge85c622
by git-noreply＠pixie.qos.ch 06 Mar '12

06 Mar '12

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via e85c6226ec0d00007c64508157d6054e07871406 (commit) from 1169a18f6aac21cbbc1f2e60dfb7b75b2a2399a0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=e85c6226ec0d00007c645081… http://github.com/ceki/logback/commit/e85c6226ec0d00007c64508157d6054e07871… commit e85c6226ec0d00007c64508157d6054e07871406 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Tue Mar 6 23:02:16 2012 +0100 Setting the debug attribute to true in the <configuration> element now registers a OnConsoleStatusListener with the StatusManager. diff --git a/logback-access/src/main/java/ch/qos/logback/access/joran/action/ConfigurationAction.java b/logback-access/src/main/java/ch/qos/logback/access/joran/action/ConfigurationAction.java index 034494f..d58c8bf 100644 --- a/logback-access/src/main/java/ch/qos/logback/access/joran/action/ConfigurationAction.java +++ b/logback-access/src/main/java/ch/qos/logback/access/joran/action/ConfigurationAction.java @@ -13,6 +13,7 @@ */ package ch.qos.logback.access.joran.action; +import ch.qos.logback.core.status.OnConsoleStatusListener; import org.xml.sax.Attributes; import ch.qos.logback.core.joran.action.Action; @@ -24,7 +25,6 @@ import ch.qos.logback.core.util.StatusPrinter; public class ConfigurationAction extends Action { static final String INTERNAL_DEBUG_ATTR = "debug"; - boolean debugMode = false; public void begin(InterpretationContext ec, String name, Attributes attributes) { String debugAttrib = attributes.getValue(INTERNAL_DEBUG_ATTR); @@ -33,8 +33,8 @@ public class ConfigurationAction extends Action { (debugAttrib == null) || debugAttrib.equals("") || debugAttrib.equals("false") || debugAttrib.equals("null")) { addInfo("Ignoring " + INTERNAL_DEBUG_ATTR + " attribute."); - } else { - debugMode = true; + } else { + OnConsoleStatusListener.addNewInstanceToContext(context); } new ContextUtil(context).addHostNameAsProperty(); @@ -45,10 +45,6 @@ public class ConfigurationAction extends Action { public void end(InterpretationContext ec, String name) { addInfo("End of configuration."); - if (debugMode) { - StatusPrinter.print(context); - } - ec.popObject(); } } diff --git a/logback-classic/src/main/java/ch/qos/logback/classic/joran/action/ConfigurationAction.java b/logback-classic/src/main/java/ch/qos/logback/classic/joran/action/ConfigurationAction.java index 6369585..42abe92 100644 --- a/logback-classic/src/main/java/ch/qos/logback/classic/joran/action/ConfigurationAction.java +++ b/logback-classic/src/main/java/ch/qos/logback/classic/joran/action/ConfigurationAction.java @@ -13,6 +13,7 @@ */ package ch.qos.logback.classic.joran.action; +import ch.qos.logback.core.status.OnConsoleStatusListener; import org.xml.sax.Attributes; import ch.qos.logback.classic.LoggerContext; @@ -29,7 +30,6 @@ public class ConfigurationAction extends Action { static final String SCAN_ATTR = "scan"; static final String SCAN_PERIOD_ATTR = "scanPeriod"; - boolean debugMode = false; long threshold = 0; public void begin(InterpretationContext ec, String name, Attributes attributes) { @@ -40,7 +40,7 @@ public class ConfigurationAction extends Action { || debugAttrib.equalsIgnoreCase("null")) { addInfo(INTERNAL_DEBUG_ATTR + " attribute not set"); } else { - debugMode = true; + OnConsoleStatusListener.addNewInstanceToContext(context); } processScanAttrib(attributes); @@ -77,11 +77,7 @@ public class ConfigurationAction extends Action { } public void end(InterpretationContext ec, String name) { - if (debugMode) { - addInfo("End of configuration."); - LoggerContext loggerContext = (LoggerContext) context; - StatusPrinter.print(loggerContext, threshold); - } + addInfo("End of configuration."); ec.popObject(); } } diff --git a/logback-core/src/main/java/ch/qos/logback/core/joran/action/StatusListenerAction.java b/logback-core/src/main/java/ch/qos/logback/core/joran/action/StatusListenerAction.java index cbe54f2..af85522 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/joran/action/StatusListenerAction.java +++ b/logback-core/src/main/java/ch/qos/logback/core/joran/action/StatusListenerAction.java @@ -33,9 +33,8 @@ public class StatusListenerAction extends Action { inError = false; String className = attributes.getValue(CLASS_ATTRIBUTE); if (OptionHelper.isEmpty(className)) { - addError( - "Missing class name for statusListener. Near [" - + name + "] line " + getLineNumber(ec)); + addError("Missing class name for statusListener. Near [" + + name + "] line " + getLineNumber(ec)); inError = true; return; } @@ -43,11 +42,11 @@ public class StatusListenerAction extends Action { try { statusListener = (StatusListener) OptionHelper.instantiateByClassName( className, StatusListener.class, context); - addInfo("Adding status listener of type ["+className+"]"); ec.getContext().getStatusManager().add(statusListener); if (statusListener instanceof ContextAware) { ((ContextAware) statusListener).setContext(context); } + addInfo("Added status listener of type [" + className + "]"); ec.pushObject(statusListener); } catch (Exception e) { inError = true; @@ -70,8 +69,7 @@ public class StatusListenerAction extends Action { } Object o = ec.peekObject(); if (o != statusListener) { - addWarn( - "The object at the of the stack is not the statusListener pushed earlier."); + addWarn("The object at the of the stack is not the statusListener pushed earlier."); } else { ec.popObject(); } diff --git a/logback-core/src/main/java/ch/qos/logback/core/status/OnConsoleStatusListener.java b/logback-core/src/main/java/ch/qos/logback/core/status/OnConsoleStatusListener.java index daea4be..9658fa1 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/status/OnConsoleStatusListener.java +++ b/logback-core/src/main/java/ch/qos/logback/core/status/OnConsoleStatusListener.java @@ -13,6 +13,8 @@ */ package ch.qos.logback.core.status; +import ch.qos.logback.core.Context; +import ch.qos.logback.core.spi.ContextAware; import ch.qos.logback.core.spi.ContextAwareBase; import ch.qos.logback.core.spi.LifeCycle; import ch.qos.logback.core.util.StatusPrinter; @@ -80,4 +82,16 @@ public class OnConsoleStatusListener extends ContextAwareBase implements StatusL public boolean isStarted() { return isStarted; } + + /** + * This utility method adds a new OnConsoleStatusListener to the context passed as parameter. + * + * @param context + * @since 1.0.1 + */ + static public void addNewInstanceToContext(Context context) { + OnConsoleStatusListener onConsoleStatusListener = new OnConsoleStatusListener(); + onConsoleStatusListener.setContext(context); + context.getStatusManager().add(onConsoleStatusListener); + } } diff --git a/logback-site/src/site/pages/manual/configuration.html b/logback-site/src/site/pages/manual/configuration.html index 0812333..df1679a 100644 --- a/logback-site/src/site/pages/manual/configuration.html +++ b/logback-site/src/site/pages/manual/configuration.html @@ -368,21 +368,24 @@ public class Foo { </ol> If any of these two conditions is not fulfilled, Joran cannot - interpret the <code>debug</code> attribute since the configuration file - cannot be read. If the configuration file is found but is - malformed, then logback will detect the error condition and - automatically print its internal status on the console. However, if - the configuration file cannot be found, logback will not automatically - print its status data, since this is not necessarily an error condition. Programmatically invoking + interpret the debug attribute since the + configuration file cannot be read. If the configuration file is + found but is malformed, then logback will detect the error + condition and automatically print its internal status on the + console. However, if the configuration file cannot be found, + logback will not automatically print its status data, since this is + not necessarily an error condition. Programmatically invoking <code>StatusPrinter.print()</code> as in the MyApp2 application above ensures that status information is always printed. - It is strongly recommended to register a status listener, - e.g. <code>OnConsoleStatusListener</code>, so that problems - occurring during the lifetime of your application, well after - logback is initialized, can be reported. See the section on <a + As of version 1.0.1, setting the debug + attribute is equivalent to registering an + <code>OnConsoleStatusListener</code> with the + <code>StatusManager</code>. Thus, problems occurring during the + lifetime of your application, well after logback is initialized, + can be reported. Refer to the section on <a href="#statusListener">status listeners</a> further below. <h3><a name="configFileProperty" diff --git a/logback-site/src/site/pages/news.html b/logback-site/src/site/pages/news.html index 1dadd0d..851bf66 100644 --- a/logback-site/src/site/pages/news.html +++ b/logback-site/src/site/pages/news.html @@ -29,7 +29,16 @@ <hr width="80%" align="center" /> - <h3>xx of December, 2011 - Release of version 1.0.1</h3> + <h3>xx of March, 2012 - Release of version 1.0.1</h3> + + Setting the debug attribute to true in the + <code><configuration></code> element now registers a + <code>OnConsoleStatusListener</code> with the + <code>StatusManager</code>. Thus, problems occurring during the + lifetime of your application, well after logback is initialized, + can be reported. This results in a behavior closer to what users + expect. + Added new property the cleanHistoryOnStart to <a @@ -60,9 +69,9 @@ as reported by Chris Cheshire. - SiftingAppender will consider stale and consequently remove - nested appenders which are closed or improperly started. This - caters for the use case described in <a + <code>SiftingAppender</code> will consider stale and + consequently remove nested appenders which are closed or + improperly started. This caters for the use case described in <a href="http://jira.qos.ch/browse/LBCLASSIC-316">LBCLASSIC-316</a> by Guus Bloemsma. ----------------------------------------------------------------------- Summary of changes: .../access/joran/action/ConfigurationAction.java | 10 ++------ .../classic/joran/action/ConfigurationAction.java | 10 ++------ .../core/joran/action/StatusListenerAction.java | 10 +++----- .../core/status/OnConsoleStatusListener.java | 14 ++++++++++++ .../src/site/pages/manual/configuration.html | 23 +++++++++++-------- logback-site/src/site/pages/news.html | 17 +++++++++++--- 6 files changed, 50 insertions(+), 34 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[JIRA] Created: (LBCLASSIC-316) SiftingAppender and the lifecycle of created appenders
by Guus Bloemsma (JIRA) 06 Mar '12

06 Mar '12

SiftingAppender and the lifecycle of created appenders ------------------------------------------------------ Key: LBCLASSIC-316 URL: http://jira.qos.ch/browse/LBCLASSIC-316 Project: logback-classic Issue Type: Improvement Components: appender Affects Versions: 1.0.0 Environment: servlet container Reporter: Guus Bloemsma Assignee: Logback dev list I'm using SiftingAppender to create logfiles per servlet request. I wrote a servlet filter to add session and request id's into MDC. A custom appender (nested into SiftingAppender) buffers all logging events. Only when a WARN or ERROR occurred it writes all of them at the end of the servlet request to yet another nested appender. Logback made this surprisingly easy! This all works fine except for one little problem. The SiftingAppender creates a new custom appender for each request. It uses a AppenderTrackerImpl to keep track of them. That AppenderTrackerImpl holds on to those appenders for half an hour even though it is guaranteed that they won't be needed after the request. That is a lot of unused appenders! Being able to configure that timeout per SiftingAppender would be one solution. Another way would be to make the method ch.qos.logback.core.sift.AppenderTrackerImpl.isEntryStale(Entry, long) check whether the appender in the entry is stopped. In that case it should be treated as stale as well. My custom appender would simply stop itself once it is no longer used. BTW, I understand that I'm kind of abusing SiftingAppender. Maybe I should just make my own... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 3

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch master updated. v_1.0.0-72-g1169a18
by git-noreply＠pixie.qos.ch 06 Mar '12

06 Mar '12

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via 1169a18f6aac21cbbc1f2e60dfb7b75b2a2399a0 (commit) from 26a0a37ccb1107094b079154e1a2d0f8c41eb9b6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=1169a18f6aac21cbbc1f2e60… http://github.com/ceki/logback/commit/1169a18f6aac21cbbc1f2e60dfb7b75b2a239… commit 1169a18f6aac21cbbc1f2e60dfb7b75b2a2399a0 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Tue Mar 6 22:17:13 2012 +0100 Fix LBCLASSIC-316 diff --git a/logback-core/src/main/java/ch/qos/logback/core/net/SMTPAppenderBase.java b/logback-core/src/main/java/ch/qos/logback/core/net/SMTPAppenderBase.java index fe57c1b..d9318d9 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/net/SMTPAppenderBase.java +++ b/logback-core/src/main/java/ch/qos/logback/core/net/SMTPAppenderBase.java @@ -328,17 +328,20 @@ public abstract class SMTPAppenderBase<E> extends AppenderBase<E> { sbuf.append(footer); } + String subjectStr = "Undefined subject"; if (subjectLayout != null) { - mimeMsg.setSubject(subjectLayout.doLayout(lastEventObject), - charsetEncoding); + subjectStr = subjectLayout.doLayout(lastEventObject); } + mimeMsg.setSubject(subjectStr, charsetEncoding); List<InternetAddress> destinationAddresses = parseAddress(lastEventObject); if (destinationAddresses.isEmpty()) { addInfo("Empty destination address. Aborting email transmission"); return; } - mimeMsg.setRecipients(Message.RecipientType.TO, destinationAddresses.toArray(EMPTY_IA_ARRAY)); + + InternetAddress[] toAddressArray = destinationAddresses.toArray(EMPTY_IA_ARRAY); + mimeMsg.setRecipients(Message.RecipientType.TO, toAddressArray); String contentType = layout.getContentType(); @@ -355,6 +358,7 @@ public abstract class SMTPAppenderBase<E> extends AppenderBase<E> { mimeMsg.setSentDate(new Date()); Transport.send(mimeMsg); + addInfo("Sent out SMTP message \""+subjectStr+"\" to "+Arrays.toString(toAddressArray)); } catch (Exception e) { addError("Error occurred while sending e-mail notification.", e); } diff --git a/logback-core/src/main/java/ch/qos/logback/core/sift/AppenderTrackerImpl.java b/logback-core/src/main/java/ch/qos/logback/core/sift/AppenderTrackerImpl.java index 59d1033..c5a361a 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/sift/AppenderTrackerImpl.java +++ b/logback-core/src/main/java/ch/qos/logback/core/sift/AppenderTrackerImpl.java @@ -108,6 +108,12 @@ public class AppenderTrackerImpl<E> implements AppenderTracker<E> { private boolean isEntryStale(Entry entry, long now) { + // stopped or improperly started appenders are considered stale + // see also http://jira.qos.ch/browse/LBCLASSIC-316 + if(!entry.value.isStarted()) + return true; + + // unused appenders are also considered stale return ((entry.timestamp + THRESHOLD) < now); } diff --git a/logback-core/src/test/java/ch/qos/logback/core/sift/Simulator.java b/logback-core/src/test/java/ch/qos/logback/core/sift/Simulator.java index 745b865..b9168cb 100644 --- a/logback-core/src/test/java/ch/qos/logback/core/sift/Simulator.java +++ b/logback-core/src/test/java/ch/qos/logback/core/sift/Simulator.java @@ -116,6 +116,7 @@ public class Simulator { Appender<Object> appender = appenderTracker.get(key, timestamp); if (appender == null) { appender = new NOPAppender<Object>(); + appender.start(); appenderTracker.put(key, appender, timestamp); } appenderTracker.stopStaleAppenders(timestamp); diff --git a/logback-site/src/site/pages/manual/appenders.html b/logback-site/src/site/pages/manual/appenders.html index 18c46b2..56cf6f9 100644 --- a/logback-site/src/site/pages/manual/appenders.html +++ b/logback-site/src/site/pages/manual/appenders.html @@ -2462,7 +2462,7 @@ logger.error(notifyAdmin, host, greatly facilitating problem diagnosis. - <h4><a name= "bufferManagement" href="#bufferManagement">On buffer + <h4><a name= "bufferManagement" href="#bufferManagement">Buffer management in very busy systems</a></h4> Internally, each distinct value returned by the discriminator diff --git a/logback-site/src/site/pages/news.html b/logback-site/src/site/pages/news.html index 0a6ba3f..1dadd0d 100644 --- a/logback-site/src/site/pages/news.html +++ b/logback-site/src/site/pages/news.html @@ -60,6 +60,12 @@ as reported by Chris Cheshire. + SiftingAppender will consider stale and consequently remove + nested appenders which are closed or improperly started. This + caters for the use case described in <a + href="http://jira.qos.ch/browse/LBCLASSIC-316">LBCLASSIC-316</a> + by Guus Bloemsma. + <code>RequestLogImpl</code> can now lookup for the logback-access configuration file as a class path resource. This feature was requested in <a ----------------------------------------------------------------------- Summary of changes: .../ch/qos/logback/core/net/SMTPAppenderBase.java | 10 +++++++--- .../qos/logback/core/sift/AppenderTrackerImpl.java | 6 ++++++ .../java/ch/qos/logback/core/sift/Simulator.java | 1 + logback-site/src/site/pages/manual/appenders.html | 2 +- logback-site/src/site/pages/news.html | 6 ++++++ 5 files changed, 21 insertions(+), 4 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[JIRA] Created: (LBCORE-213) Do not restrict SMTPAppender <to> to only 1 email address
by Alexandre Garnier (JIRA) 06 Mar '12

06 Mar '12

Do not restrict SMTPAppender <to> to only 1 email address --------------------------------------------------------- Key: LBCORE-213 URL: http://jira.qos.ch/browse/LBCORE-213 Project: logback-core Issue Type: Bug Reporter: Alexandre Garnier Assignee: Logback dev list It's not possible to have multiple email address in <to> element of SMTPAppender because only the first one is used (https://github.com/ceki/logback/blob/master/logback-core/src/main/java/ch/q…) When using a property, multiple <to> element is not really easy (if even possible)... Example: <appender name="email" class="ch.qos.logback.classic.net.SMTPAppender"> ... <to>${mail.log.to}</to> ... </appender> With properties : mail.log.to = admin@domain.com,dev@domain.com,op@domain.com => Only admin(a)domain.com get the email ! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 5