- logback-dev - mailman3.qos.ch

[JIRA] Created: (LBCLASSIC-300) Add ability to manually specify configuration BEFORE autoconfiguration
by Phil (JIRA) 18 Nov '11

18 Nov '11

Add ability to manually specify configuration BEFORE autoconfiguration ---------------------------------------------------------------------- Key: LBCLASSIC-300 URL: http://jira.qos.ch/browse/LBCLASSIC-300 Project: logback-classic Issue Type: Improvement Affects Versions: 0.9.29 Reporter: Phil Assignee: Logback dev list Priority: Minor In order to make logback initialization faster, I would like the ability to programmatically configure logback and avoid the logic that happens in ContextInitializer.autoConfig(). Specifically, refer to this stack that occurs when getILoggerFactory() is initially called... ch.qos.logback.classic.util.ContextInitializer.autoConfig() line: 147 org.slf4j.impl.StaticLoggerBinder.init() line: 85 org.slf4j.impl.StaticLoggerBinder.<clinit>() line: 55 org.slf4j.LoggerFactory.bind() line: 121 org.slf4j.LoggerFactory.performInitialization() line: 111 org.slf4j.LoggerFactory.getILoggerFactory() line: 268 Now, for some background... I am using logback for a fast executing CLI program. Right now, initializing logback dominates the execution time of my CLIs. For example... When I started with logback, I was using logback.xml. If one of my CLIs took 1.5 seconds to run, I would see that initializing logback was taking 1 of those seconds (I used the yourkit profiler to identify this). 66% of the execution time is unacceptable. So, I switched from using logback.xml to programatically configuring logback in Java with the following code.. {code} LoggerContext loggingContext = (LoggerContext) LoggerFactory.getILoggerFactory(); loggingContext.reset(); ... FileAppender<ILoggingEvent> fileAppender = new FileAppender<ILoggingEvent>(); ... Logger rootLogger = loggingContext.getLogger(Logger.ROOT_LOGGER_NAME); rootLogger.addAppender(fileAppender); {code} This reduced the initialization time quite a bit. Now logback initialization is taking about .3 seconds. This is much better. However, I still think this can be improved by completely skipping the auto config logic. The initial call to LoggerFactory.getILoggerFactory() will attempt to auto configure logback.... which searches for groovy files, xml files, and falls back to BasicConfigurator. I don't need this auto configuration logic, since I am just going reset it and configure it myself anyway. I would like the ability to programmatically configure logback and totally avoid this auto configuration. Ideally I would be able to construct a LoggerContext instance, or the root Logger, or something. Then allow slf4j to bind to it without going through the auto config steps. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 7

[JIRA] Created: (LBCORE-237) Change ch.qos.logback.core.pattern.CompositeConverter#transform access to protected
by Martin Caslavsky (JIRA) 15 Nov '11

15 Nov '11

Change ch.qos.logback.core.pattern.CompositeConverter#transform access to protected ----------------------------------------------------------------------------------- Key: LBCORE-237 URL: http://jira.qos.ch/browse/LBCORE-237 Project: logback-core Issue Type: Improvement Components: Pattern Reporter: Martin Caslavsky Assignee: Logback dev list Priority: Minor I would like to suugest to change ch.qos.logback.core.pattern.CompositeConverter#transform access from package protected to protected, which allow successor classes to be placed in package different from ch.qos.logback.core.pattern -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 1

[JIRA] Created: (LBCLASSIC-261) MongoDB appender
by Tomasz Nurkiewicz (JIRA) 15 Nov '11

15 Nov '11

MongoDB appender ---------------- Key: LBCLASSIC-261 URL: http://jira.qos.ch/browse/LBCLASSIC-261 Project: logback-classic Issue Type: New Feature Components: appender Affects Versions: 0.9.28 Reporter: Tomasz Nurkiewicz Assignee: Logback dev list An appender similar to DbAppender, but storing logs in MongoDB document-oriented database. Should be capable of storing both classic and access logs. MongoDB seems especially well suited for this task since it is schema-less and very fast. Prototype implementation + integration tests (MongoDB instance running required) can be found here: https://github.com/nurkiewicz/logback/tree/mongodb-appender. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 1

[JIRA] Created: (LBCLASSIC-308) NPE annoyance in getCodeLocation
by Yuri de Wit (JIRA) 14 Nov '11

14 Nov '11

NPE annoyance in getCodeLocation -------------------------------- Key: LBCLASSIC-308 URL: http://jira.qos.ch/browse/LBCLASSIC-308 Project: logback-classic Issue Type: Improvement Components: Other Affects Versions: 0.9.29 Reporter: Yuri de Wit Assignee: Logback dev list Priority: Trivial This is really a minor issue that affects mostly development: an NPE in PackagingDataCalculator line 161 that although it is caught by the catch() below it ends up triggering the NPE breakpoint in eclipse. The reason is that some classes don't have a protection domain and return null. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

version 99
by ceki 12 Nov '11

12 Nov '11

Hello all, http://version99.qos.ch/ has become available just a few moments ago. It's a Maven repo serving empty jar files for commons-logging and log4j. See http://day-to-day-stuff.blogspot.com/2007/07/no-more-commons-logging.html for the rationale. The repo has not been tested! Tests and proper documentation will follow after my return from vacations. Cheers, -- Ceki http://twitter.com/#!/ceki

1 0

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch master updated. v_1.0.0-54-gfef529f
by git-noreply＠pixie.qos.ch 11 Nov '11

11 Nov '11

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via fef529f87d72e94a582e5cd515c7acaddf01e07e (commit) from d7038b0e289b38382f45c2fe6f599d89980454db (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=fef529f87d72e94a582e5cd5… http://github.com/ceki/logback/commit/fef529f87d72e94a582e5cd515c7acaddf01e… commit fef529f87d72e94a582e5cd515c7acaddf01e07e Author: Ceki Gulcu <ceki(a)qos.ch> Date: Fri Nov 11 13:16:41 2011 +0100 added news item about LBCORE-210 diff --git a/logback-site/src/site/pages/news.html b/logback-site/src/site/pages/news.html index a356ae1..dd9ba9a 100644 --- a/logback-site/src/site/pages/news.html +++ b/logback-site/src/site/pages/news.html @@ -53,6 +53,13 @@ Marshall Pierce. </p> + <p>Updated the Janino dependency to version 2.5.16. In addition, + the code checking for the availability of Janino on the class path + was updated to take Janino 2.6 into account, thus fixing <a + href="http://jira.qos.ch/browse/LBCORE-210">LBCORE-210</a>. + </p> + + <hr width="80%" align="center" /> <h3>1st of November, 2011 - Release of version 1.0.0</h3> ----------------------------------------------------------------------- Summary of changes: logback-site/src/site/pages/news.html | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch master updated. v_1.0.0-53-gd7038b0
by git-noreply＠pixie.qos.ch 11 Nov '11

11 Nov '11

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via d7038b0e289b38382f45c2fe6f599d89980454db (commit) from 9c58b9e8202939b9a5888fb3896a88f82e04966b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=d7038b0e289b38382f45c2fe… http://github.com/ceki/logback/commit/d7038b0e289b38382f45c2fe6f599d8998045… commit d7038b0e289b38382f45c2fe6f599d89980454db Author: Ceki Gulcu <ceki(a)qos.ch> Date: Fri Nov 11 11:13:05 2011 +0100 upgrade to janino 2.5.16, fix LBCORE-210, remove test-time dependency on joda time diff --git a/logback-access/pom.xml b/logback-access/pom.xml index fdd3d5a..830ac97 100644 --- a/logback-access/pom.xml +++ b/logback-access/pom.xml @@ -76,7 +76,7 @@  <dependency> - <groupId>janino</groupId> + <groupId>org.codehaus.janino</groupId> <artifactId>janino</artifactId> <scope>compile</scope> <optional>true</optional> diff --git a/logback-classic/pom.xml b/logback-classic/pom.xml index 0d67770..caf59d1 100644 --- a/logback-classic/pom.xml +++ b/logback-classic/pom.xml @@ -106,7 +106,7 @@ </dependency> <dependency> - <groupId>janino</groupId> + <groupId>org.codehaus.janino</groupId> <artifactId>janino</artifactId> <scope>compile</scope> <optional>true</optional> @@ -169,13 +169,6 @@ </dependency> <dependency> - <groupId>joda-time</groupId> - <artifactId>joda-time</artifactId> - <version>1.6</version> - <scope>test</scope> - </dependency> - - <dependency> <groupId>org.apache.felix</groupId> <artifactId>org.apache.felix.main</artifactId> <version>2.0.2</version> diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic36/DateFormatOriginal_tzest.java b/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic36/DateFormatOriginal_tzest.java index 597cfd8..e35e54e 100644 --- a/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic36/DateFormatOriginal_tzest.java +++ b/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic36/DateFormatOriginal_tzest.java @@ -20,9 +20,9 @@ import junit.framework.TestSuite; import java.text.SimpleDateFormat; import java.util.Date; -import org.joda.time.format.DateTimeFormatter; -import org.joda.time.format.DateTimeFormat; -import org.joda.time.DateTime; +//import org.joda.time.format.DateTimeFormatter; +//import org.joda.time.format.DateTimeFormat; +//import org.joda.time.DateTime; public class DateFormatOriginal_tzest extends TestCase { public static final String ISO8601_PATTERN = "yyyy-MM-dd HH:mm:ss,SSS"; @@ -57,30 +57,30 @@ public class DateFormatOriginal_tzest extends TestCase { super.tearDown(); } - public void testRaw() throws Exception { - SimpleDateFormat simpleFormat = new SimpleDateFormat(ISO8601_PATTERN); - DateTimeFormatter jodaFormat = DateTimeFormat.forPattern(ISO8601_PATTERN); - - Date date = new Date(); - DateTime dateTime = new DateTime(date); - - long start = System.nanoTime(); - for (int i = 0; i < 100000; ++i) { - jodaFormat.print(dateTime); - } - long jodaAvg = (System.nanoTime() - start) / 100000; - - - start = System.nanoTime(); - for (int i = 0; i < 100000; ++i) { - simpleFormat.format(date); - } - long simpleAvg = (System.nanoTime() - start) / 100000; - - float diff = (((float) (simpleAvg - jodaAvg)) / simpleAvg) * 100; - System.out.println("Raw - JDK: " + simpleAvg + " ns Joda: " + jodaAvg - + " ns - Difference: " + diff + "%"); - } +// public void testRaw() throws Exception { +// SimpleDateFormat simpleFormat = new SimpleDateFormat(ISO8601_PATTERN); +// DateTimeFormatter jodaFormat = DateTimeFormat.forPattern(ISO8601_PATTERN); +// +// Date date = new Date(); +// DateTime dateTime = new DateTime(date); +// +// long start = System.nanoTime(); +// for (int i = 0; i < 100000; ++i) { +// jodaFormat.print(dateTime); +// } +// long jodaAvg = (System.nanoTime() - start) / 100000; +// +// +// start = System.nanoTime(); +// for (int i = 0; i < 100000; ++i) { +// simpleFormat.format(date); +// } +// long simpleAvg = (System.nanoTime() - start) / 100000; +// +// float diff = (((float) (simpleAvg - jodaAvg)) / simpleAvg) * 100; +// System.out.println("Raw - JDK: " + simpleAvg + " ns Joda: " + jodaAvg +// + " ns - Difference: " + diff + "%"); +// } public void testSynchronized() throws Exception { SynchronizedDateFormatter formatter = new SynchronizedDateFormatter(); @@ -151,30 +151,30 @@ public class DateFormatOriginal_tzest extends TestCase { } - public void testDateTimeFormatter() throws Exception { - int threads = 10; - int iterations = 10000; - Thread[] formatThreads = new DateTimeFormatThread[threads]; - JodaFormatter formatter = new JodaFormatter(); - Date date = new Date(); - DateTime dateTime = new DateTime(date); - - for (int i = 0; i < threads; i++) { - formatThreads[i] = new DateTimeFormatThread(formatter, dateTime, - iterations); - } - long start = System.nanoTime(); - for (Thread thread : formatThreads) { - thread.start(); - } - for (Thread thread : formatThreads) { - thread.join(); - } - long end = System.nanoTime(); - double actual = ((double) (end - start)) / NANOS_IN_ONE_SEC; - System.out.printf("Joda DateTimeFormatter: %,.4f seconds\n", actual); - - } +// public void testDateTimeFormatter() throws Exception { +// int threads = 10; +// int iterations = 10000; +// Thread[] formatThreads = new DateTimeFormatThread[threads]; +// JodaFormatter formatter = new JodaFormatter(); +// Date date = new Date(); +// DateTime dateTime = new DateTime(date); +// +// for (int i = 0; i < threads; i++) { +// formatThreads[i] = new DateTimeFormatThread(formatter, dateTime, +// iterations); +// } +// long start = System.nanoTime(); +// for (Thread thread : formatThreads) { +// thread.start(); +// } +// for (Thread thread : formatThreads) { +// thread.join(); +// } +// long end = System.nanoTime(); +// double actual = ((double) (end - start)) / NANOS_IN_ONE_SEC; +// System.out.printf("Joda DateTimeFormatter: %,.4f seconds\n", actual); +// +// } public interface Formatter { String format(Date date); @@ -206,13 +206,13 @@ public class DateFormatOriginal_tzest extends TestCase { } } - public static class JodaFormatter { - DateTimeFormatter formatter = DateTimeFormat.forPattern(ISO8601_PATTERN); - - public String format(DateTime date) { - return formatter.print(date); - } - } +// public static class JodaFormatter { +// DateTimeFormatter formatter = DateTimeFormat.forPattern(ISO8601_PATTERN); +// +// public String format(DateTime date) { +// return formatter.print(date); +// } +// } public static class DateFormatThread extends Thread { Formatter formatter; @@ -232,21 +232,21 @@ public class DateFormatOriginal_tzest extends TestCase { } } - public static class DateTimeFormatThread extends Thread { - JodaFormatter formatter; - DateTime date; - long iterCount; - - public DateTimeFormatThread(JodaFormatter f, DateTime date, long iterations) { - this.formatter = f; - this.date = date; - this.iterCount = iterations; - } - - public void run() { - for (int i = 0; i < iterCount; i++) { - formatter.format(this.date); - } - } - } +// public static class DateTimeFormatThread extends Thread { +// JodaFormatter formatter; +// DateTime date; +// long iterCount; +// +// public DateTimeFormatThread(JodaFormatter f, DateTime date, long iterations) { +// this.formatter = f; +// this.date = date; +// this.iterCount = iterations; +// } +// +// public void run() { +// for (int i = 0; i < iterCount; i++) { +// formatter.format(this.date); +// } +// } +// } } diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic36/DateFormatPerf_Tapp.java b/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic36/DateFormatPerf_Tapp.java index d08cf93..2cd7fd2 100644 --- a/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic36/DateFormatPerf_Tapp.java +++ b/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic36/DateFormatPerf_Tapp.java @@ -16,8 +16,8 @@ package ch.qos.logback.classic.issue.lbclassic36; import java.text.SimpleDateFormat; import java.util.Date; -import org.joda.time.format.DateTimeFormat; -import org.joda.time.format.DateTimeFormatter; +//import org.joda.time.format.DateTimeFormat; +//import org.joda.time.format.DateTimeFormatter; public class DateFormatPerf_Tapp { public static final String ISO8601_PATTERN = "yyyy-MM-dd HH:mm:ss,SSS"; @@ -40,11 +40,11 @@ public class DateFormatPerf_Tapp { } static double doRawJoda() { - DateTimeFormatter jodaFormat = DateTimeFormat.forPattern(ISO8601_PATTERN); +// DateTimeFormatter jodaFormat = DateTimeFormat.forPattern(ISO8601_PATTERN); long timeInMillis = new Date().getTime(); long start = System.nanoTime(); for (int i = 0; i < RUN_LENGTH; ++i) { - jodaFormat.print(timeInMillis); +// jodaFormat.print(timeInMillis); } return (System.nanoTime() - start) * 1.0d / RUN_LENGTH; } diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic36/SelectiveDateFormattingRunnable.java b/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic36/SelectiveDateFormattingRunnable.java index d358c39..37ea229 100644 --- a/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic36/SelectiveDateFormattingRunnable.java +++ b/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic36/SelectiveDateFormattingRunnable.java @@ -14,8 +14,8 @@ package ch.qos.logback.classic.issue.lbclassic36; import java.text.SimpleDateFormat; -import org.joda.time.format.DateTimeFormat; -import org.joda.time.format.DateTimeFormatter; +//import org.joda.time.format.DateTimeFormat; +//import org.joda.time.format.DateTimeFormatter; import ch.qos.logback.core.contention.RunnableWithCounterAndDone; @@ -38,8 +38,8 @@ public class SelectiveDateFormattingRunnable extends static long CACHE = 0; static SimpleDateFormat SDF = new SimpleDateFormat(ISO8601_PATTERN); - static final DateTimeFormatter JODA = DateTimeFormat - .forPattern(ISO8601_PATTERN); +// static final DateTimeFormatter JODA = DateTimeFormat +// .forPattern(ISO8601_PATTERN); SelectiveDateFormattingRunnable(FormattingModel model) { this.model = model; @@ -77,7 +77,7 @@ public class SelectiveDateFormattingRunnable extends for (;;) { long now = System.currentTimeMillis(); if (isCacheStale(now)) { - JODA.print(now); + //JODA.print(now); } counter++; if (done) { @@ -87,12 +87,12 @@ public class SelectiveDateFormattingRunnable extends } private static boolean isCacheStale(long now) { - synchronized (JODA) { - if (CACHE != now) { - CACHE = now; - return true; - } - } +// synchronized (JODA) { +// if (CACHE != now) { +// CACHE = now; +// return true; +// } +// } return false; } diff --git a/logback-core/pom.xml b/logback-core/pom.xml index 4efc958..fd2c90a 100644 --- a/logback-core/pom.xml +++ b/logback-core/pom.xml @@ -38,7 +38,7 @@ <dependencies> <dependency> - <groupId>janino</groupId> + <groupId>org.codehaus.janino</groupId> <artifactId>janino</artifactId> <scope>compile</scope> <optional>true</optional> diff --git a/logback-core/src/main/java/ch/qos/logback/core/util/EnvUtil.java b/logback-core/src/main/java/ch/qos/logback/core/util/EnvUtil.java index ec708aa..08e0e5e 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/util/EnvUtil.java +++ b/logback-core/src/main/java/ch/qos/logback/core/util/EnvUtil.java @@ -33,7 +33,7 @@ public class EnvUtil { static public boolean isJaninoAvailable() { ClassLoader classLoader = EnvUtil.class.getClassLoader(); try { - Class bindingClass = classLoader.loadClass("org.codehaus.janino.Cookable"); + Class bindingClass = classLoader.loadClass("org.codehaus.janino.ScriptEvaluator"); return (bindingClass != null); } catch (ClassNotFoundException e) { return false; diff --git a/pom.xml b/pom.xml index 6f88e10..7e6ced3 100755 --- a/pom.xml +++ b/pom.xml @@ -33,7 +33,7 @@ logback-classic/pom.xml and in setClasspath.cmd --> <slf4j.version>1.6.4</slf4j.version> <junit.version>4.10</junit.version> - <janino.version>2.5.10</janino.version> + <janino.version>2.5.16</janino.version> <scala.version>2.9.1</scala.version> <groovy.version>1.7.6</groovy.version> <consolePlugin.version>1.1.0</consolePlugin.version> @@ -91,7 +91,7 @@ <version>${slf4j.version}</version> </dependency> <dependency> - <groupId>janino</groupId> + <groupId>org.codehaus.janino</groupId> <artifactId>janino</artifactId> <version>${janino.version}</version> </dependency> ----------------------------------------------------------------------- Summary of changes: logback-access/pom.xml | 2 +- logback-classic/pom.xml | 9 +- .../lbclassic36/DateFormatOriginal_tzest.java | 150 ++++++++++---------- .../issue/lbclassic36/DateFormatPerf_Tapp.java | 8 +- .../SelectiveDateFormattingRunnable.java | 22 ++-- logback-core/pom.xml | 2 +- .../java/ch/qos/logback/core/util/EnvUtil.java | 2 +- pom.xml | 4 +- 8 files changed, 96 insertions(+), 103 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch master updated. v_1.0.0-52-g9c58b9e
by git-noreply＠pixie.qos.ch 10 Nov '11

10 Nov '11

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via 9c58b9e8202939b9a5888fb3896a88f82e04966b (commit) from 87c417adfa4fdd21035a1c6ebe5480b23bea8a4c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=9c58b9e8202939b9a5888fb3… http://github.com/ceki/logback/commit/9c58b9e8202939b9a5888fb3896a88f82e049… commit 9c58b9e8202939b9a5888fb3896a88f82e04966b Author: Ceki Gulcu <ceki(a)qos.ch> Date: Thu Nov 10 22:49:02 2011 +0100 removed redundant check in computeCurrentPeriodsHighestCounterValue diff --git a/logback-core/src/main/java/ch/qos/logback/core/rolling/SizeAndTimeBasedFNATP.java b/logback-core/src/main/java/ch/qos/logback/core/rolling/SizeAndTimeBasedFNATP.java index 570235e..bf17391 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/rolling/SizeAndTimeBasedFNATP.java +++ b/logback-core/src/main/java/ch/qos/logback/core/rolling/SizeAndTimeBasedFNATP.java @@ -53,8 +53,8 @@ public class SizeAndTimeBasedFNATP<E> extends void computeCurrentPeriodsHighestCounterValue(final String stemRegex) { File file = new File(getCurrentPeriodsFileNameWithoutCompressionSuffix()); - File parentDir = file.getParentFile(); + File[] matchingFileArray = FileFilterUtil .filesInFolderMatchingStemRegex(parentDir, stemRegex); @@ -64,19 +64,11 @@ public class SizeAndTimeBasedFNATP<E> extends } currentPeriodsCounter = FileFilterUtil.findHighestCounter(matchingFileArray, stemRegex); - // if parent raw file property is not null, then the next // counter is max found counter+1 - if (tbrp.getParentsRawFileProperty() != null) { - currentPeriodsCounter++; - } else if(tbrp.compressionMode != CompressionMode.NONE) { - // if raw file property == null, but compression is enabled - // we must check whether the last file whether the last file is - // compressed or not. + if (tbrp.getParentsRawFileProperty() != null || (tbrp.compressionMode != CompressionMode.NONE)) { // TODO test me - File fileCandidate = new File(getFileNameIncludingCompressionSuffix(dateInCurrentPeriod, currentPeriodsCounter)); - if(fileCandidate.exists()) - currentPeriodsCounter++; + currentPeriodsCounter++; } } ----------------------------------------------------------------------- Summary of changes: .../core/rolling/SizeAndTimeBasedFNATP.java | 14 +++----------- 1 files changed, 3 insertions(+), 11 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[JIRA] Created: (LBCORE-236) SizeAndTimeBasedFNATP does not account for last file being compressed
by TJ Rothwell (JIRA) 10 Nov '11

10 Nov '11

SizeAndTimeBasedFNATP does not account for last file being compressed --------------------------------------------------------------------- Key: LBCORE-236 URL: http://jira.qos.ch/browse/LBCORE-236 Project: logback-core Issue Type: Bug Components: Rolling Affects Versions: 1.0.0 Reporter: TJ Rothwell Assignee: Logback dev list When {{SizeAndTimeBasedFNATP}} determines it's initial index, it will not increment the counter if {{<file>}} has not been specified for the {{FileAppender}}. {noformat} <appender name="DEBUG-FILE" class="ch.qos.logback.core.rolling.RollingFileAppender">   <encoder class="ch.qos.logback.classic.encoder.PatternLayoutEncoder"> <pattern>${DEBUG_FILE_PATTERN}</pattern> </encoder> <rollingPolicy class="ch.qos.logback.core.rolling.TimeBasedRollingPolicy"> <fileNamePattern>${CONTEXT_DATA_PATH}/logs/server/server-debug.%d{yyyy-MM-dd}.%i.txt.zip</fileNamePattern> <maxHistory>${DEBUG_FILE_MAX_HISTORY}</maxHistory> <timeBasedFileNamingAndTriggeringPolicy class="ch.qos.logback.core.rolling.SizeAndTimeBasedFNATP"> <maxFileSize>100MB</maxFileSize> </timeBasedFileNamingAndTriggeringPolicy> </rollingPolicy> <filter class="ch.qos.logback.classic.filter.ThresholdFilter"> <level>${DEBUG_FILE_LEVEL}</level> </filter> </appender> {noformat} -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch master updated. v_1.0.0-51-g87c417a
by git-noreply＠pixie.qos.ch 10 Nov '11

10 Nov '11

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via 87c417adfa4fdd21035a1c6ebe5480b23bea8a4c (commit) from c0d9b3b41b6cac04daa19d30f7a262ba81e8e319 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=87c417adfa4fdd21035a1c6e… http://github.com/ceki/logback/commit/87c417adfa4fdd21035a1c6ebe5480b23bea8… commit 87c417adfa4fdd21035a1c6ebe5480b23bea8a4c Author: Ceki Gulcu <ceki(a)qos.ch> Date: Thu Nov 10 18:22:14 2011 +0100 TODO: test changes in computeCurrentPeriodsHighestCounterValue() diff --git a/logback-core/src/main/java/ch/qos/logback/core/rolling/SizeAndTimeBasedFNATP.java b/logback-core/src/main/java/ch/qos/logback/core/rolling/SizeAndTimeBasedFNATP.java index 9b28199..570235e 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/rolling/SizeAndTimeBasedFNATP.java +++ b/logback-core/src/main/java/ch/qos/logback/core/rolling/SizeAndTimeBasedFNATP.java @@ -73,6 +73,7 @@ public class SizeAndTimeBasedFNATP<E> extends // if raw file property == null, but compression is enabled // we must check whether the last file whether the last file is // compressed or not. + // TODO test me File fileCandidate = new File(getFileNameIncludingCompressionSuffix(dateInCurrentPeriod, currentPeriodsCounter)); if(fileCandidate.exists()) currentPeriodsCounter++; ----------------------------------------------------------------------- Summary of changes: .../core/rolling/SizeAndTimeBasedFNATP.java | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0