- logback-dev - mailman3.qos.ch

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. v0.9.18-96-gea6065c
by git-noreply＠pixie.qos.ch 18 Mar '10

18 Mar '10

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via ea6065ca315b78c7e0eb40d3fe85faec6441a834 (commit) from 821d05c90831d9f07d00bbc3f004561c37c1a0c0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=ea6065ca315b78c7e0eb40d3… http://github.com/ceki/logback/commit/ea6065ca315b78c7e0eb40d3fe85faec6441a… commit ea6065ca315b78c7e0eb40d3fe85faec6441a834 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Thu Mar 18 21:49:40 2010 +0100 - have all tests pass diff --git a/logback-core/src/main/java/ch/qos/logback/core/pattern/parser/Parser.java b/logback-core/src/main/java/ch/qos/logback/core/pattern/parser/Parser.java index c0321f0..268edea 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/pattern/parser/Parser.java +++ b/logback-core/src/main/java/ch/qos/logback/core/pattern/parser/Parser.java @@ -41,7 +41,7 @@ public class Parser<E> extends ContextAwareBase { try { TokenStream ts = new TokenStream(pattern, escapeUtil); this.tokenList = ts.tokenize(); - } catch (NullPointerException npe) { + } catch (IllegalArgumentException npe) { throw new ScanException("Failed to initialize Parser", npe); } } diff --git a/logback-core/src/main/java/ch/qos/logback/core/pattern/parser/TokenStream.java b/logback-core/src/main/java/ch/qos/logback/core/pattern/parser/TokenStream.java index d5080d5..b0dc881 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/pattern/parser/TokenStream.java +++ b/logback-core/src/main/java/ch/qos/logback/core/pattern/parser/TokenStream.java @@ -20,24 +20,29 @@ import ch.qos.logback.core.CoreConstants; import ch.qos.logback.core.pattern.util.IEscapeUtil; import ch.qos.logback.core.pattern.util.RegularEscapeUtil; - - /** - * Return a steady stream of tokens. + * + * Return a steady stream of tokens. + * * - * The returned tokens are one of: - * LITERAL, '%', FORMAT_MODIFIER, KEYWWORD, OPTION, LEFT_PARENTHESIS, and - * RIGHT_PARENTHESIS. + * + * The returned tokens are one of: LITERAL, '%', FORMAT_MODIFIER, KEYWWORD, + * OPTION, LEFT_PARENTHESIS, and RIGHT_PARENTHESIS. + * * - * The '\' character is used as escape. It can be used to escape '_', '%', '(' and - * '('. + * + * The '\' character is used as escape. It can be used to escape '_', '%', '(' + * and '('. + * * - * Note that there is no EOS token returned. + * + * Note that there is no EOS token returned. + * */ class TokenStream { private static final char ESCAPE_CHAR = '\\'; - private static final char PERCENT_CHAR = CoreConstants.PERCENT_CHAR; + private static final char PERCENT_CHAR = CoreConstants.PERCENT_CHAR; private static final char CURLY_LEFT = '{'; private static final char CURLY_RIGHT = '}'; @@ -49,7 +54,7 @@ class TokenStream { final String pattern; final int patternLength; final IEscapeUtil escapeUtil; - + int state = LITERAL_STATE; int pointer = 0; @@ -57,10 +62,11 @@ class TokenStream { TokenStream(String pattern) { this(pattern, new RegularEscapeUtil()); } - + TokenStream(String pattern, IEscapeUtil escapeUtil) { - if(pattern == null || pattern.length() == 0) { - throw new NullPointerException("null or empty pattern string not allowed"); + if (pattern == null || pattern.length() == 0) { + throw new IllegalArgumentException( + "null or empty pattern string not allowed"); } this.pattern = pattern; patternLength = pattern.length(); diff --git a/logback-core/src/test/java/ch/qos/logback/core/appender/AbstractAppenderTest.java b/logback-core/src/test/java/ch/qos/logback/core/appender/AbstractAppenderTest.java index 60457c8..826194a 100644 --- a/logback-core/src/test/java/ch/qos/logback/core/appender/AbstractAppenderTest.java +++ b/logback-core/src/test/java/ch/qos/logback/core/appender/AbstractAppenderTest.java @@ -55,6 +55,7 @@ abstract public class AbstractAppenderTest<E> { @Test public void testNoStart() { Appender<E> appender = getAppender(); + appender.setContext(context); appender.setName("doh"); // is null OK? appender.doAppend(null); diff --git a/logback-core/src/test/java/ch/qos/logback/core/appender/ConsoleAppenderTest.java b/logback-core/src/test/java/ch/qos/logback/core/appender/ConsoleAppenderTest.java index 74bdd80..a4e5063 100644 --- a/logback-core/src/test/java/ch/qos/logback/core/appender/ConsoleAppenderTest.java +++ b/logback-core/src/test/java/ch/qos/logback/core/appender/ConsoleAppenderTest.java @@ -61,9 +61,7 @@ public class ConsoleAppenderTest extends AbstractAppenderTest<Object> { @Override public Appender<Object> getAppender() { - ConsoleAppender<Object> ca = new ConsoleAppender<Object>(); - ca.setContext(context); - return ca; + return new ConsoleAppender<Object>(); } protected Appender<Object> getConfiguredAppender() { diff --git a/logback-core/src/test/java/ch/qos/logback/core/appender/FileAppenderTest.java b/logback-core/src/test/java/ch/qos/logback/core/appender/FileAppenderTest.java index 0c3f5d1..d3022ed 100644 --- a/logback-core/src/test/java/ch/qos/logback/core/appender/FileAppenderTest.java +++ b/logback-core/src/test/java/ch/qos/logback/core/appender/FileAppenderTest.java @@ -19,26 +19,23 @@ import static org.junit.Assert.assertTrue; import java.io.File; import java.util.List; -import java.util.Random; import org.junit.Test; import ch.qos.logback.core.Appender; -import ch.qos.logback.core.Context; -import ch.qos.logback.core.ContextBase; import ch.qos.logback.core.FileAppender; import ch.qos.logback.core.encoder.DummyEncoder; import ch.qos.logback.core.encoder.NopEncoder; import ch.qos.logback.core.status.Status; import ch.qos.logback.core.status.StatusManager; +import ch.qos.logback.core.testUtil.RandomUtil; import ch.qos.logback.core.util.CoreTestConstants; import ch.qos.logback.core.util.FileUtil; import ch.qos.logback.core.util.StatusPrinter; public class FileAppenderTest extends AbstractAppenderTest<Object> { - int diff = new Random().nextInt(100); - Context context = new ContextBase(); + int diff = RandomUtil.getPositiveInt(); protected Appender<Object> getAppender() { return new FileAppender<Object>(); diff --git a/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/TokenStreamTest.java b/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/TokenStreamTest.java index 4ce47ce..d737a56 100644 --- a/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/TokenStreamTest.java +++ b/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/TokenStreamTest.java @@ -13,9 +13,8 @@ */ package ch.qos.logback.core.pattern.parser; - - import static org.junit.Assert.assertEquals; +import static org.junit.Assert.fail; import java.util.ArrayList; import java.util.List; @@ -24,14 +23,15 @@ import org.junit.Test; import ch.qos.logback.core.pattern.util.AlmostAsIsEscapeUtil; -public class TokenStreamTest { - +public class TokenStreamTest { @Test public void testEmpty() throws ScanException { - List tl = new TokenStream("").tokenize(); - List witness = new ArrayList(); - assertEquals(witness, tl); + try { + new TokenStream("").tokenize(); + fail("empty string not allowed"); + } catch (IllegalArgumentException e) { + } } @Test @@ -330,8 +330,8 @@ public class TokenStreamTest { @Test public void testWindowsLikeBackSlashes() throws ScanException { { - List tl = new TokenStream("c:\\hello\\world.%i", new AlmostAsIsEscapeUtil()) - .tokenize(); + List tl = new TokenStream("c:\\hello\\world.%i", + new AlmostAsIsEscapeUtil()).tokenize(); List<Token> witness = new ArrayList<Token>(); witness.add(new Token(Token.LITERAL, "c:\\hello\\world.")); diff --git a/logback-core/src/test/java/ch/qos/logback/core/rolling/PackageTest.java b/logback-core/src/test/java/ch/qos/logback/core/rolling/PackageTest.java index ecc934b..94e8ca5 100644 --- a/logback-core/src/test/java/ch/qos/logback/core/rolling/PackageTest.java +++ b/logback-core/src/test/java/ch/qos/logback/core/rolling/PackageTest.java @@ -21,6 +21,7 @@ import org.junit.runners.Suite; TimeBasedRollingTest.class, TimeBasedRollingWithArchiveRemovalTest.class, MultiThreadedRollingTest.class, SizeAndTimeBasedFNATP_Test.class, + RollingFileAppenderTest.class, ch.qos.logback.core.rolling.helper.PackageTest.class }) public class PackageTest { } ----------------------------------------------------------------------- Summary of changes: .../ch/qos/logback/core/pattern/parser/Parser.java | 2 +- .../logback/core/pattern/parser/TokenStream.java | 34 +++++++++++-------- .../core/appender/AbstractAppenderTest.java | 1 + .../logback/core/appender/ConsoleAppenderTest.java | 4 +-- .../logback/core/appender/FileAppenderTest.java | 7 +--- .../core/pattern/parser/TokenStreamTest.java | 18 +++++----- .../ch/qos/logback/core/rolling/PackageTest.java | 1 + 7 files changed, 35 insertions(+), 32 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. v0.9.18-95-g821d05c
by git-noreply＠pixie.qos.ch 18 Mar '10

18 Mar '10

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via 821d05c90831d9f07d00bbc3f004561c37c1a0c0 (commit) from e13257d75b2b4439c4c98b85e25a76611080a3d4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=821d05c90831d9f07d00bbc3… http://github.com/ceki/logback/commit/821d05c90831d9f07d00bbc3f004561c37c1a… commit 821d05c90831d9f07d00bbc3f004561c37c1a0c0 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Thu Mar 18 21:31:57 2010 +0100 - additional tests and minor changes diff --git a/logback-classic/src/main/java/ch/qos/logback/classic/pattern/EnsureExceptionHandling.java b/logback-classic/src/main/java/ch/qos/logback/classic/pattern/EnsureExceptionHandling.java index 99a4a58..b9785c7 100644 --- a/logback-classic/src/main/java/ch/qos/logback/classic/pattern/EnsureExceptionHandling.java +++ b/logback-classic/src/main/java/ch/qos/logback/classic/pattern/EnsureExceptionHandling.java @@ -37,14 +37,14 @@ public class EnsureExceptionHandling implements * */ public void process(Converter<ILoggingEvent> head) { + if(head == null) { + // this should never happen + throw new IllegalArgumentException("cannot process empty chain"); + } if (!chainHandlesThrowable(head)) { Converter<ILoggingEvent> tail = ConverterUtil.findTail(head); Converter<ILoggingEvent> exConverter = new ExtendedThrowableProxyConverter(); - if (tail == null) { - head = exConverter; - } else { - tail.setNext(exConverter); - } + tail.setNext(exConverter); } } diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/util/LogbackMDCAdapterTest.java b/logback-classic/src/test/java/ch/qos/logback/classic/util/LogbackMDCAdapterTest.java index 4c8cf51..24dc122 100644 --- a/logback-classic/src/test/java/ch/qos/logback/classic/util/LogbackMDCAdapterTest.java +++ b/logback-classic/src/test/java/ch/qos/logback/classic/util/LogbackMDCAdapterTest.java @@ -19,19 +19,17 @@ import static org.junit.Assert.assertNull; import static org.junit.Assert.assertTrue; import java.util.HashMap; -import java.util.Random; import org.junit.Test; import org.slf4j.MDC; -import ch.qos.logback.classic.util.CopyOnInheritThreadLocal; -import ch.qos.logback.classic.util.LogbackMDCAdapter; +import ch.qos.logback.core.testUtil.RandomUtil; public class LogbackMDCAdapterTest { final static String A_SUFFIX = "A_SUFFIX"; - int diff = new Random().nextInt(); + int diff = RandomUtil.getPositiveInt(); /** * Test that CopyOnInheritThreadLocal does not barf when the diff --git a/logback-classic/src/test/java/org/slf4j/impl/RecursiveInitializationTest.java b/logback-classic/src/test/java/org/slf4j/impl/RecursiveInitializationTest.java index c163434..2e3c698 100644 --- a/logback-classic/src/test/java/org/slf4j/impl/RecursiveInitializationTest.java +++ b/logback-classic/src/test/java/org/slf4j/impl/RecursiveInitializationTest.java @@ -15,8 +15,6 @@ package org.slf4j.impl; import static org.junit.Assert.assertEquals; -import java.util.Random; - import org.junit.After; import org.junit.Before; import org.junit.Test; @@ -28,11 +26,12 @@ import ch.qos.logback.classic.LoggerContext; import ch.qos.logback.classic.util.ContextInitializer; import ch.qos.logback.core.status.Status; import ch.qos.logback.core.status.StatusManager; +import ch.qos.logback.core.testUtil.RandomUtil; import ch.qos.logback.core.util.StatusPrinter; public class RecursiveInitializationTest { - int diff = new Random().nextInt(); + int diff = RandomUtil.getPositiveInt(); @Before public void setUp() throws Exception { diff --git a/logback-classic/src/test/java/org/slf4j/impl/RecursiveLBAppender.java b/logback-classic/src/test/java/org/slf4j/impl/RecursiveLBAppender.java index c444d9c..7eeb7a7 100644 --- a/logback-classic/src/test/java/org/slf4j/impl/RecursiveLBAppender.java +++ b/logback-classic/src/test/java/org/slf4j/impl/RecursiveLBAppender.java @@ -15,7 +15,6 @@ package org.slf4j.impl; import java.util.ArrayList; import java.util.List; -import java.util.Random; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -23,6 +22,7 @@ import org.slf4j.LoggerFactory; import ch.qos.logback.classic.PatternLayout; import ch.qos.logback.classic.spi.ILoggingEvent; import ch.qos.logback.core.AppenderBase; +import ch.qos.logback.core.testUtil.RandomUtil; public class RecursiveLBAppender extends AppenderBase<ILoggingEvent> { @@ -41,7 +41,7 @@ public class RecursiveLBAppender extends AppenderBase<ILoggingEvent> { @Override public void start() { - int diff = new Random().nextInt(); + int diff = RandomUtil.getPositiveInt(); Logger logger = LoggerFactory.getLogger("ResursiveLBAppender"+diff); logger.info("testing"); super.start(); diff --git a/logback-core/src/main/java/ch/qos/logback/core/ConsoleAppender.java b/logback-core/src/main/java/ch/qos/logback/core/ConsoleAppender.java index 9946454..8b7661d 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/ConsoleAppender.java +++ b/logback-core/src/main/java/ch/qos/logback/core/ConsoleAppender.java @@ -13,6 +13,8 @@ */ package ch.qos.logback.core; +import java.util.Arrays; + import ch.qos.logback.core.joran.spi.ConsoleTarget; import ch.qos.logback.core.status.Status; import ch.qos.logback.core.status.WarnStatus; @@ -41,6 +43,7 @@ public class ConsoleAppender<E> extends OutputStreamAppender<E> { public void setTarget(String value) { ConsoleTarget t = ConsoleTarget.findByName(value.trim()); if (t == null) { + System.out.println("**************"); targetWarn(value); } else { target = t; @@ -58,8 +61,10 @@ public class ConsoleAppender<E> extends OutputStreamAppender<E> { } private void targetWarn(String val) { - Status status = new WarnStatus("[" + val + " should be in " + ConsoleTarget.values(), this); - status.add(new WarnStatus("Using previously set target, System.out by default.", this)); + Status status = new WarnStatus("[" + val + "] should be one of " + + Arrays.toString(ConsoleTarget.values()), this); + status.add(new WarnStatus( + "Using previously set target, System.out by default.", this)); addStatus(status); } diff --git a/logback-core/src/main/java/ch/qos/logback/core/pattern/ConverterUtil.java b/logback-core/src/main/java/ch/qos/logback/core/pattern/ConverterUtil.java index 19c8628..03f65e8 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/pattern/ConverterUtil.java +++ b/logback-core/src/main/java/ch/qos/logback/core/pattern/ConverterUtil.java @@ -36,15 +36,15 @@ public class ConverterUtil { public static<E> Converter<E> findTail(Converter<E> head) { - Converter<E> c = head; - while (c != null) { - Converter<E> next = c.getNext(); + Converter<E> p = head; + while (p != null) { + Converter<E> next = p.getNext(); if (next == null) { break; } else { - c = next; + p = next; } } - return c; + return p; } } diff --git a/logback-core/src/main/java/ch/qos/logback/core/pattern/FormatInfo.java b/logback-core/src/main/java/ch/qos/logback/core/pattern/FormatInfo.java index a424361..1f6c9a5 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/pattern/FormatInfo.java +++ b/logback-core/src/main/java/ch/qos/logback/core/pattern/FormatInfo.java @@ -50,7 +50,7 @@ public class FormatInfo { */ public static FormatInfo valueOf(String str) throws IllegalArgumentException { if (str == null) { - new NullPointerException("Argument cannot be null"); + throw new NullPointerException("Argument cannot be null"); } FormatInfo fi = new FormatInfo(); diff --git a/logback-core/src/main/java/ch/qos/logback/core/pattern/PatternLayoutBase.java b/logback-core/src/main/java/ch/qos/logback/core/pattern/PatternLayoutBase.java index 0210484..6a76153 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/pattern/PatternLayoutBase.java +++ b/logback-core/src/main/java/ch/qos/logback/core/pattern/PatternLayoutBase.java @@ -71,7 +71,11 @@ abstract public class PatternLayoutBase<E> extends LayoutBase<E> { } public void start() { - try { + if(pattern == null || pattern.length() == 0) { + addError("Empty or null pattern."); + return; + } + try { Parser<E> p = new Parser<E>(pattern); if (getContext() != null) { p.setContext(getContext()); diff --git a/logback-core/src/main/java/ch/qos/logback/core/pattern/parser/TokenStream.java b/logback-core/src/main/java/ch/qos/logback/core/pattern/parser/TokenStream.java index 8e9abff..d5080d5 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/pattern/parser/TokenStream.java +++ b/logback-core/src/main/java/ch/qos/logback/core/pattern/parser/TokenStream.java @@ -59,8 +59,8 @@ class TokenStream { } TokenStream(String pattern, IEscapeUtil escapeUtil) { - if(pattern == null) { - throw new NullPointerException("null pattern string not allowed"); + if(pattern == null || pattern.length() == 0) { + throw new NullPointerException("null or empty pattern string not allowed"); } this.pattern = pattern; patternLength = pattern.length(); diff --git a/logback-core/src/main/java/ch/qos/logback/core/pattern/util/RegularEscapeUtil.java b/logback-core/src/main/java/ch/qos/logback/core/pattern/util/RegularEscapeUtil.java index d4feaa0..b4a6295 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/pattern/util/RegularEscapeUtil.java +++ b/logback-core/src/main/java/ch/qos/logback/core/pattern/util/RegularEscapeUtil.java @@ -43,7 +43,7 @@ public class RegularEscapeUtil implements IEscapeUtil { break; default: String commaSeperatedEscapeChars = formatEscapeCharsForListing(escapeChars); - new IllegalArgumentException("Illegal char '" + next + " at column " + throw new IllegalArgumentException("Illegal char '" + next + " at column " + pointer + ". Only \\\\, \\_" + commaSeperatedEscapeChars + ", \\t, \\n, \\r combinations are allowed as escape characters."); } diff --git a/logback-core/src/test/java/ch/qos/logback/core/appender/AbstractAppenderTest.java b/logback-core/src/test/java/ch/qos/logback/core/appender/AbstractAppenderTest.java index 61b0826..60457c8 100644 --- a/logback-core/src/test/java/ch/qos/logback/core/appender/AbstractAppenderTest.java +++ b/logback-core/src/test/java/ch/qos/logback/core/appender/AbstractAppenderTest.java @@ -23,6 +23,7 @@ import ch.qos.logback.core.Appender; import ch.qos.logback.core.Context; import ch.qos.logback.core.ContextBase; import ch.qos.logback.core.status.StatusChecker; +import ch.qos.logback.core.util.StatusPrinter; @@ -31,7 +32,8 @@ abstract public class AbstractAppenderTest<E> { abstract protected Appender<E> getAppender(); abstract protected Appender<E> getConfiguredAppender(); - + Context context = new ContextBase(); + @Test public void testNewAppender() { // new appenders should be inactive @@ -53,13 +55,11 @@ abstract public class AbstractAppenderTest<E> { @Test public void testNoStart() { Appender<E> appender = getAppender(); - Context context = new ContextBase(); - appender.setContext(context); appender.setName("doh"); // is null OK? appender.doAppend(null); StatusChecker checker = new StatusChecker(context.getStatusManager()); - //StatusPrinter.print(context.getStatusManager()); + StatusPrinter.print(context); assertTrue(checker.containsMatch("Attempted to append to non started appender \\[doh\\].")); } } diff --git a/logback-core/src/test/java/ch/qos/logback/core/appender/ConsoleAppenderTest.java b/logback-core/src/test/java/ch/qos/logback/core/appender/ConsoleAppenderTest.java index e8e015c..74bdd80 100644 --- a/logback-core/src/test/java/ch/qos/logback/core/appender/ConsoleAppenderTest.java +++ b/logback-core/src/test/java/ch/qos/logback/core/appender/ConsoleAppenderTest.java @@ -30,14 +30,15 @@ import ch.qos.logback.core.encoder.DummyEncoder; import ch.qos.logback.core.encoder.EchoEncoder; import ch.qos.logback.core.encoder.NopEncoder; import ch.qos.logback.core.layout.DummyLayout; - +import ch.qos.logback.core.status.Status; +import ch.qos.logback.core.status.StatusChecker; +import ch.qos.logback.core.util.StatusPrinter; public class ConsoleAppenderTest extends AbstractAppenderTest<Object> { XTeeOutputStream tee; PrintStream original; - @Before public void setUp() throws Exception { original = System.out; @@ -45,10 +46,10 @@ public class ConsoleAppenderTest extends AbstractAppenderTest<Object> { // collect them so that the output can be compared against // some expected output data // tee = new TeeOutputStream(original); - + // keep the console quiet tee = new XTeeOutputStream(null); - + // redirect System.out to tee System.setOut(new PrintStream(tee)); } @@ -60,8 +61,10 @@ public class ConsoleAppenderTest extends AbstractAppenderTest<Object> { @Override public Appender<Object> getAppender() { - return new ConsoleAppender<Object>(); - } + ConsoleAppender<Object> ca = new ConsoleAppender<Object>(); + ca.setContext(context); + return ca; + } protected Appender<Object> getConfiguredAppender() { ConsoleAppender<Object> ca = new ConsoleAppender<Object>(); @@ -78,7 +81,7 @@ public class ConsoleAppenderTest extends AbstractAppenderTest<Object> { ca.doAppend(new Object()); assertEquals(DummyLayout.DUMMY, tee.toString()); } - + @org.junit.Test public void testOpen() { ConsoleAppender<Object> ca = (ConsoleAppender<Object>) getAppender(); @@ -88,9 +91,10 @@ public class ConsoleAppenderTest extends AbstractAppenderTest<Object> { ca.start(); ca.doAppend(new Object()); ca.stop(); - assertEquals("open"+CoreConstants.LINE_SEPARATOR+DummyLayout.DUMMY, tee.toString()); + assertEquals("open" + CoreConstants.LINE_SEPARATOR + DummyLayout.DUMMY, tee + .toString()); } - + @Test public void testClose() { ConsoleAppender<Object> ca = (ConsoleAppender<Object>) getAppender(); @@ -114,16 +118,15 @@ public class ConsoleAppenderTest extends AbstractAppenderTest<Object> { ca.setEncoder(encoder); ca.start(); ca.doAppend("a"); - assertEquals("a"+CoreConstants.LINE_SEPARATOR, tee.toString()); - + assertEquals("a" + CoreConstants.LINE_SEPARATOR, tee.toString()); + XTeeOutputStream newTee = new XTeeOutputStream(null); System.setOut(new PrintStream(newTee)); ca.doAppend("b"); - assertEquals("b"+CoreConstants.LINE_SEPARATOR, newTee.toString()); + assertEquals("b" + CoreConstants.LINE_SEPARATOR, newTee.toString()); } - - @Test + @Test public void testUTF16BE() throws UnsupportedEncodingException { ConsoleAppender<Object> ca = (ConsoleAppender<Object>) getAppender(); DummyEncoder<Object> dummyEncoder = new DummyEncoder<Object>(); @@ -135,5 +138,21 @@ public class ConsoleAppenderTest extends AbstractAppenderTest<Object> { assertEquals(DummyLayout.DUMMY, new String(tee.toByteArray(), encodingName)); } + @Test + public void wrongTarget() { + ConsoleAppender<Object> ca = (ConsoleAppender<Object>) getAppender(); + EchoEncoder<Object> encoder = new EchoEncoder<Object>(); + System.out.println("xxx"); + ca.setTarget("foo"); + ca.setEncoder(encoder); + ca.start(); + ca.doAppend("a"); + StatusChecker checker = new StatusChecker(context); + //21:28:01,246 + WARN in ch.qos.logback.core.ConsoleAppender[null] - [foo] should be one of [SystemOut, SystemErr] + //21:28:01,246 |-WARN in ch.qos.logback.core.ConsoleAppender[null] - Using previously set target, System.out by default. + + checker.containsMatch(Status.ERROR, "\\[foo\\] should be one of \\[SystemOut, SystemErr\\]"); + + } } diff --git a/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/AbstractPatternLayoutBaseTest.java b/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/AbstractPatternLayoutBaseTest.java index 8236b9c..a659adb 100644 --- a/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/AbstractPatternLayoutBaseTest.java +++ b/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/AbstractPatternLayoutBaseTest.java @@ -79,12 +79,28 @@ abstract public class AbstractPatternLayoutBaseTest<E> { PatternLayoutBase<E> plb = getPatternLayoutBase(); Context context = new ContextBase(); plb.setContext(context); + plb.setPattern(null); plb.start(); String s = plb.doLayout(getEventObject()); assertEquals("", s); StatusChecker checker = new StatusChecker(context.getStatusManager()); - //StatusPrinter.print(context.getStatusManager()); - assertTrue(checker.containsMatch("Failed to parse pattern \"null\"")); + StatusPrinter.print(context); + assertTrue(checker.containsMatch("Empty or null pattern.")); + } + + @Test + public void testEmptyPattern() { + //System.out.println("testNullPattern"); + PatternLayoutBase<E> plb = getPatternLayoutBase(); + Context context = new ContextBase(); + plb.setContext(context); + plb.setPattern(""); + plb.start(); + String s = plb.doLayout(getEventObject()); + assertEquals("", s); + StatusChecker checker = new StatusChecker(context.getStatusManager()); + StatusPrinter.print(context); + assertTrue(checker.containsMatch("Empty or null pattern.")); } } diff --git a/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/ParserTest.java b/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/ParserTest.java index e9d01e9..26ea464 100644 --- a/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/ParserTest.java +++ b/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/ParserTest.java @@ -14,6 +14,7 @@ package ch.qos.logback.core.pattern.parser; import static org.junit.Assert.assertEquals; +import static org.junit.Assert.fail; import java.util.ArrayList; import java.util.List; @@ -242,4 +243,15 @@ public class ParserTest { assertEquals(witness, t); } } + + @Test + public void empty() { + try { + Parser p = new Parser(""); + p.parse(); + fail(""); + } catch(ScanException e) { + + } + } } \ No newline at end of file ----------------------------------------------------------------------- Summary of changes: .../classic/pattern/EnsureExceptionHandling.java | 10 ++-- .../classic/util/LogbackMDCAdapterTest.java | 6 +-- .../slf4j/impl/RecursiveInitializationTest.java | 5 +- .../java/org/slf4j/impl/RecursiveLBAppender.java | 4 +- .../java/ch/qos/logback/core/ConsoleAppender.java | 9 +++- .../ch/qos/logback/core/pattern/ConverterUtil.java | 10 ++-- .../ch/qos/logback/core/pattern/FormatInfo.java | 2 +- .../logback/core/pattern/PatternLayoutBase.java | 6 ++- .../logback/core/pattern/parser/TokenStream.java | 4 +- .../core/pattern/util/RegularEscapeUtil.java | 2 +- .../core/appender/AbstractAppenderTest.java | 8 ++-- .../logback/core/appender/ConsoleAppenderTest.java | 47 ++++++++++++++------ .../parser/AbstractPatternLayoutBaseTest.java | 20 ++++++++- .../logback/core/pattern/parser/ParserTest.java | 12 +++++ 14 files changed, 99 insertions(+), 46 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

TurboFilters to transform events
by Ceki Gülcü 18 Mar '10

18 Mar '10

Hello all, At present time, a TurboFilter cannot modify the contents of an event. This decision was made in order to avoid the cost of constructing a LoggingEvent (about 20 nanoseconds) which would be later tossed out by the logger-level filter. 20 ns is not much but in absolute terms but considering that invoking the logger-level filter costs 3ns, 20ns is quite a steep price to pay in relative terms on every logger printing method invocation (for disabled logger requests). For the case where there are no turbo filters installed, performance would remain quasi-identical. For the case with one or more turbo filters installed, there would be an extra cost of 20ns. However, since invoking even the most rudimentary turbo filter costs 40ns or more, I think the 20ns overhead is well spent considering that it would allow turbo filters to transform events. Unfortunately, the TurboFilter interface would need to be modified breaking compatibility with existing turbo filters. Comments? -- Ceki

2 4

[JIRA] Created: (LBSITE-36) Example 7.5 Is Not Thread-Safe
by john jimenez (JIRA) 18 Mar '10

18 Mar '10

Example 7.5 Is Not Thread-Safe ------------------------------ Key: LBSITE-36 URL: http://jira.qos.ch/browse/LBSITE-36 Project: logback-site Issue Type: Bug Components: Documentation Affects Versions: unspecified Reporter: john jimenez Assignee: Logback dev list Example 7.5 in http://logback.qos.ch/manual/mdc.html is not thread-safe because userRegistered is declared as a global variable. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

3 5

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. v0.9.18-94-ge13257d
by git-noreply＠pixie.qos.ch 18 Mar '10

18 Mar '10

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via e13257d75b2b4439c4c98b85e25a76611080a3d4 (commit) from 499abbba89771332844fa84262e77277f66e8932 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=e13257d75b2b4439c4c98b85… http://github.com/ceki/logback/commit/e13257d75b2b4439c4c98b85e25a76611080a… commit e13257d75b2b4439c4c98b85e25a76611080a3d4 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Thu Mar 18 19:08:24 2010 +0100 Fixed http://jira.qos.ch/browse/LBSITE-36 diff --git a/logback-examples/src/main/java/chapters/mdc/UserServletFilter.java b/logback-examples/src/main/java/chapters/mdc/UserServletFilter.java index cc9db4c..532517b 100644 --- a/logback-examples/src/main/java/chapters/mdc/UserServletFilter.java +++ b/logback-examples/src/main/java/chapters/mdc/UserServletFilter.java @@ -23,38 +23,21 @@ import javax.servlet.ServletException; import javax.servlet.ServletRequest; import javax.servlet.ServletResponse; import javax.servlet.http.HttpServletRequest; -import javax.servlet.http.HttpSession; import org.slf4j.MDC; /** * A simple servlet filter that puts the username - * found either in the Principle or as a session attribute - * in the MDC. + * found either in the Principal. * - * The value is removed from the MDC once the request has been + * The value is removed from the MDC once the request has been * fully processed. * - * To be used, add the following lines to a web.xml file - * - * <filter> - * <filter-name>User Servlet Filter</filter-name> - * <filter-class> - * chapters.mdc.UserServletFilter - * </filter-class> - * </filter> - * <filter-mapping> - * <filter-name>User Servlet Filter</filter-name> - * <url-pattern>/*</url-pattern> - * </filter-mapping> - * * @author Sébastien Pennec */ public class UserServletFilter implements Filter { - boolean userRegistered = false; - - private final String userKey = "username"; + private final String USER_KEY = "username"; public void destroy() { } @@ -62,25 +45,22 @@ public class UserServletFilter implements Filter { public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain) throws IOException, ServletException { + boolean successfulRegistration = false; HttpServletRequest req = (HttpServletRequest) request; Principal principal = req.getUserPrincipal(); - // Please note that we could have also used a cookie to - // retreive the user name + // Please note that we also could have used a cookie to + // retrieve the user name if (principal != null) { String username = principal.getName(); - registerUsername(username); - } else { - HttpSession session = req.getSession(); - String username = (String)session.getAttribute(userKey); - registerUsername(username); + successfulRegistration = registerUsername(username); } try { chain.doFilter(request, response); } finally { - if (userRegistered) { - MDC.remove(userKey); + if (successfulRegistration) { + MDC.remove(USER_KEY); } } } @@ -88,11 +68,18 @@ public class UserServletFilter implements Filter { public void init(FilterConfig arg0) throws ServletException { } - private void registerUsername(String username) { + /** + * Register the user in the MDC under USER_KEY. + * + * @param username + * @return true id the user can be successfully registered + */ + private boolean registerUsername(String username) { if (username != null && username.trim().length() > 0) { - MDC.put(userKey, username); - userRegistered = true; + MDC.put(USER_KEY, username); + return true; } + return false; } } diff --git a/logback-site/src/site/pages/manual/mdc.html b/logback-site/src/site/pages/manual/mdc.html index 43e0c1a..6cdfc59 100644 --- a/logback-site/src/site/pages/manual/mdc.html +++ b/logback-site/src/site/pages/manual/mdc.html @@ -550,9 +550,7 @@ import org.slf4j.MDC; public class UserServletFilter implements Filter { - boolean userRegistered = false; - - private final String userKey = "username"; + private final String USER_KEY = "username"; public void destroy() { } @@ -560,26 +558,23 @@ public class UserServletFilter implements Filter { public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain) throws IOException, ServletException { - HttpServletRequest req = (HttpServletRequest) request; - + boolean successfulRegistration = false; + + HttpServletRequest req = (HttpServletRequest) request; Principal principal = req.getUserPrincipal(); // Please note that we could have also used a cookie to // retrieve the user name if (principal != null) { String username = principal.getName(); - registerUsername(username); - } else { - HttpSession session = req.getSession(); - String username = (String)session.getAttribute(userKey); - registerUsername(username); - } - + successfulRegistration = registerUsername(username); + } + try { chain.doFilter(request, response); } finally { - if (userRegistered) { - MDC.remove(userKey); + if (successfulRegistration) { + MDC.remove(USER_KEY); } } } @@ -587,21 +582,27 @@ public class UserServletFilter implements Filter { public void init(FilterConfig arg0) throws ServletException { } - private void registerUsername(String username) { + + /** + * Register the user in the MDC under USER_KEY. + * + * @param username + * @return true id the user can be successfully registered + */ + private boolean registerUsername(String username) { if (username != null && username.trim().length() > 0) { - MDC.put(userKey, username); - userRegistered = true; + MDC.put(USER_KEY, username); + return true; } + return false; } }</pre> When the filter's <code>doFilter()</code> method is called, it first looks for a <code>java.security.Principal</code> object in the request. This object contains the name of the currently - authenticated user. In case the user principal is not set, the - filter looks for a session attribute matching a given key (here - username). If a user information is found, it is - registered in the <code>MDC</code>. + authenticated user. If a user information is found, it is registered + in the <code>MDC</code>. Once the filter chain has completed, the filter removes the user diff --git a/logback-site/src/site/pages/news.html b/logback-site/src/site/pages/news.html index 8d5fb90..644d52a 100644 --- a/logback-site/src/site/pages/news.html +++ b/logback-site/src/site/pages/news.html @@ -131,6 +131,10 @@ reported by Tom SH Liu. + Fixed <a + href="http://jira.qos.ch/browse/LBSITE-36">LBSITE-36</a> reported + by John Jimenez. + <hr width="80%" align="center" />  ----------------------------------------------------------------------- Summary of changes: .../main/java/chapters/mdc/UserServletFilter.java | 51 +++++++------------ logback-site/src/site/pages/manual/mdc.html | 43 ++++++++-------- logback-site/src/site/pages/news.html | 4 ++ 3 files changed, 45 insertions(+), 53 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[JIRA] Created: (LBCORE-93) FlushingPolicy
by Ceki Gulcu (JIRA) 18 Mar '10

18 Mar '10

FlushingPolicy -------------- Key: LBCORE-93 URL: http://jira.qos.ch/browse/LBCORE-93 Project: logback-core Issue Type: New Feature Reporter: Ceki Gulcu Assignee: Logback dev list Let flushing be a settable policy of WriteAppender. Thus, the user would be able to set the FlushingPolicy of a WriterAppender or any derived class which would allow you to flush the underlying output stream according to any criteria available to the shouldFlush() method (see below), including time. Here is the relevant interface: interface FlushingPolicy { booelan shouldFlush(LoggingEvent e); } We could easily imagine a policy flushing on every warning or error in addition to special markers. For example, Marker FLUSH = MarkerFactory.getMarker("FLUSH"); logger.info(FLUSH, "finished serving request {}", request.getId()); -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 1

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. v0.9.18-93-g499abbb
by git-noreply＠pixie.qos.ch 18 Mar '10

18 Mar '10

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via 499abbba89771332844fa84262e77277f66e8932 (commit) from 32d669a3ab35c87a919ca47712eaef295360a46e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=499abbba89771332844fa842… http://github.com/ceki/logback/commit/499abbba89771332844fa84262e77277f66e8… commit 499abbba89771332844fa84262e77277f66e8932 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Thu Mar 18 18:27:08 2010 +0100 Making SiftingAppender relient againt zero nested appenders and more than one nested appender. diff --git a/logback-access/src/main/java/ch/qos/logback/access/sift/SiftingJoranConfigurator.java b/logback-access/src/main/java/ch/qos/logback/access/sift/SiftingJoranConfigurator.java index 0e0ca00..13d00cc 100644 --- a/logback-access/src/main/java/ch/qos/logback/access/sift/SiftingJoranConfigurator.java +++ b/logback-access/src/main/java/ch/qos/logback/access/sift/SiftingJoranConfigurator.java @@ -25,21 +25,22 @@ import ch.qos.logback.core.joran.spi.Pattern; import ch.qos.logback.core.joran.spi.RuleStore; import ch.qos.logback.core.sift.SiftingJoranConfiguratorBase; -public class SiftingJoranConfigurator extends SiftingJoranConfiguratorBase<AccessEvent> { +public class SiftingJoranConfigurator extends + SiftingJoranConfiguratorBase<AccessEvent> { String key; String value; - + SiftingJoranConfigurator(String key, String value) { this.key = key; this.value = value; } - + @Override protected Pattern initialPattern() { return new Pattern("configuration"); } - + @Override protected void addInstanceRules(RuleStore rs) { rs.addRule(new Pattern("configuration/appender"), new AppenderAction()); @@ -48,7 +49,8 @@ public class SiftingJoranConfigurator extends SiftingJoranConfiguratorBase<Acce @Override protected void buildInterpreter() { super.buildInterpreter(); - Map<String, Object> omap = interpreter.getInterpretationContext().getObjectMap(); + Map<String, Object> omap = interpreter.getInterpretationContext() + .getObjectMap(); omap.put(ActionConst.APPENDER_BAG, new HashMap()); omap.put(ActionConst.FILTER_CHAIN_BAG, new HashMap()); Map<String, String> propertiesMap = new HashMap<String, String>(); @@ -58,9 +60,14 @@ public class SiftingJoranConfigurator extends SiftingJoranConfiguratorBase<Acce @SuppressWarnings("unchecked") public Appender<AccessEvent> getAppender() { - Map<String, Object> omap = interpreter.getInterpretationContext().getObjectMap(); - HashMap map = (HashMap) omap.get(ActionConst.APPENDER_BAG); - Collection values = map.values(); + Map<String, Object> omap = interpreter.getInterpretationContext() + .getObjectMap(); + HashMap appenderMap = (HashMap) omap.get(ActionConst.APPENDER_BAG); + oneAndOnlyOneCheck(appenderMap); + Collection values = appenderMap.values(); + if(values.size() == 0) { + return null; + } return (Appender<AccessEvent>) values.iterator().next(); } } diff --git a/logback-classic/src/main/java/ch/qos/logback/classic/sift/SiftingJoranConfigurator.java b/logback-classic/src/main/java/ch/qos/logback/classic/sift/SiftingJoranConfigurator.java index 66309cb..d831f41 100644 --- a/logback-classic/src/main/java/ch/qos/logback/classic/sift/SiftingJoranConfigurator.java +++ b/logback-classic/src/main/java/ch/qos/logback/classic/sift/SiftingJoranConfigurator.java @@ -68,8 +68,12 @@ public class SiftingJoranConfigurator extends SiftingJoranConfiguratorBase<ILog @SuppressWarnings("unchecked") public Appender<ILoggingEvent> getAppender() { Map<String, Object> omap = interpreter.getInterpretationContext().getObjectMap(); - HashMap map = (HashMap) omap.get(ActionConst.APPENDER_BAG); - Collection values = map.values(); + HashMap appenderMap = (HashMap) omap.get(ActionConst.APPENDER_BAG); + oneAndOnlyOneCheck(appenderMap); + Collection values = appenderMap.values(); + if(values.size() == 0) { + return null; + } return (Appender<ILoggingEvent>) values.iterator().next(); } } diff --git a/logback-classic/src/test/input/joran/sift/multipleNesting.xml b/logback-classic/src/test/input/joran/sift/multipleNesting.xml new file mode 100644 index 0000000..2dccd19 --- /dev/null +++ b/logback-classic/src/test/input/joran/sift/multipleNesting.xml @@ -0,0 +1,24 @@ +<?xml version="1.0" encoding="UTF-8" ?> +<!DOCTYPE configuration> + +<configuration debug="true"> + + <appender name="SIFT" class="ch.qos.logback.classic.sift.SiftingAppender"> + + <discriminator> + <Key>userid</Key> + <defaultValue>smoke</defaultValue> + </discriminator> + <sift> + <appender name="a-${userid}" + class="ch.qos.logback.core.read.ListAppender" /> + <appender name="b-${userid}" + class="ch.qos.logback.core.read.ListAppender" /> + </sift> + </appender> + + <root level="DEBUG"> + <appender-ref ref="SIFT" /> + </root> + +</configuration> diff --git a/logback-classic/src/test/input/joran/sift/zeroNesting.xml b/logback-classic/src/test/input/joran/sift/zeroNesting.xml new file mode 100644 index 0000000..5194291 --- /dev/null +++ b/logback-classic/src/test/input/joran/sift/zeroNesting.xml @@ -0,0 +1,20 @@ +<?xml version="1.0" encoding="UTF-8" ?> +<!DOCTYPE configuration> + +<configuration debug="true"> + + <appender name="SIFT" class="ch.qos.logback.classic.sift.SiftingAppender"> + + <discriminator> + <Key>userid</Key> + <defaultValue>smoke</defaultValue> + </discriminator> + <sift> + </sift> + </appender> + + <root level="DEBUG"> + <appender-ref ref="SIFT" /> + </root> + +</configuration> diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/LoggerPerfTest.java b/logback-classic/src/test/java/ch/qos/logback/classic/LoggerPerfTest.java index 89608a3..c6723de 100644 --- a/logback-classic/src/test/java/ch/qos/logback/classic/LoggerPerfTest.java +++ b/logback-classic/src/test/java/ch/qos/logback/classic/LoggerPerfTest.java @@ -23,7 +23,7 @@ import ch.qos.logback.classic.spi.ILoggingEvent; import ch.qos.logback.classic.turbo.NOPTurboFilter; import ch.qos.logback.core.CoreConstants; import ch.qos.logback.core.UnsynchronizedAppenderBase; -import ch.qos.logback.core.appender.NOPAppender; +import ch.qos.logback.core.helpers.NOPAppender; import ch.qos.logback.core.testUtil.Env; public class LoggerPerfTest { diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/sift/SiftingAppenderTest.java b/logback-classic/src/test/java/ch/qos/logback/classic/sift/SiftingAppenderTest.java index b7ce5da..4bf89ac 100644 --- a/logback-classic/src/test/java/ch/qos/logback/classic/sift/SiftingAppenderTest.java +++ b/logback-classic/src/test/java/ch/qos/logback/classic/sift/SiftingAppenderTest.java @@ -16,6 +16,7 @@ package ch.qos.logback.classic.sift; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertNotNull; +import static org.junit.Assert.assertTrue; import java.util.List; @@ -29,9 +30,12 @@ import ch.qos.logback.classic.LoggerContext; import ch.qos.logback.classic.joran.JoranConfigurator; import ch.qos.logback.classic.spi.ILoggingEvent; import ch.qos.logback.classic.spi.LoggingEvent; +import ch.qos.logback.core.helpers.NOPAppender; import ch.qos.logback.core.joran.spi.JoranException; import ch.qos.logback.core.read.ListAppender; import ch.qos.logback.core.sift.AppenderTracker; +import ch.qos.logback.core.status.ErrorStatus; +import ch.qos.logback.core.status.StatusChecker; import ch.qos.logback.core.testUtil.StringListAppender; import ch.qos.logback.core.util.StatusPrinter; @@ -65,8 +69,6 @@ public class SiftingAppenderTest { SiftingAppender ha = (SiftingAppender) root.getAppender("SIFT"); ListAppender<ILoggingEvent> listAppender = (ListAppender<ILoggingEvent>) ha .getAppenderTracker().get("smoke", timestamp); - - StatusPrinter.print(loggerContext); assertNotNull(listAppender); List<ILoggingEvent> eventList = listAppender.list; assertEquals(1, listAppender.list.size()); @@ -74,6 +76,49 @@ public class SiftingAppenderTest { } @Test + public void zeroNesting() throws JoranException { + configure(PREFIX + "zeroNesting.xml"); + logger.debug("hello"); + logger.debug("hello"); + logger.debug("hello"); + logger.debug("hello"); + logger.debug("hello"); + + long timestamp = 0; + + SiftingAppender sa = (SiftingAppender) root.getAppender("SIFT"); + NOPAppender<ILoggingEvent> nopa = (NOPAppender<ILoggingEvent>) sa + .getAppenderTracker().get("smoke", timestamp); + StatusPrinter.printInCaseOfErrorsOrWarnings(loggerContext); + + assertNotNull(nopa); + StatusChecker sc = new StatusChecker(loggerContext); + assertTrue(sc.containsMatch(ErrorStatus.ERROR, "No nested appenders found")); + assertTrue(sc.containsMatch(ErrorStatus.ERROR, + "Failed to build an appender for discriminating value \\[smoke\\]")); + } + + @Test + public void multipleNesting() throws JoranException { + configure(PREFIX + "multipleNesting.xml"); + logger.debug("hello"); + logger.debug("hello"); + logger.debug("hello"); + + long timestamp = 0; + + SiftingAppender sa = (SiftingAppender) root.getAppender("SIFT"); + ListAppender<ILoggingEvent> listAppender = (ListAppender<ILoggingEvent>) sa + .getAppenderTracker().get("smoke", timestamp); + StatusPrinter.printInCaseOfErrorsOrWarnings(loggerContext); + + assertNotNull(listAppender); + StatusChecker sc = new StatusChecker(loggerContext); + assertTrue(sc.containsMatch(ErrorStatus.ERROR, + "Only and only one appender can be nested")); + } + + @Test public void defaultLayoutRule() throws JoranException { configure(PREFIX + "defaultLayoutRule.xml"); logger.debug("hello"); @@ -82,7 +127,6 @@ public class SiftingAppenderTest { StringListAppender<ILoggingEvent> listAppender = (StringListAppender<ILoggingEvent>) ha .getAppenderTracker().get("default", timestamp); - StatusPrinter.print(loggerContext); assertNotNull(listAppender); List<String> strList = listAppender.strList; assertEquals(1, strList.size()); @@ -99,8 +143,6 @@ public class SiftingAppenderTest { SiftingAppender ha = (SiftingAppender) root.getAppender("SIFT"); ListAppender<ILoggingEvent> listAppender = (ListAppender<ILoggingEvent>) ha .getAppenderTracker().get("a", timestamp); - StatusPrinter.print(loggerContext); - assertNotNull(listAppender); List<ILoggingEvent> eventList = listAppender.list; assertEquals(1, listAppender.list.size()); @@ -115,4 +157,5 @@ public class SiftingAppenderTest { assertEquals(1, ha.getAppenderTracker().keyList().size()); assertEquals("cycleDefault", ha.getAppenderTracker().keyList().get(0)); } + } diff --git a/logback-core/src/main/java/ch/qos/logback/core/CoreConstants.java b/logback-core/src/main/java/ch/qos/logback/core/CoreConstants.java index 637a1b4..699483f 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/CoreConstants.java +++ b/logback-core/src/main/java/ch/qos/logback/core/CoreConstants.java @@ -92,7 +92,7 @@ public class CoreConstants { public static long REFERENCE_BIPS = 9000; - // maximum error acoutn to report + // the max number of times an error should be reported static public final int MAX_ERROR_COUNT = 4; diff --git a/logback-core/src/test/java/ch/qos/logback/core/appender/NOPAppender.java b/logback-core/src/main/java/ch/qos/logback/core/helpers/NOPAppender.java similarity index 94% rename from logback-core/src/test/java/ch/qos/logback/core/appender/NOPAppender.java rename to logback-core/src/main/java/ch/qos/logback/core/helpers/NOPAppender.java index 52b4003..5fb5129 100644 --- a/logback-core/src/test/java/ch/qos/logback/core/appender/NOPAppender.java +++ b/logback-core/src/main/java/ch/qos/logback/core/helpers/NOPAppender.java @@ -11,7 +11,7 @@ * under the terms of the GNU Lesser General Public License version 2.1 * as published by the Free Software Foundation. */ -package ch.qos.logback.core.appender; +package ch.qos.logback.core.helpers; import ch.qos.logback.core.AppenderBase; diff --git a/logback-core/src/main/java/ch/qos/logback/core/joran/action/AppenderAction.java b/logback-core/src/main/java/ch/qos/logback/core/joran/action/AppenderAction.java index 7604a5f..5c7a6a4 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/joran/action/AppenderAction.java +++ b/logback-core/src/main/java/ch/qos/logback/core/joran/action/AppenderAction.java @@ -102,8 +102,6 @@ public class AppenderAction<E> extends Action { addWarn("The object at the of the stack is not the appender named [" + appender.getName() + "] pushed earlier."); } else { - addInfo("Popping appender named [" + appender.getName() - + "] from the object stack"); ec.popObject(); } } diff --git a/logback-core/src/main/java/ch/qos/logback/core/sift/SiftingAppenderBase.java b/logback-core/src/main/java/ch/qos/logback/core/sift/SiftingAppenderBase.java index dbfe217..c82ed9b 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/sift/SiftingAppenderBase.java +++ b/logback-core/src/main/java/ch/qos/logback/core/sift/SiftingAppenderBase.java @@ -14,7 +14,9 @@ package ch.qos.logback.core.sift; import ch.qos.logback.core.Appender; +import ch.qos.logback.core.CoreConstants; import ch.qos.logback.core.UnsynchronizedAppenderBase; +import ch.qos.logback.core.helpers.NOPAppender; import ch.qos.logback.core.joran.spi.JoranException; /** @@ -77,9 +79,11 @@ public abstract class SiftingAppenderBase<E> extends if (appender == null) { try { appender = appenderFactory.buildAppender(context, discriminatingValue); - if (appender != null) { - appenderTracker.put(discriminatingValue, appender, timestamp); + if (appender == null) { + appender = buildNOPAppender(discriminatingValue); } + appenderTracker.put(discriminatingValue, appender, timestamp); + } catch (JoranException e) { addError("Failed to build appender for [" + discriminatingValue + "]", e); @@ -97,6 +101,18 @@ public abstract class SiftingAppenderBase<E> extends public void setDiscriminator(Discriminator<E> discriminator) { this.discriminator = discriminator; } + + + int nopaWarningCount = 0; + + NOPAppender<E> buildNOPAppender(String discriminatingValue) { + NOPAppender<E> nopa = new NOPAppender<E>(); + if(nopaWarningCount < CoreConstants.MAX_ERROR_COUNT) { + nopaWarningCount++; + addError("Failed to build an appender for discriminating value ["+discriminatingValue+"]"); + } + return nopa; + } // sometime one needs to close a nested appender immediately // for example when executing a command which has its own nested appender diff --git a/logback-core/src/main/java/ch/qos/logback/core/sift/SiftingJoranConfiguratorBase.java b/logback-core/src/main/java/ch/qos/logback/core/sift/SiftingJoranConfiguratorBase.java index 0524f33..7d5c96e 100644 --- a/logback-core/src/main/java/ch/qos/logback/core/sift/SiftingJoranConfiguratorBase.java +++ b/logback-core/src/main/java/ch/qos/logback/core/sift/SiftingJoranConfiguratorBase.java @@ -13,24 +13,50 @@ */ package ch.qos.logback.core.sift; +import java.util.Map; + import ch.qos.logback.core.Appender; +import ch.qos.logback.core.CoreConstants; import ch.qos.logback.core.joran.GenericConfigurator; import ch.qos.logback.core.joran.action.NestedBasicPropertyIA; import ch.qos.logback.core.joran.action.NestedComplexPropertyIA; import ch.qos.logback.core.joran.spi.Interpreter; -public abstract class SiftingJoranConfiguratorBase<E> extends GenericConfigurator { +public abstract class SiftingJoranConfiguratorBase<E> extends + GenericConfigurator { + + final static String ONE_AND_ONLY_ONE_URL = CoreConstants.CODES_URL + + "#1andOnly1"; @Override protected void addImplicitRules(Interpreter interpreter) { NestedComplexPropertyIA nestedComplexIA = new NestedComplexPropertyIA(); nestedComplexIA.setContext(context); interpreter.addImplicitAction(nestedComplexIA); - + NestedBasicPropertyIA nestedSimpleIA = new NestedBasicPropertyIA(); nestedSimpleIA.setContext(context); interpreter.addImplicitAction(nestedSimpleIA); } - + abstract public Appender<E> getAppender(); + + int errorEmmissionCount = 0; + + protected void oneAndOnlyOneCheck(Map appenderMap) { + String errMsg = null; + if (appenderMap.size() == 0) { + errorEmmissionCount++; + errMsg = "No nested appenders found within the <sift> element in SiftingAppender."; + } else if (appenderMap.size() > 1) { + errorEmmissionCount++; + errMsg = "Only and only one appender can be nested the <sift> element in SiftingAppender. See also " + + ONE_AND_ONLY_ONE_URL; + } + + if (errMsg != null && errorEmmissionCount < CoreConstants.MAX_ERROR_COUNT) { + addError(errMsg); + } + + } } diff --git a/logback-core/src/test/java/ch/qos/logback/core/sift/Simulator.java b/logback-core/src/test/java/ch/qos/logback/core/sift/Simulator.java index db91d02..40bdf11 100644 --- a/logback-core/src/test/java/ch/qos/logback/core/sift/Simulator.java +++ b/logback-core/src/test/java/ch/qos/logback/core/sift/Simulator.java @@ -20,7 +20,7 @@ import java.util.Map; import java.util.Random; import ch.qos.logback.core.Appender; -import ch.qos.logback.core.appender.NOPAppender; +import ch.qos.logback.core.helpers.NOPAppender; import ch.qos.logback.core.sift.tracker.AppenderTrackerTImpl; import ch.qos.logback.core.sift.tracker.SimulationEvent; import ch.qos.logback.core.sift.tracker.SimulationEvent.SimEventType; diff --git a/logback-core/src/test/java/ch/qos/logback/core/spi/AppenderAttachableImplTest.java b/logback-core/src/test/java/ch/qos/logback/core/spi/AppenderAttachableImplTest.java index 300fedd..05b3a4d 100644 --- a/logback-core/src/test/java/ch/qos/logback/core/spi/AppenderAttachableImplTest.java +++ b/logback-core/src/test/java/ch/qos/logback/core/spi/AppenderAttachableImplTest.java @@ -26,7 +26,7 @@ import org.junit.Before; import org.junit.Test; import ch.qos.logback.core.Appender; -import ch.qos.logback.core.appender.NOPAppender; +import ch.qos.logback.core.helpers.NOPAppender; /** * This test case verifies all the methods of AppenderAttableImpl work properly. diff --git a/logback-site/src/site/pages/codes.html b/logback-site/src/site/pages/codes.html index 93c98de..3ab510d 100644 --- a/logback-site/src/site/pages/codes.html +++ b/logback-site/src/site/pages/codes.html @@ -354,6 +354,7 @@ <hr /> +  <a name="syslog_layout" href="#syslog_layout"> SyslogAppender does not admit a layout.</a> @@ -371,9 +372,19 @@ <hr/> + +  + <a name="1andOnly1" href="#1andOnly1">Only and only one appender + can be nested the <sift> element in + <code>SiftingAppender</code>.</a> + + SiftingAppender admits one and only one nested appender. + + + <hr/> - <script src="templates/footer.js" type="text/javascript"></script> + <script src="templates/footer.js" type="text/javascript"></script> </div> </body> </html> ----------------------------------------------------------------------- Summary of changes: .../access/sift/SiftingJoranConfigurator.java | 23 ++++++--- .../classic/sift/SiftingJoranConfigurator.java | 8 ++- .../joran/sift/{smoke.xml => multipleNesting.xml} | 4 +- .../joran/sift/{smoke.xml => zeroNesting.xml} | 4 +- .../ch/qos/logback/classic/LoggerPerfTest.java | 2 +- .../logback/classic/sift/SiftingAppenderTest.java | 53 ++++++++++++++++++-- .../java/ch/qos/logback/core/CoreConstants.java | 2 +- .../ch/qos/logback/core/helpers}/NOPAppender.java | 2 +- .../logback/core/joran/action/AppenderAction.java | 2 - .../qos/logback/core/sift/SiftingAppenderBase.java | 20 +++++++- .../core/sift/SiftingJoranConfiguratorBase.java | 32 +++++++++++- .../java/ch/qos/logback/core/sift/Simulator.java | 2 +- .../core/spi/AppenderAttachableImplTest.java | 2 +- logback-site/src/site/pages/codes.html | 13 +++++- 14 files changed, 137 insertions(+), 32 deletions(-) copy logback-classic/src/test/input/joran/sift/{smoke.xml => multipleNesting.xml} (78%) copy logback-classic/src/test/input/joran/sift/{smoke.xml => zeroNesting.xml} (78%) rename logback-core/src/{test/java/ch/qos/logback/core/appender => main/java/ch/qos/logback/core/helpers}/NOPAppender.java (94%) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[JIRA] Created: (LBCORE-139) SiftingAppender should compalin if more than one appender is nested within it
by Ceki Gulcu (JIRA) 18 Mar '10

18 Mar '10

SiftingAppender should compalin if more than one appender is nested within it ----------------------------------------------------------------------------- Key: LBCORE-139 URL: http://jira.qos.ch/browse/LBCORE-139 Project: logback-core Issue Type: Bug Affects Versions: 0.9.18 Reporter: Ceki Gulcu Assignee: Logback dev list Priority: Critical SiftingAppender should complain if more than one appender is nested within it. See the getAppender() method SiftingJoranConfigurator for a possible solution. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 1

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. v0.9.18-92-g32d669a
by git-noreply＠pixie.qos.ch 18 Mar '10

18 Mar '10

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via 32d669a3ab35c87a919ca47712eaef295360a46e (commit) from e540ea746cb1cf748343bdd8c3ce3bd364f50ff8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=32d669a3ab35c87a919ca477… http://github.com/ceki/logback/commit/32d669a3ab35c87a919ca47712eaef295360a… commit 32d669a3ab35c87a919ca47712eaef295360a46e Author: Ceki Gulcu <ceki(a)qos.ch> Date: Thu Mar 18 16:10:52 2010 +0100 - updated the docs diff --git a/logback-site/src/site/pages/manual/mdc.html b/logback-site/src/site/pages/manual/mdc.html index 143b4ff..43e0c1a 100644 --- a/logback-site/src/site/pages/manual/mdc.html +++ b/logback-site/src/site/pages/manual/mdc.html @@ -652,15 +652,23 @@ public class UserServletFilter implements Filter { </tr> <tr class="alt"> - <td>request.remoteHost</td> + <td><code>req.remoteHost</code></td> <td>as returned by the <a - href="http://java.sun.com/j2ee/sdk_1.3/techdocs/api/javax/servlet/ServletRequest.…">getRemoteHost90</a> + href="http://java.sun.com/j2ee/sdk_1.3/techdocs/api/javax/servlet/ServletRequest.…">getRemoteHost()</a> method </td> </tr> - <tr> - <td>request.requestURI</td> + <tr > + <td><code>req.xForwardedFor</code></td> + <td>value of the <a + href="http://en.wikipedia.org/wiki/X-Forwarded-For">"X-Forwarded-For"</a> + header + </td> + </tr> + + <tr class="alt"> + <td><code>req.requestURI</code></td> <td> as returned by <a href="http://java.sun.com/j2ee/sdk_1.3/techdocs/api/javax/servlet/http/HttpServle…">getRequestURI()</a> @@ -668,8 +676,8 @@ public class UserServletFilter implements Filter { </td> </tr> - <tr class="alt"> - <td>request.userAgent</td> + <tr > + <td><code>req.userAgent</code></td> <td>value of the "User-Agent" header </td> </tr> @@ -701,9 +709,16 @@ public class UserServletFilter implements Filter { Once the filter is installed, values corresponding to each MDC key will be output by the %X <a - href="layouts.html#conversionWord">conversion word</a>. + href="layouts.html#conversionWord">conversion word</a> acoording to + the key passes as first option. For example, to print the remote + host followed by the request URI on one line, the date followed by + the message on the next, you would set <code>PatternLayout</code>'s + pattern to: + + %X{req.remoteHost} %X{req.requestURI}%n%d - %m%n + <script src="../templates/footer.js" type="text/javascript"></script> </div> </body> ----------------------------------------------------------------------- Summary of changes: logback-site/src/site/pages/manual/mdc.html | 29 ++++++++++++++++++++------ 1 files changed, 22 insertions(+), 7 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. v0.9.18-91-ge540ea7
by git-noreply＠pixie.qos.ch 18 Mar '10

18 Mar '10

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via e540ea746cb1cf748343bdd8c3ce3bd364f50ff8 (commit) from 114e8b1da6d072b06900f9015c8e8db0c5f8b273 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=e540ea746cb1cf748343bdd8… http://github.com/ceki/logback/commit/e540ea746cb1cf748343bdd8c3ce3bd364f50… commit e540ea746cb1cf748343bdd8c3ce3bd364f50ff8 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Thu Mar 18 15:35:49 2010 +0100 - moved ContextSelectorStaticBinder from src/test to src/main. D'oh! - MDCInsertingServletFilter now inserts xForwardedFor entry diff --git a/logback-classic/pom.xml b/logback-classic/pom.xml index ec367ab..bdb2ec6 100644 --- a/logback-classic/pom.xml +++ b/logback-classic/pom.xml @@ -270,13 +270,15 @@ org.slf4j.test_osgi config files). They won't be found by Bnd's analysis of java code. --> +  <Import-Package> sun.reflect;resolution:=optional, javax.*;resolution:=optional, org.xml.*;resolution:=optional, ch.qos.logback.core.rolling, ch.qos.logback.core.rolling.helper, - ch.qos.logback.classic.util, * </Import-Package> diff --git a/logback-classic/src/main/java/ch/qos/logback/classic/ClassicConstants.java b/logback-classic/src/main/java/ch/qos/logback/classic/ClassicConstants.java index 8a19e96..492c8e4 100644 --- a/logback-classic/src/main/java/ch/qos/logback/classic/ClassicConstants.java +++ b/logback-classic/src/main/java/ch/qos/logback/classic/ClassicConstants.java @@ -33,8 +33,9 @@ public class ClassicConstants { */ public static final int DEFAULT_MAX_CALLEDER_DATA_DEPTH = 8; - public final static String REQUEST_REMOTE_HOST_MDC_KEY = "request.remoteHost"; - public final static String REQUEST_USER_AGENT_MDC_KEY = "request.userAgent"; - public final static String REQUEST_REQUST_URI = "request.requestURI"; + public final static String REQUEST_REMOTE_HOST_MDC_KEY = "req.remoteHost"; + public final static String REQUEST_USER_AGENT_MDC_KEY = "req.userAgent"; + public final static String REQUEST_REQUST_URI = "req.requestURI"; + public final static String REQUEST_X_FORWARDED_FOR = "req.xForwardedFor"; } diff --git a/logback-classic/src/main/java/ch/qos/logback/classic/helpers/MDCInsertingServletFilter.java b/logback-classic/src/main/java/ch/qos/logback/classic/helpers/MDCInsertingServletFilter.java index 250c5c4..d9f25d6 100644 --- a/logback-classic/src/main/java/ch/qos/logback/classic/helpers/MDCInsertingServletFilter.java +++ b/logback-classic/src/main/java/ch/qos/logback/classic/helpers/MDCInsertingServletFilter.java @@ -64,6 +64,8 @@ public class MDCInsertingServletFilter implements Filter { .getRequestURI()); MDC.put(ClassicConstants.REQUEST_USER_AGENT_MDC_KEY, httpServletRequest .getHeader("User-Agent")); + MDC.put(ClassicConstants.REQUEST_X_FORWARDED_FOR, httpServletRequest + .getHeader("X-Forwarded-For")); } } diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/util/ContextSelectorStaticBinder.java b/logback-classic/src/main/java/ch/qos/logback/classic/util/ContextSelectorStaticBinder.java similarity index 100% rename from logback-classic/src/test/java/ch/qos/logback/classic/util/ContextSelectorStaticBinder.java rename to logback-classic/src/main/java/ch/qos/logback/classic/util/ContextSelectorStaticBinder.java diff --git a/logback-site/src/site/pages/news.html b/logback-site/src/site/pages/news.html index b6b13a3..8d5fb90 100644 --- a/logback-site/src/site/pages/news.html +++ b/logback-site/src/site/pages/news.html @@ -68,6 +68,13 @@ after the connection to the server is re-established. + The packages under <code>ch.qos.logback.classic</code> + namespace no longer depend on <code>org.slf4j.impl</code>. This + fixes <a + href="http://jira.qos.ch/browse/LBCLASSIC-184">LBCLASSIC-184</a> + reported by Gunnar Wagenknecht. + + Fixed <a href="http://jira.qos.ch/browse/LBCLASSIC-193">LBCLASSIC-193</a>. <code>SyslogAppender</code> will no longer shutdown when messages ----------------------------------------------------------------------- Summary of changes: logback-classic/pom.xml | 4 +++- .../ch/qos/logback/classic/ClassicConstants.java | 7 ++++--- .../classic/helpers/MDCInsertingServletFilter.java | 2 ++ .../classic/util/ContextSelectorStaticBinder.java | 0 logback-site/src/site/pages/news.html | 7 +++++++ 5 files changed, 16 insertions(+), 4 deletions(-) rename logback-classic/src/{test => main}/java/ch/qos/logback/classic/util/ContextSelectorStaticBinder.java (100%) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0