- logback-dev - mailman3.qos.ch

[JIRA] Created: (LBCLASSIC-173) [Documentation] Errors in EvaluatorFilter documentation
by Christoph Jaehnigen (JIRA) 14 Dec '09

14 Dec '09

[Documentation] Errors in EvaluatorFilter documentation ------------------------------------------------------- Key: LBCLASSIC-173 URL: http://jira.qos.ch/browse/LBCLASSIC-173 Project: logback-classic Issue Type: Bug Components: Other Affects Versions: 0.9.18 Reporter: Christoph Jaehnigen Assignee: Logback dev list Priority: Minor There are some errors in the EvaluatorFilter documentation at http://logback.qos.ch/manual/filters.html#evalutatorFilter : 1. The correct filter class is "ch.qos.logback.CLASSIC.filter.EvaluatorFilter" 2. In the describing text to the example filter configuration the values of OnMatch and OnMismatch are mixed up. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[GIT] Logback: the generic, reliable, fast and flexible logging framework. branch, master, updated. v0.9.18-7-ge4839dd
by git-noreply＠pixie.qos.ch 14 Dec '09

14 Dec '09

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Logback: the generic, reliable, fast and flexible logging framework.". The branch, master has been updated via e4839ddb7eda16fa1565afbc30b5b3698f89eb0b (commit) via 20c091ca36000c9fe74a72e550099664f1c4aea6 (commit) from 05db4942ca70e42ea3ad6d6c8c84a47143e39a3a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=e4839ddb7eda16fa1565afbc… http://github.com/ceki/logback/commit/e4839ddb7eda16fa1565afbc30b5b3698f89e… commit e4839ddb7eda16fa1565afbc30b5b3698f89eb0b Merge: 20c091c 05db494 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Mon Dec 14 11:30:30 2009 +0100 Merge branch 'master' of git@git.qos.ch:logback http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=20c091ca36000c9fe74a72e5… http://github.com/ceki/logback/commit/20c091ca36000c9fe74a72e550099664f1c4a… commit 20c091ca36000c9fe74a72e550099664f1c4aea6 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Mon Dec 14 11:30:10 2009 +0100 making eclipse happy diff --git a/logback-classic/src/test/java/org/slf4j/test_osgi/CheckingBundleListener.java b/logback-classic/src/test/java/org/slf4j/test_osgi/CheckingBundleListener.java index 3641a2a..b4f0ac1 100644 --- a/logback-classic/src/test/java/org/slf4j/test_osgi/CheckingBundleListener.java +++ b/logback-classic/src/test/java/org/slf4j/test_osgi/CheckingBundleListener.java @@ -11,6 +11,7 @@ public class CheckingBundleListener implements BundleListener { List eventList = new ArrayList(); + @SuppressWarnings("unchecked") public void bundleChanged(BundleEvent be) { eventList.add(be); } diff --git a/logback-classic/src/test/java/org/slf4j/test_osgi/FelixHost.java b/logback-classic/src/test/java/org/slf4j/test_osgi/FelixHost.java index 62058f5..158c8f5 100644 --- a/logback-classic/src/test/java/org/slf4j/test_osgi/FelixHost.java +++ b/logback-classic/src/test/java/org/slf4j/test_osgi/FelixHost.java @@ -56,6 +56,7 @@ public class FelixHost { this.myBundleListener = myBundleListener; } + @SuppressWarnings("unchecked") public void doLaunch() { // Create a case-insensitive configuration property map. Map configMap = new StringMap(false); diff --git a/logback-classic/src/test/java/org/slf4j/test_osgi/FrameworkErrorListener.java b/logback-classic/src/test/java/org/slf4j/test_osgi/FrameworkErrorListener.java index 118ac8d..fc50f11 100644 --- a/logback-classic/src/test/java/org/slf4j/test_osgi/FrameworkErrorListener.java +++ b/logback-classic/src/test/java/org/slf4j/test_osgi/FrameworkErrorListener.java @@ -31,10 +31,10 @@ public class FrameworkErrorListener implements FrameworkListener { public List errorList = new ArrayList(); + @SuppressWarnings("unchecked") public void frameworkEvent(FrameworkEvent fe) { if (fe.getType() == FrameworkEvent.ERROR) { errorList.add(fe); - } } ----------------------------------------------------------------------- Summary of changes: .../slf4j/test_osgi/CheckingBundleListener.java | 1 + .../test/java/org/slf4j/test_osgi/FelixHost.java | 1 + .../slf4j/test_osgi/FrameworkErrorListener.java | 2 +- 3 files changed, 3 insertions(+), 1 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

branch, master, updated. v0.9.18-5-g05db494
by git-noreply＠pixie.qos.ch 07 Dec '09

07 Dec '09

The branch, master has been updated via 05db4942ca70e42ea3ad6d6c8c84a47143e39a3a (commit) from 6b87197e32713959bdebd4f315466e9466fd1ace (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=05db4942ca70e42ea3ad6d6c… http://github.com/ceki/logback/commit/05db4942ca70e42ea3ad6d6c8c84a47143e39… commit 05db4942ca70e42ea3ad6d6c8c84a47143e39a3a Author: Ceki Gulcu <ceki(a)rhino.localdomain> Date: Sun Dec 6 19:51:44 2009 -0500 print info on test start and test stop diff --git a/logback-classic/src/test/input/turbo/scan 1.xml b/logback-classic/src/test/input/turbo/scan 1.xml index 39878d3..58ee0c7 100644 --- a/logback-classic/src/test/input/turbo/scan 1.xml +++ b/logback-classic/src/test/input/turbo/scan 1.xml @@ -3,8 +3,7 @@ <configuration scan="true" scanPeriod="50 millisecond"> - <root level="ERROR"> - </root> + <root level="ERROR"/> </configuration> \ No newline at end of file diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/turbo/ReconfigureOnChangeTest.java b/logback-classic/src/test/java/ch/qos/logback/classic/turbo/ReconfigureOnChangeTest.java index b3a80df..9b56d6f 100644 --- a/logback-classic/src/test/java/ch/qos/logback/classic/turbo/ReconfigureOnChangeTest.java +++ b/logback-classic/src/test/java/ch/qos/logback/classic/turbo/ReconfigureOnChangeTest.java @@ -21,6 +21,7 @@ import java.io.IOException; import java.net.MalformedURLException; import java.net.URL; +import org.junit.After; import org.junit.Before; import org.junit.Test; import org.slf4j.helpers.BogoPerf; @@ -67,6 +68,7 @@ public class ReconfigureOnChangeTest { @Before public void setUp() { + System.out.println("======== TEST START"); // take into account propagation latency occurs on Linux or Mac if (Env.isLinux() || Env.isMac()) { sleepBetweenUpdates = 950; @@ -77,6 +79,10 @@ public class ReconfigureOnChangeTest { harness = new MultiThreadedHarness(totalTestDuration); } + @After + public void tearDown() { + System.out.println("======= TEST STOP"); + } void configure(File file) throws JoranException { JoranConfigurator jc = new JoranConfigurator(); jc.setContext(loggerContext); @@ -105,6 +111,7 @@ public class ReconfigureOnChangeTest { // Tests whether ConfigurationAction is installing ReconfigureOnChangeFilter @Test public void scan1() throws JoranException, IOException, InterruptedException { + System.out.println("***SCAN1"); File file = new File(SCAN1_FILE_AS_STR); configure(file); RunnableWithCounterAndDone[] runnableArray = buildRunnableArray(file); ----------------------------------------------------------------------- Summary of changes: logback-classic/src/test/input/turbo/scan 1.xml | 3 +-- .../classic/turbo/ReconfigureOnChangeTest.java | 7 +++++++ 2 files changed, 8 insertions(+), 2 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

branch, master, updated. v0.9.18-4-g6b87197
by git-noreply＠pixie.qos.ch 07 Dec '09

07 Dec '09

The branch, master has been updated via 6b87197e32713959bdebd4f315466e9466fd1ace (commit) from 859774c1848fe2f755efd12776a1ce2a05aa8c5f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=6b87197e32713959bdebd4f3… http://github.com/ceki/logback/commit/6b87197e32713959bdebd4f315466e9466fd1… commit 6b87197e32713959bdebd4f315466e9466fd1ace Author: Ceki Gulcu <ceki(a)rhino.localdomain> Date: Sun Dec 6 19:29:19 2009 -0500 - Make ReconfigureOnChangeTest pass on Mac by taking into account the longer latency - Increase latency from 850ms to 950ms (this makes the tests pass quite consistently on Linux) diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/turbo/ReconfigureOnChangeTest.java b/logback-classic/src/test/java/ch/qos/logback/classic/turbo/ReconfigureOnChangeTest.java index cff1fff..b3a80df 100644 --- a/logback-classic/src/test/java/ch/qos/logback/classic/turbo/ReconfigureOnChangeTest.java +++ b/logback-classic/src/test/java/ch/qos/logback/classic/turbo/ReconfigureOnChangeTest.java @@ -67,9 +67,9 @@ public class ReconfigureOnChangeTest { @Before public void setUp() { - // take into account propagation latency occurs on Linux - if (Env.isLinux()) { - sleepBetweenUpdates = 850; + // take into account propagation latency occurs on Linux or Mac + if (Env.isLinux() || Env.isMac()) { + sleepBetweenUpdates = 950; totalTestDuration = sleepBetweenUpdates * 5; } else { totalTestDuration = sleepBetweenUpdates * 10; diff --git a/logback-core/src/test/java/ch/qos/logback/core/testUtil/Env.java b/logback-core/src/test/java/ch/qos/logback/core/testUtil/Env.java index 00bccb9..bc7f55e 100644 --- a/logback-core/src/test/java/ch/qos/logback/core/testUtil/Env.java +++ b/logback-core/src/test/java/ch/qos/logback/core/testUtil/Env.java @@ -19,6 +19,10 @@ public class Env { return System.getProperty("os.name").indexOf("Windows") != -1; } + static public boolean isMac() { + return System.getProperty("os.name").indexOf("Mac") != -1; + } + static public boolean isLinux() { return System.getProperty("os.name").indexOf("Linux") != -1; } diff --git a/logback-examples/.gitignore b/logback-examples/.gitignore new file mode 100644 index 0000000..f1ff06d --- /dev/null +++ b/logback-examples/.gitignore @@ -0,0 +1 @@ +lib/ \ No newline at end of file ----------------------------------------------------------------------- Summary of changes: .../classic/turbo/ReconfigureOnChangeTest.java | 6 +++--- .../java/ch/qos/logback/core/testUtil/Env.java | 4 ++++ logback-examples/.gitignore | 1 + 3 files changed, 8 insertions(+), 3 deletions(-) create mode 100644 logback-examples/.gitignore hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

branch, master, updated. v0.9.18-3-g859774c
by git-noreply＠pixie.qos.ch 07 Dec '09

07 Dec '09

The branch, master has been updated via 859774c1848fe2f755efd12776a1ce2a05aa8c5f (commit) from ea2ed26c5255ae70a844a39793b127963bf14ea7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=859774c1848fe2f755efd127… http://github.com/ceki/logback/commit/859774c1848fe2f755efd12776a1ce2a05aa8… commit 859774c1848fe2f755efd12776a1ce2a05aa8c5f Author: Ceki Gulcu <ceki(a)qos.ch> Date: Mon Dec 7 01:12:43 2009 +0100 minor cosmetic changes diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/turbo/ReconfigureOnChangeTest.java b/logback-classic/src/test/java/ch/qos/logback/classic/turbo/ReconfigureOnChangeTest.java index 6c21e35..cff1fff 100644 --- a/logback-classic/src/test/java/ch/qos/logback/classic/turbo/ReconfigureOnChangeTest.java +++ b/logback-classic/src/test/java/ch/qos/logback/classic/turbo/ReconfigureOnChangeTest.java @@ -133,7 +133,7 @@ public class ReconfigureOnChangeTest { verify(expectedRreconfigurations); } - void verify(long expectedRreconfigurations) { + void verify(long expectedReconfigurations) { StatusChecker checker = new StatusChecker(loggerContext); StatusPrinter.print(loggerContext); assertTrue(checker.isErrorFree()); @@ -141,12 +141,12 @@ public class ReconfigureOnChangeTest { .matchCount("Resetting and reconfiguring context"); // the number of effective resets must be equal or less than // expectedRreconfigurations - assertTrue(effectiveResets <= expectedRreconfigurations); + assertTrue(effectiveResets <= expectedReconfigurations); // however, there should be some effective resets String failMsg = "effective=" + effectiveResets + ", expected=" - + expectedRreconfigurations; + + expectedReconfigurations; assertTrue(failMsg, - (effectiveResets * 1.3) >= (expectedRreconfigurations * 1.0)); + (effectiveResets * 1.3) >= (expectedReconfigurations * 1.0)); } ReconfigureOnChangeFilter initROCF() throws MalformedURLException { ----------------------------------------------------------------------- Summary of changes: .../classic/turbo/ReconfigureOnChangeTest.java | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

build failure.
by Ralph Goers 07 Dec '09

07 Dec '09

I am trying to merge the changes in your fork to mine but the build is failing in logback-classic. I have changed slf4j's version to 1.5.11-SNAPSHOT in my fork. As a consequence the osgi build step is failing due to <macrodef name="prepareOSGiHarness"> <attribute name="binding"/> <sequential> <delete> <fileset dir="${bundlesDir}" includes="*.jar"/> </delete> <copy file="${iBundleJar}" todir="${bundlesDir}"/> <copy file="../logback-examples/lib/slf4j-api-${slf4j.version}.jar" todir="${bundlesDir}"/> <copy file="../logback-core/target/logback-core-${currentVersion}.jar" todir="${bundlesDir}"/> <copy file="target/logback-classic-${currentVersion}.jar" todir="${bundlesDir}"/> <echo>value of t = @{t}</echo> </sequential> </macrodef> It is trying to copy slf4j-api from logback-examples/lib, but maven hasn't yet run the build for logback-examples so the jar hasn't been copied from the local repository. However, the jar was copied to logback-classic/lib. Changing osgi-build.xml to refer to that causes the build to succeed. However, I should point out that it is poor practice to modify any part of a project outside of the target directory during a build. It would be better if the files were copied to target/test-lib or a something similar. Ralph

2 1

branch, master, updated. v0.9.18-2-gea2ed26
by git-noreply＠pixie.qos.ch 07 Dec '09

07 Dec '09

The branch, master has been updated via ea2ed26c5255ae70a844a39793b127963bf14ea7 (commit) from df2d1961fd5fbf4169057c0c433934616445d9bc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://git.qos.ch/gitweb/?p=logback.git;a=commit;h=ea2ed26c5255ae70a844a397… http://github.com/ceki/logback/commit/ea2ed26c5255ae70a844a39793b127963bf14… commit ea2ed26c5255ae70a844a39793b127963bf14ea7 Author: Ceki Gulcu <ceki(a)qos.ch> Date: Mon Dec 7 00:58:32 2009 +0100 - have osgi-build.xml refer to the lib/ folder within logback-classic instead of logback-examples diff --git a/logback-classic/osgi-build.xml b/logback-classic/osgi-build.xml index 0d0e898..0e56c0b 100644 --- a/logback-classic/osgi-build.xml +++ b/logback-classic/osgi-build.xml @@ -59,7 +59,7 @@ <fileset dir="${bundlesDir}" includes="*.jar"/> </delete> <copy file="${iBundleJar}" todir="${bundlesDir}"/> - <copy file="../logback-examples/lib/slf4j-api-${slf4j.version}.jar" todir="${bundlesDir}"/> + <copy file="lib/slf4j-api-${slf4j.version}.jar" todir="${bundlesDir}"/> <copy file="../logback-core/target/logback-core-${currentVersion}.jar" todir="${bundlesDir}"/> <copy file="target/logback-classic-${currentVersion}.jar" todir="${bundlesDir}"/> <echo>value of t = @{t}</echo> ----------------------------------------------------------------------- Summary of changes: logback-classic/osgi-build.xml | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) hooks/post-receive -- Logback: the generic, reliable, fast and flexible logging framework.

1 0

ReconfigureOnChangeTest
by Ralph Goers 06 Dec '09

06 Dec '09

This test seems to fail consistently on my Mac. I suspect it is because the file timestamp on some operating systems is only granular to the second and the default interval between updates is 110 milliseconds which should result in 1 actual reconfiguration out of 10 iterations. It appears the test expects about 77% of the iterations to result in a reconfiguration so this is bound to fail. I changed the code to check for running on a Mac - @Before public void setUp() { // take into account propagation latency occurs on Linux if (Env.isLinux() || Env.isMac()) { sleepBetweenUpdates = 850; totalTestDuration = sleepBetweenUpdates * 5; } else { totalTestDuration = sleepBetweenUpdates * 10; } harness = new MultiThreadedHarness(totalTestDuration); } but this still intermittently fails since it is easily possible to get a ratio of less that 77% with this interval. Note that with this combination the best that can be hoped for is that 4 out of 5 updates per thread will cause a reconfiguration, which with 5 threads is 20 out of 25 (80%). However, if it can be arranged that either a single iteration is delayed just a bit so that only 3 out of 5 updates result in a reconfiguration then the result would be 19 out of 25 or 76% which would result in a test failure. I am sure there are other ways similar results could occur, but the bottom line is that this test needs a bit more breathing room. Ralph

1 1

[JIRA] Created: (LBCORE-127) Logback auto config closes the jar file previously opened in user code
by tomliliu (JIRA) 05 Dec '09

05 Dec '09

Logback auto config closes the jar file previously opened in user code ---------------------------------------------------------------------- Key: LBCORE-127 URL: http://jira.qos.ch/browse/LBCORE-127 Project: logback-core Issue Type: Bug Components: Joran Affects Versions: 0.9.17 Reporter: tomliliu Assignee: Logback dev list User code opens an input stream from a jar file first. Then logback auto config loads the configuration file from the same jar. User code will get the following exception when read the input stream later. {code title="Stack Trace"} java.util.zip.ZipException: ZipFile closed at java.util.zip.ZipFile.ensureOpenOrZipException(ZipFile.java:413) at java.util.zip.ZipFile.access$1100(ZipFile.java:29) at java.util.zip.ZipFile$ZipFileInputStream.read(ZipFile.java:445) at java.io.FilterInputStream.read(FilterInputStream.java:116) at sun.nio.cs.StreamDecoder.readBytes(StreamDecoder.java:264) at sun.nio.cs.StreamDecoder.implRead(StreamDecoder.java:306) at sun.nio.cs.StreamDecoder.read(StreamDecoder.java:158) at java.io.InputStreamReader.read(InputStreamReader.java:167) at java.io.BufferedReader.fill(BufferedReader.java:136) at java.io.BufferedReader.readLine(BufferedReader.java:299) at java.io.BufferedReader.readLine(BufferedReader.java:362) {code} {code title="Reproduce"} InputStream resourceAsStream = Thread.currentThread().getContextClassLoader().getResourceAsStream(logLocation); BufferedReader reader = new BufferedReader(new InputStreamReader(resourceAsStream)); final Logger logger = LoggerFactory.getLogger(LogbackBugReproduce.class); logger.debug(reader.readLine()); {code} It looks like in ch.qos.logback.core.joran.GenericConfigurator.doConfigure(URL url) method: urlConnection.setDefaultUseCaches(false); InputStream in = urlConnection.getInputStream(); doConfigure(in); in.close(); The input stream is associated with the same zip file instance of the users. Then close the input stream will close the zip file that user currently is using. After changing it to: urlConnection.setUseCaches(false); InputStream in = urlConnection.getInputStream(); doConfigure(in); in.close(); The input stream is associated with a different zip file instance. Then close the input stream will not affect the zip file used by the user code. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 9

[JIRA] Created: (LBSITE-35) http://logback.qos.ch/manual/appenders.html: MDCBasedDiscriminator link doesn't work
by Valery Shorin (JIRA) 04 Dec '09

04 Dec '09

http://logback.qos.ch/manual/appenders.html: MDCBasedDiscriminator link doesn't work ------------------------------------------------------------------------------------- Key: LBSITE-35 URL: http://jira.qos.ch/browse/LBSITE-35 Project: logback-site Issue Type: Bug Components: Documentation Affects Versions: 0.9.18 Reporter: Valery Shorin Assignee: Logback dev list Priority: Minor http://logback.qos.ch/manual/appenders.html: MDCBasedDiscriminator link doesn't work: http://logback.qos.ch/manual/xref/ch/qos/logback/classic/sift/MDCBasedDiscr… - page not found -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 1