- logback-dev - mailman3.qos.ch

svn commit: r2316 - in logback/trunk: logback-classic/src/main/java/ch/qos/logback/classic logback-classic/src/test/java/ch/qos/logback/classic logback-core/src/main/java/ch/qos/logback/core logback-core/src/test/java/ch/qos/logback/core logback-site/src/site/pages
by noreply.ceki＠qos.ch 02 Jul '09

02 Jul '09

Author: ceki Date: Thu Jul 2 15:56:33 2009 New Revision: 2316 Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/LoggerContext.java logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/LoggerContextTest.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/ContextBase.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/ContextBaseTest.java logback/trunk/logback-site/src/site/pages/news.html Log: Fixing LBCORE-104 Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/LoggerContext.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/LoggerContext.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/LoggerContext.java Thu Jul 2 15:56:33 2009 @@ -60,10 +60,10 @@ private LoggerContextVO loggerContextRemoteView; private final TurboFilterList turboFilterList = new TurboFilterList(); - private boolean packagingDataEnabled = true; - + private boolean packagingDataEnabled = true; + private int maxCallerDataDepth = ClassicConstants.DEFAULT_MAX_CALLEDER_DATA_DEPTH; - + boolean started = false; public LoggerContext() { @@ -200,11 +200,14 @@ return packagingDataEnabled; } - /** - * This method closes all appenders, + * This method clears all internal properties, closes all appenders, removes + * any turboFilters, fires an OnReset event, removes all status listeners, + * removes all context listeners (except those which are reset resistant). */ + @Override public void reset() { + super.reset(); root.recursiveReset(); resetTurboFilterList(); fireOnReset(); @@ -344,5 +347,5 @@ public void setMaxCallerDataDepth(int maxCallerDataDepth) { this.maxCallerDataDepth = maxCallerDataDepth; } - + } Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/LoggerContextTest.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/LoggerContextTest.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/LoggerContextTest.java Thu Jul 2 15:56:33 2009 @@ -191,6 +191,17 @@ } @Test + public void resetTest_LBCORE_104() { + lc.putProperty("keyA", "valA"); + lc.putObject("keyA", "valA"); + assertEquals("valA", lc.getProperty("keyA")); + assertEquals("valA", lc.getObject("keyA")); + lc.reset(); + assertNull(lc.getProperty("keyA")); + assertNull(lc.getObject("keyA")); + } + + @Test public void levelResetTest() { Logger root = lc.getLogger(LoggerContext.ROOT_NAME); root.setLevel(Level.TRACE); Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/ContextBase.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/ContextBase.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/ContextBase.java Thu Jul 2 15:56:33 2009 @@ -74,6 +74,14 @@ } /** + * Clear the internal objectMap and all properties. + */ + public void reset() { + propertyMap.clear(); + objectMap.clear(); + } + + /** * The context name can be set only if it is not already set, or if the * current name is the default context name, namely "default", or if the * current name and the old name are the same. Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/ContextBaseTest.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/ContextBaseTest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/ContextBaseTest.java Thu Jul 2 15:56:33 2009 @@ -9,6 +9,8 @@ */ package ch.qos.logback.core; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertNull; import static org.junit.Assert.fail; import org.junit.Test; @@ -40,4 +42,15 @@ } } + @Test + public void resetTest() { + context.setName("hello"); + context.putProperty("keyA", "valA"); + context.putObject("keyA", "valA"); + assertEquals("valA", context.getProperty("keyA")); + assertEquals("valA", context.getObject("keyA")); + context.reset(); + assertNull(context.getProperty("keyA")); + assertNull(context.getObject("keyA")); + } } Modified: logback/trunk/logback-site/src/site/pages/news.html ============================================================================== --- logback/trunk/logback-site/src/site/pages/news.html (original) +++ logback/trunk/logback-site/src/site/pages/news.html Thu Jul 2 15:56:33 2009 @@ -29,7 +29,17 @@ <hr width="80%" align="center" /> - <h3>Nth of April 2009 - Release of version 0.9.16</h3> + <h3>Nth of July 2009 - Release of version 0.9.16</h3> + + <p>In logback-classic, <a + href="xref/ch/qos/logback/classic/spi/LoggingEvent.html"><code>LoggingEvent</code></a> + now implements the <a + href="xref/ch/qos/logback/classic/spi/ILoggingEvent.html"><code>ILoggingEvent</code></a> + interface. All logback-classic components expect to process + <code>ILoggingEvent</code> intances. Moreover, events which sent + to a remote host are now of type <a + href="xref/ch/qos/logback/classic/spi/LoggingEventVO.html"><code>LoggingEventVO</code></a>. + </p> <p>Fixed a bug in the localLevelReset() method in the <code>Logger</code> class whcih inadvertently used the DEBUG_INT @@ -54,6 +64,12 @@ href="http://jira.qos.ch/browse/LBCLASSIC-117">LBCLASSIC-117</a> by Rick Janda. </p> + + <p>When a context is reset, then its object and property maps are + now cleared. This fixes <a + href="http://jira.qos.ch/browse/LBCORE-104">LBCORE-104</a> + reported by Johan Bos. + </p> <hr width="80%" align="center" />

1 0

[JIRA] Created: (LBCORE-60) Allow rolling based on time or file size
by Szel Zoltan (JIRA) 02 Jul '09

02 Jul '09

Allow rolling based on time or file size ---------------------------------------- Key: LBCORE-60 URL: http://jira.qos.ch/browse/LBCORE-60 Project: logback-core Issue Type: New Feature Components: Appender Affects Versions: 0.9.9 Reporter: Szel Zoltan Assignee: Logback dev list The rolling grouping file appender allows to roll over on a specific interval(TimeBasedRollingPolicy) or when the log file has reached a specific file size. But unfortunately Logback does not support both to use together. For example if i want to roll over every day but i also want to roll the file when it is greater than 100MB. Please consider adding this feature to Logback and feel free to contact me if further clarification is required. Thanks, Zoltan Szel -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

4 9

[JIRA] Created: (LBCORE-99) Deadlock in consoleappender using logback in jetty
by Sakib Mehasanewala (JIRA) 01 Jul '09

01 Jul '09

Deadlock in consoleappender using logback in jetty -------------------------------------------------- Key: LBCORE-99 URL: http://jira.qos.ch/browse/LBCORE-99 Project: logback-core Issue Type: Bug Components: Appender Affects Versions: 0.9.15 Environment: Maven 2.1.0 jetty plugin on ubuntu linux. maven dependencies list ... <dependency> <groupId>org.slf4j</groupId> <artifactId>slf4j-ext</artifactId> <version>1.5.8</version> <type>jar</type> </dependency> <dependency> <groupId>org.slf4j</groupId> <artifactId>jcl-over-slf4j</artifactId> <version>1.5.8</version> </dependency> <dependency> <groupId>ch.qos.logback</groupId> <artifactId>logback-core</artifactId> <version>0.9.15</version> <type>jar</type> </dependency> <dependency> <groupId>ch.qos.logback</groupId> <artifactId>logback-classic</artifactId> <version>0.9.15</version> <type>jar</type> </dependency> <dependency> <groupId>commons-logging</groupId> <artifactId>commons-logging</artifactId> <version>99.0-does-not-exist</version> </dependency Reporter: Sakib Mehasanewala Assignee: Logback dev list I came across this deadlock while running jetty via plugin in maven to run functional tests... Found one Java-level deadlock: ============================= "Shutdown": waiting to lock monitor 0xb52073c0 (object 0x7395a770, a ch.qos.logback.core.ConsoleAppender), which is held by "32900144@qtp0-0 - /cbs2/v1.0/ws/cbs2.wsdl" "32900144@qtp0-0 - /cbs2/v1.0/ws/cbs2.wsdl": waiting to lock monitor 0xb5209bfc (object 0x7391a760, a org.mortbay.jetty.webapp.WebAppClassLoader), which is held by "15510444@qtp0-2 - /cbs2/v1.0/ws/cbs2.wsdl" "15510444@qtp0-2 - /cbs2/v1.0/ws/cbs2.wsdl": waiting to lock monitor 0xb52073c0 (object 0x7395a770, a ch.qos.logback.core.ConsoleAppender), which is held by "32900144@qtp0-0 - /cbs2/v1.0/ws/cbs2.wsdl" Java stack information for the threads listed above: =================================================== "Shutdown": at ch.qos.logback.core.AppenderBase.doAppend(AppenderBase.java:66) - waiting to lock <0x7395a770> (a ch.qos.logback.core.ConsoleAppender) at ch.qos.logback.core.spi.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:60) at ch.qos.logback.classic.Logger.appendLoopOnAppenders(Logger.java:270) at ch.qos.logback.classic.Logger.callAppenders(Logger.java:257) at ch.qos.logback.classic.Logger.buildLoggingEventAndAppend(Logger.java:439) at ch.qos.logback.classic.Logger.filterAndLog_2(Logger.java:430) at ch.qos.logback.classic.Logger.info(Logger.java:605) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.mortbay.log.Slf4jLog.info(Slf4jLog.java:103) at org.mortbay.log.Log.info(Log.java:132) at org.mortbay.jetty.Server$ShutdownHookThread.run(Server.java:550) "32900144@qtp0-0 - /cbs2/v1.0/ws/cbs2.wsdl": at org.mortbay.jetty.webapp.WebAppClassLoader.loadClass(WebAppClassLoader.java:341) - waiting to lock <0x7391a760> (a org.mortbay.jetty.webapp.WebAppClassLoader) at ch.qos.logback.classic.spi.PackagingDataCalculator.loadClass(PackagingDataCalculator.java:232) at ch.qos.logback.classic.spi.PackagingDataCalculator.bestEffortLoadClass(PackagingDataCalculator.java:257) at ch.qos.logback.classic.spi.PackagingDataCalculator.computeBySTEP(PackagingDataCalculator.java:166) at ch.qos.logback.classic.spi.PackagingDataCalculator.populateFrames(PackagingDataCalculator.java:97) at ch.qos.logback.classic.spi.PackagingDataCalculator.calculate(PackagingDataCalculator.java:61) at ch.qos.logback.classic.spi.ThrowableProxy.calculatePackagingData(ThrowableProxy.java:50) at ch.qos.logback.classic.pattern.ExtendedThrowableProxyConverter.prepareLoggingEvent(ExtendedThrowableProxyConverter.java:35) at ch.qos.logback.classic.pattern.ThrowableProxyConverter.convert(ThrowableProxyConverter.java:142) at ch.qos.logback.classic.pattern.ThrowableProxyConverter.convert(ThrowableProxyConverter.java:30) at ch.qos.logback.core.pattern.FormattingConverter.write(FormattingConverter.java:32) at ch.qos.logback.core.pattern.PatternLayoutBase.writeLoopOnConverters(PatternLayoutBase.java:110) at ch.qos.logback.classic.PatternLayout.doLayout(PatternLayout.java:132) at ch.qos.logback.classic.PatternLayout.doLayout(PatternLayout.java:51) at ch.qos.logback.core.WriterAppender.subAppend(WriterAppender.java:261) at ch.qos.logback.core.WriterAppender.append(WriterAppender.java:114) at ch.qos.logback.core.AppenderBase.doAppend(AppenderBase.java:87) - locked <0x7395a770> (a ch.qos.logback.core.ConsoleAppender) at ch.qos.logback.core.spi.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:60) at ch.qos.logback.classic.Logger.appendLoopOnAppenders(Logger.java:270) at ch.qos.logback.classic.Logger.callAppenders(Logger.java:257) at ch.qos.logback.classic.Logger.buildLoggingEventAndAppend(Logger.java:439) at ch.qos.logback.classic.Logger.filterAndLog_0_Or3Plus(Logger.java:393) at ch.qos.logback.classic.Logger.warn(Logger.java:710) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.mortbay.log.Slf4jLog.warn(Slf4jLog.java:128) at org.mortbay.log.Log.warn(Log.java:181) at org.mortbay.log.Log.unwind(Log.java:216) at org.mortbay.log.Log.warn(Log.java:182) at org.mortbay.log.Log.unwind(Log.java:216) at org.mortbay.log.Log.warn(Log.java:182) at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:414) at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216) at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181) at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766) at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:417) at org.mortbay.jetty.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:230) at org.mortbay.jetty.handler.HandlerCollection.handle(HandlerCollection.java:114) at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152) at org.mortbay.jetty.Server.handle(Server.java:320) at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:534) at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:864) at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:533) at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:207) at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:403) at org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:409) at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:522) "15510444@qtp0-2 - /cbs2/v1.0/ws/cbs2.wsdl": at ch.qos.logback.core.AppenderBase.doAppend(AppenderBase.java:66) - waiting to lock <0x7395a770> (a ch.qos.logback.core.ConsoleAppender) at ch.qos.logback.core.spi.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:60) at ch.qos.logback.classic.Logger.appendLoopOnAppenders(Logger.java:270) at ch.qos.logback.classic.Logger.callAppenders(Logger.java:257) at ch.qos.logback.classic.Logger.buildLoggingEventAndAppend(Logger.java:439) at ch.qos.logback.classic.Logger.filterAndLog_2(Logger.java:430) at ch.qos.logback.classic.Logger.debug(Logger.java:508) at sun.reflect.GeneratedMethodAccessor15.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.mortbay.log.Slf4jLog.debug(Slf4jLog.java:73) at org.mortbay.log.Log.debug(Log.java:90) at org.mortbay.jetty.webapp.WebAppClassLoader.loadClass(WebAppClassLoader.java:388) - locked <0x7391a760> (a org.mortbay.jetty.webapp.WebAppClassLoader) at org.mortbay.jetty.webapp.WebAppClassLoader.loadClass(WebAppClassLoader.java:341) - locked <0x7391a760> (a org.mortbay.jetty.webapp.WebAppClassLoader) at com.sun.org.apache.xerces.internal.parsers.ObjectFactory.findProviderClass(ObjectFactory.java:393) at com.sun.org.apache.xerces.internal.parsers.ObjectFactory.newInstance(ObjectFactory.java:348) at com.sun.org.apache.xerces.internal.parsers.ObjectFactory.createObject(ObjectFactory.java:154) at com.sun.org.apache.xerces.internal.parsers.ObjectFactory.createObject(ObjectFactory.java:97) at com.sun.org.apache.xerces.internal.parsers.DOMParser.<init>(DOMParser.java:125) at com.sun.org.apache.xerces.internal.parsers.DOMParser.<init>(DOMParser.java:109) at com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderImpl.<init>(DocumentBuilderImpl.java:115) at com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderFactoryImpl.newDocumentBuilder(DocumentBuilderFactoryImpl.java:72) at com.sun.org.apache.xalan.internal.xsltc.trax.SAX2DOM.<init>(SAX2DOM.java:69) - locked <0x912b1278> (a java.lang.Class for com.sun.org.apache.xalan.internal.xsltc.trax.SAX2DOM) at com.sun.org.apache.xalan.internal.xsltc.runtime.output.TransletOutputHandlerFactory.getSerializationHandler(TransletOutputHandlerFactory.java:187) at com.sun.org.apache.xalan.internal.xsltc.trax.TransformerImpl.getOutputHandler(TransformerImpl.java:392) at com.sun.org.apache.xalan.internal.xsltc.trax.TransformerImpl.transform(TransformerImpl.java:298) at org.springframework.ws.transport.http.WsdlDefinitionHandlerAdapter.handle(WsdlDefinitionHandlerAdapter.java:125) at org.springframework.ws.transport.http.MessageDispatcherServlet.doService(MessageDispatcherServlet.java:222) at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:613) at org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:525) at javax.servlet.http.HttpServlet.service(HttpServlet.java:707) at javax.servlet.http.HttpServlet.service(HttpServlet.java:820) at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:502) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1124) at com.diginsite.services.cbs2.filter.ClearRequestContextFilter.doFilter(ClearRequestContextFilter.java:34) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1115) at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:361) at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216) at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181) at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766) at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:417) at org.mortbay.jetty.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:230) at org.mortbay.jetty.handler.HandlerCollection.handle(HandlerCollection.java:114) at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152) at org.mortbay.jetty.Server.handle(Server.java:320) at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:534) at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:864) at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:533) at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:207) at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:403) at org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:409) at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:522) Found 1 deadlock. Heap def new generation total 3904K, used 115K [0x70060000, 0x70490000, 0x727c0000) eden space 3520K, 3% used [0x70060000, 0x7007cda8, 0x703d0000) from space 384K, 0% used [0x703d0000, 0x703d0000, 0x70430000) to space 384K, 0% used [0x70430000, 0x70430000, 0x70490000) tenured generation total 50668K, used 26395K [0x727c0000, 0x7593b000, 0x90060000) the space 50668K, 52% used [0x727c0000, 0x74186f40, 0x74187000, 0x7593b000) compacting perm gen total 20736K, used 20517K [0x90060000, 0x914a0000, 0x94060000) the space 20736K, 98% used [0x90060000, 0x914697a0, 0x91469800, 0x914a0000) ro space 8192K, 74% used [0x94060000, 0x94658b48, 0x94658c00, 0x94860000) rw space 12288K, 58% used [0x94860000, 0x94f73df0, 0x94f73e00, 0x95460000) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

4 14

[JIRA] Created: (LBGENERAL-29) Revision 2296 does not build executing "mvn clean install"
by Joern Huxhorn (JIRA) 01 Jul '09

01 Jul '09

Revision 2296 does not build executing "mvn clean install" ---------------------------------------------------------- Key: LBGENERAL-29 URL: http://jira.qos.ch/browse/LBGENERAL-29 Project: logback-general Issue Type: Bug Environment: Maven version: 2.0.10 Java version: 1.6.0_13 OS name: "mac os x" version: "10.5.7" arch: "x86_64" Family: "mac" Reporter: Joern Huxhorn Assignee: Logback dev list Lots of strange errors are reported by Maven. I suspect that it's a bug in the surefire-plugin as all internal classes of tests are interpreted as test-classes... Anyway, I've fixed this. Patch is upcoming. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 2

[JIRA] Created: (LBCORE-103) message implicit variable should have a more detailed documentation and usage for the EvaluatorFilter
by Johan Bos (JIRA) 30 Jun '09

30 Jun '09

message implicit variable should have a more detailed documentation and usage for the EvaluatorFilter ----------------------------------------------------------------------------------------------------- Key: LBCORE-103 URL: http://jira.qos.ch/browse/LBCORE-103 Project: logback-core Issue Type: Improvement Components: Appender Affects Versions: 0.9.15 Environment: Windows XP, Java 1.5 Sun JVM, Tomcat 5.0.27 Reporter: Johan Bos Assignee: Logback dev list Priority: Trivial I was expecting "message" implicit variable to contain the full message rendered by the %message or %msg from the pattern, but the recommanded way of logging, using LOG.debug("I want to log an object {}", object); is only formatted in the event.getFormattedMessage(), event.getMessage <=> message, but only contains the "I want to log an object {}" so if my matching string for the expression setting for the EvaluatorFilter is the dynamical part I can't never match my string, instead it got "{}". So, it would be less confusing for users to find in the documentation an explicit information on what message variable contains, and does not contain! Thank you I would be happy to explain my point if you find it unclear or irrelevant. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Created: (LBCLASSIC-141) ContextListener that stops the LoggerContext when using DefaultContextSelector
by Paul Nyheim (JIRA) 30 Jun '09

30 Jun '09

ContextListener that stops the LoggerContext when using DefaultContextSelector ------------------------------------------------------------------------------ Key: LBCLASSIC-141 URL: http://jira.qos.ch/browse/LBCLASSIC-141 Project: logback-classic Issue Type: Improvement Affects Versions: 0.9.15 Reporter: Paul Nyheim Assignee: Logback dev list Priority: Minor When using the "The simplest and easiest approach" to configure logback as described here: http://logback.qos.ch/manual/loggingSeparation.html, The LoggerContext never gets stopped when the application is redeployed in an applicationserver. This causes both memory leaks, and an unability to Rename log files using RollingFileAppender because several handles to the log file exists. An easy solution to this is to stop the LoggerContext in a ServletContextListener - much the same as for the ContextJNDISelector using ContextDetachingSCL. I will upload a file - based on the ContextDetatchingSCL which does the job. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

2 2

svn commit: r2315 - logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135
by noreply.ceki＠qos.ch 29 Jun '09

29 Jun '09

Author: ceki Date: Mon Jun 29 19:06:40 2009 New Revision: 2315 Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingToFileThrouhput.java Log: reformat results Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingToFileThrouhput.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingToFileThrouhput.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingToFileThrouhput.java Mon Jun 29 19:06:40 2009 @@ -23,7 +23,7 @@ */ public class LoggingToFileThrouhput { - static int THREAD_COUNT = 10; + static int THREAD_COUNT = 1; static long OVERALL_DURATION_IN_MILLIS = 5000; public static void main(String args[]) throws InterruptedException { @@ -79,34 +79,34 @@ // java.vendor = Sun Microsystems Inc. // os.name = Windows XP // -// Threads 10: total of 309402 operations, or 61 operations per millisecond // Threads 1: total of 485077 operations, or 97 operations per millisecond +// Threads 10: total of 309402 operations, or 61 operations per millisecond //* After revision 2310 -//* Threads 10: total of 243362 operations, or 58 operations per millisecond //* Threads 1: total of 462465 operations, or 92 operations per millisecond +//* Threads 10: total of 243362 operations, or 48 operations per millisecond +// ==================== Linux ======================== // java.runtime.version = 1.6.0_11-b03 // java.vendor = Sun Microsystems Inc. // os.name = Linux // os.version = 2.6.25-gentoo-r6 -// Threads 10: total of 287943 operations, or 57 operations per millisecond // Threads 1: total of 356355 operations, or 71 operations per millisecond +// Threads 10: total of 287943 operations, or 57 operations per millisecond //* After revision 2310 -//* Threads 10: total of 311104 operations, or 62 operations per millisecond //* Threads 1: total of 331494 operations, or 66 operations per millisecond - +//* Threads 10: total of 311104 operations, or 58 operations per millisecond // java.runtime.version = jvmxa6460-20081105_25433 // java.vendor = IBM Corporation // java.version = 1.6.0 // os.name = Linux // os.version = 2.6.25-gentoo-r6 -// Threads 10 total of 142989 operations, or 28 operations per millisecond // Threads 1: total of 280381 operations, or 56 operations per millisecond +// Threads 10 total of 142989 operations, or 28 operations per millisecond //* After revision 2310 -//* Threads 10: total of 147660 operations, or 29 operations per millisecond -//* Threads 1: total of 305638 operations, or 61 operations per millisecond \ No newline at end of file +//* Threads 1: total of 305638 operations, or 61 operations per millisecond +//* Threads 10: total of 147660 operations, or 29 operations per millisecond \ No newline at end of file

1 0

svn commit: r2314 - logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135
by noreply.ceki＠qos.ch 29 Jun '09

29 Jun '09

Author: ceki Date: Mon Jun 29 19:00:06 2009 New Revision: 2314 Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingToFileThrouhput.java Log: slightly slower results after revision 2310 Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingToFileThrouhput.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingToFileThrouhput.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingToFileThrouhput.java Mon Jun 29 19:00:06 2009 @@ -82,10 +82,10 @@ // Threads 10: total of 309402 operations, or 61 operations per millisecond // Threads 1: total of 485077 operations, or 97 operations per millisecond -// After revision 2310 +//* After revision 2310 +//* Threads 10: total of 243362 operations, or 58 operations per millisecond +//* Threads 1: total of 462465 operations, or 92 operations per millisecond -// Threads 1: total of 462465 operations, or 92 operations per millisecond -//Threads 10: total of 243362 operations, or 48 operations per millisecond // java.runtime.version = 1.6.0_11-b03 // java.vendor = Sun Microsystems Inc. @@ -94,6 +94,10 @@ // Threads 10: total of 287943 operations, or 57 operations per millisecond // Threads 1: total of 356355 operations, or 71 operations per millisecond +//* After revision 2310 +//* Threads 10: total of 311104 operations, or 62 operations per millisecond +//* Threads 1: total of 331494 operations, or 66 operations per millisecond + // java.runtime.version = jvmxa6460-20081105_25433 // java.vendor = IBM Corporation @@ -103,3 +107,6 @@ // Threads 10 total of 142989 operations, or 28 operations per millisecond // Threads 1: total of 280381 operations, or 56 operations per millisecond +//* After revision 2310 +//* Threads 10: total of 147660 operations, or 29 operations per millisecond +//* Threads 1: total of 305638 operations, or 61 operations per millisecond \ No newline at end of file

1 0

svn commit: r2313 - logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/lbclassic139
by noreply.ceki＠qos.ch 29 Jun '09

29 Jun '09

Author: ceki Date: Mon Jun 29 18:54:35 2009 New Revision: 2313 Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/lbclassic139/LB139_DeadlockTest.java Log: wait longer so that tests pass in slower machines Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/lbclassic139/LB139_DeadlockTest.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/lbclassic139/LB139_DeadlockTest.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/lbclassic139/LB139_DeadlockTest.java Mon Jun 29 18:54:35 2009 @@ -4,7 +4,7 @@ public class LB139_DeadlockTest { - @Test(timeout=2000) + @Test(timeout=3000) public void test() throws Exception { Worker worker = new Worker(); Accessor accessor = new Accessor(worker);

1 0

svn commit: r2312 - in logback/trunk: logback-classic/src/test/java/ch/qos/logback/classic logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135 logback-core/src/test/java/ch/qos/logback/core/appender logback-core/src/test/java/ch/qos/logback/core/contention logback-core/src/test/java/ch/qos/logback/core/rolling
by noreply.ceki＠qos.ch 29 Jun '09

29 Jun '09

Author: ceki Date: Mon Jun 29 18:44:28 2009 New Revision: 2312 Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/TestConstants.java logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingRunnable.java logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingToFileThrouhput.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/AbstractAppenderTest.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/ConsoleAppenderTest.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/DummyAppenderTest.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/FileAppenderTest.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/contention/RunnableWithCounterAndDone.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/rolling/RollingFileAppenderTest.java Log: Use Appender instead of AppenderBase in AbstractAppender related tests Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/TestConstants.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/TestConstants.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/TestConstants.java Mon Jun 29 18:44:28 2009 @@ -1,11 +1,11 @@ /** - * LOGBack: the reliable, fast and flexible logging library for Java. - * - * Copyright (C) 1999-2006, QOS.ch - * - * This library is free software, you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public License as - * published by the Free Software Foundation. + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2009, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. */ package ch.qos.logback.classic; Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingRunnable.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingRunnable.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingRunnable.java Mon Jun 29 18:44:28 2009 @@ -1,3 +1,12 @@ +/** + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2009, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. + */ package ch.qos.logback.classic.issue.lbclassic135; import ch.qos.logback.classic.Logger; Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingToFileThrouhput.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingToFileThrouhput.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/issue/lbclassic135/LoggingToFileThrouhput.java Mon Jun 29 18:44:28 2009 @@ -1,3 +1,12 @@ +/** + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2009, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. + */ package ch.qos.logback.classic.issue.lbclassic135; import ch.qos.logback.classic.Logger; Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/AbstractAppenderTest.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/AbstractAppenderTest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/AbstractAppenderTest.java Mon Jun 29 18:44:28 2009 @@ -1,11 +1,11 @@ /** - * LOGBack: the reliable, fast and flexible logging library for Java. - * - * Copyright (C) 1999-2006, QOS.ch - * - * This library is free software, you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public License as - * published by the Free Software Foundation. + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2009, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. */ package ch.qos.logback.core.appender; @@ -15,7 +15,7 @@ import org.junit.Test; -import ch.qos.logback.core.AppenderBase; +import ch.qos.logback.core.Appender; import ch.qos.logback.core.Context; import ch.qos.logback.core.ContextBase; import ch.qos.logback.core.status.StatusChecker; @@ -25,19 +25,19 @@ abstract public class AbstractAppenderTest<E> { - abstract protected AppenderBase<E> getAppender(); - abstract protected AppenderBase<E> getConfiguredAppender(); + abstract protected Appender<E> getAppender(); + abstract protected Appender<E> getConfiguredAppender(); @Test public void testNewAppender() { // new appenders should be inactive - AppenderBase appender = getAppender(); + Appender appender = getAppender(); assertFalse( appender.isStarted()); } @Test public void testConfiguredAppender() { - AppenderBase appender = getConfiguredAppender(); + Appender appender = getConfiguredAppender(); appender.start(); assertTrue(appender.isStarted()); @@ -48,7 +48,7 @@ @Test public void testNoStart() { - AppenderBase<E> appender = getAppender(); + Appender<E> appender = getAppender(); Context context = new ContextBase(); appender.setContext(context); appender.setName("doh"); Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/ConsoleAppenderTest.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/ConsoleAppenderTest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/ConsoleAppenderTest.java Mon Jun 29 18:44:28 2009 @@ -1,11 +1,11 @@ /** - * LOGBack: the reliable, fast and flexible logging library for Java. - * - * Copyright (C) 1999-2006, QOS.ch - * - * This library is free software, you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public License as - * published by the Free Software Foundation. + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2009, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. */ package ch.qos.logback.core.appender; @@ -18,7 +18,7 @@ import org.junit.Before; import org.junit.Test; -import ch.qos.logback.core.AppenderBase; +import ch.qos.logback.core.Appender; import ch.qos.logback.core.ConsoleAppender; import ch.qos.logback.core.CoreConstants; import ch.qos.logback.core.layout.DummyLayout; @@ -53,11 +53,11 @@ } @Override - public AppenderBase<Object> getAppender() { + public Appender<Object> getAppender() { return new ConsoleAppender<Object>(); } - protected AppenderBase<Object> getConfiguredAppender() { + protected Appender<Object> getConfiguredAppender() { ConsoleAppender<Object> ca = new ConsoleAppender<Object>(); ca.setLayout(new NopLayout<Object>()); ca.start(); Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/DummyAppenderTest.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/DummyAppenderTest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/DummyAppenderTest.java Mon Jun 29 18:44:28 2009 @@ -9,13 +9,13 @@ */ package ch.qos.logback.core.appender; -import static org.junit.Assert.*; +import static org.junit.Assert.assertEquals; import java.io.StringWriter; import org.junit.Test; -import ch.qos.logback.core.AppenderBase; +import ch.qos.logback.core.Appender; import ch.qos.logback.core.layout.DummyLayout; import ch.qos.logback.core.layout.NopLayout; @@ -23,11 +23,11 @@ public class DummyAppenderTest { - protected AppenderBase getAppender() { + protected Appender getAppender() { return new DummyAppender(new StringWriter()); } - protected AppenderBase getConfiguredAppender() { + protected Appender getConfiguredAppender() { DummyAppender<Object> da = new DummyAppender<Object>(new StringWriter()); da.setLayout(new NopLayout<Object>()); da.start(); Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/FileAppenderTest.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/FileAppenderTest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/appender/FileAppenderTest.java Mon Jun 29 18:44:28 2009 @@ -19,7 +19,7 @@ import org.junit.Test; -import ch.qos.logback.core.AppenderBase; +import ch.qos.logback.core.Appender; import ch.qos.logback.core.Context; import ch.qos.logback.core.ContextBase; import ch.qos.logback.core.FileAppender; @@ -35,11 +35,11 @@ int diff = new Random().nextInt(100); Context context = new ContextBase(); - protected AppenderBase<Object> getAppender() { + protected Appender<Object> getAppender() { return new FileAppender<Object>(); } - protected AppenderBase<Object> getConfiguredAppender() { + protected Appender<Object> getConfiguredAppender() { FileAppender<Object> appender = new FileAppender<Object>(); appender.setLayout(new NopLayout<Object>()); appender.setFile("temp.log"); Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/contention/RunnableWithCounterAndDone.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/contention/RunnableWithCounterAndDone.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/contention/RunnableWithCounterAndDone.java Mon Jun 29 18:44:28 2009 @@ -1,3 +1,12 @@ +/** + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2009, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. + */ package ch.qos.logback.core.contention; /** Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/rolling/RollingFileAppenderTest.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/rolling/RollingFileAppenderTest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/rolling/RollingFileAppenderTest.java Mon Jun 29 18:44:28 2009 @@ -1,3 +1,12 @@ +/** + * Logback: the generic, reliable, fast and flexible logging framework. + * + * Copyright (C) 2000-2009, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. + */ package ch.qos.logback.core.rolling; @@ -10,7 +19,7 @@ import org.junit.Before; import org.junit.Test; -import ch.qos.logback.core.AppenderBase; +import ch.qos.logback.core.Appender; import ch.qos.logback.core.Context; import ch.qos.logback.core.ContextBase; import ch.qos.logback.core.appender.AbstractAppenderTest; @@ -41,12 +50,12 @@ @Override - protected AppenderBase<Object> getAppender() { + protected Appender<Object> getAppender() { return rfa; } @Override - protected AppenderBase<Object> getConfiguredAppender() { + protected Appender<Object> getConfiguredAppender() { rfa.setContext(context); tbrp.setFileNamePattern("toto-%d.log");

1 0