- logback-dev - mailman3.qos.ch

[JIRA] Created: (LBCLASSIC-99) Add SiftingAppender support in logback-access
by Ceki Gulcu (JIRA) 23 Dec '08

23 Dec '08

Add SiftingAppender support in logback-access --------------------------------------------- Key: LBCLASSIC-99 URL: http://jira.qos.ch/browse/LBCLASSIC-99 Project: logback-classic Issue Type: Sub-task Reporter: Ceki Gulcu Assignee: Logback dev list Fix For: 0.9.14 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 2

[JIRA] Created: (LBCLASSIC-97) document HoardingAppender
by Ceki Gulcu (JIRA) 23 Dec '08

23 Dec '08

document HoardingAppender ------------------------- Key: LBCLASSIC-97 URL: http://jira.qos.ch/browse/LBCLASSIC-97 Project: logback-classic Issue Type: Sub-task Components: appender Affects Versions: 0.9.10 Reporter: Ceki Gulcu Assignee: Ceki Gulcu Fix For: 0.9.14 document in the manual. Do not forget to update the javadocs -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 3

[JIRA] Resolved: (LBCLASSIC-2) Offer a logging implementation of org.xml.sax.ErrorHandler
by Ceki Gulcu (JIRA) 23 Dec '08

23 Dec '08

[ http://jira.qos.ch/browse/LBCLASSIC-2?page=com.atlassian.jira.plugin.system… ] Ceki Gulcu resolved LBCLASSIC-2. -------------------------------- Resolution: Won't Fix No one else has asked for this feature. > Offer a logging implementation of org.xml.sax.ErrorHandler > ---------------------------------------------------------- > > Key: LBCLASSIC-2 > URL: http://jira.qos.ch/browse/LBCLASSIC-2 > Project: logback-classic > Issue Type: Improvement > Components: Other > Affects Versions: unspecified > Environment: Operating System: Windows > Platform: PC > Reporter: Ceki Gulcu > Assignee: Ceki Gulcu > Priority: Minor > > It would be nice if logback contained an implementation of o.x.sax.ErrorHandler > which did some logging, possibly using the status manager as well... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Created: (LBCLASSIC-96) verify the newly built appender depends on the mdc value
by Ceki Gulcu (JIRA) 23 Dec '08

23 Dec '08

verify the newly built appender depends on the mdc value -------------------------------------------------------- Key: LBCLASSIC-96 URL: http://jira.qos.ch/browse/LBCLASSIC-96 Project: logback-classic Issue Type: Sub-task Reporter: Ceki Gulcu Assignee: Logback dev list -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 3

[JIRA] Created: (LBCLASSIC-94) clean up appenders
by Ceki Gulcu (JIRA) 23 Dec '08

23 Dec '08

clean up appenders ------------------- Key: LBCLASSIC-94 URL: http://jira.qos.ch/browse/LBCLASSIC-94 Project: logback-classic Issue Type: Sub-task Reporter: Ceki Gulcu Assignee: Logback dev list Fix For: 0.9.14 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 3

[JIRA] Created: (LBCLASSIC-92) HoardingAppender
by Ceki Gulcu (JIRA) 23 Dec '08

23 Dec '08

HoardingAppender ---------------- Key: LBCLASSIC-92 URL: http://jira.qos.ch/browse/LBCLASSIC-92 Project: logback-classic Issue Type: Task Components: appender Affects Versions: 0.9.14 Reporter: Ceki Gulcu Assignee: Ceki Gulcu HoardingAppender related tasks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 2

svn commit: r2100 - in logback/trunk: logback-access/src/main/java/ch/qos/logback/access/sift logback-access/src/test/input/jetty logback-core/src/main/java/ch/qos/logback/core/joran/action logback-examples/src/main/java/chapter4/sift logback-site/src/site/pages/manual
by noreply.ceki＠qos.ch 23 Dec '08

23 Dec '08

Author: ceki Date: Tue Dec 23 22:22:24 2008 New Revision: 2100 Added: logback/trunk/logback-examples/src/main/java/chapter4/sift/access-siftingFile.xml Removed: logback/trunk/logback-access/src/test/input/jetty/siftingFile.xml Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/sift/AccessEventDiscriminator.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/AppenderRefAction.java logback/trunk/logback-site/src/site/pages/manual/appenders.html Log: - improved docs Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/sift/AccessEventDiscriminator.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/sift/AccessEventDiscriminator.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/sift/AccessEventDiscriminator.java Tue Dec 23 22:22:24 2008 @@ -38,7 +38,9 @@ * REQUEST_ATTRIBUTE, SESSION_ATTRIBUTE, REMOTE_ADDRESS, * LOCAL_PORT,REQUEST_URI * - * The first three fields require an additional key. + * The first three fields require an additional key. For the + * SESSION_ATTRIBUTE field, the additional key named "id" has special meaning + * as it is mapped to the session id of the current http request. */ public enum FieldName { COOKIE, REQUEST_ATTRIBUTE, SESSION_ATTRIBUTE, REMOTE_ADDRESS, LOCAL_PORT, REQUEST_URI @@ -61,16 +63,19 @@ public String getRawDiscriminatingValue(AccessEvent acccessEvent) { switch (fieldName) { case COOKIE: + // tested return acccessEvent.getCookie(additionalKey); case LOCAL_PORT: return String.valueOf(acccessEvent.getLocalPort()); case REQUEST_ATTRIBUTE: + // tested return getRequestAttribute(acccessEvent); case SESSION_ATTRIBUTE: return getSessionAttribute(acccessEvent); case REMOTE_ADDRESS: return acccessEvent.getRemoteAddr(); case REQUEST_URI: + // tested return getRequestURI(acccessEvent); default: return null; @@ -79,13 +84,13 @@ private String getRequestAttribute(AccessEvent acccessEvent) { String attr = acccessEvent.getAttribute(additionalKey); - if(AccessEvent.NA.equals(attr)) { + if (AccessEvent.NA.equals(attr)) { return null; } else { return attr; } } - + private String getRequestURI(AccessEvent acccessEvent) { String uri = acccessEvent.getRequestURI(); if (uri != null && uri.length() >= 1 && uri.charAt(0) == '/') { @@ -97,18 +102,9 @@ private String getSessionAttribute(AccessEvent acccessEvent) { HttpServletRequest req = acccessEvent.getRequest(); - System.out.println("req=" + req); if (req != null) { HttpSession session = req.getSession(false); - System.out.println("session=" + session); if (session != null) { - Enumeration ee = session.getAttributeNames(); - while(ee.hasMoreElements()) { - String k = (String) ee.nextElement(); - Object v = session.getAttribute(k); - System.out.println("Session "+k+"="+v); - } - if ("id".equalsIgnoreCase(additionalKey)) { return session.getId(); } else { Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/AppenderRefAction.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/AppenderRefAction.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/AppenderRefAction.java Tue Dec 23 22:22:24 2008 @@ -1,7 +1,7 @@ /** - * LOGBack: the generic, reliable, fast and flexible logging framework. + * Logback: the generic, reliable, fast and flexible logging framework. * - * Copyright (C) 1999-2006, QOS.ch + * Copyright (C) 2000-2008, QOS.ch * * This library is free software, you can redistribute it and/or modify it under * the terms of the GNU Lesser General Public License as published by the Free Added: logback/trunk/logback-examples/src/main/java/chapter4/sift/access-siftingFile.xml ============================================================================== --- (empty file) +++ logback/trunk/logback-examples/src/main/java/chapter4/sift/access-siftingFile.xml Tue Dec 23 22:22:24 2008 @@ -0,0 +1,22 @@ +<configuration> + + <appender name="SIFTING" + class="ch.qos.logback.access.sift.SiftingAppender"> + <Discriminator> + <Key>id</Key> + <FieldName>SESSION_ATTRIBUTE</FieldName> + <AdditionalKey>username</AdditionalKey> + <DefaultValue>NA</DefaultValue> + </Discriminator> + <sift> + <appender name="${id}" class="ch.qos.logback.core.FileAppender"> + <File>byUser/${id}.log</File> + <layout class="ch.qos.logback.access.PatternLayout"> + <Pattern>%h %l %u %t \"%r\" %s %b</Pattern> + </layout> + </appender> + </sift> + </appender> + + <appender-ref ref="SIFTING" /> +</configuration> \ No newline at end of file Modified: logback/trunk/logback-site/src/site/pages/manual/appenders.html ============================================================================== --- logback/trunk/logback-site/src/site/pages/manual/appenders.html (original) +++ logback/trunk/logback-site/src/site/pages/manual/appenders.html Tue Dec 23 22:22:24 2008 @@ -3512,11 +3512,47 @@ The desginated AccessEvent field can be one of COOKIE, REQUEST_ATTRIBUTE, SESSION_ATTRIBUTE, REMOTE_ADDRESS, LOCAL_PORT, - REQUEST_URI. Note that the fiest three fields require that the - AdditionalKey property to be + REQUEST_URI. Note that the first three fields require that the + AdditionalKey property also to be specified. + Below is an example configuration file. + Example 4.: SiftingAppender configuration (logback-examples/src/main/java/chapter4/conf/sift/access-siftingFile.xml) + + <configuration> + <appender name="SIFTING" class="ch.qos.logback.access.sift.SiftingAppender"> + <Discriminator class="ch.qos.logback.access.sift.AccessEventDiscriminator"> + <Key>id</Key> + <FieldName>SESSION_ATTRIBUTE</FieldName> + <AdditionalKey>username</AdditionalKey> + <DefaultValue>NA</DefaultValue> + </Discriminator> + <sift> + <appender name="${id}" class="ch.qos.logback.core.FileAppender"> + <File>byUser/${id}.log</File> + <layout class="ch.qos.logback.access.PatternLayout"> + <Pattern>%h %l %u %t \"%r\" %s %b</Pattern> + </layout> + </appender> + </sift> + </appender> + <appender-ref ref="SIFTING" /> +</configuration> + + + In the above configuration file, a <code>SiftingAppender</code> + nests <code>FileAppender</code> instances. The key "id" is + designated as a variable which will be availabe to the nested + <code>FileAppender</code> instances. The default discriminator, + namely <code>AccessEventDiscriminator</code>, will search for + "username" session attribute in each <code>AccessEvent</code>. If + no such attribute is available, then the default value "NA" will + be used. Thus, assuming the session attribute named "username" + contains the username of each logged on user, there will be a log + file under the byUser/ folder (of the current folder) + named after each user containing the access logs for that user. + <script src="../templates/footer.js" type="text/javascript"></script>

1 0

svn commit: r2099 - logback/trunk/logback-access/src/main/java/ch/qos/logback/access/sift
by noreply.ceki＠qos.ch 23 Dec '08

23 Dec '08

Author: ceki Date: Tue Dec 23 21:33:14 2008 New Revision: 2099 Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/sift/AccessEventDiscriminator.java Log: - minor changes Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/sift/AccessEventDiscriminator.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/sift/AccessEventDiscriminator.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/sift/AccessEventDiscriminator.java Tue Dec 23 21:33:14 2008 @@ -9,6 +9,8 @@ */ package ch.qos.logback.access.sift; +import java.util.Enumeration; + import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpSession; @@ -18,11 +20,11 @@ /** * - * AccessEventDiscriminator's job is to return the value of a designated field in - * an {@link AccessEvent} instance. + * AccessEventDiscriminator's job is to return the value of a designated field + * in an {@link AccessEvent} instance. + * + * The field is specified via the {@link FieldName} property. * - * The field is specified via the {@link FieldName} property. - * @author Ceki Gülcü * */ @@ -32,8 +34,8 @@ boolean started = false; /** - * At present time the followed fields can be designated: - * COOKIE, REQUEST_ATTRIBUTE, SESSION_ATTRIBUTE, REMOTE_ADDRESS, + * At present time the followed fields can be designated: COOKIE, + * REQUEST_ATTRIBUTE, SESSION_ATTRIBUTE, REMOTE_ADDRESS, * LOCAL_PORT,REQUEST_URI * * The first three fields require an additional key. @@ -63,7 +65,7 @@ case LOCAL_PORT: return String.valueOf(acccessEvent.getLocalPort()); case REQUEST_ATTRIBUTE: - return acccessEvent.getAttribute(additionalKey); + return getRequestAttribute(acccessEvent); case SESSION_ATTRIBUTE: return getSessionAttribute(acccessEvent); case REMOTE_ADDRESS: @@ -75,6 +77,15 @@ } } + private String getRequestAttribute(AccessEvent acccessEvent) { + String attr = acccessEvent.getAttribute(additionalKey); + if(AccessEvent.NA.equals(attr)) { + return null; + } else { + return attr; + } + } + private String getRequestURI(AccessEvent acccessEvent) { String uri = acccessEvent.getRequestURI(); if (uri != null && uri.length() >= 1 && uri.charAt(0) == '/') { @@ -86,12 +97,25 @@ private String getSessionAttribute(AccessEvent acccessEvent) { HttpServletRequest req = acccessEvent.getRequest(); + System.out.println("req=" + req); if (req != null) { HttpSession session = req.getSession(false); + System.out.println("session=" + session); if (session != null) { - Object v = session.getAttribute(additionalKey); - if (v != null) { - return v.toString(); + Enumeration ee = session.getAttributeNames(); + while(ee.hasMoreElements()) { + String k = (String) ee.nextElement(); + Object v = session.getAttribute(k); + System.out.println("Session "+k+"="+v); + } + + if ("id".equalsIgnoreCase(additionalKey)) { + return session.getId(); + } else { + Object v = session.getAttribute(additionalKey); + if (v != null) { + return v.toString(); + } } } } @@ -119,7 +143,8 @@ case REQUEST_ATTRIBUTE: case COOKIE: if (additionalKey == null) { - addError("\"OptionalKey\" property is mandatory for field name "+fieldName.toString()); + addError("\"OptionalKey\" property is mandatory for field name " + + fieldName.toString()); errorCount++; } } @@ -141,7 +166,6 @@ return fieldName; } - public String getAdditionalKey() { return additionalKey; } @@ -176,5 +200,4 @@ this.key = key; } - }

1 0

svn commit: r2098 - logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/util
by noreply.ceki＠qos.ch 23 Dec '08

23 Dec '08

Author: ceki Date: Tue Dec 23 21:06:37 2008 New Revision: 2098 Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/util/ContextInitializer.java Log: It is possible for ContextInitializer (part of logback-classic) to be loaded by a different class loader than the class loaded that loaded c.q.l.core.Loader (part of logback-core). Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/util/ContextInitializer.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/util/ContextInitializer.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/util/ContextInitializer.java Tue Dec 23 21:06:37 2008 @@ -80,7 +80,7 @@ return url; } - url = Loader.getResourceBySelfClassLoader(TEST_AUTOCONFIG_FILE); + url = Loader.getResource(TEST_AUTOCONFIG_FILE, this.getClass().getClassLoader()); if (updateStatus) { statusOnResourceSearch(TEST_AUTOCONFIG_FILE, url); } @@ -88,7 +88,7 @@ return url; } - url = Loader.getResourceBySelfClassLoader(AUTOCONFIG_FILE); + url = Loader.getResource(AUTOCONFIG_FILE, this.getClass().getClassLoader()); if (updateStatus) { statusOnResourceSearch(AUTOCONFIG_FILE, url); }

1 0

svn commit: r2097 - logback-demo/trunk
by noreply.ceki＠qos.ch 23 Dec '08

23 Dec '08

Author: ceki Date: Tue Dec 23 20:04:00 2008 New Revision: 2097 Modified: logback-demo/trunk/pom.xml Log: test with logback 0.9.14-SNAPSHOT Modified: logback-demo/trunk/pom.xml ============================================================================== --- logback-demo/trunk/pom.xml (original) +++ logback-demo/trunk/pom.xml Tue Dec 23 20:04:00 2008 @@ -9,7 +9,7 @@ <version>1.0</version> <properties> - <lb.version>0.9.13</lb.version> + <lb.version>0.9.14-SNAPSHOT</lb.version> </properties>

1 0