- logback-dev - mailman3.qos.ch

[JIRA] Commented: (LBCLASSIC-57) SyslogAppender fails sporadically
by Anton Tagunov (JIRA) 14 Jul '08

14 Jul '08

[ http://jira.qos.ch/browse/LBCLASSIC-57?page=com.atlassian.jira.plugin.syste… ] Anton Tagunov commented on LBCLASSIC-57: ---------------------------------------- We've traced this down to a very long log message "killing" our logging. After we attempt to log a 1.85Mb message via SyslogAppender it stops working. What is surprising is that even configuration reload which recreates DatagramSocket does not help. It looks as if we messes up something in the data structures of libc on top of which jvm operates. > SyslogAppender fails sporadically > --------------------------------- > > Key: LBCLASSIC-57 > URL: http://jira.qos.ch/browse/LBCLASSIC-57 > Project: logback-classic > Issue Type: Bug > Environment: $ uname -a > Linux ... 2.6.9-67.ELsmp #1 SMP Wed Nov 7 13:56:44 EST 2007 x86_64 x86_64 x86_64 GNU/Linux > $ java -version > java version "1.6.0_03" > Java(TM) SE Runtime Environment (build 1.6.0_03-b05) > Java HotSpot(TM) Server VM (build 1.6.0_03-b05, mixed mode) > multiprocessor PC box > Reporter: Anton Tagunov > Assignee: Logback dev list > > * several JVM-s per Linux box > * 5 SyslogAppender-s logging to syslog-ng on 127.0.0.1 > Once in a while one of the SyslogAppender-s (the busiest one with longest messages) stops logging completely > Other SyslogAppender-ss continue working fine. > /usr/sbin/tcpdump has confirmed upd packets reach > syslog-ng port via 'lo' network interface for remaining appends > /usr/sbin/tcpdump has confirmed NO udp packets reach > syslog-ng port via 'lo' network interface for the failing appender > We have JMX enabled. JConsole does show StatusManager messages. > There are no error messages there. > Just the messages emitted during initial logback configuration > from logback.xml on the classpath. > We had invoked 'reload()' method via JMX. > StatusMananger messages observed via JMX show that reload had happened. > Full re-configuration had happened. > All 5 SyslogAppenders had been apparently re-created. > Yet NO udp messages had come from the SyslogAppender > replacing those which had previously failed. > Reloading did not help at all. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

svn commit: r1708 - logback/trunk
by noreply.ceki＠qos.ch 14 Jul '08

14 Jul '08

Author: ceki Date: Mon Jul 14 22:19:13 2008 New Revision: 1708 Modified: logback/trunk/pom.xml Log: - latest SLF4J release is 1.5.2 Modified: logback/trunk/pom.xml ============================================================================== --- logback/trunk/pom.xml (original) +++ logback/trunk/pom.xml Mon Jul 14 22:19:13 2008 @@ -36,7 +36,7 @@ <properties>  - <slf4j.version>1.5.0</slf4j.version> + <slf4j.version>1.5.2</slf4j.version> <consolePlugin.version>1.1.0</consolePlugin.version> <retrotranslator.verify>false</retrotranslator.verify> </properties>

1 0

svn commit: r1707 - logback/trunk/logback-site/src/site/pages
by noreply.ceki＠qos.ch 14 Jul '08

14 Jul '08

Author: ceki Date: Mon Jul 14 22:18:43 2008 New Revision: 1707 Modified: logback/trunk/logback-site/src/site/pages/download.html logback/trunk/logback-site/src/site/pages/news.html Log: - added blurb about LBCLASSIC-56 - added link to Lilith Modified: logback/trunk/logback-site/src/site/pages/download.html ============================================================================== --- logback/trunk/logback-site/src/site/pages/download.html (original) +++ logback/trunk/logback-site/src/site/pages/download.html Mon Jul 14 22:18:43 2008 @@ -78,6 +78,16 @@ classic. </dd> + + <dt> + <a href="http://lilith.huxhorn.de">Lilith</a> by Joern Huxhorn + </dt> + + <dd> + Lilith is a Logging- and AccessEvent viewer for LOGBack. + + </dd> + </dl> Modified: logback/trunk/logback-site/src/site/pages/news.html ============================================================================== --- logback/trunk/logback-site/src/site/pages/news.html (original) +++ logback/trunk/logback-site/src/site/pages/news.html Mon Jul 14 22:18:43 2008 @@ -43,6 +43,11 @@ prevents this. Documenation has been updated to reflect the change. + Fixed <a href="http://jira.qos.ch/browse/LBCLASSIC-56">bug + LBCLASSIC-56c</a> originally reported by Michel Colette. Backslash + characters are now correctly interpreted in filename patterns. + + The TurboFilterChain in a LoggerContext is <a href="http://svn.qos.ch/viewvc?view=rev&revision=1678">now cleared</a> when the shutdownAndReset method is called. This problem

1 0

svn commit: r1706 - in logback/trunk: logback-classic/src/main/java/org/slf4j/impl logback-core/src/main/java/ch/qos/logback/core logback-core/src/main/java/ch/qos/logback/core/joran/action logback-core/src/main/java/ch/qos/logback/core/pattern/parser logback-core/src/main/java/ch/qos/logback/core/pattern/util logback-core/src/main/java/ch/qos/logback/core/rolling/helper logback-core/src/main/java/ch/qos/logback/core/util logback-core/src/test/java/ch/qos/logback/core/pattern/parser logback-co
by noreply.ceki＠qos.ch 14 Jul '08

14 Jul '08

Author: ceki Date: Mon Jul 14 21:31:59 2008 New Revision: 1706 Added: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/util/AlmostAsIsEscapeUtil.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/util/IEscapeUtil.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/util/RegularEscapeUtil.java - copied, changed from r1704, /logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/util/EscapeUtil.java Removed: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/util/EscapeUtil.java Modified: logback/trunk/logback-classic/src/main/java/org/slf4j/impl/StaticLoggerBinder.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/CoreGlobal.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/PropertyAction.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/parser/OptionTokenizer.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/parser/Parser.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/parser/TokenStream.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/FileNamePattern.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/util/PropertySetter.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/TokenStreamTest.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/rolling/helper/FileNamePatternTest.java Log: - fixes LBCLASSIC-56 Escaping is implemented selectively. Cerated a new interface called EscapeUtil. In particular, FileNamePattern now uses AlmostAsIsEscapeUtil. See also http://jira.qos.ch/browse/LBCLASSIC-56 Modified: logback/trunk/logback-classic/src/main/java/org/slf4j/impl/StaticLoggerBinder.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/org/slf4j/impl/StaticLoggerBinder.java (original) +++ logback/trunk/logback-classic/src/main/java/org/slf4j/impl/StaticLoggerBinder.java Mon Jul 14 21:31:59 2008 @@ -86,7 +86,10 @@ } static ContextSelector dynamicalContextSelector( - LoggerContext defaultLoggerContext, String contextSelectorStr) throws ClassNotFoundException, SecurityException, NoSuchMethodException, IllegalArgumentException, InstantiationException, IllegalAccessException, InvocationTargetException { + LoggerContext defaultLoggerContext, String contextSelectorStr) + throws ClassNotFoundException, SecurityException, NoSuchMethodException, + IllegalArgumentException, InstantiationException, IllegalAccessException, + InvocationTargetException { Class contextSelectorClass = Loader.loadClass(contextSelectorStr); Constructor cons = contextSelectorClass .getConstructor(new Class[] { LoggerContext.class }); Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/CoreGlobal.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/CoreGlobal.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/CoreGlobal.java Mon Jul 14 21:31:59 2008 @@ -44,5 +44,8 @@ * An empty Class array. */ public final static Class[] EMPTY_CLASS_ARRAY = new Class[] {}; - static public final String CAUSED_BY = "Caused by: "; + public final static String CAUSED_BY = "Caused by: "; + + + public final static char PERCENT_CHAR = '%'; } Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/PropertyAction.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/PropertyAction.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/PropertyAction.java Mon Jul 14 21:31:59 2008 @@ -12,7 +12,7 @@ import org.xml.sax.Attributes; import ch.qos.logback.core.joran.spi.InterpretationContext; -import ch.qos.logback.core.pattern.util.EscapeUtil; +import ch.qos.logback.core.pattern.util.RegularEscapeUtil; import ch.qos.logback.core.util.OptionHelper; @@ -65,7 +65,7 @@ } else if ( !(OptionHelper.isEmpty(name) || OptionHelper.isEmpty(value)) && OptionHelper.isEmpty(fileName)) { - value = EscapeUtil.basicEscape(value); + value = RegularEscapeUtil.basicEscape(value); // now remove both leading and trailing spaces value = value.trim(); setProperty(ec, name, value); Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/parser/OptionTokenizer.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/parser/OptionTokenizer.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/parser/OptionTokenizer.java Mon Jul 14 21:31:59 2008 @@ -3,7 +3,9 @@ import java.util.ArrayList; import java.util.List; -import ch.qos.logback.core.pattern.util.EscapeUtil; +import ch.qos.logback.core.CoreGlobal; +import ch.qos.logback.core.pattern.util.IEscapeUtil; +import ch.qos.logback.core.pattern.util.RegularEscapeUtil; public class OptionTokenizer { @@ -16,15 +18,26 @@ private static final char DOUBLE_QUOTE_CHAR = '"'; private static final char SINGLE_QUOTE_CHAR = '\''; - String pattern; - int patternLength; + final String pattern; + final int patternLength; + final IEscapeUtil escapeUtil; + char quoteChar; int pointer = 0; int state = EXPECTING_STATE; + /** + * This variant is used in tests + * @param pattern + */ OptionTokenizer(String pattern) { + this(pattern, new RegularEscapeUtil()); + } + + OptionTokenizer(String pattern, IEscapeUtil escapeUtil) { this.pattern = pattern; patternLength = pattern.length(); + this.escapeUtil = escapeUtil; } List tokenize() throws ScanException { @@ -96,7 +109,7 @@ void escape(String escapeChars, StringBuffer buf) { if ((pointer < patternLength)) { char next = pattern.charAt(pointer++); - EscapeUtil.escape(escapeChars, buf, next, pointer); + escapeUtil.escape(escapeChars, buf, next, pointer); } } } \ No newline at end of file Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/parser/Parser.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/parser/Parser.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/parser/Parser.java Mon Jul 14 21:31:59 2008 @@ -5,6 +5,8 @@ import ch.qos.logback.core.pattern.Converter; import ch.qos.logback.core.pattern.FormatInfo; +import ch.qos.logback.core.pattern.util.IEscapeUtil; +import ch.qos.logback.core.pattern.util.RegularEscapeUtil; import ch.qos.logback.core.spi.ContextAwareBase; @@ -12,14 +14,21 @@ final List tokenList; int pointer = 0; + IEscapeUtil escapeUtil; Parser(TokenStream ts) throws ScanException { this.tokenList = ts.tokenize(); } + // this variant should be used for testing purposes only public Parser(String pattern) throws ScanException { + this(pattern, new RegularEscapeUtil()); + } + + public Parser(String pattern, IEscapeUtil escapeUtil) throws ScanException { + this.escapeUtil = escapeUtil; try { - TokenStream ts = new TokenStream(pattern); + TokenStream ts = new TokenStream(pattern, escapeUtil); this.tokenList = ts.tokenize(); } catch (NullPointerException npe) { throw new ScanException("Failed to initialize Parser", npe); Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/parser/TokenStream.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/parser/TokenStream.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/parser/TokenStream.java Mon Jul 14 21:31:59 2008 @@ -12,7 +12,11 @@ import java.util.List; import java.util.ArrayList; -import ch.qos.logback.core.pattern.util.EscapeUtil; +import ch.qos.logback.core.CoreGlobal; +import ch.qos.logback.core.pattern.util.IEscapeUtil; +import ch.qos.logback.core.pattern.util.RegularEscapeUtil; + + /** * Return a steady stream of tokens. @@ -29,7 +33,7 @@ class TokenStream { private static final char ESCAPE_CHAR = '\\'; - private static final char PERCENT_CHAR = '%'; + private static final char PERCENT_CHAR = CoreGlobal.PERCENT_CHAR; private static final char LEFT_PARENTHESIS = '('; private static final char RIGHT_PARENTHESIS = ')'; private static final char CURLY_LEFT = '{'; @@ -42,15 +46,23 @@ final String pattern; final int patternLength; + final IEscapeUtil escapeUtil; + int state = LITERAL_STATE; int pointer = 0; + // this variant should be used for testing purposes only TokenStream(String pattern) { + this(pattern, new RegularEscapeUtil()); + } + + TokenStream(String pattern, IEscapeUtil escapeUtil) { if(pattern == null) { throw new NullPointerException("null pattern string not allowed"); } this.pattern = pattern; patternLength = pattern.length(); + this.escapeUtil = escapeUtil; } List tokenize() throws ScanException { @@ -133,7 +145,7 @@ } else if (c == ESCAPE_CHAR) { if ((pointer < patternLength)) { char next = pattern.charAt(pointer++); - EscapeUtil.escape("%()", buf, next, pointer); + escapeUtil.escape("%()", buf, next, pointer); } } else { buf.append(c); @@ -167,7 +179,7 @@ void escape(String escapeChars, StringBuffer buf) { if ((pointer < patternLength)) { char next = pattern.charAt(pointer++); - EscapeUtil.escape(escapeChars, buf, next, pointer); + escapeUtil.escape(escapeChars, buf, next, pointer); } } Added: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/util/AlmostAsIsEscapeUtil.java ============================================================================== --- (empty file) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/util/AlmostAsIsEscapeUtil.java Mon Jul 14 21:31:59 2008 @@ -0,0 +1,40 @@ +package ch.qos.logback.core.pattern.util; + +import ch.qos.logback.core.CoreGlobal; +import ch.qos.logback.core.rolling.helper.FileNamePattern; + +/** + * This implementation is intended for use in {@link FileNamePattern}. + * + * @author Ceki Gülcü + */ +public class AlmostAsIsEscapeUtil implements IEscapeUtil { + + /** + * Do not perform any character escaping, except for '%'. + * + * + * Here is the rationale. First, filename patterns do not include escape + * combinations such as \r or \n. Moreover, characters which have special + * meaning in logback parsers, such as '(', ')', '{', or '}' cannot be part of + * file names (so me thinks). Thus, the only character that needs escaping is + * '%'. + * + * + * Note that this method assumes that it is called after the escape character + * has been consumed. + */ + public void escape(String escapeChars, StringBuffer buf, char next, + int pointer) { + + if (next == CoreGlobal.PERCENT_CHAR) { + buf.append(CoreGlobal.PERCENT_CHAR); + } else { + // restitute the escape char (because it was consumed + // before this method was called). + buf.append("\\"); + // restitute the next character + buf.append(next); + } + } +} Added: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/util/IEscapeUtil.java ============================================================================== --- (empty file) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/util/IEscapeUtil.java Mon Jul 14 21:31:59 2008 @@ -0,0 +1,6 @@ +package ch.qos.logback.core.pattern.util; + +public interface IEscapeUtil { + + void escape(String additionalEscapeChars, StringBuffer buf, char next, int pointer); +} \ No newline at end of file Copied: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/util/RegularEscapeUtil.java (from r1704, /logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/util/EscapeUtil.java) ============================================================================== --- /logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/util/EscapeUtil.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/pattern/util/RegularEscapeUtil.java Mon Jul 14 21:31:59 2008 @@ -1,8 +1,13 @@ package ch.qos.logback.core.pattern.util; -public class EscapeUtil { +/** + * This implementation is intended for use in PatternLayout. + * + * @author Ceki Gülcü + */ +public class RegularEscapeUtil implements IEscapeUtil { - public static void escape(String escapeChars, StringBuffer buf, char next, + public void escape(String escapeChars, StringBuffer buf, char next, int pointer) { if (escapeChars.indexOf(next) >= 0) { buf.append(next); @@ -24,16 +29,21 @@ buf.append('\n'); break; default: - String echars = ""; - for (int i = 0; i < escapeChars.length(); i++) { - echars += ", \\" + escapeChars.charAt(i); - } + String commaSeperatedEscapeChars = formatEscapeCharsForListing(escapeChars); new IllegalArgumentException("Illegal char '" + next + " at column " - + pointer + ". Only \\\\, \\_" + echars + + pointer + ". Only \\\\, \\_" + commaSeperatedEscapeChars + ", \\t, \\n, \\r combinations are allowed as escape characters."); } } + String formatEscapeCharsForListing(String escapeChars) { + String commaSeperatedEscapeChars = ""; + for (int i = 0; i < escapeChars.length(); i++) { + commaSeperatedEscapeChars += ", \\" + escapeChars.charAt(i); + } + return commaSeperatedEscapeChars; + } + public static String basicEscape(String s) { char c; int len = s.length(); Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/FileNamePattern.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/FileNamePattern.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/helper/FileNamePattern.java Mon Jul 14 21:31:59 2008 @@ -20,6 +20,7 @@ import ch.qos.logback.core.pattern.parser.Node; import ch.qos.logback.core.pattern.parser.Parser; import ch.qos.logback.core.pattern.parser.ScanException; +import ch.qos.logback.core.pattern.util.AlmostAsIsEscapeUtil; import ch.qos.logback.core.spi.ContextAwareBase; @@ -52,7 +53,7 @@ void parse() { try { - Parser<Object> p = new Parser<Object>(pattern); + Parser<Object> p = new Parser<Object>(pattern, new AlmostAsIsEscapeUtil()); p.setContext(context); Node t = p.parse(); this.headTokenConverter = p.compile(t, CONVERTER_MAP); Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/util/PropertySetter.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/util/PropertySetter.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/util/PropertySetter.java Mon Jul 14 21:31:59 2008 @@ -22,6 +22,7 @@ import java.beans.Introspector; import java.beans.MethodDescriptor; import java.beans.PropertyDescriptor; +import java.lang.reflect.Constructor; import java.lang.reflect.Method; import ch.qos.logback.core.spi.ContextAwareBase; @@ -247,6 +248,20 @@ } } } + + <T> boolean isUnequivocallyInstantiable(Class<T> clazz) { + if(clazz.isInterface()) { + return false; + } + try { + Constructor<T> pubConstructor = clazz.getConstructor(); + return true; + } catch (SecurityException e) { + return false; + } catch (NoSuchMethodException e) { + return false; + } + } public Class getObjClass() { return objClass; Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/TokenStreamTest.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/TokenStreamTest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/pattern/parser/TokenStreamTest.java Mon Jul 14 21:31:59 2008 @@ -10,14 +10,12 @@ package ch.qos.logback.core.pattern.parser; -import junit.framework.*; - -import java.util.List; import java.util.ArrayList; +import java.util.List; -import ch.qos.logback.core.pattern.parser.ScanException; -import ch.qos.logback.core.pattern.parser.Token; -import ch.qos.logback.core.pattern.parser.TokenStream; +import ch.qos.logback.core.pattern.util.AlmostAsIsEscapeUtil; + +import junit.framework.TestCase; public class TokenStreamTest extends TestCase { @@ -317,6 +315,18 @@ witness.add(new Token(Token.LITERAL, ")")); assertEquals(witness, tl); } + } + public void testWindowsLikeBackSlashes() throws ScanException { + { + List tl = new TokenStream("c:\\hello\\world.%i", new AlmostAsIsEscapeUtil()) + .tokenize(); + + List<Token> witness = new ArrayList<Token>(); + witness.add(new Token(Token.LITERAL, "c:\\hello\\world.")); + witness.add(Token.PERCENT_TOKEN); + witness.add(new Token(Token.KEYWORD, "i")); + assertEquals(witness, tl); + } } } \ No newline at end of file Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/rolling/helper/FileNamePatternTest.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/rolling/helper/FileNamePatternTest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/rolling/helper/FileNamePatternTest.java Mon Jul 14 21:31:59 2008 @@ -20,35 +20,33 @@ import ch.qos.logback.core.rolling.helper.FileNamePattern; import ch.qos.logback.core.util.StatusPrinter; - - /** * @author Ceki - * + * */ public class FileNamePatternTest extends TestCase { - + Context context = new ContextBase(); - + public FileNamePatternTest(String arg) { super(arg); } - - public void test1() { - //System.out.println("Testing [t]"); + + + public void testSmoke() { + // System.out.println("Testing [t]"); FileNamePattern pp = new FileNamePattern("t", context); assertEquals("t", pp.convertInt(3)); - //System.out.println("Testing [foo]"); + // System.out.println("Testing [foo]"); pp = new FileNamePattern("foo", context); assertEquals("foo", pp.convertInt(3)); - //System.out.println("Testing [foo%]"); - //pp = new FileNamePattern("foo%", context); - //StatusPrinter.print(context.getStatusManager()); - //assertEquals("foo%", pp.convertInt(3)); - - + // System.out.println("Testing [foo%]"); + // pp = new FileNamePattern("foo%", context); + // StatusPrinter.print(context.getStatusManager()); + // assertEquals("foo%", pp.convertInt(3)); + pp = new FileNamePattern("%i foo", context); StatusPrinter.print(context.getStatusManager()); assertEquals("3 foo", pp.convertInt(3)); @@ -62,7 +60,6 @@ pp = new FileNamePattern("foo.%i.log", context); assertEquals("foo.3.log", pp.convertInt(3)); - pp = new FileNamePattern("%i.foo\\%", context); assertEquals("3.foo%", pp.convertInt(3)); @@ -70,15 +67,21 @@ assertEquals("%foo", pp.convertInt(3)); } - public void test2() { - //System.out.println("Testing [foo%ibar%i]"); - - FileNamePattern pp = new FileNamePattern("foo%i\\_bar%i", context); - assertEquals("foo3bar3", pp.convertInt(3)); - + // test ways for dealing with flowing i converter, as in "foo%ix" + public void testFlowingI() { + // System.out.println("Testing [foo%ibar%i]"); + + { + FileNamePattern pp = new FileNamePattern("foo%i{}bar%i", context); + assertEquals("foo3bar3", pp.convertInt(3)); + } + { + FileNamePattern pp = new FileNamePattern("foo%i{}bar%i", context); + assertEquals("foo3bar3", pp.convertInt(3)); + } } - public void test3() { + public void testDate() { Calendar cal = Calendar.getInstance(); cal.set(2003, 4, 20, 17, 55); @@ -90,15 +93,20 @@ assertEquals("foo2003.05.20 17:55", pp.convertDate(cal.getTime())); pp = new FileNamePattern("%d{yyyy.MM.dd HH:mm} foo", context); - assertEquals("2003.05.20 17:55 foo", pp.convertDate(cal.getTime())); + assertEquals("2003.05.20 17:55 foo", pp.convertDate(cal.getTime())); } + + public void testWithBackslash() { + FileNamePattern pp = new FileNamePattern("c:\\foo\\bar.%i", context); + assertEquals("c:\\foo\\bar.3", pp.convertInt(3)); + } public static Test xsuite() { TestSuite suite = new TestSuite(); suite.addTest(new FileNamePatternTest("test1")); suite.addTest(new FileNamePatternTest("test2")); - //suite.addTest(new FileNamePatternTestCase("test3")); + // suite.addTest(new FileNamePatternTestCase("test3")); return suite; }

1 0

svn commit: r1705 - logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action
by noreply.ceki＠qos.ch 14 Jul '08

14 Jul '08

Author: ceki Date: Mon Jul 14 18:24:21 2008 New Revision: 1705 Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/NestedComponentIA.java Log: minor change in comments (TODO instead of FIXME) Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/NestedComponentIA.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/NestedComponentIA.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/NestedComponentIA.java Mon Jul 14 18:24:21 2008 @@ -102,7 +102,7 @@ // "About to instantiate component [{}] of type [{}]", localName, // className); - // FIXME: Loading classes should be governed by config file rules. + // TODO: Loading classes should be governed by config file rules. actionData.nestedComponent = Loader.loadClass(className, context).newInstance();

1 0

Testing, please ignore
by Ceki Gulcu 26 Jun '08

26 Jun '08

Hello, OK, so contrary to what the subject line says, you are actually reading this message. :-) The main QOS.ch server crashed due to a permanent failure of its hard drive. We are in the process of reconstructing the server on a brand new machine using data available from backups. This message is to test that the logback-dev mailing list is again operational. Cheers, -- Ceki Gülcü QOS.ch is looking to hire talented developers located in Switzerland. If interested, please contact c e k i AT q o s . c h

1 0

What's the exact difference between File and Presentation Header?
by Lilianne E. Blaze 23 Jun '08

23 Jun '08

Hello, I'm trying to write a custom Layout, I have it pretty much planned, but there's one thing I don't know - what's the exact difference between FileHeader and PresentationHeader? As in - which one is meant for what exactly? Neither the source nor Google were clear on that. Greetings, Lilianne

1 0

[JIRA] Commented: (LBCORE-43) support looking up property files from classpath resources
by Eduardo Ito (JIRA) 22 Jun '08

22 Jun '08

[ http://jira.qos.ch/browse/LBCORE-43?page=com.atlassian.jira.plugin.system.i… ] Eduardo Ito commented on LBCORE-43: ----------------------------------- I've implemented it as sugested. The affected files are listed below and are attached in a zip file. logback-core/src/main/java/ch/qos/logback/core/joran/action/Action.java logback-core/src/main/java/ch/qos/logback/core/joran/action/PropertyAction.java logback-core/src/test/java/ch/qos/logback/core/joran/action/PropertyActionTest.java logback-core/src/test/resources/input/joran/propertyActionTest.properties Could some core developer review it, and if there is no problem, and commit it? I would like to see it in the next release. > support looking up property files from classpath resources > ---------------------------------------------------------- > > Key: LBCORE-43 > URL: http://jira.qos.ch/browse/LBCORE-43 > Project: logback-core > Issue Type: Bug > Components: Joran > Affects Versions: unspecified > Environment: Operating System: Linux > Platform: PC > Reporter: Bruno Navert > Assignee: Logback dev list > Attachments: res.zip > > > Joran's support for property files (through PropertyAction) is useful, but it only reads filesystem files. It would be useful to be able to read classpath resources, that way the logback.xml file as well as its properties files would be located in the same place (in the class path). > Furthermore, it would be useful for both resource and file lookups to perform system property resolution in the included file names. > For instance: > <substitutionProperty resource="config/logback/logback-${CONFIG_MODE}.properties"/> > where CONFIG_MODE is a system property. In our environment this is set to something like DEV or QA or PROD, which would allow use of substitution properties that change based on the environment. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[JIRA] Updated: (LBCORE-43) support looking up property files from classpath resources
by Eduardo Ito (JIRA) 22 Jun '08

22 Jun '08

[ http://jira.qos.ch/browse/LBCORE-43?page=com.atlassian.jira.plugin.system.i… ] Eduardo Ito updated LBCORE-43: ------------------------------ Attachment: res.zip > support looking up property files from classpath resources > ---------------------------------------------------------- > > Key: LBCORE-43 > URL: http://jira.qos.ch/browse/LBCORE-43 > Project: logback-core > Issue Type: Bug > Components: Joran > Affects Versions: unspecified > Environment: Operating System: Linux > Platform: PC > Reporter: Bruno Navert > Assignee: Logback dev list > Attachments: res.zip > > > Joran's support for property files (through PropertyAction) is useful, but it only reads filesystem files. It would be useful to be able to read classpath resources, that way the logback.xml file as well as its properties files would be located in the same place (in the class path). > Furthermore, it would be useful for both resource and file lookups to perform system property resolution in the included file names. > For instance: > <substitutionProperty resource="config/logback/logback-${CONFIG_MODE}.properties"/> > where CONFIG_MODE is a system property. In our environment this is set to something like DEV or QA or PROD, which would allow use of substitution properties that change based on the environment. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

1 0

[Bug 1] Appender interface managing Layouts?
by bugzilla-daemon＠pixie.qos.ch 09 Jun '08

09 Jun '08

show_bug.cgi?id=1 Ceki Gulcu <noreply.ceki(a)qos.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|noreply.ceki(a)qos.ch | --- Comment #2 from Ceki Gulcu <noreply.ceki(a)qos.ch> 2008-06-09 16:46:16 --- editing should fail -- Configure bugmail: userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 0