- logback-dev - mailman3.qos.ch

[Bug 135] New: FixedWindowRollingPolicy MAX_WINDOW_SIZE too small?
by bugzilla-daemon＠pixie.qos.ch 08 Mar '08

08 Mar '08

http://bugzilla.qos.ch/show_bug.cgi?id=135 Summary: FixedWindowRollingPolicy MAX_WINDOW_SIZE too small? Product: logback-core Version: unspecified Platform: All OS/Version: Windows Status: NEW Severity: enhancement Priority: P5 Component: Rolling AssignedTo: logback-dev(a)qos.ch ReportedBy: Michael_Mansell(a)yahoo.com I know it's not a blog but let me first say I've switched from log time use of JCL / log4j and think SLF4J / Logback is awesome so kudos to you guys for getting this out here... simple and powerful.. not much to not like ;-) I'm curious as to why a window size as small as 12 was chosen here. I realize the renaming of all files within the window gets more expensive as the window increases but it seems prohibitive for people with larger logging requirements. Moreover, the fact that it is final means I can't override this either although I realize it is rather trivial to build my own implementation. I have a project that generates a tremendous amount of logging currently (about 100MB every 6 minutes) and in my current setup have issues with files over 2GB. With the current MAX_WINDOW_SIZE I can only keep a days worth of logs! If the rename is a big deal a rolling policy that just uses the index as a cyclic sequence should work fine or are there other reasons to cap this at something so low? I could submit an implementation back if you like but just curious to get your feedback and any reasoning I might be missing on keeping the window size so low. Thanks again for a great product! -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 0

svn commit: r1634 - logback/trunk/logback-core/src/test/input/joran/implcitAction
by noreply.ceki＠qos.ch 05 Mar '08

05 Mar '08

Author: ceki Date: Wed Mar 5 14:32:06 2008 New Revision: 1634 Added: logback/trunk/logback-core/src/test/input/joran/implcitAction/ logback/trunk/logback-core/src/test/input/joran/implcitAction/nestedComponent.xml logback/trunk/logback-core/src/test/input/joran/implcitAction/nestedComponentCollection.xml Log: - added a new test, checking the configuration of nested collection of complex objects Added: logback/trunk/logback-core/src/test/input/joran/implcitAction/nestedComponent.xml ============================================================================== --- (empty file) +++ logback/trunk/logback-core/src/test/input/joran/implcitAction/nestedComponent.xml Wed Mar 5 14:32:06 2008 @@ -0,0 +1,9 @@ +<?xml version="1.0" encoding="UTF-8" ?> + +<context> + <fruit class="ch.qos.logback.core.joran.implicitAction.Fruit"> + <name>blue</name> + <text>hello</text> + <text>world</text> + </fruit> +</context> \ No newline at end of file Added: logback/trunk/logback-core/src/test/input/joran/implcitAction/nestedComponentCollection.xml ============================================================================== --- (empty file) +++ logback/trunk/logback-core/src/test/input/joran/implcitAction/nestedComponentCollection.xml Wed Mar 5 14:32:06 2008 @@ -0,0 +1,17 @@ +<?xml version="1.0" encoding="UTF-8" ?> + +<context> + <fruit class="ch.qos.logback.core.joran.implicitAction.Fruit"> + <name>blue</name> + <text>hello</text> + <text>world</text> + <cake class="ch.qos.logback.core.joran.implicitAction.Cake"> + <type>A</type> + <code>1</code> + </cake> + <cake class="ch.qos.logback.core.joran.implicitAction.Cake"> + <type>B</type> + <code>2</code> + </cake> + </fruit> +</context> \ No newline at end of file

1 0

svn commit: r1633 - in logback/trunk/logback-core/src/test: input/joran java/ch/qos/logback/core/joran/implicitAction
by noreply.ceki＠qos.ch 05 Mar '08

05 Mar '08

Author: ceki Date: Wed Mar 5 14:31:06 2008 New Revision: 1633 Added: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/Cake.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/ImplicitActionTest.java - copied, changed from r1632, /logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/SimplePropertyIATest.java Removed: logback/trunk/logback-core/src/test/input/joran/simplePropertyIA1.xml logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/SimplePropertyIATest.java Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/Fruit.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/PackageTest.java Log: - added a new test, checking the configuration of nested collection of complex objects Added: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/Cake.java ============================================================================== --- (empty file) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/Cake.java Wed Mar 5 14:31:06 2008 @@ -0,0 +1,22 @@ +package ch.qos.logback.core.joran.implicitAction; + +public class Cake { + + String type; + int code; + + public String getType() { + return type; + } + public void setType(String type) { + this.type = type; + } + public int getCode() { + return code; + } + public void setCode(int code) { + this.code = code; + } + + +} Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/Fruit.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/Fruit.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/Fruit.java Wed Mar 5 14:31:06 2008 @@ -7,6 +7,7 @@ String name; List<String> textList = new ArrayList<String>(); + List<Cake> cakeList = new ArrayList<Cake>(); public Fruit() { } @@ -23,4 +24,7 @@ textList.add(s); } + public void addCake(Cake c) { + cakeList.add(c); + } } Copied: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/ImplicitActionTest.java (from r1632, /logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/SimplePropertyIATest.java) ============================================================================== --- /logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/SimplePropertyIATest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/ImplicitActionTest.java Wed Mar 5 14:31:06 2008 @@ -1,42 +1,44 @@ package ch.qos.logback.core.joran.implicitAction; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertNotNull; + import java.util.HashMap; import java.util.List; -import junit.framework.TestCase; +import org.junit.Before; +import org.junit.Test; + import ch.qos.logback.core.joran.SimpleConfigurator; import ch.qos.logback.core.joran.action.Action; import ch.qos.logback.core.joran.spi.Pattern; import ch.qos.logback.core.util.Constants; import ch.qos.logback.core.util.StatusPrinter; -public class SimplePropertyIATest extends TestCase { +public class ImplicitActionTest { + static final String IMPLCIT_DIR = Constants.TEST_DIR_PREFIX +"input/joran/implicitAction/"; + FruitContext fruitContext = new FruitContext(); + SimpleConfigurator simpleConfigurator; - public SimplePropertyIATest(String arg0) { - super(arg0); + public ImplicitActionTest() { } - protected void setUp() throws Exception { - super.setUp(); + @Before + public void setUp() throws Exception { fruitContext.setName("fruits"); + HashMap<Pattern, Action> rulesMap = new HashMap<Pattern, Action>(); + rulesMap.put(new Pattern("/context/"), new FruitContextAction()); + simpleConfigurator = new SimpleConfigurator(rulesMap); + simpleConfigurator.setContext(fruitContext); } - protected void tearDown() throws Exception { - super.tearDown(); - } - - public void test() throws Exception { + @Test + public void nested() throws Exception { try { - HashMap<Pattern, Action> rulesMap = new HashMap<Pattern, Action>(); - rulesMap.put(new Pattern("/context/"), new FruitContextAction()); - SimpleConfigurator simpleConfigurator = new SimpleConfigurator(rulesMap); - - simpleConfigurator.setContext(fruitContext); - - simpleConfigurator.doConfigure(Constants.TEST_DIR_PREFIX + "input/joran/" - + "simplePropertyIA1.xml"); + simpleConfigurator.doConfigure(IMPLCIT_DIR + "nestedComponent.xml"); + List<Fruit> fList = fruitContext.getFruitList(); assertNotNull(fList); assertEquals(1, fList.size()); @@ -46,11 +48,35 @@ assertEquals(2, f0.textList.size()); assertEquals("hello", f0.textList.get(0)); assertEquals("world", f0.textList.get(1)); + } catch (Exception je) { StatusPrinter.print(fruitContext); throw je; } } + @Test + public void nestedCollection() throws Exception { + try { + simpleConfigurator.doConfigure(IMPLCIT_DIR + "nestedComponentCollection.xml"); + + List<Fruit> fList = fruitContext.getFruitList(); + assertNotNull(fList); + assertEquals(1, fList.size()); + + Fruit f0 = fList.get(0); + assertEquals(2, f0.cakeList.size()); + + Cake cakeA = f0.cakeList.get(0); + assertEquals("A", cakeA.getType()); + + Cake cakeB = f0.cakeList.get(1); + assertEquals("B", cakeB.getType()); + + } catch (Exception je) { + StatusPrinter.print(fruitContext); + throw je; + } + } } Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/PackageTest.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/PackageTest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/PackageTest.java Wed Mar 5 14:31:06 2008 @@ -9,6 +9,7 @@ */ package ch.qos.logback.core.joran.implicitAction; +import junit.framework.JUnit4TestAdapter; import junit.framework.Test; import junit.framework.TestCase; import junit.framework.TestSuite; @@ -17,7 +18,7 @@ public static Test suite() { TestSuite suite = new TestSuite(); - suite.addTestSuite(SimplePropertyIATest.class); + suite.addTest(new JUnit4TestAdapter(ImplicitActionTest.class)); return suite; } }

1 0

svn commit: r1632 - in logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran: . action action/ext ia implicitAction
by noreply.ceki＠qos.ch 05 Mar '08

05 Mar '08

Author: ceki Date: Wed Mar 5 14:02:32 2008 New Revision: 1632 Added: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/ext/ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/ext/BadBeginAction.java - copied, changed from r1631, /logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/BadBeginAction.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/ext/BadEndAction.java - copied, changed from r1631, /logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/BadEndAction.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/ext/HelloAction.java - copied, changed from r1631, /logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/HelloAction.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/ext/IncAction.java - copied, changed from r1631, /logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/IncAction.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/ext/SoccerPlayer.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/ext/StackCounterAction.java - copied, changed from r1631, /logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/StackCounterAction.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/ext/TouchAction.java - copied, changed from r1631, /logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/TouchAction.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/ - copied from r1631, /logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/ia/ Removed: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/BadBeginAction.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/BadEndAction.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/HelloAction.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/IncAction.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/StackCounterAction.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/TouchAction.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/ia/ Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/PackageTest.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/SkippingInInterpreterTest.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/TrivialcConfiguratorTest.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/IncludeActionTest.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/Fruit.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/FruitContext.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/FruitContextAction.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/PackageTest.java logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/SimplePropertyIATest.java Log: - Moved certain test actions into c/q/l/core/joran/action/ext - renamed c.q.l.c.j.action.ia as c.q.l.c.j.action.implicitAction Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/PackageTest.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/PackageTest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/PackageTest.java Wed Mar 5 14:02:32 2008 @@ -23,7 +23,7 @@ suite.addTest(ch.qos.logback.core.joran.event.PackageTest.suite()); suite.addTest(ch.qos.logback.core.joran.spi.PackageTest.suite()); suite.addTest(ch.qos.logback.core.joran.replay.PackageTest.suite()); - suite.addTest(ch.qos.logback.core.joran.ia.PackageTest.suite()); + suite.addTest(ch.qos.logback.core.joran.implicitAction.PackageTest.suite()); return suite; } } Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/SkippingInInterpreterTest.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/SkippingInInterpreterTest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/SkippingInInterpreterTest.java Wed Mar 5 14:02:32 2008 @@ -20,11 +20,11 @@ import ch.qos.logback.core.Context; import ch.qos.logback.core.ContextBase; import ch.qos.logback.core.joran.action.Action; -import ch.qos.logback.core.joran.action.BadBeginAction; -import ch.qos.logback.core.joran.action.BadEndAction; -import ch.qos.logback.core.joran.action.HelloAction; import ch.qos.logback.core.joran.action.NOPAction; -import ch.qos.logback.core.joran.action.TouchAction; +import ch.qos.logback.core.joran.action.ext.BadBeginAction; +import ch.qos.logback.core.joran.action.ext.BadEndAction; +import ch.qos.logback.core.joran.action.ext.HelloAction; +import ch.qos.logback.core.joran.action.ext.TouchAction; import ch.qos.logback.core.joran.spi.Pattern; import ch.qos.logback.core.util.Constants; Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/TrivialcConfiguratorTest.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/TrivialcConfiguratorTest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/TrivialcConfiguratorTest.java Wed Mar 5 14:02:32 2008 @@ -16,7 +16,7 @@ import ch.qos.logback.core.Context; import ch.qos.logback.core.ContextBase; import ch.qos.logback.core.joran.action.Action; -import ch.qos.logback.core.joran.action.IncAction; +import ch.qos.logback.core.joran.action.ext.IncAction; import ch.qos.logback.core.joran.spi.Pattern; import ch.qos.logback.core.util.Constants; Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/IncludeActionTest.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/IncludeActionTest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/IncludeActionTest.java Wed Mar 5 14:02:32 2008 @@ -16,6 +16,7 @@ import ch.qos.logback.core.Context; import ch.qos.logback.core.ContextBase; import ch.qos.logback.core.joran.TrivialConfigurator; +import ch.qos.logback.core.joran.action.ext.IncAction; import ch.qos.logback.core.joran.spi.JoranException; import ch.qos.logback.core.joran.spi.Pattern; import ch.qos.logback.core.status.Status; Copied: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/ext/BadBeginAction.java (from r1631, /logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/BadBeginAction.java) ============================================================================== --- /logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/BadBeginAction.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/ext/BadBeginAction.java Wed Mar 5 14:02:32 2008 @@ -8,7 +8,7 @@ * Software Foundation. */ -package ch.qos.logback.core.joran.action; +package ch.qos.logback.core.joran.action.ext; import org.xml.sax.Attributes; Copied: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/ext/BadEndAction.java (from r1631, /logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/BadEndAction.java) ============================================================================== --- /logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/BadEndAction.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/ext/BadEndAction.java Wed Mar 5 14:02:32 2008 @@ -7,7 +7,7 @@ * the terms of the GNU Lesser General Public License as published by the Free * Software Foundation. */ -package ch.qos.logback.core.joran.action; +package ch.qos.logback.core.joran.action.ext; Copied: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/ext/HelloAction.java (from r1631, /logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/HelloAction.java) ============================================================================== --- /logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/HelloAction.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/ext/HelloAction.java Wed Mar 5 14:02:32 2008 @@ -7,7 +7,7 @@ * the terms of the GNU Lesser General Public License as published by the Free * Software Foundation. */ -package ch.qos.logback.core.joran.action; +package ch.qos.logback.core.joran.action.ext; import org.xml.sax.Attributes; Copied: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/ext/IncAction.java (from r1631, /logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/IncAction.java) ============================================================================== --- /logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/IncAction.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/ext/IncAction.java Wed Mar 5 14:02:32 2008 @@ -8,7 +8,7 @@ * Software Foundation. */ -package ch.qos.logback.core.joran.action; +package ch.qos.logback.core.joran.action.ext; import org.xml.sax.Attributes; Added: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/ext/SoccerPlayer.java ============================================================================== --- (empty file) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/ext/SoccerPlayer.java Wed Mar 5 14:02:32 2008 @@ -0,0 +1,21 @@ +package ch.qos.logback.core.joran.action.ext; + +public class SoccerPlayer { + String name; + int age; + + public String getName() { + return name; + } + public void setName(String name) { + this.name = name; + } + public int getAge() { + return age; + } + public void setAge(int age) { + this.age = age; + } + + +} Copied: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/ext/StackCounterAction.java (from r1631, /logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/StackCounterAction.java) ============================================================================== --- /logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/StackCounterAction.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/ext/StackCounterAction.java Wed Mar 5 14:02:32 2008 @@ -8,7 +8,7 @@ * Software Foundation. */ -package ch.qos.logback.core.joran.action; +package ch.qos.logback.core.joran.action.ext; import org.xml.sax.Attributes; Copied: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/ext/TouchAction.java (from r1631, /logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/TouchAction.java) ============================================================================== --- /logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/TouchAction.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/ext/TouchAction.java Wed Mar 5 14:02:32 2008 @@ -8,7 +8,7 @@ * Software Foundation. */ -package ch.qos.logback.core.joran.action; +package ch.qos.logback.core.joran.action.ext; import org.xml.sax.Attributes; Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/Fruit.java ============================================================================== --- /logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/ia/Fruit.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/Fruit.java Wed Mar 5 14:02:32 2008 @@ -1,4 +1,4 @@ -package ch.qos.logback.core.joran.ia; +package ch.qos.logback.core.joran.implicitAction; import java.util.ArrayList; import java.util.List; Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/FruitContext.java ============================================================================== --- /logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/ia/FruitContext.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/FruitContext.java Wed Mar 5 14:02:32 2008 @@ -1,4 +1,4 @@ -package ch.qos.logback.core.joran.ia; +package ch.qos.logback.core.joran.implicitAction; import java.util.ArrayList; import java.util.List; Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/FruitContextAction.java ============================================================================== --- /logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/ia/FruitContextAction.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/FruitContextAction.java Wed Mar 5 14:02:32 2008 @@ -8,7 +8,7 @@ * Software Foundation. */ -package ch.qos.logback.core.joran.ia; +package ch.qos.logback.core.joran.implicitAction; import org.xml.sax.Attributes; Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/PackageTest.java ============================================================================== --- /logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/ia/PackageTest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/PackageTest.java Wed Mar 5 14:02:32 2008 @@ -7,7 +7,7 @@ * the terms of the GNU Lesser General Public License as published by the Free * Software Foundation. */ -package ch.qos.logback.core.joran.ia; +package ch.qos.logback.core.joran.implicitAction; import junit.framework.Test; import junit.framework.TestCase; Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/SimplePropertyIATest.java ============================================================================== --- /logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/ia/SimplePropertyIATest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/implicitAction/SimplePropertyIATest.java Wed Mar 5 14:02:32 2008 @@ -1,4 +1,4 @@ -package ch.qos.logback.core.joran.ia; +package ch.qos.logback.core.joran.implicitAction; import java.util.HashMap; import java.util.List;

1 0

svn commit: r1631 - logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action
by noreply.ceki＠qos.ch 04 Mar '08

04 Mar '08

Author: ceki Date: Tue Mar 4 21:34:51 2008 New Revision: 1631 Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/IncludeActionTest.java Log: - minor changes Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/IncludeActionTest.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/IncludeActionTest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/IncludeActionTest.java Tue Mar 4 21:34:51 2008 @@ -66,16 +66,15 @@ @Before public void setUp() throws Exception { - IncAction.beginCount = 0; - IncAction.errorCount = 0; - IncAction.endCount = 0; + IncAction.reset(); } @After public void tearDown() throws Exception { context = null; System.clearProperty(INCLUDE_KEY); - IncAction.reset(); + System.clearProperty(SECOND_FILE_KEY); + System.clearProperty(SUB_FILE_KEY); } @Test

1 0

svn commit: r1630 - in logback/trunk/logback-classic: src/main/java/ch/qos/logback/classic/net src/test/java/ch/qos/logback/classic/net src/test/java/ch/qos/logback/classic/net/mock stylesheets
by noreply.ceki＠qos.ch 04 Mar '08

04 Mar '08

Author: ceki Date: Tue Mar 4 21:01:52 2008 New Revision: 1630 Removed: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net/mock/MockSocketServer.java logback/trunk/logback-classic/stylesheets/ Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/net/SimpleSocketServer.java logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net/SocketAppenderTest.java Log: - MockSocketServer is no longer needed for tests as SimpleSocketServer does the job - removing unused stylesheets directory Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/net/SimpleSocketServer.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/net/SimpleSocketServer.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/net/SimpleSocketServer.java Tue Mar 4 21:01:52 2008 @@ -9,6 +9,7 @@ */ package ch.qos.logback.classic.net; +import java.io.IOException; import java.net.ServerSocket; import java.net.Socket; @@ -23,17 +24,13 @@ * A simple {@link SocketNode} based server. * * <pre> - * Usage: java ch.qos.logback.classic.net.SimpleSocketServer port configFile - * - * where - * - * port - * - * is a part number where the server listens and - * - * configFile - * - * is an xml configuration file fed to {@link JoranConfigurator}. + * Usage: java ch.qos.logback.classic.net.SimpleSocketServer port configFile + * </pre> + * + * where port is a port number where the server listens and + * configFile is an xml configuration file fed to + * {@link JoranConfigurator}. + * * </pre> * * @author Ceki Gülcü @@ -41,36 +38,69 @@ * * @since 0.8.4 */ -public class SimpleSocketServer { +public class SimpleSocketServer extends Thread { - static Logger logger = LoggerFactory.getLogger(SimpleSocketServer.class); + Logger logger = LoggerFactory.getLogger(SimpleSocketServer.class); - static int port; + private final int port; + private final LoggerContext lc; + private boolean closed = false; + private ServerSocket serverSocket; public static void main(String argv[]) throws Exception { + int port = -1; if (argv.length == 2) { - init(argv[0], argv[1]); + port = parsePortNumber(argv[0]); } else { usage("Wrong number of arguments."); } - runServer(); + String configFile = argv[1]; + LoggerContext lc = (LoggerContext) LoggerFactory.getILoggerFactory(); + configureLC(lc, configFile); + + SimpleSocketServer sss = new SimpleSocketServer(lc, port); + sss.start(); } - static void runServer() { + public SimpleSocketServer(LoggerContext lc, int port) { + this.lc = lc; + this.port = port; + } + + public void run() { try { logger.info("Listening on port " + port); - ServerSocket serverSocket = new ServerSocket(port); - while (true) { + serverSocket = new ServerSocket(port); + while (!closed) { logger.info("Waiting to accept a new client."); Socket socket = serverSocket.accept(); logger.info("Connected to client at " + socket.getInetAddress()); logger.info("Starting new socket node."); - LoggerContext lc = (LoggerContext) LoggerFactory.getILoggerFactory(); new Thread(new SocketNode(socket, lc)).start(); } } catch (Exception e) { - e.printStackTrace(); + if(closed) { + logger.info("Exception in run method for a closed server. This is expected"); + } else { + logger.error("Failure in run method", e); + } + } + } + + + public boolean isClosed() { + return closed; + } + + public void close() { + closed = true; + if (serverSocket != null) { + try { + serverSocket.close(); + } catch (IOException e) { + logger.error("Failed to close serverSocket", e); + } } } @@ -81,21 +111,22 @@ System.exit(1); } - static void init(String portStr, String configFile) throws JoranException { + static int parsePortNumber(String portStr) { try { - port = Integer.parseInt(portStr); + return Integer.parseInt(portStr); } catch (java.lang.NumberFormatException e) { e.printStackTrace(); usage("Could not interpret port number [" + portStr + "]."); + // we won't get here + return -1; } + } - if (configFile.endsWith(".xml")) { - LoggerContext lc = (LoggerContext) LoggerFactory.getILoggerFactory(); - JoranConfigurator configurator = new JoranConfigurator(); - lc.shutdownAndReset(); - configurator.setContext(lc); - configurator.doConfigure(configFile); - //StatusPrinter.print(lc); - } + static public void configureLC(LoggerContext lc, String configFile) + throws JoranException { + JoranConfigurator configurator = new JoranConfigurator(); + lc.shutdownAndReset(); + configurator.setContext(lc); + configurator.doConfigure(configFile); } } Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net/SocketAppenderTest.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net/SocketAppenderTest.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/net/SocketAppenderTest.java Tue Mar 4 21:01:52 2008 @@ -20,18 +20,23 @@ import ch.qos.logback.classic.Level; import ch.qos.logback.classic.Logger; import ch.qos.logback.classic.LoggerContext; -import ch.qos.logback.classic.net.mock.MockSocketServer; import ch.qos.logback.classic.spi.LoggerContextRemoteView; import ch.qos.logback.classic.spi.LoggerRemoteView; import ch.qos.logback.classic.spi.LoggingEvent; +import ch.qos.logback.core.read.ListAppender; public class SocketAppenderTest extends TestCase { - private LoggerContext lc; - private MockSocketServer mockSocketServer; - + static final String LIST_APPENDER_NAME = "la"; + int port = 4560; + LoggerContext lc = new LoggerContext(); + LoggerContext serverLC = new LoggerContext(); + ListAppender<LoggingEvent> la = new ListAppender<LoggingEvent>(); + + //private MockSocketServer mockSocketServer; + private SimpleSocketServer simpleSocketServer; + public void testStartFailNoRemoteHost() { - lc = new LoggerContext(); SocketAppender appender = new SocketAppender(); appender.setContext(lc); appender.setPort(123); @@ -45,14 +50,17 @@ Logger logger = lc.getLogger(LoggerContext.ROOT_NAME); logger.debug("test msg"); - + + Thread.sleep(100); + // Wait max 2 seconds for mock server to finish. However, it should // finish much sooner than that. - mockSocketServer.join(2000); - assertTrue(mockSocketServer.isFinished()); - assertEquals(1, mockSocketServer.getEventsList().size()); + simpleSocketServer.close(); + simpleSocketServer.join(2000); + assertTrue(simpleSocketServer.isClosed()); + assertEquals(1, la.list.size()); - LoggingEvent remoteEvent = mockSocketServer.getEventsList().get(0); + LoggingEvent remoteEvent = la.list.get(0); assertEquals("test msg", remoteEvent.getMessage()); assertEquals(Level.DEBUG, remoteEvent.getLevel()); } @@ -66,11 +74,13 @@ // Wait max 2 seconds for mock server to finish. However, it should // finish much sooner than that. - mockSocketServer.join(2000); - assertTrue(mockSocketServer.isFinished()); - assertEquals(1, mockSocketServer.getEventsList().size()); + Thread.sleep(100); + simpleSocketServer.close(); + simpleSocketServer.join(2000); + assertTrue(simpleSocketServer.isClosed()); + assertEquals(1, la.list.size()); - LoggingEvent remoteEvent = mockSocketServer.getEventsList().get(0); + LoggingEvent remoteEvent = la.list.get(0); LoggerRemoteView loggerRemoteView = remoteEvent.getLoggerRemoteView(); assertNotNull(loggerRemoteView); @@ -95,11 +105,14 @@ // Wait max 2 seconds for mock server to finish. However, it should // finish much sooner than that. - mockSocketServer.join(2000); - assertTrue(mockSocketServer.isFinished()); - assertEquals(1, mockSocketServer.getEventsList().size()); + Thread.sleep(100); + simpleSocketServer.close(); + simpleSocketServer.join(2000); + assertTrue(simpleSocketServer.isClosed()); + ListAppender<LoggingEvent> la = getListAppender(); + assertEquals(1, la.list.size()); - LoggingEvent remoteEvent = mockSocketServer.getEventsList().get(0); + LoggingEvent remoteEvent = la.list.get(0); Map<String, String> MDCPropertyMap = remoteEvent.getMDCPropertyMap(); assertEquals("testValue", MDCPropertyMap.get("key")); } @@ -113,13 +126,16 @@ Marker marker = MarkerFactory.getMarker("testMarker"); logger.debug(marker, "test msg"); + Thread.sleep(100); + // Wait max 2 seconds for mock server to finish. However, it should // finish much sooner than that. - mockSocketServer.join(2000); - assertTrue(mockSocketServer.isFinished()); - assertEquals(1, mockSocketServer.getEventsList().size()); + simpleSocketServer.close(); + simpleSocketServer.join(2000); + assertTrue(simpleSocketServer.isClosed()); + assertEquals(1, la.list.size()); - LoggingEvent remoteEvent = mockSocketServer.getEventsList().get(0); + LoggingEvent remoteEvent = la.list.get(0); assertEquals("testMarker", remoteEvent.getMarker().getName()); } @@ -135,26 +151,44 @@ MDC.put("key", "updatedTestValue"); logger.debug("test msg 2"); + Thread.sleep(100); + // Wait max 2 seconds for mock server to finish. However, it should // finish much sooner than that. - mockSocketServer.join(2000); - assertTrue(mockSocketServer.isFinished()); - assertEquals(2, mockSocketServer.getEventsList().size()); + simpleSocketServer.close(); + simpleSocketServer.join(2000); + assertTrue(simpleSocketServer.isClosed()); + ListAppender<LoggingEvent> la = getListAppender(); + + assertEquals(2, la.list.size()); // We observe the second logging event. It should provide us with // the updated MDC property. - LoggingEvent remoteEvent = mockSocketServer.getEventsList().get(1); + LoggingEvent remoteEvent = la.list.get(1); Map<String, String> MDCPropertyMap = remoteEvent.getMDCPropertyMap(); assertEquals("updatedTestValue", MDCPropertyMap.get("key")); } private void startServer(int expectedNumberOfEvents) throws InterruptedException { - mockSocketServer = new MockSocketServer(expectedNumberOfEvents); - mockSocketServer.start(); + Logger root = serverLC.getLogger("root"); + la.setName(LIST_APPENDER_NAME); + la.setContext(serverLC); + la.start(); + root.addAppender(la); + simpleSocketServer = new SimpleSocketServer(serverLC, port); + simpleSocketServer.start(); + //mockSocketServer = new MockSocketServer(expectedNumberOfEvents); + //mockSocketServer.start(); // give MockSocketServer head start Thread.sleep(100); } + + ListAppender<LoggingEvent> getListAppender() { + Logger root = serverLC.getLogger("root"); + return (ListAppender<LoggingEvent>) root.getAppender(LIST_APPENDER_NAME); + } + private void configureClient() { lc = new LoggerContext(); lc.setName("test"); @@ -163,7 +197,7 @@ SocketAppender socketAppender = new SocketAppender(); socketAppender.setContext(lc); socketAppender.setName("socket"); - socketAppender.setPort(4560); + socketAppender.setPort(port); socketAppender.setRemoteHost("localhost"); root.addAppender(socketAppender); socketAppender.start();

1 0

[Bug 133] New: MDC content is not copied to child threads
by bugzilla-daemon＠pixie.qos.ch 04 Mar '08

04 Mar '08

http://bugzilla.qos.ch/show_bug.cgi?id=133 Summary: MDC content is not copied to child threads Product: logback-classic Version: unspecified Platform: All OS/Version: All Status: NEW Severity: critical Priority: P1 Component: Other AssignedTo: logback-dev(a)qos.ch ReportedBy: mfranz(a)intershop.de I havn't found neither at slf4j nor logback pages any information if a child thread inherits the MDC content of its parent thread when it is created. The log4j Javadoc of the MDC class states: "The MDC is managed on a per thread basis. A child thread automatically inherits a copy of the mapped diagnostic context of its parent." But with logback 0.9.8 the MDC is always empty for a new thread. Is there a reason for that? Within my application it only make sense if the child thread MDC is initially filled with content of the parent thread. Also for users of the log4j MDC this might be a critical issue preventing them from switching to logback. The LogbackMDCAdapter can easily be changed to achieve the inheriting feature: public class LogbackMDCAdapter implements MDCAdapter { private final InheritableThreadLocal<HashMap<String, String>> threadLocal = new InheritableThreadLocal<HashMap<String, String>>() { @Override @SuppressWarnings("unchecked") protected HashMap<String, String> childValue(HashMap<String, String> parentValue) { return (parentValue!=null) ? (HashMap<String, String>)parentValue.clone() : null; } }; ... } -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 2

svn commit: r1629 - logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action
by noreply.ceki＠qos.ch 04 Mar '08

04 Mar '08

Author: ceki Date: Tue Mar 4 19:04:20 2008 New Revision: 1629 Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/IncludeActionTest.java Log: - fixing bug #129 see also http://bugzilla.qos.ch/show_bug.cgi?id=129\ - refactored the IncludeAction for clarity - IncludeActionTest has been enhanced to check for bug 129 Modified: logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/IncludeActionTest.java ============================================================================== --- logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/IncludeActionTest.java (original) +++ logback/trunk/logback-core/src/test/java/ch/qos/logback/core/joran/action/IncludeActionTest.java Tue Mar 4 19:04:20 2008 @@ -22,33 +22,27 @@ import ch.qos.logback.core.status.StatusChecker; import ch.qos.logback.core.util.StatusPrinter; -public class IncludeActionTest { +public class IncludeActionTest { final static String INCLUDE_KEY = "includeKey"; final static String SUB_FILE_KEY = "subFileKey"; final static String SECOND_FILE_KEY = "secondFileKey"; - - + Context context = new ContextBase(); TrivialConfigurator tc; static final String INCLUSION_DIR_PREFIX = "src/test/input/joran/inclusion/"; - static final String TOP_BY_FILE = INCLUSION_DIR_PREFIX - + "topByFile.xml"; - - static final String SUB_FILE = INCLUSION_DIR_PREFIX - + "subByFile.xml"; - + static final String TOP_BY_FILE = INCLUSION_DIR_PREFIX + "topByFile.xml"; + + static final String SUB_FILE = INCLUSION_DIR_PREFIX + "subByFile.xml"; + static final String MULTI_INCLUDE_BY_FILE = INCLUSION_DIR_PREFIX - + "multiIncludeByFile.xml"; - - static final String SECOND_FILE = INCLUSION_DIR_PREFIX - + "second.xml"; - - - static final String TOP_BY_URL = INCLUSION_DIR_PREFIX - + "topByUrl.xml"; + + "multiIncludeByFile.xml"; + + static final String SECOND_FILE = INCLUSION_DIR_PREFIX + "second.xml"; + + static final String TOP_BY_URL = INCLUSION_DIR_PREFIX + "topByUrl.xml"; static final String INCLUDE_BY_RESOURCE = INCLUSION_DIR_PREFIX + "topByResource.xml"; @@ -100,7 +94,7 @@ } @Test - public void testBasicURL() throws JoranException { + public void testBasicURL() throws JoranException { System.setProperty(INCLUDE_KEY, URL_TO_INCLUDE); tc.doConfigure(TOP_BY_URL); StatusPrinter.print(context); @@ -152,7 +146,7 @@ verifyConfig(1); } - + @Test public void multiInclude() throws JoranException { System.setProperty(INCLUDE_KEY, INCLUDED_FILE); @@ -160,9 +154,7 @@ tc.doConfigure(MULTI_INCLUDE_BY_FILE); verifyConfig(3); } - - void verifyConfig(int expected) { assertEquals(expected, IncAction.beginCount); assertEquals(expected, IncAction.endCount);

1 0

[Bug 64] New: Logback MDC context is not inherited by child threads.
by bugzilla-daemon＠pixie.qos.ch 04 Mar '08

04 Mar '08

http://bugzilla.qos.ch/show_bug.cgi?id=64 Summary: Logback MDC context is not inherited by child threads. Product: logback-classic Version: unspecified Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: P1 Component: Other AssignedTo: logback-dev(a)qos.ch ReportedBy: bendis(a)bendis.cz As stated in the javadoc documentation, the ch.qos.logback.classic.MDC should be inherited by a child thread: "A child thread automatically inherits a copy of the mapped diagnostic context of its parent." But the context is NOT ihnerited by child threads - the context HashMap is stored in the ThreadLocal, not in the InheritableThreadLocal. Regards, Bendis -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 2

[Bug 127] New: LoggerComparator sorts incorrectly
by bugzilla-daemon＠pixie.qos.ch 04 Mar '08

04 Mar '08

http://bugzilla.qos.ch/show_bug.cgi?id=127 Summary: LoggerComparator sorts incorrectly Product: logback-classic Version: unspecified Platform: All OS/Version: All Status: NEW Severity: major Priority: P2 Component: Other AssignedTo: logback-dev(a)qos.ch ReportedBy: mark_z(a)charter.net ch.qos.logback.classic.spi.LoggerComparator doesn't work as intended, because it is violating the symmetric property and contract of java.util.Comparator.compare(T, T). While Logger l1 is checked against LoggerContext.ROOT_NAME, Logger l2 also needs to be checked. Current implementation: public int compare(Logger l1, Logger l2) { if (l1.getName().equals(LoggerContext.ROOT_NAME)) { return -1; } return l1.getName().compareTo(l2.getName()); } Corrected implementation: public int compare(Logger l1, Logger l2) { if(l1.getName().equals(LoggerContext.ROOT_NAME)){ return -1; } if(l2.getName().equals(LoggerContext.ROOT_NAME)){ return 1; } return l1.getName().compareTo(l2.getName()); } -- Configure bugmail: http://bugzilla.qos.ch/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

1 5