- logback-dev - mailman3.qos.ch

[continuum] BUILD FAILURE: Logback Access Module
by John Noreplai 29 Nov '06

29 Nov '06

Online report : http://localhost:8090/continuum/servlet/continuum/target/ProjectBuild.vm/vi… Build statistics: State: Failed Previous State: Failed Started at: Wed, 29 Nov 2006 11:00:19 +0100 Finished at: Wed, 29 Nov 2006 11:00:33 +0100 Total time: 14s Build Trigger: Schedule Exit code: 1 Building machine hostname: pixie Operating system : Linux(unknown) Java version : 1.5.0_08(Sun Microsystems Inc.) Changes seb Added an option to let the user choose if she wants to add the headers to the DB or not /logback/trunk/logback-access/src/main/java/ch/qos/logback/access/db/DBAppender.java /logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTestBase.java /logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/DBAppenderTestBase.java /logback/trunk/pom.xml **************************************************************************** Output: **************************************************************************** [INFO] Scanning for projects... [INFO] ---------------------------------------------------------------------------- [INFO] Building Logback Access Module [INFO] task-segment: [clean, install] [INFO] ---------------------------------------------------------------------------- [INFO] [clean:clean] [INFO] Deleting directory /opt/continuum-1.0.3/apps/continuum/working-directory/47/target [INFO] Deleting directory /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/classes [INFO] Deleting directory /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/test-classes [INFO] [resources:resources] [INFO] Using default encoding to copy filtered resources. Downloading: http://repo1.maven.org/maven2/hsqldb/hsqldb/1.8.0.7/hsqldb-1.8.0.7.pom 621b downloaded [INFO] [compiler:compile] Compiling 56 source files to /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/classes [INFO] [resources:testResources] [INFO] Using default encoding to copy filtered resources. Downloading: http://repo1.maven.org/maven2/hsqldb/hsqldb/1.8.0.7/hsqldb-1.8.0.7.jar 628K downloaded [INFO] [compiler:testCompile] Compiling 22 source files to /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/test-classes [INFO] [surefire:test] [INFO] Surefire report directory: /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/surefire-reports ------------------------------------------------------- T E S T S ------------------------------------------------------- Running ch.qos.logback.access.db.DBAppenderTest [Server@3c6f579]: [Thread[main,5,main]]: checkRunning(false) entered [Server@3c6f579]: [Thread[main,5,main]]: checkRunning(false) exited [Server@3c6f579]: [Thread[main,5,main]]: setDatabaseName(0,test) [Server@3c6f579]: [Thread[main,5,main]]: checkRunning(false) entered [Server@3c6f579]: [Thread[main,5,main]]: checkRunning(false) exited [Server@3c6f579]: [Thread[main,5,main]]: setDatabasePath(0,mem:test;sql.enforce_strict_size=true) [Server@7cf1bb78]: [Thread[main,5,main]]: checkRunning(false) entered [Server@7cf1bb78]: [Thread[main,5,main]]: checkRunning(false) exited [Server@7cf1bb78]: [Thread[main,5,main]]: setDatabaseName(0,test) [Server@7cf1bb78]: [Thread[main,5,main]]: checkRunning(false) entered [Server@7cf1bb78]: [Thread[main,5,main]]: checkRunning(false) exited [Server@7cf1bb78]: [Thread[main,5,main]]: setDatabasePath(0,mem:test;sql.enforce_strict_size=true) [Server@16aa37a6]: [Thread[main,5,main]]: checkRunning(false) entered [Server@16aa37a6]: [Thread[main,5,main]]: checkRunning(false) exited [Server@16aa37a6]: [Thread[main,5,main]]: setDatabaseName(0,test) [Server@16aa37a6]: [Thread[main,5,main]]: checkRunning(false) entered [Server@16aa37a6]: [Thread[main,5,main]]: checkRunning(false) exited [Server@16aa37a6]: [Thread[main,5,main]]: setDatabasePath(0,mem:test;sql.enforce_strict_size=true) Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.649 sec Running ch.qos.logback.access.jetty.JettyBasicTest 2006-11-29 11:00:32.034::INFO: Logging to STDERR via org.mortbay.log.StdErrLog 2006-11-29 11:00:32.082::INFO: jetty-6.0.x |-WARN in ch.qos.logback.access.jetty.RequestLogImpl@1de4f7c2 - filename property not set. Assuming [null/etc/logback-access.xml] |-ERROR in ch.qos.logback.access.jetty.RequestLogImpl@1de4f7c2 - [null/etc/logback-access.xml] does not exist |-INFO in ch.qos.logback.access.jetty.RequestLogImpl@1de4f7c2 - RequestLog added to RequestLogRegistry with name: LogbackRequestLog 2006-11-29 11:00:32.142::INFO: Started SelectChannelConnector @ 0.0.0.0:1234 29/11/2006:11:00:32 +0100 localhost 127.0.0.1 Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.279 sec <<< FAILURE! Running ch.qos.logback.access.filter.AccessStatsTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.009 sec Running ch.qos.logback.access.pattern.ConverterTest Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.023 sec Running ch.qos.logback.access.filter.StatsByDayTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.011 sec Running ch.qos.logback.access.net.URLEvaluatorTest Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.01 sec Running ch.qos.logback.access.net.SocketAppenderTest Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.128 sec Results : Tests run: 28, Failures: 0, Errors: 1, Skipped: 0 [INFO] ------------------------------------------------------------------------ [ERROR] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] There are test failures. [INFO] ------------------------------------------------------------------------ [INFO] For more information, run Maven with the -e switch [INFO] ------------------------------------------------------------------------ [INFO] Total time: 13 seconds [INFO] Finished at: Wed Nov 29 11:00:33 CET 2006 [INFO] Final Memory: 12M/142M [INFO] ------------------------------------------------------------------------ ****************************************************************************

1 0

svn commit: r1029 - in logback/trunk: . logback-access/src/main/java/ch/qos/logback/access/db logback-access/src/test/java/ch/qos/logback/access/db logback-classic/src/test/java/ch/qos/logback/classic/db
by noreply.seb＠qos.ch 29 Nov '06

29 Nov '06

Author: seb Date: Wed Nov 29 10:41:28 2006 New Revision: 1029 Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/db/DBAppender.java logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTestBase.java logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/DBAppenderTestBase.java logback/trunk/pom.xml Log: Added an option to let the user choose if she wants to add the headers to the DB or not Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/db/DBAppender.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/db/DBAppender.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/db/DBAppender.java Wed Nov 29 10:41:28 2006 @@ -35,6 +35,8 @@ protected final String insertHeaderSQL = "INSERT INTO access_event_header (event_id, header_key, header_value) VALUES (?, ?, ?)"; protected static final Method GET_GENERATED_KEYS_METHOD; + private boolean insertHeaders = false; + static { StringBuffer sql = new StringBuffer(); sql.append("INSERT INTO access_event ("); @@ -76,8 +78,10 @@ addWarn("Failed to insert access event"); } - int eventId = getEventId(insertStatement, connection); - addRequestHeaders(event, connection, eventId); + if (insertHeaders) { + int eventId = getEventId(insertStatement, connection); + addRequestHeaders(event, connection, eventId); + } } void addAccessEvent(PreparedStatement stmt, AccessEvent event) @@ -135,4 +139,8 @@ protected String getInsertSQL() { return insertSQL; } + + public void setInsertHeaders(boolean insertHeaders) { + this.insertHeaders = insertHeaders; + } } Modified: logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTestBase.java ============================================================================== --- logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTestBase.java (original) +++ logback/trunk/logback-access/src/test/java/ch/qos/logback/access/db/DBAppenderTestBase.java Wed Nov 29 10:41:28 2006 @@ -41,6 +41,8 @@ server.setDatabasePath(0, "mem:test;sql.enforce_strict_size=true"); server.setLogWriter(null); server.setErrWriter(null); + server.setTrace(false); + server.setSilent(true); server.start(); } else { if (url == null) { Modified: logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/DBAppenderTestBase.java ============================================================================== --- logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/DBAppenderTestBase.java (original) +++ logback/trunk/logback-classic/src/test/java/ch/qos/logback/classic/db/DBAppenderTestBase.java Wed Nov 29 10:41:28 2006 @@ -44,6 +44,8 @@ server.setDatabasePath(0, "mem:test;sql.enforce_strict_size=true"); server.setLogWriter(null); server.setErrWriter(null); + server.setTrace(false); + server.setSilent(true); server.start(); } else { if (url == null) { Modified: logback/trunk/pom.xml ============================================================================== --- logback/trunk/pom.xml (original) +++ logback/trunk/pom.xml Wed Nov 29 10:41:28 2006 @@ -89,7 +89,7 @@ <dependency> <groupId>hsqldb</groupId> <artifactId>hsqldb</artifactId> - <version>1.8.0.5</version> + <version>1.8.0.7</version> </dependency> <dependency> <groupId>tomcat</groupId>

1 0

[continuum] BUILD FAILURE: Logback Access Module
by John Noreplai 29 Nov '06

29 Nov '06

Online report : http://localhost:8090/continuum/servlet/continuum/target/ProjectBuild.vm/vi… Build statistics: State: Failed Previous State: Failed Started at: Wed, 29 Nov 2006 10:32:37 +0100 Finished at: Wed, 29 Nov 2006 10:32:50 +0100 Total time: 12s Build Trigger: Forced Exit code: 1 Building machine hostname: pixie Operating system : Linux(unknown) Java version : 1.5.0_08(Sun Microsystems Inc.) Changes No files changed **************************************************************************** Output: **************************************************************************** [INFO] Scanning for projects... [INFO] ---------------------------------------------------------------------------- [INFO] Building Logback Access Module [INFO] task-segment: [clean, install] [INFO] ---------------------------------------------------------------------------- [INFO] [clean:clean] [INFO] Deleting directory /opt/continuum-1.0.3/apps/continuum/working-directory/47/target [INFO] Deleting directory /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/classes [INFO] Deleting directory /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/test-classes [INFO] [resources:resources] [INFO] Using default encoding to copy filtered resources. [INFO] [compiler:compile] Compiling 56 source files to /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/classes [INFO] [resources:testResources] [INFO] Using default encoding to copy filtered resources. [INFO] [compiler:testCompile] Compiling 22 source files to /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/test-classes [INFO] [surefire:test] [INFO] Surefire report directory: /opt/continuum-1.0.3/apps/continuum/working-directory/47/target/surefire-reports ------------------------------------------------------- T E S T S ------------------------------------------------------- Running ch.qos.logback.access.db.DBAppenderTest [Server@7b1ddcde]: [Thread[main,5,main]]: checkRunning(false) entered [Server@7b1ddcde]: [Thread[main,5,main]]: checkRunning(false) exited [Server@7b1ddcde]: [Thread[main,5,main]]: setDatabaseName(0,test) [Server@7b1ddcde]: [Thread[main,5,main]]: checkRunning(false) entered [Server@7b1ddcde]: [Thread[main,5,main]]: checkRunning(false) exited [Server@7b1ddcde]: [Thread[main,5,main]]: setDatabasePath(0,mem:test;sql.enforce_strict_size=true) [Server@624b035d]: [Thread[main,5,main]]: checkRunning(false) entered [Server@624b035d]: [Thread[main,5,main]]: checkRunning(false) exited [Server@624b035d]: [Thread[main,5,main]]: setDatabaseName(0,test) [Server@624b035d]: [Thread[main,5,main]]: checkRunning(false) entered [Server@624b035d]: [Thread[main,5,main]]: checkRunning(false) exited [Server@624b035d]: [Thread[main,5,main]]: setDatabasePath(0,mem:test;sql.enforce_strict_size=true) [Server@2c76e369]: [Thread[main,5,main]]: checkRunning(false) entered [Server@2c76e369]: [Thread[main,5,main]]: checkRunning(false) exited [Server@2c76e369]: [Thread[main,5,main]]: setDatabaseName(0,test) [Server@2c76e369]: [Thread[main,5,main]]: checkRunning(false) entered [Server@2c76e369]: [Thread[main,5,main]]: checkRunning(false) exited [Server@2c76e369]: [Thread[main,5,main]]: setDatabasePath(0,mem:test;sql.enforce_strict_size=true) Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.719 sec <<< FAILURE! Running ch.qos.logback.access.jetty.JettyBasicTest 2006-11-29 10:32:48.547::INFO: Logging to STDERR via org.mortbay.log.StdErrLog 2006-11-29 10:32:48.595::INFO: jetty-6.0.x |-WARN in ch.qos.logback.access.jetty.RequestLogImpl@309cbd4b - filename property not set. Assuming [null/etc/logback-access.xml] |-ERROR in ch.qos.logback.access.jetty.RequestLogImpl@309cbd4b - [null/etc/logback-access.xml] does not exist |-INFO in ch.qos.logback.access.jetty.RequestLogImpl@309cbd4b - RequestLog added to RequestLogRegistry with name: LogbackRequestLog 2006-11-29 10:32:48.658::INFO: Started SelectChannelConnector @ 0.0.0.0:1234 29/11/2006:10:32:48 +0100 localhost 127.0.0.1 Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.291 sec <<< FAILURE! Running ch.qos.logback.access.filter.AccessStatsTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.011 sec Running ch.qos.logback.access.pattern.ConverterTest Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.029 sec Running ch.qos.logback.access.filter.StatsByDayTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.012 sec Running ch.qos.logback.access.net.URLEvaluatorTest Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.009 sec Running ch.qos.logback.access.net.SocketAppenderTest Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.128 sec Results : Tests run: 28, Failures: 0, Errors: 2, Skipped: 0 [INFO] ------------------------------------------------------------------------ [ERROR] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] There are test failures. [INFO] ------------------------------------------------------------------------ [INFO] For more information, run Maven with the -e switch [INFO] ------------------------------------------------------------------------ [INFO] Total time: 11 seconds [INFO] Finished at: Wed Nov 29 10:32:50 CET 2006 [INFO] Final Memory: 12M/116M [INFO] ------------------------------------------------------------------------ ****************************************************************************

1 0

svn commit: r1028 - logback/trunk/logback-site/src/site/resources
by noreply.ceki＠qos.ch 29 Nov '06

29 Nov '06

Author: ceki Date: Wed Nov 29 08:52:24 2006 New Revision: 1028 Modified: logback/trunk/logback-site/src/site/resources/10reasons.ppt Log: ongoing work Modified: logback/trunk/logback-site/src/site/resources/10reasons.ppt ============================================================================== Binary files. No diff available.

1 0

svn commit: r1027 - logback/trunk/logback-site/src/site/resources
by noreply.ceki＠qos.ch 29 Nov '06

29 Nov '06

Author: ceki Date: Wed Nov 29 08:51:06 2006 New Revision: 1027 Added: logback/trunk/logback-site/src/site/resources/modules.EAP (contents, props changed) Modified: logback/trunk/logback-site/src/site/resources/slf4j-slides.vsd Log: ongoing work Added: logback/trunk/logback-site/src/site/resources/modules.EAP ============================================================================== Binary file. No diff available. Modified: logback/trunk/logback-site/src/site/resources/slf4j-slides.vsd ============================================================================== Binary files. No diff available.

1 0

svn commit: r1026 - in logback/trunk: . logback-site/src/site/resources
by noreply.ceki＠qos.ch 28 Nov '06

28 Nov '06

Author: ceki Date: Tue Nov 28 23:17:44 2006 New Revision: 1026 Removed: logback/trunk/sync_logback_ibiblio.sh Modified: logback/trunk/logback-site/src/site/resources/10reasons.ppt Log: ongoing work Modified: logback/trunk/logback-site/src/site/resources/10reasons.ppt ============================================================================== Binary files. No diff available.

1 0

svn commit: r1025 - logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling
by noreply.ceki＠qos.ch 28 Nov '06

28 Nov '06

Author: ceki Date: Tue Nov 28 22:51:48 2006 New Revision: 1025 Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/SizeBasedTriggeringPolicy.java Log: minor refactoring Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/SizeBasedTriggeringPolicy.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/SizeBasedTriggeringPolicy.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/SizeBasedTriggeringPolicy.java Tue Nov 28 22:51:48 2006 @@ -28,6 +28,7 @@ */ public class SizeBasedTriggeringPolicy extends TriggeringPolicyBase { + public static final String SEE_SIZE_FORMAT = "http://logback.qos.ch/codes.html#sbtp_size_format"; /** * The default maximum file size. */ @@ -82,7 +83,7 @@ return Long.valueOf(s).longValue() * multiplier; } catch (NumberFormatException e) { - addError("[" + s + "] is not in proper int form. For more info, please visit http://logback.qos.ch/codes.html#sbtp_size_format"); + addError("[" + s + "] is not in proper int format. Please refer to "+SEE_SIZE_FORMAT); addError("[" + value + "] not in expected format.", e); } }

1 0

svn commit: r1024 - logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling
by noreply.ceki＠qos.ch 28 Nov '06

28 Nov '06

Author: ceki Date: Tue Nov 28 22:49:12 2006 New Revision: 1024 Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/TimeBasedRollingPolicy.java Log: correcting URL Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/TimeBasedRollingPolicy.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/TimeBasedRollingPolicy.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/rolling/TimeBasedRollingPolicy.java Tue Nov 28 22:49:12 2006 @@ -33,7 +33,7 @@ static final String FNP_NOT_SET = "The FileNamePattern option must be set before using TimeBasedRollingPolicy. "; static final String SEE_FNP_NOT_SET = - "See also http://logback.qos.ch/doc/codes.html#tbr_fnp_not_set"; + "See also http://logback.qos.ch/codes.html#tbr_fnp_not_set"; RollingCalendar rc; long nextCheck; Date lastCheck = new Date();

1 0

svn commit: r1023 - logback/trunk/logback-examples/src/main/java/chapter4/conf/access
by noreply.seb＠qos.ch 28 Nov '06

28 Nov '06

Author: seb Date: Tue Nov 28 20:55:24 2006 New Revision: 1023 Added: logback/trunk/logback-examples/src/main/java/chapter4/conf/access/logback-DB.xml Log: Added a sample configuration for access' DBAppender Added: logback/trunk/logback-examples/src/main/java/chapter4/conf/access/logback-DB.xml ============================================================================== --- (empty file) +++ logback/trunk/logback-examples/src/main/java/chapter4/conf/access/logback-DB.xml Tue Nov 28 20:55:24 2006 @@ -0,0 +1,14 @@ +<configuration> + + <appender name="DB" class="ch.qos.logback.access.db.DBAppender"> + <connectionSource class="ch.qos.logback.core.db.DriverManagerConnectionSource"> + <driverClass>com.mysql.jdbc.Driver</driverClass> + <url>jdbc:mysql://localhost:3306/logbackdb</url> + <user>logback</user> + <password>logback</password> + </connectionSource> + <insertHeaders>true</insertHeaders> + </appender> + + <appender-ref ref="DB" /> +</configuration> \ No newline at end of file

1 0

svn commit: r1022 - in logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran: action spi
by noreply.ceki＠qos.ch 28 Nov '06

28 Nov '06

Author: ceki Date: Tue Nov 28 20:30:16 2006 New Revision: 1022 Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/NestedComponentIA.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/NestedSimplePropertyIA.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/spi/Interpreter.java Log: more precise log messages Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/NestedComponentIA.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/NestedComponentIA.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/NestedComponentIA.java Tue Nov 28 20:30:16 2006 @@ -66,7 +66,7 @@ // we only push action data if NestComponentIA is applicable case AS_COMPONENT_COLLECTION: case AS_SINGLE_COMPONENT: - addInfo("was deemed applicable for " + pattern); + //addInfo("was deemed applicable for " + pattern); ImplicitActionData ad = new ImplicitActionData(parentBean, containmentType); actionDataStack.push(ad); @@ -91,7 +91,7 @@ if (OptionHelper.isEmpty(className)) { actionData.inError = true; - String errMsg = "No class name attribute in <" + localName + ">"; + String errMsg = "No class name attribute in [" + localName + "]"; addError(errMsg); return; @@ -110,12 +110,12 @@ ((ContextAware) actionData.nestedComponent).setContext(this.context); } // getLogger().debug( - addInfo("Pushing component <" + localName - + "> on top of the object stack."); + addInfo("Pushing component [" + localName + + "] on top of the object stack."); ec.pushObject(actionData.nestedComponent); } catch (Exception oops) { actionData.inError = true; - String msg = "Could not create component <" + localName + "> of type [" + String msg = "Could not create component [" + localName + "] of type [" + className + "]"; addError(msg, oops); } Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/NestedSimplePropertyIA.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/NestedSimplePropertyIA.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/action/NestedSimplePropertyIA.java Tue Nov 28 20:30:16 2006 @@ -68,7 +68,7 @@ ImplicitActionData ad = new ImplicitActionData(parentBean, containmentType); ad.propertyName = nestedElementTagName; actionDataStack.push(ad); - //addInfo("NestedSimplePropertyIA deemed applicable <" + pattern + ">"); + //addInfo("NestedSimplePropertyIA deemed applicable [" + pattern + "]"); return true; default: addError("PropertySetter.canContainComponent returned " + containmentType); Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/spi/Interpreter.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/spi/Interpreter.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/joran/spi/Interpreter.java Tue Nov 28 20:30:16 2006 @@ -117,16 +117,16 @@ pattern.push(tagName); List applicableActionList = getApplicableActionList(pattern, atts); - + if (applicableActionList != null) { actionListStack.add(applicableActionList); callBeginAction(applicableActionList, tagName, atts); } else { actionListStack.add(EMPTY_LIST); - String errMsg = "no applicable action for <" + tagName - + ">, current pattern is [" + pattern + "]"; - ec.addError(errMsg); + String errMsg = "no applicable action for [" + tagName + + "], current pattern is [" + pattern + "]"; + cai.addError(errMsg); } }

1 0