- logback-dev - mailman3.qos.ch

svn commit: r632 - in logback/trunk/logback-core/examples: . src
by noreply.ceki＠qos.ch 08 Oct '06

08 Oct '06

Author: ceki Date: Sun Oct 8 18:14:11 2006 New Revision: 632 Added: logback/trunk/logback-core/examples/ logback/trunk/logback-core/examples/src/ Log: Added joran tutorial

1 0

svn commit: r631 - logback/trunk/logback-core/src/main/java/ch/qos/logback/core/util
by noreply.ceki＠qos.ch 08 Oct '06

08 Oct '06

Author: ceki Date: Sun Oct 8 18:07:45 2006 New Revision: 631 Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/util/StatusPrinter.java Log: Added a variant of the print method taking in a Context. Modified: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/util/StatusPrinter.java ============================================================================== --- logback/trunk/logback-core/src/main/java/ch/qos/logback/core/util/StatusPrinter.java (original) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/util/StatusPrinter.java Sun Oct 8 18:07:45 2006 @@ -1,28 +1,44 @@ /** - * LOGBack: the reliable, fast and flexible logging library for Java. - * + * Logback: the reliable, fast and flexible logging library for Java. + * * Copyright (C) 1999-2006, QOS.ch - * - * This library is free software, you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public License as - * published by the Free Software Foundation. + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. */ + package ch.qos.logback.core.util; import java.util.Iterator; +import ch.qos.logback.core.Context; import ch.qos.logback.core.status.Status; import ch.qos.logback.core.status.StatusManager; public class StatusPrinter { + public static void print(Context context) { + if (context == null) { + throw new IllegalArgumentException("Context argument cannot be null"); + } + + StatusManager sm = context.getStatusManager(); + if (sm == null) { + System.out.println("WARN: Context named \"" + context.getName() + + "\" has no status manager"); + } + + print(sm); + } + public static void print(StatusManager sm) { - + Iterator it = sm.iterator(); - while(it.hasNext()) { + while (it.hasNext()) { Status s = (Status) it.next(); System.out.println(s); - if(s.getThrowable() != null) { + if (s.getThrowable() != null) { s.getThrowable().printStackTrace(System.out); } }

1 0

svn commit: r630 - logback/trunk/logback-access/src/main/java/ch/qos/logback/access/net
by noreply.seb＠qos.ch 06 Oct '06

06 Oct '06

Author: seb Date: Fri Oct 6 17:26:07 2006 New Revision: 630 Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/net/SMTPAppender.java Log: - modified default triggering behaviour - updated javadoc accordingly Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/net/SMTPAppender.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/net/SMTPAppender.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/net/SMTPAppender.java Fri Oct 6 17:26:07 2006 @@ -29,8 +29,12 @@ * keeps memory requirements at a reasonable level while still delivering useful * application context. * - * By default, the email is sent everything an event has a status code of - * 500 (server error) or higher. + * By default, the email is sent everytime an event has a status code of + * 500 (server error) or higher. In order not to flood one's mailbox, + * an email will be sent only if the previous email was sent more that 24 hours ago. + * + * This behaviour can be easily bypassed either by modifying this class, or by + * imlementing a new <code>TriggeringPolicy</code>. * * @author Ceki Gülcü * @author Sébastien Pennec @@ -117,16 +121,30 @@ private boolean started; private static final Integer TRIGGERING_STATUS_CODE = 500; + private static final long ONE_DAY = 1000*60*60*24; + private static long LAST_TRIGGER_DATE = 0L; + + /** * Is this <code>event</code> the e-mail triggering event? * * * This method returns <code>true</code>, if the event status code * is 500 (server error) or higher. Otherwise it returns <code>false</code>. + * + * Once an email is sent, the next one will not be sent unless a certain amount + * of time passed. */ public boolean isTriggeringEvent(File file, Object eventObject) { AccessEvent event = (AccessEvent) eventObject; - return TRIGGERING_STATUS_CODE.compareTo(event.getStatusCode()) <= 0; + + if (TRIGGERING_STATUS_CODE.compareTo(event.getStatusCode()) <= 0) { + if (System.currentTimeMillis() >= LAST_TRIGGER_DATE + ONE_DAY) { + LAST_TRIGGER_DATE = System.currentTimeMillis(); + return true; + } + } + return false; } public boolean isStarted() {

1 0

svn commit: r629 - logback/trunk/logback-access/src/main/java/ch/qos/logback/access/html
by noreply.seb＠qos.ch 06 Oct '06

06 Oct '06

Author: seb Date: Fri Oct 6 16:06:44 2006 New Revision: 629 Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/html/HTMLLayout.java Log: minor fix Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/html/HTMLLayout.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/html/HTMLLayout.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/html/HTMLLayout.java Fri Oct 6 16:06:44 2006 @@ -54,10 +54,6 @@ * </configuration> *</pre> * - * In this configuration file, the throwableRenderer element specifies the default - * implementation of IThrowableRenderer. It could be omitted, but is showed for educationnal - * purposes. - * * @author Ceki Gülcü * @author Sébastien Pennec */ @@ -67,7 +63,7 @@ * Default pattern string for log output. Currently set to the string "%m" * which just prints the application supplied message. */ - static final String DEFAULT_CONVERSION_PATTERN = "%date%thread%level%logger%mdc%msg"; + static final String DEFAULT_CONVERSION_PATTERN = "%remoteIP%date%requestURL%statusCode%bytesSent"; /** * Constructs a PatternLayout using the DEFAULT_LAYOUT_PATTERN.

1 0

svn commit: r628 - in logback/trunk/logback-access/src/main/java/ch/qos/logback/access: . html net
by noreply.seb＠qos.ch 06 Oct '06

06 Oct '06

Author: seb Date: Fri Oct 6 16:05:02 2006 New Revision: 628 Added: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/html/ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/html/HTMLLayout.java logback/trunk/logback-access/src/main/java/ch/qos/logback/access/html/package.html Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/PatternLayout.java logback/trunk/logback-access/src/main/java/ch/qos/logback/access/net/SMTPAppender.java Log: - added HTMLLayout for access module - minor fix on SMTPAppender javadoc Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/PatternLayout.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/PatternLayout.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/PatternLayout.java Fri Oct 6 16:05:02 2006 @@ -212,7 +212,7 @@ */ public class PatternLayout extends PatternLayoutBase implements AccessLayout { - static final Map<String, String> defaultConverterMap = new HashMap<String, String>(); + public static final Map<String, String> defaultConverterMap = new HashMap<String, String>(); public static String CLF_PATTERN = "%h %l %u %t \"%r\" %s %b"; Added: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/html/HTMLLayout.java ============================================================================== --- (empty file) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/html/HTMLLayout.java Fri Oct 6 16:05:02 2006 @@ -0,0 +1,129 @@ +/** + * Logback: the reliable, generic, fast and flexible logging framework. + * + * Copyright (C) 1999-2006, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. + */ + +package ch.qos.logback.access.html; + +import java.util.Map; + +import ch.qos.logback.access.AccessLayout; +import ch.qos.logback.access.PatternLayout; +import ch.qos.logback.access.spi.AccessEvent; +import ch.qos.logback.core.html.HTMLLayoutBase; +import ch.qos.logback.core.html.NOPThrowableRenderer; +import ch.qos.logback.core.pattern.Converter; + +/** + * + * HTMLLayout outputs events in an HTML table. + * + * The content of the table columns are specified using a conversion pattern. + * See {@link ch.qos.logback.access.PatternLayout} for documentation on the + * available patterns. + * + * A user-specified external CSS file can be linked to the html page. + * In case one does not want to customize the html output, an internal CSS style + * is used. + * + * The HTMLLayout is often used in conjunction with SMTPAppender, to + * send a nicely formatted html email. Of course, it can be used with any + * other Appender. + * + * In case on wants to use the HTMLLayout with a SMTPAppender, here is a sample + * configuration file that can be used. + * + * <pre> + * <configuration> + * <appender name="SMTP" class="ch.qos.logback.access.net.SMTPAppender"> + * <layout class="ch.qos.logback.access.html.HTMLLayout"> + * <param name="pattern" value="%remoteIP%date%requestURL%statusCode%bytesSent" /> + * </layout> + * <param name="From" value="sender.email(a)domain.net" /> + * <param name="SMTPHost" value="mail.domain.net" /> + * <param name="Subject" value="LastEvent: %statusCode %requestURL" /> + * <param name="To" value="destination.email(a)domain.net" /> + * </appender> + * + * <appender-ref ref="SMTP" /> + * </configuration> + *</pre> + * + * In this configuration file, the throwableRenderer element specifies the default + * implementation of IThrowableRenderer. It could be omitted, but is showed for educationnal + * purposes. + * + * @author Ceki Gülcü + * @author Sébastien Pennec + */ +public class HTMLLayout extends HTMLLayoutBase implements AccessLayout { + + /** + * Default pattern string for log output. Currently set to the string "%m" + * which just prints the application supplied message. + */ + static final String DEFAULT_CONVERSION_PATTERN = "%date%thread%level%logger%mdc%msg"; + + /** + * Constructs a PatternLayout using the DEFAULT_LAYOUT_PATTERN. + * + * The default pattern just produces the application supplied message. + */ + public HTMLLayout() { + pattern = DEFAULT_CONVERSION_PATTERN; + throwableRenderer = new NOPThrowableRenderer(); + } + + @Override + protected Map<String, String> getDefaultConverterMap() { + return PatternLayout.defaultConverterMap; + } + + public String doLayout(Object event) { + return doLayout((AccessEvent) event); + } + + public String doLayout(AccessEvent event) { + StringBuffer buf = new StringBuffer(); + handleTableClosing(buf); + + boolean odd = true; + if (((counter++) & 1) == 0) { + odd = false; + } + + buf.append(LINE_SEP); + buf.append("<tr class=\""); + if (odd) { + buf.append(" odd\">"); + } else { + buf.append(" even\">"); + } + buf.append(LINE_SEP); + + Converter c = head; + while (c != null) { + appendEventToBuffer(buf, c, event); + c = c.getNext(); + } + buf.append("</tr>"); + buf.append(LINE_SEP); + + return buf.toString(); + } + + private void appendEventToBuffer(StringBuffer buf, Converter c, + AccessEvent event) { + buf.append("<td class=\""); + buf.append(computeConverterName(c)); + buf.append("\">"); + buf.append(c.convert(event)); + buf.append("</td>"); + buf.append(LINE_SEP); + } +} Added: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/html/package.html ============================================================================== --- (empty file) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/html/package.html Fri Oct 6 16:05:02 2006 @@ -0,0 +1,13 @@ +<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"> + +<html> + <head> + <title></title> + </head> + + <body> + + Contains classes to format log output in HTML. + + </body> +</html> \ No newline at end of file Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/net/SMTPAppender.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/net/SMTPAppender.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/net/SMTPAppender.java Fri Oct 6 16:05:02 2006 @@ -30,7 +30,7 @@ * application context. * * By default, the email is sent everything an event has a status code of - * 500 (server error) or higher. + * 500 (server error) or higher. * * @author Ceki Gülcü * @author Sébastien Pennec

1 0

svn commit: r627 - logback/trunk/logback-access/src/main/java/ch/qos/logback/access/pattern
by noreply.seb＠qos.ch 06 Oct '06

06 Oct '06

Author: seb Date: Fri Oct 6 09:41:51 2006 New Revision: 627 Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/pattern/PostContentConverter.java Log: bigger warning... Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/pattern/PostContentConverter.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/pattern/PostContentConverter.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/pattern/PostContentConverter.java Fri Oct 6 09:41:51 2006 @@ -4,10 +4,12 @@ /** * This class is tied to the <code>postContent</code> conversion pattern. - * + * * It has been removed from the {@link ch.qos.logback.access.PatternLayout} since * it needs further testing before being used widely. - * + * + * Please handle this class with caution if you wish to use it anyway! + * * @author Ceki Gülcü * @author Sébastien Pennec */

1 0

svn commit: r626 - in logback/trunk: logback-access/src/main/java/ch/qos/logback/access logback-access/src/main/java/ch/qos/logback/access/jetty logback-access/src/main/java/ch/qos/logback/access/net logback-access/src/main/java/ch/qos/logback/access/pattern logback-site/src/site/xdocTemplates
by noreply.seb＠qos.ch 06 Oct '06

06 Oct '06

Author: seb Date: Fri Oct 6 09:38:58 2006 New Revision: 626 Added: logback/trunk/logback-site/src/site/xdocTemplates/accessLogJetty.xml Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/PatternLayout.java logback/trunk/logback-access/src/main/java/ch/qos/logback/access/jetty/RequestLogImpl.java logback/trunk/logback-access/src/main/java/ch/qos/logback/access/net/SMTPAppender.java logback/trunk/logback-access/src/main/java/ch/qos/logback/access/pattern/PostContentConverter.java logback/trunk/logback-site/src/site/xdocTemplates/documentation.xml Log: - added documentation for logback access. - removed PostContentConverter from PatternLayout. Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/PatternLayout.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/PatternLayout.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/PatternLayout.java Fri Oct 6 09:38:58 2006 @@ -36,39 +36,216 @@ import ch.qos.logback.core.pattern.Converter; import ch.qos.logback.core.pattern.PatternLayoutBase; - +/** + * + * This class is a module-specific implementation of + * {@link ch.qos.logback.classic.PatternLayout} to allow http-specific patterns + * to be used. The <code>ch.qos.logback.access.PatternLayout</code> provides a + * way to format the logging output that is just as easy and flexible as the + * usual <code>PatternLayout</code>. + * + * + * For more information about the general use of a <code>PatternLayout</code>, + * please refer to logback classic's + * <code>ch.qos.logback.classic.PatternLayout</code>. + * + * + * Logback access' <code>PatternLayout</code> offers the following + * possibilities: + * + * <table border="1" CELLPADDING="8"> + * <th>Conversion Character or Word</th> + * <th>Effect</th> + * + * <tr> + * <td align="center">a / remoteIP</td> + * <td> + * + * Remote IP address. + * + * </td> + * </tr> + * <tr> + * <td align="center">A / localIP</td> + * <td> + * + * Local IP address. + * + * </td> + * </tr> + * <tr> + * <td align="center">b / B / byteSent</td> + * <td> + * + * Response's content length. + * + * </td> + * </tr> + * <tr> + * <td align="center">h / clientHost</td> + * <td> + * + * Remote host. + * + * </td> + * </tr> + * <tr> + * <td align="center">H / protocol</td> + * <td> + * + * Request protocol. + * + * </td> + * </tr> + * <tr> + * <td align="center">i / header</td> + * <td> + * + * Request header. This conversion word can be followed by a key whose + * corresponding data will be extracted from the header information. + * + * </td> + * </tr> + * <tr> + * <td align="center">m / requestMethod</td> + * <td> + * + * Request method. + * + * </td> + * </tr> + * <tr> + * <td align="center">r / requestURL</td> + * <td> + * + * URL requested. + * + * </td> + * </tr> + * <tr> + * <td align="center">s / statusCode</td> + * <td> + * + * Status code of the request. + * + * </td> + * </tr> + * <tr> + * <td align="center">t / date</td> + * <td> + * + * Date of the event. + * + * </td> + * </tr> + * <tr> + * <td align="center">u / user</td> + * <td> + * + * Remote user. + * + * </td> + * </tr> + * <tr> + * <td align="center">U / requestURI</td> + * <td> + * + * Requested URI. + * + * </td> + * </tr> + * <tr> + * <td align="center">v / server</td> + * <td> + * + * Server name. + * + * </td> + * </tr> + * <tr> + * <td align="center">localPort</td> + * <td> + * + * Local port. + * + * </td> + * </tr> + * <tr> + * <td align="center">reqAttribute</td> + * <td> + * + * Attribute of the request. Just like the request header conversion word, + * reqAttribute can be followed by a key. + * + * </td> + * </tr> + * <tr> + * <td align="center">reqCookie</td> + * <td> + * + * Request cookie. + * + * </td> + * </tr> + * <tr> + * <td align="center">responseHeader</td> + * <td> + * + * Header of the response. Just like the request header conversion word, + * responseHeader can be followed by a key. + * + * </td> + * </tr> + * <tr> + * <td align="center">reqParameter</td> + * <td> + * + * Parameter of the response. Just like the request header conversion word, + * reqParameter can be followed by a key. + * + * </td> + * </tr> + * </table> + * + * @author Ceki Gülcü + * @author Sébastien Pennec + */ public class PatternLayout extends PatternLayoutBase implements AccessLayout { static final Map<String, String> defaultConverterMap = new HashMap<String, String>(); public static String CLF_PATTERN = "%h %l %u %t \"%r\" %s %b"; - + static { defaultConverterMap.put("a", RemoteIPAddressConverter.class.getName()); - defaultConverterMap.put("remoteIP", RemoteIPAddressConverter.class.getName()); + defaultConverterMap.put("remoteIP", RemoteIPAddressConverter.class + .getName()); defaultConverterMap.put("A", LocalIPAddressConverter.class.getName()); defaultConverterMap.put("localIP", LocalIPAddressConverter.class.getName()); defaultConverterMap.put("b", ContentLengthConverter.class.getName()); defaultConverterMap.put("B", ContentLengthConverter.class.getName()); - defaultConverterMap.put("bytesSent", ContentLengthConverter.class.getName()); + defaultConverterMap + .put("bytesSent", ContentLengthConverter.class.getName()); defaultConverterMap.put("h", RemoteHostConverter.class.getName()); defaultConverterMap.put("clientHost", RemoteHostConverter.class.getName()); defaultConverterMap.put("H", RequestProtocolConverter.class.getName()); - defaultConverterMap.put("protocol", RequestProtocolConverter.class.getName()); - + defaultConverterMap.put("protocol", RequestProtocolConverter.class + .getName()); + defaultConverterMap.put("i", RequestHeaderConverter.class.getName()); defaultConverterMap.put("header", RequestHeaderConverter.class.getName()); - + defaultConverterMap.put("l", NAConverter.class.getName()); - + defaultConverterMap.put("m", RequestMethodConverter.class.getName()); - defaultConverterMap.put("requestMethod", RequestMethodConverter.class.getName()); - + defaultConverterMap.put("requestMethod", RequestMethodConverter.class + .getName()); + defaultConverterMap.put("r", RequestURLConverter.class.getName()); defaultConverterMap.put("requestURL", RequestURLConverter.class.getName()); @@ -80,23 +257,26 @@ defaultConverterMap.put("u", RemoteUserConverter.class.getName()); defaultConverterMap.put("user", RemoteUserConverter.class.getName()); - + defaultConverterMap.put("U", RequestURIConverter.class.getName()); defaultConverterMap.put("requestURI", RequestURIConverter.class.getName()); - + defaultConverterMap.put("v", ServerNameConverter.class.getName()); defaultConverterMap.put("server", ServerNameConverter.class.getName()); - + defaultConverterMap.put("localPort", LocalPortConverter.class.getName()); - defaultConverterMap.put("reqAttribute", RequestAttributeConverter.class.getName()); - defaultConverterMap.put("reqCookie", RequestCookieConverter.class.getName()); - defaultConverterMap.put("responseHeader", ResponseHeaderConverter.class.getName()); - defaultConverterMap.put("reqParameter", RequestParameterConverter.class.getName()); - - + defaultConverterMap.put("reqAttribute", RequestAttributeConverter.class + .getName()); + defaultConverterMap + .put("reqCookie", RequestCookieConverter.class.getName()); + defaultConverterMap.put("responseHeader", ResponseHeaderConverter.class + .getName()); + defaultConverterMap.put("reqParameter", RequestParameterConverter.class + .getName()); + defaultConverterMap.put("n", LineSeparatorConverter.class.getName()); } - + public PatternLayout() { // set a default value for pattern setPattern(CLF_PATTERN); @@ -115,7 +295,7 @@ protected void postCompileProcessing(Converter head) { Converter tail = findTail(head); Converter newLineConverter = new LineSeparatorConverter(); - if(tail == null) { + if (tail == null) { head = newLineConverter; } else { if (!(tail instanceof LineSeparatorConverter)) { @@ -135,6 +315,5 @@ public String doLayout(Object o) { return doLayout((AccessEvent) o); } - } Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/jetty/RequestLogImpl.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/jetty/RequestLogImpl.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/jetty/RequestLogImpl.java Fri Oct 6 09:38:58 2006 @@ -24,56 +24,80 @@ * LoggerContext does. It also provides containers for properties. * * To configure jetty in order to use RequestLogImpl, the following lines must - * be added to the jetty configuration file: + * be added to the jetty configuration file, namely etc/jetty.xml: + * * <pre> - * <Ref id="requestLog"> - * <Set name="requestLog"> - * <New id="requestLogImpl" class="ch.qos.logback.access.jetty.RequestLogImpl"></New> - * </Set> - * </Ref> + * <Ref id="requestLog"> + * <Set name="requestLog"> + * <New id="requestLogImpl" class="ch.qos.logback.access.jetty.RequestLogImpl"></New> + * </Set> + * </Ref> * </pre> + * * By default, RequestLogImpl looks for a logback configuration file called * logback.xml, in the same folder where jetty.xml is located, that is - * /etc/logback.xml. The logback.xml file is slightly different than the usual + * etc/logback.xml. The logback.xml file is slightly different than the usual * logback classic configuration file. Most of it is the same: Appenders and * Layouts are declared the exact same way. However, loggers elements are not * allowed. * - * It is possible to put the logback configuration file anywhere, as long as it's path is - * specified. Here is another example, with a path to the logback.xml file. + * It is possible to put the logback configuration file anywhere, as long as + * it's path is specified. Here is another example, with a path to the + * logback.xml file. + * * <pre> - * <Ref id="requestLog"> - * <Set name="requestLog"> - * <New id="requestLogImpl" class="ch.qos.logback.access.jetty.RequestLogImpl"></New> - * <Set name="fileName">path/to/logback.xml</Set> - * </Set> - * </Ref> + * <Ref id="requestLog"> + * <Set name="requestLog"> + * <New id="requestLogImpl" class="ch.qos.logback.access.jetty.RequestLogImpl"></New> + * <Set name="fileName">path/to/logback.xml</Set> + * </Set> + * </Ref> * </pre> + * * * Here is a sample logback.xml file that can be used right away: + * * <pre> - * <configuration> - * <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender"> - * <layout class="ch.qos.logback.access.PatternLayout"> - * <param name="Pattern" value="%date %server %remoteIP %clientHost %user %requestURL" /> - * </layout> - * </appender> - * - * <appender-ref ref="STDOUT" /> - * </configuration> + * <configuration> + * <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender"> + * <layout class="ch.qos.logback.access.PatternLayout"> + * <param name="Pattern" value="%date %server %remoteIP %clientHost %user %requestURL" /> + * </layout> + * </appender> + * + * <appender-ref ref="STDOUT" /> + * </configuration> * </pre> * + * + * Another configuration file, using SMTPAppender, could be: * + * <pre> + * <configuration> + * <appender name="SMTP" class="ch.qos.logback.access.net.SMTPAppender"> + * <layout class="ch.qos.logback.access.PatternLayout"> + * <param name="pattern" value="%remoteIP [%date] %requestURL %statusCode %bytesSent" /> + * </layout> + * <param name="From" value="sender(a)domaine.org" /> + * <param name="SMTPHost" value="mail.domain.org" /> + * <param name="Subject" value="Last Event: %statusCode %requestURL" /> + * <param name="To" value="server_admin(a)domain.org" /> + * </appender> + * <appender-ref ref="SMTP" /> + * </configuration> + * </pre> * - * A special, module-specific implementation of PatternLayout was implemented to allow - * http-specific patterns to be used. The {@link ch.qos.logback.access.PatternLayout} provides - * a way to format the logging output that is just as easy and flexible as the usual - * PatternLayout. - * For more information about the general use of a PatternLayout, please refer to logback - * classic's {@link ch.qos.logback.classic.PatternLayout}. For information about logback - * access' specific PatternLayout, please refer to it's javadoc. + * A special, module-specific implementation of PatternLayout was implemented to + * allow http-specific patterns to be used. The + * {@link ch.qos.logback.access.PatternLayout} provides a way to format the + * logging output that is just as easy and flexible as the usual PatternLayout. + * For more information about the general use of a PatternLayout, please refer + * to logback classic's {@link ch.qos.logback.classic.PatternLayout}. For + * information about logback access' specific PatternLayout, please refer to + * it's javadoc. * * @author Ceki Gülcü + * @author Sébastien Pennec */ public class RequestLogImpl extends ContextBase implements RequestLog, AppenderAttachable { Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/net/SMTPAppender.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/net/SMTPAppender.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/net/SMTPAppender.java Fri Oct 6 09:38:58 2006 @@ -20,8 +20,7 @@ import ch.qos.logback.core.rolling.TriggeringPolicy; /** - * Send an e-mail when a specific access event occurs, typically on errors or - * fatal errors. + * Send an e-mail when a specific access event occurs, typically on server errors. * * * The number of access events delivered in this e-mail depend on the value of Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/pattern/PostContentConverter.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/pattern/PostContentConverter.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/pattern/PostContentConverter.java Fri Oct 6 09:38:58 2006 @@ -2,6 +2,15 @@ import ch.qos.logback.access.spi.AccessEvent; +/** + * This class is tied to the <code>postContent</code> conversion pattern. + * + * It has been removed from the {@link ch.qos.logback.access.PatternLayout} since + * it needs further testing before being used widely. + * + * @author Ceki Gülcü + * @author Sébastien Pennec + */ public class PostContentConverter extends AccessConverter { @Override Added: logback/trunk/logback-site/src/site/xdocTemplates/accessLogJetty.xml ============================================================================== --- (empty file) +++ logback/trunk/logback-site/src/site/xdocTemplates/accessLogJetty.xml Fri Oct 6 09:38:58 2006 @@ -0,0 +1,322 @@ +<document> +  + + + <body> + <h2>Access log with logback and Jetty</h2> + <div class="author"> + Authors: Ceki Gülcü, Sébastien Pennec + </div> + + + <table> + <tr> + <td valign="top" align="top"> + <a rel="license" + href="http://creativecommons.org/licenses/by-nc-nd/2.5/"> + <img alt="Creative Commons License" border="0" + valign="top" align="top" + src="http://creativecommons.org/images/public/somerights20.png" /> + </a> + </td> + <td> + Copyright © 2000-2006, QOS.ch + + + This work is licensed under a + <a rel="license" + href="http://creativecommons.org/licenses/by-nc-nd/2.5/"> + Creative Commons + Attribution-Noncommercial-No Derivative + Works 2.5 License + </a> + . + + </td> + </tr> + </table> + + <h2>Introduction</h2> + + + Since its first design drafts, logback has been concieved as a modular framework. + Being able to use logback's internal core in many situations, without heavy coding or + complex specific configuration was one of our goals. + + + Lobgack access integrates with Servlet containers such as Jetty and Tomcat to provide + HTTP-access log functionality. + + + Integrating logback into Jetty is very simple. Once done, one can benefit of many of + logback's flexibility and reliability. + + + <h2>Logback's RequestLog implementation</h2> + + + Logback's <code>ch.qos.logback.access.jetty.RequestLogImpl</code> is an + implementation of jetty's <code>RequestLog</code> interface. + + + It can be seen as logback classic's <code>LoggerContext</code>. + + + In logback, logging destinations are called Appenders. These classes + can be attached directly to <code>RequestLogImpl</code>. + + Logback's internal error reporting system is based on Status objects. + <code>RequestLogImpl</code> uses the same <code>StatusManager</code> + as <code>LoggerContext</code> does. It also provides containers for properties. + + + To configure jetty in order to use <code>RequestLogImpl</code>, the + following lines must be added to the jetty configuration + file, namely etc/jetty.xml: + + <pre> +<Ref id="requestLog"> + <Set name="requestLog"> + <New id="requestLogImpl" + class="ch.qos.logback.access.jetty.RequestLogImpl"> + </New> + </Set> +</Ref> + </pre> + + By default, <code>RequestLogImpl</code> looks for a logback configuration + file called logback.xml, in the same folder where jetty.xml + is located, that is etc/logback.xml. The logback.xml file + is slightly different than the usual logback classic + configuration file. Most of it is the same: Appenders and + Layouts (which are logback components to format logging output) + are declared the exact same way. However, loggers + elements are not allowed. It is possible to put the logback + configuration file anywhere, as long as it's path is + specified. Here is another example, with a path to the + logback.xml file. + + <pre> +<Ref id="requestLog"> + <Set name="requestLog"> + <New id="requestLogImpl" + class="ch.qos.logback.access.jetty.RequestLogImpl"> + </New> + <Set name="fileName">path/to/logback.xml</Set> + </Set> +</Ref> + </pre> + + Here is a sample logback.xml file that can be used right + away: + + <pre> +<configuration> + <appender name="STDOUT" + class="ch.qos.logback.core.ConsoleAppender"> + <layout + class="ch.qos.logback.access.PatternLayout"> + <param name="Pattern" + value="%date %server %remoteIP %clientHost %user %requestURL" /> + </layout> + </appender> + + <appender-ref ref="STDOUT" /> +</configuration> + </pre> + Another configuration file, using logback access <code>SMTPAppender</code>, could be: + <pre> +<configuration> + <appender name="SMTP" + class="ch.qos.logback.access.net.SMTPAppender"> + <layout + class="ch.qos.logback.access.PatternLayout"> + <param name="pattern" + value="%remoteIP [%date] %requestURL %statusCode %bytesSent" /> + </layout> + <param name="From" value="sender(a)domaine.org" /> + <param name="SMTPHost" value="mail.domain.org" /> + <param name="Subject" + value="Last Event: %statusCode %requestURL" /> + <param name="To" value="server_admin(a)domain.org" /> + </appender> + <appender-ref ref="SMTP" /> +</configuration> + </pre> + + A special, module-specific implementation of <code>PatternLayout</code> + was implemented to allow http-specific patterns to be used. + The <code>ch.qos.logback.access.PatternLayout</code> provides a way to + format the logging output that is just as easy and flexible + as the usual <code>PatternLayout</code>. + + + For more information about the + general use of a <code>PatternLayout</code>, please refer to logback + classic's <code>ch.qos.logback.classic.PatternLayout</code>. + + + Logback access <code>PatternLayout</code> offers the following possibilities: + + <table border="1" CELLPADDING="8"> + <th align="center">Conversion Character or Word</th> + <th align="center">Effect</th> + + <tr> + <td align="center">a / remoteIP</td> + <td> + + Remote IP address. + + </td> + </tr> + <tr> + <td align="center">A / localIP</td> + <td> + + Local IP address. + + </td> + </tr> + <tr> + <td align="center">b / B / byteSent</td> + <td> + + Response's content length. + + </td> + </tr> + <tr> + <td align="center">h / clientHost</td> + <td> + + Remote host. + + </td> + </tr> + <tr> + <td align="center">H / protocol</td> + <td> + + Request protocol. + + </td> + </tr> + <tr> + <td align="center">i / header</td> + <td> + + Request header. This conversion word can be followed by a key + whose corresponding data will be extracted from the header information. + + </td> + </tr> + <tr> + <td align="center">m / requestMethod</td> + <td> + + Request method. + + </td> + </tr> + <tr> + <td align="center">r / requestURL</td> + <td> + + URL requested. + + </td> + </tr> + <tr> + <td align="center">s / statusCode</td> + <td> + + Status code of the request. + + </td> + </tr> + <tr> + <td align="center">t / date</td> + <td> + + Date of the event. + + </td> + </tr> + <tr> + <td align="center">u / user</td> + <td> + + Remote user. + + </td> + </tr> + <tr> + <td align="center">U / requestURI</td> + <td> + + Requested URI. + + </td> + </tr> + <tr> + <td align="center">v / server</td> + <td> + + Server name. + + </td> + </tr> + <tr> + <td align="center">localPort</td> + <td> + + Local port. + + </td> + </tr> + <tr> + <td align="center">reqAttribute</td> + <td> + + Attribute of the request. Just like the request header + conversion word, reqAttribute can be followed by a key. + + </td> + </tr> + <tr> + <td align="center">reqCookie</td> + <td> + + Request cookie. Just like the request header + conversion word, reqCookie can be followed by a key. + + </td> + </tr> + <tr> + <td align="center">responseHeader</td> + <td> + + Header of the response. Just like the request header + conversion word, responseHeader can be followed by a key. + + </td> + </tr> + <tr> + <td align="center">reqParameter</td> + <td> + + Parameter of the response. Just like the request header + conversion word, reqParameter can be followed by a key. + + </td> + </tr> + </table> + </body> +</document> Modified: logback/trunk/logback-site/src/site/xdocTemplates/documentation.xml ============================================================================== --- logback/trunk/logback-site/src/site/xdocTemplates/documentation.xml (original) +++ logback/trunk/logback-site/src/site/xdocTemplates/documentation.xml Fri Oct 6 09:38:58 2006 @@ -17,9 +17,11 @@ <li> <a href="shortIntro.html">A short introduction to logback-classic</a> </li> - <li> - <a href="apidocs/index.html">javadoc</a> + <a href="accessLogJetty.html">A short introduction to access logging with logback-access and Jetty</a> + </li> + <li> + <a href="apidocs/index.html">Javadoc</a> </li> </ul>

1 0

svn commit: r625 - in logback/trunk: logback-access/src/main/java/ch/qos/logback/access/net logback-classic/src/main/java/ch/qos/logback/classic/helpers logback-classic/src/main/java/ch/qos/logback/classic/net logback-core/src/main/java/ch/qos/logback/core/helpers
by noreply.seb＠qos.ch 05 Oct '06

05 Oct '06

Author: seb Date: Thu Oct 5 10:44:41 2006 New Revision: 625 Added: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/net/ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/net/SMTPAppender.java logback/trunk/logback-core/src/main/java/ch/qos/logback/core/helpers/CyclicBuffer.java Removed: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/helpers/CyclicBuffer.java Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/net/SMTPAppender.java Log: - added SMTPAppender for access module - moved CyclicBuffer.java to the core module - modified classic module's SMTPAppender accordingly Added: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/net/SMTPAppender.java ============================================================================== --- (empty file) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/net/SMTPAppender.java Thu Oct 5 10:44:41 2006 @@ -0,0 +1,144 @@ +/** + * Logback: the reliable, generic, fast and flexible logging framework. + * + * Copyright (C) 1999-2006, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. + */ + +package ch.qos.logback.access.net; + +import java.io.File; + +import ch.qos.logback.access.PatternLayout; +import ch.qos.logback.core.helpers.CyclicBuffer; +import ch.qos.logback.access.spi.AccessEvent; +import ch.qos.logback.core.Layout; +import ch.qos.logback.core.net.SMTPAppenderBase; +import ch.qos.logback.core.rolling.TriggeringPolicy; + +/** + * Send an e-mail when a specific access event occurs, typically on errors or + * fatal errors. + * + * + * The number of access events delivered in this e-mail depend on the value of + * BufferSize option. The <code>SMTPAppender</code> keeps only the + * last <code>BufferSize</code> access events in its cyclic buffer. This + * keeps memory requirements at a reasonable level while still delivering useful + * application context. + * + * By default, the email is sent everything an event has a status code of + * 500 (server error) or higher. + * + * @author Ceki Gülcü + * @author Sébastien Pennec + * + */ +public class SMTPAppender extends SMTPAppenderBase { + + static final String DEFAULT_SUBJECT_PATTERN = "%m"; + + private int bufferSize = 512; + protected CyclicBuffer cb = new CyclicBuffer(bufferSize); + + /** + * The default constructor will instantiate the appender with a + * {@link TriggeringEventEvaluator} that will trigger on events with level + * ERROR or higher. + */ + public SMTPAppender() { + this(new DefaultEvaluator()); + } + + /** + * Use <code>evaluator</code> passed as parameter as the {@link + * TriggeringEventEvaluator} for this SMTPAppender. + */ + public SMTPAppender(TriggeringPolicy evaluator) { + this.evaluator = evaluator; + } + + /** + * Perform SMTPAppender specific appending actions, mainly adding the event to + * a cyclic buffer. + */ + protected void subAppend(Object eventObject) { + AccessEvent event = (AccessEvent) eventObject; + + cb.add(event); + // addInfo("Added event to the cyclic buffer: " + event.getMessage()); + } + + @Override + protected void fillBuffer(StringBuffer sbuf) { + int len = cb.length(); + for (int i = 0; i < len; i++) { + // sbuf.append(MimeUtility.encodeText(layout.format(cb.get()))); + Object event = cb.get(); + sbuf.append(layout.doLayout(event)); + } + } + + /** + * The BufferSize option takes a positive integer representing the + * maximum number of logging events to collect in a cyclic buffer. When the + * <code>BufferSize</code> is reached, oldest events are deleted as new + * events are added to the buffer. By default the size of the cyclic buffer is + * 512 events. + */ + public void setBufferSize(int bufferSize) { + this.bufferSize = bufferSize; + cb.resize(bufferSize); + } + + /** + * Returns value of the BufferSize option. + */ + public int getBufferSize() { + return bufferSize; + } + + @Override + protected Layout makeSubjectLayout(String subjectStr) { + if(subjectStr == null) { + subjectStr = DEFAULT_SUBJECT_PATTERN; + } + PatternLayout pl = new PatternLayout(); + pl.setPattern(subjectStr); + pl.start(); + return pl; + } +} + +class DefaultEvaluator implements TriggeringPolicy { + + private boolean started; + + private static final Integer TRIGGERING_STATUS_CODE = 500; + /** + * Is this <code>event</code> the e-mail triggering event? + * + * + * This method returns <code>true</code>, if the event status code + * is 500 (server error) or higher. Otherwise it returns <code>false</code>. + */ + public boolean isTriggeringEvent(File file, Object eventObject) { + AccessEvent event = (AccessEvent) eventObject; + return TRIGGERING_STATUS_CODE.compareTo(event.getStatusCode()) <= 0; + } + + public boolean isStarted() { + return started == true; + } + + public void start() { + started = true; + } + + public void stop() { + started = false; + } +} Modified: logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/net/SMTPAppender.java ============================================================================== --- logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/net/SMTPAppender.java (original) +++ logback/trunk/logback-classic/src/main/java/ch/qos/logback/classic/net/SMTPAppender.java Thu Oct 5 10:44:41 2006 @@ -14,7 +14,7 @@ import ch.qos.logback.classic.Level; import ch.qos.logback.classic.PatternLayout; -import ch.qos.logback.classic.helpers.CyclicBuffer; +import ch.qos.logback.core.helpers.CyclicBuffer; import ch.qos.logback.classic.spi.LoggingEvent; import ch.qos.logback.core.Layout; import ch.qos.logback.core.net.SMTPAppenderBase; Added: logback/trunk/logback-core/src/main/java/ch/qos/logback/core/helpers/CyclicBuffer.java ============================================================================== --- (empty file) +++ logback/trunk/logback-core/src/main/java/ch/qos/logback/core/helpers/CyclicBuffer.java Thu Oct 5 10:44:41 2006 @@ -0,0 +1,142 @@ +/** + * Logback: the reliable, generic, fast and flexible logging framework. + * + * Copyright (C) 1999-2006, QOS.ch + * + * This library is free software, you can redistribute it and/or modify it under + * the terms of the GNU Lesser General Public License as published by the Free + * Software Foundation. + */ + +package ch.qos.logback.core.helpers; + + +/** + * + * CyclicBuffer is used by other appenders to hold + * objects for immediate or differed display. + * + * This buffer gives read access to any element in the buffer not just the first + * or last element. + * + * @author Ceki Gülcü + */ +public class CyclicBuffer { + + Object[] ea; + int first; + int last; + int numElems; + int maxSize; + + /** + * Instantiate a new CyclicBuffer of at most <code>maxSize</code> events. + * + * The <code>maxSize</code> argument must a positive integer. + * + * @param maxSize + * The maximum number of elements in the buffer. + */ + public CyclicBuffer(int maxSize) throws IllegalArgumentException { + if (maxSize < 1) { + throw new IllegalArgumentException("The maxSize argument (" + maxSize + + ") is not a positive integer."); + } + this.maxSize = maxSize; + ea = new Object[maxSize]; + first = 0; + last = 0; + numElems = 0; + } + + /** + * Add an <code>event</code> as the last event in the buffer. + * + */ + public void add(Object event) { + ea[last] = event; + if (++last == maxSize) + last = 0; + + if (numElems < maxSize) + numElems++; + else if (++first == maxSize) + first = 0; + } + + /** + * Get the ith oldest event currently in the buffer. If i + * is outside the range 0 to the number of elements currently in the buffer, + * then <code>null</code> is returned. + */ + public Object get(int i) { + if (i < 0 || i >= numElems) + return null; + + return ea[(first + i) % maxSize]; + } + + public int getMaxSize() { + return maxSize; + } + + + /** + * Get the oldest (first) element in the buffer. The oldest element is removed + * from the buffer. + */ + public Object get() { + Object r = null; + if (numElems > 0) { + numElems--; + r = ea[first]; + ea[first] = null; + if (++first == maxSize) + first = 0; + } + return r; + } + + /** + * Get the number of elements in the buffer. This number is guaranteed to be + * in the range 0 to <code>maxSize</code> (inclusive). + */ + public int length() { + return numElems; + } + + /** + * Resize the cyclic buffer to <code>newSize</code>. + * + * @throws IllegalArgumentException + * if <code>newSize</code> is negative. + */ + public void resize(int newSize) { + if (newSize < 0) { + throw new IllegalArgumentException("Negative array size [" + newSize + + "] not allowed."); + } + if (newSize == numElems) + return; // nothing to do + + Object[] temp = new Object[newSize]; + + int loopLen = newSize < numElems ? newSize : numElems; + + for (int i = 0; i < loopLen; i++) { + temp[i] = ea[first]; + ea[first] = null; + if (++first == numElems) + first = 0; + } + ea = temp; + first = 0; + numElems = loopLen; + maxSize = newSize; + if (loopLen == newSize) { + last = 0; + } else { + last = loopLen; + } + } +}

1 0

svn commit: r624 - logback/trunk/logback-access/src/main/java/ch/qos/logback/access
by noreply.seb＠qos.ch 05 Oct '06

05 Oct '06

Author: seb Date: Thu Oct 5 10:19:13 2006 New Revision: 624 Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/PatternLayout.java Log: - added a line separator word, for more coherence with c.q.l.classic.PatternLayout - modified the behaviour of postCompileProcessing() accordingly Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/PatternLayout.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/PatternLayout.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/PatternLayout.java Thu Oct 5 10:19:13 2006 @@ -18,7 +18,6 @@ import ch.qos.logback.access.pattern.LocalIPAddressConverter; import ch.qos.logback.access.pattern.LocalPortConverter; import ch.qos.logback.access.pattern.NAConverter; -import ch.qos.logback.access.pattern.PostContentConverter; import ch.qos.logback.access.pattern.RemoteHostConverter; import ch.qos.logback.access.pattern.RemoteIPAddressConverter; import ch.qos.logback.access.pattern.RemoteUserConverter; @@ -93,6 +92,9 @@ defaultConverterMap.put("reqCookie", RequestCookieConverter.class.getName()); defaultConverterMap.put("responseHeader", ResponseHeaderConverter.class.getName()); defaultConverterMap.put("reqParameter", RequestParameterConverter.class.getName()); + + + defaultConverterMap.put("n", LineSeparatorConverter.class.getName()); } public PatternLayout() { @@ -116,7 +118,9 @@ if(tail == null) { head = newLineConverter; } else { - tail.setNext(newLineConverter); + if (!(tail instanceof LineSeparatorConverter)) { + tail.setNext(newLineConverter); + } } setContextForConverters(head); }

1 0

svn commit: r623 - in logback/trunk/logback-access/src/main/java/ch/qos/logback/access: jetty tomcat
by noreply.seb＠qos.ch 05 Oct '06

05 Oct '06

Author: seb Date: Thu Oct 5 10:04:26 2006 New Revision: 623 Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/jetty/RequestLogImpl.java logback/trunk/logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java Log: StatusPrinter.print is pretty useful, actually... Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/jetty/RequestLogImpl.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/jetty/RequestLogImpl.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/jetty/RequestLogImpl.java Thu Oct 5 10:04:26 2006 @@ -14,6 +14,7 @@ import ch.qos.logback.core.spi.AppenderAttachable; import ch.qos.logback.core.spi.AppenderAttachableImpl; import ch.qos.logback.core.status.ErrorStatus; +import ch.qos.logback.core.util.StatusPrinter; /** * This class is logback's implementation of jetty's RequestLog interface. @@ -107,7 +108,7 @@ JoranConfigurator jc = new JoranConfigurator(); jc.setContext(this); jc.doConfigure(filename); - //StatusPrinter.print(getStatusManager()); + StatusPrinter.print(getStatusManager()); } else { getStatusManager().add( new ErrorStatus("[" + filename + "] does not exist", this)); Modified: logback/trunk/logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java ============================================================================== --- logback/trunk/logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java (original) +++ logback/trunk/logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java Thu Oct 5 10:04:26 2006 @@ -23,6 +23,7 @@ import ch.qos.logback.core.spi.FilterAttachableImpl; import ch.qos.logback.core.status.ErrorStatus; import ch.qos.logback.core.status.StatusManager; +import ch.qos.logback.core.util.StatusPrinter; /** * This class is an implementation of tomcat's Valve interface, by extending @@ -112,7 +113,7 @@ JoranConfigurator jc = new JoranConfigurator(); jc.setContext(this); jc.doConfigure(filename); - // StatusPrinter.print(getStatusManager()); + StatusPrinter.print(getStatusManager()); } else { getStatusManager().add( new ErrorStatus("[" + filename + "] does not exist", this));

1 0