[ http://jira.qos.ch/browse/LBCLASSIC-46?page=com.atlassian.jira.plugin.system... ] Joern Huxhorn edited comment on LBCLASSIC-46 at 10/29/08 2:14 PM: ------------------------------------------------------------------ Oh, that was a misunderstanding. I didn't mean that the stacktrace shouldn't be reduced, I wanted to suggest to just drop the information message about the dropped frames because it wouldn't fit into a StackTraceElementProxy so it couldn't be added anymore in my example above. Alternatively, we could add an additional int omittedFrames to contain info about the number of omitted frames. What I'd really like to have is the raw data so I can access the different field without additional processing. was (Author: jhuxhorn): Oh, that was a misunderstanding. I didn't mean that the stacktrace shouldn't be reduced, I wanted to suggest to just drop the information message about the dropped frames because it wouldn't fit into a StackTraceElementProxy so it couldn't be added anymore in my example above. Alternatively, we could add an additional int omittedFrames to contain info abou the number of omitted frames. What I'd really like to have is the raw data so I can access the different field without additional processing.
ThrowableInformation should keep the Throwable cause hierarchy intact. ----------------------------------------------------------------------
Key: LBCLASSIC-46 URL: http://jira.qos.ch/browse/LBCLASSIC-46 Project: logback-classic Issue Type: Improvement Components: Other Affects Versions: unspecified Environment: Operating System: All Platform: All Reporter: Joern Huxhorn Assignee: Ceki Gulcu Priority: Minor
Instead of a String representation of the whole Throwable stack trace incl. cause ThrowableInformation should instead look like this: public class ThrowableInformation implements Serializable { String throwableClassName; String message; StackTraceElement[] stackTrace; ThrowableInformation cause; } I omitted get/set and private in this example. StackTraceElement is perfectly Serializable and did also receive a public c'tor in Java 5 so I guess that the current ThrowableInformation is more or less a relict of log4j which had to stay compatible with older Java versions. You could obviously keep the getThrowableStrRep() method for compatibility. This bug is somewhat related to LBCLASSIC-45 because I think that ThrowableInformation should also, as LoggingEvent, be just a dumb data container with no real logic. The logic to extract the relevant StackTraceElements should IMHO be moved either into Logger or into a static factory method of ThrowableInformation.
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira