[ http://jira.qos.ch/browse/LBCLASSIC-46?page=com.atlassian.jira.plugin.system... ] Ceki Gulcu commented on LBCLASSIC-46: ------------------------------------- The 'x commons framed omitted' helps to significantly reduce the number of printed stack lines for nested exceptions. However, I don't think the nested ThrowableProxy structure you propose precludes the calculation of commons frames.
ThrowableInformation should keep the Throwable cause hierarchy intact. ----------------------------------------------------------------------
Key: LBCLASSIC-46 URL: http://jira.qos.ch/browse/LBCLASSIC-46 Project: logback-classic Issue Type: Improvement Components: Other Affects Versions: unspecified Environment: Operating System: All Platform: All Reporter: Joern Huxhorn Assignee: Ceki Gulcu Priority: Minor
Instead of a String representation of the whole Throwable stack trace incl. cause ThrowableInformation should instead look like this: public class ThrowableInformation implements Serializable { String throwableClassName; String message; StackTraceElement[] stackTrace; ThrowableInformation cause; } I omitted get/set and private in this example. StackTraceElement is perfectly Serializable and did also receive a public c'tor in Java 5 so I guess that the current ThrowableInformation is more or less a relict of log4j which had to stay compatible with older Java versions. You could obviously keep the getThrowableStrRep() method for compatibility. This bug is somewhat related to LBCLASSIC-45 because I think that ThrowableInformation should also, as LoggingEvent, be just a dumb data container with no real logic. The logic to extract the relevant StackTraceElements should IMHO be moved either into Logger or into a static factory method of ThrowableInformation.
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira