Branch: refs/heads/useContextExecutorService Home: https://github.com/qos-ch/logback Commit: 64971049c80e8700506373b2fbb65541a704436e https://github.com/qos-ch/logback/commit/64971049c80e8700506373b2fbb65541a70... Author: Carl Harris <ceharris@vt.edu> Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M logback-core/src/main/java/ch/qos/logback/core/net/server/ServerSocketAppenderBase.java Log Message: ----------- ServerSocketAppenderBase now uses ExecutorService from context If the appender does not have a thread pool configuration, we now use the context's ExecutorService instead of creating a new one based on the default ThreadPoolConfiguration. Commit: 9e06b6be7e6bace591dac20373a51eed59264ad2 https://github.com/qos-ch/logback/commit/9e06b6be7e6bace591dac20373a51eed592... Author: Carl Harris <ceharris@vt.edu> Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M logback-core/src/test/java/ch/qos/logback/core/net/server/InstrumentedServerSocketAppenderBase.java A logback-core/src/test/java/ch/qos/logback/core/net/server/MockExecutorService.java R logback-core/src/test/java/ch/qos/logback/core/net/server/MockThreadPoolFactoryBean.java M logback-core/src/test/java/ch/qos/logback/core/net/server/ServerSocketAppenderBaseTest.java Log Message: ----------- updated tests to validate that context's executor is not shut down In ServerSocketAppenderBase.stop, we must not shut down the executor service if it is the context's executorService. We only shut down an executor that we created specifically for this appender. Commit: e84874634c30889af380671811345fba4ab15dd2 https://github.com/qos-ch/logback/commit/e84874634c30889af380671811345fba4ab... Author: Carl Harris <ceharris@vt.edu> Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M logback-classic/src/main/java/ch/qos/logback/classic/net/SocketRemote.java Log Message: ----------- SocketRemote now uses ExecutorService from context The SocketRemote component doesn't want/need to allow the user to provide a thread pool configuration, anyway, so we might as well use the executor service provided by the context instead of creating our own. Commit: bbd4100e30cd6b2fbd5fce80bf6031fd6ae0e4ad https://github.com/qos-ch/logback/commit/bbd4100e30cd6b2fbd5fce80bf6031fd6ae... Author: Carl Harris <ceharris@vt.edu> Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M logback-classic/src/test/java/ch/qos/logback/classic/net/SocketRemoteTest.java Log Message: ----------- modified SocketRemoteTest to validate executor service shutdown behavior If a subclass provides a custom executor, we want to shut it down, but if the context's executor is used, we must not shut it down. The revised test covers both cases. Commit: d35ea443e333486a69506a8ff660071790d819bf https://github.com/qos-ch/logback/commit/d35ea443e333486a69506a8ff660071790d... Author: Carl Harris <ceharris@vt.edu> Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M logback-classic/src/main/java/ch/qos/logback/classic/net/server/SocketServer.java Log Message: ----------- SocketServer now uses ExecutorService from context If the server has no thread pool configuration, the context's executor service is now used by default. Compare: https://github.com/qos-ch/logback/compare/64971049c80e^...d35ea443e333