I'm grateful for the clean build efforts. I can also relate to the frustration when spending time on ancillary stuff. I wanted to see if I could do 10 clean builds in a row, using commit 8b0f18fa95a87b60aab070c388d55b9825e49c6c. I just did 'mvn clean; mvn install' ten times. Nine of the ten completed with success. Only my 4th build had trouble, with "ch.qos.logback.core.appender.FileAppenderTest". I pasted the results below. In any case, this is a significant improvement to build stability, and it will let me move on. I also think this has great value to others who might want to contribute code to the project too. A functioning build process is needed when starting out. So for your bit of diversion I say, "Thank you". Broc build 1: [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Logback-Parent .................................... SUCCESS [0.340s] [INFO] Logback Core Module ............................... SUCCESS [29.637s] [INFO] Logback Classic Module ............................ SUCCESS [21.184s] [INFO] Logback Access Module ............................. SUCCESS [4.256s] [INFO] Logback Site ...................................... SUCCESS [0.800s] [INFO] Logback Examples Module ........................... SUCCESS [1.430s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 58.167s [INFO] Finished at: Wed Apr 17 10:36:18 EDT 2013 [INFO] Final Memory: 61M/212M [INFO] ------------------------------------------------------------------------ build 2: [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Logback-Parent .................................... SUCCESS [0.266s] [INFO] Logback Core Module ............................... SUCCESS [28.242s] [INFO] Logback Classic Module ............................ SUCCESS [19.011s] [INFO] Logback Access Module ............................. SUCCESS [3.938s] [INFO] Logback Site ...................................... SUCCESS [0.712s] [INFO] Logback Examples Module ........................... SUCCESS [1.324s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 54.061s [INFO] Finished at: Wed Apr 17 10:39:47 EDT 2013 [INFO] Final Memory: 63M/291M [INFO] ------------------------------------------------------------------------ build 3: [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Logback-Parent .................................... SUCCESS [0.241s] [INFO] Logback Core Module ............................... SUCCESS [28.453s] [INFO] Logback Classic Module ............................ SUCCESS [19.244s] [INFO] Logback Access Module ............................. SUCCESS [4.027s] [INFO] Logback Site ...................................... SUCCESS [0.710s] [INFO] Logback Examples Module ........................... SUCCESS [1.314s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 54.585s [INFO] Finished at: Wed Apr 17 10:41:46 EDT 2013 [INFO] Final Memory: 62M/269M [INFO] ------------------------------------------------------------------------ build 4: [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Logback-Parent .................................... SUCCESS [0.242s] [INFO] Logback Core Module ............................... FAILURE [27.591s] [INFO] Logback Classic Module ............................ SKIPPED [INFO] Logback Access Module ............................. SKIPPED [INFO] Logback Site ...................................... SKIPPED [INFO] Logback Examples Module ........................... SKIPPED [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 28.354s [INFO] Finished at: Wed Apr 17 10:42:48 EDT 2013 [INFO] Final Memory: 27M/313M [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2. 12.4:test (default-test) on project logback-core: There are test failures. [ERROR] ------------------------------------------------------------------------------- Test set: ch.qos.logback.core.appender.FileAppenderTest ------------------------------------------------------------------------------- Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.308 sec <<< FAILURE! testCreateParentFolders(ch.qos.logback.core.appender.FileAppenderTest) Time elapsed: 0.001 sec <<< FAILURE! java.lang.AssertionError: failed to delete C:\gitrepo\logback\logback-core\target\test-output\fat631734906 at org.junit.Assert.fail(Assert.java:93) at org.junit.Assert.assertTrue(Assert.java:43) at ch.qos.logback.core.appender.FileAppenderTest.testCreateParentFolders(FileAppenderTest.java:93) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222) at org.junit.runners.ParentRunner.run(ParentRunner.java:300) at org.junit.runners.Suite.runChild(Suite.java:128) at org.junit.runners.Suite.runChild(Suite.java:24) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334) at java.util.concurrent.FutureTask.run(FutureTask.java:166) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) at java.lang.Thread.run(Thread.java:722) smoke(ch.qos.logback.core.appender.FileAppenderTest) Time elapsed: 0.029 sec testPrudentModeLogicalImplications(ch.qos.logback.core.appender.FileAppenderTest) Time elapsed: 0.069 sec testNewAppender(ch.qos.logback.core.appender.FileAppenderTest) Time elapsed: 0.011 sec testConfiguredAppender(ch.qos.logback.core.appender.FileAppenderTest) Time elapsed: 0.002 sec testNoStart(ch.qos.logback.core.appender.FileAppenderTest) Time elapsed: 0 sec build 5: [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Logback-Parent .................................... SUCCESS [0.263s] [INFO] Logback Core Module ............................... SUCCESS [29.218s] [INFO] Logback Classic Module ............................ SUCCESS [19.913s] [INFO] Logback Access Module ............................. SUCCESS [4.036s] [INFO] Logback Site ...................................... SUCCESS [0.756s] [INFO] Logback Examples Module ........................... SUCCESS [1.357s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 56.078s [INFO] Finished at: Wed Apr 17 10:46:56 EDT 2013 [INFO] Final Memory: 63M/291M [INFO] ------------------------------------------------------------------------ build 6: [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Logback-Parent .................................... SUCCESS [0.283s] [INFO] Logback Core Module ............................... SUCCESS [28.330s] [INFO] Logback Classic Module ............................ SUCCESS [19.198s] [INFO] Logback Access Module ............................. SUCCESS [3.924s] [INFO] Logback Site ...................................... SUCCESS [0.717s] [INFO] Logback Examples Module ........................... SUCCESS [1.314s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 54.328s [INFO] Finished at: Wed Apr 17 10:48:27 EDT 2013 [INFO] Final Memory: 63M/290M [INFO] ------------------------------------------------------------------------ build 7: [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Logback-Parent .................................... SUCCESS [0.309s] [INFO] Logback Core Module ............................... SUCCESS [29.081s] [INFO] Logback Classic Module ............................ SUCCESS [19.194s] [INFO] Logback Access Module ............................. SUCCESS [4.013s] [INFO] Logback Site ...................................... SUCCESS [0.720s] [INFO] Logback Examples Module ........................... SUCCESS [1.297s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 55.167s [INFO] Finished at: Wed Apr 17 10:49:54 EDT 2013 [INFO] Final Memory: 62M/315M [INFO] ------------------------------------------------------------------------ build 8: [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Logback-Parent .................................... SUCCESS [0.275s] [INFO] Logback Core Module ............................... SUCCESS [28.663s] [INFO] Logback Classic Module ............................ SUCCESS [19.419s] [INFO] Logback Access Module ............................. SUCCESS [3.947s] [INFO] Logback Site ...................................... SUCCESS [0.769s] [INFO] Logback Examples Module ........................... SUCCESS [1.240s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 54.915s [INFO] Finished at: Wed Apr 17 10:51:30 EDT 2013 [INFO] Final Memory: 65M/291M [INFO] ------------------------------------------------------------------------ build 9: [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Logback-Parent .................................... SUCCESS [0.288s] [INFO] Logback Core Module ............................... SUCCESS [29.104s] [INFO] Logback Classic Module ............................ SUCCESS [20.182s] [INFO] Logback Access Module ............................. SUCCESS [4.055s] [INFO] Logback Site ...................................... SUCCESS [0.707s] [INFO] Logback Examples Module ........................... SUCCESS [1.279s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 56.194s [INFO] Finished at: Wed Apr 17 10:53:27 EDT 2013 [INFO] Final Memory: 65M/421M [INFO] ------------------------------------------------------------------------ build 10: [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Logback-Parent .................................... SUCCESS [0.260s] [INFO] Logback Core Module ............................... SUCCESS [28.505s] [INFO] Logback Classic Module ............................ SUCCESS [19.856s] [INFO] Logback Access Module ............................. SUCCESS [4.163s] [INFO] Logback Site ...................................... SUCCESS [0.738s] [INFO] Logback Examples Module ........................... SUCCESS [1.359s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 55.467s [INFO] Finished at: Wed Apr 17 10:54:53 EDT 2013 [INFO] Final Memory: 64M/291M [INFO] ------------------------------------------------------------------------ On Wed, Apr 17, 2013 at 10:28 AM, ceki <ceki@qos.ch> wrote:
It sounds pretty pathetic to make a big deal out of clean builds. However, getting all the tests to pass consistently has proven to be a big challenge. Frustratingly enough, none of the failures have to do anything with the "actual" logback code but with test code.
On 17.04.2013 15:34, Donald McLean wrote:
"and there was much rejoicing."
On Wed, Apr 17, 2013 at 9:32 AM, ceki <ceki@qos.ch <mailto:ceki@qos.ch>>
wrote:
Hi all,
In light of recent improvements in the test suite, we had a streak of of 18 successive clean builds by Jenkins. It ended with a failure in ch.qos.logback.classic.net <http://ch.qos.logback.**classic.net<http://ch.qos.logback.classic.net>
.__SMTPAppender_**GreenTest.__testMultipleTo
[1].
In any case, we are making progress.
[1] http://logback.qos.ch/jenkins/**__job/logback/91/<http://logback.qos.ch/jenkins/__job/logback/91/>
<http://logback.qos.ch/**jenkins/job/logback/91/<http://logback.qos.ch/jenkins/job/logback/91/>
-- Ceki 65% of statistics are made up on the spot
-- Ceki 65% of statistics are made up on the spot ______________________________**_________________ logback-dev mailing list logback-dev@qos.ch http://mailman.qos.ch/mailman/**listinfo/logback-dev<http://mailman.qos.ch/mailman/listinfo/logback-dev>