[ http://jira.qos.ch/browse/LBCLASSIC-188?page=com.atlassian.jira.plugin.syste... ] Ceki Gulcu edited comment on LBCLASSIC-188 at 3/19/10 12:05 AM: ---------------------------------------------------------------- You can see the result of merging your contribution and my proposed simplifications to the DBNameResolver interface at: http://github.com/ceki/logback/tree/dbname The only downside I can see is that your version of CustomDBNameResolver was fully configurable via a config file while my version cannot be configured via an XML config file but it can be configured programmatically. If configuration via XML config file is required, then we can work something out. By the way, since your contribution is on the substantial side, could you please sign the ICLA ? It can be found at: http://logback.qos.ch/cla.txt was (Author: noreply.ceki@qos.ch): You can see the result of merging your contribution and my proposed simplifications to the DBNameResolver interface at: http://github.com/ceki/logback/tree/dbname The only downside I can see is that your version of CustomDBNameResolver was fully configurable via a config file while my version cannot be configured via an XML config file but it can be configured programmatically. If configuration via XML config file is required, then we can work something out.
Make table and column names overridable ---------------------------------------
Key: LBCLASSIC-188 URL: http://jira.qos.ch/browse/LBCLASSIC-188 Project: logback-classic Issue Type: Sub-task Components: appender Affects Versions: 0.9.18 Reporter: Ceki Gulcu Assignee: Logback dev list
To comply with local project rules, it can be helpful if the table and column names used by DBAppender could be overridden. The easiest way to solve this problem is for DBAppender to delegate the resolution of table names and columns to a different class, say DBNameResolver. Here is a possible interface: interface DBNameResolver { String getTableName(String standardTableName); String getColumnName(String standardColumnName); } The default implementation of DBNameResolver could be: class DefaulDBNameResolver implements DBNameResolver { public String getTableName(String standardTableName) { if("logging_event".equals(standardTableName) { return standardTableName; } if("logging_event_property".equals(standardTableName) { return standardTableName; } if("logging_event_exception".equals(standardTableName) { return standardTableName; } throw new IllegalArgumentException(standardTableName + " is an unknown table name"); } String getColumnName(String standardColumnName) { ... } } If a user wanted to use different names she would simply implement DBNameResolver according to her requirements. Any volunteers to implement this?
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira