Totally agree. The change in c96dde9 did fix LOGBACK-873, but it took a shortcut because the deciding factor should be if a log level is enabled. Lazy initialization is fine in this context, but the framework has no control over how `toString()` is implemented: IO operations, synchronizations, etc. It's just safer to not invoke an external method while holding a lock. |