[ http://jira.qos.ch/browse/LBCORE-41?page=com.atlassian.jira.plugin.system.is... ] David Vallner commented on LBCORE-41: ------------------------------------- I think the hard limit on window size should be removed altogether or replaced with a warning instead of the library just doing something else than I tell it to. Libraries shouldn't establish policy, that's up to my customer's requirements, if their choice ends up lagging them to all hell, so be it. Alternately, it should be made possible to use size triggering with time rolling, so I can have my 100 log files of 5 MB if I want to.
FixedWindowRollingPolicy MAX_WINDOW_SIZE too small? ---------------------------------------------------
Key: LBCORE-41 URL: http://jira.qos.ch/browse/LBCORE-41 Project: logback-core Issue Type: Improvement Components: Rolling Affects Versions: unspecified Environment: Operating System: Windows Platform: All Reporter: Mike Mansell Assignee: Logback dev list Priority: Minor
I know it's not a blog but let me first say I've switched from log time use of JCL / log4j and think SLF4J / Logback is awesome so kudos to you guys for getting this out here... simple and powerful.. not much to not like ;-) I'm curious as to why a window size as small as 12 was chosen here. I realize the renaming of all files within the window gets more expensive as the window increases but it seems prohibitive for people with larger logging requirements. Moreover, the fact that it is final means I can't override this either although I realize it is rather trivial to build my own implementation. I have a project that generates a tremendous amount of logging currently (about 100MB every 6 minutes) and in my current setup have issues with files over 2GB. With the current MAX_WINDOW_SIZE I can only keep a days worth of logs! If the rename is a big deal a rolling policy that just uses the index as a cyclic sequence should work fine or are there other reasons to cap this at something so low? I could submit an implementation back if you like but just curious to get your feedback and any reasoning I might be missing on keeping the window size so low. Thanks again for a great product!
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira