[ http://jira.qos.ch/browse/LBCLASSIC-234?page=com.atlassian.jira.plugin.syste... ] Ceki Gulcu commented on LBCLASSIC-234: -------------------------------------- Hello Uri, The fact that scanning reduces throughput by 50% is rather disturbing. Can you test throughput of your application with line 107 of ReconfigureOnChangeFilter changed from: if (((invocationCounter++) & 0xF) != 0xF) { to: if (((invocationCounter++) & 0xFFFF) != 0xFFFF) { Do you see a noticeable difference? BTW, what is your target OS?
CLONE -Excessive synchronization in ReconfigureOnChangeFilter.decide --------------------------------------------------------------------
Key: LBCLASSIC-234 URL: http://jira.qos.ch/browse/LBCLASSIC-234 Project: logback-classic Issue Type: Bug Affects Versions: 0.917 Reporter: uri unger Assignee: Ceki Gulcu Priority: Critical Attachments: screenshot-1.jpg
The synchronization in ReconfigureOnChangeFilter.decide hurts scalability. It seems unnecessary to serialize the code in changeDetected -- it should be possible to use atomic updates of nextCheck and lastModified and only serialize the actual reconfiguration.
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira