Hello Karl, I've looked through the history of the LogbackView class, and I couldn't find the Table I wrote first, where each lines where split into cells, each one displaying one of the attribute of the LoggingEvent object. I think I must have written it on some mini- project, more of a POC than a real first implementation. In the SVN[1] I could find the previous version of the LogbackView, which was made with a MessageConsoleView extension. However, you could take a look at the current version, which uses a virtual Table. If you see any optimizable parts, (and there certainly are a few!), do not hesitate to tweak the plugin and send me a patch, I'll test it gladly. Cheers, Sébastien [1] http://svn.qos.ch/viewvc/logbackPDE/trunk/plugins/ConsolePlugin Le 1 déc. 07 à 19:48, Karl Pietrzak a écrit :
On Dec 1, 2007 12:28 PM, Sébastien Pennec <sebastien@qos.ch> wrote: Hello Karl,
Thanks for your interest! :-)
My pleasure!
It may be in the repository, but it certainly is burried deep. I'll search for it tomorrow in afternoon and send any link.
Thank you very much! I'll take a crack at it as soon as you get a chance to send a link.
The first thing I tried was to build a Table with each column being a LoggingEvent attribute. And that rendered very slowly. The actual version is a TableViewer which contains only one column, filled with the result of the PatternLayout's formatting.
Sébastien
Le 1 déc. 07 à 17:33, Karl Pietrzak a écrit :
Hello again, Sébastien!
On Nov 23, 2007 1:18 PM, Sébastien Pennec <sebastien@qos.ch> wrote: Hello Karl,
The performance problem was clearly seen during the refresh of the view. When I sent many logs to the view, they were appearing slowly, and the redraw of the view was taking ages… I cannot give you precise numbers, because the speed of the refresh was obviously too slow.
I remember you mentioning a performance issue with using SWT Table. I know you're busy, but if you get the chance, would you send me the code (or is it in source control already somewhere) so I could see if I could optimize it?
Let me know, thanks! =)
Le 23 nov. 07 à 07:45, Karl Pietrzak a écrit :
Thanks for the reply, Sébastien!
On Nov 22, 2007 4:54 PM, Sébastien Pennec < sebastien@qos.ch> wrote: Hello Karl and Maarten,
It's great to see that you both are interested in improving the console plugin!
Using a Table has been the first thing that I tried when I began writing the plugin, and I had a big performance issue. It was much slower than a simple console view.
Could you elaborate on the performance issues? If I'm understanding you correctly, the issue is the log events are taking a while to appear in the console view. What kind of time are we talking about? 500 milliseconds?
Do you think that we can code a plugin that uses a Table and that is as fast as a console to display logging events? As you might imagine, performance is a priority, since the plugin needs to display events even when they are recieved at a very fast pace. My goal was to be as fast as the console view.
Maarten, thanks for the link to Vigilog, I'll take a look at it soon.
Cheers,
Sébastien
Le 22 nov. 07 à 14:28, Maarten Bosteels a écrit :
Hello Karl,
I am not working on the Logback Console Plugin, but I agree that a JTable would be much better than just text.
But instead of enhancing the current plugin, this is what I had in mind: * enhance vigilog [1] in several ways (ability to taill a log- file, to receive logging events over a socket, ...) * create a plugin for Eclipse and for IntelliJ IDEA that listens on a socket for commands like "goto:org.some.package.MyCoolClass :172" => plugin will then open an editor window for the specified class and line * vigilog could then create hyperlinks for all logging events that have a locationInfo and for stacktraces
This way, we can concentrate on enhancing vigilog and both eclipse and idea users benefit.
Note that I am not yet a vigilog contributor, and it could take a long time before all this is accomplished. Just wanted to let you know what I have in mind.
And if you want to add a JTable to the Console Plugin, it might be interesting to have a look at the vigilog source code. It uses glazedlists and JxTable.
[1] http://vigilog.sourceforge.net/
Regards Maarten
On Nov 22, 2007 4:27 AM, Karl Pietrzak < kap4020@gmail.com> wrote: Hey everyone!
Logback looks awesome! Is anyone (besides me) interested in having a Table instead of List in the Logback Console Plugin?
I'm thinking about spending some time on this. Anyone wanna join me? (e.g., I'll add Table support and someone else does sorting- by- column?)
Thanks, and keep up the great work! _______________________________________________ logback-dev mailing list logback-dev@qos.ch http://qos.ch/mailman/listinfo/logback-dev
_______________________________________________ logback-dev mailing list logback-dev@qos.ch http://qos.ch/mailman/listinfo/logback-dev
_______________________________________________ logback-dev mailing list logback-dev@qos.ch http://qos.ch/mailman/listinfo/logback-dev
_______________________________________________ logback-dev mailing list logback-dev@qos.ch http://qos.ch/mailman/listinfo/logback-dev
_______________________________________________ logback-dev mailing list logback-dev@qos.ch http://qos.ch/mailman/listinfo/logback-dev
_______________________________________________ logback-dev mailing list logback-dev@qos.ch http://qos.ch/mailman/listinfo/logback-dev
_______________________________________________ logback-dev mailing list logback-dev@qos.ch http://qos.ch/mailman/listinfo/logback-dev
_______________________________________________ logback-dev mailing list logback-dev@qos.ch http://qos.ch/mailman/listinfo/logback-dev