[ http://jira.qos.ch/browse/LBACCESS-12?page=com.atlassian.jira.plugin.system.... ] Joern Huxhorn commented on LBACCESS-12: --------------------------------------- Small clarification: It would be ideal if the AccessEventVO would give me the ability to set the data manually. The current AccessEvent(HttpServletRequest httpRequest, HttpServletResponse httpResponse, ServerAdapter adapter) c'tor is scraping all the data from the parameters itself. It would be nice - but not necessary! - if setters would be available and a default c'tor would be provided. Otherwise I'd have to reimplement my own IAccessEvent. Again, I'd have no problem doing so, provided that this interface is created and that the formatter is expecting that interface instead of AccessEvent. I just wanted to clarify the rationale behind this request. I just realized that I may be able to work around this but the result would get quite ugly...

Please add IAccessEvent (and AccessEventVO) similar to the LoggingEvent counterparts ------------------------------------------------------------------------------------

Key: LBACCESS-12 URL: http://jira.qos.ch/browse/LBACCESS-12 Project: logback-access Issue Type: Improvement Affects Versions: 0.9.20 Reporter: Joern Huxhorn Assignee: Logback dev list

I'm currently implementing "cat" functionality for Lilith data files, i.e. events stored in Lilith data files can be printed using ch.qos.logback.classic.PatternLayout and ch.qos.logback.access.PatternLayout. This works for LoggingEvent since I could implement a iLoggingEvent wrapper for my own LoggingEvent. It does not work for AccessEvent, though, because there is no IAccessEvent interface and I can't instantiate AccessEvent and set the properties manually. ch.qos.logback.access.PatternLayout is currently working on an AccessEvent and I'd like to use it's functionality.

-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.qos.ch/browse/LBACCESS-12?page=com.atlassian.jira.plugin.system.... ] Ceki Gulcu commented on LBACCESS-12: ------------------------------------ Hi Joern, Is the proper solution to the above problem to introduce IAccessEvent so that logback-access classes are parameterized with IAccessEvent instead of AccessEvent? For example, public class SMTPAppender extends SMTPAppenderBase<AccessEvent> would be modified to: public class SMTPAppender extends SMTPAppenderBase<IAccessEvent> Would you want to make this change in github so that I could later merge it?

Please add IAccessEvent (and AccessEventVO) similar to the LoggingEvent counterparts ------------------------------------------------------------------------------------

Key: LBACCESS-12 URL: http://jira.qos.ch/browse/LBACCESS-12 Project: logback-access Issue Type: Improvement Affects Versions: 0.9.20 Reporter: Joern Huxhorn Assignee: Logback dev list

I'm currently implementing "cat" functionality for Lilith data files, i.e. events stored in Lilith data files can be printed using ch.qos.logback.classic.PatternLayout and ch.qos.logback.access.PatternLayout. This works for LoggingEvent since I could implement a iLoggingEvent wrapper for my own LoggingEvent. It does not work for AccessEvent, though, because there is no IAccessEvent interface and I can't instantiate AccessEvent and set the properties manually. ch.qos.logback.access.PatternLayout is currently working on an AccessEvent and I'd like to use it's functionality.

-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.qos.ch/browse/LBACCESS-12?page=com.atlassian.jira.plugin.system.... ] Ceki Gulcu commented on LBACCESS-12: ------------------------------------ You can fix LBCLASSIC-257 along with your changes for LBACCESS-12 (this issue).

Please add IAccessEvent (and AccessEventVO) similar to the LoggingEvent counterparts ------------------------------------------------------------------------------------

Key: LBACCESS-12 URL: http://jira.qos.ch/browse/LBACCESS-12 Project: logback-access Issue Type: Improvement Affects Versions: 0.9.20 Reporter: Joern Huxhorn Assignee: Logback dev list

I'm currently implementing "cat" functionality for Lilith data files, i.e. events stored in Lilith data files can be printed using ch.qos.logback.classic.PatternLayout and ch.qos.logback.access.PatternLayout. This works for LoggingEvent since I could implement a iLoggingEvent wrapper for my own LoggingEvent. It does not work for AccessEvent, though, because there is no IAccessEvent interface and I can't instantiate AccessEvent and set the properties manually. ch.qos.logback.access.PatternLayout is currently working on an AccessEvent and I'd like to use it's functionality.

-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira